| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
Bitfield is similar to unsigned
integer. I also added a test.
Tested on amani, jam, linew.
|
| |
|
|\
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Bring r18109 from trunk to 1.8 branch:
Bring r18076-18096 from hdf5_1_8_coverity branch to trunk:
r18076:
Correct Coverity issue #1 by removing dead code
r18077:
Fix coverity item 142. When an error occurred while copying a linked list in
H5S_point_copy, the library would not free the partially allocated list. Added
code to free the list in this case.
r18078:
Correct Coverity issue #2 by removing impossible to reach code.
r18079:
Correct #3 by removing impossible to reach code.
r18080:
Correct Coverity issue #4 by removing impossible to reach code.
r18081:
fix coverity 26 , check (dblik->parent) before calls H5HF_man_iblock_detach().
r18082:
Fixed coverity issues 321 and 316.
321: freed sm_buf in error handling to remove resource leak.
Also set sm_buf to NULL after other instances in which
it is freed to prevent double free.
316: initialized nmembs to 0.
r18083:
Correct Coverity issue #6 by removing debugging knob from error reporting code.
r18084:
Fix coverity item 269 + others. When a error occurred in a function using the
h5tools error framework, the "past_catch" variable would not be set to true
because that statement was before the label that goto jumped to. This could
cause a failure in the cleanup section to go back to the start of the section,
freeing variables twice, etc.
Moved the label infront of past_catch=TRUE.
r18085:
fixed coverity #27, check if (heap) before use heap->obj....
r18086:
fixed coverity #28, check curr_span not null before use it at if(curr_span &&
(io_bytes_left==0 || curr_seq>=maxseq))
r18087:
Correct Coverity issue #7 by cleaning up correctly on error
r18088:
Correct Coverity #8 by removing unchanged variable checking code.
r18089:
Correct Coverity issue #9 - remove impossible to reach code.
r18090:
Correct Coverity issue #11 by removing impossible to reach code. Also clean
up some minor style issues.
r18091:
Fix coverity items 314 and 318. Changed the improper assertion of the return
value of a library function to a check, and a return(void) on failure.
r18092:
Fix coverity item 70. Changed the improper assertion of the return value of a
library function to a check, and a return(void) on failure.
r18093:
Correct Coverity issue #12 by removing dead code.
r18094:
Correct Coverity issue #16 by removing debugging code.
r18095:
Fixed coverity issue # 271.
Removed redundant checking and freeing of sm_buf1 and sm_buf2.
r18096:
Correct Coverity issue #17 by refactoring test to remove dead code.
Also, removed previous "coverity" statements in comments, we'll review
those issues again and see if we can figure them out, now that we have more
experience with Coverity.
Tested on:
Mac OS X/32 10.6.2 (amazon) debug & prod
|
| |
| |
| |
| |
| |
| |
| | |
Correct Coverity issue #17 by refactoring test to remove dead code.
Tested on:
Mac OS X/32 10.6.2 (amazon) w/debug
|
| |
| |
| |
| | |
Removed redundant checking and freeing of sm_buf1 and sm_buf2.
|
| |
| |
| |
| |
| |
| |
| | |
Correct Coverity issue #16 by removing debugging code.
Tested on:
Mac OS X/32 10.6.2 (amazon) w/debug
|
| |
| |
| |
| |
| |
| |
| | |
Correct Coverity issue #12 by removing dead code.
Tested on:
Mac OS X/32 10.6.3 (amazon) w/debug
|
| |
| |
| |
| |
| |
| |
| |
| | |
return value of a
library function to a check, and a return(void) on failure.
Tested: Fedora
|
| |
| |
| |
| |
| |
| |
| |
| | |
of the return
value of a library function to a check, and a return(void) on failure.
Tested: Fedora
|
| |
| |
| |
| |
| |
| |
| |
| | |
Correct Coverity issue #11 by removing impossible to reach code. Also clean
up some minor style issues.
Tested on:
Mac OS X/32 10.6.3 (amazon) w/debug
|
| |
| |
| |
| |
| |
| |
| | |
Correct Coverity issue #9 - remove impossible to read code.
Tested on:
Mac OS X/32 10.6.3 (amazon)
|
| |
| |
| |
| |
| |
| |
| | |
Correct Coverity #8 by removing unchanged variable checking code.
Tested on:
Mac OS X/32 10.6.3 (amazon) w/debug
|
| |
| |
| |
| |
| |
| |
| | |
Correct Coverity issue #7 by cleaning up correctly on error
Tested on:
Mac OS X/32 10.6.3 (amazon) w/debug
|
| |
| |
| |
| | |
if(curr_span && (io_bytes_left==0 || curr_seq>=maxseq))
|
| |
| |
| |
| | |
fixed coverity #27, check if (heap) before use heap->obj....
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
function using the
h5tools error framework, the "past_catch" variable would not be set to true
because that statement was before the label that goto jumped to. This could
cause a failure in the cleanup section to go back to the start of the section,
freeing variables twice, etc.
Moved the label infront of past_catch=TRUE.
Tested: Fedora
|
| |
| |
| |
| |
| |
| |
| |
| | |
Correct Coverity issue #6 by removing debugging knob from error reporting
code.
Tested on:
Mac OS X/32 10.6.3 (amazon) w/debug
|
| |
| |
| |
| |
| |
| |
| |
| | |
321: freed sm_buf in error handling to remove resource leak.
Also set sm_buf to NULL after other instances in which
it is freed to prevent double free.
316: initialized nmembs to 0.
|
| |
| |
| |
| |
| |
| |
| |
| | |
H5HF_man_iblock_detach().
line, and those below, will be ignored--
M src/H5HFdblock.c
|
| |
| |
| |
| |
| |
| |
| | |
Correct Coverity issue #4 by removing impossible to reach code.
Tested on:
Mac OS X/32 10.6.3 (amazon) w/debug
|
| |
| |
| |
| |
| |
| |
| | |
Correct #3 by removing impossible to reach code.
Tested on:
Mac OS X/32 10.6.2 (amazon) w/debug
|
| |
| |
| |
| |
| |
| |
| | |
Correct Coverity issue #2 by removing impossible to reach code.
Tested on:
Mac OS X/32 10.6.2 (amazon) w/debug
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
linked list in
H5S_point_copy, the library would not free the partially allocated list. Added
code to free the list in this case.
Tested: Fedora
|
| |
| |
| |
| |
| |
| |
| | |
Correct Coverity issue #1 by removing dead code
Tested on:
Mac OS X/32 (amazon) debug
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The mixed use of RUNTEST (original) and RUNTESTS (new) caused
confusion. E.g., the timings in test/ was still using the old
$RUNTEST. It made more sense to use $RUNTEST which is used
by the dejagnu feature of automake. So, I changed all
$RUNTEST or $RUNTESTS to $RUNEXEC.
config/commence.am & config/conclude.am are the two files
that got changes. Also fixed an error in test/Makefile.am.
The rest are changed by bin/reconfigure.
Tested: h5committested.
|
| |
| |
| |
| | |
Tested: windows
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Merged changes from trunk/fortran into the branch used:
svn merge -r 17682:18098 https://svn.hdfgroup.uiuc.edu/hdf5/trunk/fortran
Tested on: jam (intel)
amani (pgi)
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Bring r18072 from trunk to 1.8 branch:
Bring r18071 from metadata journaling merge branch:
Refactor local heap routines with changes from metadata journaling
branch, along with other misc. changes as the changes on the metadata journaling
branch are being converged with the current state of the trunk.
Tested on:
Mac OS X/32 10.6.2 (amazon) debug & prod
Linux/64 2.6 (amani) prod
FreeBSD/64 (liberty) prod
|
| |
| |
| |
| | |
Tested chkmanifest on jam.
|
| |
| |
| |
| |
| |
| |
| | |
Port to AIX 6.1 for RS6000. Should be the same as PowerPC based AIX.
Tested:
Blue-print of NCSA.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
was fixed in the
trunk in r17751, but was not ported to 1.8 because that feature (compress group
fheap) had not beed added to 1.8 yet. This fix should have been ported to the
cgfh branch at the time, but it was overlooked.
Tested: Fedora (too small for commit test)
|
| | |
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| | |
Description:
Fixed exit code (sometimes return code in Main) to follow the HDF5 standards.
Tested:
Jam, both serial and parallel.
|
| |
| |
| |
| | |
Checked by bin/chkmanifest.
|
| |
| |
| |
| |
| |
| |
| |
| | |
Description:
Fixed exit code (sometimes return code in Main) to follow the HDF5 standards.
Tested:
H5committested plus serial test in Jam.
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
hl/tools/gif2h5/testfiles
so that it has its own testfiles directory.
Tested:
h5committested.
|
| |
| |
| |
| |
| |
| |
| |
| | |
Description:
Some exit code (sometimes return code in Main) to follow the HDF5 standards.
Tested:
H5committested plus serial test in Jam.
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Bring r18045 from trunk to 1.8 branch:
Slush changes back & forth between trunk, the merging branch and the
metadata journaling branch to level them out to a reasonably common set of code
to work from for the next set of more significant changes.
Tested on:
FreeBSD/32 6.3 (duty) w/debug
(h5committested on trunk)
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Bring r18039 from trunk to 1.8 branch:
Minor code cleanups, to align better w/ongoing metadata journaling
convergence.
Tested on:
Mac OS X/32 10.6.2 (amazon) w/debug
(too minor to require h5committest)
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Bring r18037 from trunk to 1.8 branch:
Bring r18035 from merge_metadata_journaling branch to trunk:
More "brush clearing" convergence between metadata_journaling branch
and the trunk.
Tested on:
Linux/64-amd64 2.6 (amani) w/Intel compilers, w/default API=1.6.x,
w/C++ & FORTRAN, in production mode
(h5committested on trunk)
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Bring r18033 from trunk to 1.8 branch:
Correct error in merging Coverity changes in r18011
Tested on:
None - eyeballed only (very simple)
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Bring r18031 from trunk to 1.8 branch:
Bring r18030 from merge_metadata_journaling branch to trunk:
Bring "brush clearing" changes (whitespace & style issues, mostly) from
metadata_journaling branch to the "merging" branch, to converge the trunk and
the metadata_journaling branch.
Also, some other minor cleanups along the way.
Tested on:
FreeBSD/32 6.3 (duty) in debug mode
FreeBSD/64 6.3 (liberty) w/C++ & FORTRAN, in debug mode
(h5committested on trunk)
|
| |
| |
| |
| |
| |
| |
| |
| | |
(The test is in test_exit_definitions.) Their document says
it's supposed to be 2. I commented it out for further
consideration.
Tested on jam - simple change.
|
| |
| |
| |
| |
| |
| |
| |
| | |
were 2 identical calls to
the function H5Fopen.
Tested on jam and OpenVMS.
|
|/
|
|
| |
Tested v1.8.4 on OpenVMS.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Bring r18011 from trunk to 1.8 branch:
Bring Coverity changes into the trunk: (also other minor cleanups)
r17991:
Fix Coverity items 175 and 176. Fixed memory leak on error in print_enum in
H5LT.c.
r17993: (r17992 was not a Coverity change)
Close Coverity issue #206: inconsistently checking whether dt->shared was
non-NULL after H5T_alloc() returned a valid 'dt' value (which should guarantee
that dt->shared is valid).
r17994:
Fix Coverity item 149. Fixed file handle leak on error in H5FD_stdio_open.
r17995:
Fixed Coverity issues 154 to 161:
Added H5MP_close routine to error handling in the event *mp has not been
freed before error.
r17996:
Close Coverity issue #126: potentially leaking merged_spans on routine failure.
r17997:
Fix Coverity items 147 and 148. Fixed resource leaks on error in H5FDloc.c.
r17998:
Coverity issue 269-272:
Added integer result variable to functions that could return negative.
Assigned to unsigned after checking.
Added H5E_BEGIN_TRY block around H5Tclose and removed H5E_THROW in the
catch block.
Checked buffer is NULL before free. Changed HGOTO_ERROR outside of the if
block to H5E_THROW.
r17999:
Close Coverity issue #127: release temporary spans in more generic manner.
(Also add error checking to previous fix)
r18000:
Resolved Coverity issues 211 and 212 in H5T.c. Added comments to ignore
Coverity warning regarding not checking pointer for NULL, as we are using
an assert which catches the issue.
r18001:
Fix Coverity item 146. Fixed resource leak on error in H5O_layout_copy.
r18002:
Fix Coverity items 143 and 145. Fixed resource leaks on error in
H5D_compact_copy and H5D_contig_copy.
r18003:
Close Coverity issue #192: close file on error
r18004:
Fix Coverity issue #125: release temporary spans on error
r18005:
Resolved Coverity issues 5, 25, and 83 (in H5T.c):
Separated embedded functions in order to check for NULL on return of
H5I_object before passing into H5T_copy.
Check to see if new_dt is NULL within error handling before
dereferencing it.
Ignore Coverity's dead code warnings as the checks that lead to the code
are machine dependent.
r18006:
Coverity 63,70,73: Checked result of function before assigning to an unsigned
variable.
r18007:
Coverity 78,79: added continue statement if H5Pget_filter2 returns negative.
r18008:
Fixed Coverity issue # 138:
Added support in error handling to free dst pointer (if allocated) on error.
r18009:
Whitespace & coding style cleanup
Tested on:
Mac OS X/32 10.6.2 (amazon) w/debug & production
(h5committested on trunk)
|