| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Bring r18157 from trunk to 1.8 branch:
Bring back changes from Coverity session on 1/15/10:
r18111:
Fix Coverity issue #130: make certain that the cache gets freed on error.
r18112:
Fix Coverity issue #43 by making cache testing calls protected by 'pass'
variable.
r18113:
Fix Coverity issue #129 by releasing the cache on error.
r18115:
Coverity #45 fix: patched an error check in H5Screate_simple to prevent future dereferencing of a NULL point.
Added a verification in test/th5s.c.
r18116:
Fix Coverity issue #43 by releasing cache on error.
r18117:
Coverity #362,363 by adding HGOTO_DONE, freeing allocations and associated changes. REsolving coverity results #364-368, 369, 370-372, 377, 379, and 380.
r18118:
Fix Coverity issue #42: assert that cache & test specification pointer are
valid.
r18122:
Coverity #362,363 by adding HGOTO_DONE and freeing allocations. This also takes care of #357,358.
r18123:
Coverity #359-361, 373-376: Added HGOTO_DONE(FAIL) statement after checking allocation for NULL. Verified allocation is freed in done block.
r18128:
Fixed coverity issue #10 -- removed dead code.
Tested on:
Mac OS X/32 10.6.2 (amazon)
|
|
|
|
|
|
|
|
| |
GetTestVerbosity() is called many times during tests. Implemented a more
efficient macro version HDGetTestVerbosity.
Tested: Jam (serial and parallel). Did not run h5committest since this
is a trival change that is portable, I am 99% sure.
|
|
|
|
|
|
|
|
|
|
|
|
| |
Additional fix relted to the fix of bug1672.
Description:
The fix of bug1672 caused some changes of output which required modifying
some test cases. After some discussion, restoring the changes of the test
cases was decided. After many experiments for the solution, this fix was
made so the code which improved performance can stay.
Tested on Jam.
|
| |
|
|
|
|
|
|
|
| |
Add test case relate to bug1749. Also corrected command echo line which
is not match with actual test.
Tested on Jam.
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix for bug1749: Incorrect code in diff() function for links compare
Also removed duplicated redundant code, which improves performance.
Description:
When comparing file1 to file2 and both files contain same soft-links and/or
external-links, if file2's target object path name is longer than file1's
target object path name, the current code allocates memory buffer
incorrectly, so it could end up buffer overflow or wrong result.
Tested on Jam.
|
|
|
|
|
|
|
|
| |
Bitfield is similar to unsigned
integer. I also added a test.
Tested on amani, jam, linew.
|
| |
|
|\
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Bring r18109 from trunk to 1.8 branch:
Bring r18076-18096 from hdf5_1_8_coverity branch to trunk:
r18076:
Correct Coverity issue #1 by removing dead code
r18077:
Fix coverity item 142. When an error occurred while copying a linked list in
H5S_point_copy, the library would not free the partially allocated list. Added
code to free the list in this case.
r18078:
Correct Coverity issue #2 by removing impossible to reach code.
r18079:
Correct #3 by removing impossible to reach code.
r18080:
Correct Coverity issue #4 by removing impossible to reach code.
r18081:
fix coverity 26 , check (dblik->parent) before calls H5HF_man_iblock_detach().
r18082:
Fixed coverity issues 321 and 316.
321: freed sm_buf in error handling to remove resource leak.
Also set sm_buf to NULL after other instances in which
it is freed to prevent double free.
316: initialized nmembs to 0.
r18083:
Correct Coverity issue #6 by removing debugging knob from error reporting code.
r18084:
Fix coverity item 269 + others. When a error occurred in a function using the
h5tools error framework, the "past_catch" variable would not be set to true
because that statement was before the label that goto jumped to. This could
cause a failure in the cleanup section to go back to the start of the section,
freeing variables twice, etc.
Moved the label infront of past_catch=TRUE.
r18085:
fixed coverity #27, check if (heap) before use heap->obj....
r18086:
fixed coverity #28, check curr_span not null before use it at if(curr_span &&
(io_bytes_left==0 || curr_seq>=maxseq))
r18087:
Correct Coverity issue #7 by cleaning up correctly on error
r18088:
Correct Coverity #8 by removing unchanged variable checking code.
r18089:
Correct Coverity issue #9 - remove impossible to reach code.
r18090:
Correct Coverity issue #11 by removing impossible to reach code. Also clean
up some minor style issues.
r18091:
Fix coverity items 314 and 318. Changed the improper assertion of the return
value of a library function to a check, and a return(void) on failure.
r18092:
Fix coverity item 70. Changed the improper assertion of the return value of a
library function to a check, and a return(void) on failure.
r18093:
Correct Coverity issue #12 by removing dead code.
r18094:
Correct Coverity issue #16 by removing debugging code.
r18095:
Fixed coverity issue # 271.
Removed redundant checking and freeing of sm_buf1 and sm_buf2.
r18096:
Correct Coverity issue #17 by refactoring test to remove dead code.
Also, removed previous "coverity" statements in comments, we'll review
those issues again and see if we can figure them out, now that we have more
experience with Coverity.
Tested on:
Mac OS X/32 10.6.2 (amazon) debug & prod
|
| |
| |
| |
| |
| |
| |
| | |
Correct Coverity issue #17 by refactoring test to remove dead code.
Tested on:
Mac OS X/32 10.6.2 (amazon) w/debug
|
| |
| |
| |
| | |
Removed redundant checking and freeing of sm_buf1 and sm_buf2.
|
| |
| |
| |
| |
| |
| |
| | |
Correct Coverity issue #16 by removing debugging code.
Tested on:
Mac OS X/32 10.6.2 (amazon) w/debug
|
| |
| |
| |
| |
| |
| |
| | |
Correct Coverity issue #12 by removing dead code.
Tested on:
Mac OS X/32 10.6.3 (amazon) w/debug
|
| |
| |
| |
| |
| |
| |
| |
| | |
return value of a
library function to a check, and a return(void) on failure.
Tested: Fedora
|
| |
| |
| |
| |
| |
| |
| |
| | |
of the return
value of a library function to a check, and a return(void) on failure.
Tested: Fedora
|
| |
| |
| |
| |
| |
| |
| |
| | |
Correct Coverity issue #11 by removing impossible to reach code. Also clean
up some minor style issues.
Tested on:
Mac OS X/32 10.6.3 (amazon) w/debug
|
| |
| |
| |
| |
| |
| |
| | |
Correct Coverity issue #9 - remove impossible to read code.
Tested on:
Mac OS X/32 10.6.3 (amazon)
|
| |
| |
| |
| |
| |
| |
| | |
Correct Coverity #8 by removing unchanged variable checking code.
Tested on:
Mac OS X/32 10.6.3 (amazon) w/debug
|
| |
| |
| |
| |
| |
| |
| | |
Correct Coverity issue #7 by cleaning up correctly on error
Tested on:
Mac OS X/32 10.6.3 (amazon) w/debug
|
| |
| |
| |
| | |
if(curr_span && (io_bytes_left==0 || curr_seq>=maxseq))
|
| |
| |
| |
| | |
fixed coverity #27, check if (heap) before use heap->obj....
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
function using the
h5tools error framework, the "past_catch" variable would not be set to true
because that statement was before the label that goto jumped to. This could
cause a failure in the cleanup section to go back to the start of the section,
freeing variables twice, etc.
Moved the label infront of past_catch=TRUE.
Tested: Fedora
|
| |
| |
| |
| |
| |
| |
| |
| | |
Correct Coverity issue #6 by removing debugging knob from error reporting
code.
Tested on:
Mac OS X/32 10.6.3 (amazon) w/debug
|
| |
| |
| |
| |
| |
| |
| |
| | |
321: freed sm_buf in error handling to remove resource leak.
Also set sm_buf to NULL after other instances in which
it is freed to prevent double free.
316: initialized nmembs to 0.
|
| |
| |
| |
| |
| |
| |
| |
| | |
H5HF_man_iblock_detach().
line, and those below, will be ignored--
M src/H5HFdblock.c
|
| |
| |
| |
| |
| |
| |
| | |
Correct Coverity issue #4 by removing impossible to reach code.
Tested on:
Mac OS X/32 10.6.3 (amazon) w/debug
|
| |
| |
| |
| |
| |
| |
| | |
Correct #3 by removing impossible to reach code.
Tested on:
Mac OS X/32 10.6.2 (amazon) w/debug
|
| |
| |
| |
| |
| |
| |
| | |
Correct Coverity issue #2 by removing impossible to reach code.
Tested on:
Mac OS X/32 10.6.2 (amazon) w/debug
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
linked list in
H5S_point_copy, the library would not free the partially allocated list. Added
code to free the list in this case.
Tested: Fedora
|
| |
| |
| |
| |
| |
| |
| | |
Correct Coverity issue #1 by removing dead code
Tested on:
Mac OS X/32 (amazon) debug
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The mixed use of RUNTEST (original) and RUNTESTS (new) caused
confusion. E.g., the timings in test/ was still using the old
$RUNTEST. It made more sense to use $RUNTEST which is used
by the dejagnu feature of automake. So, I changed all
$RUNTEST or $RUNTESTS to $RUNEXEC.
config/commence.am & config/conclude.am are the two files
that got changes. Also fixed an error in test/Makefile.am.
The rest are changed by bin/reconfigure.
Tested: h5committested.
|
| |
| |
| |
| | |
Tested: windows
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Merged changes from trunk/fortran into the branch used:
svn merge -r 17682:18098 https://svn.hdfgroup.uiuc.edu/hdf5/trunk/fortran
Tested on: jam (intel)
amani (pgi)
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Bring r18072 from trunk to 1.8 branch:
Bring r18071 from metadata journaling merge branch:
Refactor local heap routines with changes from metadata journaling
branch, along with other misc. changes as the changes on the metadata journaling
branch are being converged with the current state of the trunk.
Tested on:
Mac OS X/32 10.6.2 (amazon) debug & prod
Linux/64 2.6 (amani) prod
FreeBSD/64 (liberty) prod
|
| |
| |
| |
| | |
Tested chkmanifest on jam.
|
| |
| |
| |
| |
| |
| |
| | |
Port to AIX 6.1 for RS6000. Should be the same as PowerPC based AIX.
Tested:
Blue-print of NCSA.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
was fixed in the
trunk in r17751, but was not ported to 1.8 because that feature (compress group
fheap) had not beed added to 1.8 yet. This fix should have been ported to the
cgfh branch at the time, but it was overlooked.
Tested: Fedora (too small for commit test)
|
| | |
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| | |
Description:
Fixed exit code (sometimes return code in Main) to follow the HDF5 standards.
Tested:
Jam, both serial and parallel.
|
| |
| |
| |
| | |
Checked by bin/chkmanifest.
|
| |
| |
| |
| |
| |
| |
| |
| | |
Description:
Fixed exit code (sometimes return code in Main) to follow the HDF5 standards.
Tested:
H5committested plus serial test in Jam.
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
hl/tools/gif2h5/testfiles
so that it has its own testfiles directory.
Tested:
h5committested.
|
| |
| |
| |
| |
| |
| |
| |
| | |
Description:
Some exit code (sometimes return code in Main) to follow the HDF5 standards.
Tested:
H5committested plus serial test in Jam.
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Bring r18045 from trunk to 1.8 branch:
Slush changes back & forth between trunk, the merging branch and the
metadata journaling branch to level them out to a reasonably common set of code
to work from for the next set of more significant changes.
Tested on:
FreeBSD/32 6.3 (duty) w/debug
(h5committested on trunk)
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Bring r18039 from trunk to 1.8 branch:
Minor code cleanups, to align better w/ongoing metadata journaling
convergence.
Tested on:
Mac OS X/32 10.6.2 (amazon) w/debug
(too minor to require h5committest)
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Bring r18037 from trunk to 1.8 branch:
Bring r18035 from merge_metadata_journaling branch to trunk:
More "brush clearing" convergence between metadata_journaling branch
and the trunk.
Tested on:
Linux/64-amd64 2.6 (amani) w/Intel compilers, w/default API=1.6.x,
w/C++ & FORTRAN, in production mode
(h5committested on trunk)
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Bring r18033 from trunk to 1.8 branch:
Correct error in merging Coverity changes in r18011
Tested on:
None - eyeballed only (very simple)
|