summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Merging in latest from upstream (HDFFV/hdf5:refs/heads/develop)Allen Byrne2019-11-2652-311/+504
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * commit 'a8892bb42d6f6e4fbc30fae0eb2b957f81c938b9': (45 commits) Oops, remove more C99 designated initializers for VS 2010 compatibility. Add an #include to get a function declaration. Don't use C99 designated initializers, they're not compatible with Visual Studio 2010. Quiet some more maybe-uninitialized warnings---each is a false positive, *sigh*. This is more code that may not compile with VS2010, *sigh sigh*. Always warn on maybe-uninitialized. -Wincompatible-pointer-types was not available until GCC 5, so enable it only if that's the GCC version we're using. Only promote maybe-uninitialized warnings to errors on GCC 8. Even on GCC 8, there may be false positives at low optimization levels? I need to check. Only use -Werror=cast-function-type with GCC 8 and later. Put all of the -W options back into the order I found them in so that it's easier to compare old and new config/gnu-flags. Add new source files to CMakeLists.txt. Mention the -Werror= flags in libhdf5.settings.in. free -> HDfree Promote decleration-after-statement warnings to errors. Quiet decleration-after-statement warnings. Move a statement under some declarations since some vintages of Visual Studio don't like declarations after statements. Document H5D__chunk_mem_xfree_wrapper(). Undo accidental test deletion. Oops, delete a debug printf that snuck in here. Undo my changes to the HD macros, hadn't really intended those to be on this branch.... Make errors of some more warnings. Move disabled warnings to DEVELOPER_WARNING_CFLAGS. Put just one warning option on a line, and sort some of the options. Cast to the parameter type, H5VL_token_t *, instead of to unsigned char *. ...
| * Merge pull request #2055 in HDFFV/hdf5 from ↵David Young2019-11-254-5/+14
| |\ | | | | | | | | | | | | | | | | | | ~DYOUNG/vchoi_fork:add-werror-and-squash-some to develop * commit 'f907b511d06612dafc7814a7c30f2f3d2b76d52b': Oops, remove more C99 designated initializers for VS 2010 compatibility.
| | * Oops, remove more C99 designated initializers for VS 2010 compatibility.David Young2019-11-254-5/+14
| | |
| * | Merge pull request #2030 in HDFFV/hdf5 from ↵David Young2019-11-2552-314/+498
| |\ \ | | |/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ~DYOUNG/vchoi_fork:add-werror-and-squash-some to develop * commit '62208b056a09c01855fbac7f75146be58ad6bfe5': (44 commits) Add an #include to get a function declaration. Don't use C99 designated initializers, they're not compatible with Visual Studio 2010. Quiet some more maybe-uninitialized warnings---each is a false positive, *sigh*. This is more code that may not compile with VS2010, *sigh sigh*. Always warn on maybe-uninitialized. -Wincompatible-pointer-types was not available until GCC 5, so enable it only if that's the GCC version we're using. Only promote maybe-uninitialized warnings to errors on GCC 8. Even on GCC 8, there may be false positives at low optimization levels? I need to check. Only use -Werror=cast-function-type with GCC 8 and later. Put all of the -W options back into the order I found them in so that it's easier to compare old and new config/gnu-flags. Add new source files to CMakeLists.txt. Mention the -Werror= flags in libhdf5.settings.in. free -> HDfree Promote decleration-after-statement warnings to errors. Quiet decleration-after-statement warnings. Move a statement under some declarations since some vintages of Visual Studio don't like declarations after statements. Document H5D__chunk_mem_xfree_wrapper(). Undo accidental test deletion. Oops, delete a debug printf that snuck in here. Undo my changes to the HD macros, hadn't really intended those to be on this branch.... Make errors of some more warnings. Move disabled warnings to DEVELOPER_WARNING_CFLAGS. Put just one warning option on a line, and sort some of the options. Cast to the parameter type, H5VL_token_t *, instead of to unsigned char *. Change hdset_reg_ref_t and H5R_ref_t from arrays of unsigned char to structs containing those arrays. Encapsulating the arrays in this way makes it easier to write and think about pointers to these types, casts to/from these types, etc. ...
| | * Add an #include to get a function declaration.David Young2019-11-251-0/+1
| | |
| | * Merge remote-tracking branch 'hdf5/develop' into add-werror-and-squash-someDavid Young2019-11-2531-180/+667
| | |\ | | |/ | |/|
| | * Don't use C99 designated initializers, they're not compatible withDavid Young2019-11-253-16/+24
| | | | | | | | | | | | Visual Studio 2010.
| | * Quiet some more maybe-uninitialized warnings---each is a false positive,David Young2019-11-223-3/+16
| | | | | | | | | | | | | | | *sigh*. This is more code that may not compile with VS2010, *sigh sigh*.
| | * Always warn on maybe-uninitialized. -Wincompatible-pointer-types was notDavid Young2019-11-221-2/+2
| | | | | | | | | | | | available until GCC 5, so enable it only if that's the GCC version we're using.
| | * Only promote maybe-uninitialized warnings to errors on GCC 8. Even onDavid Young2019-11-221-1/+7
| | | | | | | | | | | | | | | GCC 8, there may be false positives at low optimization levels? I need to check.
| | * Only use -Werror=cast-function-type with GCC 8 and later.David Young2019-11-221-1/+1
| | |
| | * Put all of the -W options back into the order I found them in so that it'sDavid Young2019-11-221-29/+23
| | | | | | | | | | | | easier to compare old and new config/gnu-flags.
| | * Add new source files to CMakeLists.txt.David Young2019-11-201-0/+2
| | |
| | * Mention the -Werror= flags in libhdf5.settings.in.David Young2019-11-201-1/+1
| | |
| | * free -> HDfreeDavid Young2019-11-201-1/+1
| | |
| | * Promote decleration-after-statement warnings to errors.David Young2019-11-131-1/+1
| | |
| | * Quiet decleration-after-statement warnings.David Young2019-11-132-6/+5
| | |
| | * Move a statement under some declarations since some vintages of VisualDavid Young2019-11-131-1/+2
| | | | | | | | | | | | Studio don't like declarations after statements.
| | * Document H5D__chunk_mem_xfree_wrapper().David Young2019-11-131-0/+5
| | |
| | * Undo accidental test deletion.David Young2019-11-131-1/+1
| | |
| | * Oops, delete a debug printf that snuck in here.David Young2019-11-131-1/+0
| | |
| | * Undo my changes to the HD macros, hadn't really intended those to be onDavid Young2019-11-131-7/+7
| | | | | | | | | | | | this branch....
| | * Make errors of some more warnings. Move disabled warnings toDavid Young2019-11-131-31/+43
| | | | | | | | | | | | | | | DEVELOPER_WARNING_CFLAGS. Put just one warning option on a line, and sort some of the options.
| | * Cast to the parameter type, H5VL_token_t *, instead of to unsigned char *.David Young2019-11-131-1/+1
| | | | | | | | | | | | | | | (H5VL_token_t, too, probably should turn from a typedef for a constant-length array to an array encapsulated in a struct.)
| | * Change hdset_reg_ref_t and H5R_ref_t from arrays of unsigned char toDavid Young2019-11-133-136/+145
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | structs containing those arrays. Encapsulating the arrays in this way makes it easier to write and think about pointers to these types, casts to/from these types, etc. An interesting side-effect that we probably should *not* rely on is that the struct-encapsulation changes the alignment so that some GCC warnings about casts that increase the alignment requirement of the operand go away. Warnings like that have to be taken seriously: I will add -Werror=cast-align to the default compiler flags so that they stop the build quickly. GCC warnings led me to some surprising casts in test/trefer.c. I found that it was possible to make many simplifications after introducing the struct-encapsulation that I described, above.
| | * In every instance, `x` is initialized by `memcpy`, but GCC isn't smartDavid Young2019-11-131-17/+17
| | | | | | | | | | | | | | | enough to figure that out. Quiet some warnings by always initializing `x` to 0.
| | * `same_file` is assigned but never used. Delete it.David Young2019-11-131-8/+0
| | |
| | * Don't assign a constant string to a pointer to non-constant character.David Young2019-11-131-1/+1
| | |
| | * GCC isn't smart enough to realize that `fill_c` is always initializedDavid Young2019-11-131-1/+2
| | | | | | | | | | | | | | | and exclusively used in `datatype == H5T_COMPOUND` branches, so just initialize it at its declaration so that GCC doesn't warn.
| | * I'm not sure what the previous code was trying to do, casting an arrayDavid Young2019-11-131-2/+2
| | | | | | | | | | | | | | | | | | of `hsize_t`, `start`, to `long long`, but I think the way that I have rewritten it, it probably produces a more useful result? As a bonus, GCC has stopped warning about it.
| | * Quiet a warning about an unused variable. This code looks like itDavid Young2019-11-131-1/+1
| | | | | | | | | | | | | | | should be heavily restructured to avoid the use of globals like `pass`, but that's a project for another day and another person.
| | * Straggler from previous commit: build and link the new .c files where IDavid Young2019-11-131-1/+7
| | | | | | | | | | | | | | | moved some previously-static variables and functions that were causing unused-variable/function warnings.
| | * Make many warnings about H5T_copy() calls that discard const qualifiersDavid Young2019-11-132-2/+2
| | | | | | | | | | | | into a few warnings in H5T_copy() itself.
| | * Use FUNC_ENTER_STATIC_NOERR instead of FUNC_ENTER_STATIC for a functionDavid Young2019-11-131-1/+1
| | | | | | | | | | | | | | | that does not generate its own error, so GCC does not warn that err_occurred (or whatever it is called) is unused or set and unused.
| | * Explicitly initialize `type_flags`; the compiler does not realize thatDavid Young2019-11-131-2/+2
| | | | | | | | | | | | it is set before use by passing it as a reference to another function.
| | * Initialize a couple of return values to avoid used-before-set warnings.David Young2019-11-131-2/+2
| | |
| | * Initialize a couple of variables that the compiler does not realize areDavid Young2019-11-132-2/+2
| | | | | | | | | | | | initialized when they're passed by reference to functions.
| | * To quiet a warning, initialize some `struct timeval`s that the compilerDavid Young2019-11-131-2/+2
| | | | | | | | | | | | does not realize are always set before use by `gettimeofday`.
| | * Move some static functions and variables to .c files to avoid unusedDavid Young2019-11-134-54/+106
| | | | | | | | | | | | function/variable warnings.
| | * Delete unused variable.David Young2019-11-131-1/+0
| | |
| | * Change a signed variable to unsigned to avoid a warning about the signDavid Young2019-11-131-1/+1
| | | | | | | | | | | | being lost by a cast.
| | * Avoid unused-variable warnings: change static const strings in a coupleDavid Young2019-11-132-2/+2
| | | | | | | | | | | | of header-file templates to #defines.
| | * Demote errors to warnings for a couple of unused-but-set variables thatDavid Young2019-11-132-0/+7
| | | | | | | | | | | | I cannot untangle right now.
| | * Delete an unused variable.David Young2019-11-131-1/+0
| | |
| | * Mark an unused parameter H5_ATTR_UNUSED.David Young2019-11-131-1/+1
| | |
| | * Delete variables that are unused or set and unused.David Young2019-11-131-12/+0
| | |
| | * Initialize a variable before its first use.David Young2019-11-131-1/+1
| | |
| | * Format a pointer with %p to avoid a gripe about casting a pointer to anDavid Young2019-11-131-3/+2
| | | | | | | | | | | | integer.
| | * Merge remote-tracking branch 'hdf5/develop' into add-werror-and-squash-some toDavid Young2019-11-1242-326/+792
| | |\ | | | | | | | | | | | | see if new warnings-as-errors have cropped up.
| | * \ Merge remote-tracking branch 'hdf5/develop' into add-werror-and-squash-someDavid Young2019-11-0829-41/+275
| | |\ \ | | | | | | | | | | | | | | | to pick up the NetBSD-compatibility changes that I recently merged.
generated by cgit v0.12 at 2024-09-06 04:08:10 (GMT)