::checkConsistency(*p); + } +}; +#endif + +} + +#endif // ValueCheck_h diff --git a/src/3rdparty/webkit/JavaScriptCore/wtf/Vector.h b/src/3rdparty/webkit/JavaScriptCore/wtf/Vector.h index e1fc5b4..6f55e53 100644 --- a/src/3rdparty/webkit/JavaScriptCore/wtf/Vector.h +++ b/src/3rdparty/webkit/JavaScriptCore/wtf/Vector.h @@ -24,6 +24,7 @@ #include "FastAllocBase.h" #include "Noncopyable.h" #include "NotFound.h" +#include "ValueCheck.h" #include "VectorTraits.h" #include #include @@ -71,7 +72,7 @@ namespace WTF { } template - class VectorDestructor; + struct VectorDestructor; template struct VectorDestructor @@ -90,7 +91,7 @@ namespace WTF { }; template - class VectorInitializer; + struct VectorInitializer; template struct VectorInitializer @@ -118,7 +119,7 @@ namespace WTF { }; template - class VectorMover; + struct VectorMover; template struct VectorMover @@ -162,7 +163,7 @@ namespace WTF { }; template - class VectorCopier; + struct VectorCopier; template struct VectorCopier @@ -187,7 +188,7 @@ namespace WTF { }; template - class VectorFiller; + struct VectorFiller; template struct VectorFiller @@ -212,7 +213,7 @@ namespace WTF { }; template - class VectorComparer; + struct VectorComparer; template struct VectorComparer @@ -285,6 +286,20 @@ namespace WTF { m_buffer = static_cast(fastMalloc(newCapacity * sizeof(T))); } + bool tryAllocateBuffer(size_t newCapacity) + { + if (newCapacity > std::numeric_limits::max() / sizeof(T)) + return false; + + T* newBuffer; + if (tryFastMalloc(newCapacity * sizeof(T)).getValue(newBuffer)) { + m_capacity = newCapacity; + m_buffer = newBuffer; + return true; + } + return false; + } + void deallocateBuffer(T* bufferToDeallocate) { if (m_buffer == bufferToDeallocate) { @@ -360,6 +375,7 @@ namespace WTF { void restoreInlineBufferIfNeeded() { } using Base::allocateBuffer; + using Base::tryAllocateBuffer; using Base::deallocateBuffer; using Base::buffer; @@ -404,6 +420,15 @@ namespace WTF { } } + bool tryAllocateBuffer(size_t newCapacity) + { + if (newCapacity > inlineCapacity) + return Base::tryAllocateBuffer(newCapacity); + m_buffer = inlineBuffer(); + m_capacity = inlineCapacity; + return true; + } + void deallocateBuffer(T* bufferToDeallocate) { if (bufferToDeallocate == inlineBuffer()) @@ -537,6 +562,7 @@ namespace WTF { void grow(size_t size); void resize(size_t size); void reserveCapacity(size_t newCapacity); + bool tryReserveCapacity(size_t newCapacity); void reserveInitialCapacity(size_t initialCapacity); void shrinkCapacity(size_t newCapacity); void shrinkToFit() { shrinkCapacity(size()); } @@ -547,6 +573,7 @@ namespace WTF { template void append(const U&); template void uncheckedAppend(const U& val); template void append(const Vector&); + template bool tryAppend(const U*, size_t); template void insert(size_t position, const U*, size_t); template void insert(size_t position, const U&); @@ -586,9 +613,13 @@ namespace WTF { m_buffer.swap(other.m_buffer); } + void checkConsistency(); + private: void expandCapacity(size_t newMinCapacity); const T* expandCapacity(size_t newMinCapacity, const T*); + bool tryExpandCapacity(size_t newMinCapacity); + const T* tryExpandCapacity(size_t newMinCapacity, const T*); template U* expandCapacity(size_t newMinCapacity, U*); size_t m_size; @@ -739,6 +770,26 @@ namespace WTF { return begin() + index; } + template + bool Vector::tryExpandCapacity(size_t newMinCapacity) + { + return tryReserveCapacity(max(newMinCapacity, max(static_cast(16), capacity() + capacity() / 4 + 1))); + } + + template + const T* Vector::tryExpandCapacity(size_t newMinCapacity, const T* ptr) + { + if (ptr < begin() || ptr >= end()) { + if (!tryExpandCapacity(newMinCapacity)) + return 0; + return ptr; + } + size_t index = ptr - begin(); + if (!tryExpandCapacity(newMinCapacity)) + return 0; + return begin() + index; + } + template template inline U* Vector::expandCapacity(size_t newMinCapacity, U* ptr) { @@ -794,6 +845,21 @@ namespace WTF { } template + bool Vector::tryReserveCapacity(size_t newCapacity) + { + if (newCapacity <= capacity()) + return true; + T* oldBuffer = begin(); + T* oldEnd = end(); + if (!m_buffer.tryAllocateBuffer(newCapacity)) + return false; + ASSERT(begin()); + TypeOperations::move(oldBuffer, oldEnd, begin()); + m_buffer.deallocateBuffer(oldBuffer); + return true; + } + + template inline void Vector::reserveInitialCapacity(size_t initialCapacity) { ASSERT(!m_size); @@ -845,6 +911,25 @@ namespace WTF { } template template + bool Vector::tryAppend(const U* data, size_t dataSize) + { + size_t newSize = m_size + dataSize; + if (newSize > capacity()) { + data = tryExpandCapacity(newSize, data); + if (!data) + return false; + ASSERT(begin()); + } + if (newSize < m_size) + return false; + T* dest = end(); + for (size_t i = 0; i < dataSize; ++i) + new (&dest[i]) T(data[i]); + m_size = newSize; + return true; + } + + template template ALWAYS_INLINE void Vector::append(const U& val) { const U* ptr = &val; @@ -987,6 +1072,15 @@ namespace WTF { } template + inline void Vector::checkConsistency() + { +#if !ASSERT_DISABLED + for (size_t i = 0; i < size(); ++i) + ValueCheck::checkConsistency(at(i)); +#endif + } + + template void deleteAllValues(const Vector& collection) { typedef typename Vector::const_iterator iterator; @@ -1016,6 +1110,15 @@ namespace WTF { return !(a == b); } +#if !ASSERT_DISABLED + template struct ValueCheck > { + typedef Vector TraitType; + static void checkConsistency(const Vector& v) + { + v.checkConsistency(); + } + }; +#endif } // namespace WTF diff --git a/src/3rdparty/webkit/JavaScriptCore/wtf/Vector3.h b/src/3rdparty/webkit/JavaScriptCore/wtf/Vector3.h new file mode 100644 index 0000000..3c40b61 --- /dev/null +++ b/src/3rdparty/webkit/JavaScriptCore/wtf/Vector3.h @@ -0,0 +1,138 @@ +/* + * Copyright (C) 2010 Google Inc. All rights reserved. + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions + * are met: + * + * 1. Redistributions of source code must retain the above copyright + * notice, this list of conditions and the following disclaimer. + * 2. Redistributions in binary form must reproduce the above copyright + * notice, this list of conditions and the following disclaimer in the + * documentation and/or other materials provided with the distribution. + * 3. Neither the name of Apple Computer, Inc. ("Apple") nor the names of + * its contributors may be used to endorse or promote products derived + * from this software without specific prior written permission. + * + * THIS SOFTWARE IS PROVIDED BY APPLE AND ITS CONTRIBUTORS "AS IS" AND ANY + * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED + * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE + * DISCLAIMED. IN NO EVENT SHALL APPLE OR ITS CONTRIBUTORS BE LIABLE FOR ANY + * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES + * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; + * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND + * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT + * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF + * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. + */ + +#ifndef Vector3_h +#define Vector3_h + +#include + +namespace WebCore { + +class Vector3 { +public: + Vector3() + : m_x(0.0) + , m_y(0.0) + , m_z(0.0) + { + } + + Vector3(double x, double y, double z) + : m_x(x) + , m_y(y) + , m_z(z) + { + } + + Vector3(const float p[3]) + : m_x(p[0]) + , m_y(p[1]) + , m_z(p[2]) + { + } + + Vector3(const double p[3]) + : m_x(p[0]) + , m_y(p[1]) + , m_z(p[2]) + { + } + + double abs() const + { + return sqrt(m_x * m_x + m_y * m_y + m_z * m_z); + } + + bool isZero() const + { + return !m_x && !m_y && !m_z; + } + + void normalize() + { + double absValue = abs(); + if (!absValue) + return; + + double k = 1.0 / absValue; + m_x *= k; + m_y *= k; + m_z *= k; + } + + double x() const { return m_x; } + double y() const { return m_y; } + double z() const { return m_z; } + +private: + double m_x; + double m_y; + double m_z; +}; + +inline Vector3 operator+(const Vector3& v1, const Vector3& v2) +{ + return Vector3(v1.x() + v2.x(), v1.y() + v2.y(), v1.z() + v2.z()); +} + +inline Vector3 operator-(const Vector3& v1, const Vector3& v2) +{ + return Vector3(v1.x() - v2.x(), v1.y() - v2.y(), v1.z() - v2.z()); +} + +inline Vector3 operator*(double k, const Vector3& v) +{ + return Vector3(k * v.x(), k * v.y(), k * v.z()); +} + +inline Vector3 operator*(const Vector3& v, double k) +{ + return Vector3(k * v.x(), k * v.y(), k * v.z()); +} + +inline double dot(const Vector3& v1, const Vector3& v2) +{ + return v1.x() * v2.x() + v1.y() * v2.y() + v1.z() * v2.z(); +} + +inline Vector3 cross(const Vector3& v1, const Vector3& v2) +{ + double x3 = v1.y() * v2.z() - v1.z() * v2.y(); + double y3 = v1.z() * v2.x() - v1.x() * v2.z(); + double z3 = v1.x() * v2.y() - v1.y() * v2.x(); + return Vector3(x3, y3, z3); +} + +inline double distance(const Vector3& v1, const Vector3& v2) +{ + return (v1 - v2).abs(); +} + +} // WebCore + +#endif // Vector3_h diff --git a/src/3rdparty/webkit/JavaScriptCore/wtf/VectorTraits.h b/src/3rdparty/webkit/JavaScriptCore/wtf/VectorTraits.h index eb4c279..3f33b29 100644 --- a/src/3rdparty/webkit/JavaScriptCore/wtf/VectorTraits.h +++ b/src/3rdparty/webkit/JavaScriptCore/wtf/VectorTraits.h @@ -32,7 +32,7 @@ using std::pair; namespace WTF { template - class VectorTraitsBase; + struct VectorTraitsBase; template struct VectorTraitsBase @@ -80,9 +80,6 @@ namespace WTF { template struct VectorTraits > : SimpleClassVectorTraits { }; - template - struct VectorTraits > : SimpleClassVectorTraits { }; - template struct VectorTraits > { diff --git a/src/3rdparty/webkit/JavaScriptCore/wtf/dtoa.cpp b/src/3rdparty/webkit/JavaScriptCore/wtf/dtoa.cpp index d75c17a..6289d04 100644 --- a/src/3rdparty/webkit/JavaScriptCore/wtf/dtoa.cpp +++ b/src/3rdparty/webkit/JavaScriptCore/wtf/dtoa.cpp @@ -140,7 +140,6 @@ #else #define NO_ERRNO #endif -#include #include #include #include @@ -148,6 +147,7 @@ #include #include #include +#include #include #include @@ -159,9 +159,9 @@ #pragma warning(disable: 4554) #endif -#if PLATFORM(BIG_ENDIAN) +#if CPU(BIG_ENDIAN) #define IEEE_MC68k -#elif PLATFORM(MIDDLE_ENDIAN) +#elif CPU(MIDDLE_ENDIAN) #define IEEE_ARM #else #define IEEE_8087 @@ -262,7 +262,8 @@ typedef union { double d; uint32_t L[2]; } U; #define Pack_32 #endif -#if PLATFORM(PPC64) || PLATFORM(X86_64) +#if CPU(PPC64) || CPU(X86_64) +// FIXME: should we enable this on all 64-bit CPUs? // 64-bit emulation provided by the compiler is likely to be slower than dtoa own code on 32-bit hardware. #define USE_LONG_LONG #endif @@ -560,7 +561,7 @@ static void mult(BigInt& aRef, const BigInt& bRef) aRef = c; } -struct P5Node { +struct P5Node : Noncopyable { BigInt val; P5Node* next; }; @@ -1869,7 +1870,7 @@ static ALWAYS_INLINE int quorem(BigInt& b, BigInt& S) * calculation. */ -void dtoa(char* result, double dd, int ndigits, int* decpt, int* sign, char** rve) +void dtoa(DtoaBuffer result, double dd, int ndigits, int* decpt, int* sign, char** rve) { /* Arguments ndigits, decpt, sign are similar to those @@ -1908,16 +1909,23 @@ void dtoa(char* result, double dd, int ndigits, int* decpt, int* sign, char** rv { /* Infinity or NaN */ *decpt = 9999; - if (!word1(&u) && !(word0(&u) & 0xfffff)) + if (!word1(&u) && !(word0(&u) & 0xfffff)) { strcpy(result, "Infinity"); - else + if (rve) + *rve = result + 8; + } else { strcpy(result, "NaN"); + if (rve) + *rve = result + 3; + } return; } if (!dval(&u)) { *decpt = 1; result[0] = '0'; result[1] = '\0'; + if (rve) + *rve = result + 1; return; } @@ -2376,4 +2384,83 @@ ret: *rve = s; } +static ALWAYS_INLINE void append(char*& next, const char* src, unsigned size) +{ + for (unsigned i = 0; i < size; ++i) + *next++ = *src++; +} + +void doubleToStringInJavaScriptFormat(double d, DtoaBuffer buffer, unsigned* resultLength) +{ + ASSERT(buffer); + + // avoid ever printing -NaN, in JS conceptually there is only one NaN value + if (isnan(d)) { + append(buffer, "NaN", 3); + if (resultLength) + *resultLength = 3; + return; + } + // -0 -> "0" + if (!d) { + buffer[0] = '0'; + if (resultLength) + *resultLength = 1; + return; + } + + int decimalPoint; + int sign; + + DtoaBuffer result; + char* resultEnd = 0; + WTF::dtoa(result, d, 0, &decimalPoint, &sign, &resultEnd); + int length = resultEnd - result; + + char* next = buffer; + if (sign) + *next++ = '-'; + + if (decimalPoint <= 0 && decimalPoint > -6) { + *next++ = '0'; + *next++ = '.'; + for (int j = decimalPoint; j < 0; j++) + *next++ = '0'; + append(next, result, length); + } else if (decimalPoint <= 21 && decimalPoint > 0) { + if (length <= decimalPoint) { + append(next, result, length); + for (int j = 0; j < decimalPoint - length; j++) + *next++ = '0'; + } else { + append(next, result, decimalPoint); + *next++ = '.'; + append(next, result + decimalPoint, length - decimalPoint); + } + } else if (result[0] < '0' || result[0] > '9') + append(next, result, length); + else { + *next++ = result[0]; + if (length > 1) { + *next++ = '.'; + append(next, result + 1, length - 1); + } + + *next++ = 'e'; + *next++ = (decimalPoint >= 0) ? '+' : '-'; + // decimalPoint can't be more than 3 digits decimal given the + // nature of float representation + int exponential = decimalPoint - 1; + if (exponential < 0) + exponential = -exponential; + if (exponential >= 100) + *next++ = static_cast('0' + exponential / 100); + if (exponential >= 10) + *next++ = static_cast('0' + (exponential % 100) / 10); + *next++ = static_cast('0' + exponential % 10); + } + if (resultLength) + *resultLength = next - buffer; +} + } // namespace WTF diff --git a/src/3rdparty/webkit/JavaScriptCore/wtf/dtoa.h b/src/3rdparty/webkit/JavaScriptCore/wtf/dtoa.h index cbec7c7..6127f53 100644 --- a/src/3rdparty/webkit/JavaScriptCore/wtf/dtoa.h +++ b/src/3rdparty/webkit/JavaScriptCore/wtf/dtoa.h @@ -30,8 +30,18 @@ namespace WTF { extern WTF::Mutex* s_dtoaP5Mutex; double strtod(const char* s00, char** se); - void dtoa(char* result, double d, int ndigits, int* decpt, int* sign, char** rve); + + typedef char DtoaBuffer[80]; + void dtoa(DtoaBuffer result, double d, int ndigits, int* decpt, int* sign, char** rve); + + // dtoa() for ECMA-262 'ToString Applied to the Number Type.' + // The *resultLength will have the length of the resultant string in bufer. + // The resultant string isn't terminated by 0. + void doubleToStringInJavaScriptFormat(double, DtoaBuffer, unsigned* resultLength); } // namespace WTF +using WTF::DtoaBuffer; +using WTF::doubleToStringInJavaScriptFormat; + #endif // WTF_dtoa_h diff --git a/src/3rdparty/webkit/JavaScriptCore/wtf/gobject/GOwnPtr.cpp b/src/3rdparty/webkit/JavaScriptCore/wtf/gobject/GOwnPtr.cpp new file mode 100644 index 0000000..da0d839 --- /dev/null +++ b/src/3rdparty/webkit/JavaScriptCore/wtf/gobject/GOwnPtr.cpp @@ -0,0 +1,67 @@ +/* + * Copyright (C) 2008 Collabora Ltd. + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2 of the License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library; if not, write to the Free Software + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA + */ + +#include "config.h" +#include "GOwnPtr.h" + +#include +#include + +namespace WTF { + +template <> void freeOwnedGPtr(GError* ptr) +{ + if (ptr) + g_error_free(ptr); +} + +template <> void freeOwnedGPtr(GList* ptr) +{ + g_list_free(ptr); +} + +template <> void freeOwnedGPtr(GCond* ptr) +{ + if (ptr) + g_cond_free(ptr); +} + +template <> void freeOwnedGPtr(GMutex* ptr) +{ + if (ptr) + g_mutex_free(ptr); +} + +template <> void freeOwnedGPtr(GPatternSpec* ptr) +{ + if (ptr) + g_pattern_spec_free(ptr); +} + +template <> void freeOwnedGPtr(GDir* ptr) +{ + if (ptr) + g_dir_close(ptr); +} + +template <> void freeOwnedGPtr(GFile* ptr) +{ + if (ptr) + g_object_unref(ptr); +} +} // namespace WTF diff --git a/src/3rdparty/webkit/JavaScriptCore/wtf/gobject/GOwnPtr.h b/src/3rdparty/webkit/JavaScriptCore/wtf/gobject/GOwnPtr.h new file mode 100644 index 0000000..1fc594c --- /dev/null +++ b/src/3rdparty/webkit/JavaScriptCore/wtf/gobject/GOwnPtr.h @@ -0,0 +1,148 @@ +/* + * Copyright (C) 2006, 2007 Apple Inc. All rights reserved. + * Copyright (C) 2008 Collabora Ltd. + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Library General Public + * License as published by the Free Software Foundation; either + * version 2 of the License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Library General Public License for more details. + * + * You should have received a copy of the GNU Library General Public License + * along with this library; see the file COPYING.LIB. If not, write to + * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, + * Boston, MA 02110-1301, USA. + * + */ + +#ifndef GOwnPtr_h +#define GOwnPtr_h + +#include +#include +#include + +// Forward delcarations at this point avoid the need to include GLib includes +// in WTF headers. +typedef struct _GError GError; +typedef struct _GList GList; +typedef struct _GCond GCond; +typedef struct _GMutex GMutex; +typedef struct _GPatternSpec GPatternSpec; +typedef struct _GDir GDir; +typedef struct _GHashTable GHashTable; +typedef struct _GFile GFile; +extern "C" void g_free(void*); + +namespace WTF { + +template inline void freeOwnedGPtr(T* ptr); +template<> void freeOwnedGPtr(GError*); +template<> void freeOwnedGPtr(GList*); +template<> void freeOwnedGPtr(GCond*); +template<> void freeOwnedGPtr(GMutex*); +template<> void freeOwnedGPtr(GPatternSpec*); +template<> void freeOwnedGPtr(GDir*); +template<> void freeOwnedGPtr(GHashTable*); +template<> void freeOwnedGPtr(GFile*); + +template class GOwnPtr : public Noncopyable { +public: + explicit GOwnPtr(T* ptr = 0) : m_ptr(ptr) { } + ~GOwnPtr() { freeOwnedGPtr(m_ptr); } + + T* get() const { return m_ptr; } + T* release() + { + T* ptr = m_ptr; + m_ptr = 0; + return ptr; + } + + T*& outPtr() + { + ASSERT(!m_ptr); + return m_ptr; + } + + void set(T* ptr) + { + ASSERT(!ptr || m_ptr != ptr); + freeOwnedGPtr(m_ptr); + m_ptr = ptr; + } + + void clear() + { + freeOwnedGPtr(m_ptr); + m_ptr = 0; + } + + T& operator*() const + { + ASSERT(m_ptr); + return *m_ptr; + } + + T* operator->() const + { + ASSERT(m_ptr); + return m_ptr; + } + + bool operator!() const { return !m_ptr; } + + // This conversion operator allows implicit conversion to bool but not to other integer types. + typedef T* GOwnPtr::*UnspecifiedBoolType; + operator UnspecifiedBoolType() const { return m_ptr ? &GOwnPtr::m_ptr : 0; } + + void swap(GOwnPtr& o) { std::swap(m_ptr, o.m_ptr); } + +private: + T* m_ptr; +}; + +template inline void swap(GOwnPtr& a, GOwnPtr& b) +{ + a.swap(b); +} + +template inline bool operator==(const GOwnPtr& a, U* b) +{ + return a.get() == b; +} + +template inline bool operator==(T* a, const GOwnPtr& b) +{ + return a == b.get(); +} + +template inline bool operator!=(const GOwnPtr& a, U* b) +{ + return a.get() != b; +} + +template inline bool operator!=(T* a, const GOwnPtr& b) +{ + return a != b.get(); +} + +template inline typename GOwnPtr::PtrType getPtr(const GOwnPtr& p) +{ + return p.get(); +} + +template inline void freeOwnedGPtr(T* ptr) +{ + g_free(ptr); +} + +} // namespace WTF + +using WTF::GOwnPtr; + +#endif // GOwnPtr_h diff --git a/src/3rdparty/webkit/JavaScriptCore/wtf/gobject/GRefPtr.cpp b/src/3rdparty/webkit/JavaScriptCore/wtf/gobject/GRefPtr.cpp new file mode 100644 index 0000000..e7cf34b --- /dev/null +++ b/src/3rdparty/webkit/JavaScriptCore/wtf/gobject/GRefPtr.cpp @@ -0,0 +1,38 @@ +/* + * Copyright (C) 2009 Martin Robinson + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2 of the License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library; if not, write to the Free Software + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA + */ + +#include "config.h" +#include "GRefPtr.h" + +#include + +namespace WTF { + +template <> GHashTable* refGPtr(GHashTable* ptr) +{ + if (ptr) + g_hash_table_ref(ptr); + return ptr; +} + +template <> void derefGPtr(GHashTable* ptr) +{ + g_hash_table_unref(ptr); +} + +} // namespace WTF diff --git a/src/3rdparty/webkit/JavaScriptCore/wtf/gobject/GRefPtr.h b/src/3rdparty/webkit/JavaScriptCore/wtf/gobject/GRefPtr.h new file mode 100644 index 0000000..66739ef --- /dev/null +++ b/src/3rdparty/webkit/JavaScriptCore/wtf/gobject/GRefPtr.h @@ -0,0 +1,187 @@ +/* + * Copyright (C) 2005, 2006, 2007, 2008 Apple Inc. All rights reserved. + * Copyright (C) 2008 Collabora Ltd. + * Copyright (C) 2009 Martin Robinson + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Library General Public + * License as published by the Free Software Foundation; either + * version 2 of the License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Library General Public License for more details. + * + * You should have received a copy of the GNU Library General Public License + * along with this library; see the file COPYING.LIB. If not, write to + * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, + * Boston, MA 02110-1301, USA. + * + */ + +#ifndef WTF_GRefPtr_h +#define WTF_GRefPtr_h + +#include "AlwaysInline.h" +#include + +typedef struct _GHashTable GHashTable; + +namespace WTF { + +enum GRefPtrAdoptType { GRefPtrAdopt }; +template inline T* refGPtr(T*); +template inline void derefGPtr(T*); +template class GRefPtr; +template GRefPtr adoptGRef(T*); +template <> GHashTable* refGPtr(GHashTable* ptr); +template <> void derefGPtr(GHashTable* ptr); + +template class GRefPtr { +public: + GRefPtr() : m_ptr(0) { } + GRefPtr(T* ptr) : m_ptr(ptr) { if (ptr) refGPtr(ptr); } + GRefPtr(const GRefPtr& o) : m_ptr(o.m_ptr) { if (T* ptr = m_ptr) refGPtr(ptr); } + template GRefPtr(const GRefPtr& o) : m_ptr(o.get()) { if (T* ptr = m_ptr) refGPtr(ptr); } + + ~GRefPtr() { if (T* ptr = m_ptr) derefGPtr(ptr); } + + void clear() + { + if (T* ptr = m_ptr) + derefGPtr(ptr); + m_ptr = 0; + } + + T* get() const { return m_ptr; } + T& operator*() const { return *m_ptr; } + ALWAYS_INLINE T* operator->() const { return m_ptr; } + + bool operator!() const { return !m_ptr; } + + // This conversion operator allows implicit conversion to bool but not to other integer types. + typedef T* GRefPtr::*UnspecifiedBoolType; + operator UnspecifiedBoolType() const { return m_ptr ? &GRefPtr::m_ptr : 0; } + + GRefPtr& operator=(const GRefPtr&); + GRefPtr& operator=(T*); + template GRefPtr& operator=(const GRefPtr&); + + void swap(GRefPtr&); + friend GRefPtr adoptGRef(T*); + +private: + static T* hashTableDeletedValue() { return reinterpret_cast(-1); } + // Adopting constructor. + GRefPtr(T* ptr, GRefPtrAdoptType) : m_ptr(ptr) {} + + T* m_ptr; +}; + +template inline GRefPtr& GRefPtr::operator=(const GRefPtr& o) +{ + T* optr = o.get(); + if (optr) + refGPtr(optr); + T* ptr = m_ptr; + m_ptr = optr; + if (ptr) + derefGPtr(ptr); + return *this; +} + +template inline GRefPtr& GRefPtr::operator=(T* optr) +{ + T* ptr = m_ptr; + if (optr) + refGPtr(optr); + m_ptr = optr; + if (ptr) + derefGPtr(ptr); + return *this; +} + +template inline void GRefPtr::swap(GRefPtr& o) +{ + std::swap(m_ptr, o.m_ptr); +} + +template inline void swap(GRefPtr& a, GRefPtr& b) +{ + a.swap(b); +} + +template inline bool operator==(const GRefPtr& a, const GRefPtr& b) +{ + return a.get() == b.get(); +} + +template inline bool operator==(const GRefPtr& a, U* b) +{ + return a.get() == b; +} + +template inline bool operator==(T* a, const GRefPtr& b) +{ + return a == b.get(); +} + +template inline bool operator!=(const GRefPtr& a, const GRefPtr& b) +{ + return a.get() != b.get(); +} + +template inline bool operator!=(const GRefPtr& a, U* b) +{ + return a.get() != b; +} + +template inline bool operator!=(T* a, const GRefPtr& b) +{ + return a != b.get(); +} + +template inline GRefPtr static_pointer_cast(const GRefPtr& p) +{ + return GRefPtr(static_cast(p.get())); +} + +template inline GRefPtr const_pointer_cast(const GRefPtr& p) +{ + return GRefPtr(const_cast(p.get())); +} + +template inline T* getPtr(const GRefPtr& p) +{ + return p.get(); +} + +template GRefPtr adoptGRef(T* p) +{ + return GRefPtr(p, GRefPtrAdopt); +} + +template inline T* refGPtr(T* ptr) +{ + if (ptr) + g_object_ref_sink(ptr); + return ptr; +} + +template inline void derefGPtr(T* ptr) +{ + if (ptr) + g_object_unref(ptr); +} + +} // namespace WTF + +using WTF::GRefPtr; +using WTF::refGPtr; +using WTF::derefGPtr; +using WTF::adoptGRef; +using WTF::static_pointer_cast; +using WTF::const_pointer_cast; + +#endif // WTF_GRefPtr_h diff --git a/src/3rdparty/webkit/JavaScriptCore/wtf/qt/ThreadingQt.cpp b/src/3rdparty/webkit/JavaScriptCore/wtf/qt/ThreadingQt.cpp index 1fdd2bb..dc04a68 100644 --- a/src/3rdparty/webkit/JavaScriptCore/wtf/qt/ThreadingQt.cpp +++ b/src/3rdparty/webkit/JavaScriptCore/wtf/qt/ThreadingQt.cpp @@ -29,6 +29,8 @@ #include "config.h" #include "Threading.h" +#if !ENABLE(SINGLE_THREADED) + #include "CurrentTime.h" #include "HashMap.h" #include "MainThread.h" @@ -64,6 +66,21 @@ void ThreadPrivate::run() m_returnValue = m_entryPoint(m_data); } +class ThreadMonitor : public QObject { + Q_OBJECT +public: + static ThreadMonitor * instance() + { + static ThreadMonitor *instance = new ThreadMonitor(); + return instance; + } + +public Q_SLOTS: + void threadFinished() + { + sender()->deleteLater(); + } +}; static Mutex* atomicallyInitializedStaticMutex; @@ -155,6 +172,9 @@ ThreadIdentifier createThreadInternal(ThreadFunction entryPoint, void* data, con LOG_ERROR("Failed to create thread at entry point %p with data %p", entryPoint, data); return 0; } + + QObject::connect(thread, SIGNAL(finished()), ThreadMonitor::instance(), SLOT(threadFinished())); + thread->start(); QThread* threadRef = static_cast(thread); @@ -162,7 +182,7 @@ ThreadIdentifier createThreadInternal(ThreadFunction entryPoint, void* data, con return establishIdentifierForThread(threadRef); } -void setThreadNameInternal(const char*) +void initializeCurrentThreadInternal(const char*) { } @@ -181,8 +201,10 @@ int waitForThreadCompletion(ThreadIdentifier threadID, void** result) return !res; } -void detachThread(ThreadIdentifier) +void detachThread(ThreadIdentifier threadID) { + ASSERT(threadID); + clearThreadForIdentifier(threadID); } ThreadIdentifier currentThread() @@ -267,3 +289,7 @@ void ThreadCondition::broadcast() } } // namespace WebCore + +#include "ThreadingQt.moc" + +#endif diff --git a/src/3rdparty/webkit/JavaScriptCore/wtf/symbian/BlockAllocatorSymbian.cpp b/src/3rdparty/webkit/JavaScriptCore/wtf/symbian/BlockAllocatorSymbian.cpp index cc8fd15..6a28e9e 100644 --- a/src/3rdparty/webkit/JavaScriptCore/wtf/symbian/BlockAllocatorSymbian.cpp +++ b/src/3rdparty/webkit/JavaScriptCore/wtf/symbian/BlockAllocatorSymbian.cpp @@ -28,7 +28,7 @@ #include "config.h" -#if PLATFORM(SYMBIAN) +#if OS(SYMBIAN) #include "BlockAllocatorSymbian.h" diff --git a/src/3rdparty/webkit/JavaScriptCore/wtf/unicode/Collator.h b/src/3rdparty/webkit/JavaScriptCore/wtf/unicode/Collator.h index 51e8a06..fe6a809 100644 --- a/src/3rdparty/webkit/JavaScriptCore/wtf/unicode/Collator.h +++ b/src/3rdparty/webkit/JavaScriptCore/wtf/unicode/Collator.h @@ -29,8 +29,8 @@ #ifndef WTF_Collator_h #define WTF_Collator_h -#include #include +#include #include #if USE(ICU_UNICODE) && !UCONFIG_NO_COLLATION @@ -47,7 +47,7 @@ namespace WTF { ~Collator(); void setOrderLowerFirst(bool); - static std::auto_ptr userDefault(); + static PassOwnPtr userDefault(); Result collate(const ::UChar*, size_t, const ::UChar*, size_t) const; diff --git a/src/3rdparty/webkit/JavaScriptCore/wtf/unicode/CollatorDefault.cpp b/src/3rdparty/webkit/JavaScriptCore/wtf/unicode/CollatorDefault.cpp index eddbe53..4e05432 100644 --- a/src/3rdparty/webkit/JavaScriptCore/wtf/unicode/CollatorDefault.cpp +++ b/src/3rdparty/webkit/JavaScriptCore/wtf/unicode/CollatorDefault.cpp @@ -45,9 +45,9 @@ void Collator::setOrderLowerFirst(bool) { } -std::auto_ptr Collator::userDefault() +PassOwnPtr Collator::userDefault() { - return std::auto_ptr(new Collator(0)); + return new Collator(0); } // A default implementation for platforms that lack Unicode-aware collation. diff --git a/src/3rdparty/webkit/JavaScriptCore/wtf/unicode/UTF8.cpp b/src/3rdparty/webkit/JavaScriptCore/wtf/unicode/UTF8.cpp index 9e713fe..21d5856 100644 --- a/src/3rdparty/webkit/JavaScriptCore/wtf/unicode/UTF8.cpp +++ b/src/3rdparty/webkit/JavaScriptCore/wtf/unicode/UTF8.cpp @@ -23,6 +23,7 @@ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. */ +#include "config.h" #include "UTF8.h" namespace WTF { diff --git a/src/3rdparty/webkit/JavaScriptCore/wtf/unicode/Unicode.h b/src/3rdparty/webkit/JavaScriptCore/wtf/unicode/Unicode.h index 7016a03..d59439d 100644 --- a/src/3rdparty/webkit/JavaScriptCore/wtf/unicode/Unicode.h +++ b/src/3rdparty/webkit/JavaScriptCore/wtf/unicode/Unicode.h @@ -26,11 +26,7 @@ #include #if USE(QT4_UNICODE) -#if COMPILER(WINSCW) || COMPILER(RVCT) -#include "wtf/unicode/qt4/UnicodeQt4.h" -#else #include "qt4/UnicodeQt4.h" -#endif #elif USE(ICU_UNICODE) #include #elif USE(GLIB_UNICODE) diff --git a/src/3rdparty/webkit/JavaScriptCore/wtf/unicode/glib/UnicodeGLib.cpp b/src/3rdparty/webkit/JavaScriptCore/wtf/unicode/glib/UnicodeGLib.cpp index a779b36..e20c376 100644 --- a/src/3rdparty/webkit/JavaScriptCore/wtf/unicode/glib/UnicodeGLib.cpp +++ b/src/3rdparty/webkit/JavaScriptCore/wtf/unicode/glib/UnicodeGLib.cpp @@ -19,6 +19,7 @@ * */ +#include "config.h" #include "UnicodeGLib.h" namespace WTF { diff --git a/src/3rdparty/webkit/JavaScriptCore/wtf/unicode/glib/UnicodeGLib.h b/src/3rdparty/webkit/JavaScriptCore/wtf/unicode/glib/UnicodeGLib.h index c03d3ec..46b00ea 100644 --- a/src/3rdparty/webkit/JavaScriptCore/wtf/unicode/glib/UnicodeGLib.h +++ b/src/3rdparty/webkit/JavaScriptCore/wtf/unicode/glib/UnicodeGLib.h @@ -26,7 +26,7 @@ #define UnicodeGLib_h #include "UnicodeMacrosFromICU.h" -#include +#include "GOwnPtr.h" #include #include @@ -152,6 +152,11 @@ inline bool isArabicChar(UChar32 c) return c >= 0x0600 && c <= 0x06FF; } +inline bool isAlphanumeric(UChar32 c) +{ + return g_unichar_isalnum(c); +} + inline bool isFormatChar(UChar32 c) { return g_unichar_type(c) == G_UNICODE_FORMAT; diff --git a/src/3rdparty/webkit/JavaScriptCore/wtf/unicode/icu/CollatorICU.cpp b/src/3rdparty/webkit/JavaScriptCore/wtf/unicode/icu/CollatorICU.cpp index 6376bb3..ecab5bd 100644 --- a/src/3rdparty/webkit/JavaScriptCore/wtf/unicode/icu/CollatorICU.cpp +++ b/src/3rdparty/webkit/JavaScriptCore/wtf/unicode/icu/CollatorICU.cpp @@ -36,7 +36,7 @@ #include #include -#if PLATFORM(DARWIN) +#if OS(DARWIN) #include "RetainPtr.h" #include #endif @@ -57,11 +57,11 @@ Collator::Collator(const char* locale) { } -std::auto_ptr Collator::userDefault() +PassOwnPtr Collator::userDefault() { -#if PLATFORM(DARWIN) && PLATFORM(CF) +#if OS(DARWIN) && PLATFORM(CF) // Mac OS X doesn't set UNIX locale to match user-selected one, so ICU default doesn't work. -#if !defined(BUILDING_ON_TIGER) && !defined(BUILDING_ON_LEOPARD) && !PLATFORM(IPHONE) +#if !defined(BUILDING_ON_TIGER) && !defined(BUILDING_ON_LEOPARD) && !OS(IPHONE_OS) RetainPtr currentLocale(AdoptCF, CFLocaleCopyCurrent()); CFStringRef collationOrder = (CFStringRef)CFLocaleGetValue(currentLocale.get(), kCFLocaleCollatorIdentifier); #else @@ -71,11 +71,11 @@ std::auto_ptr Collator::userDefault() char buf[256]; if (collationOrder) { CFStringGetCString(collationOrder, buf, sizeof(buf), kCFStringEncodingASCII); - return std::auto_ptr(new Collator(buf)); + return new Collator(buf); } else - return std::auto_ptr(new Collator("")); + return new Collator(""); #else - return std::auto_ptr(new Collator(0)); + return new Collator(0); #endif } diff --git a/src/3rdparty/webkit/JavaScriptCore/wtf/unicode/icu/UnicodeIcu.h b/src/3rdparty/webkit/JavaScriptCore/wtf/unicode/icu/UnicodeIcu.h index 35c6fbf..a2a5c0a 100644 --- a/src/3rdparty/webkit/JavaScriptCore/wtf/unicode/icu/UnicodeIcu.h +++ b/src/3rdparty/webkit/JavaScriptCore/wtf/unicode/icu/UnicodeIcu.h @@ -164,6 +164,11 @@ inline bool isArabicChar(UChar32 c) return ublock_getCode(c) == UBLOCK_ARABIC; } +inline bool isAlphanumeric(UChar32 c) +{ + return u_isalnum(c); +} + inline bool isSeparatorSpace(UChar32 c) { return u_charType(c) == U_SPACE_SEPARATOR; diff --git a/src/3rdparty/webkit/JavaScriptCore/wtf/unicode/qt4/UnicodeQt4.h b/src/3rdparty/webkit/JavaScriptCore/wtf/unicode/qt4/UnicodeQt4.h index bdf2028..9b1754a 100644 --- a/src/3rdparty/webkit/JavaScriptCore/wtf/unicode/qt4/UnicodeQt4.h +++ b/src/3rdparty/webkit/JavaScriptCore/wtf/unicode/qt4/UnicodeQt4.h @@ -30,7 +30,6 @@ #include -#if QT_VERSION >= 0x040300 QT_BEGIN_NAMESPACE namespace QUnicodeTables { struct Properties { @@ -55,10 +54,9 @@ namespace QUnicodeTables { Q_CORE_EXPORT const Properties * QT_FASTCALL properties(ushort ucs2); } QT_END_NAMESPACE -#endif // ugly hack to make UChar compatible with JSChar in API/JSStringRef.h -#if defined(Q_OS_WIN) || COMPILER(WINSCW) +#if defined(Q_OS_WIN) || COMPILER(WINSCW) || COMPILER(RVCT) typedef wchar_t UChar; #else typedef uint16_t UChar; @@ -186,8 +184,6 @@ enum CharCategory { }; -#if QT_VERSION >= 0x040300 - // FIXME: handle surrogates correctly in all methods inline UChar32 toLower(UChar32 ch) @@ -406,138 +402,6 @@ inline CharCategory category(UChar32 c) return (CharCategory) U_MASK(QChar::category(c)); } -#else - -inline UChar32 toLower(UChar32 ch) -{ - if (ch > 0xffff) - return ch; - return QChar((unsigned short)ch).toLower().unicode(); -} - -inline int toLower(UChar* result, int resultLength, const UChar* src, int srcLength, bool* error) -{ - *error = false; - if (resultLength < srcLength) { - *error = true; - return srcLength; - } - for (int i = 0; i < srcLength; ++i) - result[i] = QChar(src[i]).toLower().unicode(); - return srcLength; -} - -inline UChar32 toUpper(UChar32 ch) -{ - if (ch > 0xffff) - return ch; - return QChar((unsigned short)ch).toUpper().unicode(); -} - -inline int toUpper(UChar* result, int resultLength, const UChar* src, int srcLength, bool* error) -{ - *error = false; - if (resultLength < srcLength) { - *error = true; - return srcLength; - } - for (int i = 0; i < srcLength; ++i) - result[i] = QChar(src[i]).toUpper().unicode(); - return srcLength; -} - -inline int toTitleCase(UChar32 c) -{ - if (c > 0xffff) - return c; - return QChar((unsigned short)c).toUpper().unicode(); -} - -inline UChar32 foldCase(UChar32 c) -{ - if (c > 0xffff) - return c; - return QChar((unsigned short)c).toLower().unicode(); -} - -inline int foldCase(UChar* result, int resultLength, const UChar* src, int srcLength, bool* error) -{ - return toLower(result, resultLength, src, srcLength, error); -} - -inline bool isPrintableChar(UChar32 c) -{ - return (c & 0xffff0000) == 0 && QChar((unsigned short)c).isPrint(); -} - -inline bool isArabicChar(UChar32 c) -{ - return c >= 0x0600 && c <= 0x06FF; -} - -inline bool isSeparatorSpace(UChar32 c) -{ - return (c & 0xffff0000) == 0 && QChar((unsigned short)c).category() == QChar::Separator_Space; -} - -inline bool isPunct(UChar32 c) -{ - return (c & 0xffff0000) == 0 && QChar((unsigned short)c).isPunct(); -} - -inline bool isLower(UChar32 c) -{ - return (c & 0xffff0000) == 0 && QChar((unsigned short)c).category() == QChar::Letter_Lowercase; -} - -inline UChar32 mirroredChar(UChar32 c) -{ - if (c > 0xffff) - return c; - return QChar(c).mirroredChar().unicode(); -} - -inline uint8_t combiningClass(UChar32 c) -{ - if (c > 0xffff) - return 0; - return QChar((unsigned short)c).combiningClass(); -} - -inline DecompositionType decompositionType(UChar32 c) -{ - if (c > 0xffff) - return DecompositionNone; - return (DecompositionType)QChar(c).decompositionTag(); -} - -inline int umemcasecmp(const UChar* a, const UChar* b, int len) -{ - for (int i = 0; i < len; ++i) { - QChar c1 = QChar(a[i]).toLower(); - QChar c2 = QChar(b[i]).toLower(); - if (c1 != c2) - return c1.unicode() - c2.unicode(); - } - return 0; -} - -inline Direction direction(UChar32 c) -{ - if (c > 0xffff) - return LeftToRight; - return (Direction)QChar(c).direction(); -} - -inline CharCategory category(UChar32 c) -{ - if (c > 0xffff) - return NoCategory; - return (CharCategory) U_MASK(QChar(c).category()); -} - -#endif - } } #endif // WTF_UNICODE_QT4_H diff --git a/src/3rdparty/webkit/JavaScriptCore/wtf/unicode/wince/UnicodeWince.cpp b/src/3rdparty/webkit/JavaScriptCore/wtf/unicode/wince/UnicodeWince.cpp index 966f2a1..2df44f8 100644 --- a/src/3rdparty/webkit/JavaScriptCore/wtf/unicode/wince/UnicodeWince.cpp +++ b/src/3rdparty/webkit/JavaScriptCore/wtf/unicode/wince/UnicodeWince.cpp @@ -19,6 +19,7 @@ * Boston, MA 02110-1301, USA. */ +#include "config.h" #include "UnicodeWince.h" #include diff --git a/src/3rdparty/webkit/JavaScriptCore/wtf/wince/FastMallocWince.h b/src/3rdparty/webkit/JavaScriptCore/wtf/wince/FastMallocWince.h index 93d9f75..37174f0 100644 --- a/src/3rdparty/webkit/JavaScriptCore/wtf/wince/FastMallocWince.h +++ b/src/3rdparty/webkit/JavaScriptCore/wtf/wince/FastMallocWince.h @@ -1,5 +1,4 @@ /* - * This file is part of the KDE libraries * Copyright (C) 2005, 2006, 2007, 2008 Apple Inc. All rights reserved. * Copyright (C) 2007-2009 Torch Mobile, Inc. All rights reserved * diff --git a/src/3rdparty/webkit/JavaScriptCore/wtf/wince/MemoryManager.cpp b/src/3rdparty/webkit/JavaScriptCore/wtf/wince/MemoryManager.cpp index b65b368..81d4f80 100644 --- a/src/3rdparty/webkit/JavaScriptCore/wtf/wince/MemoryManager.cpp +++ b/src/3rdparty/webkit/JavaScriptCore/wtf/wince/MemoryManager.cpp @@ -139,25 +139,25 @@ void* fastZeroedMalloc(size_t n) return p; } -void* tryFastMalloc(size_t n) +TryMallocReturnValue tryFastMalloc(size_t n) { MemoryAllocationCanFail canFail; return fastMalloc(n); } -void* tryFastZeroedMalloc(size_t n) +TryMallocReturnValue tryFastZeroedMalloc(size_t n) { MemoryAllocationCanFail canFail; return fastZeroedMalloc(n); } -void* tryFastCalloc(size_t n_elements, size_t element_size) +TryMallocReturnValue tryFastCalloc(size_t n_elements, size_t element_size) { MemoryAllocationCanFail canFail; return fastCalloc(n_elements, element_size); } -void* tryFastRealloc(void* p, size_t n) +TryMallocReturnValue tryFastRealloc(void* p, size_t n) { MemoryAllocationCanFail canFail; return fastRealloc(p, n); diff --git a/src/3rdparty/webkit/JavaScriptCore/yarr/RegexCompiler.cpp b/src/3rdparty/webkit/JavaScriptCore/yarr/RegexCompiler.cpp index c7b3c81..9cd3d12 100644 --- a/src/3rdparty/webkit/JavaScriptCore/yarr/RegexCompiler.cpp +++ b/src/3rdparty/webkit/JavaScriptCore/yarr/RegexCompiler.cpp @@ -708,7 +708,7 @@ const char* compileRegex(const UString& patternString, RegexPattern& pattern) unsigned numSubpatterns = pattern.m_numSubpatterns; constructor.reset(); -#ifndef NDEBUG +#if !ASSERT_DISABLED const char* error = #endif parse(constructor, patternString, numSubpatterns); diff --git a/src/3rdparty/webkit/JavaScriptCore/yarr/RegexCompiler.h b/src/3rdparty/webkit/JavaScriptCore/yarr/RegexCompiler.h index 3ed2be9..9d2443a 100644 --- a/src/3rdparty/webkit/JavaScriptCore/yarr/RegexCompiler.h +++ b/src/3rdparty/webkit/JavaScriptCore/yarr/RegexCompiler.h @@ -26,13 +26,11 @@ #ifndef RegexCompiler_h #define RegexCompiler_h -#include - #if ENABLE(YARR) -#include #include "RegexParser.h" #include "RegexPattern.h" +#include namespace JSC { namespace Yarr { diff --git a/src/3rdparty/webkit/JavaScriptCore/yarr/RegexInterpreter.cpp b/src/3rdparty/webkit/JavaScriptCore/yarr/RegexInterpreter.cpp index d088086..c2cb1c2 100644 --- a/src/3rdparty/webkit/JavaScriptCore/yarr/RegexInterpreter.cpp +++ b/src/3rdparty/webkit/JavaScriptCore/yarr/RegexInterpreter.cpp @@ -280,20 +280,6 @@ public: return false; } - bool tryConsumeCharacter(int testChar) - { - if (input.atEnd()) - return false; - - int ch = input.read(); - - if (pattern->m_ignoreCase ? ((Unicode::toLower(testChar) == ch) || (Unicode::toUpper(testChar) == ch)) : (testChar == ch)) { - input.next(); - return true; - } - return false; - } - bool checkCharacter(int testChar, int inputPosition) { return testChar == input.readChecked(inputPosition); @@ -305,23 +291,6 @@ public: return (loChar == ch) || (hiChar == ch); } - bool tryConsumeCharacterClass(CharacterClass* characterClass, bool invert) - { - if (input.atEnd()) - return false; - - bool match = testCharacterClass(characterClass, input.read()); - - if (invert) - match = !match; - - if (match) { - input.next(); - return true; - } - return false; - } - bool checkCharacterClass(CharacterClass* characterClass, bool invert, int inputPosition) { bool match = testCharacterClass(characterClass, input.readChecked(inputPosition)); diff --git a/src/3rdparty/webkit/JavaScriptCore/yarr/RegexInterpreter.h b/src/3rdparty/webkit/JavaScriptCore/yarr/RegexInterpreter.h index 48c9a5e..e3c3122 100644 --- a/src/3rdparty/webkit/JavaScriptCore/yarr/RegexInterpreter.h +++ b/src/3rdparty/webkit/JavaScriptCore/yarr/RegexInterpreter.h @@ -26,13 +26,11 @@ #ifndef RegexInterpreter_h #define RegexInterpreter_h -#include - #if ENABLE(YARR) -#include #include "RegexParser.h" #include "RegexPattern.h" +#include namespace JSC { namespace Yarr { diff --git a/src/3rdparty/webkit/JavaScriptCore/yarr/RegexJIT.cpp b/src/3rdparty/webkit/JavaScriptCore/yarr/RegexJIT.cpp index 5ce579a..271d453 100644 --- a/src/3rdparty/webkit/JavaScriptCore/yarr/RegexJIT.cpp +++ b/src/3rdparty/webkit/JavaScriptCore/yarr/RegexJIT.cpp @@ -44,7 +44,7 @@ namespace JSC { namespace Yarr { class RegexGenerator : private MacroAssembler { friend void jitCompileRegex(JSGlobalData* globalData, RegexCodeBlock& jitObject, const UString& pattern, unsigned& numSubpatterns, const char*& error, bool ignoreCase, bool multiline); -#if PLATFORM(ARM) +#if CPU(ARM) static const RegisterID input = ARMRegisters::r0; static const RegisterID index = ARMRegisters::r1; static const RegisterID length = ARMRegisters::r2; @@ -54,7 +54,17 @@ class RegexGenerator : private MacroAssembler { static const RegisterID regT1 = ARMRegisters::r6; static const RegisterID returnRegister = ARMRegisters::r0; -#elif PLATFORM(X86) +#elif CPU(MIPS) + static const RegisterID input = MIPSRegisters::a0; + static const RegisterID index = MIPSRegisters::a1; + static const RegisterID length = MIPSRegisters::a2; + static const RegisterID output = MIPSRegisters::a3; + + static const RegisterID regT0 = MIPSRegisters::t4; + static const RegisterID regT1 = MIPSRegisters::t5; + + static const RegisterID returnRegister = MIPSRegisters::v0; +#elif CPU(X86) static const RegisterID input = X86Registers::eax; static const RegisterID index = X86Registers::edx; static const RegisterID length = X86Registers::ecx; @@ -64,7 +74,7 @@ class RegexGenerator : private MacroAssembler { static const RegisterID regT1 = X86Registers::esi; static const RegisterID returnRegister = X86Registers::eax; -#elif PLATFORM(X86_64) +#elif CPU(X86_64) static const RegisterID input = X86Registers::edi; static const RegisterID index = X86Registers::esi; static const RegisterID length = X86Registers::edx; @@ -1288,11 +1298,11 @@ class RegexGenerator : private MacroAssembler { void generateEnter() { -#if PLATFORM(X86_64) +#if CPU(X86_64) push(X86Registers::ebp); move(stackPointerRegister, X86Registers::ebp); push(X86Registers::ebx); -#elif PLATFORM(X86) +#elif CPU(X86) push(X86Registers::ebp); move(stackPointerRegister, X86Registers::ebp); // TODO: do we need spill registers to fill the output pointer if there are no sub captures? @@ -1308,28 +1318,32 @@ class RegexGenerator : private MacroAssembler { #else loadPtr(Address(X86Registers::ebp, 2 * sizeof(void*)), output); #endif -#elif PLATFORM(ARM) +#elif CPU(ARM) push(ARMRegisters::r4); push(ARMRegisters::r5); push(ARMRegisters::r6); move(ARMRegisters::r3, output); +#elif CPU(MIPS) + // Do nothing. #endif } void generateReturn() { -#if PLATFORM(X86_64) +#if CPU(X86_64) pop(X86Registers::ebx); pop(X86Registers::ebp); -#elif PLATFORM(X86) +#elif CPU(X86) pop(X86Registers::esi); pop(X86Registers::edi); pop(X86Registers::ebx); pop(X86Registers::ebp); -#elif PLATFORM(ARM) +#elif CPU(ARM) pop(ARMRegisters::r6); pop(ARMRegisters::r5); pop(ARMRegisters::r4); +#elif CPU(MIPS) + // Do nothing #endif ret(); } diff --git a/src/3rdparty/webkit/JavaScriptCore/yarr/RegexJIT.h b/src/3rdparty/webkit/JavaScriptCore/yarr/RegexJIT.h index 1872f21..fd765bc 100644 --- a/src/3rdparty/webkit/JavaScriptCore/yarr/RegexJIT.h +++ b/src/3rdparty/webkit/JavaScriptCore/yarr/RegexJIT.h @@ -26,8 +26,6 @@ #ifndef RegexJIT_h #define RegexJIT_h -#include - #if ENABLE(YARR_JIT) #include "MacroAssembler.h" @@ -37,7 +35,7 @@ #include struct JSRegExp; // temporary, remove when fallback is removed. -#if PLATFORM(X86) && !COMPILER(MSVC) +#if CPU(X86) && !COMPILER(MSVC) #define YARR_CALL __attribute__ ((regparm (3))) #else #define YARR_CALL diff --git a/src/3rdparty/webkit/JavaScriptCore/yarr/RegexParser.h b/src/3rdparty/webkit/JavaScriptCore/yarr/RegexParser.h index 64e8463..c946c2e 100644 --- a/src/3rdparty/webkit/JavaScriptCore/yarr/RegexParser.h +++ b/src/3rdparty/webkit/JavaScriptCore/yarr/RegexParser.h @@ -26,14 +26,12 @@ #ifndef RegexParser_h #define RegexParser_h -#include - #if ENABLE(YARR) #include +#include #include #include -#include namespace JSC { namespace Yarr { diff --git a/src/3rdparty/webkit/JavaScriptCore/yarr/RegexPattern.h b/src/3rdparty/webkit/JavaScriptCore/yarr/RegexPattern.h index a451131..2e8f468 100644 --- a/src/3rdparty/webkit/JavaScriptCore/yarr/RegexPattern.h +++ b/src/3rdparty/webkit/JavaScriptCore/yarr/RegexPattern.h @@ -26,7 +26,6 @@ #ifndef RegexPattern_h #define RegexPattern_h -#include #if ENABLE(YARR) @@ -137,7 +136,7 @@ struct PatternTerm { PatternTerm(unsigned spatternId) : type(TypeBackReference) - , invertOrCapture(invertOrCapture) + , invertOrCapture(false) { subpatternId = spatternId; quantityType = QuantifierFixedCount; diff --git a/src/3rdparty/webkit/VERSION b/src/3rdparty/webkit/VERSION deleted file mode 100644 index 4de7ad8..0000000 --- a/src/3rdparty/webkit/VERSION +++ /dev/null @@ -1,11 +0,0 @@ -This is a snapshot of the Qt port of WebKit from - - git://gitorious.org/qtwebkit/qtwebkit.git - -The commit imported was from the - - qtwebkit/qtwebkit-4.6 branch/tag - -and has the sha1 checksum - - ecfa4583e573ce4dff1f0df12f6bdba3022376e5 diff --git a/src/3rdparty/webkit/WebCore/ChangeLog b/src/3rdparty/webkit/WebCore/ChangeLog index 2bd506b..3eedeff 100644 --- a/src/3rdparty/webkit/WebCore/ChangeLog +++ b/src/3rdparty/webkit/WebCore/ChangeLog @@ -1,60066 +1,23738 @@ -2010-03-25 yael aharon +2010-04-05 Luiz Agostini - Reviewed by Laszlo Gombos. + Reviewed by Kenneth Rohde Christiansen. - [Qt] Windowed netscape plugins don't work with QGraphicsWebView on Symbian - https://bugs.webkit.org/show_bug.cgi?id=35112 + [Qt] Maemo5 theme - wrong spelling + https://bugs.webkit.org/show_bug.cgi?id=37110 - Add a proxy widget when loading a QWidget based plugin in a QGraphicsWebView. + Correcting wrong spelling in RenderThemeQt.cpp. - * plugins/symbian/PluginContainerSymbian.cpp: - (PluginContainerSymbian::PluginContainerSymbian): - (PluginContainerSymbian::focusInEvent): - * plugins/symbian/PluginContainerSymbian.h: - (WebCore::PluginContainerSymbian::proxy): - * plugins/symbian/PluginViewSymbian.cpp: - (WebCore::PluginView::updatePluginWidget): - (WebCore::PluginView::platformStart): - (WebCore::PluginView::platformDestroy): + * platform/qt/RenderThemeQt.cpp: -2010-03-29 Laszlo Gombos +2010-04-01 Luiz Agostini - Reviewed for the Qt 4.6 branch by Simon Hausmann. + Reviewed by Kenneth Rohde Christiansen. - Accept XHTML-MP content type as XHTML content - https://bugs.webkit.org/show_bug.cgi?id=34262 + [Qt] Maemo5 theme - custom rendering + https://bugs.webkit.org/show_bug.cgi?id=36369 - Enable processing XHTML-MP mime type as an XHTML document - even if XHTML-MP support is not enabled. + Customizing rendering of elements in Maemo5. - * platform/MIMETypeRegistry.cpp: - (WebCore::initializeSupportedNonImageMimeTypes): + * platform/qt/Maemo5Webstyle.cpp: + (Maemo5WebStyle::drawMultipleComboButton): + (Maemo5WebStyle::drawSimpleComboButton): + (Maemo5WebStyle::getButtonImageSize): + (Maemo5WebStyle::findComboButton): + (Maemo5WebStyle::drawComplexControl): + * platform/qt/Maemo5Webstyle.h: -2010-03-22 Jakub Wieczorek +2010-03-31 Luiz Agostini - Reviewed by Simon Hausmann. + Reviewed by Kenneth Rohde Christiansen. - [Qt] Don't construct a QLineEdit every time when painting a text field - https://bugs.webkit.org/show_bug.cgi?id=36373 + [Qt] Maemo5 theme - form controls style + https://bugs.webkit.org/show_bug.cgi?id=36370 - Instead, keep one instance per RenderTheme around. + Adjusting Mameo5 form elements rendering. + * WebCore.pri: + * WebCore.pro: + * css/themeQtMaemo5.css: Added. + (select): + (select:disabled): + (select:active): + (select:active:disabled): + (textarea): + (textarea:disabled): + (textarea:active): + * platform/qt/Maemo5Webstyle.cpp: Added. + (Maemo5WebStyle::Maemo5WebStyle): + (drawRectangularControlBackgorund): + (Maemo5WebStyle::drawChecker): + (Maemo5WebStyle::findChecker): + (Maemo5WebStyle::drawRadio): + (Maemo5WebStyle::findRadio): + (Maemo5WebStyle::drawControl): + (Maemo5WebStyle::drawComplexControl): + * platform/qt/Maemo5Webstyle.h: Added. * platform/qt/RenderThemeQt.cpp: - (WebCore::findFrameLineWidth): + (WebCore::RenderThemeQt::RenderThemeQt): + (WebCore::RenderThemeQt::isControlStyled): + (WebCore::RenderThemeQt::popupInternalPaddingBottom): + (WebCore::RenderThemeQt::extraDefaultStyleSheet): + (WebCore::RenderThemeQt::adjustMenuListButtonStyle): + * platform/qt/RenderThemeQt.h: -2010-03-26 Janne Koskinen +2010-04-05 Laszlo Gombos - Reviewed by Laszlo Gombos. + Reviewed by Kenneth Rohde Christiansen. - Don't undefine SKIP_STATIC_CONSTRUCTORS_ON_GCC for Symbian HW targets. - https://bugs.webkit.org/show_bug.cgi?id=34081 + [Symbian] Consolidate Symbian WINSCW environment configuration + https://bugs.webkit.org/show_bug.cgi?id=37100 - Defining StringImpl instances as globals will cause a crash on process exit as - StringImpl::Remove expects TLS which was already deleted at time of exiting main and ends up - constructing one exiting thread. + Move the "undefinition" of WIN32 and _WIN32 from WebCore/config.h + to JavaScriptCore/wtf/Platform.h as it is not specific to WebCore. + + No new tests as there is no new functionality. * config.h: -2010-02-02 Alexey Proskuryakov +2010-04-05 Laszlo Gombos - Reviewed by Darin Adler. + Reviewed by Kenneth Rohde Christiansen. - https://bugs.webkit.org/show_bug.cgi?id=34076 - Crash in mangleme in WebCore::Element::getAttribute + Consolidate the definition of SKIP_STATIC_CONSTRUCTORS_ON_GCC - Test: fast/forms/misplaced-img-form-registration.html + Instead of defining and undefining it later, let's not + define SKIP_STATIC_CONSTRUCTORS_ON_GCC for WINSCW. - * html/HTMLFormElement.cpp: - (WebCore::HTMLFormElement::registerImgElement): Assert that the same image isn't added - to vector again. - (WebCore::HTMLFormElement::removeImgElement): Similarly, assert that we're removing something - that's actually registered. + No new tests as there is no new functionality. - * html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::~HTMLImageElement): If parser fails - to insert the image element, then there will be no removed from tree notification either, - need to unregister right away. + * config.h: -2010-01-25 Alexey Proskuryakov +2010-03-30 Luiz Agostini - Rubber-stamped by Geoffrey Garen. + Reviewed by Kenneth Rohde Christiansen. - https://bugs.webkit.org/show_bug.cgi?id=34076 - An image remains accessible via form.property syntax after being removed from document. + [Qt] Maemo5 theme - QtMaemoWebPopup class + https://bugs.webkit.org/show_bug.cgi?id=36790 - Fix crashing regression tests (tables/mozilla/bugs/bug4527.html et al.) + Moving maemo5 theme related code from WebCore.pri to WebCore.pro and adding + new maemo menu lists popup class source and header to the project. - * html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::insertedIntoTree): Remove incorrect - assertions added in the previous patch - it's mot true that m_for is always a parent; table - parsing can reparent the image element, but m_form still needs to be set. + The code was in .pri file because of a theme css that was conditionally included. + As the css file is been included unconditionally there is no need to this + code to be kept in webcore.pri. -2010-01-25 Alexey Proskuryakov + * WebCore.pri: + * WebCore.pro: - Reviewed by Geoffrey Garen. +2010-04-02 Laszlo Gombos - https://bugs.webkit.org/show_bug.cgi?id=34076 - An image remains accessible via form.property syntax after being removed from document. + Reviewed by Eric Seidel. - Tests: fast/forms/removed-image-as-property.html - fast/forms/reparented-image-as-property.html + Accept XHTML-MP content type as XHTML content + https://bugs.webkit.org/show_bug.cgi?id=34262 - * html/HTMLImageElement.cpp: - (WebCore::HTMLImageElement::~HTMLImageElement): This is called during GC - not a good time - to make observable changes to DOM. - (WebCore::HTMLImageElement::insertedIntoTree): This is the right place to do any work that - depends on connectedness to some ancestor. We still allow for m_form to be set via constructor, - which happens during parsing. - (WebCore::HTMLImageElement::removedFromTree): Ditto. + Enable processing XHTML-MP mime type as an XHTML document + even if XHTML-MP support is not enabled. - * html/HTMLImageElement.h: Added removedFromTree/insertedIntoTree, moved removedFromDocument - and insertedIntoDocument to private section, as they shouldn't be called directly. + * platform/MIMETypeRegistry.cpp: + (WebCore::initializeSupportedNonImageMimeTypes): -2009-12-08 Brady Eidson +2010-04-01 Kenneth Rohde Christiansen - Reviewed by Darin Adler. + Reviewed by Dave Hyatt. - Navigating to a cached page can result in accessing a destroyed HTMLInputElement. - and https://webkit.org/b/32293 + iframe flattening doesn't flatten + https://bugs.webkit.org/show_bug.cgi?id=36798 - Test: fast/loader/input-element-page-cache-crash.html + Fixed to the iframe flattening code so that the iframes on + http://www.samisite.com/test-csb2nf/id43.htm are actually + flattened. - * html/HTMLInputElement.cpp: - (WebCore::HTMLInputElement::parseMappedAttribute): Make sure to unregister for the activation - callback after the new m_autocomplete setting has been stored so the unregistration actually - takes place. + Covered by current tests. -2009-12-13 Dan Bernstein + * page/FrameView.cpp: Propagate contents changes of iframes + and subframes in framesets to the parent so that it is relayouted + (WebCore::FrameView::setContentsSize): + (WebCore::FrameView::adjustViewSize): + (WebCore::FrameView::scheduleRelayout): + * rendering/RenderPart.cpp: HTMLIFrameElement do not inherit from + HTMLFrameElement, but HTMLFrameElementBase, correct cast. Correct + the use of inset border values. Avoid a sometimes unnecessary + relayout. + (WebCore::RenderPart::layoutWithFlattening): + * rendering/RenderPartObject.cpp: Make the calcHeight and calcWidth + return the right values, considering scrolling and fixed width/height + (WebCore::RenderPartObject::flattenFrame): + (WebCore::RenderPartObject::calcHeight): + (WebCore::RenderPartObject::calcWidth): + (WebCore::RenderPartObject::layout): - Reviewed by Simon Fraser. +2010-03-31 Kenneth Rohde Christiansen - Crash at HTMLParser::popOneBlockCommon() after - handling misnested residual style tags + Unreviewed crash fix. - Test: fast/parser/residual-style-close-ref-clone.html + Crash with frame flattening on after r56854 + https://bugs.webkit.org/show_bug.cgi?id=36894 - * html/HTMLParser.cpp: - (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks): Gave the - block stack a strong reference to the cloned residual style element. + Solution tested by Greg Bolsinga, thanks. -2009-12-23 Dan Bernstein + * page/FrameView.cpp: + (WebCore::FrameView::avoidScrollbarCreation): + * platform/ScrollView.cpp: + (WebCore::ScrollView::setHasHorizontalScrollbar): + (WebCore::ScrollView::setHasVerticalScrollbar): - Reviewed by Darin Adler. +2010-03-31 Kenneth Rohde Christiansen - First line of text cannot be selected - https://bugs.webkit.org/show_bug.cgi?id=32749 + Reviewed by Antti Koivisto. - Test: fast/text/remove-zero-length-run.html + iframe flattening doesn't flatten + https://bugs.webkit.org/show_bug.cgi?id=36798 - * rendering/RenderText.cpp: - (WebCore::RenderText::positionLineBox): Changed code that assumed that if a box was being - removed, it was the only box in the RenderText. Instead, correctly preserve the list of - text boxes. - (WebCore::RenderText::checkConsistency): Updated for earlier rename. + Do not draw scrollbars for subframes when frame flattening is + enabled. Implemented using a virtual method in ScrollView as + suggested by Dave Hyatt. -2009-12-10 Oliver Hunt + Do not suppress scrollbars as that is wrong according to + Dave Hyatt. - Reviewed by Alexey Proskuryakov. + Covered by current tests. - Crash in XMLTokenizer::popCurrentNode if window.close() is called during parsing - https://bugs.webkit.org/show_bug.cgi?id=31576 + * page/FrameView.cpp: + (WebCore::FrameView::avoidScrollbarCreation): + * page/FrameView.h: + * platform/ScrollView.cpp: + (WebCore::ScrollView::setHasHorizontalScrollbar): + (WebCore::ScrollView::setHasVerticalScrollbar): + * platform/ScrollView.h: + (WebCore::ScrollView::avoidScrollbarCreation): + * rendering/RenderPart.cpp: + (WebCore::RenderPart::layoutWithFlattening): - Add a RefCounted wrapper object around xmlParserCtxtPtr so we can - maintain it's lifetime more effectively. +2010-03-30 Kenneth Rohde Christiansen - Test: fast/parser/xhtml-close-while-parsing.xhtml + Reviewed by Antti Koivisto. - * dom/XMLTokenizer.cpp: - (WebCore::XMLTokenizer::popCurrentNode): - * dom/XMLTokenizer.h: - (WebCore::XMLParserContext::context): - (WebCore::XMLParserContext::XMLParserContext): - (WebCore::XMLTokenizer::context): - * dom/XMLTokenizerLibxml2.cpp: - (WebCore::XMLParserContext::createStringParser): - (WebCore::XMLParserContext::createMemoryParser): - (WebCore::XMLParserContext::~XMLParserContext): - (WebCore::XMLTokenizer::~XMLTokenizer): - (WebCore::XMLTokenizer::doWrite): - (WebCore::XMLTokenizer::initializeParserContext): - (WebCore::XMLTokenizer::doEnd): - (WebCore::XMLTokenizer::lineNumber): - (WebCore::XMLTokenizer::columnNumber): - (WebCore::XMLTokenizer::stopParsing): - (WebCore::parseXMLDocumentFragment): - (WebCore::parseAttributes): + iframe flattening doesn't flatten + https://bugs.webkit.org/show_bug.cgi?id=36798 -2009-11-09 Anders Carlsson + Fix wrongly reversing logic in frame flattening check. - Reviewed by Darin Adler and Dan Bernstein. + Tests: + fast/frames/flattening/iframe-flattening-fixed-height.html + fast/frames/flattening/iframe-flattening-fixed-width.html + fast/frames/flattening/iframe-flattening-fixed-width-and-height.html + fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling.html - - https://bugs.webkit.org/show_bug.cgi?id=31277 + * rendering/RenderPartObject.cpp: + (WebCore::RenderPartObject::flattenFrame): - When an object tag's style changes (for example when child nodes are added/removed), - reuse its Frame (if it has one) instead of creating multiple Frames. +2010-03-31 Benjamin Poulain - Test: fast/dom/HTMLObjectElement/children-changed.html + Reviewed by Darin Adler. - * loader/FrameLoader.cpp: - (WebCore::FrameLoader::requestObject): + tryLayoutDoingPositionedMovementOnly does not have to be in RenderObject or be virtual + https://bugs.webkit.org/show_bug.cgi?id=36810 -2009-12-05 Adam Langley + Move tryLayoutDoingPositionedMovementOnly as a regular method of RenderBox - Reviewed by Adam Barth. + * rendering/RenderBox.h: + (WebCore::RenderBox::tryLayoutDoingPositionedMovementOnly): + * rendering/RenderObject.h: - Check that a CSS format() argument is of a valid type. +2010-03-30 Stanislav Paltis - https://bugs.webkit.org/show_bug.cgi?id=31815 - http://code.google.com/p/chromium/issues/detail?id=28582 + Reviewed by Laszlo Gombos. - Test: fast/css/url-format-non-string.html + [Qt] qmake/symbian build failure + https://bugs.webkit.org/show_bug.cgi?id=36745 - * css/CSSParser.cpp: - (WebCore::CSSParser::parseFontFaceSrc): + Fix build break in Symbian build introduced in r56714, + by modifying comment escape character from ";" to "#". -2010-03-19 Miikka Heikkinen + * WebCore.pro: + +2010-03-29 Janne Koskinen Reviewed by Simon Hausmann. - [Qt] Support for QT_LIBINFIX in Symbian builds + [Qt] Package build fixes for Symbian - Configuring Qt with -qtlibinfix parameter will enable installing - an alternate version of Qt on devices that already have it on ROM. - This patch provides support for infixed builds of Webkit. + * enable building standalone QtWebkit for Symbian using qtlibinfix configuration option - * WebCore.pro: + qtlibinfix adds possibility having multiple versions of Qt in Symbian devices. + Fix also allows unfrozen DLL exports during development. -2010-01-31 Benjamin Poulain + * Removed heap size configuration. DLLs don't have a heap. - Reviewed by Eric Seidel. + * Removed enforcement to def files for package builds. Instead inherit the setting from + Qt's qconfig.pri whether to use def files or not. It's still possible to override this + also at qmake time by passing CONFIG+=def_files. - [Qt] Enable FAST_MOBILE_SCROLLING on Qt embedded platforms - https://bugs.webkit.org/show_bug.cgi?id=34168 + * WebCore.pro: - Enable FAST_MOBILE_SCROLLING for Qt on Maemo 5, Linux embedded - and Symbian +2010-03-26 Kenneth Rohde Christiansen - * WebCore.pro: + Reviewed by Antti Koivisto. -2010-01-19 Daniel Bates + Implement flattening for iframes. - Reviewed by Adam Treat. + Refactoring of frameset flattening code to reuse it for + iframe flattening. - https://bugs.webkit.org/show_bug.cgi?id=33408 + Tests: fast/frames/flattening/iframe-flattening-simple.html + + * WebCore.base.exp: + * page/FrameView.cpp: + (WebCore::FrameView::layout): + (WebCore::FrameView::scheduleRelayout): + * page/Settings.cpp: + (WebCore::Settings::Settings): + (WebCore::Settings::setFrameFlatteningEnabled): + * page/Settings.h: + (WebCore::Settings::frameFlatteningEnabled): + * rendering/RenderFrame.cpp: + * rendering/RenderFrame.h: + * rendering/RenderFrameSet.cpp: + (WebCore::RenderFrameSet::flattenFrameSet): + * rendering/RenderFrameSet.h: + * rendering/RenderPart.cpp: + (WebCore::RenderPart::layoutWithFlattening): + * rendering/RenderPart.h: + * rendering/RenderPartObject.cpp: + (WebCore::RenderPartObject::flattenFrame): + (WebCore::RenderPartObject::calcHeight): + (WebCore::RenderPartObject::calcWidth): + (WebCore::RenderPartObject::layout): + * rendering/RenderPartObject.h: - Implements an optimization to ignore fixed background images - (i.e. background-attachment: fixed) when a page does not contain - any fixed position elements so as to allow fast repaints (via bit - blit) when scrolling a page. +2010-03-30 Laszlo Gombos - Currently, if a page has elements that specify either a fixed - background or a fixed position then we perform a slow repaint - (i.e disable blitting) so as to avoid rendering artifacts. - However, on low-powered/mobile devices slow repaints can cause - noticeable delays when scrolling a page with a fixed background - image. By sacrificing support for fixed background images when - there are no fixed elements on the page and with come care, we - don't need to force slow repaints and can avoid rendering artifacts. - Hence, on such devices we can improve the responsiveness of - scrolling a page with a fixed background image. + Reviewed by David Kilzer. - Note, this optimization is only enabled if the WebKit is built - with FAST_MOBILE_SCROLLING enabled. + Guard Geolocation files with ENABLE_GEOLOCATION + https://bugs.webkit.org/show_bug.cgi?id=25756 - Tests: fast/fast-mobile-scrolling/fixed-position-element.html - fast/fast-mobile-scrolling/no-fixed-position-elements.html + The intent is to guard the Geolocation implementation files + and minimize the impact on on clients/call sites. - * rendering/RenderBoxModelObject.cpp: - (WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry): - Disable fixed background attachment if we can blit on scroll. - * rendering/RenderObject.cpp: - (WebCore::RenderObject::styleWillChange): + * DerivedSources.make: + * WebCore.Geolocation.exp: Added. Exported interfaces if GEOLOCATION + is enabled. + * WebCore.base.exp: + * bindings/js/JSCustomPositionCallback.cpp: + * bindings/js/JSCustomPositionErrorCallback.cpp: + * bindings/js/JSGeolocationCustom.cpp: + * page/Geolocation.cpp: + (WebCore::Geolocation::disconnectFrame): Stub implementation if + GEOLOCATION is turned off. + (WebCore::Geolocation::Geolocation): Ditto. + (WebCore::Geolocation::~Geolocation): Ditto. + (WebCore::Geolocation::setIsAllowed): Ditto. + * page/Geolocation.h: + * page/Geolocation.idl: + * page/GeolocationPositionCache.cpp: + * page/Geoposition.idl: + * page/PositionError.idl: + * platform/GeolocationService.cpp: + * platform/mock/GeolocationServiceMock.cpp: -2010-03-11 Simon Hausmann +2010-03-22 Kenneth Rohde Christiansen - Reviewed by Tor Arne Vestbø. + Reviewed by Simon Fraser. - [Qt] Avoid double-buffering with Qt image decoders + Add support for Widgets 1.0: View Mode Media Feature + https://bugs.webkit.org/show_bug.cgi?id=35446 - Pass QIODevice::Unbuffered when opening the QBuffer that - wraps the image data, to hint to Qt that no extra buffering - is needed. + When enabling Web Widgets, add support for the view-mode media + feature (http://www.w3.org/TR/widgets-vmmf/). - * platform/graphics/qt/ImageDecoderQt.cpp: - (WebCore::ImageDecoderQt::setData): + Test: fast/media/media-feature-wgt-view-mode.html -2010-01-14 Diego Gonzalez + * css/CSSValueKeywords.in: + * css/MediaFeatureNames.h: + * css/MediaQueryEvaluator.cpp: + (WebCore::view_modeMediaFeatureEval): + * page/ChromeClient.h: + (WebCore::ChromeClient::isDocked): + (WebCore::ChromeClient::isFloating): + (WebCore::ChromeClient::isApplication): + (WebCore::ChromeClient::isFullscreen): - Reviewed by Kenneth Christiansen. +2010-03-29 Luiz Agostini - [Qt] Missing fileSystemPath() method in Qt KURL implementation - https://bugs.webkit.org/show_bug.cgi?id=33614 + Reviewed by Kenneth Rohde Christiansen. - No new tests. + [Qt] Multiselect - Adding method itemIsSelected() to QtAbstractWebPopup + https://bugs.webkit.org/show_bug.cgi?id=36769 - * platform/qt/KURLQt.cpp: - (WebCore::KURL::fileSystemPath): + Adding method itemIsSelected() to QtAbstractWebPopup. -2010-02-01 Andreas Kling + * platform/qt/QtAbstractWebPopup.h: + (WebCore::QtAbstractWebPopup::itemIsSelected): - Reviewed by Kenneth Rohde Christiansen. +2010-03-29 Dawit Alemayehu - [Qt] In the StyledPainter determine the style from the Render and Scrollbar theme instead of from the paint device - https://bugs.webkit.org/show_bug.cgi?id=34054 + Reviewed by Simon Hausmann. - Getting the style from the painter's paint device is a hack that breaks when - the paint device's style is different than the style that is used when - calculating the metries earlier when there is no painter available. + Added a function, WebCore::shouldTreatAsAttachment, to HTTPParsers.* - This change moves us closer to always using the same style. + https://bugs.webkit.org/show_bug.cgi?id=36395 - * platform/qt/RenderThemeQt.cpp: - (WebCore::StylePainter::StylePainter): - (WebCore::StylePainter::init): - (WebCore::RenderThemeQt::paintButton): - (WebCore::RenderThemeQt::paintTextField): - (WebCore::RenderThemeQt::paintMenuList): - (WebCore::RenderThemeQt::paintMenuListButton): - (WebCore::RenderThemeQt::paintSliderTrack): - (WebCore::RenderThemeQt::paintMediaMuteButton): - (WebCore::RenderThemeQt::paintMediaPlayButton): - (WebCore::RenderThemeQt::paintMediaSliderTrack): - (WebCore::RenderThemeQt::paintMediaSliderThumb): - * platform/qt/RenderThemeQt.h: - * platform/qt/ScrollbarThemeQt.cpp: - (WebCore::ScrollbarThemeQt::paint): - (WebCore::ScrollbarThemeQt::hitTest): - (WebCore::ScrollbarThemeQt::shouldCenterOnThumb): - (WebCore::ScrollbarThemeQt::scrollbarThickness): - (WebCore::ScrollbarThemeQt::thumbLength): - (WebCore::ScrollbarThemeQt::trackPosition): - (WebCore::ScrollbarThemeQt::trackLength): - (WebCore::ScrollbarThemeQt::paintScrollCorner): - (WebCore::ScrollbarThemeQt::style): - * platform/qt/ScrollbarThemeQt.h: + This function, which was moved from WebKit/chromium/src/FrameClientImpl.cpp, + is used to check whether or not a request is supposed to be rendered or + simply downloaded based on the "Content-Disposition" header sent by the + web server. The intent of code refactoring is to avoid code duplication + so that this piece of code can be used by other implementations such as + QtWebKit. -2010-01-25 Simon Hausmann + * platform/network/HTTPParsers.cpp: + (WebCore::shouldTreatAsAttachment): + * platform/network/HTTPParsers.h: - Reviewed by Kenneth Rohde Christiansen. +2010-03-29 Jocelyn Turcotte - [Qt] Use the fallback style on Maemo 5 + Reviewed by nobody, build fix. - https://bugs.webkit.org/show_bug.cgi?id=34376 + [Qt] Fix build break introduced in r56724. - * platform/qt/RenderThemeQt.cpp: - (WebCore::RenderThemeQt::RenderThemeQt): - (WebCore::RenderThemeQt::fallbackStyle): - (WebCore::RenderThemeQt::qStyle): - (WebCore::RenderThemeQt::setPaletteFromPageClientIfExists): - * platform/qt/RenderThemeQt.h: + * WebCore.pro: -2010-01-29 Oswald Buddenhagen +2010-03-29 Jocelyn Turcotte Reviewed by Simon Hausmann. - [Qt] Speed up the WebCore::String -> QString conversion + [Qt] Do not generate INSTALLS for webkit when building inside Qt. + Qt will do this for us. - Use QString(const QChar *, int len) constructor instead of QString::fromUtf16 to - avoid BOM checks and byteswapping. - - * bridge/qt/qt_class.cpp: - (JSC::Bindings::QtClass::fieldNamed): - * bridge/qt/qt_runtime.cpp: - (JSC::Bindings::convertValueToQVariant): + * WebCore.pro: -2010-01-14 Andreas Kling +2010-03-29 Antti Koivisto Reviewed by Kenneth Rohde Christiansen. - [Qt] Enable scrolling optimization for pages with embedded widgets + https://bugs.webkit.org/show_bug.cgi?id=36703 + Timer restart loop during page loading + + Fix regression introduced in http://trac.webkit.org/changeset/54526. + Restarting the request timer unconditionally from the timer callback is a bad idea. + Instead, start the timer when a non-cached request completes. - https://bugs.webkit.org/show_bug.cgi?id=33373 + * loader/loader.cpp: + (WebCore::Loader::Host::nonCacheRequestComplete): + (WebCore::Loader::Host::servePendingRequests): - Added a basic manual test for scrolling of embedded QWidgets. +2010-03-29 Thomas Zander - * manual-tests/qt/qtplugin-scrolling.html: Added. - * platform/ScrollView.cpp: - (WebCore::ScrollView::scrollContents): - (WebCore::ScrollView::setParent): - * platform/ScrollView.h: - * platform/qt/ScrollViewQt.cpp: - (WebCore::ScrollView::platformInit): - (WebCore::ScrollView::platformAddChild): - (WebCore::ScrollView::platformRemoveChild): - * plugins/qt/PluginViewQt.cpp: - (WebCore::PluginView::updatePluginWidget): - (WebCore::PluginView::invalidateRect): + Reviewed by Simon Hausmann. -2010-01-29 Laszlo Gombos + [Qt] Shadowbuilds of WebCore with Qt on Symbian fails. - Reviewed by Simon Hausmann. + https://bugs.webkit.org/show_bug.cgi?id=36749 - [Qt] Turn off websocket support by default for Qt 4.6.x - https://bugs.webkit.org/show_bug.cgi?id=34284 + Doing a 'make sis' expects the dll in the libdir, so place it + there. This fixes out-of-source building to always put the dll + in the expected dir. - * WebCore.pro: + * WebCore.pro: Fix for shadow builds inside Qt. -2010-01-26 Holger Hans Peter Freyther +2010-03-29 Thomas Zander Reviewed by Simon Hausmann. - [Qt] JavaScript prompt is currently broken. - https://bugs.webkit.org/show_bug.cgi?id=30914 + [Qt] Make it possible to build using both Windows and Linux for Symbian + https://bugs.webkit.org/show_bug.cgi?id=36748 - Remove the manual test case in favor of an automated - test case in WebKit/qt/tests/qwebpage. + * WebCore.pro: don't assume Windows buildsystem is the only one + and exclude the windows-only setters from the linux builds. - * manual-tests/qt/java-script-prompt.html: Removed. - -2010-01-25 Janne Koskinen +2010-03-29 Thomas Zander Reviewed by Simon Hausmann. - [Qt] Phone backup support for QtWebkit for Symbian devices. - https://bugs.webkit.org/show_bug.cgi?id=34077 + https://bugs.webkit.org/show_bug.cgi?id=36745 - * WebCore.pro: + [Qt] Fix def file builds with Qt 4.7. -2010-01-21 Thiago Macieira + Switched to using DEF_FILE, which is the official variable. + + * WebCore.pro: Use DEF_FILE + +2010-03-28 Kim Grönholm Reviewed by Simon Hausmann. - [Qt] Fix incorrect dependency to QtXmlPatterns in generated include/QtWebKit/QtWebKit header + [Qt] GraphicsLayer: Timing functions don't work with transitions + https://bugs.webkit.org/show_bug.cgi?id=36589 + + If the animation value doesn't have timing function set, we need to + use the animation's timing function. + + Fixed also a bug in passing the duration to solveCubicBezierFunction. + The duration was divided two times by 1000 and meanwhile casted to int. + It needs to be kept as double and divided by 1000 only once. - The generated file includes QtXmlPatterns/QtXmlPatterns, which is neither used/required by - the public QtWebKit API nor will it be available if Qt is configured with -no-xmlpatterns. + Test case: https://bugs.webkit.org/attachment.cgi?id=51619 - * WebCore.pro: Trick syncqt to believe that xmlpatterns is not a dependency, so that it's not - included in the generated file. It'll still be used and linked to with this trick. + * platform/graphics/qt/GraphicsLayerQt.cpp: + (WebCore::applyTimingFunction): + (WebCore::AnimationQt:::AnimationQtBase): + (WebCore::AnimationQt::updateCurrentTime): -2010-01-17 Srinidhi Shreedhara +2010-03-28 Laszlo Gombos Reviewed by Simon Hausmann. - [Qt] [Symbian] SetWindow call in npapi plugin does not happen when the cooridnates are negative - https://bugs.webkit.org/show_bug.cgi?id=33573 + [Qt] Remove the definition of WTF_CHANGES guards from the build system + https://bugs.webkit.org/show_bug.cgi?id=31670 - * plugins/symbian/PluginViewSymbian.cpp: - (WebCore::PluginView::setNPWindowIfNeeded): Remove tests for negative - coordinates for early return. + No new tests as there is no new functionality. + + * WebCore.pri: Remove the definition of WTF_CHANGES + as it is already defined in config.h -2010-01-14 Norbert Leser +2010-03-26 Janne Koskinen Reviewed by Laszlo Gombos. - Platform Symbian specific: - Added time-based optimization (-Otime) and increased optimization level to -O3, - conditionally for RVCT compiler (for ARM), for increasing performance - (primarily affecting JavaScript execution). - Default settings are -Ospace and -O2. + Don't undefine SKIP_STATIC_CONSTRUCTORS_ON_GCC for Symbian HW targets. + https://bugs.webkit.org/show_bug.cgi?id=34081 - No new tests needed because no new funtionality is introduced, - only potential regression on existing tests needs to be evaluated. + Defining StringImpl instances as globals will cause a crash on process exit as + StringImpl::Remove expects TLS which was already deleted at time of exiting main and ends up + constructing one exiting thread. - * WebCore.pro: + * config.h: -2010-01-13 Girish Ramakrishnan +2010-03-26 Jocelyn Turcotte Reviewed by Simon Hausmann. - [Qt/Win] Flash in QGraphicsWebView does not process hover correctly. - - https://bugs.webkit.org/show_bug.cgi?id=33591 - - Mouse hover does not work as expected with the flash in some sites. - - http://www.bbc.co.uk/ Hover over the map - - http://www.barbie.com/ Hover over the menu items (Games, Videos) - The problem appears to be that Flash queries NPNVnetscapeWindow on every - mouse hover. I do not how flash uses this value but returning 0 when flash - is in windowless mode solves the problem (When using QGraphicsWebView we - inject wmode opaque, thereby putting the plugin in windowless mode). + [Qt] Build JavaScriptCore as a static library. + https://bugs.webkit.org/show_bug.cgi?id=36590 - * plugins/win/PluginViewWin.cpp: - (windowHandleForPageClient): + This patch takes what was left of the unused JavaScriptCore.pro + and moved the compilation logic from JavaScriptCore.pri to + JavaScriptCore.pro. -2010-01-13 Miikka Heikkinen + * WebCore.pro: - Reviewed by Simon Hausmann. +2010-03-25 Jakub Wieczorek - [Qt/Symbian] Added missing vendor information to qtwebkit.sis + Reviewed by Eric Seidel. - This information is necessary to Symbian sign the package. + [Qt] RenderTheme: fix size adjustment for text fields + https://bugs.webkit.org/show_bug.cgi?id=36413 - http://bugreports.qt.nokia.com/browse/QTBUG-7290 + To match other ports, remove the hardcoded dimensions for text fields so that + the default ones from WebCore can be used. + Properly apply the correct padding to text areas - this fixes their appearance + with the Oxygen style. - * WebCore.pro: + * platform/qt/RenderThemeQt.cpp: + (WebCore::RenderThemeQt::computeSizeBasedOnStyle): -2010-01-12 Jakub Wieczorek +2010-03-26 Qi Zhang - Reviewed by Adam Barth. + Reviewed by Laszlo Gombos. - [Qt] XSL stylesheets can load documents from a different origin + [Qt] fast/canvas/drawImage-with-negative-source-destination.html failed + https://bugs.webkit.org/show_bug.cgi?id=35005 - https://bugs.webkit.org/show_bug.cgi?id=33423 + To support negative width or height at context.drawImage - * xml/XSLTProcessorQt.cpp: - (WebCore::XSLTUriResolver::XSLTUriResolver): - (WebCore::XSLTUriResolver::resolve): - (WebCore::XSLTProcessor::transformToString): + * platform/graphics/qt/StillImageQt.cpp: + (WebCore::StillImage::draw): -2010-01-07 Yael Aharon +2010-03-24 Dmitry Titov - Reviewed by Kenneth Rohde Christiansen. + Unreviewed, Chromium test fix. - [Qt] Allow the application to override online/offline network status - https://bugs.webkit.org/show_bug.cgi?id=32684 + Recent r56445 added CustomEvent and a test but it didn't work on Chromium bots. + Test crashed due to infinte recursion because the compiler did not have the right definition of toV8(CustomEvent*) + and was substituting toV8(Event*). - Added API to NetworkStateNotifier for forcing network status. + Fixing test fast/events/custom-event.html - * platform/network/NetworkStateNotifier.h: - * platform/network/qt/NetworkStateNotifierPrivate.h: - * platform/network/qt/NetworkStateNotifierQt.cpp: - (WebCore::NetworkStateNotifierPrivate::NetworkStateNotifierPrivate): - (WebCore::NetworkStateNotifierPrivate::onlineStateChanged): - (WebCore::NetworkStateNotifierPrivate::networkAccessPermissionChanged): - (WebCore::NetworkStateNotifier::updateState): - (WebCore::NetworkStateNotifier::NetworkStateNotifier): - (WebCore::NetworkStateNotifier::setNetworkAccessAllowed): + * bindings/v8/custom/V8EventCustom.cpp: -2010-01-07 Simon Hausmann +2010-03-03 Kenneth Rohde Christiansen - Reviewed by Tor Arne Vestbø. + Reviewed by Antti Koivisto. - [Qt] Fix linkage against Qt mobility API bearer management module + Add support for DOM Level 3 Custom Event + http://www.w3.org/TR/DOM-Level-3-Events - Use the documented .pro file syntax to link against the correct - library and (more importantly) get the include paths correct. + V8 Generator change by Nate Chapin , Thanks! + Test: fast/events/custom-event.html + + * DerivedSources.cpp: + * GNUmakefile.am: + * WebCore.gypi: + * WebCore.pri: * WebCore.pro: + * WebCore/DerivedSources.make: + * WebCore.vcproj/WebCore.vcproj: + * WebCore.xcodeproj/project.pbxproj: + * bindings/js/JSEventCustom.cpp: + (WebCore::toJS): + * bindings/scripts/CodeGeneratorJS.pm: + * bindings/scripts/CodeGeneratorV8.pm: + * dom/CustomEvent.cpp: Added. + (WebCore::CustomEvent::CustomEvent): + (WebCore::CustomEvent::initCustomEvent): + (WebCore::CustomEvent::isCustomEvent): + * dom/CustomEvent.h: Added. + (WebCore::CustomEvent::create): + (WebCore::CustomEvent::detail): + * dom/Document.cpp: + (WebCore::Document::createEvent): + * dom/Event.cpp: + (WebCore::Event::isCustomEvent): + * dom/Event.h: -2010-01-07 Laszlo Gombos +2010-03-23 Kenneth Rohde Christiansen - Reviewed by NOBODY (OOPS!). + Reviewed by Simon Hausmann. - [RVCT] ACID3 test crash - https://bugs.webkit.org/show_bug.cgi?id=33280 + Add a way to check if the page client is making use of + a QWidget. - Workaround developed by Yongjun Zhang. + * platform/qt/QWebPageClient.h: + (QWebPageClient::isQWidgetClient): - * dom/Element.cpp: - (WebCore::Element::setAttribute): +2010-03-25 Antti Koivisto -2010-01-06 Simon Hausmann + Reviewed by Kenneth Rohde Christiansen. - Unreviewed trivial Qt build fix. + https://bugs.webkit.org/show_bug.cgi?id=36316 + Tiles of selected content do not update if not in viewport + + Don't clip repaints to viewport when tiling is enabled. - Prefix the phonon includes with phonon/ to avoid conflicts with the S60 - audio routing API ( http://wiki.forum.nokia.com/index.php/Audio_Routing_API ). + * page/Frame.cpp: + (WebCore::Frame::setView): + (WebCore::Frame::setTiledBackingStoreEnabled): - * platform/graphics/qt/MediaPlayerPrivatePhonon.cpp: +2010-03-25 Tor Arne Vestbø -2009-12-31 Laszlo Gombos + Reviewed by Simon Hausmann. - Reviewed by Kenneth Rohde Christiansen. + [Qt] Implement ChromeClient::windowResizerRect() - Do not include Frame.h under WebCore/html/canvas - https://bugs.webkit.org/show_bug.cgi?id=33082 + https://bugs.webkit.org/show_bug.cgi?id=21300 - No new tests, as there is no new functionality. + The helper function geometryRelativeToOwnerWidget() in the page + client is used to clip the resize rect to the actual size of the + viewport, not the size of the QGraphicsView. - * html/canvas/CanvasRenderingContext2D.cpp: + * platform/qt/QWebPageClient.h: -2009-12-30 Janne Koskinen +2010-03-26 Olivier Goffart Reviewed by Simon Hausmann. - [Qt] Add support for Symbian def files + [Qt] Fix compilation on Windows - * WebCore.pro: + For some reason, the MSVC compiler choose the + operator+(const QString &, const QString &) instead of + operator+(const WebCore::String &, const WebCore::String &) + resulting in errors when QT_USE_FAST_OPERATOR_PLUS is used. -2009-12-30 Simon Hausmann + * dom/XMLTokenizerQt.cpp: + (WebCore::handleElementNamespaces): - Unreviewed Qt/Symbian build fix. +2010-03-25 Diego Gonzalez - Don't build network state notifier support when building inside of Qt. - Otherwise the Qt build depends on an external module that itself depends - on Qt again. + Reviewed by Eric Seidel. - * WebCore.pro: + Missing forward ENABLE_DATALIST macro to JavaScript enabled features macros + on WebKit.pri -2009-12-30 Laszlo Gombos + [Qt] Forward ENABLE_DATALIST macro to JavaScript enabled macros + https://bugs.webkit.org/show_bug.cgi?id=36547 - Reviewed by Simon Hausmann. + * WebCore.pri: - Turn off DataGrid support by default. +2010-03-25 Simon Hausmann - No new tests, as there is no new functionality. + Reviewed by Kenneth Rohde Christiansen. - * WebCore.pro: + [Qt] Fix the package build on Maemo 5 -2009-12-17 Yael Aharon + https://bugs.webkit.org/show_bug.cgi?id=36607 - Reviewed by Kenneth Rohde Christiansen. + Always embed the stylesheet for the no-listbox rendering. This way it'll be + included in the generated files for the package generation. - [Qt] support navigator.onLine and ononline/onoffline events. - https://bugs.webkit.org/show_bug.cgi?id=32555 + * WebCore.pri: - Hooked up Bearer Management to NetworkStateNotifier. This solution is available - only if QtMobility's Bearer Management is installed. +2010-03-19 Miikka Heikkinen - * WebCore.pro: - * platform/network/NetworkStateNotifier.h: - * platform/network/qt/NetworkStateNotifierPrivate.h: Added. - * platform/network/qt/NetworkStateNotifierQt.cpp: Added. - (WebCore::NetworkStateNotifierPrivate::NetworkStateNotifierPrivate): - (WebCore::NetworkStateNotifierPrivate::onlineStateChanged): - (WebCore::NetworkStateNotifierPrivate::~NetworkStateNotifierPrivate): - (WebCore::NetworkStateNotifier::updateState): - (WebCore::NetworkStateNotifier::NetworkStateNotifier): + Reviewed by Simon Hausmann. -2009-12-17 Simon Hausmann + [Qt] Support for QT_LIBINFIX in Symbian builds - Reviewed by Tor Arne Vestbø. + Configuring Qt with -qtlibinfix parameter will enable installing + an alternate version of Qt on devices that already have it on ROM. + This patch provides support for infixed builds of Webkit. - [Qt] Symbian build fix: Don't include QtXml/qxmlstream.h but omit the prefix, to - make sure we pick up the header file from QtCore. That is where the implementation - is compiled. + * WebCore.pro: - * dom/XMLTokenizer.h: +2010-03-24 Kent Tamura -2009-12-14 Holger Hans Peter Freyther + Reviewed by Darin Adler. - Reviewed by Kenneth Rohde Christiansen. + Make Icon::createIconForFiles() optional. + https://bugs.webkit.org/show_bug.cgi?id=35072 + + r54923 made Icon::createIconForFiles() deprecated. However moving + existing icon loading code to outside of WebCore is not good. So, + we assume: + - ChromeClient::chooseIconForFiles(), renamed from iconForFiles(), is + the primary API to load icons. + - Icon::createIconForFiles() is an optional API to help + implementing ChromeClient::iconForFiles(). + + This patch removes a call to Icon::createIconForFiles() from + FileChooser::loadIcon(), and ChromeClient::chooseIconForFiles() of + non-Chromium ports calls Icon::createIconForFiles(). + + * WebCore.base.exp: Export FileChooser::iconLoaded(), + Icon::createIconForFiles(), and Icon::~Icon(). + * WebCore.xcodeproj/project.pbxproj: Export Icon.h + * loader/EmptyClient.h: Rename iconForFiles() to chooseIconForFiles(). + * page/Chrome.cpp: ditto. + * page/Chrome.h: ditto. + * page/ChromeClient.h: ditto. + * platform/FileChooser.cpp: + (WebCore::FileChooser::loadIcon): + * platform/graphics/Icon.h: Remove a comment on createIconForFiles(). + * platform/graphics/chromium/IconChromiumLinux.cpp: Remove createIconForFiles(). + * platform/graphics/chromium/IconChromiumMac.cpp: ditto. + * platform/graphics/chromium/IconChromiumWin.cpp: ditto. + * rendering/RenderFileUploadControl.cpp: Rename iconForFiles() to chooseIconForFiles(). + * rendering/RenderFileUploadControl.h: ditto. - [Qt] Add manual test for JavaScript prompt corner case - https://bugs.webkit.org/show_bug.cgi?id=30914 +2010-03-23 Dan Bernstein - The patch is based on the work done by Gupta Manish. + Fixed typos. - Verify behavior of the JavaScript prompt function. Currently - Qt is not behaving like other WebKit ports and Firefox in - regards to accepting the prompt but not entering a text. + * manual-tests/plugin-visible-rect-change.html: - * manual-tests/qt/java-script-prompt.html: Added. +2010-03-23 Dan Bernstein -2009-12-21 Andreas Kling + Reviewed by John Sullivan. - Reviewed by Darin Adler. + WebCore part of + Plug-in clip rect does not update when overflow + clip changes + https://bugs.webkit.org/show_bug.cgi?id=36479. - Fix assertion failure when dragging an SVG image. - https://bugs.webkit.org/show_bug.cgi?id=32511 + * manual-tests/plugin-visible-rect-change.html: Added. + * platform/mac/WidgetMac.mm: + (WebCore::WidgetPrivate::WidgetPrivate): Added previousVisibleRect. + (WebCore::Widget::setFrameRect): If the visible rect changed but the + frame rect did not, send a -visibleRectDidChange message to the view, + if it responds to it. + (WebCore::Widget::releasePlatformWidget): Reset previousVisibleRect. + * rendering/RenderWidget.cpp: + (WebCore::RenderWidget::setWidgetGeometry): Track changes to the clip rect + imposed by the enclosing layer. Call Widget::setFrameRect when it changes, + even if the frame rect did not. + * rendering/RenderWidget.h: + (WebCore::RenderWidget::windowClipRect): Added this accessor. - Test: fast/images/drag-svg-as-image.html +2010-03-23 Simon Fraser - * svg/graphics/SVGImage.cpp: - (WebCore::SVGImage::filenameExtension): Return "svg" - * svg/graphics/SVGImage.h: + Reviewed by Dan Bernstein. -2009-11-23 Simon Hausmann + Assertion ASSERTION FAILED: rootLayer == m_clipRectsRoot at hulu.com + https://bugs.webkit.org/show_bug.cgi?id=34065 + + Fix another cause of assertions related to the clip rects root. Embeds + with zero size caused the overlap testing to fail, yet we require them to work + for correct compositing, so when the composited bounds is empty, use a 1x1 rect + for overlap testing. - Reviewed by Kenneth Rohde Christiansen. + Test: compositing/geometry/empty-embed-rects.html - [Qt] Wrong runtime instance objects of wrapped QObjects may be used if - the wrapped object died before the gc removed the instance. + * rendering/RenderLayerCompositor.cpp: + (WebCore::RenderLayerCompositor::addToOverlapMap): + (WebCore::RenderLayerCompositor::computeCompositingRequirements): - https://bugs.webkit.org/show_bug.cgi?id=31681 +2010-03-23 David Levin - Before using a cached instance, verify that its wrapped QObject is - still alive. + Reviewed by Nate Chapin. - * bridge/qt/qt_instance.cpp: - (JSC::Bindings::QtInstance::getQtInstance): - * bridge/qt/qt_instance.h: - (JSC::Bindings::QtInstance::hashKey): + [chromium] XMLHttpRequest.send sends 'undefined' string when passed undefined value. + https://bugs.webkit.org/show_bug.cgi?id=36506 -2009-11-25 Jocelyn Turcotte + Test: http/tests/xmlhttprequest/send-undefined-and-null.html - Reviewed by Simon Hausmann. + * bindings/v8/custom/V8XMLHttpRequestCustom.cpp: + (WebCore::isDocumentType): Unrelated style fix: fixed the casing of the method. + (WebCore::V8XMLHttpRequest::sendCallback): Added check for null/undefined to do the send. + This mirrors what is done in the JSC bindings. Previously, sending 'null' worked because + the last case, which did "toWebCoreStringWithNullCheck", resulted in sending an empty + request body. - [Qt] Fix crash of QtWebKit on any page with Flash when compiled with MinGW. +2010-03-23 Chris Evans - Fix inline assembly, don't dereference the function pointer twice. + Reviewed by Darin Adler. - * plugins/win/PluginViewWin.cpp: - (WebCore::PluginView::hookedBeginPaint): - (WebCore::PluginView::hookedEndPaint): + Fix hard-to-see crash due to incorrect libxml API usage. -2009-11-22 Jakub Wieczorek + https://bugs.webkit.org/show_bug.cgi?id=36000 - Reviewed by Adam Barth. + Test: fast/text/bad-encoding.html - [Qt] Remove the Referer header when redirecting to a non-secure site - https://bugs.webkit.org/show_bug.cgi?id=31785 + * dom/XMLTokenizerLibxml2.cpp: + (WebCore::XMLTokenizer::doEnd): Avoid operations on a closed context. - This makes Qt pass two tests introduced in r50226. +2010-03-23 Nate Chapin - * platform/network/qt/QNetworkReplyHandler.cpp: - (WebCore::QNetworkReplyHandler::sendResponseIfNeeded): + Unreviewed, revert r56376. -2009-11-19 Olivier Goffart + This revision introduced a crash in a couple of layout tests + on Chromium Linux. - Reviewed by Simon Hausmann. + * page/chromium/ChromeClientChromium.h: + * platform/chromium/PopupMenuChromium.cpp: + (WebCore::): + (WebCore::PopupContainer::create): + (WebCore::PopupContainer::PopupContainer): + (WebCore::PopupContainer::showPopup): + (WebCore::PopupContainer::showExternal): + (WebCore::PopupContainer::hidePopup): + (WebCore::PopupMenu::show): + * platform/chromium/PopupMenuChromium.h: + (WebCore::PopupItem::): + (WebCore::PopupItem::PopupItem): + (WebCore::PopupContainerSettings::): + (WebCore::PopupContainer::listBox): - [Qt] Normalize signal and slot signatures. +2010-03-23 David Hyatt - * platform/graphics/qt/MediaPlayerPrivatePhonon.cpp: - (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): + Reviewed by Simon Fraser and Darin Adler. -2009-11-18 Benjamin Poulain + https://bugs.webkit.org/show_bug.cgi?id=36272, make sure nth-child can work when the portion with "n" is omitted. - Reviewed by Simon Hausmann. + Added fast/css/nth-child-implied-step.html - [Qt] WebKit crashes when loading certain SVG images + * css/CSSGrammar.y: + * css/tokenizer.flex: - Check if the familly exist before creating the PlatformData from it. +2010-03-23 Darin Adler - https://bugs.webkit.org/show_bug.cgi?id=29443 + Reviewed by Sam Weinig. - Test: svg/text/text-font-invalid.html + Reduce and straighten internal use of DOMImplementation + https://bugs.webkit.org/show_bug.cgi?id=36501 - * platform/graphics/qt/FontFallbackListQt.cpp: - (WebCore::FontFallbackList::fontDataAt): + * WebCore.xcodeproj/project.pbxproj: Xcode decided to + re-sort this file. -2009-11-14 Antonio Gomes + * dom/Clipboard.cpp: Removed unneeded include of DOMImplementation.h. - Reviewed by Antti Koivisto. + * dom/DOMImplementation.cpp: Removed unneeded createDocument and + createHTMLDocument functions. These should be done directly instead + of involving the DOMImplementation class. + * dom/DOMImplementation.h: Ditto. - [Qt] Broken back/forward after using ErrorPageExtension to set error page - https://bugs.webkit.org/show_bug.cgi?id=30573 + * dom/DocumentType.cpp: Removed unneeded include of DOMImplementation.h. - Make FrameLoader::checkLoadCompleteForThisFrame method - to check for any working DocumentLoader instance (through - activeDocumentLoader()) instead of only checking for - 'm_provisionalDocumentLoader' in order to decide to if - it is going to reset of not the back and forward history. - after an error page has been loaded. + * html/HTMLViewSourceDocument.cpp: + (WebCore::HTMLViewSourceDocument::createTokenizer): Don't allocate a + DOMImplementation object just to use a class member function. - Test: LayoutTests/fast/history/back-forward-reset-after-error-handling.html + * loader/CachedFont.cpp: Removed unneeded include of DOMImplementation.h. - * loader/FrameLoader.cpp: - (WebCore::FrameLoader::checkLoadCompleteForThisFrame): + * xml/XMLHttpRequest.cpp: + (WebCore::XMLHttpRequest::responseXML): Use Document::create to create a + new document instead of involving DOMImplementation. + * xml/XSLTProcessor.cpp: + (WebCore::XSLTProcessor::createDocumentFromSource): Ditto. And in the case + where we do need to call DOMImplementation to interpret the MIME type, + don't allocate a DOMImplementation object just to use a class member + function. -2009-11-09 Laszlo Gombos +2010-03-23 Luiz Agostini Reviewed by Kenneth Rohde Christiansen. - [Qt] Few classes have virtual functions but non-virtual destructor - https://bugs.webkit.org/show_bug.cgi?id=31269 + [Qt] Maemo5 theme - all elements should be rendered as menu lists. + https://bugs.webkit.org/show_bug.cgi?id=36367 - No new tests as there is no functional change. + Enabling NO_LISTBOX_RENDERING in WebCore.pri for Maemo5. - * platform/qt/QWebPageClient.h: - (QWebPageClient::~QWebPageClient): Add virtual destructor. + * WebCore.pri: -2009-11-09 Yael Aharon +2010-03-22 Joseph Pecoraro - Reviewed by Kenneth Rohde Christiansen. + Reviewed by David Kilzer. - [Qt] Allow setting HTTP headers with empty value in XMLHTTPRequest - https://bugs.webkit.org/show_bug.cgi?id=31140 + Upstream iPhone KeyEvent platform code and share with Mac platform + https://bugs.webkit.org/show_bug.cgi?id=35870 - QtNetwork interprets null string as request to remove the header, not add it. - Replace null values with empty values before passing them to QtNetwork. + * platform/iphone/KeyEventCodesIPhone.h: Improper comment for #endif. + * platform/iphone/KeyEventIPhone.mm: Fixed headers. - Test: http/tests/xmlhttprequest/xmlhttprequest-setrequestheader-no-value.html +2010-03-23 David Hyatt - * platform/network/qt/ResourceRequestQt.cpp: - (WebCore::ResourceRequest::toNetworkRequest): + Reviewed by Jeremy Orlow. -2009-11-05 Jakub Wieczorek + https://bugs.webkit.org/show_bug.cgi?id=36277, make sure nth-child supports the positive unary prefix (+) as well as the negative + one (-). - Reviewed by Holger Freyther. + Added fast/css/nth-child-unary-prefix.html - [Qt] The XML tokenizer reports a parse error twice if it occurs before the document element is found. - https://bugs.webkit.org/show_bug.cgi?id=31144 + * css/tokenizer.flex: - XMLTokenizer::doEnd() uses an additional logic to report a parse failure in - documents that end prematurely but are not considered invalid by QXmlStream. - This is to stay compatible with the libxml2 implementation. - However, that code path would be also hit in situations when it should not, - i.e. the error would have already been caught and handled. As a result, the - same error would be reported twice. +2010-03-23 Andrey Kosyakov - No new tests, because the problem is already covered by - fast/parser/xml-declaration-missing-ending-mark.html. + Reviewed by Dmitry Titov. - * dom/XMLTokenizerQt.cpp: - (WebCore::XMLTokenizer::doEnd): + Change notification sent to inspector frontend on workers creation / destruction + to be posted asynchronously to avoid JS reenterability problems. Also, renamed + willDestroyWorker to didDestroyWorker to reflect that it gets called later and got + rid of explicit IDs for workers (use addresses instead). + https://bugs.webkit.org/show_bug.cgi?id=36213 -2009-11-05 Yuta Kitamura + * inspector/InjectedScriptHost.cpp: + (WebCore::InjectedScriptHost::didDestroyWorker): + * inspector/InjectedScriptHost.h: + * inspector/InjectedScriptHost.idl: + * inspector/InspectorController.cpp: + (WebCore::PostWorkerNotificationToFrontendTask::create): + (WebCore::PostWorkerNotificationToFrontendTask::PostWorkerNotificationToFrontendTask): + (WebCore::PostWorkerNotificationToFrontendTask::performTask): + (WebCore::InspectorController::postWorkerNotificationToFrontend): + (WebCore::InspectorController::didCreateWorker): + (WebCore::InspectorController::didDestroyWorker): + * inspector/InspectorController.h: + (WebCore::InspectorController::): + * inspector/InspectorFrontend.cpp: + (WebCore::InspectorFrontend::didDestroyWorker): + * inspector/InspectorFrontend.h: + * inspector/InspectorWorkerResource.h: + (WebCore::InspectorWorkerResource::create): + (WebCore::InspectorWorkerResource::id): + (WebCore::InspectorWorkerResource::InspectorWorkerResource): + * inspector/front-end/InjectedFakeWorker.js: + (InjectedFakeWorker.FakeWorker.prototype.terminate): + * inspector/front-end/WorkersSidebarPane.js: + (WebInspector.didDestroyWorker): + * workers/AbstractWorker.cpp: + (WebCore::AbstractWorker::AbstractWorker): + (WebCore::AbstractWorker::onDestroyWorker): + * workers/AbstractWorker.h: + (WebCore::AbstractWorker::asID): + * workers/SharedWorker.cpp: + (WebCore::SharedWorker::SharedWorker): + * workers/Worker.cpp: + (WebCore::Worker::Worker): - Reviewed by Eric Seidel. +2010-03-22 David Hyatt - Fix ASSERT(currentStyle = renderStyle()). - https://bugs.webkit.org/show_bug.cgi?id=31152 + Reviewed by Sam Weinig. - * dom/Element.cpp: - (WebCore::Element::pseudoStyleCacheIsInvalid): We should have used "==" instead of "=". + https://bugs.webkit.org/show_bug.cgi?id=36266, support DOM Level 3 focusin/focusout events. Add support for + IE onfocusin/onfocusout extensions to HTML. The old DOM level 2 names (DOMFocusIn/DOMFocusOut are still supported). -2009-11-04 Yael Aharon + Added fast/events/focusinout.html - Reviewed by Tor Arne Vestbø. + * dom/Document.cpp: + (WebCore::Document::setFocusedNode): + * dom/Event.cpp: + (WebCore::Event::aliasedType): + (WebCore::Event::hasAliasedType): + * dom/Event.h: + * dom/EventNames.h: + * dom/EventTarget.cpp: + (WebCore::EventTarget::fireEventListeners): + * dom/EventTarget.h: + * dom/Node.cpp: + (WebCore::Node::dispatchUIEvent): + * html/HTMLAttributeNames.in: + * html/HTMLButtonElement.cpp: + (WebCore::HTMLButtonElement::parseMappedAttribute): + * html/HTMLElement.cpp: + (WebCore::HTMLElement::parseMappedAttribute): + * html/HTMLFormControlElement.cpp: + (WebCore::HTMLTextFormControlElement::parseMappedAttribute): + * html/HTMLFrameSetElement.cpp: + (WebCore::HTMLFrameSetElement::parseMappedAttribute): + * html/HTMLSelectElement.cpp: + (WebCore::HTMLSelectElement::parseMappedAttribute): + * svg/SVGElement.cpp: + (WebCore::SVGElement::parseMappedAttribute): - [Qt] ASSERT failure when receiving 401 HTTP Authentication response. - https://bugs.webkit.org/show_bug.cgi?id=31077 +2010-03-23 MORITA Hajime - Allow sending the response body under the same conditions that we - allow it to finish without reporting an error. + Reviewed by Alexey Proskuryakov. - * platform/network/qt/QNetworkReplyHandler.cpp: - (WebCore::QNetworkReplyHandler::sendResponseIfNeeded): + WebCore::SelectionController::setSelection NULL pointer + https://bugs.webkit.org/show_bug.cgi?id=31545 -2009-11-03 Evan Martin + Added missing NULL-check that other APIs have. - Reviewed by Darin Adler. + Test: svg/dom/frame-related-api-during-load.html - Fix an off-by-one in the CSS lexer that causes memory corruption in - hard-to-trigger circumstances. + * svg/SVGSVGElement.cpp: + (WebCore::SVGSVGElement::deselectAll): - https://bugs.webkit.org/show_bug.cgi?id=30827 +2010-03-23 Qi Zhang - Test: fast/css/end-of-buffer-crash.html + Reviewed by Simon Hausmann. - * css/maketokenizer: Add comments, fix off-by-one. + [Qt] LayoutTests/fast/canvas/fillrect_gradient.html failed + https://bugs.webkit.org/show_bug.cgi?id=36444 -2009-11-02 Darin Adler + Handle duplicated or unsorted colorStop at platformDestory - Reviewed by Dan Bernstein. + * platform/graphics/qt/GradientQt.cpp: + (WebCore::Gradient::platformGradient): - Crash due to double-destroy related to CSS run-in property - https://bugs.webkit.org/show_bug.cgi?id=31034 - rdar://problem/7328458 +2010-03-23 Julien Chaffraix - Test: fast/css/run-in-crash.html + Unreviewed build fix. - * rendering/RenderBlock.cpp: - (WebCore::RenderBlock::destroy): Reorder destruction so the - continuation is destroyed after anonymous children. See comment - in the code for more details of why this is right. - * rendering/RenderInline.cpp: - (WebCore::RenderInline::destroy): Ditto. + Try to make the window buildbot happy. -2009-10-30 Kenneth Rohde Christiansen + * xml/XMLHttpRequestProgressEventThrottle.cpp: + * xml/XMLHttpRequestProgressEventThrottle.h: Move initialization of the + static const in the cpp file. - Reviewed by Holger Hans Peter Freyther. +2010-03-23 Pavel Feldman - If the owner widget of the page has a palette set, we - should use that one. This was only working when the - owner was a QWebView. This patch fixes that. + Reviewed by Timothy Hatcher. - * platform/qt/RenderThemeQt.cpp: - (WebCore::RenderThemeQt::applyTheme): + Web Inspector: make gear menu appear on styles panel at all times. -2009-10-29 Xan Lopez + https://bugs.webkit.org/show_bug.cgi?id=36490 - Reviewed by Oliver Hunt. + * inspector/front-end/inspector.css: - [GTK] Threading problems with some of the tests - https://bugs.webkit.org/show_bug.cgi?id=30814 +2010-03-23 Pavel Feldman - Create strings shared among threads with crossThreadString - constructor method. + Reviewed by Timothy Hatcher. - * storage/Database.cpp: - (WebCore::Database::Database): + Web Inspector: render nodes in inherited style bars as links. -2009-10-30 Tor Arne Vestbø + https://bugs.webkit.org/show_bug.cgi?id=36486 - Reviewed by NOBODY (OOPS!). + * English.lproj/localizedStrings.js: + * inspector/front-end/BreakpointsSidebarPane.js: + (WebInspector.BreakpointsSidebarPane.prototype._appendBreakpointElement.breakpointClicked): + (WebInspector.BreakpointsSidebarPane.prototype._appendBreakpointElement): + * inspector/front-end/StylesSidebarPane.js: + (WebInspector.StylesSidebarPane.prototype._update.else.insertInheritedNodeSeparator): + (WebInspector.StylesSidebarPane.prototype._update): + (WebInspector.StylesSidebarPane.prototype._selectNode): + * inspector/front-end/inspector.js: - [Qt] Use the default timeout interval for JS as the HTML tokenizer delay for setHtml() +2010-03-23 Julien Chaffraix - This ensures that long-running JavaScript (for example due to a modal alert() dialog), - will not trigger a deferred load after only 500ms (the default tokenizer delay) while - still giving a reasonable timeout (10 seconds) to prevent deadlock. + Reviewed by Alexey Proskuryakov. - https://bugs.webkit.org/show_bug.cgi?id=29381 + [XHR] onProgress event needs to be dispatched according to what the specification states + https://bugs.webkit.org/show_bug.cgi?id=18654 - * html/HTMLTokenizer.cpp: Change debug output to print the actual tokenizer delay + Test: http/tests/xmlhttprequest/xmlhttprequest-50ms-download-dispatch.html -2009-10-30 Tor Arne Vestbø + * Android.mk: + * GNUmakefile.am: + * WebCore.gypi: + * WebCore.pro: + * WebCore.vcproj/WebCore.vcproj: + * WebCore.xcodeproj/project.pbxproj: + Added XMLHttpRequestProgressEventThrottle to the build systems. - Reviewed by NOBODY (OOPS!). + * xml/XMLHttpRequest.cpp: + (WebCore::XMLHttpRequest::XMLHttpRequest): Created the throttle. + (WebCore::XMLHttpRequest::callReadyStateChangeListener): The 'readyState' event are + dispatched using the XMLHttpRequestProgressEventThrottle now. For the DONE state, we + need to flush any pending progress event as we do not want it to be dispatched after + the DONE readyState event. + (WebCore::XMLHttpRequest::createRequest): Made this event use the + XMLHttpRequestProgressEventThrottle for event dispatching. + (WebCore::XMLHttpRequest::abort): Ditto. + (WebCore::XMLHttpRequest::networkError): Ditto. + (WebCore::XMLHttpRequest::abortError): Ditto. + (WebCore::XMLHttpRequest::didReceiveData): Ditto. Also fixed a potential warning. + (WebCore::XMLHttpRequest::suspend): + (WebCore::XMLHttpRequest::resume): Implemented the logic for suspend / resume. + * xml/XMLHttpRequest.h: + * xml/XMLHttpRequestProgressEventThrottle.cpp: Added. + (WebCore::XMLHttpRequestProgressEventThrottle::XMLHttpRequestProgressEventThrottle): + (WebCore::XMLHttpRequestProgressEventThrottle::~XMLHttpRequestProgressEventThrottle): + (WebCore::XMLHttpRequestProgressEventThrottle::dispatchProgressEvent): Implemented the bulk + of the event throttling here: we use a timer to do so, as long as the timer is active it means + that events are coming faster than the throttling time and we coalesce them. + (WebCore::XMLHttpRequestProgressEventThrottle::dispatchEvent): Generic method to dispatch an event. + (WebCore::XMLHttpRequestProgressEventThrottle::flushProgressEvent): Called when we want to dispatch + any pending events and stopping any further dispatching. + (WebCore::XMLHttpRequestProgressEventThrottle::dispatchPausedEvent): Used to dispatch the event + that was queued due to the object being suspended. + (WebCore::XMLHttpRequestProgressEventThrottle::fired): Used to dispatch any coalesced event. + (WebCore::XMLHttpRequestProgressEventThrottle::hasEventToDispatch): Used to check if we have + an event to dispatch. + (WebCore::XMLHttpRequestProgressEventThrottle::suspend): Marked the object as suspended. + (WebCore::XMLHttpRequestProgressEventThrottle::resume): Dispatched the event that was queued. + * xml/XMLHttpRequestProgressEventThrottle.h: Added. + (WebCore::): + (WebCore::XMLHttpRequestProgressEventThrottle::suspended): - Clear the initial request when loading synchronously to prevent duplicate loads +2010-03-23 Pavel Feldman - MainResourceLoader uses the member m_initialRequest to store a request for future - deferred loads. When doing a synchronous load, in handleDataLoadNow(), we therefore - have to clear this request so that subsequent entries into the loader will not start - yet another load. + Reviewed by Timothy Hatcher. - This can for example happen in setDefersLoading() as a result of a PageGroupLoadDeferrer - going out of scope when returning from Chrome::runJavaScriptAlert(), where the alert() - came from a script executed as part of the first/original load. + Web Inspector: Element inspector search funtion: Error dispatching: performSearch. - https://bugs.webkit.org/show_bug.cgi?id=30879 + https://bugs.webkit.org/show_bug.cgi?id=36488 - * loader/MainResourceLoader.cpp: - (WebCore::MainResourceLoader::handleDataLoadNow): clear m_initialRequest + Test: inspector/elements-panel-search.html -2009-11-04 Jocelyn Turcotte + * inspector/front-end/ElementsPanel.js: + (WebInspector.ElementsPanel.prototype.performSearch): + (WebInspector.ElementsPanel.prototype.addNodesToSearchResult): + * inspector/front-end/InjectedScript.js: + (injectedScriptConstructor.): + (injectedScriptConstructor): - Reviewed by Timothy Hatcher. +2010-03-23 Qi Zhang - WebInspector: Use a different method to identify the webkit port in - InspectorBackent::platform(). - This corrects the inspector expected behavior with Qt on Windows. - https://bugs.webkit.org/show_bug.cgi?id=31116 + Reviewed by Simon Hausmann. - * inspector/InspectorBackend.cpp: - (WebCore::InspectorBackend::platform): - (WebCore::InspectorBackend::port): - * inspector/InspectorBackend.h: - * inspector/InspectorBackend.idl: - * inspector/front-end/InspectorControllerStub.js: - (.WebInspector.InspectorControllerStub.prototype.port): - * inspector/front-end/inspector.css: - * inspector/front-end/inspector.js: - (WebInspector.loaded): - (WebInspector.toolbarDragStart): + [Qt] fast/canvas/patternfill-repeat.html failed. + https://bugs.webkit.org/show_bug.cgi?id=34477 -2009-11-12 Benjamin Poulain + Change Pattern to expose the repeatX and repeatY + At GraphicsContextQt to apply repeatX and repeatY - Reviewed by Kenneth Rohde Christiansen. + * platform/graphics/Pattern.h: + (WebCore::Pattern::repeatX): + (WebCore::Pattern::repeatY): + * platform/graphics/qt/GraphicsContextQt.cpp: + (WebCore::GraphicsContext::drawLine): + (WebCore::GraphicsContext::fillRect): + (WebCore::GraphicsContext::rotate): - Custom printing shrink factors - https://bugs.webkit.org/show_bug.cgi?id=29042 +2010-03-23 Alex Milowski - This reverts commit r49769. The public API for this needs to be reviewed - before its inclusion in Qt. + Reviewed by Kenneth Rohde Christiansen. - * page/PrintContext.cpp: - (WebCore::PrintContext::begin): - * page/Settings.cpp: - (WebCore::Settings::Settings): - * page/Settings.h: + Removed the use of beta STIX fonts. -2009-11-09 Norbert Leser + * css/mathml.css: - Reviewed by Kenneth Rohde Christiansen. +2010-03-23 Gustavo Noronha Silva - Moved macro MMP_RULES (LINKEROPTION) into symbian instead of symbian-sbsv2, - since adjustment of RW-section base address will be needed for all new symbian - tool chains, specifically for arm and gcc compilation targets. - Also, change target address to 0xE00000 to be sufficient for all targets. + Reviewed by Holger Freyther. - * WebCore.pro: + [GTK] Does not build with latest GTK+ development release + https://bugs.webkit.org/show_bug.cgi?id=36398 -2009-11-11 Jocelyn Turcotte + Fix building with newest GTK+ versions. - Reviewed by Eric Seidel. + * GNUmakefile.am: + * platform/gtk/GtkPluginWidget.cpp: + (WebCore::GtkPluginWidget::invalidateRect): + (WebCore::GtkPluginWidget::paint): + * platform/gtk/GtkVersioning.h: Added. + * platform/gtk/PlatformScreenGtk.cpp: + (WebCore::getVisual): + (WebCore::screenRect): + (WebCore::screenAvailableRect): + * platform/gtk/ScrollbarGtk.cpp: + (ScrollbarGtk::paint): + * plugins/gtk/gtk2xtbin.c: + (gtk_xtbin_set_position): + (gtk_xtbin_unrealize): - [Qt] Make the default style background color valid. - Currently the color is transparent but invalid, this causes - list boxes in QtWebKit to be drawn with a black background - since r49242. - https://bugs.webkit.org/show_bug.cgi?id=31295 +2010-03-23 Laszlo Gombos - * rendering/style/RenderStyle.h: - (WebCore::InheritedFlags::initialBackgroundColor): - * rendering/style/StyleBackgroundData.cpp: - (WebCore::StyleBackgroundData::StyleBackgroundData): + Reviewed by Kenneth Rohde Christiansen. -2009-11-11 Simon Hausmann + [Qt] Remove support for Qt v4.4 + https://bugs.webkit.org/show_bug.cgi?id=36389 - Reviewed by Tor Arne Vestbø. + No new tests as there is no new functionality. - Introduce a function for querying the input method status - in QWebPageClient. + * WebCore.pri: + * WebCore.pro: + * platform/network/qt/ResourceHandleQt.cpp: + (WebCore::ResourceHandle::willLoadFromCache): + * platform/qt/CookieJarQt.cpp: + (WebCore::setCookies): + (WebCore::cookies): + * platform/qt/KURLQt.cpp: + (WebCore::KURL::operator QUrl): + * platform/qt/ScrollbarThemeQt.cpp: + (WebCore::ScrollbarThemeQt::paintScrollCorner): + * plugins/mac/PluginViewMac.cpp: - * platform/qt/QWebPageClient.h: +2010-03-23 Kent Tamura -2009-11-09 Yael Aharon + Reviewed by Adam Barth. - Reviewed by Kenneth Rohde Christiansen. + Add checks if setNeedsWillValidateCheck() and + setNeedsValidityCheck() are called correctly. + https://bugs.webkit.org/show_bug.cgi?id=34924 - [Qt] Pass credentials provided by XMLHTTPRequest to the network request. - https://bugs.webkit.org/show_bug.cgi?id=31208 + Introduce HTMLFormControlElement::m_willValidate and + m_isValid. They are the caches of willValidate() and + isValidFormControlElement(). setNeedsWillValidateCheck() updates + m_willValidate and setNeedsValidityCheck() updates m_isValid. - After r42483, the credentials are no longer passed to the network request - in the URL of the request. - Pass the credentials from XMLHTTPRequest to the network request, the same - way that other ports do. + willValidate() and isValidFormControlElement() have assertions to + check m_willvalidate or m_isValid has the correct state. If + setNeedsWillValidateCheck() or setNeedsValidityCheck() is needed + to be called and is not called, these assertions fail. - After this patch LayoutTests/http/xmlhttprequest/basic-auth.html passes. + * html/HTMLButtonElement.h: + (WebCore::HTMLButtonElement::recalcWillValidate): + * html/HTMLFieldSetElement.h: + (WebCore::HTMLFieldSetElement::recalcWillValidate): + * html/HTMLFormControlElement.cpp: + (WebCore::HTMLFormControlElement::HTMLFormControlElement): + (WebCore::HTMLFormControlElement::parseMappedAttribute): + (WebCore::HTMLFormControlElement::recalcWillValidate): + (WebCore::HTMLFormControlElement::willValidate): + (WebCore::HTMLFormControlElement::setNeedsWillValidateCheck): + (WebCore::HTMLFormControlElement::validationMessage): + (WebCore::HTMLFormControlElement::isValidFormControlElement): + (WebCore::HTMLFormControlElement::setNeedsValidityCheck): + * html/HTMLFormControlElement.h: + * html/HTMLInputElement.cpp: + (WebCore::HTMLInputElement::setInputType): + (WebCore::HTMLInputElement::parseMappedAttribute): + (WebCore::HTMLInputElement::setValue): + (WebCore::HTMLInputElement::recalcWillValidate): + * html/HTMLInputElement.h: + * html/HTMLTextAreaElement.cpp: + (WebCore::HTMLTextAreaElement::setNonDirtyValue): - * platform/network/qt/ResourceHandleQt.cpp: - (WebCore::ResourceHandle::start): - (WebCore::ResourceHandle::loadResourceSynchronously): +2010-03-22 Pavel Feldman -2009-11-03 Simon Hausmann + Reviewed by Dave Hyatt. - Unreviewed build fix for WebInspector with Qt build. + Web Inspector: display CSS selector source line in the styles sidebar pane. - Simply re-generate the Qt resource file by running - WebKitTools/Scripts/generate-qt-inspector-resource + https://bugs.webkit.org/show_bug.cgi?id=36414 - * inspector/front-end/WebKit.qrc: + This change adds a sourceLine field into the CSSStyleRule that is populated + from within the parser. CSSParser is now keeping track of the line numbers + and last selector line number that is being used while creating CSSStyleRules. -2009-11-03 Simon Hausmann + Test: inspector/styles-source-lines.html - Reviewed by Tor Arne Vestbø. + * css/CSSGrammar.y: + * css/CSSParser.cpp: + (WebCore::CSSParser::CSSParser): + (WebCore::CSSParser::lex): + (WebCore::CSSParser::countLines): + (WebCore::CSSParser::createStyleRule): + * css/CSSParser.h: + (WebCore::CSSParser::updateLastSelectorLine): + * css/CSSStyleRule.cpp: + (WebCore::CSSStyleRule::CSSStyleRule): + * css/CSSStyleRule.h: + (WebCore::CSSStyleRule::create): + (WebCore::CSSStyleRule::sourceLine): + * css/tokenizer.flex: + * inspector/InspectorDOMAgent.cpp: + (WebCore::InspectorDOMAgent::buildObjectForRule): + * inspector/front-end/DOMAgent.js: + (WebInspector.CSSStyleDeclaration.parseRule): + * inspector/front-end/StylesSidebarPane.js: + (WebInspector.StylePropertiesSection): - Make QWebPluginDatabase private API for now. +2010-03-22 Qi Zhang - https://bugs.webkit.org/show_bug.cgi?id=30775 + Reviewed by Laszlo Gombos. - * WebCore.pro: + [Qt] Fix arc function in canvas + https://bugs.webkit.org/show_bug.cgi?id=36296 -2009-11-03 Simon Hausmann + Based on HTLM5 spec (4.8.10.1.8 Complex shapes), arc function should draw a line to previous point, not only the arc. - Reviewed by Tor Arne Vestbø. + * platform/graphics/qt/PathQt.cpp: + (WebCore::Path::addArc): - Extended the conversion of the WebCore ResourceRequest to the - QNetworkRequest with a mandatory originating object argument, - which is meant to be the QWebFrame the request belongs to. +2010-03-19 Abhishek Arya - https://bugs.webkit.org/show_bug.cgi?id=29975 + Reviewed by Adam Barth. - * platform/network/qt/QNetworkReplyHandler.cpp: - (WebCore::QNetworkReplyHandler::QNetworkReplyHandler): - (WebCore::QNetworkReplyHandler::sendResponseIfNeeded): - (WebCore::QNetworkReplyHandler::start): - * platform/network/qt/ResourceRequest.h: - * platform/network/qt/ResourceRequestQt.cpp: - (WebCore::ResourceRequest::toNetworkRequest): + https://bugs.webkit.org/show_bug.cgi?id=36339 + Off-by-one memory corruption fix for long invalid websockets upgrade header -2009-11-02 Jedrzej Nowacki + Test: websocket/tests/long-invalid-header.html - Reviewed by Adam Barth. + * websockets/WebSocketHandshake.cpp: + (WebCore::WebSocketHandshake::readServerHandshake): - QWebView crash fix. +2010-03-22 Fumitoshi Ukai - The QWebView should not crash if the stop() method is called from - a function triggered by the loadProgress signal. + Unreviewed build fix for Chromim Mac at r56376 - A null pointer protection was added in the ProgressTracker::incrementProgress. + Fix initializer order of PopupContainer. - New autotest was created. + * platform/chromium/PopupMenuChromium.cpp: + (WebCore::PopupContainer::PopupContainer): - https://bugs.webkit.org/show_bug.cgi?id=29425 +2010-03-22 Jay Campan - * loader/ProgressTracker.cpp: - (WebCore::ProgressTracker::incrementProgress): + Reviewed by Darin Fisher. -2009-11-02 Kai Koehne + Making Chromium select popups not steal activation from the browser. + Select popups are now like autocomplete popups, shown in non-activated + windows. + https://bugs.webkit.org/show_bug.cgi?id=36062 - Reviewed by Holger Freyther. + * page/chromium/ChromeClientChromium.h: + * platform/chromium/PopupMenuChromium.cpp: + (WebCore::): + (WebCore::PopupContainer::create): + (WebCore::PopupContainer::PopupContainer): + (WebCore::PopupContainer::~PopupContainer): + (WebCore::PopupContainer::showPopup): + (WebCore::PopupContainer::showExternal): + (WebCore::PopupContainer::hidePopup): + (WebCore::PopupMenu::show): + * platform/chromium/PopupMenuChromium.h: + (WebCore::PopupContainer::): + (WebCore::PopupContainer::popupType): - Remove implementation of ImageDecocerQt::clearFrameBufferCache. - The implementation was buggy, and will visually break repeating - animations anyway. +2010-03-22 Dmitry Titov - https://bugs.webkit.org/show_bug.cgi?id=31009 + Reviewed by Nate Chapin. - * platform/graphics/qt/ImageDecoderQt.cpp: - (WebCore::ImageDecoderQt::clearFrameBufferCache): + [v8] Crash if the worker is terminated before its initial script is executed. + https://bugs.webkit.org/show_bug.cgi?id=36336 -2009-11-01 Yael Aharon + Test: fast/workers/termination-early.html - Reviewed by Darin Adler. + * bindings/v8/WorkerContextExecutionProxy.cpp: + (WebCore::WorkerContextExecutionProxy::initContextIfNeeded): Check for 0 context. When terminated, the v8 heap initialization returns 0. + (WebCore::WorkerContextExecutionProxy::evaluate): Don't execute script if initialization failed. + * bindings/v8/WorkerContextExecutionProxy.h: - Don't add '/' to the URL path if the it does not include '/' after the protocol component - https://bugs.webkit.org/show_bug.cgi?id=30971 +2010-03-22 Andrey Kosyakov - Match IE8 behaviour, that does not add '/' if there is none after the protocol component. + Reviewed by Pavel Feldman. - * platform/KURL.cpp: - (WebCore::KURL::parse): + Support creation of fake workers before document is loaded by deferring + attaching of fake workers iframe until document is loaded and buffering all + messages addressed to worker. + https://bugs.webkit.org/show_bug.cgi?id=36445 -2009-10-30 Kenneth Rohde Christiansen + * inspector/front-end/InjectedFakeWorker.js: + (InjectedFakeWorker.FakeWorker.prototype.postMessage): + (InjectedFakeWorker.FakeWorker.prototype._buildWorker): + (InjectedFakeWorker.FakeWorker.prototype._attachWorkerFrameToDocument): + (InjectedFakeWorker.FakeWorker.prototype._onWorkerFrameLoaded): - Reviewed by Holger Hans Peter Freyther. +2010-03-22 Darin Fisher - If the owner widget of the page has a palette set, we - should use that one. This was only working when the - owner was a QWebView. This patch fixes that. + Reviewed by Brady Eidson. - * platform/qt/RenderThemeQt.cpp: - (WebCore::RenderThemeQt::applyTheme): + HistoryController::replaceState() should modify m_currentItem + instead of the current HistoryItem of the BackForwardList. -2009-10-29 Laszlo Gombos + https://bugs.webkit.org/show_bug.cgi?id=36435 - Reviewed by Tor Arne Vestbø. + Test: fast/loader/stateobjects/replacestate-in-iframe.html - [Qt] Implement DELETE HTTP method for XmlHttpRequest - https://bugs.webkit.org/show_bug.cgi?id=30894 + * loader/HistoryController.cpp: + (WebCore::HistoryController::replaceState): - No new tests as this functionality is already tested by the - xmlhttprequest LayoutTests. As this patch depends on an unreleased - version of the dependent QtNetwork library and the tests will be - enabled later once the dependent library is released (and the - buildbot is updated). +2010-03-22 Joseph Pecoraro - * platform/network/qt/QNetworkReplyHandler.cpp: - (WebCore::QNetworkReplyHandler::QNetworkReplyHandler): - (WebCore::QNetworkReplyHandler::start): + Reviewed by David Kilzer. -2009-11-02 Tor Arne Vestbø + Upstream Part of the iPhone Platform sharing code with the Mac Platform + https://bugs.webkit.org/show_bug.cgi?id=35870 + and - Rubber-stamped by Antti Koivisto. + Part 3 of 3: Shared code between iphone and mac. The shared code was + refactored to be usable by both platforms without platform specific + typing, meaning no NSEvent versus WebEvent special cases. - [Qt] Build fix for Windows CE + Shared code usable by either mac or iphone platforms. - * plugins/PluginDatabase.cpp: + * platform/cocoa/KeyEventCocoa.h: + * platform/cocoa/KeyEventCocoa.mm: + (WebCore::keyIdentifierForCharCode): + (WebCore::windowsKeyCodeForKeyCode): + (WebCore::windowsKeyCodeForCharCode): -2009-11-02 Jocelyn Turcotte + Make use of the shared code. Keep anything platform specific in the + original file before calling the shared code. - Reviewed by Tor Arne Vestbø. + * platform/iphone/KeyEventIPhone.mm: + (WebCore::keyIdentifierForKeyEvent): + * platform/mac/KeyEventMac.mm: + (WebCore::keyIdentifierForKeyEvent): + (WebCore::windowsKeyCodeForKeyEvent): - [Qt] Fix Qt build on Windows. - https://bugs.webkit.org/show_bug.cgi?id=30905 +2010-03-22 Kevin Decker - * WebCore.pro: - * platform/graphics/BitmapImage.h: - * platform/graphics/qt/ImageQt.cpp: - (WebCore::BitmapImage::BitmapImage): - (WebCore::BitmapImage::create): - -2009-10-28 Adam Barth - - Reviewed by Eric Seidel. + Reviewed by Simon Fraser. - Don't run JavaScript URLs in view source mode - https://bugs.webkit.org/show_bug.cgi?id=30881 + https://bugs.webkit.org/show_bug.cgi?id=36328 - Just say no. + * rendering/RenderEmbeddedObject.cpp: + (WebCore::RenderEmbeddedObject::RenderEmbeddedObject): Fix a find/repalce mistake from my earlier patch. + Rename m_setShowsMissingPluginIndicator -> m_showsMissingPluginIndicator. + (WebCore::RenderEmbeddedObject::updateWidget): Don't update the widget if we're showing + the missing plug-in indicator. + (WebCore::RenderEmbeddedObject::paint):Fix a find/repalce mistake from my earlier patch. + Rename m_setShowsMissingPluginIndicator -> m_showsMissingPluginIndicator. + (WebCore::RenderEmbeddedObject::paintReplaced): Ditto. + * rendering/RenderEmbeddedObject.h: Ditto. + (WebCore::RenderEmbeddedObject::setShowsMissingPluginIndicator): Ditto. + (WebCore::RenderEmbeddedObject::showsMissingPluginIndicator): Ditto. - Test: http/tests/security/view-source-no-javascript-url.html +2010-03-22 Joseph Pecoraro - * bindings/ScriptControllerBase.cpp: - (WebCore::ScriptController::executeIfJavaScriptURL): + Reviewed by David Kilzer. -2009-10-29 Gustavo Noronha Silva + Upstream Part of the iPhone Platform sharing code with the Mac Platform + https://bugs.webkit.org/show_bug.cgi?id=35870 + - Unreviewed. Fixes style problems pointed out by Evan Martin. + Part 2 of 3: No changes other than moving code around. + Copied KeyEvent function from platform/mac to a platform/cocoa shared directory. - * platform/gtk/Language.cpp: - (WebCore::defaultLanguage): + * WebCore.xcodeproj/project.pbxproj: Added cocoa group and new files. + * platform/cocoa/KeyEventCocoa.h: Added. + * platform/cocoa/KeyEventCocoa.mm: Copied from WebCore/platform/mac/KeyEventMac.mm. + (WebCore::keyIdentifierForKeyEvent): + (WebCore::windowsKeyCodeForKeyEvent): Include the shared code. + * platform/mac/KeyEventMac.mm: -2009-10-29 Dan Bernstein +2010-03-22 Joseph Pecoraro - Rubber-stamped by Mark Rowe. + Reviewed by David Kilzer. - 64-bit Leopard build fix after r50259 - - * platform/graphics/mac/ComplexTextControllerATSUI.cpp: - Declared ATSUTextInserted in 64-bit. - (WebCore::fontHasMirroringInfo): Use %d format and cast to int. - (WebCore::disableLigatures): Ditto. - (WebCore::initializeATSUStyle): Ditto. - (WebCore::ComplexTextController::collectComplexTextRunsForCharacters): Ditto. + Part 1 of 3: Upstream iPhone KeyEvent platform code and share with Mac platform + https://bugs.webkit.org/show_bug.cgi?id=35870 + -2009-10-29 Dan Bernstein + * WebCore.xcodeproj/project.pbxproj: Added iphone group and new files. + * platform/iphone: Added. + * platform/iphone/KeyEventCodesIPhone.h: Added. + * platform/iphone/KeyEventIPhone.mm: Added. Ensure PLATFORM(IPHONE) + * platform/mac/KeyEventMac.mm: Ensure PLATFORM(MAC) - Tiger build fix after r50259 +2010-03-22 Kevin Decker + + Attempt to fix the Leopard build. + * rendering/RenderEmbeddedObject.cpp: Add ".f" to contants. - * platform/graphics/mac/ComplexTextController.h: - * platform/graphics/mac/ComplexTextControllerATSUI.cpp: +2010-03-22 Justin Schuh -2009-10-29 Dan Bernstein + Reviewed by Dirk Schulze. - Attempted Tiger build fix after r50259 + Out of bounds read in SVG feColorMatrix filter + https://bugs.webkit.org/show_bug.cgi?id=32714 - * platform/graphics/mac/ComplexTextControllerATSUI.cpp: + Prevents an invalid read when a valid values attribute is not + supplied for an feColorMatrix SVG filter. Also fixes general + handling of missing or invalid values attribute. -2009-10-28 Steve Falkenburg + Tests: svg/filters/feColorMatrix-invalid-value.svg + svg/filters/feColorMatrix-values.svg - Rubber stamped by Mark Rowe. + * svg/SVGFEColorMatrixElement.cpp: + (WebCore::SVGFEColorMatrixElement::build): - https://bugs.webkit.org/show_bug.cgi?id=30899 - WebKit fails to build release on 32-bit Windows systems +2010-03-22 Philippe Normand - * WebCore.vcproj/WebCore.vcproj: Excluded files from project. - * bindings/js/JSBindingsAllInOne.cpp: Added. + Reviewed by Eric Carlson. -2009-10-28 Dan Bernstein + [GStreamer] Use ImageBuffer API to do painting + https://bugs.webkit.org/show_bug.cgi?id=35783 - Reviewed by Jon Honeycutt. + New ImageGStreamer class abstracting the conversion of GStreamer + buffers to cairo surfaces. Using this makes the painting code of + the player more generic. - Fixed typos in color names. + * GNUmakefile.am: + * platform/graphics/gstreamer/ImageGStreamer.h: Added. + (WebCore::ImageGStreamer::image): + * platform/graphics/gstreamer/ImageGStreamerCairo.cpp: Added. + (ImageGStreamer::createImage): + (ImageGStreamer::ImageGStreamer): + (ImageGStreamer::~ImageGStreamer): + * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: + (WebCore::MediaPlayerPrivate::paint): + * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h: - * inspector/front-end/Color.js: +2010-03-22 Beth Dakin -2009-10-28 Dan Bernstein + Reviewed by Darin Adler. - Reviewed by Sam Weinig. + Fix for With Web Inspector opened, a crash + occurs at Webcore:getMatchedCSSRules() when navigating to a + previous page - Share code between the ATSUI- and Core Text-based Font implementations by doing the - following: - - Generalize CoreTextController as ComplexTextController, keeping the Core Text-specific - parts in ComplexTextControllerCoreText.cpp. - - Generalize FontMacCoreText as FontComplexTextMac using ComplexTextController - - Implement ATSUI-specific parts of ComplexTextController in ComplexTextControllerATSUI. - - Remove FontMacATSUI. - - * WebCore.xcodeproj/project.pbxproj: Removed CoreTextController.{cpp,h}, FontMacATSUI.mm, - and FontMacCoreText.cpp, and added ComplexTextController.{cpp,h}, - ComplexTextControllerATSUI.cpp, ComplexTextControllerCoreText.cpp, and - FontComplexTextMac.cpp. - - * platform/graphics/mac/ComplexTextController.cpp: Copied from CoreTextController.cpp and - kept the non-Core Text-specific bits. - (WebCore::ComplexTextController::ComplexTextController): Updated for renames, including - its own. - (WebCore::ComplexTextController::offsetForPosition): Updated for renames and for - m_complexTextRuns holding references instead of objects. - (WebCore::ComplexTextController::collectComplexTextRuns): Updated for renames, including - its own. - (WebCore::ComplexTextController::advance): Updated for renames. - (WebCore::ComplexTextController::adjustGlyphsAndAdvances): Updated for renames and for - m_complexTextRuns holding references instead of objects, and changed to use the glyphs() - and advances() accessors. - - * platform/graphics/mac/ComplexTextController.h: Copied from CoreTextController.h and - renamed CoreTextController to ComplexTextController and CoreTextRun to ComplexTextRun. Made - the latter RefCounted, added ATSUI-specific members to it, and made some other members - Core Text-specific. Renamed m_coreTextRuns to m_complexTextRuns and made it hold references - rather than objects. - (WebCore::ComplexTextController::ComplexTextRun::create): - (WebCore::ComplexTextController::ComplexTextRun::glyphs): - (WebCore::ComplexTextController::ComplexTextRun::advances): - - * platform/graphics/mac/ComplexTextControllerATSUI.cpp: Added. Includes ATSUI-specific - parts of the ComplexTextController implementation. - (WebCore::ComplexTextController::ComplexTextRun::overrideLayoutOperation): This ATSUI - callback populates the ComplexTextRun’s glyphs, advances and indices vectors. It is invoked - when the ComplexTextRun constructor calls ATSUGetGlyphBounds(). - (WebCore::isArabicLamWithAlefLigature): Helper function, copied from FontMacATSUI.mm. - (WebCore::shapeArabic): Helper function, adapted from FontMacATSUI.mm. - (WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun): Sets up the - ATSUTextLayout, substituting the text buffer if necessary for things like shaping Arabic, - mirroring glyphs or directionality overrides, then calls ATSUGetGlyphBounds() in order to - get the glyphs, advances and indices vectors populated. - (WebCore::fontHasMirroringInfo): Helper function, copied from FontMacATSUI.mm. - (WebCore::disableLigatures): Ditto. - (WebCore::initializeATSUStyle): Ditto, somewhat cleaned up and simplified. - (WebCore::ComplexTextController::collectComplexTextRunsForCharacters): Constructs - ComplexTextRuns, either missing-glyphs ones or ATSUTextLayout-based ones. - - * platform/graphics/mac/ComplexTextControllerCoreText.cpp: Copied from - CoreTextController.cpp and kept the Core Text-specific bits. - (WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun): Updated for renames, - including its own, and moved the code to initialize m_glyphs and m_advances here. Previously - this was done in adjustGlyphsAndAdvances(). - (WebCore::ComplexTextController::collectComplexTextRunsForCharacters): Updated for renames, - including its own. - * platform/graphics/mac/CoreTextController.cpp: Removed. - * platform/graphics/mac/CoreTextController.h: Removed. - * platform/graphics/mac/FontComplexTextMac.cpp: Renamed FontMacCoreText.cpp to this. - (WebCore::Font::selectionRectForComplexText): Changed to use ComplexTextController instead - of CoreTextController. - (WebCore::Font::drawComplexText): Ditto. - (WebCore::Font::floatWidthForComplexText): Ditto. - (WebCore::Font::offsetForPositionForComplexText): Ditto. - * platform/graphics/mac/FontMacATSUI.mm: Removed. - * platform/graphics/mac/FontMacCoreText.cpp: Removed. - -2009-10-27 Chris Fleizach + defaultView() can legitimately by null (as it is in this case), so + it must be null-checked. - Reviewed by Darin Adler. + * inspector/InspectorDOMAgent.cpp: + (WebCore::InspectorDOMAgent::getStyles): + (WebCore::InspectorDOMAgent::getComputedStyle): + (WebCore::InspectorDOMAgent::getMatchedCSSRules): - WAI-ARIA: add support for 'option' role - https://bugs.webkit.org/show_bug.cgi?id=30843 +2010-03-22 Kevin Decker - Test: accessibility/aria-option-role.html + Reviewed by Darin. - * accessibility/AccessibilityListBoxOption.h: - (WebCore::AccessibilityListBoxOption::canHaveChildren): - * accessibility/AccessibilityRenderObject.cpp: - (WebCore::RoleEntry::): - (WebCore::AccessibilityRenderObject::canHaveChildren): + https://bugs.webkit.org/show_bug.cgi?id=36328 + + * loader/FrameLoader.cpp: + (WebCore::FrameLoader::loadPlugin): Call setShowsMissingPluginIndicator(true) in cases that fail + to generate a widget. + * rendering/RenderEmbeddedObject.cpp: Added new missing plug-in related static constants + (WebCore::RenderEmbeddedObject::RenderEmbeddedObject): Initialize newly boolean to false. + (WebCore::RenderEmbeddedObject::paint): Added. + (WebCore::RenderEmbeddedObject::paintReplaced): Added. Draws a subtle rounded rectangle + containing the text "Missing Plug-in". + * rendering/RenderEmbeddedObject.h: Added the following two methods below. + (WebCore::RenderEmbeddedObject::setShowsMissingPluginIndicator): + (WebCore::RenderEmbeddedObject::showsMissingPluginIndicator): + * rendering/RenderWidget.h: Moved paint(PaintInfo&, int, int) from private to protected. + +2010-03-22 Jakub Wieczorek -2009-10-28 Jens Alfke + Reviewed by Kenneth Rohde Christiansen. - Reviewed by Eric Seidel. + [Qt] Phonon media backend: expose supported MIME types to WebCore - Fix GCC compiler warnings in WebCore, and enable -Wall and -Werror for Chromium build. - https://bugs.webkit.org/show_bug.cgi?id=30716 + https://bugs.webkit.org/show_bug.cgi?id=33453 - * WebCore.gyp/WebCore.gyp: Enable "chromium_code" flag, just on Mac build for now. - * accessibility/AccessibilityRenderObject.cpp: - (WebCore::createARIARoleMap): Fix struct visibiity warning. - * bindings/v8/ScriptCallStack.h: Fix out-of-order member initialization warning. - * bindings/v8/V8Collection.h: - (WebCore::getV8Object): Function in header should not be 'static' (fixes unused-static warning.) - * bindings/v8/V8DOMWrapper.cpp: - (WebCore::V8DOMWrapper::convertNewNodeToV8Object): Fix signed/unsigned comparison warning. - * bindings/v8/V8GCController.cpp: - (WebCore::ObjectGrouperVisitor::applyGrouping): Fix unused-variable warning. - * css/CSSPrimitiveValueMappings.h: - (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Enable ListButtonPart case to avoid - warning about missing cases in 'switch' statement. - * editing/EditorCommand.cpp: - (WebCore::createCommandMap): Fix struct visibiity warning. - * platform/graphics/skia/PlatformContextSkia.cpp: - (PlatformContextSkia::State::State): Fix out-of-order member initialization warning. - * rendering/RenderMediaControlsChromium.cpp: - (WebCore::RenderMediaControlsChromium::shouldRenderMediaControlPart): Add empty 'default' case in - 'switch' statement to avoid missing-case warning. - (WebCore::RenderMediaControlsChromium::paintMediaControlsPart): Ditto. - * xml/XPathFunctions.cpp: - (WebCore::XPath::createFunctionMap): Fix struct visibiity warning. + MediaPlayerPrivate should expose the MIME types that are supported + by the underlying backend in Phonon. -2009-10-29 Adam Barth + * platform/graphics/qt/MediaPlayerPrivatePhonon.cpp: + (WebCore::MediaPlayerPrivate::supportedTypesCache): + (WebCore::MediaPlayerPrivate::getSupportedTypes): + (WebCore::MediaPlayerPrivate::supportsType): + * platform/graphics/qt/MediaPlayerPrivatePhonon.h: - Reviewed by Darin Adler. +2010-03-22 Alexander Pavlov - REGRESSION: crashes in WebCore::RedirectScheduler::timerFired(WebCore::Timer*) - https://bugs.webkit.org/show_bug.cgi?id=30839 + Reviewed by Pavel Feldman. - Added null check for the case when the frame is detached from the page. + Web Inspector: AuditRules still use getMatchedCSSRules as a part of the img-related audit. + https://bugs.webkit.org/show_bug.cgi?id=36424 - * loader/RedirectScheduler.cpp: - (WebCore::RedirectScheduler::timerFired): + * inspector/front-end/AuditRules.js: + (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun): + (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.receivedImages): + (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.pushImageNodes): + * inspector/front-end/InjectedScript.js: + (injectedScriptConstructor): -2009-10-28 Joanmarie Diggs +2010-03-22 Darin Adler - Reviewed by Xan Lopez. + Reviewed by Dan Bernstein. - https://bugs.webkit.org/show_bug.cgi?id=30817 - Use parentObjectUnignored instead of parentObject in webkit_accessible_get_parent + TextBreakIteratorICU.cpp is incompatible with new UBreakIterator type in ICU 4.4 + https://bugs.webkit.org/show_bug.cgi?id=36381 - Also removes the hack I had originally added to solve bug 25411, because - the fix here is what I should have done in the first place. + * platform/text/TextBreakIteratorICU.cpp: + (WebCore::setUpIterator): Use reinterpret_cast instead of static_cast or relying + on conversion to void*. + (WebCore::textBreakFirst): Ditto. + (WebCore::textBreakLast): Ditto. + (WebCore::textBreakNext): Ditto. + (WebCore::textBreakPrevious): Ditto. + (WebCore::textBreakPreceding): Ditto. + (WebCore::textBreakFollowing): Ditto. + (WebCore::textBreakCurrent): Ditto. + (WebCore::isTextBreak): Ditto. + (WebCore::setUpIteratorWithRules): Ditto. - * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: - (webkit_accessible_get_parent): +2010-03-22 Eric Carlson -2009-10-28 Dmitry Titov + Reviewed by Sam Weinig. - Reviewed by David Levin. + Typo in GPL license text + https://bugs.webkit.org/show_bug.cgi?id=36442 - https://bugs.webkit.org/show_bug.cgi?id=30805 - Add MessageQueue::removeIf(Predicate&) to remove certain tasks without pulling them from the queue. - Existing Database tests cover this, no change in functionality. + Fix typo - "aint with this library" -> "along with this library". - * storage/DatabaseThread.cpp: - (WebCore::SameDatabasePredicate::SameDatabasePredicate): Added predicate that flags the tasks belonging to a specified database. - (WebCore::SameDatabasePredicate::operator()): - (WebCore::DatabaseThread::unscheduleDatabaseTasks): changed to use the new removeIf method. + * bindings/scripts/CodeGenerator.pm: + * bindings/scripts/CodeGeneratorJS.pm: + * bindings/scripts/CodeGeneratorObjC.pm: + * bindings/scripts/CodeGeneratorV8.pm: + * bindings/scripts/IDLParser.pm: + * bindings/scripts/IDLStructure.pm: + * bindings/scripts/generate-bindings.pl: -2009-10-28 Pavel Feldman +2010-03-22 Jakub Wieczorek - Reviewed by Timothy Hatcher. + Reviewed by Simon Hausmann. - Web Inspector: Glue subsequent timeline records with same category - and title together. + [Qt] Don't construct a QLineEdit every time when painting a text field + https://bugs.webkit.org/show_bug.cgi?id=36373 - https://bugs.webkit.org/show_bug.cgi?id=30885 + Instead, keep one instance per RenderTheme around. - * English.lproj/localizedStrings.js: - * inspector/front-end/TimelinePanel.js: - (WebInspector.TimelinePanel.prototype.addRecordToTimeline): - (WebInspector.TimelinePanel.prototype._formatRecord): - (WebInspector.TimelineRecordTreeElement.prototype.onattach): - (WebInspector.TimelineRecordTreeElement.prototype.refresh): + * platform/qt/RenderThemeQt.cpp: + (WebCore::findFrameLineWidth): -2009-10-28 Gustavo Noronha Silva +2010-03-22 Luiz Agostini - Reviewed by Xan Lopez. + Reviewed by Kenneth Rohde Christiansen. - [GTK] Fails new test fast/js/navigator-language.html - https://bugs.webkit.org/show_bug.cgi?id=30440 + [Qt] Multiselect Popup - adjusting QtAbstractWebPopup + https://bugs.webkit.org/show_bug.cgi?id=36186 - Reimplement WebCore::defaultLanguage to account for changes in - locale done by setLocale. + QtAbstractWebPopup must provide new methods to be used by its descendants that + wish to handle elements. - Already existing test: fast/js/navigator-language.html + * platform/qt/QtAbstractWebPopup.cpp: + (WebCore::QtAbstractWebPopup::selectItem): + (WebCore::QtAbstractWebPopup::multiple): + * platform/qt/QtAbstractWebPopup.h: - * platform/gtk/Language.cpp: - (WebCore::defaultLanguage): +2010-03-22 Alex Milowski -2009-10-28 Eric Carlson + Reviewed by Kenneth Rohde Christiansen. - Reviewed by Simon Fraser. + Added basic support for mfrac (fractions) - - Can't exit full screen mode or restart movie after pressing command -R. + Test: mathml/presentation/fractions.xhtml - * html/HTMLMediaElement.cpp: - (WebCore::HTMLMediaElement::removedFromDocument): - (WebCore::HTMLMediaElement::documentWillBecomeInactive): - Exit from fullscreen if necessary. - * html/HTMLMediaElement.h: + * WebCore.xcodeproj/project.pbxproj: + * mathml/MathMLInlineContainerElement.cpp: + (WebCore::MathMLInlineContainerElement::createRenderer): + * mathml/RenderMathMLFraction.cpp: Added. + (WebCore::RenderMathMLFraction::RenderMathMLFraction): + (WebCore::RenderMathMLFraction::updateFromElement): + (WebCore::RenderMathMLFraction::addChild): + * mathml/RenderMathMLFraction.h: Added. -2009-10-28 Alexey Proskuryakov +2010-03-22 Kevin Decker - Unreviewed - a trivial fix to get Windows bots running. + Reviewed by John Sullivan. - https://bugs.webkit.org/show_bug.cgi?id=30841 - WebKit should not pass Referer header through a redirect to a non-secure site + https://bugs.webkit.org/show_bug.cgi?id=36328 - * platform/network/cf/ResourceRequestCFNet.cpp: (WebCore::setHeaderFields): Don't try to - access empty vector's data. + * page/mac/WebCoreViewFactory.h: Added -missingPluginText method + * platform/LocalizedStrings.h: Added missingPluginText() + * platform/gtk/LocalizedStringsGtk.cpp: Likewise. + * platform/mac/LocalizedStringsMac.mm: Same here. + * platform/qt/Localizations.cpp: Ditto. -2009-10-28 Joanmarie Diggs +2010-03-22 Yury Semikhatsky - Reviewed by Xan Lopez. + Reviewed by Pavel Feldman. - https://bugs.webkit.org/show_bug.cgi?id=25897 - [Gtk] Extraneous object of ROLE_PANEL in hierarchy for entries + Handle worker exceptions in V8MessageHandler like it's done in regular documents. This way all worker exceptions will be logged in the console not only those which happen in event listeners. - Remove the extraneous object of ROLE_PANEL. + https://bugs.webkit.org/show_bug.cgi?id=31171 - * accessibility/gtk/AccessibilityObjectAtk.cpp: - (AccessibilityObject::accessibilityPlatformIncludesObject): + * bindings/v8/V8AbstractEventListener.cpp: + (WebCore::V8AbstractEventListener::invokeEventHandler): Removed explicit call to reportException. + * bindings/v8/V8Utilities.cpp: reportException function was removed since it's not used. + (WebCore::getScriptExecutionContext): + * bindings/v8/V8Utilities.h: + * bindings/v8/WorkerContextExecutionProxy.cpp: + (WebCore::v8MessageHandler): + (WebCore::WorkerContextExecutionProxy::initContextIfNeeded): Setup message handler when first worker context is created. -2009-10-28 Jonathan Dixon +2010-03-22 Leandro Pereira - Reviewed by Eric Seidel. + Reviewed by Simon Hausmann. - Bug 30547: (Chromium) searchbox not rendered properly due to the css property -webkit-border-radius - https://bugs.webkit.org/show_bug.cgi?id=30547 + Add EFL-specific code to page/EventHandler.cpp. + http://webkit.org/b/36306 - Test: fast/css/text-input-with-webkit-border-radius.html + * page/EventHandler.cpp: - * rendering/RenderThemeChromiumWin.cpp: - (WebCore::RenderThemeChromiumWin::paintTextFieldInternal): - Implemented rounded border rendering in Chromium Windows theme renderer. +2010-03-22 Leandro Pereira -2009-10-28 Pavel Feldman + Reviewed by Simon Hausmann. - Reviewed by Timothy Hatcher. + Add EFL-specific code to platform/DragImage.h and + platform/DragData.h. + http://webkit.org/b/36310 - Web Inspector: Pull items collections from resources panel and - timeline panel into AbstractTimelinePanel. + * platform/DragImage.h: + * platform/DragData.h: - https://bugs.webkit.org/show_bug.cgi?id=30875 +2010-03-22 Leandro Pereira - * inspector/front-end/AbstractTimelinePanel.js: - (WebInspector.AbstractTimelinePanel): - (WebInspector.AbstractTimelinePanel.prototype.populateSidebar): - (WebInspector.AbstractTimelinePanel.prototype.createItemTreeElement): - (WebInspector.AbstractTimelinePanel.prototype.createItemGraph): - (WebInspector.AbstractTimelinePanel.prototype._showCategory): - (WebInspector.AbstractTimelinePanel.prototype._hideCategory): - (WebInspector.AbstractTimelinePanel.prototype.filter): - (WebInspector.AbstractTimelinePanel.prototype._createGraph): - (WebInspector.AbstractTimelinePanel.prototype.updateMainViewWidth): - (WebInspector.AbstractTimelinePanel.prototype.refresh): - (WebInspector.AbstractTimelinePanel.prototype.reset): - (WebInspector.AbstractTimelinePanel.prototype.get calculator): - (WebInspector.AbstractTimelinePanel.prototype.set calculator): - (WebInspector.AbstractTimelinePanel.prototype.addItem): - (WebInspector.AbstractTimelinePanel.prototype.removeItem): - (WebInspector.AbstractTimelinePanel.prototype.refreshItem): - (WebInspector.AbstractTimelinePanel.prototype.revealAndSelectItem): - (WebInspector.AbstractTimelinePanel.prototype.sortItems): - (WebInspector.AbstractTimelinePanel.prototype.adjustScrollPosition): - (WebInspector.AbstractTimelineCategory): - (WebInspector.AbstractTimelineCategory.prototype.toString): - * inspector/front-end/ResourceCategory.js: - (WebInspector.ResourceCategory): - * inspector/front-end/ResourcesPanel.js: - (WebInspector.ResourcesPanel): - (WebInspector.ResourcesPanel.prototype.createItemTreeElement): - (WebInspector.ResourcesPanel.prototype.createItemGraph): - (WebInspector.ResourcesPanel.prototype.isCategoryVisible): - (WebInspector.ResourcesPanel.prototype.populateSidebar): - (WebInspector.ResourcesPanel.prototype.get searchableViews): - (WebInspector.ResourcesPanel.prototype.get searchResultsSortFunction.sortFuction): - (WebInspector.ResourcesPanel.prototype.get searchResultsSortFunction): - (WebInspector.ResourcesPanel.prototype.searchMatchFound): - (WebInspector.ResourcesPanel.prototype.searchCanceled): - (WebInspector.ResourcesPanel.prototype.performSearch): - (WebInspector.ResourcesPanel.prototype.refresh): - (WebInspector.ResourcesPanel.prototype.reset): - (WebInspector.ResourcesPanel.prototype.removeResource): - (WebInspector.ResourcesPanel.prototype.addMessageToResource): - (WebInspector.ResourcesPanel.prototype.clearMessages): - (WebInspector.ResourcesPanel.prototype.refreshResource): - (WebInspector.ResourcesPanel.prototype.recreateViewForResourceIfNeeded): - (WebInspector.ResourcesPanel.prototype.showResource): - (WebInspector.ResourcesPanel.prototype._sortResourcesIfNeeded): - (WebInspector.ResourcesPanel.prototype._toggleLargerResources): - (WebInspector.ResourcesPanel.prototype._toggleResourceTracking): - (WebInspector.ResourcesPanel.prototype.get _resources): - (WebInspector.ResourceTimeCalculator.prototype._upperBound): - * inspector/front-end/TimelinePanel.js: - (WebInspector.TimelinePanel): - (WebInspector.TimelinePanel.prototype.get categories): - (WebInspector.TimelinePanel.prototype.populateSidebar): - (WebInspector.TimelinePanel.prototype.addRecordToTimeline): - (WebInspector.TimelinePanel.prototype.createItemTreeElement): - (WebInspector.TimelinePanel.prototype.createItemGraph): - (WebInspector.TimelinePanel.prototype._formatRecord): - (WebInspector.TimelineCategory): - * inspector/front-end/inspector.css: - * inspector/front-end/inspector.html: + Reviewed by Simon Hausmann. -2009-10-28 Kelly Norton + Add EFL-specific code to platform/FileSystem.h. + http://webkit.org/b/36313 - Reviewed by Pavel Feldman. + * platform/FileSystem.h: - Resets InspectorFrontend in InspectorTimelineAgent instead of removing it so - that it remains active on refreshs and page transitions. - https://bugs.webkit.org/show_bug.cgi?id=30874 +2010-03-22 Leandro Pereira - * inspector/InspectorController.cpp: - (WebCore::InspectorController::setFrontendProxyObject): - * inspector/InspectorTimelineAgent.cpp: - (WebCore::InspectorTimelineAgent::resetFrontendProxyObject): - * inspector/InspectorTimelineAgent.h: + Reviewed by Simon Hausmann. -2009-10-27 Shinichiro Hamaji + Add EFL-specific code to platform/Cursor.h. + http://webkit.org/b/36319 - Reviewed by Darin Adler. + * platform/Cursor.h: - Provide a way to get counter values with layoutTestContoller - https://bugs.webkit.org/show_bug.cgi?id=30555 +2010-03-22 Leandro Pereira - Expose WebCore::counterValueForElement as a WebCore API. + Reviewed by Simon Hausmann. - * WebCore.base.exp: - * rendering/RenderTreeAsText.cpp: - (WebCore::writeCounterValuesFromChildren): - (WebCore::counterValueForElement): - * rendering/RenderTreeAsText.h: + Add EFL-specific code to platform/NotImplemented.h. + http://webkit.org/b/36320 -2009-10-28 Nate Chapin + * platform/NotImplemented.h: - Unreviewed, Chromium build fix for r50225. +2010-03-21 Kim Grönholm - * loader/FrameLoader.cpp: - (WebCore::FrameLoader::defaultObjectContentType): + Reviewed by Simon Hausmann. -2009-10-28 Eric Z. Ayers + [Qt] GraphicsLayer: matrix interpolations in transform-animations don't behave correctly + https://bugs.webkit.org/show_bug.cgi?id=35520 + + The case where the list of source and target transform operations are + not the same but have the same size needs to be special-cased in + GraphicsLayerQt, as well as the case where the source or target + operation list is empty. The URLs listed here render correctly after + applying the patch. - Reviewed by Pavel Feldman. + Tests: https://bug-35520-attachments.webkit.org/attachment.cgi?id=49890 + https://bug-35520-attachments.webkit.org/attachment.cgi?id=49889 + - Adds InspectorTimelineAgent instrumentation for encountering a -