summaryrefslogtreecommitdiffstats
path: root/config/gnu-warnings
Commit message (Collapse)AuthorAgeFilesLines
* Re-promote some GNU warnings to errors (#1508)David Young2022-05-064-48/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Promote some GCC warnings back to errors and deal with build breakage. I tested configuring and building with GCC 8.3.0 with `.../configure --prefix=$HOME/wrk/install/manydsets --enable-build-mode=production --enable-symbols=-gdwarf-4 --enable-warnings-as-errors --enable-java --enable-hl --enable-fortran --enable-cxx --enable-mirror-vfd --enable-ros3-vfd --enable-direct-vfd` and with the same options but `--enable-build-mode=debug`. * Promote -Wrestrict to -Werror=restrict to help catch overlapping arguments to strcpy, memcpy, et cetera, at compile time. * NFCI: sort lines. * Committing clang-format changes * NFCI: remove whitespace at EOL. * Re-use temporary variable `shared`. * Remove merge oopsie. * Mention that no op codes are understood per review comment. * Change this back to the develop branch's way, since this change isn't integral to the PR. * Committing clang-format changes * NFCI: reduce differences with `develop` branch in the hope that that also kicks off CI. Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Dana Robinson <43805+derobins@users.noreply.github.com>
* Fixes for format string warnings raised by -Wformat=2/-Wformat-security (#1489)Dana Robinson2022-03-113-14/+4
|
* Move -Werror=int-conversion from error-general to error-5 in (#1194)Larry Knox2021-11-142-1/+1
| | | gnu-warnings (unrecognized command line option for gcc 4.85/4.93.
* Make it an error if the library implicitly converts from integer to (#1165)David Young2021-11-131-0/+2
| | | | | pointer or from pointer to integer (-Werror=int-conversion). Also, make it an error if the library explicitly converts to pointer from an integer of a different size (-Werror=int-to-pointer-cast).
* Fix the function cast error in H5Dchunk.c and activate (#1170)David Young2021-11-081-4/+1
| | | `-Werror=cast-function-type`. Again.
* Github #1019 - add Fortran developer flags (#1090)Allen Byrne2021-10-271-0/+0
|
* Move test utilities to utils/test folder (#1109)Allen Byrne2021-10-202-0/+25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Move test utilities to utils/test folder * Fix makefile assignment * Add new dir * add new folder * Correct copied makefile * Fix dir typo * Add missing include dir * Remove unnecessary lib link * Correct dependent dirs * Fix conditional checks * Disable test if not built * fix path to executable * Use fixture for swmr_vfd check * Add release note * Correct shell tests and c++ flag warning * Update autotools c++ warning * Fix typo
* To reduce maintenance effort, delete the `noerror-` variants of the compiler ↵David Young2021-10-065-172/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | flags files (#1033) * Avoid maintenance headaches: delete the `noerror-` variants of the compiler flags files, since they essentially duplicate the `error-` files modulo the replacement of `-Werror=` with `-W` and any changes in comments. (I verified the duplication with a script.) For autoconf, reinstate the use of the `demote_errors` shell function to derive the `noerror-` content from the `error-` content. `demote_errors` replaces `-Werror=` with `-W` when `WARNINGS_AS_ERRORS` is `no`. Slightly reorder `configure.ac` so that the setting of `WARNINGS_AS_ERRORS` takes effect before the `error-` files are sourced. * Take a stab at updating the CMake files to match the changes I made to the autoconf files to remove `noerror-` files. I'm not much of a CMake user so these changes are quite rough. Looks like the duplication can be reduced with the introduction of a new macro. * Delete `noerror-` files from the MANIFEST. * Reduce duplication in the CMake files: perform the HDF5_ENABLE_WARNINGS_AS_ERRORS test once in the ADD_H5_FLAGS macro. * Add a release note.
* Organize and align compiler flags (#741)Allen Byrne2021-06-113-2/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * OESS-98 convert plugin option to FetchContent, add tests * Fixes for pkcfg files because of plugin option * OESS-98 fix tools test for plugins * Keep doxygen comments under 100 chars long - format hint * Whitespace * HDFFV-11144 - Reclassify CMake messages * HDFFV-11099/11100 added help text * Reworked switch statement to compare string instead * Fix typo * Update CDash mode * Correct name of threadsafe * Correct option name * Undo accidental commit * Note LLVM 10 to 11 format default changes * Update format plugin * Undo clang-format version 11 changes * One more correction * Update supported platforms * Revert whitespace changes * Correct whitespace * Changes from PR#3 * HDFFV-11213 added option to control gcc10 warnings diagnostics * HDFFV-11212 Use the new references correctly in JNI utility and tests * format source * Fix typo * Add new test file * HDFFV-11212 - update test and remove unused arg * Minor non-space formatting changes * Use H5I_INVALID_ID instead of "-1" * source formatting * add missing testfile, update jni function * Undo commit of debug code * remove mislocated file * Fix h5repack test for handling of fapls and id close * Update h5diff test files usage text * HDFFV-11212 add new ref tests for JNI export dataset * src format update * Remove blank line typo * src format typo * long double requires %Lg * Another long double foramt specifer S.B. %Lg * issue with t128bit test * Windows issue with h5dump and type. * Fix review issues * refactor function nesting and fix error checks * format fixes * Remove untested functions and javadoc quiet comments * Restore TRY block. * Change string append errors to memory exception * revert to H5_JNI_FATAL_ERROR - support functions need work * Add assertion error for h5util functions * remove duplicate function * format fix * Revert HD function error handling * Update copyright comments * GH #386 java folder copyright corrections * Whitespace * GH #359 implement and fix tools 1.6 API usage * remove excessive comments * Flip inits to correct ifdef section * rework ifdef to be simpler * format issue * Reformat ifdef inits * remove static attribute * format compliance * Update names * Revert because logic relies on float not being int * Changes noticed from creating merge of #412 * Double underscore change * Correct compiler version variable used * Remove header guard underscores * Whitespace cleanup * Split format source and commit changes on repo push * remove pre-split setting * Change windows TS to use older VS. * correct window os name * HDFFV-11212 JNI export util and Javadoc * Suggested review changes * Another change found * Committing clang-format changes * HDFFV-11113 long double in tools * HDFFV-11113 add note * Disable long double tests for now * HDFFV-11228 remove arbitrary CMake warning groups. * Make each flag a string * Some Javadoc warning fixes * Updated javadoc fixes * # WARNING: head commit changed in the meantime HDFFV-11229 Fix long double usage in tools and java Changed h5dump and h5ls to just print 128-bit for long double type. Added test and file for dataset and attributes with all three float types. * Committing clang-format changes * HDFFV-11229 Add release note * HDFFV-11229 windows testfile needed * fix typo * Remove non supported message text * HDFFV-11229 - change ldouble test to check both native and general * HDFFV-11229 add second file compare * HDFFV-11229 fix reference file * HDFFV-11229 autotools check two refs * HDFFV-11229 revert back to removal of NATIVE_LDOUBLE in tools output * Committing clang-format changes * Update release note * Update attribute type of ref file * Change source of ninja for macs * try port instead of brew * Recommended is to use brew. * Undo non long double changes * remove unneeded file * Fix perl and doxygen CMake code * Add "option" command for clang options * Rework CMake add_custom to use the BYPRODUCTS argument * Add stamp files to BYPRODUCTS * Only one copy of file exists * Fix custom cmmand depends targets * Fix fortran custom command DEPENDS * Add LD_LIBRARY_PATH to tests * Add custom target for DEPENDS * Add h5detect conditionaly to generated target DEPENDS * Correct DEPENDS targets * Parallel builds need the mpi compiler for pkgconfig scripts. * install only if MPI build * Fortran target depends * Remove incorrect source attribute * doxygen adjustments * doxygen build updates * Correct version * Correct function version - function has been merged to 1.12 * Correct version string for map functions * Cleanup warnings for tools debug builds * TRILAB-227 - fix indexing for h5diff selections * Correct location of pos to index function call * TRILAB-227 Enable test * Quote subset args * Use MATCHES because of AppleClang * if blocks needed for build modes * Update list of DT platforms * VS2019 correctly displays float values * revert VS2019 change * Issue #669 remove version from pkgcfg filename * remove version from h5cc script * Java reference functions updated enabled fortran in cmake gcc action yaml file java reference test changed to correctly test refs jni reference functions that create ids changed to use jni id logging * Correct BYPRODUCTS argument * Correct more genereated files BYPRODUCTS * BYPRODUCTS must have unique locations * Fix typo * Fix fortran configure checks * Rework H5_PAC_C_MAX_REAL_PRECISION setting logic * Add note about fortran configure change * Adds a quick for for some egregious chunk_info badness (#722) * Fixes issue with ccmake that prevents building Fortran (#723) ccmake runs iteratively, and the check_fortran_source_runs macros were clobbering a single output file that did not get updated on further configure iterations * Fix conflicts with merge * Move MAX_PRECISION back to HDF5UseFortran.cmake * Use STREQUAL to test macro argument * Move C language test to ConfigureChecks from HDF5UseFortran * MAX_PRECISION defines must be defined * Organize flags and align autotools and cmake * Fix comment in no-error-general warnings files. Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Dana Robinson <43805+derobins@users.noreply.github.com>
* Removed -fanalyzer from the gcc 10 developer options (#744)Dana Robinson2021-06-101-4/+0
| | | | | This is extremely slow and generates a LOT of false positives. It's also not really a warning flag, but an analysis feature and thus belongs in a separate configure option, not lumped in with the warnings.
* C++ warning and build fixes (#707)Dana Robinson2021-06-011-0/+2
| | | | | | | | | | | | * Committing clang-format changes * C++ build and warning updates * Fixes all warnings on C++ (with gcc 9.3) * Updates CMake and Autotools C++ builds * Undo warning clobber Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
* Removed mentions of Wdeclaration-after-statement now that C99 is requ… (#447)Sean McBride2021-05-032-2/+0
| | | | | | | * Removed mentions of Wdeclaration-after-statement now that C99 is required * Remove -Werror=declaration-after-statement from error-general file. Co-authored-by: Larry Knox <lrknox@hdfgroup.org>
* Add compiler flags for GCC 10, along with updating warnhist script to ↵Quincey Koziol2020-12-214-0/+34
| | | | accommodate them. (#217)
* Add else choice to error flags option (#128)Allen Byrne2020-11-255-0/+171
|
* Removes -Wimplicit-fallthrough=5 from the gcc warningsDana Robinson2020-10-221-1/+0
| | | | | | | | | | | | -Wimplicit-fallthrough=3 is added by -Wextra, which we already set. Bumping the warning level only changes how fall-through comments are parsed, with level 5 turning off fall-through comments entirely. This is unnecessary and results in having to do extra work to squash warnings when included external code uses fall-through. This change also adds /* FALLTHROUGH */ comments where H5_ATTR_FALLTHROUGH is used so compilers that don't use attributes but do respect fall-through comments don't raise spurious warnings.
* Merge remote-tracking branch 'hdffv/develop' into rebased-fprintf-experimentDavid Young2020-09-033-2/+3
|\
| * Removes unsuffixed float warningsDana Robinson2020-08-073-2/+3
| | | | | | | | These warnings can only be addressed with gnu extensions.
* | Promote format-string warnings to errors.David Young2020-07-071-1/+1
|/
* Revise gnu-*flags and cmake/HDF*CompilerFlags.cmake files to add warningLarry Knox2020-05-1823-47/+70
| | | | | | | flags for GCC compilers version 4.8 and above. Removed files from gnu-warnings that only apply to versions < 4.8. Consolidated warnings from versions < 4.8 that apply to versions >= 4.8 into the 4.8 warnings files.
* Moved -Woverlength-strings to the developer flags.Dana Robinson2020-04-261-0/+4
|
* TRILAB-244 separate CXX warnings and errors from CAllen Byrne2020-04-235-4/+76
|
* TRILAB-192 - cleanup edits and match CMake CXX to autotoolsAllen Byrne2020-04-131-0/+1
|
* Remove flag from gfort-general in gfort-5, add /EHsc to Win C++Allen Byrne2020-04-061-1/+0
|
* Update intel flagsAllen Byrne2020-04-061-0/+1
|
* Correct whitespace in flags, force list modeAllen Byrne2020-04-053-12/+12
|
* TRILAB-192 add c++ and fortran warnings build systems one fileAllen Byrne2020-04-059-0/+44
|
* Reorg commentsAllen Byrne2020-03-251-4/+22
|
* Correct warning flag formAllen Byrne2020-03-251-1/+1
|
* Because of tools macro, this needs to be a warningAllen Byrne2020-03-251-1/+3
|
* Fix Werror issues in JNI and toolsAllen Byrne2020-03-241-3/+1
|
* TRILAB-192 fix JNI shadow warningAllen Byrne2020-03-241-6/+1
|
* TRILAB-192 restrict extensive warnings to librariesAllen Byrne2020-03-241-34/+27
|
* TRILAB-192 Identify warnings that fail as errorsAllen Byrne2020-03-242-11/+72
|
* Move the GNU warnings configuration under config/gnu-warnings/ and trimDavid Young2020-03-1934-0/+172
the filename prefixes. Update config/gnu-flags to suit. I also made changes to config/cmake/HDFCompilerFlags.cmake, but I'm not sure they're correct.