summaryrefslogtreecommitdiffstats
path: root/hl/test
Commit message (Expand)AuthorAgeFilesLines
* [svn-r12411] Purpose:James Laird2006-06-131-0/+1
* [svn-r12373] Purpose: Add debug information.Raymond Lu2006-05-231-0/+2507
* [svn-r12358] Purpose:Albert Cheng2006-05-191-1/+0
* [svn-r12351] Purpose: Follow-up what's committed yesterday.Raymond Lu2006-05-172-0/+89
* [svn-r12314] Purpose:Quincey Koziol2006-04-297-137/+176
* [svn-r12295] Purpose:James Laird2006-04-211-3/+3
* [svn-r12229] Purpose:Pedro Vicente Nunes2006-04-126-22/+26
* [svn-r12149] Purpose:James Laird2006-03-231-7/+1
* [svn-r12143] Purpose:James Laird2006-03-231-0/+4
* [svn-r11882] Purpose: RevisionRaymond Lu2006-01-161-37/+37
* [svn-r11832] Purpose: Rename files and change grammar rule.Raymond Lu2005-12-221-9/+2
* [svn-r11830] Purpose: A new function and its test.Raymond Lu2005-12-211-9/+121
* [svn-r11771] Purpose:Quincey Koziol2005-12-081-0/+1
* [svn-r11741] Purpose:James Laird2005-11-181-6/+16
* [svn-r11738] Purpose:James Laird2005-11-181-0/+4
* [svn-r11737] Purpose:James Laird2005-11-171-0/+8
* [svn-r11689] Purpose: Bug fixRaymond Lu2005-11-071-2/+0
* [svn-r11683] Raymond Lu2005-11-041-39/+38
* [svn-r11676] Purpose: New featureRaymond Lu2005-11-031-0/+406
* [svn-r11646] Purpose:James Laird2005-10-311-4/+14
* [svn-r11612] Purpose:James Laird2005-10-271-1/+1
* [svn-r11602] Purpose:James Laird2005-10-241-3/+0
* [svn-r11573] Purpose:James Laird2005-10-171-0/+1
* [svn-r11566] Purpose:James Laird2005-10-141-0/+2
* [svn-r11537] Purpose:Albert Cheng2005-10-118-68/+102
* [svn-r11478] Purpose:Albert Cheng2005-09-291-8/+7
* [svn-r11446] Purpose:James Laird2005-09-201-2/+3
* [svn-r11431] Purpose:Albert Cheng2005-09-181-2/+3
* [svn-r11421] Purpose:James Laird2005-09-161-4/+11
* [svn-r11420] Purpose:James Laird2005-09-161-0/+2
* [svn-r11418] Purpose:James Laird2005-09-151-0/+2
* [svn-r11323] Purpose:Albert Cheng2005-08-311-1/+2
* [svn-r11319] Purpose:James Laird2005-08-301-1/+1
* [svn-r11303] Purpose:Albert Cheng2005-08-261-25/+17
* [svn-r11245] Purpose:Quincey Koziol2005-08-136-693/+693
* [svn-r11213] Purpose:Albert Cheng2005-08-081-7/+2
* [svn-r11208] Purpose:Albert Cheng2005-08-081-55/+63
* [svn-r11185] Purpose:James Laird2005-08-022-14/+13
* [svn-r11179] Purpose:James Laird2005-08-011-7/+15
* [svn-r11095] Purpose:James Laird2005-07-211-15/+52
* [svn-r11091] Purpose:Pedro Vicente Nunes2005-07-201-1/+1
* [svn-r11042] Purpose:Quincey Koziol2005-07-071-7/+7
* [svn-r11034] Purpose:Albert Cheng2005-07-071-4/+2
* [svn-r11013] Purpose:James Laird2005-07-011-7/+7
* [svn-r11008] Purpose:James Laird2005-06-302-93/+85
* [svn-r10858] Purpose:Albert Cheng2005-06-041-4/+15
* [svn-r10849] Purpose:Albert Cheng2005-06-021-1/+3
* [svn-r10840] Purpose:James Laird2005-06-021-6/+36
* [svn-r10801] Purpose:James Laird2005-05-251-1/+1
* [svn-r10747] Purpose:Pedro Vicente Nunes2005-05-162-26/+71
4 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964 965 966 967 968 969 970 971 972 973 974 975 976 977 978 979 980 981 982 983 984 985 986 987 988 989 990 991 992 993 994 995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087 1088 1089 1090 1091 1092 1093 1094 1095 1096 1097 1098 1099 1100 1101 1102 1103 1104 1105 1106 1107 1108 1109 1110 1111 1112 1113 1114 1115 1116 1117 1118 1119 1120 1121 1122 1123 1124 1125 1126 1127 1128 1129 1130 1131 1132 1133 1134 1135 1136 1137 1138 1139 1140 1141 1142 1143 1144 1145 1146 1147 1148 1149 1150 1151 1152 1153 1154 1155 1156 1157 1158 1159 1160 1161 1162 1163 1164 1165 1166 1167 1168 1169 1170 1171 1172 1173 1174 1175 1176 1177 1178 1179 1180 1181 1182 1183 1184 1185 1186 1187 1188 1189 1190 1191 1192 1193 1194 1195 1196 1197 1198 1199 1200 1201 1202 1203 1204 1205 1206 1207 1208 1209 1210 1211 1212 1213 1214 1215 1216 1217 1218 1219 1220 1221 1222 1223 1224 1225 1226 1227 1228 1229 1230 1231 1232 1233 1234 1235 1236 1237 1238 1239 1240 1241 1242 1243 1244 1245 1246 1247 1248 1249 1250 1251 1252 1253 1254 1255 1256 1257 1258 1259 1260 1261 1262 1263 1264 1265 1266 1267 1268 1269 1270 1271 1272 1273 1274 1275 1276 1277 1278 1279 1280 1281 1282 1283 1284 1285 1286 1287 1288 1289 1290 1291 1292 1293 1294 1295 1296 1297 1298 1299 1300 1301 1302 1303 1304 1305 1306 1307 1308 1309 1310 1311 1312 1313 1314 1315 1316 1317 1318 1319 1320 1321 1322 1323 1324 1325 1326 1327 1328 1329 1330 1331 1332 1333 1334 1335 1336 1337 1338 1339 1340 1341 1342 1343 1344 1345 1346 1347 1348 1349 1350 1351 1352 1353 1354 1355 1356 1357 1358 1359 1360 1361 1362 1363 1364 1365 1366 1367 1368 1369 1370 1371 1372 1373 1374 1375 1376 1377 1378 1379 1380 1381 1382 1383 1384 1385 1386 1387 1388 1389 1390 1391 1392 1393 1394 1395 1396 1397 1398 1399 1400 1401 1402 1403 1404 1405 1406 1407 1408 1409 1410 1411 1412 1413 1414 1415 1416 1417 1418 1419 1420 1421 1422 1423 1424 1425 1426 1427 1428 1429 1430 1431 1432 1433 1434 1435 1436 1437 1438 1439 1440 1441 1442 1443 1444 1445 1446 1447 1448 1449 1450 1451 1452 1453 1454 1455 1456 1457 1458 1459 1460 1461 1462 1463 1464 1465 1466 1467 1468 1469 1470 1471 1472 1473 1474 1475 1476 1477 1478 1479 1480 1481 1482 1483 1484 1485 1486 1487 1488 1489 1490 1491 1492 1493 1494 1495 1496 1497 1498 1499 1500 1501 1502 1503 1504 1505 1506 1507 1508 1509 1510 1511 1512 1513 1514 1515 1516 1517 1518 1519 1520 1521 1522 1523 1524 1525 1526 1527 1528 1529 1530 1531 1532 1533 1534 1535 1536 1537 1538 1539 1540 1541 1542 1543 1544 1545 1546 1547 1548 1549 1550 1551 1552 1553 1554 1555 1556 1557 1558 1559 1560 1561 1562 1563 1564 1565 1566 1567 1568 1569 1570 1571 1572 1573 1574 1575 1576 1577 1578 1579 1580 1581 1582 1583 1584 1585 1586 1587 1588 1589 1590 1591 1592 1593 1594 1595 1596 1597 1598 1599 1600 1601 1602 1603 1604 1605 1606 1607 1608 1609 1610 1611 1612 1613 1614 1615 1616 1617 1618 1619 1620 1621 1622 1623 1624 1625 1626 1627 1628 1629 1630 1631 1632 1633 1634 1635 1636 1637 1638 1639 1640 1641 1642 1643 1644 1645 1646 1647 1648 1649 1650 1651 1652 1653 1654 1655 1656 1657 1658 1659 1660 1661 1662 1663 1664 1665 1666 1667 1668 1669 1670 1671 1672 1673 1674 1675 1676 1677 1678 1679 1680 1681 1682 1683 1684 1685 1686 1687 1688 1689 1690 1691 1692 1693 1694 1695 1696 1697 1698 1699 1700 1701 1702 1703 1704 1705 1706 1707 1708 1709 1710 1711 1712 1713 1714 1715 1716 1717 1718 1719 1720 1721 1722 1723 1724 1725 1726 1727 1728 1729 1730 1731 1732 1733 1734 1735 1736 1737 1738 1739 1740 1741 1742 1743 1744 1745 1746 1747 1748 1749 1750 1751 1752 1753 1754 1755 1756 1757 1758 1759 1760 1761 1762 1763 1764 1765 1766 1767 1768 1769 1770 1771 1772 1773 1774 1775 1776 1777 1778 1779 1780 1781 1782 1783 1784 1785 1786 1787 1788 1789 1790 1791 1792 1793 1794 1795 1796 1797 1798 1799 1800 1801 1802 1803 1804 1805 1806 1807 1808 1809 1810 1811 1812 1813 1814 1815 1816 1817 1818 1819 1820 1821 1822 1823 1824 1825 1826 1827 1828 1829 1830 1831 1832 1833 1834 1835 1836 1837 1838 1839 1840 1841 1842 1843 1844 1845 1846 1847 1848 1849 1850 1851 1852 1853 1854 1855 1856 1857 1858 1859 1860 1861 1862 1863 1864 1865 1866 1867 1868 1869 1870 1871 1872 1873 1874 1875 1876 1877 1878 1879 1880 1881 1882 1883 1884 1885 1886 1887 1888 1889 1890 1891 1892 1893 1894 1895 1896 1897 1898 1899 1900 1901 1902 1903 1904 1905 1906 1907 1908 1909 1910 1911 1912 1913 1914 1915 1916 1917 1918 1919 1920 1921 1922 1923 1924 1925 1926 1927 1928 1929 1930 1931 1932 1933 1934 1935 1936 1937 1938 1939 1940 1941 1942 1943 1944 1945 1946 1947 1948 1949 1950 1951 1952 1953 1954 1955 1956 1957 1958 1959 1960 1961 1962 1963 1964 1965 1966 1967 1968 1969 1970 1971 1972 1973 1974 1975 1976 1977 1978 1979 1980 1981 1982 1983 1984 1985 1986 1987 1988 1989 1990 1991 1992 1993 1994 1995 1996 1997 1998 1999 2000 2001 2002 2003 2004 2005 2006 2007 2008 2009 2010 2011 2012 2013 2014 2015 2016 2017 2018 2019 2020 2021 2022 2023 2024 2025 2026 2027 2028 2029 2030 2031 2032 2033 2034 2035 2036 2037 2038 2039 2040 2041 2042 2043 2044 2045 2046 2047 2048 2049 2050 2051 2052 2053 2054 2055 2056 2057 2058 2059 2060 2061 2062 2063 2064 2065 2066 2067 2068 2069 2070 2071 2072 2073 2074 2075 2076 2077 2078 2079 2080 2081 2082 2083 2084 2085 2086 2087 2088 2089 2090 2091 2092 2093 2094 2095 2096 2097 2098 2099 2100 2101 2102 2103 2104 2105 2106 2107 2108 2109 2110 2111 2112 2113 2114 2115 2116 2117 2118 2119 2120 2121 2122 2123 2124 2125 2126 2127 2128 2129 2130 2131 2132 2133 2134 2135 2136 2137 2138 2139 2140 2141 2142 2143 2144 2145 2146 2147 2148 2149 2150 2151 2152 2153 2154 2155 2156 2157 2158 2159 2160 2161 2162 2163 2164 2165 2166 2167 2168 2169 2170 2171 2172 2173 2174 2175 2176 2177 2178 2179 2180 2181 2182 2183 2184 2185 2186 2187 2188 2189 2190 2191 2192 2193 2194 2195 2196 2197 2198 2199 2200 2201 2202 2203 2204 2205 2206 2207 2208 2209 2210 2211 2212 2213 2214 2215 2216 2217 2218 2219 2220 2221 2222 2223 2224 2225 2226 2227 2228 2229 2230 2231 2232 2233 2234 2235 2236 2237 2238 2239 2240 2241 2242 2243 2244 2245 2246 2247 2248 2249 2250 2251 2252 2253 2254 2255 2256 2257 2258 2259 2260 2261 2262 2263 2264 2265 2266 2267 2268 2269 2270 2271 2272 2273 2274 2275 2276 2277 2278 2279 2280 2281 2282 2283 2284 2285 2286 2287 2288 2289 2290 2291 2292 2293 2294 2295 2296 2297 2298 2299 2300 2301 2302 2303 2304 2305 2306 2307 2308 2309 2310 2311 2312 2313 2314 2315 2316 2317 2318 2319 2320 2321 2322 2323 2324 2325 2326 2327 2328 2329 2330 2331 2332 2333 2334 2335 2336 2337 2338 2339 2340 2341 2342 2343 2344 2345 2346 2347 2348 2349 2350 2351 2352 2353 2354 2355 2356 2357 2358 2359 2360 2361 2362 2363 2364 2365 2366 2367 2368 2369 2370 2371 2372 2373 2374 2375 2376 2377 2378 2379 2380 2381 2382 2383 2384 2385 2386 2387 2388 2389 2390 2391 2392 2393 2394 2395 2396 2397 2398 2399 2400 2401 2402 2403 2404 2405 2406 2407 2408 2409 2410 2411 2412 2413 2414 2415 2416 2417 2418 2419 2420 2421 2422 2423 2424 2425 2426 2427 2428 2429 2430 2431 2432 2433 2434 2435 2436 2437 2438 2439 2440 2441 2442 2443 2444 2445 2446 2447 2448 2449 2450 2451 2452 2453 2454 2455 2456 2457 2458 2459 2460 2461 2462 2463 2464 2465 2466 2467 2468 2469 2470 2471 2472 2473 2474 2475 2476 2477 2478 2479 2480 2481 2482 2483 2484 2485 2486 2487 2488 2489 2490 2491 2492 2493 2494 2495 2496 2497 2498 2499 2500 2501 2502 2503 2504 2505 2506 2507 2508 2509 2510 2511 2512 2513 2514 2515 2516 2517 2518 2519 2520 2521 2522 2523 2524 2525 2526 2527 2528 2529 2530 2531 2532 2533 2534 2535 2536 2537 2538 2539 2540 2541 2542 2543 2544 2545 2546 2547 2548 2549 2550 2551 2552 2553 2554 2555 2556 2557 2558 2559 2560 2561 2562 2563 2564 2565 2566 2567 2568 2569 2570 2571 2572 2573 2574 2575 2576 2577 2578 2579 2580 2581 2582 2583 2584 2585 2586 2587 2588 2589 2590 2591 2592 2593 2594 2595 2596 2597 2598 2599 2600 2601 2602 2603 2604 2605 2606 2607 2608 2609 2610 2611 2612 2613 2614 2615 2616 2617 2618 2619 2620 2621 2622 2623 2624 2625 2626 2627 2628 2629 2630 2631 2632 2633 2634 2635 2636 2637 2638 2639 2640 2641 2642 2643 2644 2645 2646 2647 2648 2649 2650 2651 2652 2653 2654 2655 2656 2657 2658 2659 2660 2661 2662 2663 2664 2665 2666 2667 2668 2669 2670 2671 2672 2673 2674 2675 2676 2677 2678 2679 2680 2681 2682 2683 2684 2685 2686 2687 2688 2689 2690 2691 2692 2693 2694 2695 2696 2697 2698 2699 2700 2701 2702 2703 2704 2705 2706 2707 2708 2709 2710 2711 2712 2713 2714 2715 2716 2717 2718 2719 2720 2721 2722 2723 2724 2725 2726 2727 2728 2729 2730 2731 2732 2733 2734 2735 2736 2737 2738 2739 2740 2741 2742 2743 2744 2745 2746 2747 2748 2749 2750 2751 2752 2753 2754 2755 2756 2757 2758 2759 2760 2761 2762 2763 2764 2765 2766 2767 2768 2769 2770 2771 2772 2773 2774 2775 2776 2777 2778 2779 2780 2781 2782 2783 2784 2785 2786 2787 2788 2789 2790 2791 2792 2793 2794 2795 2796 2797 2798 2799 2800 2801 2802 2803 2804 2805 2806 2807 2808 2809 2810 2811 2812 2813 2814 2815 2816 2817 2818 2819 2820 2821 2822 2823 2824 2825 2826 2827 2828 2829 2830 2831 2832 2833 2834 2835 2836 2837 2838 2839 2840 2841 2842 2843 2844 2845 2846 2847 2848 2849 2850 2851 2852 2853 2854 2855 2856 2857 2858 2859 2860 2861 2862 2863 2864 2865 2866 2867 2868 2869 2870 2871 2872 2873 2874 2875 2876 2877 2878 2879 2880 2881 2882 2883 2884 2885 2886 2887 2888 2889 2890 2891 2892 2893 2894 2895 2896 2897 2898 2899 2900 2901 2902 2903 2904 2905 2906 2907 2908 2909 2910 2911 2912 2913 2914 2915 2916 2917 2918 2919 2920 2921 2922 2923 2924 2925 2926 2927 2928 2929 2930 2931 2932 2933 2934 2935 2936 2937 2938 2939 2940 2941 2942 2943 2944 2945 2946 2947 2948 2949 2950 2951 2952 2953 2954 2955 2956 2957 2958 2959 2960 2961 2962 2963 2964 2965 2966 2967 2968 2969 2970 2971 2972 2973 2974 2975 2976 2977 2978 2979 2980 2981 2982 2983 2984 2985 2986 2987 2988 2989 2990 2991 2992 2993 2994 2995 2996 2997 2998 2999 3000 3001 3002 3003 3004 3005 3006 3007 3008 3009 3010 3011 3012 3013 3014 3015 3016 3017 3018 3019 3020 3021 3022 3023 3024 3025 3026 3027 3028 3029 3030 3031 3032 3033 3034 3035 3036 3037 3038 3039 3040 3041 3042 3043 3044 3045 3046 3047 3048 3049 3050 3051 3052 3053 3054 3055 3056 3057 3058 3059 3060 3061 3062 3063 3064 3065 3066 3067 3068 3069 3070 3071 3072 3073 3074 3075 3076 3077 3078 3079 3080 3081 3082 3083 3084 3085 3086 3087 3088 3089 3090 3091 3092 3093 3094 3095 3096 3097 3098 3099 3100 3101 3102 3103 3104 3105 3106 3107 3108 3109 3110 3111 3112 3113 3114 3115 3116 3117 3118 3119 3120 3121 3122 3123 3124 3125 3126 3127 3128 3129 3130 3131 3132 3133 3134 3135 3136 3137 3138 3139 3140 3141 3142 3143 3144 3145 3146 3147 3148 3149 3150 3151 3152 3153 3154 3155 3156 3157 3158 3159 3160 3161 3162 3163 3164 3165 3166 3167 3168 3169 3170 3171 3172 3173 3174 3175 3176 3177 3178 3179 3180 3181 3182 3183 3184 3185 3186 3187 3188 3189 3190 3191 3192 3193 3194 3195 3196 3197 3198 3199 3200 3201 3202 3203 3204 3205 3206 3207 3208 3209 3210 3211 3212 3213 3214 3215 3216 3217 3218 3219 3220 3221 3222 3223 3224 3225 3226 3227 3228 3229 3230 3231 3232 3233 3234 3235 3236 3237 3238 3239 3240 3241 3242 3243 3244 3245 3246 3247 3248 3249 3250 3251 3252 3253 3254 3255 3256 3257 3258 3259 3260 3261 3262 3263 3264 3265 3266 3267 3268 3269 3270 3271 3272 3273 3274 3275 3276 3277 3278 3279 3280 3281 3282 3283 3284 3285 3286 3287 3288 3289 3290 3291 3292 3293 3294 3295 3296 3297 3298 3299 3300 3301 3302 3303 3304 3305 3306 3307 3308 3309 3310 3311 3312 3313 3314 3315 3316 3317 3318 3319 3320 3321 3322 3323 3324 3325 3326 3327 3328 3329 3330 3331 3332 3333 3334 3335 3336 3337 3338 3339 3340 3341 3342 3343 3344 3345 3346 3347 3348 3349 3350 3351 3352 3353 3354 3355 3356 3357 3358 3359 3360 3361 3362 3363 3364 3365 3366 3367 3368 3369 3370 3371 3372 3373 3374 3375 3376 3377 3378 3379 3380 3381 3382 3383 3384 3385 3386 3387 3388 3389 3390 3391 3392 3393 3394 3395 3396 3397 3398 3399 3400 3401 3402 3403 3404 3405 3406 3407 3408 3409 3410 3411 3412 3413 3414 3415 3416 3417 3418 3419 3420 3421 3422 3423 3424 3425 3426 3427 3428 3429 3430 3431 3432 3433 3434 3435 3436 3437 3438 3439 3440 3441 3442 3443 3444 3445 3446 3447 3448 3449 3450 3451 3452 3453 3454 3455 3456 3457 3458 3459 3460 3461 3462 3463 3464 3465 3466 3467 3468 3469 3470 3471 3472 3473 3474 3475 3476 3477 3478 3479 3480 3481 3482 3483 3484 3485 3486 3487 3488 3489 3490 3491 3492 3493 3494 3495 3496 3497 3498 3499 3500 3501 3502 3503 3504 3505 3506 3507 3508 3509 3510 3511 3512 3513 3514 3515 3516 3517 3518 3519 3520 3521 3522 3523 3524 3525 3526 3527 3528 3529 3530 3531 3532 3533 3534 3535 3536 3537 3538 3539 3540 3541 3542 3543 3544 3545 3546 3547 3548 3549 3550 3551 3552 3553 3554 3555 3556 3557 3558 3559 3560 3561 3562 3563 3564 3565 3566 3567 3568 3569 3570 3571 3572 3573 3574 3575 3576 3577 3578 3579 3580 3581 3582 3583 3584 3585 3586 3587 3588 3589 3590 3591 3592 3593 3594 3595 3596 3597 3598 3599 3600 3601 3602 3603 3604 3605 3606 3607 3608 3609 3610 3611 3612 3613 3614 3615 3616 3617 3618 3619 3620 3621 3622 3623 3624 3625 3626 3627 3628 3629 3630 3631 3632 3633 3634 3635 3636 3637 3638 3639 3640 3641 3642 3643 3644 3645 3646 3647 3648 3649 3650 3651 3652 3653 3654 3655 3656 3657 3658 3659 3660 3661 3662 3663 3664 3665 3666 3667 3668 3669 3670 3671 3672 3673 3674 3675 3676 3677 3678 3679 3680 3681 3682 3683 3684 3685 3686 3687 3688 3689 3690 3691 3692 3693 3694 3695 3696 3697 3698 3699 3700 3701 3702 3703 3704 3705 3706 3707 3708 3709 3710 3711 3712 3713 3714 3715 3716 3717 3718 3719 3720 3721 3722 3723 3724 3725 3726 3727 3728 3729 3730 3731 3732 3733 3734 3735 3736 3737 3738 3739 3740 3741 3742 3743 3744 3745 3746 3747 3748 3749 3750 3751 3752 3753 3754 3755 3756 3757 3758 3759 3760 3761 3762 3763 3764 3765 3766 3767 3768 3769 3770 3771 3772 3773 3774 3775 3776 3777 3778 3779 3780 3781 3782 3783 3784 3785 3786 3787 3788 3789 3790 3791 3792 3793 3794 3795 3796 3797 3798 3799 3800 3801 3802 3803 3804 3805 3806 3807 3808 3809 3810 3811 3812 3813 3814 3815 3816 3817 3818 3819 3820 3821 3822 3823 3824 3825 3826 3827 3828 3829 3830 3831 3832 3833 3834 3835 3836 3837 3838 3839 3840 3841 3842 3843 3844 3845 3846 3847 3848 3849 3850 3851 3852 3853 3854 3855 3856 3857 3858 3859 3860 3861 3862 3863 3864 3865 3866 3867 3868 3869 3870 3871 3872 3873 3874 3875 3876 3877 3878 3879 3880 3881 3882 3883 3884 3885 3886 3887 3888 3889 3890 3891 3892 3893 3894 3895 3896 3897 3898 3899 3900 3901 3902 3903 3904 3905 3906 3907 3908 3909 3910 3911 3912 3913 3914 3915 3916 3917 3918 3919 3920 3921 3922 3923 3924 3925 3926 3927 3928 3929 3930 3931 3932 3933 3934 3935 3936 3937 3938 3939 3940 3941 3942 3943 3944 3945 3946 3947 3948 3949 3950 3951 3952 3953 3954 3955 3956 3957 3958 3959 3960 3961 3962 3963 3964 3965 3966 3967 3968 3969 3970 3971 3972 3973 3974 3975 3976 3977 3978 3979 3980 3981 3982 3983 3984 3985 3986 3987 3988 3989 3990 3991 3992 3993 3994 3995 3996 3997 3998 3999 4000 4001 4002 4003 4004 4005 4006 4007 4008 4009 4010 4011 4012 4013 4014 4015 4016 4017 4018 4019 4020 4021 4022 4023 4024 4025 4026 4027 4028 4029 4030 4031 4032 4033 4034 4035 4036 4037 4038 4039 4040 4041 4042 4043 4044 4045 4046 4047 4048 4049 4050 4051 4052 4053 4054 4055 4056 4057 4058 4059 4060 4061 4062 4063 4064 4065 4066 4067 4068 4069 4070 4071 4072 4073 4074 4075 4076 4077 4078 4079 4080 4081 4082 4083 4084 4085 4086 4087 4088 4089 4090 4091 4092 4093 4094 4095 4096 4097 4098 4099 4100 4101 4102 4103 4104 4105 4106 4107 4108 4109 4110 4111 4112 4113 4114 4115 4116 4117 4118 4119 4120 4121 4122 4123 4124 4125 4126 4127 4128 4129 4130 4131 4132 4133 4134 4135 4136 4137 4138 4139 4140 4141 4142 4143 4144 4145 4146 4147 4148 4149 4150 4151 4152 4153 4154 4155 4156 4157 4158 4159 4160 4161 4162 4163 4164 4165 4166 4167 4168 4169 4170 4171 4172 4173 4174 4175 4176 4177 4178 4179 4180 4181 4182 4183 4184 4185 4186 4187 4188 4189 4190 4191 4192 4193 4194 4195 4196 4197 4198 4199 4200 4201 4202 4203 4204 4205 4206 4207 4208 4209 4210 4211 4212 4213 4214 4215 4216 4217 4218 4219 4220 4221 4222 4223 4224 4225 4226 4227 4228 4229 4230 4231 4232 4233 4234 4235 4236 4237 4238 4239 4240 4241 4242 4243 4244 4245 4246 4247 4248 4249 4250 4251 4252 4253 4254 4255 4256 4257 4258 4259 4260 4261 4262 4263 4264 4265 4266 4267 4268 4269 4270 4271 4272 4273 4274 4275 4276 4277 4278 4279 4280 4281 4282 4283 4284 4285 4286 4287 4288 4289 4290 4291 4292 4293 4294 4295 4296 4297 4298 4299 4300 4301 4302 4303 4304 4305 4306 4307 4308 4309 4310 4311 4312 4313 4314 4315 4316 4317 4318 4319 4320 4321 4322 4323 4324 4325 4326 4327 4328 4329 4330 4331 4332 4333 4334 4335 4336 4337 4338 4339 4340 4341 4342 4343 4344 4345 4346 4347 4348 4349 4350 4351 4352 4353 4354 4355 4356 4357 4358 4359 4360 4361 4362 4363 4364 4365 4366 4367 4368 4369 4370 4371 4372 4373 4374 4375 4376 4377 4378 4379 4380 4381 4382 4383 4384 4385 4386 4387 4388 4389 4390 4391 4392 4393 4394 4395 4396 4397 4398 4399 4400 4401 4402 4403 4404 4405 4406 4407 4408 4409 4410 4411 4412 4413 4414 4415 4416 4417 4418 4419 4420 4421 4422 4423 4424 4425 4426 4427 4428 4429 4430 4431 4432 4433 4434 4435 4436 4437 4438 4439 4440 4441 4442 4443 4444 4445 4446 4447 4448 4449 4450 4451 4452 4453 4454 4455 4456 4457 4458 4459 4460 4461 4462 4463 4464 4465 4466 4467 4468 4469 4470 4471 4472 4473 4474 4475 4476 4477 4478 4479 4480 4481 4482 4483 4484 4485 4486 4487 4488 4489 4490 4491 4492 4493 4494 4495 4496 4497 4498 4499 4500 4501 4502 4503 4504 4505 4506 4507 4508 4509 4510 4511 4512 4513 4514 4515 4516 4517 4518 4519 4520 4521 4522 4523 4524 4525 4526 4527 4528 4529 4530 4531 4532 4533 4534 4535 4536 4537 4538 4539 4540 4541 4542 4543 4544 4545 4546 4547 4548 4549 4550 4551 4552 4553 4554 4555 4556 4557 4558 4559 4560 4561 4562 4563 4564 4565 4566 4567 4568 4569 4570 4571 4572 4573 4574 4575 4576 4577 4578 4579 4580 4581 4582 4583 4584 4585 4586 4587 4588 4589 4590 4591 4592 4593 4594 4595 4596 4597 4598 4599 4600 4601 4602 4603 4604 4605 4606 4607 4608 4609 4610 4611 4612 4613 4614 4615 4616 4617 4618 4619 4620 4621 4622 4623 4624 4625 4626 4627 4628 4629 4630 4631 4632 4633 4634 4635 4636 4637 4638 4639 4640 4641 4642 4643 4644 4645 4646 4647 4648 4649 4650 4651 4652 4653 4654 4655 4656 4657 4658 4659 4660 4661 4662 4663 4664 4665 4666 4667 4668 4669 4670 4671 4672 4673 4674 4675 4676 4677 4678 4679 4680 4681 4682 4683 4684 4685 4686 4687 4688 4689 4690 4691 4692 4693 4694 4695 4696 4697 4698 4699 4700 4701 4702 4703 4704 4705 4706 4707 4708 4709 4710 4711 4712 4713 4714 4715 4716 4717 4718 4719 4720 4721 4722 4723 4724 4725 4726 4727 4728 4729 4730 4731 4732 4733 4734 4735 4736 4737 4738 4739 4740 4741 4742 4743 4744 4745 4746 4747 4748 4749 4750 4751 4752 4753 4754 4755 4756 4757 4758 4759 4760 4761 4762 4763 4764 4765 4766 4767 4768 4769 4770 4771 4772 4773 4774 4775 4776 4777 4778 4779 4780 4781 4782 4783 4784 4785 4786 4787 4788 4789 4790 4791 4792 4793 4794 4795 4796 4797 4798 4799 4800 4801 4802 4803 4804 4805 4806 4807 4808 4809 4810 4811 4812 4813 4814 4815 4816
/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * *
 * Copyright by The HDF Group.                                               *
 * Copyright by the Board of Trustees of the University of Illinois.         *
 * All rights reserved.                                                      *
 *                                                                           *
 * This file is part of HDF5.  The full HDF5 copyright notice, including     *
 * terms governing use, modification, and redistribution, is contained in    *
 * the COPYING file, which can be found at the root of the source code       *
 * distribution tree, or in https://www.hdfgroup.org/licenses.               *
 * If you do not have access to either file, you may request a copy from     *
 * help@hdfgroup.org.                                                        *
 * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */

/*-------------------------------------------------------------------------
 *
 * Created:  H5PB2.c
 *
 * Purpose:  Re-implementation of the page buffer with added features to
 *           support VFD SWMR.
 *                                              JRM -- 10/11/18
 *
 *-------------------------------------------------------------------------
 */

/****************/
/* Module Setup */
/****************/

#define H5F_FRIEND      /* suppress error about including H5Fpkg */
#include "H5PBmodule.h" /* This source code file is part of the 
                                 * H5PB module 
                                 */

/***********/
/* Headers */
/***********/
#include "H5private.h"   /* Generic Functions			*/
#include "H5Eprivate.h"  /* Error handling		  	*/
#include "H5Fpkg.h"      /* Files				*/
#include "H5FDprivate.h" /* File drivers				*/
#include "H5Iprivate.h"  /* IDs			  		*/
#include "H5FLprivate.h" /* Free lists                           */
#include "H5MMprivate.h" /* Memory management                    */
#include "H5PBpkg.h"     /* File access				*/

/****************/
/* Local Macros */
/****************/

/* Round _x down to nearest _size. */
/* not used at present */
/*
#ifndef rounddown
#define rounddown(_x, _size) (((_x) / (_size)) * (_size))
#endif
*/

/* Round _x up to nearest _size. */
#ifndef roundup
#define roundup(_x, _size) ((((_x) + (_size)-1) / (_size)) * (_size))
#endif

/******************/
/* Local Typedefs */
/******************/

typedef struct _metadata_section {
    haddr_t     addr;
    size_t      len;
    const char *buf;
} metadata_section_t;

/********************/
/* Package Typedefs */
/********************/

/********************/
/* Local Prototypes */
/********************/

static H5PB_entry_t *H5PB__allocate_page(H5PB_t *page_buf, size_t buf_size, hbool_t clean_image);

static herr_t H5PB__create_new_page(H5PB_t *page_buf, haddr_t addr, size_t size, H5FD_mem_t type,
                                    hbool_t clean_image, H5PB_entry_t **entry_ptr_ptr);

static void H5PB__deallocate_page(H5PB_entry_t *entry_ptr);

static herr_t H5PB__evict_entry(H5F_shared_t *, H5PB_entry_t *, hbool_t, hbool_t);

static herr_t H5PB__flush_entry(H5F_shared_t *, H5PB_t *, H5PB_entry_t *);

static herr_t H5PB__load_page(H5F_shared_t *, H5PB_t *, haddr_t, H5FD_mem_t, H5PB_entry_t **);

static herr_t H5PB__make_space(H5F_shared_t *, H5PB_t *, H5FD_mem_t);

static herr_t H5PB__mark_entry_clean(H5PB_t *, H5PB_entry_t *);

static herr_t H5PB__mark_entry_dirty(H5F_shared_t *, H5PB_t *, H5PB_entry_t *);

static herr_t H5PB__read_meta(H5F_shared_t *, H5FD_mem_t, haddr_t, size_t, void *);

static herr_t H5PB__read_raw(H5F_shared_t *, H5FD_mem_t, haddr_t, size_t, void *);

static herr_t H5PB__write_meta(H5F_shared_t *, H5FD_mem_t, haddr_t, size_t, const void *);

static herr_t H5PB__write_raw(H5F_shared_t *, H5FD_mem_t, haddr_t, size_t, const void *);

/*********************/
/* Package Variables */
/*********************/

/* Package initialization variable */
hbool_t H5_PKG_INIT_VAR = FALSE;

/*****************************/
/* Library Private Variables */
/*****************************/

/*******************/
/* Local Variables */
/*******************/

/* Declare a free list to manage the H5PB_t struct */
H5FL_DEFINE_STATIC(H5PB_t);

/* Declare a free list to manage the H5PB_entry_t struct */
H5FL_DEFINE_STATIC(H5PB_entry_t);

/*-------------------------------------------------------------------------
 *
 * Function:	H5PB_reset_stats
 *
 * Purpose:     Reset statistics collected for the page buffer layer.
 *
 * Return:      Non-negative on success/Negative on failure
 *
 * Programmer:	John Mainzer -- 10/12/18
 *
 * Changes:     None.
 *
 *-------------------------------------------------------------------------
 */
herr_t
H5PB_reset_stats(H5PB_t *page_buf)
{
    int i;

    FUNC_ENTER_NOAPI_NOERR

    /* Sanity checks */
    HDassert(page_buf);
    HDassert(page_buf->magic == H5PB__H5PB_T_MAGIC);

    for (i = 0; i < H5PB__NUM_STAT_TYPES; i++) {

        page_buf->bypasses[i]   = 0;
        page_buf->accesses[i]   = 0;
        page_buf->hits[i]       = 0;
        page_buf->misses[i]     = 0;
        page_buf->loads[i]      = 0;
        page_buf->insertions[i] = 0;
        page_buf->flushes[i]    = 0;
        page_buf->evictions[i]  = 0;
        page_buf->clears[i]     = 0;
    }

    page_buf->max_lru_len                      = 0;
    page_buf->max_lru_size                     = 0;
    page_buf->lru_md_skips                     = 0;
    page_buf->lru_rd_skips                     = 0;
    page_buf->total_ht_insertions              = 0;
    page_buf->total_ht_deletions               = 0;
    page_buf->successful_ht_searches           = 0;
    page_buf->total_successful_ht_search_depth = 0;
    page_buf->failed_ht_searches               = 0;
    page_buf->total_failed_ht_search_depth     = 0;
    page_buf->max_index_len                    = 0;
    page_buf->max_clean_index_len              = 0;
    page_buf->max_dirty_index_len              = 0;
    page_buf->max_clean_index_size             = 0;
    page_buf->max_dirty_index_size             = 0;
    page_buf->max_index_size                   = 0;
    page_buf->max_rd_pages                     = 0;
    page_buf->max_md_pages                     = 0;
    page_buf->max_mpmde_count                  = 0;
    page_buf->lru_tl_skips                     = 0;
    page_buf->max_tl_len                       = 0;
    page_buf->max_tl_size                      = 0;
    page_buf->delayed_writes                   = 0;
    page_buf->total_delay                      = 0;
    page_buf->max_dwl_len                      = 0;
    page_buf->max_dwl_size                     = 0;
    page_buf->total_dwl_ins_depth              = 0;
    page_buf->md_read_splits                   = 0;
    page_buf->md_write_splits                  = 0;

    FUNC_LEAVE_NOAPI(SUCCEED)

} /* H5PB_reset_stats() */

/*-------------------------------------------------------------------------
 * Function:	H5PB_get_stats
 *
 * Purpose:     This function was created without documentation.
 *              What follows is my best understanding of Mohamad's intent.
 *
 *              Retrieve statistics collected about page accesses for the
 *              page buffer layer.
 *
 *              --accesses: the number of metadata and raw data accesses
 *                          to the page buffer layer
 *
 *              --hits: the number of metadata and raw data hits in
 *                          the page buffer layer
 *
 *              --misses: the number of metadata and raw data misses in
 *                          the page buffer layer
 *
 *              --evictions: the number of metadata and raw data evictions
 *                          from the page buffer layer
 *
 *              --bypasses: the number of metadata and raw data accesses
 *                          that bypass the page buffer layer
 *
 *              TODO: The available stats have changed considerably
 *                    since Mohamad wrote this routine.  Update
 *                    the function once things settle down.
 *
 *                                              JRM -- 4/13/20
 *
 * Return:	Non-negative on success/Negative on failure
 *
 * Programmer:	Mohamad Chaarawi
 *
 *-------------------------------------------------------------------------
 */
herr_t
H5PB_get_stats(const H5PB_t *page_buf, unsigned accesses[2], unsigned hits[2], unsigned misses[2],
               unsigned evictions[2], unsigned bypasses[2])
{
    FUNC_ENTER_NOAPI_NOERR

    /* Sanity checks */
    HDassert(page_buf);

    accesses[0]  = (unsigned)page_buf->accesses[0];
    accesses[1]  = (unsigned)page_buf->accesses[1];
    accesses[2]  = (unsigned)page_buf->accesses[2];
    hits[0]      = (unsigned)page_buf->hits[0];
    hits[1]      = (unsigned)page_buf->hits[1];
    hits[2]      = (unsigned)page_buf->hits[2];
    misses[0]    = (unsigned)page_buf->misses[0];
    misses[1]    = (unsigned)page_buf->misses[1];
    misses[2]    = (unsigned)page_buf->misses[2];
    evictions[0] = (unsigned)page_buf->evictions[0];
    evictions[1] = (unsigned)page_buf->evictions[1];
    evictions[2] = (unsigned)page_buf->evictions[2];
    bypasses[0]  = (unsigned)page_buf->bypasses[0];
    bypasses[1]  = (unsigned)page_buf->bypasses[1];
    bypasses[2]  = (unsigned)page_buf->bypasses[2];

    FUNC_LEAVE_NOAPI(SUCCEED)
} /* H5PB_get_stats */

/*-------------------------------------------------------------------------
 *
 * Function:	H5PB_print_stats()
 *
 * Purpose:     Print out statistics collected for the page buffer layer.
 *
 * Return:	Non-negative on success/Negative on failure
 *
 * Programmer:	John Mainzer -- 10/12/18
 *
 * Changes:     Added support for md_read_splits and md_write_splits.
 *
 *                                            JRM -- 4/11/20
 *
 *-------------------------------------------------------------------------
 */
herr_t
H5PB_print_stats(const H5PB_t *page_buf)
{
    double ave_succ_search_depth       = 0.0;
    double ave_failed_search_depth     = 0.0;
    double ave_delayed_write           = 0.0;
    double ave_delayed_write_ins_depth = 0.0;

    FUNC_ENTER_NOAPI_NOINIT_NOERR

    HDassert(page_buf);
    HDassert(page_buf->magic == H5PB__H5PB_T_MAGIC);

    HDfprintf(stdout, "\n\nPage Buffer Statistics (raw/meta/mpmde): \n\n");

    HDfprintf(stdout, "bypasses   = %" PRIi64 " (%" PRIi64 "/%" PRIi64 "/%" PRIi64 ")\n",
              (page_buf->bypasses[0] + page_buf->bypasses[1] + page_buf->bypasses[2]), page_buf->bypasses[0],
              page_buf->bypasses[1], page_buf->bypasses[2]);

    HDfprintf(stdout, "acesses    = %" PRIi64 " (%" PRIi64 "/%" PRIi64 "/%" PRIi64 ")\n",
              (page_buf->accesses[0] + page_buf->accesses[1] + page_buf->accesses[2]), page_buf->accesses[0],
              page_buf->accesses[1], page_buf->accesses[2]);

    HDfprintf(stdout, "hits       = %" PRIi64 " (%" PRIi64 "/%" PRIi64 "/%" PRIi64 ")\n",
              (page_buf->hits[0] + page_buf->hits[1] + page_buf->hits[2]), page_buf->hits[0],
              page_buf->hits[1], page_buf->hits[2]);

    HDfprintf(stdout, "misses     = %" PRIi64 " (%" PRIi64 "/%" PRIi64 "/%" PRIi64 ")\n",
              (page_buf->misses[0] + page_buf->misses[1] + page_buf->misses[2]), page_buf->misses[0],
              page_buf->misses[1], page_buf->misses[2]);

    HDfprintf(stdout, "loads      = %" PRIi64 " (%" PRIi64 "/%" PRIi64 "/%" PRIi64 ")\n",
              (page_buf->loads[0] + page_buf->loads[1] + page_buf->loads[2]), page_buf->loads[0],
              page_buf->loads[1], page_buf->loads[2]);

    HDfprintf(stdout, "insertions = %" PRIi64 " (%" PRIi64 "/%" PRIi64 "/%" PRIi64 ")\n",
              (page_buf->insertions[0] + page_buf->insertions[1] + page_buf->insertions[2]),
              page_buf->insertions[0], page_buf->insertions[1], page_buf->insertions[2]);

    HDfprintf(stdout, "flushes    = %" PRIi64 " (%" PRIi64 "/%" PRIi64 "/%" PRIi64 ")\n",
              (page_buf->flushes[0] + page_buf->flushes[1] + page_buf->flushes[2]), page_buf->flushes[0],
              page_buf->flushes[1], page_buf->flushes[2]);

    HDfprintf(stdout, "evictions  = %" PRIi64 " (%" PRIi64 "/%" PRIi64 "/%" PRIi64 ")\n",
              (page_buf->evictions[0] + page_buf->evictions[1] + page_buf->evictions[2]),
              page_buf->evictions[0], page_buf->evictions[1], page_buf->evictions[2]);

    HDfprintf(stdout, "clears     = %" PRIi64 " (%" PRIi64 "/%" PRIi64 "/%" PRIi64 ")\n",
              (page_buf->clears[0] + page_buf->clears[1] + page_buf->clears[2]), page_buf->clears[0],
              page_buf->clears[1], page_buf->clears[2]);

    HDfprintf(stdout, "max LRU len / size = %" PRIi64 " / %" PRIi64 "\n", page_buf->max_lru_len,
              page_buf->max_lru_size);

    HDfprintf(stdout, "LRU make space md/rd/tl skips = %" PRIi64 "/%" PRIi64 "/%" PRIi64 "\n",
              page_buf->lru_md_skips, page_buf->lru_rd_skips, page_buf->lru_tl_skips);

    HDfprintf(stdout, "hash table insertions / deletions = %" PRIi64 " / %" PRIi64 "\n",
              page_buf->total_ht_insertions, page_buf->total_ht_deletions);

    if (page_buf->successful_ht_searches > 0) {

        ave_succ_search_depth =
            (double)(page_buf->total_successful_ht_search_depth) / (double)(page_buf->successful_ht_searches);
    }
    HDfprintf(stdout, "successful ht searches / ave depth = %" PRIi64 " / %g\n",
              page_buf->successful_ht_searches, ave_succ_search_depth);

    if (page_buf->failed_ht_searches > 0) {

        ave_failed_search_depth =
            (double)(page_buf->total_failed_ht_search_depth) / (double)(page_buf->failed_ht_searches);
    }
    HDfprintf(stdout, "failed ht searches / ave depth = %" PRIi64 " / %g\n", page_buf->failed_ht_searches,
              ave_failed_search_depth);

    HDfprintf(stdout, "max index length / size = %" PRIi64 " / %" PRIi64 "\n", page_buf->max_index_len,
              page_buf->max_index_size);

    HDfprintf(stdout, "max rd / md / mpmde entries = %" PRIi64 " / %" PRIi64 " / %" PRIi64 "\n",
              page_buf->max_rd_pages, page_buf->max_md_pages, page_buf->max_mpmde_count);

    HDfprintf(stdout, "tick list max len / size = %" PRIi64 " / %" PRIi64 "\n", page_buf->max_tl_len,
              page_buf->max_tl_size);

    HDfprintf(stdout, "delayed write list max len / size = %" PRIi64 " / %" PRIi64 "\n",
              page_buf->max_dwl_len, page_buf->max_dwl_size);

    if (page_buf->delayed_writes > 0) {

        ave_delayed_write = (double)(page_buf->total_delay) / (double)(page_buf->delayed_writes);
        ave_delayed_write_ins_depth =
            (double)(page_buf->total_dwl_ins_depth) / (double)(page_buf->delayed_writes);
    }

    HDfprintf(stdout, "delayed writes / ave delay / ave ins depth = %" PRIi64 " / %g / %g\n",
              page_buf->delayed_writes, ave_delayed_write, ave_delayed_write_ins_depth);

    HDfprintf(stdout, "metadata read / write splits = %" PRIi64 " / %" PRIi64 ".\n", page_buf->md_read_splits,
              page_buf->md_write_splits);

    FUNC_LEAVE_NOAPI(SUCCEED)

} /* H5PB_print_stats */

/*-------------------------------------------------------------------------
 *
 * Function:	H5PB_add_new_page
 *
 * Purpose:	Insert a new blank page to the page buffer if the page
 *              buffer is configured to allow pages of the specified
 *              type.
 *
 *              This function is called by the MF layer when a new page
 *              is allocated to indicate to the page buffer layer that
 *              a read of the page from the file is not necessary since
 *              it's an empty page.
 *
 *              For purposes of the VFD SWMR writer, we also track pages
 *              that are inserted via this call, as the fact that the
 *              page was allocated implies that an earlier version does
 *              not exist in the HDF5 file, and thus we need not concern
 *              ourselves with delaying the write of this pages to avoid
 *              messages from the future on the reader.
 *
 *              Note that this function inserts the new page without
 *              attempting to make space.  This can result in the page
 *              buffer exceeding its maximum size.
 *
 *              Note also that it is possible that the page (marked clean)
 *              will be evicted before its first use.
 *
 * Return:	Non-negative on success/Negative on failure
 *
 * Programmer:	John Mainzer -- 10/12/18
 *
 * Changes:     Modified function to function to prevent the insertion
 *              of raw data pages when operating in VFD SWMR mode.
 *
 *                                          JRM -- 3/25/20
 *
 *-------------------------------------------------------------------------
 */
herr_t
H5PB_add_new_page(H5F_shared_t *shared, H5FD_mem_t type, haddr_t page_addr)
{
    hbool_t       can_insert = TRUE;
    H5PB_t *      page_buf   = NULL;
    H5PB_entry_t *entry_ptr  = NULL;
    herr_t        ret_value  = SUCCEED; /* Return value */

    FUNC_ENTER_NOAPI(FAIL)

    /* Sanity checks */
    HDassert(shared);
    HDassert(shared->page_buf);

    page_buf = shared->page_buf;

    HDassert(page_buf->magic == H5PB__H5PB_T_MAGIC);

    if (H5FD_MEM_DRAW == type) { /* raw data page insertion */

        if ((page_buf->min_md_pages == page_buf->max_pages) || (page_buf->vfd_swmr)) {

            can_insert = FALSE;
        }
    }
    else { /* metadata page insertion */

        if (page_buf->min_rd_pages == page_buf->max_pages) {

            can_insert = FALSE;
        }
    }

    if (can_insert) {

        if (H5PB__create_new_page(page_buf, page_addr, (size_t)(page_buf->page_size), type, TRUE,
                                  &entry_ptr) < 0)

            HGOTO_ERROR(H5E_PAGEBUF, H5E_SYSTEM, FAIL, "new page buffer page creation failed.")

        /* make note that this page was allocated, not loaded from file */
        entry_ptr->loaded = FALSE;

        /* updates stats */
        H5PB__UPDATE_STATS_FOR_INSERTION(page_buf, entry_ptr);
    }

done:

    FUNC_LEAVE_NOAPI(ret_value)

} /* H5PB_add_new_page */

/*-------------------------------------------------------------------------
 *
 * Function:	H5PB_create
 *
 * Purpose:	Setup a page buffer for the supplied file.
 *
 * Return:	Non-negative on success/Negative on failure
 *
 * Programmer:	John Mainzer -- 10/11/18
 *
 * Changes:     Added initialization for the vfd_swmr field.  Also
 *              added code to force min_rd_pages to 0 if vfd_swrm is
 *              TRUE.  Do this since we now exclude raw data from the
 *              page buffer when operating in VFD SWMR mode.
 *
 *                                               JRM -- 3/28/20
 *
 *-------------------------------------------------------------------------
 */
herr_t
H5PB_create(H5F_shared_t *shared, size_t size, unsigned page_buf_min_meta_perc,
            unsigned page_buf_min_raw_perc)
{
    hbool_t vfd_swmr        = FALSE;
    hbool_t vfd_swmr_writer = FALSE;
    int     i;
    int32_t min_md_pages;
    int32_t min_rd_pages;
    H5PB_t *page_buf  = NULL;
    herr_t  ret_value = SUCCEED; /* Return value */

    FUNC_ENTER_NOAPI(FAIL)

    /* Sanity checks */
    HDassert(shared);
    HDassert(page_buf_min_meta_perc <= 100);
    HDassert(page_buf_min_raw_perc <= 100);
    HDassert((page_buf_min_meta_perc + page_buf_min_raw_perc) <= 100);

    /* Check args */
    if (shared->fs_strategy != H5F_FSPACE_STRATEGY_PAGE)

        HGOTO_ERROR(H5E_FILE, H5E_CANTINIT, FAIL, "Enabling Page Buffering requires PAGE file space strategy")

    else if (size > shared->fs_page_size) {

        /* round size down to the next multiple of fs_page_size */

        hsize_t temp_size;

        temp_size = (size / shared->fs_page_size) * shared->fs_page_size;

        H5_CHECKED_ASSIGN(size, size_t, temp_size, hsize_t);

    } /* end if */
    else if (0 != size % shared->fs_page_size)

        HGOTO_ERROR(H5E_PAGEBUF, H5E_CANTINIT, FAIL, "Page Buffer size must be >= to the page size")

    /* Calculate the minimum page count for metadata and raw data
     * based on the fractions provided
     */
    min_md_pages = (int32_t)((size * page_buf_min_meta_perc) / (shared->fs_page_size * 100));
    min_rd_pages = (int32_t)((size * page_buf_min_raw_perc) / (shared->fs_page_size * 100));
    HDassert(min_md_pages >= 0);
    HDassert(min_rd_pages >= 0);
    HDassert((min_md_pages + min_rd_pages) <= (int32_t)(size / shared->fs_page_size));

    /* compute vfd_swrm and vfd_swmr_writer */
    if (H5F_SHARED_VFD_SWMR_CONFIG(shared)) {

        vfd_swmr = TRUE;

        /* force min_rd_pages to zero since raw data is exclued from
         * the page buffer in VFD SWMR mode.
         */
        min_rd_pages = 0;

        if (H5F_SHARED_INTENT(shared) & H5F_ACC_RDWR) {

            HDassert(shared->vfd_swmr_config.writer);
            vfd_swmr_writer = TRUE;
        }
    }

    /* Allocate the new page buffering structure */
    if (NULL == (page_buf = H5FL_MALLOC(H5PB_t)))

        HGOTO_ERROR(H5E_PAGEBUF, H5E_NOSPACE, FAIL, "memory allocation failed")

    /* initialize the new instance of H5PB_t */

    page_buf->magic     = H5PB__H5PB_T_MAGIC;
    page_buf->page_size = shared->fs_page_size;
    H5_CHECKED_ASSIGN(page_buf->page_size, size_t, shared->fs_page_size, hsize_t);
    page_buf->max_pages     = (int32_t)(size / shared->fs_page_size);
    page_buf->curr_pages    = 0;
    page_buf->curr_md_pages = 0;
    page_buf->curr_rd_pages = 0;
    page_buf->min_md_pages  = min_md_pages;
    page_buf->min_rd_pages  = min_rd_pages;

    page_buf->max_size      = size;
    page_buf->min_meta_perc = page_buf_min_meta_perc;
    page_buf->min_raw_perc  = page_buf_min_raw_perc;

    /* index */
    for (i = 0; i < H5PB__HASH_TABLE_LEN; i++)
        page_buf->ht[i] = NULL;
    page_buf->index_len        = 0;
    page_buf->clean_index_len  = 0;
    page_buf->dirty_index_len  = 0;
    page_buf->index_size       = 0;
    page_buf->clean_index_size = 0;
    page_buf->dirty_index_size = 0;
    page_buf->il_len           = 0;
    page_buf->il_size          = 0;
    page_buf->il_head          = NULL;
    page_buf->il_tail          = NULL;

    /* LRU */
    page_buf->LRU_len      = 0;
    page_buf->LRU_size     = 0;
    page_buf->LRU_head_ptr = NULL;
    page_buf->LRU_tail_ptr = NULL;

    /* VFD SWMR specific fields.
     * The following fields are defined iff vfd_swmr_writer is TRUE.
     */
    page_buf->vfd_swmr        = vfd_swmr;
    page_buf->vfd_swmr_writer = vfd_swmr_writer;
    page_buf->mpmde_count     = 0;
    page_buf->cur_tick        = 0;

    /* delayed write list */
    page_buf->max_delay    = 0;
    page_buf->dwl_len      = 0;
    page_buf->dwl_size     = 0;
    page_buf->dwl_head_ptr = NULL;
    page_buf->dwl_tail_ptr = NULL;

    /* tick list */
    page_buf->tl_len      = 0;
    page_buf->tl_size     = 0;
    page_buf->tl_head_ptr = NULL;
    page_buf->tl_tail_ptr = NULL;

    H5PB_reset_stats(page_buf);

    shared->page_buf = page_buf;

    /* if this is a VFD SWMR reader, inform the reader VFD that the
     * page buffer is configured.  Note that this is for sanity
     * checking, and only needed until we modify the file open
     * code to create the page buffer before any file reads in
     * the VFD SWMR reader case.  After that, this code should be
     * removed.
     *                               JRM -- 1/29/19
     */
    if ((H5F_SHARED_VFD_SWMR_CONFIG(shared)) && (0 == (H5F_SHARED_INTENT(shared) & H5F_ACC_RDWR))) {

        HDassert(shared->lf);
        HDassert(!shared->vfd_swmr_config.writer);

        H5FD_vfd_swmr_set_pb_configured(shared->lf);
    }

done:

    if (ret_value < 0) {

        if (page_buf != NULL) {

            page_buf = H5FL_FREE(H5PB_t, page_buf);
        }
    }

    FUNC_LEAVE_NOAPI(ret_value)

} /* H5PB_create */

/*-------------------------------------------------------------------------
 *
 * Function:	H5PB_dest
 *
 * Purpose:	Flush (if necessary) and evict all entries in the page
 *              buffer, and then discard the page buffer.
 *
 * Return:	Non-negative on success/Negative on failure
 *
 * Programmer:	John Mainzer -- 10/22/18
 *
 * Changes:     None.
 *
 *-------------------------------------------------------------------------
 */
herr_t
H5PB_dest(H5F_shared_t *shared)
{
    int           i;
    H5PB_t *      page_buf  = NULL;
    H5PB_entry_t *entry_ptr = NULL;
    H5PB_entry_t *evict_ptr = NULL;
    herr_t        ret_value = SUCCEED; /* Return value */

    FUNC_ENTER_NOAPI(FAIL)

    /* Sanity check */
    HDassert(shared);

    /* flush and destroy the page buffer, if it exists */
    if (shared->page_buf) {

        page_buf = shared->page_buf;

        HDassert(page_buf->magic == H5PB__H5PB_T_MAGIC);

        /* the current implementation if very inefficient, and will
         * fail if there are any outstanding delayed writes -- must fix this
         */
        for (i = 0; i < H5PB__HASH_TABLE_LEN; i++) {

            entry_ptr = page_buf->ht[i];

            while (entry_ptr) {

                HDassert(entry_ptr->magic == H5PB__H5PB_ENTRY_T_MAGIC);

                evict_ptr = entry_ptr;
                entry_ptr = entry_ptr->ht_next;

                if (evict_ptr->is_dirty) {

                    if (H5PB__flush_entry(shared, page_buf, evict_ptr) < 0)

                        HGOTO_ERROR(H5E_PAGEBUF, H5E_WRITEERROR, FAIL, "Can't flush entry")
                }

                if (H5PB__evict_entry(shared, evict_ptr, TRUE, TRUE) < 0)

                    HGOTO_ERROR(H5E_PAGEBUF, H5E_SYSTEM, FAIL, "forced eviction failed")

                entry_ptr = page_buf->ht[i];
            }
        }

        /* regular operations fields */
        HDassert(page_buf->curr_pages == 0);
        HDassert(page_buf->curr_md_pages == 0);
        HDassert(page_buf->curr_rd_pages == 0);
        HDassert(page_buf->index_len == 0);
        HDassert(page_buf->index_size == 0);
        HDassert(page_buf->LRU_len == 0);
        HDassert(page_buf->LRU_size == 0);
        HDassert(page_buf->LRU_head_ptr == NULL);
        HDassert(page_buf->LRU_tail_ptr == NULL);

        /* VFD SWMR fields */
        HDassert(page_buf->dwl_len == 0);
        HDassert(page_buf->dwl_size == 0);
        HDassert(page_buf->dwl_head_ptr == NULL);
        HDassert(page_buf->dwl_tail_ptr == NULL);

        HDassert(page_buf->tl_len == 0);
        HDassert(page_buf->tl_size == 0);
        HDassert(page_buf->tl_head_ptr == NULL);
        HDassert(page_buf->tl_tail_ptr == NULL);

        page_buf->magic  = 0;
        shared->page_buf = H5FL_FREE(H5PB_t, page_buf);
    }

done:

    FUNC_LEAVE_NOAPI(ret_value)

} /* H5PB_dest */

/*-------------------------------------------------------------------------
 *
 * Function:	H5PB_flush
 *
 * Purpose:	If the page buffer is defined, flush all entries.
 *
 * Return:	Non-negative on success/Negative on failure
 *
 * Programmer:	John Mainzer -- 10/22/18
 *
 * Changes:     None.
 *
 *-------------------------------------------------------------------------
 */
herr_t
H5PB_flush(H5F_shared_t *shared)
{
    int           i;
    H5PB_t *      page_buf  = NULL;
    H5PB_entry_t *entry_ptr = NULL;
    H5PB_entry_t *flush_ptr = NULL;
    herr_t        ret_value = SUCCEED; /* Return value */

    FUNC_ENTER_NOAPI(FAIL)

    /* Sanity check */
    HDassert(shared);

    page_buf = shared->page_buf;

    if (page_buf) {

        HDassert(page_buf->magic == H5PB__H5PB_T_MAGIC);

        /* the current implementation is very inefficient, and will
         * fail if there are any delayed writes -- must fix this
         */
        for (i = 0; i < H5PB__HASH_TABLE_LEN; i++) {

            entry_ptr = page_buf->ht[i];

            while (entry_ptr) {

                HDassert(entry_ptr->magic == H5PB__H5PB_ENTRY_T_MAGIC);

                flush_ptr = entry_ptr;
                entry_ptr = entry_ptr->ht_next;

                if (flush_ptr->is_dirty) {

                    if (flush_ptr->delay_write_until != 0)
                        continue;

                    if (H5PB__flush_entry(shared, page_buf, flush_ptr) < 0)

                        HGOTO_ERROR(H5E_PAGEBUF, H5E_WRITEERROR, FAIL, "Can't flush entry")
                }
            }
        }
    }

done:

    FUNC_LEAVE_NOAPI(ret_value)

} /* H5PB_flush */

/*-------------------------------------------------------------------------
 *
 * Function:	H5PB_page_exists
 *
 * Purpose:	Test to see if a page buffer page exists at the specified
 *              address.  Set *page_exists_ptr to TRUE or FALSE accordingly.
 *
 *              This function exists for the convenience of the test
 *              code
 *
 * Return:	Non-negative on success/Negative on failure
 *
 * Programmer:	John Mainzer -- 10/22/18
 *
 * Changes:     None.
 *
 *-------------------------------------------------------------------------
 */
herr_t
H5PB_page_exists(H5F_shared_t *shared, haddr_t addr, hbool_t *page_exists_ptr)
{
    uint64_t      page;
    H5PB_t *      page_buf  = NULL;
    H5PB_entry_t *entry_ptr = NULL;
    herr_t        ret_value = SUCCEED; /* Return value */

    FUNC_ENTER_NOAPI(FAIL)

    /* Sanity check */
    HDassert(shared);
    HDassert(shared->page_buf);

    page_buf = shared->page_buf;

    HDassert(page_buf->magic == H5PB__H5PB_T_MAGIC);
    HDassert(page_exists_ptr);

    /* Calculate the page offset */
    page = (addr / page_buf->page_size);

    /* the supplied address should be page aligned */
    HDassert(addr == page * page_buf->page_size);

    /* Search for page in the hash table  */
    H5PB__SEARCH_INDEX(page_buf, page, entry_ptr, FAIL)

    HDassert((NULL == entry_ptr) || (entry_ptr->addr == addr));

    *page_exists_ptr = (entry_ptr != NULL);

done:

    FUNC_LEAVE_NOAPI(ret_value)

} /* H5PB_page_exists */

static void
H5PB_count_meta_access_by_size(H5PB_t *pb, size_t size)
{
    const size_t nslots = NELMTS(pb->access_size_count);
    size_t       i, hi;

    for (hi = pb->page_size, i = 0; i < nslots - 1; i++, hi *= 2) {
        if (size <= hi)
            break;
    }
    pb->access_size_count[i]++;
}

/*-------------------------------------------------------------------------
 *
 * Function:	H5PB_read
 *
 * Purpose:	Satisfy the read from the page buffer if possible.
 *
 *              1) If the page buffer is disabled, simply read from the
 *                 HDF5 file and return.
 *
 *              2) If the read is for raw data, and the page buffer is
 *                 configured for metadata only (i.e. min_md_pages ==
 *                 max_pages), or if we are operating in VFD SWMR mode
 *                 (i.e. vfd_swmr == TRUE), simply read from the HDF5
 *                 file and return.
 *
 *              3) If the read is for raw data, and is of page size or
 *                 larger, read it directly from the HDF5 file.
 *
 *                 It is possible that the page buffer contains dirty pages
 *                 that intersect with the read -- test for this and update
 *                 the read buffer from the page buffer if any such pages
 *                 exist.
 *
 *                 Note that no pages are inserted into the page buffer in
 *                 this case.
 *
 *              4) If the read is for raw data, and it is of size less
 *                 than the page size, satisfy the read from the page
 *                 buffer, loading and inserting pages into the
 *                 page buffer as necessary
 *
 *              5) If the read is for metadata, and the page buffer is
 *                 configured for raw data only (i.e. min_rd_pages ==
 *                 max_pages), simply read from the HDF5 file and return.
 *
 *              The free space manager guarantees that allocations larger
 *              than one page will be page alligned, and that allocations
 *              of size less than or equal to page size will not cross page
 *              boundaries.  Further, unlike raw data, metadata is always
 *              written and read atomically.
 *
 *              In principle, this should make it easy to discriminate
 *              between small and multi-page metadata entries so that
 *              pages containing the former will be buffered and the
 *              latter be read directly from file.
 *
 *              Unfortunately, there are several flies in the ointment.
 *
 *              First, the fixed and extensible array on disk data
 *              structures allocate multiple metadata cache entries in
 *              a single block, and use this fact to make the addresses
 *              of all but the first entry in the block computable.  While
 *              this simplifies the fixed and extensible array on disk data
 *              structures, if complicates the metadata cache and the page
 *              buffer.  Needless to say, the correct solution to this
 *              problem is to remove the complexity at its source.  However,
 *              for now, we must code around the problem.
 *
 *              Thus, this function must examine each read request
 *              to determine if it crosses page boundaries and is not for
 *              two or more complete pages.  If it does, and it is one of
 *              the fixed or extensible array entries that is sub-allocated
 *              from a larger space allocation, the read request must be
 *              split into the minimal set of read requests that either
 *              don't cross page boundaries, or are page aligned and
 *              consist of an integral number of pages.
 *
 *
 *              Second, the metadata cache does not always know the
 *              size of metadata entries when it tries to read them.  In
 *              such cases, it issues speculative reads that may be either
 *              smaller or larger than the actual size of the piece of
 *              metadata that is finally read.
 *
 *              Since we are guaranteed that all metadata allocations larger
 *              that one page are page aligned (with the exception of those
 *              sub-allocated from larger allocations -- which we deal with
 *              by splitting I/O requests as discussed above), we can safely
 *              clip at the page boundary any non page aligned metadata
 *              read that crosses page boundaries.
 *
 *              However, page aligned reads could wind up being either
 *              small or multi-page.  This results in two scenarios that
 *              we must handle:
 *
 *                  a) A page aligned read of size less than one page
 *                     turns out to be mult-page.
 *
 *                     In this case, the initial speculative read will
 *                     result in a page load and insertion into the page
 *                     buffer.  This page must be evicted on the subsequent
 *                     read of size greater than page size.
 *
 *                     In the context of VFD SWMR, it is also possible that
 *                     that the multi-page metadata entry is already in the
 *                     page buffer -- in which case the initial read should
 *                     be satisfied from the multi-page page buffer entry.
 *
 *                  b) A page aligned, larger than one page read turns out
 *                     to be small (less than one page).
 *
 *                     If there is already a page in the page buffer with
 *                     same address, we can safely clip the original
 *                     read to page size
 *
 *              The above considerations resolve into the following cases:
 *
 *              6) If the read is for metadata and not page aligned, clip
 *                 the read to the end of the current page if necessary.
 *                 Load the relevant page if necessary and satisfy the
 *                 read from the page buffer.  Note that it there is an
 *                 existing page, it must not be a multi-page metadata
 *                 entry.  It it is, flag an error.
 *
 *              7) If the read is for metadata, is page aligned, is larger
 *                 than one page, and there is no entry in the page buffer,
 *                 satisfy the read from the file
 *
 *              8) If the read is for metadata, is page aligned, is larger
 *                 than one page, and there is a regular entry at the target
 *                 page address, test to see if the read is speculative.
 *
 *                 If it is not, evict the page, and satisfy the read from
 *                 file.  Flag an error if the page was dirty.
 *
 *                 If it is, clip the read to one page, and satisfy the
 *                 read from the existing regular entry.
 *
 *              9) If the read is for metadata, is page aligned, is larger
 *                 than one page, and there is a multi-page metadata entry
 *                 at the target page address, test to see if
 *                 page_buf->vfd_swmr_write is TRUE.
 *
 *                 If it is, satisfy the read from the multi-page metadata
 *                 entry, clipping the read if necessary.
 *
 *                 if page_buf->vfd_swmr_write is FALSE, flag an error.
 *
 *             10) If the read is for metadata, is page aligned, is no
 *                 larger than a page, test to see if the page buffer
 *                 contains a page at the target address.
 *
 *                 If it doesn't, load the page and satisfy the read
 *                 from it.
 *
 *                 If it contains a regular page entry, satisfy the read
 *                 from it.
 *
 *                 If it contains a multipage metadata entry at the target
 *                 address, satisfy the read from the multi-page metadata
 *                 entry if page_buf->vfd_swmr_write is TRUE, and flag an
 *                 error otherwise.
 *
 *              Observe that this function handles casses 1, 2, and 5
 *              directly, calls H5PB_read_raw() for cases 3 & 4, and
 *              calls H5PB_read_meta() for cases 6), 7, 8, 9), and 10).
 *
 * Return:	Non-negative on success/Negative on failure
 *
 * Programmer:	John Mainzer -- 10/11/18
 *
 * Changes:     Updated for discovery of the fact that the fixed and
 *              extensible array data structures allocate multiple
 *              metadata cache entries in a single block, and thus
 *              violate that invarient that metadata entries either
 *              do not cross page boundaries, or are page aligned.
 *
 *                                               JRM -- 3/28/20
 *
 *-------------------------------------------------------------------------
 */

herr_t
H5PB_read(H5F_shared_t *shared, H5FD_mem_t type, haddr_t addr, size_t size, void *buf /*out*/)
{
    H5PB_t *page_buf;             /* Page buffer for this file */
    hbool_t bypass_pb  = FALSE;   /* Whether to bypass page buffering */
    hbool_t split_read = FALSE;   /* whether the read must be split */
    herr_t  ret_value  = SUCCEED; /* Return value */

    /* the following six fields are defined iff split_read is TRUE */
    haddr_t prefix_addr = HADDR_UNDEF; /* addr of prefix -- if defined */
    haddr_t body_addr   = HADDR_UNDEF; /* addr of body -- if defined */
    haddr_t suffix_addr = HADDR_UNDEF; /* addr of suffix -- if defined */
    size_t  prefix_size = 0;           /* size of prefix */
    size_t  body_size   = 0;           /* size of body */
    size_t  suffix_size = 0;           /* size of suffix */

    FUNC_ENTER_NOAPI(FAIL)

    /* Sanity checks */
    HDassert(shared);

    page_buf = shared->page_buf;

    if (page_buf != NULL && type != H5FD_MEM_DRAW)
        H5PB_count_meta_access_by_size(page_buf, size);

    if (page_buf == NULL) {

        bypass_pb = TRUE; /* case 1) -- page buffer is disabled */
    }
    else {

        HDassert(page_buf->magic == H5PB__H5PB_T_MAGIC);

        if (H5FD_MEM_DRAW == type) { /* raw data read */

            if ((page_buf->min_md_pages == page_buf->max_pages) || (page_buf->vfd_swmr)) {

                /* case 2) -- page buffer configured for metadata only
                 *            or vfd swmr.
                 */
                bypass_pb = TRUE;
            }
        }
        else { /* metadata read */

            if (page_buf->min_rd_pages == page_buf->max_pages) {

                /* case 5) -- page buffer configured for raw data only */
                bypass_pb = TRUE;
            }
            else {
                /* determine whether the read request must be split,
                 * and if so, compute the start points and sizes of
                 * of the sections.
                 *
                 * Note: The following code is almost identical to the
                 *       similar code in H5PB_write().  Thus, on the surface,
                 *       it is an obvious candidate for refactoring into a
                 *       function 0r macro.
                 *
                 *       However, there are subtle differences between
                 *       the two pieces of code which are driven by the
                 *       possibility of speculative reads.
                 *
                 *       More to the point, further changes may be necessary.
                 *       Thus we should wait on refactoring until this code has
                 *       been in daily use for some time, and it is clear
                 *       that further changes are unlikely.
                 */
                int      mdc_client_id = -1; /* id of mdc client, or -1 if undef */
                uint64_t start_page;         /* page index of first page in read */
                uint64_t second_page;        /* page index of second page in read */
                uint64_t end_page;           /* page index of last page in read */
                uint64_t body_page;          /* page index of start of body */
                haddr_t  start_page_addr;    /* addr of first page in read */
                haddr_t  second_page_addr;   /* addr of second page in read */
                haddr_t  end_page_addr;      /* addr of last page in read */
                haddr_t  end_addr;           /* addr of last byte in read */

                /* Calculate the aligned address of the first page */
                start_page      = (addr / page_buf->page_size);
                start_page_addr = start_page * page_buf->page_size;

                /* Calculate the aligned address of the last page */
                end_addr      = addr + (haddr_t)(size - 1);
                end_page      = end_addr / (haddr_t)(page_buf->page_size);
                end_page_addr = end_page * page_buf->page_size;

                HDassert(start_page_addr <= addr);
                HDassert(addr < start_page_addr + (haddr_t)(page_buf->page_size));

                HDassert(start_page <= end_page);
                HDassert(end_page_addr <= ((addr + (haddr_t)size - 1)));
                HDassert((addr + (haddr_t)size - 1) < (end_page_addr + page_buf->page_size));

                /* test to see if the read crosses a page boundary, and
                 * does not start on a page boundary, and is not of an
                 * integral number of pages.
                 */
                if ((start_page < end_page) &&
                    (!((addr == start_page_addr) &&
                       (end_page_addr + (haddr_t)(page_buf->page_size) == end_addr + 1)))) {

                    /* the read crosses a page boundary and is not
                     * page aligned and of length some multiple of page size.
                     *
                     * Test to see if the read is for a metadata entry that
                     * is sub-allocated from a larger space allocation.
                     *
                     * Note that the following test may have to be
                     * adjusted.
                     */
                    mdc_client_id = H5C_get_curr_io_client_type(shared->cache);

                    if ((mdc_client_id == (int)H5AC_EARRAY_DBLK_PAGE_ID) ||
                        (mdc_client_id == (int)H5AC_FARRAY_DBLK_PAGE_ID)) {

                        split_read = TRUE;
                    }
                }

                if (split_read) {

                    /* compute the base addresses and length of the prefix,
                     * body, and suffix of the read, where these terms are
                     * defined as follows:
                     *
                     * prefix: All bytes from addr to the first page address
                     *         at or after addr.  If addr == start_page_addr,
                     *         the prefix is empty.
                     *
                     * body:   All bytes from the first page address covered
                     *         by the read up to but not including the last
                     *         page address in the read.  Note that the
                     *         length of the body must be a multiple of the
                     *         page size.  If only one page address is
                     *         included in the read, the body is empty.
                     *
                     * suffix: All bytes from the last page address in the
                     *         read until the end of the read.  If the
                     *         read ends on a page boundary, the suffix is
                     *         empty.
                     *
                     * Since we know that the read crosses at least one
                     * page boundary, and we have aleady filtered out the
                     * body only case, at least two of the above must be
                     * non-empty.
                     */

                    second_page      = start_page + 1;
                    second_page_addr = (haddr_t)(second_page * page_buf->page_size);

                    if (addr > start_page_addr) { /* prefix exists */

                        prefix_addr = addr;
                        prefix_size = (size_t)(second_page_addr - addr);

                        HDassert(prefix_addr > start_page_addr);
                        HDassert(prefix_size < page_buf->page_size);
                        HDassert(((size_t)(addr - start_page_addr) + prefix_size) == page_buf->page_size);
                    }

                    if (size - prefix_size >= page_buf->page_size) {

                        /* body exists */

                        if (addr == start_page_addr) {

                            body_page = start_page;
                            body_addr = start_page_addr;
                        }
                        else {

                            body_page = second_page;
                            body_addr = second_page_addr;
                        }

                        if (end_addr < end_page_addr + (haddr_t)(page_buf->page_size - 1)) {

                            /* suffix exists */
                            body_size = (size_t)(end_page - body_page) * page_buf->page_size;
                        }
                        else {

                            /* suffix is empty */
                            body_size = (size_t)(end_page - body_page + 1) * page_buf->page_size;
                        }

                        HDassert((body_page == start_page) || (body_page == start_page + 1));

                        HDassert(body_addr == (haddr_t)(body_page * page_buf->page_size));

                        HDassert(body_size < size);
                        HDassert(body_size >= page_buf->page_size);

                        HDassert(body_addr == addr + (haddr_t)prefix_size);
                        HDassert((body_addr + (haddr_t)body_size) <= (end_addr + 1));
                    }

                    if (end_addr < end_page_addr + (haddr_t)(page_buf->page_size - 1)) {

                        suffix_addr = end_page_addr;
                        suffix_size = (end_addr + 1) - end_page_addr;

                        HDassert(suffix_addr == addr + (haddr_t)(prefix_size + body_size));
                    }

                    HDassert(size == prefix_size + body_size + suffix_size);
                }
            }
        }
    }

#ifdef H5_HAVE_PARALLEL
    /* at present, the page buffer must be disabled in the parallel case.
     * However, just in case ...
     */
    if (H5F_SHARED_HAS_FEATURE(shared, H5FD_FEAT_HAS_MPI)) {

        bypass_pb = TRUE;

    }  /* end if */
#endif /* H5_HAVE_PARALLEL */

    if (bypass_pb) { /* cases 1, 2. and 5 */

        if (H5FD_read(shared->lf, type, addr, size, buf) < 0)

            HGOTO_ERROR(H5E_PAGEBUF, H5E_READERROR, FAIL, "read through  failed")

        /* Update statistics */
        if (page_buf) {

            H5PB__UPDATE_STATS_FOR_BYPASS(page_buf, type, size);
        }
    }
    else {

        if (H5FD_MEM_DRAW == type) { /* cases 3 and 4 */

            if (H5PB__read_raw(shared, type, addr, size, buf) < 0)

                HGOTO_ERROR(H5E_PAGEBUF, H5E_READERROR, FAIL, "H5PB_read_raw() failed")
        }
        else if (split_read) {

            /* handle the sub-allocated entry case */

            /* read prefix if it exists */
            if (prefix_size > 0) {

                if (H5PB__read_meta(shared, type, prefix_addr, prefix_size, buf) < 0)

                    HGOTO_ERROR(H5E_PAGEBUF, H5E_READERROR, FAIL, "H5PB_read_meta() failed on prefix")
            }

            /* read body -- if it exists. */
            if (body_size > 0) {

                if (H5PB__read_meta(shared, type, body_addr, body_size,
                                    (void *)((uint8_t *)buf + prefix_size)) < 0)

                    HGOTO_ERROR(H5E_PAGEBUF, H5E_READERROR, FAIL, "H5PB_read_meta() failed on body")
            }

            /* read suffix -- if it exists. */
            if (suffix_size > 0) {

                if (H5PB__read_meta(shared, type, suffix_addr, suffix_size,
                                    (void *)((uint8_t *)buf + prefix_size + body_size)) < 0)

                    HGOTO_ERROR(H5E_PAGEBUF, H5E_READERROR, FAIL, "H5PB_read_meta() failed on suffix")
            }

            H5PB__UPDATE_STATS_FOR_READ_SPLIT(page_buf)
        }
        else { /* pass to H5PB_read_meta() -- cases 6, 7, 8, 9, & 10 */

            if (H5PB__read_meta(shared, type, addr, size, buf) < 0)

                HGOTO_ERROR(H5E_PAGEBUF, H5E_READERROR, FAIL, "H5PB_read_meta() failed")
        }
    }

done:

    FUNC_LEAVE_NOAPI(ret_value)

} /* H5PB_read() */

/* Remove the entry corresponding to lower-file page number `page`.
 * Return 0 if there was no such entry or if the entry was removed
 * successfully.  Return -1 on error.
 *
 * If `only_mark` is true, then the entry corresponding shadow-index
 * entry is not removed.  Instead, it is marked as garbage.  This is
 * a stop-gap fix for a performance problem in H5PB_dest(): deleting
 * all of the index entries took time quadratic in their number because
 * this routine performs an O(n) copy of index entries.
 */
static int
shadow_idx_entry_remove(H5F_shared_t *shared, uint64_t page, hbool_t only_mark)
{
    ptrdiff_t                  i;
    H5FD_vfd_swmr_idx_entry_t *entry;

    entry = vfd_swmr_pageno_to_mdf_idx_entry(shared->mdf_idx, shared->mdf_idx_entries_used, page, FALSE);

    if (entry == NULL)
        return 0;

    if (shared->vfd_swmr_writer && entry->md_file_page_offset != 0) {
        if (shadow_image_defer_free(shared, entry) != 0)
            return -1;
        entry->md_file_page_offset = 0;
    }

    if (only_mark) {
        entry->garbage = TRUE;
        return 0;
    }

    i = entry - shared->mdf_idx;

    if (shared->mdf_idx_entries_used > i + 1) {
        const size_t ntocopy = (size_t)(shared->mdf_idx_entries_used - (i + 1));
        HDmemmove(&shared->mdf_idx[i], &shared->mdf_idx[i + 1], ntocopy * sizeof(shared->mdf_idx[i + 1]));
    }
    shared->mdf_idx_entries_used--;
    return 0;
}

/*-------------------------------------------------------------------------
 *
 * Function:    H5PB_remove_entry
 *
 * Purpose:     Remove possible metadata entry with ADDR from the PB cache.
 *
 *              This is in response to the data corruption bug from fheap.c
 *              with page buffering + page strategy.
 *
 *              Note: Large metadata page bypasses the PB cache.
 *
 *              Note: Update of raw data page (large or small sized) is
 *                    handled by the PB cache.
 *
 * Return:      Non-negative on success/Negative on failure
 *
 * Programmer:  Vailin Choi; Feb 2017
 *
 * Changes:     Reworked function for re-implementation of the page buffer.
 *
 *              In the context of VFD SWMR, it is possible that the
 *              discarded page or multi-page metadata entry has been
 *              modified during the current tick and/or is subject to a
 *              delayed write.  We must detect this, and remove the entry
 *              from the tick list and/or delayed write list before it is
 *              evicted.
 *
 *              Vailin: I think we need to do this for raw data as well.
 *
 *                                               JRM -- 10/23/18
 *
 *              We also need to evict modified pages from the page
 *              buffer in the VFD SWMR reader case to avoid message from
 *              the past bugs.  This function will serve for this for
 *              now, but for efficiency, we may want a version that takes
 *              a list of pages instead.
 *
 *                                               JRM -- 12/30/18
 *
 *-------------------------------------------------------------------------
 */
herr_t
H5PB_remove_entry(H5F_shared_t *shared, haddr_t addr)
{
    uint64_t      page;
    H5PB_t *      page_buf  = NULL;
    H5PB_entry_t *entry_ptr = NULL;
    herr_t        ret_value = SUCCEED; /* Return value */

    FUNC_ENTER_NOAPI(FAIL)

    /* Sanity checks */
    HDassert(shared);
    HDassert(shared->page_buf);

    page_buf = shared->page_buf;

    /* Calculate the page offset */
    page = (addr / page_buf->page_size);

    HDassert(addr == page * page_buf->page_size);

    /* Search for page in the hash table */
    H5PB__SEARCH_INDEX(page_buf, page, entry_ptr, FAIL)

    if (entry_ptr) {

        HDassert(entry_ptr->addr == addr);

        /* A page or a metadata multi-page with vfd_swmr_writer (case 7) */
        HDassert((entry_ptr->size == page_buf->page_size) ||
                 (entry_ptr->size > page_buf->page_size && entry_ptr->mem_type != H5FD_MEM_DRAW &&
                  page_buf->vfd_swmr_writer));

        if (entry_ptr->modified_this_tick) {

            H5PB__REMOVE_FROM_TL(page_buf, entry_ptr, FAIL);

            entry_ptr->modified_this_tick = FALSE;
        }

        if (entry_ptr->delay_write_until > 0) {

            entry_ptr->delay_write_until = 0;

            H5PB__REMOVE_FROM_DWL(page_buf, entry_ptr, FAIL)

            if (!(entry_ptr->is_mpmde)) {

                H5PB__UPDATE_RP_FOR_INSERTION(page_buf, entry_ptr, FAIL);
            }
        }

        /* if the entry is dirty, mark it clean before we evict */
        if ((entry_ptr->is_dirty) && (H5PB__mark_entry_clean(page_buf, entry_ptr) < 0))

            HGOTO_ERROR(H5E_PAGEBUF, H5E_SYSTEM, FAIL, "mark entry clean failed")

        if (H5PB__evict_entry(shared, entry_ptr, TRUE, FALSE) < 0)

            HGOTO_ERROR(H5E_PAGEBUF, H5E_SYSTEM, FAIL, "forced eviction failed")

        HDassert(!shared->vfd_swmr_writer ||
                 vfd_swmr_pageno_to_mdf_idx_entry(shared->mdf_idx, shared->mdf_idx_entries_used, page,
                                                  FALSE) == NULL);
    }

done:

    FUNC_LEAVE_NOAPI(ret_value)

} /* H5PB_remove_entry */

/*-------------------------------------------------------------------------
 *
 * Function:    H5PB_remove_entries
 *
 * Purpose:     Remove entries in the page buffer associated with a
 *              newly freed multi-page block of file space.
 *
 *              There are several possible situations here.
 *
 *              In the context of metadata, there are two possible cases.
 *
 *              1) The block of file space is associated with a metadata
 *                 entry.
 *
 *                 In regular operating mode, this entry will not be
 *                 cached in the page buffer, so there should be nothing
 *                 to do.
 *
 *                 In VFD SWMR mode, the entry may be cached in a single
 *                 multi-page entry.
 *
 *              2) The block of file space has been sub-allocated
 *                 into multiple metadata entries (i.e. fixed and extensible
 *                 array).  In this case, the individual entries may cross
 *                 boundaries without being page aligned -- however, for
 *                 purposes of the page buffer, I/O requests on these
 *                 entries will have been broken up into requests that
 *                 either do not cross page boundaries or are page aligned.
 *
 *              In the context of raw data, the page buffer may or may
 *              not contain regular entries scattered over the space
 *              touched by the newly freed file space.
 *
 *              In all contexts, there is no guarantee that the page buffer
 *              will contain any of the possible entries.
 *
 *              Space allocations larger than one page must be page alligned.
 *              Further, any space between the end of a multi-page allocation
 *              and the next page boundary will remain un-allocated until after
 *              the original allocation is freed.  This implies that:
 *
 *              1) The address passed into this call must be page aligned.
 *
 *              2) The page buffer may safely discard any page that
 *                 intersects with the newly freed file space allocation.
 *
 *              The bottom line here is that we must scan the page buffer
 *              index, and discard all entries that intersect the supplied
 *              address and length.  As a sanity check, we must verify that
 *              any such entries don't overlap.
 *
 *              Also, in the context of the VFD SWMR write, it is possible
 *              that the discarded pages will reside in the tick list or
 *              the delayed write list -- if so, they must be removed
 *              prior to eviction.
 *
 *              Note:
 *
 *              This function scans the page buffer hash table to
 *              find entries to remove.  While this is normally
 *              pretty in-expensive, a very large (i.e. GB) file
 *              space free may impose significant cost.
 *
 *              As best I understand it, such frees are rare, so
 *              the current solution should be good enough for now.
 *              However, if we determine that the current solution
 *              is too expensive, two alternate solutions come to mine.
 *
 *              a) Scan the index list instead of the hash table
 *                 if the free is sufficiently large.  Also, skip
 *                 entirely if the page buffer doesn't contain any
 *                 pages of the appropriate type.
 *
 *              b) Whenever writing a large metadata entry, scan for
 *                 intersecting entries and delete them.  (potential
 *                 issues with fixed and variable array entries are
 *                 dealt with via the splitting mechanism.)  In this
 *                 case we would also have to simply ignore writes
 *                 beyond EOA on flush or close.
 *
 *                 Note that we already scan for intersecting entries
 *                 on large raw data writes -- with possible performance
 *                 issues for large writes.
 *
 *                                            JRM -- 4/25/20
 *
 * Return:      Non-negative on success/Negative on failure
 *
 * Programmer:  John Mainzer 4/25/20
 *
 * Changes:     None.
 *
 *-------------------------------------------------------------------------
 */

herr_t
H5PB_remove_entries(H5F_shared_t *shared, haddr_t addr, hsize_t size)
{
    uint64_t      i;
    uint64_t      start_page;
    uint64_t      end_page;
    int64_t       entry_pages = 0;
    hsize_t       entry_size;
    H5PB_t *      page_buf  = NULL;
    H5PB_entry_t *entry_ptr = NULL;
    herr_t        ret_value = SUCCEED; /* Return value */

    FUNC_ENTER_NOAPI(FAIL)

    /* Sanity checks */
    HDassert(shared);
    HDassert(shared->page_buf);

    page_buf = shared->page_buf;

    /* Calculate the start_page offset */
    start_page = (addr / page_buf->page_size);

    HDassert(addr == start_page * page_buf->page_size);

    /* Calculate the end_page offset */
    end_page = ((addr + (haddr_t)(size - 1)) / page_buf->page_size);

    HDassert(start_page <= end_page);
    HDassert(((end_page - start_page) * page_buf->page_size) <= size);
    HDassert(size <= ((end_page - start_page + 1) * page_buf->page_size));

    for (i = start_page; i <= end_page; i++) {
        /* test to see if page i exists */
        H5PB__SEARCH_INDEX(page_buf, i, entry_ptr, FAIL)

        if (entry_ptr) {

            /* verify that this entry doesn't overlap with a previously
             * visited entry.
             */
            HDassert(entry_pages <= 0);

            entry_size  = entry_ptr->size;
            entry_pages = (int64_t)(entry_size / page_buf->page_size);

            if ((uint64_t)entry_pages * page_buf->page_size < entry_size) {

                entry_pages++;
            }

            /* remove the entry */
            if (H5PB_remove_entry(shared, entry_ptr->addr) < 0)

                HGOTO_ERROR(H5E_PAGEBUF, H5E_SYSTEM, FAIL, "H5PB_remove_entry() failed")
        }
        entry_pages--;
    }

done:

    FUNC_LEAVE_NOAPI(ret_value)

} /* H5PB_remove_entries() */

/*-------------------------------------------------------------------------
 *
 * Function:	H5PB_update_entry
 *
 * Purpose:	In PHDF5, metadata cache entries that are written by other
 *              processes are simply marked clean in the current process.
 *              However, if the page buffer is enabled, entries marked
 *              clean must still be written to the page buffer so as to
 *              keep the contents of metadata pages consistent on all
 *              processes.
 *
 *              Do this as follows:
 *
 *              1) Test to see if the page buffer is configured to accept
 *                 metadata pages.  If it isn't, return.
 *
 *              2) Test to see if the page buffer contains the page that
 *                 contains the supplied metadata cache entry.  If it
 *                 doesn't, return.
 *
 *              3) Write the supplied buffer to page at the appropriate
 *                 offset.
 *
 *              Note that at present, page buffering is disabled in the
 *              parallel case.  Thus this function has not been tested.
 *
 * Return:	Non-negative on success/Negative on failure
 *
 * Programmer:	John Mainzer -- 10/23/18
 *
 * Changes:     None.
 *
 *-------------------------------------------------------------------------
 */
herr_t
H5PB_update_entry(H5PB_t *page_buf, haddr_t addr, size_t size, const void *buf)
{
    uint64_t      page;
    size_t        offset;
    H5PB_entry_t *entry_ptr = NULL;
    haddr_t       page_addr;
    herr_t        ret_value = SUCCEED; /* Return value */

    FUNC_ENTER_NOAPI(FAIL)

    /* Sanity checks */
    HDassert(page_buf);
    HDassert(page_buf->magic == H5PB__H5PB_T_MAGIC);
    HDassert(size > 0);
    HDassert(size <= page_buf->page_size);
    HDassert(buf);

    if (page_buf->min_rd_pages < page_buf->max_pages) {

        /* page buffer is configured to accept metadata pages */

        /* Calculate the aligned address of the containing page */
        page      = (addr / page_buf->page_size);
        page_addr = page * page_buf->page_size;

        H5PB__SEARCH_INDEX(page_buf, page, entry_ptr, FAIL)

        if (entry_ptr) {

            HDassert(entry_ptr->is_metadata);
            HDassert(!(entry_ptr->is_mpmde));
            HDassert(addr + size <= page_addr + page_buf->page_size);

            offset = addr - page_addr;

            HDmemcpy(((uint8_t *)(entry_ptr->image_ptr) + offset), buf, size);

            /* should we mark the page dirty?  If so, replace the following
             * with a call to H5PB__mark_entry_dirty()
             */
            H5PB__UPDATE_RP_FOR_ACCESS(page_buf, entry_ptr, FAIL)
        }
    }

done:

    FUNC_LEAVE_NOAPI(ret_value)

} /* H5PB_update_entry */

/*-------------------------------------------------------------------------
 *
 * Function:	H5PB_vfd_swmr__release_delayed_writes
 *
 * Purpose:	After the tick list has been released, and before the
 *              beginning of the next tick, we must scan the delayed
 *              write list, and release those entries whose delays have
 *              expired.
 *
 *              Note that pages of metadata, and multi-page metadata entries
 *              are handled differently.
 *
 *              Regular pages are removed from the delayed write list and
 *              inserted in the replacement policy
 *
 *              In contrast, multi-page metadata entries are simply
 *              flushed and evicted.
 *
 *              Since the delayed write list is sorted in decreasing
 *              delay_write_until order, we start our scan at the bottom
 *              of the delayed write list and continue upwards until no
 *              expired entries remain.
 *
 * Return:	Non-negative on success/Negative on failure
 *
 * Programmer:	John Mainzer -- 11/15/18
 *
 * Changes:     None.
 *
 *-------------------------------------------------------------------------
 */
herr_t
H5PB_vfd_swmr__release_delayed_writes(H5F_shared_t *shared)
{
    H5PB_t *      page_buf  = NULL;
    H5PB_entry_t *entry_ptr = NULL;
    herr_t        ret_value = SUCCEED; /* Return value */

    FUNC_ENTER_NOAPI(FAIL)

    /* Sanity checks */
    HDassert(shared);
    HDassert(shared->vfd_swmr);
    HDassert(shared->vfd_swmr_writer);

    page_buf = shared->page_buf;

    HDassert(page_buf);
    HDassert(page_buf->magic == H5PB__H5PB_T_MAGIC);
    HDassert(page_buf->vfd_swmr_writer);

    while (page_buf->dwl_tail_ptr && page_buf->dwl_tail_ptr->delay_write_until <= shared->tick_num) {

        entry_ptr = page_buf->dwl_tail_ptr;

        HDassert(entry_ptr->is_dirty);

        entry_ptr->delay_write_until = 0;

        H5PB__REMOVE_FROM_DWL(page_buf, entry_ptr, FAIL)

        if (entry_ptr->is_mpmde) { /* flush and evict now */

            if (H5PB__flush_entry(shared, page_buf, entry_ptr) < 0)

                HGOTO_ERROR(H5E_PAGEBUF, H5E_WRITEERROR, FAIL, "flush of mpmde failed")

            if (H5PB__evict_entry(shared, entry_ptr, TRUE, FALSE) < 0)

                HGOTO_ERROR(H5E_PAGEBUF, H5E_SYSTEM, FAIL, "eviction of mpmde failed")
        }
        else { /* insert it in the replacement policy */

            H5PB__UPDATE_RP_FOR_INSERT_APPEND(page_buf, entry_ptr, FAIL)
        }
    }

done:

    FUNC_LEAVE_NOAPI(ret_value)

} /* H5PB_vfd_swmr__release_delayed_writes() */

/*-------------------------------------------------------------------------
 *
 * Function:	H5PB_vfd_swmr__release_tick_list
 *
 * Purpose:	After the metadata file has been updated, and before the
 *              beginning of the next tick, we must release the tick list.
 *
 *              This function performs this function.
 *
 *              In passing, flush and evict any multi-page metadata entries
 *              that are not subject to a delayed write.
 *
 * Return:	Non-negative on success/Negative on failure
 *
 * Programmer:	John Mainzer -- 11/12/18
 *
 * Changes:     None.
 *
 *-------------------------------------------------------------------------
 */
herr_t
H5PB_vfd_swmr__release_tick_list(H5F_shared_t *shared)
{
    H5PB_t *      page_buf  = NULL;
    H5PB_entry_t *entry_ptr = NULL;
    herr_t        ret_value = SUCCEED; /* Return value */

    FUNC_ENTER_NOAPI(FAIL)

    /* Sanity checks */
    HDassert(shared);
    HDassert(shared->vfd_swmr);
    HDassert(shared->vfd_swmr_writer);

    page_buf = shared->page_buf;

    HDassert(page_buf);
    HDassert(page_buf->magic == H5PB__H5PB_T_MAGIC);
    HDassert(page_buf->vfd_swmr_writer);

    /* remove all entries from the tick list */
    while (page_buf->tl_head_ptr) {

        entry_ptr = page_buf->tl_head_ptr;

        H5PB__REMOVE_FROM_TL(page_buf, entry_ptr, FAIL)

        entry_ptr->modified_this_tick = FALSE;

        if (entry_ptr->is_mpmde) {

            HDassert(entry_ptr->is_dirty);

            if (entry_ptr->delay_write_until == 0) {

                /* flush and evict the multi-page metadata entry immediately */
                if (H5PB__flush_entry(shared, page_buf, entry_ptr) < 0)

                    HGOTO_ERROR(H5E_PAGEBUF, H5E_WRITEERROR, FAIL, "flush of mpmde failed")

                if (H5PB__evict_entry(shared, entry_ptr, TRUE, FALSE) < 0)

                    HGOTO_ERROR(H5E_PAGEBUF, H5E_SYSTEM, FAIL, "eviction of mpmde failed")
            }
        }
        /* if the entry is not a multi-page metadata entry, it must already
         * be on either the replacment policy or the delayed write list.
         * In either case, it will be flush when possible and necessary.
         */
    }

    HDassert(page_buf->tl_head_ptr == NULL);
    HDassert(page_buf->tl_tail_ptr == NULL);
    HDassert(page_buf->tl_len == 0);
    HDassert(page_buf->tl_size == 0);

done:

    FUNC_LEAVE_NOAPI(ret_value)

} /* H5PB_vfd_swmr__release_tick_list */

/*-------------------------------------------------------------------------
 *
 * Function:	H5PB_vfd_swmr__set_tick
 *
 * Purpose:	At the beginning of each tick, the page buffer must be told
 *              to synchronize its copy of the current tick with that of
 *              the file to which the page buffer belongs.
 *
 *              This function performs this function.
 *
 * Return:	Non-negative on success/Negative on failure
 *
 * Programmer:	John Mainzer -- 11/20/18
 *
 * Changes:     None.
 *
 *-------------------------------------------------------------------------
 */
herr_t
H5PB_vfd_swmr__set_tick(H5F_shared_t *shared)
{
    H5PB_t *page_buf  = NULL;
    herr_t  ret_value = SUCCEED; /* Return value */

    FUNC_ENTER_NOAPI(FAIL)

    /* Sanity checks */
    HDassert(shared);
    HDassert(shared->vfd_swmr);
    HDassert(shared->vfd_swmr_writer);

    page_buf = shared->page_buf;

    HDassert(page_buf);
    HDassert(page_buf->magic == H5PB__H5PB_T_MAGIC);
    HDassert(page_buf->vfd_swmr_writer);

    /* the tick must always increase by 1 -- verify this */
    if (shared->tick_num != page_buf->cur_tick + 1)

        HGOTO_ERROR(H5E_PAGEBUF, H5E_SYSTEM, FAIL,
                    "shared->tick_num (%" PRIu64 ") != (%" PRIu64 ") page_buf->cur_tick + 1 ?!?!",
                    shared->tick_num, page_buf->cur_tick)

    page_buf->cur_tick = shared->tick_num;

done:

    FUNC_LEAVE_NOAPI(ret_value)

} /* H5PB_vfd_swmr__release_tick_list */

/*-------------------------------------------------------------------------
 *
 * Function:	H5PB_vfd_swmr__update_index
 *
 * Purpose:	In the VFD SWMR writer, all metadata writes to the page
 *              buffer during a tick are buffered in the page buffer in
 *              the tick list.  Further, the metadata cache is flushed
 *              to the page buffer at the end of the tick so that all
 *              metadata changes during the tick are reflected in the
 *              tick list.
 *
 *              Once this is done, the internal representation of the
 *              metadata file index must be updated from the tick list
 *              so that the metadata file can be updated, and the tick
 *              list can be emptied and prepared to buffer metadata changes
 *              in the next tick.
 *
 *              This function is called to accomplish this.  Its cycle of
 *              operation is as follows:
 *
 *              1) Scan the tick list.  For each entry (*entry), test
 *                 to see if it appears in the index.
 *
 *                 If it does the entry must have been modified in the
 *                 past tick.  Update the index entry (*ie_ptr) as follows:
 *
 *                 a) Set ie_ptr->entry_ptr = entry->image_ptr.  This
 *                    is needed to give the metadata file update code
 *                    access to the image of the target page or multi-page
 *                    multi-date entry.  Note that ie_ptr->entry_ptr will
 *                    be set to NULL as soon as the metadata file is updated,
 *                    so the buffer pointed to by entry->image_ptr can
 *                    be safely discarded at any time after the metadata
 *                    file update.
 *
 *                 b) Set ie_ptr->tick_of_last_change to the current tick.
 *
 *                 c) If entry->is_dirty, set ie_ptr->clean to FALSE.
 *                    If entry->is_dirty is FALSE, set ie_ptr->clean
 *                    to TRUE and set ie_ptr->tick_of_last_flush to the
 *                    current tick.
 *
 *                 If the tick list entry (*entry) doesn't appear in
 *                 the index, allocate a metadata file index entry (*ie_ptr),
 *                 and initialize it as follows:
 *
 *                     ie_ptr->hdf5_page_offset = entry->page
 *                     ie_ptr->length           = entry->size
 *                     ie_ptr->delayed_flush    = entry->delay_write_until
 *
 *                 and then update the new entry as per the existing entry
 *                 case described above.
 *
 *              2) Scan the internal representation of the metadata file
 *                 index for entries that do not appear in the tick list.
 *                 For each such entry (*ie_ptr), proceed as follows:
 *
 *                 1) If ie_ptr->clean, we are done -- proceed to the
 *                    next index entry that doesn't appear in the tick list.
 *
 *                 2) Test to see if the cognate entry appears in the page
 *                    buffer.  If it doesn't, it must have been flushed and
 *                    evicted in the past tick.  Set
 *
 *                        ie_ptr->clean = TRUE, and
 *
 *                        ie_ptr->tick_of_last_flush = current tick
 *
 *                    and proceed to the next index entry that doesn't
 *                    appear in the tick list.
 *
 *                 3) If the cognate entry does appear in the page buffer
 *                    and is clean, proceed as per 2) above.
 *
 *                 4) In all other cases, do nothing, and proceed to the
 *                    next index entry that does not appear in the tick list.
 *
 *
 * Return:	Non-negative on success/Negative on failure
 *
 * Programmer:	John Mainzer -- 11/9/18
 *
 * Changes:     None.
 *
 *-------------------------------------------------------------------------
 */
herr_t
H5PB_vfd_swmr__update_index(H5F_t *f, uint32_t *idx_ent_added_ptr, uint32_t *idx_ent_modified_ptr,
                            uint32_t *idx_ent_not_in_tl_ptr, uint32_t *idx_ent_not_in_tl_flushed_ptr)
{
    H5F_shared_t *const        shared   = f->shared;
    const uint64_t             tick_num = shared->tick_num;
    uint32_t                   i;
    uint32_t                   idx_ent_added             = 0;
    uint32_t                   idx_ent_modified          = 0;
    uint32_t                   idx_ent_not_in_tl         = 0;
    uint32_t                   idx_ent_not_in_tl_flushed = 0;
    H5PB_t *                   page_buf                  = NULL;
    H5PB_entry_t *             entry;
    H5FD_vfd_swmr_idx_entry_t *ie_ptr    = NULL;
    H5FD_vfd_swmr_idx_entry_t *idx       = NULL;
    herr_t                     ret_value = SUCCEED; /* Return value */

    FUNC_ENTER_NOAPI(FAIL)

    HDassert(shared->vfd_swmr);
    HDassert(shared->vfd_swmr_writer);

    idx = shared->mdf_idx;

    HDassert(idx);

    page_buf = shared->page_buf;

    HDassert(page_buf);
    HDassert(page_buf->magic == H5PB__H5PB_T_MAGIC);
    HDassert(page_buf->vfd_swmr_writer);

    HDassert(idx_ent_added_ptr);
    HDassert(idx_ent_modified_ptr);
    HDassert(idx_ent_not_in_tl_ptr);
    HDassert(idx_ent_not_in_tl_flushed_ptr);

    /* scan the tick list and insert or update metadata file index entries
     * as appropriate.
     */

    for (entry = page_buf->tl_head_ptr; entry != NULL; entry = entry->tl_next) {
        uint64_t target_page = entry->page;

        HDassert(entry->magic == H5PB__H5PB_ENTRY_T_MAGIC);

        /* see if the shadow index already contains an entry for *entry. */

        ie_ptr = vfd_swmr_pageno_to_mdf_idx_entry(idx, shared->mdf_idx_entries_used, target_page, FALSE);

        if (ie_ptr == NULL) { /* alloc new entry in the metadata file index*/
            uint32_t new_index_entry_index;

            new_index_entry_index = shared->mdf_idx_entries_used + idx_ent_added++;

            if (new_index_entry_index >= shared->mdf_idx_len &&
                (idx = vfd_swmr_enlarge_shadow_index(f)) == NULL) {
                HDfprintf(stderr, "\n\nmax mdf index len (%" PRIu32 ") exceeded.\n\n", shared->mdf_idx_len);
                HDfprintf(stderr, "tick = %" PRIu64 ".\n", tick_num);
                HDexit(EXIT_FAILURE);
            }

            ie_ptr = idx + new_index_entry_index;

            /* partial initialization of new entry -- rest done later */
            ie_ptr->hdf5_page_offset    = target_page;
            ie_ptr->md_file_page_offset = 0; /* undefined at this point */
            ie_ptr->checksum            = 0; /* undefined at this point */
            /* ie_ptr->entry_ptr            initialized below */
            /* ie_ptr->tick_of_last_change  initialized below */
            /* ie_ptr->clean                initialized below */
            /* ie_ptr->tick_of_last_flush   initialized below */
            ie_ptr->delayed_flush       = entry->delay_write_until;
            ie_ptr->moved_to_lower_file = FALSE;
            ie_ptr->garbage             = FALSE;
            ie_ptr->length              = (uint32_t)entry->size;
        }
        else {
            /* If entry->size changed, discard the too-small (too-big?)
             * shadow region and set the shadow-file page number to 0
             * so that H5F_update_vfd_swmr_metadata_file() will
             * allocate a new one.
             */
            if (ie_ptr->length != (uint32_t)entry->size) {
                int ret;

                ret = shadow_image_defer_free(shared, ie_ptr);
                HDassert(ret == 0);

                ie_ptr->md_file_page_offset = 0;
                ie_ptr->length              = (uint32_t)entry->size;
            }

            idx_ent_modified++;
        }

        ie_ptr->entry_ptr           = entry->image_ptr;
        ie_ptr->tick_of_last_change = tick_num;
        HDassert(entry->is_dirty);
        ie_ptr->clean              = FALSE;
        ie_ptr->tick_of_last_flush = 0;
    }

    /* scan the metadata file index for entries that don't appear in the
     * tick list.  If the index entry is dirty, and either doesn't appear
     * in the page buffer, or is clean in the page buffer, mark the index
     * entry clean and as having been flushed in the current tick.
     */
    for (i = 0; i < shared->mdf_idx_entries_used; i++) {

        HDassert(i == 0 || idx[i - 1].hdf5_page_offset < idx[i].hdf5_page_offset);

        ie_ptr = idx + i;

        if (ie_ptr->tick_of_last_change == tick_num)
            continue;

        idx_ent_not_in_tl++;

        if (ie_ptr->clean)
            continue;

        H5PB__SEARCH_INDEX(page_buf, ie_ptr->hdf5_page_offset, entry, FAIL);

        if (entry == NULL || !entry->is_dirty) {
            idx_ent_not_in_tl_flushed++;
            ie_ptr->clean              = TRUE;
            ie_ptr->tick_of_last_flush = tick_num;
        }
    }

    HDassert(idx_ent_modified + idx_ent_not_in_tl == shared->mdf_idx_entries_used);

    HDassert(idx_ent_modified + idx_ent_not_in_tl + idx_ent_added <= shared->mdf_idx_len);

    *idx_ent_added_ptr             = idx_ent_added;
    *idx_ent_modified_ptr          = idx_ent_modified;
    *idx_ent_not_in_tl_ptr         = idx_ent_not_in_tl;
    *idx_ent_not_in_tl_flushed_ptr = idx_ent_not_in_tl_flushed;

done:

    FUNC_LEAVE_NOAPI(ret_value)

} /* H5PB_vfd_swmr__update_index() */

/*-------------------------------------------------------------------------
 *
 * Function:	H5PB_write
 *
 * Purpose:	Write data into the Page Buffer if practical, and to file
 *              otherwise.  Specifically:
 *
 *              1) If the page buffer is disabled, simply write to the
 *                 HDF5 file and return.
 *
 *              2) If the write is raw data, and the page buffer is
 *                 configured for metadata only (i.e. min_md_pages ==
 *                 max_pages), or if the page buffer is operating in
 *                 vfd_swmr mode, simply write to the HDF5 file and return.
 *
 *              3) If the write is raw data, and is of page size or
 *                 larger, write directly from the HDF5 file.
 *
 *                 It is possible that the write intersects one or more
 *                 pages in the page buffer -- test for this and update
 *                 any partially written pages, and evict any pages
 *                 that are completely overwritten.
 *
 *                 Note that no pages are inserted into the page buffer in
 *                 this case.
 *
 *              4) If the write is of raw data, and it is of size less
 *                 than the page size, write the page into the page
 *                 buffer, loading and inserting pages into the
 *                 page buffer as necessary
 *
 *              5) If the write is of metadata, and the page buffer is
 *                 configured for raw data only (i.e. min_rd_pages ==
 *                 max_pages), simply write to the HDF5 file and return.
 *
 *              The free space manager guarantees that allocations larger
 *              than one page will be page alligned, and that allocations
 *              of size less than or equal to page size will not cross page
 *              boundaries.  Further, unlike raw data, metadata is always
 *              written and read atomically.
 *
 *              In principle, this should make it easy to discriminate
 *              between small and multi-page metadata entries so that
 *              pages containing the former will be buffered and the
 *              latter be written directly to file.
 *
 *              Unfortunately, there is a fly in the ointment.
 *
 *              The fixed and extensible array on disk data
 *              structures allocate multiple metadata cache entries in
 *              a single block, and use this fact to make the addresses
 *              of all but the first entry in the block computable.  While
 *              this simplifies the fixed and extensible array on disk data
 *              structures, it complicates the metadata cache and the page
 *              buffer.
 *
 *              From the page buffer perspective, it breaks the invarient
 *              that metadata entries of less than page size don't cross
 *              page boundaries, and those of size greater than or equal
 *              to page size start on page boundaries -- which is important
 *              for VFD SWMR as it allows efficient management of multi-page
 *              metadata entries.
 *
 *              While it is tempting to repair the fixed and extensible
 *              array data structures so as to remove this irregularity,
 *              and remove the resulting complexity from both the metadata
 *              cache and the page buffer, this is a ticklish task, as there
 *              are already files in the wild that use the existing versions
 *              of these data structures.  Thus, due to resource constraints,
 *              we have to program around the issue for now.
 *
 *              Fortunately, for purposes of the page buffer, this is
 *              relatively easy -- when we encounter a metadata write
 *              that crosses one or more page boundaries, and is not
 *              both page aligned and an integral number of pages, we
 *              query the metadata cache to determine the type of the
 *              client whose data is being writtne.  If it is one of the
 *              mis-behaving types, we split it into two or three writes
 *              such that each write either doesn't cross page boundaries,
 *              or is page aligned and an integral number of pages.
 *
 *              This is done in this function, and is not reflected in
 *              the case analysis in the rest of this comment.
 *
 *              6) If the write is of metadata, the write is larger than
 *                 one page, and vfd_swmr_writer is FALSE, simply write
 *                 to the HDF5 file.  There is no need to check the
 *                 page buffer, as metadata is always read atomically,
 *                 and entries of this size are not buffered in the page
 *                 buffer.
 *
 *                 Observe that this write must be page aligned.  This
 *                 should be enforced by the free space manager, but
 *                 for now it is enforced by the above mentioned practice
 *                 of splitting writes from cache client that don't
 *                 allocate each entry separately.
 *
 *              7) If the write is of metadata, the write is larger than
 *                 one page, and vfd_swmr_writer is TRUE, the write must
 *                 buffered in the page buffer until the end of the tick.
 *
 *                 If it doesn't exist already, create a multi-page metadata
 *                 entry in the page buffer and copy the write into it.
 *                 Insert the new entry in the tick list if necessary.
 *
 *                 Test to see if the write of the multi-page metadata
 *                 entry must be delayed.  If so, place the entry in
 *                 the delayed write list.  Otherwise, the multi-page
 *                 metadata entry will be written to the HDF5 file and
 *                 evicted when the tick list is released at the of the
 *                 tick.
 *
 *
 *              8) If the write is of metadata, and the write is of size
 *                 less than or equal to the page size, write the data
 *                 into the page buffer, loading and inserting a page
 *                 if necessary.
 *
 *                 If, in addition, vfd_swmr_writer is TRUE, add the page
 *                 touched by the write to the tick list.
 *
 *              Observe that this function handles casses 1, 2, 5, and 6
 *              directly, calls H5PB_write_raw() for cases 3 & 4, and
 *              calls H5PB_read_meta() for cases 7, and 8.
 *
 * Return:	Non-negative on success/Negative on failure
 *
 * Programmer:	John Mainzer -- 10/11/18
 *
 * Changes:     Updated to support splitting of metadata writes that
 *              are not page aligned and cross page boundaries into
 *              2 or 3 writes that are either page aligned or do not
 *              cross page boundaries.  Full details in the header
 *              comment above, that has been updated to document
 *              this change.
 *
 *              Also updated case 2 to bypass the page buffer for raw
 *              data writes in vfd swmr mode.
 *
 *                                      JRM -- 4/5/20
 *
 *-------------------------------------------------------------------------
 */
herr_t
H5PB_write(H5F_shared_t *shared, H5FD_mem_t type, haddr_t addr, size_t size, const void *buf)
{
    H5PB_t *page_buf;              /* Page buffer for this file */
    hbool_t bypass_pb   = FALSE;   /* Whether to bypass page buffering */
    hbool_t split_write = FALSE;   /* whether md write must be split */
    herr_t  ret_value   = SUCCEED; /* Return value */

    /* the following six fields are defined iff split_write is TRUE */
    haddr_t prefix_addr = HADDR_UNDEF; /* addr of prefix -- if defined */
    haddr_t body_addr   = HADDR_UNDEF; /* addr of body -- if defined */
    haddr_t suffix_addr = HADDR_UNDEF; /* addr of suffix -- if defined */
    size_t  prefix_size = 0;           /* size of prefix */
    size_t  body_size   = 0;           /* size of body */
    size_t  suffix_size = 0;           /* size of suffix */

    FUNC_ENTER_NOAPI(FAIL)

    page_buf = shared->page_buf;

    if (page_buf != NULL && type != H5FD_MEM_DRAW)
        H5PB_count_meta_access_by_size(page_buf, size);

    if (page_buf == NULL) {

        bypass_pb = TRUE; /* case 1) -- page buffer is disabled */
    }
    else {

        HDassert(page_buf->magic == H5PB__H5PB_T_MAGIC);

        if (H5FD_MEM_DRAW == type) { /* raw data write */

            if ((page_buf->min_md_pages == page_buf->max_pages) || (page_buf->vfd_swmr)) {

                /* case 2) -- page buffer configured for metadata only */
                bypass_pb = TRUE;
            }
        }
        else { /* metadata write */

            if (page_buf->min_rd_pages == page_buf->max_pages) {

                /* case 5) -- page buffer configured for raw data only */
                bypass_pb = TRUE;
            }
            else {

                /* determine whether the write request must be split,
                 * and if so, compute the start points and sizes of
                 * of the sections.
                 *
                 * Note: The following code is almost identical to the
                 *       similar code in H5PB_read().  Thus, on the surface,
                 *       it is an obvious candidate for refactoring into a
                 *       function or macro.
                 *
                 *       However, there are subtle differences between
                 *       the two pieces of code which are driven by the
                 *       possibility of speculative reads.
                 *
                 *       More to the point, further changes may be necessary.
                 *       Thus we should wait on refactoring until this code has
                 *       been in daily use for some time, and it is clear
                 *       that further changes are unlikely.
                 */
                int      mdc_client_id = -1; /* id of mdc client, or -1 if undef */
                uint64_t start_page;         /* page index of first page in read */
                uint64_t second_page;        /* page index of second page in read */
                uint64_t end_page;           /* page index of last page in read */
                uint64_t body_page;          /* page index of start of body */
                haddr_t  start_page_addr;    /* addr of first page in read */
                haddr_t  second_page_addr;   /* addr of second page in read */
                haddr_t  end_page_addr;      /* addr of last page in read */
                haddr_t  end_addr;           /* addr of last byte in read */

                /* Calculate the aligned address of the first page */
                start_page      = (addr / page_buf->page_size);
                start_page_addr = start_page * page_buf->page_size;

                /* Calculate the aligned address of the last page */
                end_addr      = addr + (haddr_t)(size - 1);
                end_page      = end_addr / (haddr_t)(page_buf->page_size);
                end_page_addr = end_page * page_buf->page_size;

                HDassert(start_page_addr <= addr);
                HDassert(addr < start_page_addr + (haddr_t)(page_buf->page_size));

                HDassert(start_page <= end_page);
                HDassert(end_page_addr <= ((addr + (haddr_t)size - 1)));
                HDassert((addr + (haddr_t)size - 1) < (end_page_addr + page_buf->page_size));

                /* test to see if the write crosses a page boundary, and
                 * does not start on a page boundary, and is not of an
                 * integral number of pages.
                 */
                if ((start_page < end_page) &&
                    (!((addr == start_page_addr) &&
                       (end_page_addr + (haddr_t)(page_buf->page_size) == end_addr + 1)))) {

                    /* the read crosses a page boundary and is not
                     * page aligned and of length some multiple of page size.
                     *
                     * Test to see if the read is for a metadata entry that
                     * is sub-allocated from a larger space allocation.
                     *
                     * Note that the following test may have to be
                     * adjusted.
                     */
                    mdc_client_id = H5C_get_curr_io_client_type(shared->cache);

                    if ((mdc_client_id == (int)H5AC_EARRAY_DBLK_PAGE_ID) ||
                        (mdc_client_id == (int)H5AC_FARRAY_DBLK_PAGE_ID)) {

                        split_write = TRUE;
                    }
                    else {

                        HDassert(addr == start_page_addr);
                        HDassert(size > page_buf->page_size);

                        if (!page_buf->vfd_swmr_writer) {

                            /* case 6) -- multi-page entry with fixed /
                             * extensible array filtered out, and no
                             * no VFD swmr.
                             */
                            bypass_pb = TRUE;
                        }
                    }
                }
                else if ((size > page_buf->page_size) && (!page_buf->vfd_swmr_writer)) {

                    /* write is larger than page size and we are not
                     * in VFD SWMR mode -- bypass the page buffer.
                     * This is also case 6.  We catch it here as
                     * the code to determine whether to split only
                     * looks at I/O requests that cross page bundaries
                     * and are not both page aligned and an integral
                     * number of pages in length.
                     */
                    HDassert(start_page_addr == addr);
                    bypass_pb = TRUE;
                }

                if (split_write) {

                    /* compute the base addresses and length of the prefix,
                     * body, and suffix of the write, where these terms are
                     * defined as follows:
                     *
                     * prefix: All bytes from addr to the first page address
                     *         at or after addr.  If addr == start_page_addr,
                     *         the prefix is empty.
                     *
                     * body:   All bytes from the first page address covered
                     *         by the write up to but not including the last
                     *         page address in the write.  Note that the
                     *         length of the body must be a multiple of the
                     *         page size.  If only one page address is
                     *         included in the write, the body is empty.
                     *
                     * suffix: All bytes from the last page address in the
                     *         write until the end of the write.  If the
                     *         write ends on a page boundary, the suffix is
                     *         empty.
                     *
                     * Since we know that the write crosses at least one
                     * page boundary, and we have aleady filtered out the
                     * body only case, at least two of the above must be
                     * non-empty.
                     */

                    second_page      = start_page + 1;
                    second_page_addr = (haddr_t)(second_page * page_buf->page_size);

                    if (addr > start_page_addr) { /* prefix exists */

                        prefix_addr = addr;
                        prefix_size = (size_t)(second_page_addr - addr);

                        HDassert(prefix_addr > start_page_addr);
                        HDassert(prefix_size < page_buf->page_size);
                        HDassert(((size_t)(addr - start_page_addr) + prefix_size) == page_buf->page_size);
                    }

                    if (size - prefix_size >= page_buf->page_size) {

                        /* body exists */

                        if (addr == start_page_addr) {

                            body_page = start_page;
                            body_addr = start_page_addr;
                        }
                        else {

                            body_page = second_page;
                            body_addr = second_page_addr;
                        }

                        if (end_addr < end_page_addr + (haddr_t)(page_buf->page_size - 1)) {

                            /* suffix exists */
                            body_size = (size_t)(end_page - body_page) * page_buf->page_size;
                        }
                        else {

                            /* suffix is empty */
                            body_size = (size_t)(end_page - body_page + 1) * page_buf->page_size;
                        }

                        HDassert((body_page == start_page) || (body_page == start_page + 1));

                        HDassert(body_addr == (haddr_t)(body_page * page_buf->page_size));

                        HDassert(body_size < size);
                        HDassert(body_size >= page_buf->page_size);

                        HDassert(body_addr == addr + (haddr_t)prefix_size);
                        HDassert((body_addr + (haddr_t)body_size) <= (end_addr + 1));
                    }

                    if (end_addr < end_page_addr + (haddr_t)(page_buf->page_size - 1)) {

                        suffix_addr = end_page_addr;
                        suffix_size = (end_addr + 1) - end_page_addr;

                        HDassert(suffix_addr == addr + (haddr_t)(prefix_size + body_size));
                    }

                    HDassert(size == prefix_size + body_size + suffix_size);
                }
            }
        }
    }

#ifdef H5_HAVE_PARALLEL
    /* at present, the page buffer must be disabled in the parallel case.
     * However, just in case ...
     */
    if (H5F_SHARED_HAS_FEATURE(shared, H5FD_FEAT_HAS_MPI)) {

        bypass_pb = TRUE;

    }  /* end if */
#endif /* H5_HAVE_PARALLEL */

    if (bypass_pb) { /* cases 1, 2. 5, and 6 */

        if (H5FD_write(shared->lf, type, addr, size, buf) < 0)

            HGOTO_ERROR(H5E_PAGEBUF, H5E_WRITEERROR, FAIL, "write through lower VFD failed")

        /* Update statistics */
        if (page_buf) {

            H5PB__UPDATE_STATS_FOR_BYPASS(page_buf, type, size);
        }
    }
    else {

        if (H5FD_MEM_DRAW == type) { /* cases 3 and 4 */

            if (H5PB__write_raw(shared, type, addr, size, buf) < 0)

                HGOTO_ERROR(H5E_PAGEBUF, H5E_WRITEERROR, FAIL, "H5PB_read_raw() failed")
        }
        else if (split_write) {

            /* handle the sub-allocated entry case */

            /* write prefix if it exists */
            if (prefix_size > 0) {

                if (H5PB__write_meta(shared, type, addr, prefix_size, buf) < 0)

                    HGOTO_ERROR(H5E_PAGEBUF, H5E_WRITEERROR, FAIL, "H5PB__write_meta() failed on prefix")
            }

            /* write the body if it exists */
            if (body_size > 0) {

                /* The "body_size == page_buf->page_size" clause in the
                 * following if is required since in normal operating
                 * mode, the page buffer buffers metadata I/O
                 * requests of page size or less.
                 *
                 * Thus this clause ensures that a single page body
                 * does not bypass the page buffer, setting the potential
                 * for an older version to shadow the most recent version.
                 *
                 * Note: The page buffer really shouldn't buffer page
                 *       aligned single page metadata I/O requests, as it
                 *       creates extra overhead to no purpose.  However,
                 *       fixing this is a bit tricky, and the case doesn't
                 *       appear to be common.  Thus, while it should be
                 *       fixed,  I don't think it is urgent.
                 *
                 *                           JRM 4/19/20
                 */
                if ((page_buf->vfd_swmr) || (body_size == page_buf->page_size)) {

                    if (H5PB__write_meta(shared, type, body_addr, body_size,
                                         (const void *)((const uint8_t *)buf + prefix_size)) < 0)

                        HGOTO_ERROR(H5E_PAGEBUF, H5E_WRITEERROR, FAIL, "H5PB__write_meta() failed on body")
                }
                else {

                    if (H5FD_write(shared->lf, type, body_addr, body_size,
                                   (const void *)((const uint8_t *)buf + prefix_size)) < 0)

                        HGOTO_ERROR(H5E_PAGEBUF, H5E_WRITEERROR, FAIL, "write through of body failed")

                    H5PB__UPDATE_STATS_FOR_BYPASS(page_buf, type, size);
                }
            }

            /* write the suffix if it exists */
            if (suffix_size > 0) {

                if (H5PB__write_meta(shared, type, suffix_addr, suffix_size,
                                     (const void *)((const uint8_t *)buf + prefix_size + body_size)) < 0)

                    HGOTO_ERROR(H5E_PAGEBUF, H5E_WRITEERROR, FAIL, "H5PB_write_meta() failed on suffix")
            }

            H5PB__UPDATE_STATS_FOR_WRITE_SPLIT(page_buf)
        }
        else { /* cases 7, and 8 */

            if (H5PB__write_meta(shared, type, addr, size, buf) < 0)

                HGOTO_ERROR(H5E_PAGEBUF, H5E_WRITEERROR, FAIL, "H5PB_write_meta() failed")
        }
    }

done:

    FUNC_LEAVE_NOAPI(ret_value)

} /* end H5PB_write() */

/**************************************************************************/
/***************************** STATIC FUNCTIONS ***************************/
/**************************************************************************/

/*-------------------------------------------------------------------------
 *
 * Function:	H5PB__allocate_page
 *
 * Purpose:	Allocate an instance of H5PB_entry_t and its associated
 *              buffer.  The supplied size must be greater than or
 *              equal to page_buf->page_size, and equal to that value if
 *              page_buf->vfd_swmr_writer is FALSE.
 *
 *              The associated buffer is zeroed if clean_image is TRUE.
 *
 * Return:	Pointer to the newly allocated instance of H5PB_entry_t
 *              on success, and NULL on failure.
 *
 * Programmer:	John Mainzer -- 10/12/18
 *
 * Changes:     None.
 *
 *-------------------------------------------------------------------------
 */
static H5PB_entry_t *
H5PB__allocate_page(H5PB_t *page_buf, size_t size, hbool_t clean_image)
{
    H5PB_entry_t *entry_ptr = NULL;
    void *        image_ptr = NULL;
    H5PB_entry_t *ret_value = NULL; /* Return value */

    FUNC_ENTER_NOAPI(NULL)

    /* sanity checks */
    HDassert(page_buf);
    HDassert(page_buf->magic == H5PB__H5PB_T_MAGIC);
    HDassert(size >= page_buf->page_size);
    HDassert((size == page_buf->page_size) || (page_buf->vfd_swmr_writer));

    /* allocate the entry and its associated image buffer */
    if (NULL == (entry_ptr = H5FL_MALLOC(H5PB_entry_t)))

        HGOTO_ERROR(H5E_PAGEBUF, H5E_NOSPACE, NULL, "memory allocation for H5PB_entry_t failed")

    if (clean_image) {

        image_ptr = H5MM_calloc(size);
    }
    else {

        image_ptr = H5MM_malloc(size);
    }

    if (NULL == image_ptr)

        HGOTO_ERROR(H5E_PAGEBUF, H5E_NOSPACE, NULL, "memory allocation for page image failed")

    /* initialize the new page buffer entry */
    entry_ptr->magic       = H5PB__H5PB_ENTRY_T_MAGIC;
    entry_ptr->page_buf    = page_buf;
    entry_ptr->addr        = HADDR_UNDEF;
    entry_ptr->page        = 0;
    entry_ptr->size        = size;
    entry_ptr->image_ptr   = image_ptr;
    entry_ptr->mem_type    = H5FD_MEM_DEFAULT;
    entry_ptr->is_metadata = FALSE;
    entry_ptr->is_mpmde    = FALSE;
    entry_ptr->is_dirty    = FALSE;

    /* fields supporting the hash table */
    entry_ptr->ht_prev = NULL;
    entry_ptr->ht_next = NULL;
    entry_ptr->il_prev = NULL;
    entry_ptr->il_next = NULL;

    /* fields supporting replacement policise */
    entry_ptr->next = NULL;
    entry_ptr->prev = NULL;

    /* fields supporting VFD SWMR */
    entry_ptr->is_mpmde           = FALSE;
    entry_ptr->loaded             = FALSE;
    entry_ptr->modified_this_tick = FALSE;
    entry_ptr->delay_write_until  = 0;
    entry_ptr->tl_next            = NULL;
    entry_ptr->tl_prev            = NULL;

    ret_value = entry_ptr;

done:

    if (NULL == ret_value) {

        if (entry_ptr) {

            entry_ptr->magic = 0;
            entry_ptr        = H5FL_FREE(H5PB_entry_t, entry_ptr);
        }

        if (image_ptr) {

            image_ptr = H5MM_xfree(image_ptr);
        }
    } /* end if */

    FUNC_LEAVE_NOAPI(ret_value)

} /* H5PB__allocate_page() */

/*-------------------------------------------------------------------------
 *
 * Function:	H5PB__create_new_page
 *
 * Purpose:	Create a new page and insert it in the page buffer with
 *              the specified address and type.  If entry_ptr_ptr is not
 *              NULL, return a pointer to the new entry in *entry_ptr_ptr.
 *
 *              Throw an error if a page already exists at the specified
 *              address.
 *
 * Return:	Non-negative on success/Negative on failure
 *
 * Programmer:	John Mainzer -- 10/12/18
 *
 * Changes:     None.
 *
 *-------------------------------------------------------------------------
 */
herr_t
H5PB__create_new_page(H5PB_t *page_buf, haddr_t addr, size_t size, H5FD_mem_t type, hbool_t clean_image,
                      H5PB_entry_t **entry_ptr_ptr)
{
    hbool_t       inserted_in_index = FALSE;
    hbool_t       inserted_in_lru   = FALSE;
    uint64_t      page;
    H5PB_entry_t *entry_ptr = NULL;
    herr_t        ret_value = SUCCEED; /* Return value */

    FUNC_ENTER_NOAPI(FAIL)

    /* Sanity checks */
    HDassert(page_buf->magic == H5PB__H5PB_T_MAGIC);

    page = (uint64_t)addr / (uint64_t)(page_buf->page_size);

    HDassert((uint64_t)(addr) == (page * (uint64_t)(page_buf->page_size)));

    HDassert(size >= page_buf->page_size);
    HDassert((size == page_buf->page_size) || ((page_buf->vfd_swmr_writer) && (type != H5FD_MEM_DRAW)));
    HDassert((NULL == entry_ptr_ptr) || (NULL == *entry_ptr_ptr));

    H5PB__SEARCH_INDEX(page_buf, page, entry_ptr, FAIL);

    if (entry_ptr != NULL) {

        HGOTO_ERROR(H5E_PAGEBUF, H5E_SYSTEM, FAIL,
                    "page buffer already contains a page at the specified address")
    }

    entry_ptr = H5PB__allocate_page(page_buf, size, clean_image);

    if (NULL == entry_ptr)
        HGOTO_ERROR(H5E_PAGEBUF, H5E_NOSPACE, FAIL, "Can't allocate new page buffer entry")

    /* perform additional initialization */
    HDassert(entry_ptr->magic == H5PB__H5PB_ENTRY_T_MAGIC);
    HDassert(entry_ptr->page_buf == page_buf);
    entry_ptr->addr = addr;
    entry_ptr->page = page;
    HDassert(entry_ptr->size == size);
    HDassert(entry_ptr->image_ptr);
    entry_ptr->mem_type    = type;
    entry_ptr->is_metadata = (type != H5FD_MEM_DRAW);
    entry_ptr->is_mpmde    = ((entry_ptr->is_metadata) && (size > page_buf->page_size));
    entry_ptr->is_dirty    = FALSE;

    /* insert in the hash table */
    H5PB__INSERT_IN_INDEX(page_buf, entry_ptr, FAIL)
    inserted_in_index = TRUE;

    /* insert at the head of the LRU if it isn't a multi-page metadata entry */
    if (!entry_ptr->is_mpmde) {

        H5PB__UPDATE_RP_FOR_INSERTION(page_buf, entry_ptr, FAIL)
        inserted_in_lru = TRUE;
    }

    /* updates stats */
    H5PB__UPDATE_STATS_FOR_INSERTION(page_buf, entry_ptr);

    if (entry_ptr_ptr) {

        *entry_ptr_ptr = entry_ptr;
    }

done:

    if (ret_value < 0) {

        if (entry_ptr) {

            if (inserted_in_lru) {

                H5PB__UPDATE_RP_FOR_EVICTION(page_buf, entry_ptr, FAIL);
            }

            if (inserted_in_index) {

                H5PB__DELETE_FROM_INDEX(page_buf, entry_ptr, FAIL)
            }

            H5PB__deallocate_page(entry_ptr);
            entry_ptr = NULL;
        }
    }

    FUNC_LEAVE_NOAPI(ret_value)

} /* H5PB_add_new_page */

/*-------------------------------------------------------------------------
 *
 * Function:	H5PB__deallocate_page
 *
 * Purpose:	Free the supplied instance of H5PB_entry_t and its
 *              associated buffer.  The entry must be clean and removed
 *              from the page buffer before this function is called.
 *
 * Return:	void
 *
 * Programmer:	John Mainzer -- 10/12/18
 *
 * Changes:     None.
 *
 *-------------------------------------------------------------------------
 */
static void
H5PB__deallocate_page(H5PB_entry_t *entry_ptr)
{
    FUNC_ENTER_NOAPI_NOINIT_NOERR

    /* sanity checks */
    HDassert(entry_ptr);
    HDassert(entry_ptr->magic == H5PB__H5PB_ENTRY_T_MAGIC);
    HDassert(entry_ptr->size > 0);
    HDassert(entry_ptr->image_ptr);
    HDassert(!(entry_ptr->is_dirty));
    HDassert(entry_ptr->ht_next == NULL);
    HDassert(entry_ptr->ht_prev == NULL);
    HDassert(entry_ptr->il_next == NULL);
    HDassert(entry_ptr->il_prev == NULL);
    HDassert(entry_ptr->next == NULL);
    HDassert(entry_ptr->prev == NULL);
    HDassert(entry_ptr->tl_next == NULL);
    HDassert(entry_ptr->tl_prev == NULL);

    entry_ptr->magic     = 0;
    entry_ptr->image_ptr = H5MM_xfree(entry_ptr->image_ptr);
    entry_ptr            = H5FL_FREE(H5PB_entry_t, entry_ptr);

    FUNC_LEAVE_NOAPI_VOID

} /* H5PB__deallocate_page() */

/*-------------------------------------------------------------------------
 *
 * Function:	H5PB__evict_entry
 *
 * Purpose:	Evict the target entry from the from the page buffer, and
 *              de-allocate its associated image and instance of
 *              H5PB_entry_t.
 *
 *              In general, entries must be clean before they can be
 *              evicted, and the minimum metadata and raw data limits
 *              must be respected.  Attempts to evict an entry that
 *              that do not respect these constraints will generate
 *              and error unless the force parameter is TRUE, in which
 *              case, these constraints are ignored.
 *
 *              If `only_mark` is true, then the page-table entry's
 *              corresponding shadow-index entry is not removed.  Instead,
 *              it is marked as garbage.  This is a stop-gap fix for a
 *              performance problem in H5PB_dest(): deleting all of the
 *              index entries took time quadratic in their number.
 *
 *              In the context of VFD SWMR, there is also the requirement
 *              that entries to be evicted not be on the tick list, and
 *              also not reside on the delayed write list.  In the rare
 *              case in which such a page is discarded by the free space
 *              manager, it must be removed from the tick list and/or the
 *              delayed write list before being evicted by this function.
 *
 * Return:	Non-negative on success/Negative on failure
 *
 * Programmer:	John Mainzer -- 10/14/18
 *
 * Changes:     None.
 *
 *-------------------------------------------------------------------------
 */
static herr_t
H5PB__evict_entry(H5F_shared_t *shared, H5PB_entry_t *entry_ptr, hbool_t force, hbool_t only_mark)
{
    H5PB_t *page_buf  = shared->page_buf;
    herr_t  ret_value = SUCCEED; /* Return value */

    FUNC_ENTER_NOAPI(FAIL)

    /* sanity checks */
    HDassert(page_buf);
    HDassert(page_buf->magic == H5PB__H5PB_T_MAGIC);
    HDassert(entry_ptr);
    HDassert(entry_ptr->magic == H5PB__H5PB_ENTRY_T_MAGIC);
    HDassert(entry_ptr->size > 0);
    HDassert(entry_ptr->image_ptr);
    /* entries on either the tick list or the delayed write
     * list may not be evicted -- verify this.
     */
    HDassert(!(entry_ptr->modified_this_tick));
    HDassert(entry_ptr->delay_write_until == 0);

    if ((!force) && (entry_ptr->is_dirty))

        HGOTO_ERROR(H5E_PAGEBUF, H5E_SYSTEM, FAIL, "Attempt to evict a dirty entry");

    if (!force) {

        /* it is OK to evict an metadata page if page_buf->curr_md_pages ==
         * page_buf->min_md_pages - 1 if we are about to replace it with another
         * metadata page.
         *
         * Similarly, it is OK to evict an raw data page if
         * page_buf->curr_rd_pages == page_buf->min_rd_pages - 1 if we are
         * about to replace it with another raw data page.
         *
         * Assume sanity checks have been made before this call, and
         * allow the above without testing the intended replacement.
         */
        if ((entry_ptr->is_metadata) && (page_buf->curr_md_pages < page_buf->min_md_pages)) {

            HGOTO_ERROR(H5E_PAGEBUF, H5E_SYSTEM, FAIL, "Attempt to violate min_md_pages");
        }
        else if ((!entry_ptr->is_metadata) && (page_buf->curr_rd_pages < page_buf->min_rd_pages)) {

            HGOTO_ERROR(H5E_PAGEBUF, H5E_SYSTEM, FAIL, "Attempt to violate min_rd_pages");
        }
    }
    else if ((entry_ptr->is_dirty) && (H5PB__mark_entry_clean(page_buf, entry_ptr) < 0)) {

        HGOTO_ERROR(H5E_PAGEBUF, H5E_SYSTEM, FAIL, "mark entry clean failed")
    }

    /* if the entry is in the replacement policy, remove it */
    if (!(entry_ptr->is_mpmde)) {

        H5PB__UPDATE_RP_FOR_EVICTION(page_buf, entry_ptr, FAIL)
    }

    /* remove the entry from the hash table */
    H5PB__DELETE_FROM_INDEX(page_buf, entry_ptr, FAIL)

    /* We need to remove the entry from the shadow file index in
     * the VFD SWMR case.
     *
     * If a multipage metadata entry is deallocated, and a new, single-page
     * metadata entry is allocated at the same base address, then
     * the old shadow index entry will still tell the size of the previous
     * image, which is greater than a page, and a shadow-file flush will
     * access bytes past the end of the entry's image.
     *
     * When we add code to allow entries
     * to age out of the metadata file index, that may provide
     * code that we can reuse to perform this invalidation.
     *
     * It's also possible (I think) for the index-entry size to be set
     * to one page, and then for a multipage entry to appear later at that
     * same index entry. The recorded size will still say the same, but
     * the image will be bigger.  So the shadow file will never see the
     * entire image written, just the first page of the image.
     */
    if (shared->vfd_swmr_writer && shadow_idx_entry_remove(shared, entry_ptr->page, only_mark) == -1) {
        HGOTO_ERROR(H5E_PAGEBUF, H5E_SYSTEM, FAIL, "failed to remove shadow index entry")
    }

    /* update stats for eviction */
    H5PB__UPDATE_STATS_FOR_EVICTION(page_buf, entry_ptr)

    /* deallocate the page */
    H5PB__deallocate_page(entry_ptr);

done:

    FUNC_LEAVE_NOAPI(ret_value)

} /* H5PB__evict_entry() */

/*-------------------------------------------------------------------------
 *
 * Function:	H5PB__flush_entry
 *
 * Purpose:	Flush the target entry to file.
 *
 *              Under normal circumstances, the entry will be in the
 *              replacement policy.  In this, also update the replacement
 *              policy for flush.
 *
 *              If page_buf->vfd_swmr_writer, it is possible that the target
 *              is a multi-page metadata entry.  In this case, the entry
 *              is not in the replacement policy, and thus the policy
 *              should not be updated.
 *
 * Return:	Non-negative on success/Negative on failure
 *
 * Programmer:	John Mainzer -- 10/14/18
 *
 * Changes:     None.
 *
 *-------------------------------------------------------------------------
 */
static herr_t
H5PB__flush_entry(H5F_shared_t *shared, H5PB_t *page_buf, H5PB_entry_t *const entry_ptr)
{
    haddr_t eoa;                 /* Current EOA for the file */
    herr_t  ret_value = SUCCEED; /* Return value */

    FUNC_ENTER_NOAPI(FAIL)

    /* sanity checks */
    HDassert(shared);
    HDassert(shared->lf);
    HDassert(page_buf);
    HDassert(page_buf->magic == H5PB__H5PB_T_MAGIC);
    HDassert(entry_ptr);
    HDassert(entry_ptr->magic == H5PB__H5PB_ENTRY_T_MAGIC);
    HDassert(entry_ptr->size > 0);
    HDassert(entry_ptr->size >= page_buf->page_size);
    HDassert((entry_ptr->size == page_buf->page_size) || (entry_ptr->is_mpmde));
    HDassert(entry_ptr->image_ptr);
    HDassert(entry_ptr->is_dirty);
    HDassert((page_buf->vfd_swmr_writer) || (!(entry_ptr->is_mpmde)));
    HDassert(0 == entry_ptr->delay_write_until);

    /* Retrieve the 'eoa' for the file */
    if (HADDR_UNDEF == (eoa = H5FD_get_eoa(shared->lf, entry_ptr->mem_type)))

        HGOTO_ERROR(H5E_PAGEBUF, H5E_CANTGET, FAIL, "driver get_eoa request failed")

    /* TODO: update the free space manager to inform the page buffer when
     *       space is de-allocated so that the following assertions will be
     *       true in all cases.
     */

    /* Verify that the base addresss of the page is within the EOA.  If it
     * isn't, the associated page has been discarded and should have been
     * removed from the page buffer.  This is a bug in the HDF5 library, so
     * an assertion is adequate here.
     */
    HDassert(eoa > entry_ptr->addr);

    /* Space at the end of the file should be allocate in increments of
     * pages.  Thus the entire page should be within the EOA.  Again,
     * an assertion is adequate here.
     */
    HDassert(eoa >= entry_ptr->addr + entry_ptr->size);

    /* flush the entry */
    if (H5FD_write(shared->lf, entry_ptr->mem_type, entry_ptr->addr, entry_ptr->size, entry_ptr->image_ptr) <
        0)

        HGOTO_ERROR(H5E_PAGEBUF, H5E_WRITEERROR, FAIL, "file write failed")

    /* mark the entry clean */
    if (H5PB__mark_entry_clean(page_buf, entry_ptr) < 0)

        HGOTO_ERROR(H5E_PAGEBUF, H5E_SYSTEM, FAIL, "mark entry clean failed")

    /* if the entry is on the LRU, update the replacement policy */
    if (!entry_ptr->is_mpmde) {
        HDassert(entry_ptr->delay_write_until == 0);

        H5PB__UPDATE_RP_FOR_FLUSH(page_buf, entry_ptr, FAIL)
    }

    /* update stats for flush */
    H5PB__UPDATE_STATS_FOR_FLUSH(page_buf, entry_ptr)

done:

    FUNC_LEAVE_NOAPI(ret_value)

} /* H5PB__flush_entry() */

/*-------------------------------------------------------------------------
 *
 * Function:	H5PB__load_page
 *
 * Purpose:	Load the page with the specified base address and insert
 *              it into the page buffer.  If necessary and possible, make
 *              space for the new page first.
 *
 *              Note that the size of the page is always page_buf->page_size,
 *              even in the VFD SWMR case, as in this context, multi-page
 *              metadata entries are always written in full, and they
 *              may only enter the page buffer as the result of a write.
 *
 *              In the context of VFD SWMR, when a page is loaded from
 *              file, it is possible that the VFD SWMR writer must delay
 *              writes to the page to avoid the possibility of message from
 *              the future bugs on the VFD SWMR reader.  For this reason,
 *              make note of the fact that the entry has been loaded from
 *              from file, so that the necessary checks can be made when
 *              writing to the page.
 *
 * Return:	SUCCEED if no errors are encountered, and
 *              FAIL otherwise.
 *
 * Programmer:	John Mainzer -- 10/18/18
 *
 * Changes:     None.
 *
 *-------------------------------------------------------------------------
 */
static herr_t
H5PB__load_page(H5F_shared_t *shared, H5PB_t *page_buf, haddr_t addr, H5FD_mem_t type,
                H5PB_entry_t **entry_ptr_ptr)
{
    hbool_t       skip_read = FALSE;
    haddr_t       eof       = HADDR_UNDEF;
    H5PB_entry_t *entry_ptr = NULL;
    void *        image_ptr = NULL;
    herr_t        ret_value = SUCCEED; /* Return value */

    FUNC_ENTER_NOAPI(FAIL)

    /* sanity checks */
    HDassert(shared);
    HDassert(shared->lf);
    HDassert(page_buf);
    HDassert(page_buf->magic == H5PB__H5PB_T_MAGIC);
    HDassert((entry_ptr_ptr == NULL) || (*entry_ptr_ptr == NULL));

#if 0  /* JRM */
    haddr_t eoa;
    /* Retrieve the 'eoa' for the file */
    if ( HADDR_UNDEF == (eoa = H5FD_get_eoa(shared->lf, type)))

        HGOTO_ERROR(H5E_PAGEBUF, H5E_CANTGET, FAIL, \
                    "driver get_eoa request failed")
    if ( addr + ((haddr_t)(page_buf->page_size)) > eoa )

        HGOTO_ERROR(H5E_PAGEBUF, H5E_SYSTEM, FAIL, \
                    "Attempt to load page that extends past EOA")
#endif /* JRM */
    if (HADDR_UNDEF == (eof = H5FD_get_eof(shared->lf, H5FD_MEM_DEFAULT)))

        HGOTO_ERROR(H5E_PAGEBUF, H5E_CANTGET, FAIL, "driver get_eof request failed")

#if 0
    /* It is possible that this page been allocated but not
     * written.  Skip the read if addr > EOF.  In this case, tell 
     * H5PB__create_new_page() to zero the page image.
     *
     * Don't set "skip_read = (addr >= eof);" when accumulator is used.
     */
    skip_read = (addr >= eof);
#endif

    /* make space in the page buffer if necessary */
    if ((page_buf->curr_pages >= page_buf->max_pages) && (H5PB__make_space(shared, page_buf, type) < 0))

        HGOTO_ERROR(H5E_PAGEBUF, H5E_SYSTEM, FAIL, "H5PB__make_space() reports an error")

    /* Create a new page buffer page and insert it into the page buffer */
    if (H5PB__create_new_page(page_buf, addr, (size_t)(page_buf->page_size), type, skip_read, &entry_ptr) < 0)

        HGOTO_ERROR(H5E_PAGEBUF, H5E_SYSTEM, FAIL, "can't create new page buffer page")

    HDassert(entry_ptr);
    HDassert(entry_ptr->magic == H5PB__H5PB_ENTRY_T_MAGIC);
    HDassert(entry_ptr->addr == addr);

    image_ptr = entry_ptr->image_ptr;

    HDassert(image_ptr);

    /* Read the contents of the page from file, and store it in the
     * image buffer associated with the new entry.
     */
    if ((!skip_read) && (H5FD_read(shared->lf, type, addr, entry_ptr->size, image_ptr) < 0))

        HGOTO_ERROR(H5E_PAGEBUF, H5E_READERROR, FAIL, "driver read request failed")

    /* If in fact the page was read from file, make note of this fact
     * for purposes of VFD SWMR delayed writes in the VFD SWMR writer.
     */
    entry_ptr->loaded = !skip_read;

    H5PB__UPDATE_STATS_FOR_LOAD(page_buf, entry_ptr)

    if (entry_ptr_ptr) {

        *entry_ptr_ptr = entry_ptr;
    }

done:

    /* add cleanup in case of failure */

    FUNC_LEAVE_NOAPI(ret_value)

} /* H5PB__load_page() */

/*-------------------------------------------------------------------------
 *
 * Function:	H5PB__make_space
 *
 * Purpose:	Evict one or more pages from the page buffer so as to
 *              reduce the size of the page buffer to page_buf->max_pages - 1.
 *              if possible.
 *
 *              Note that the function must not be called under
 *              nonsensical conditions -- thus if either
 *
 *                  1) the inserted type is metadata and min_rd_pages ==
 *                     max_pages, or
 *
 *                  2) the inserted type is raw data and min_md_pages ==
 *                     max_pages
 *
 *              holds, the function has been called in error, and an
 *              assertion failure is appropriate.
 *
 *              If the page buffer is below its maximum size, we are
 *              done, and the function simply returns.
 *
 *              Otherwise, scan upwards from the bottom of the LRU list,
 *              examining each entry in turn.
 *
 *              If the entry is dirty, flush it, move it to the top of the
 *              LRU, and continue with the scan.  Note in the VFD SWMR case,
 *              we do not have to concern ourselves with delayed writes in
 *              this context, as all entries which are subject to delayed
 *              writes must reside on the delayed write list, not the LRU list.
 *
 *              If the entry is:
 *
 *                 1) clean
 *
 *                 2) either:
 *
 *                    a) the target entry is metadata and
 *                       curr_md_pages > min_md_pages.
 *
 *                    b) the target entry is raw data and
 *                       curr_rd_pages > min_rd_pages.
 *
 *                    c) the target entry is metadata, the inserted_type
 *                       is metadata, and curr_md_pages == min_md_pages.
 *
 *                    d) the target entry is raw data, the inserted_type
 *                       is raw data, and curr_rd_pages == min_rd_pages.
 *
 *                 3) The entry is not on the tick list (which can only
 *                    happen if page_buf->vfd_swmr_writer is TRUE).
 *
 *              evict the entry and test to see if page_buf->curr_pages <
 *              page_buf->max_pages.  If it is, return.  Otherwise, continue
 *              the scan until either the above condidtion is fulfilled,
 *              or the head of the LRU is reach.
 *
 *              Under normal circumstances, it should always be possible
 *              to reduce the size of the page buffer below page_buf->max_pages.
 *              However, due to prohibition on evicting entries on the
 *              tick list, and either flushing or evicting entries on the
 *              delayed write list, this will not in general be the case
 *              if page_buf->vfd_swmr_writer is TRUE.  In this case, the
 *              page buffer may exceed its maximum size by an arbitrary
 *              amount.
 *
 *              If this situation occurs with any regularity, we will
 *              need a mechanism to avoid attempts to make space when
 *              it is not possible to do so.
 *
 * Return:	SUCCEED if no errors are encountered, and
 *              FAIL otherwise.
 *
 * Programmer:	John Mainzer -- 10/14/18
 *
 * Changes:     None.
 *
 *-------------------------------------------------------------------------
 */
static herr_t
H5PB__make_space(H5F_shared_t *shared, H5PB_t *page_buf, H5FD_mem_t inserted_type)
{
    hbool_t       inserting_md;
    H5PB_entry_t *search_ptr;
    H5PB_entry_t *flush_ptr;
    H5PB_entry_t *evict_ptr;
    herr_t        ret_value = SUCCEED; /* Return value */

    FUNC_ENTER_NOAPI(FAIL)

    /* sanity checks */
    HDassert(page_buf);
    HDassert(page_buf->magic == H5PB__H5PB_T_MAGIC);
    HDassert(page_buf->min_md_pages + page_buf->min_rd_pages <= page_buf->max_pages);

    inserting_md = (H5FD_MEM_DRAW != inserted_type);

    if ((inserting_md) && (page_buf->min_rd_pages == page_buf->max_pages))

        HGOTO_ERROR(H5E_PAGEBUF, H5E_SYSTEM, FAIL,
                    "can't make space for metadata -- pb config for raw data only")

    if ((!inserting_md) && (page_buf->min_md_pages == page_buf->max_pages))

        HGOTO_ERROR(H5E_PAGEBUF, H5E_SYSTEM, FAIL,
                    "can't make space for raw data -- pb config for metadata only")

    search_ptr = page_buf->LRU_tail_ptr;

    while ((search_ptr) && (page_buf->curr_pages >= page_buf->max_pages)) {

        HDassert(search_ptr->magic == H5PB__H5PB_ENTRY_T_MAGIC);

        if (search_ptr->modified_this_tick) { /* entry is on tick list */

            search_ptr = search_ptr->prev;
            H5PB__UPDATE_STATS_FOR_LRU_TL_SKIP(page_buf);
        }
        else if ((inserting_md) && (!(search_ptr->is_metadata)) &&
                 (page_buf->curr_rd_pages <= page_buf->min_rd_pages)) {

            search_ptr = search_ptr->prev;
            H5PB__UPDATE_STATS_FOR_LRU_RD_SKIP(page_buf);
        }
        else if ((!inserting_md) && (search_ptr->is_metadata) &&
                 (page_buf->curr_md_pages <= page_buf->min_md_pages)) {

            search_ptr = search_ptr->prev;
            H5PB__UPDATE_STATS_FOR_LRU_MD_SKIP(page_buf);
        }
        else if (search_ptr->is_dirty) {

            /* One can make the argument that we should test for dirty
             * entries first, instead of skipping potentially dirty
             * entries in the above clauses.  However, I suspect that
             * this would result in excessive flushes.  Lets try it
             * this way for now.
             */

            flush_ptr = search_ptr;

            /* if the *search_ptr has a predecessor in the LRU,
             * set set search_ptr equal to search_ptr->prev.  Otherwise,
             * leave search_ptr unchanged, so that it can be examined
             * on the next pass through the while loop after it has been
             * flushed.
             */
            if (search_ptr->prev) {

                search_ptr = search_ptr->prev;
            }

            if (H5PB__flush_entry(shared, page_buf, flush_ptr) < 0)

                HGOTO_ERROR(H5E_PAGEBUF, H5E_WRITEERROR, FAIL, "Can't flush entry")
        }
        else { /* evict the entry */

            evict_ptr  = search_ptr;
            search_ptr = search_ptr->prev;
            if (H5PB__evict_entry(shared, evict_ptr, FALSE, FALSE) < 0)

                HGOTO_ERROR(H5E_PAGEBUF, H5E_WRITEERROR, FAIL, "Can't evict entry")
        }
    }

    HDassert((search_ptr == NULL) || (page_buf->curr_pages < page_buf->max_pages));

done:

    FUNC_LEAVE_NOAPI(ret_value)

} /* H5PB__make_space() */

/*-------------------------------------------------------------------------
 *
 * Function:	H5PB__mark_entry_clean
 *
 * Purpose:	Mark the target entry clean
 *
 *              This function is typically used when an entry has been
 *              completely overwritten and is about to be evicted.  In
 *              this case, the entry must be marked clean to avoid
 *              sanity check failures on evictions.
 *
 *              While this function does update the index for the
 *              entry clean, it does not update the replacement policy.
 *              If this is desired, it must be done by the caller.
 *
 * Return:	Non-negative on success/Negative on failure
 *
 * Programmer:	John Mainzer -- 10/14/18
 *
 * Changes:     None.
 *
 *-------------------------------------------------------------------------
 */
static herr_t
H5PB__mark_entry_clean(H5PB_t *page_buf, H5PB_entry_t *entry_ptr)
{
    herr_t ret_value = SUCCEED; /* Return value */

    FUNC_ENTER_NOAPI(FAIL)

    /* sanity checks */
    HDassert(page_buf);
    HDassert(page_buf->magic == H5PB__H5PB_T_MAGIC);
    HDassert(entry_ptr);
    HDassert(entry_ptr->magic == H5PB__H5PB_ENTRY_T_MAGIC);
    HDassert(entry_ptr->size > 0);
    HDassert(entry_ptr->size >= page_buf->page_size);
    HDassert((entry_ptr->size == page_buf->page_size) || (entry_ptr->is_mpmde));
    HDassert(entry_ptr->image_ptr);
    HDassert((page_buf->vfd_swmr_writer) || (!(entry_ptr->is_mpmde)));

    /* mark the entry clean */
    entry_ptr->is_dirty = FALSE;

    /* update the index for the entry clean */
    H5PB__UPDATE_INDEX_FOR_ENTRY_CLEAN(page_buf, entry_ptr)

    /* don't update the replacement policy -- this will be done by
     * the caller if desired.
     */

done:

    FUNC_LEAVE_NOAPI(ret_value)

} /* H5PB__mark_entry_clean() */

/*-------------------------------------------------------------------------
 *
 * Function:	H5PB__mark_entry_dirty
 *
 * Purpose:	Mark the target entry as dirty.
 *
 *              If page_buf->vfd_swmr_writer is FALSE, the entry will be
 *              in the replacement policy.  In this, we simply mark the
 *              entry as dirty, and update the replacement policy for an
 *              access.
 *
 *              If page_buf->vfd_swmr_writer, it is possible that we must
 *              delay writes to the target page or multi-page metadata
 *              entry to avoid message from the future bugs on the VFD
 *              SWMR readers.  In such cases we must set the
 *              delay_write_until field and insert the entry on the
 *              delayed write list instead of the replacement policy.
 *
 * Return:	Non-negative on success/Negative on failure
 *
 * Programmer:	John Mainzer -- 10/14/18
 *
 * Changes:     None.
 *
 *-------------------------------------------------------------------------
 */
static herr_t
H5PB__mark_entry_dirty(H5F_shared_t *shared, H5PB_t *page_buf, H5PB_entry_t *entry_ptr)
{
    herr_t ret_value = SUCCEED; /* Return value */

    FUNC_ENTER_NOAPI(FAIL)

    /* sanity checks */
    HDassert(page_buf);
    HDassert(page_buf->magic == H5PB__H5PB_T_MAGIC);
    HDassert(entry_ptr);
    HDassert(entry_ptr->magic == H5PB__H5PB_ENTRY_T_MAGIC);
    HDassert(entry_ptr->size > 0);
    HDassert(entry_ptr->size >= page_buf->page_size);
    HDassert((entry_ptr->size == page_buf->page_size) || (entry_ptr->is_mpmde));
    HDassert(entry_ptr->image_ptr);
    HDassert((page_buf->vfd_swmr_writer) || (!(entry_ptr->is_mpmde)));

    /* mark the entry dirty if necessary */
    if (!(entry_ptr->is_dirty)) {

        entry_ptr->is_dirty = TRUE;

        H5PB__UPDATE_INDEX_FOR_ENTRY_DIRTY(page_buf, entry_ptr)

        /* since the entry was clean, there can be no pending delayed write */
        HDassert(entry_ptr->delay_write_until == 0);

        if ((page_buf->vfd_swmr_writer) && (entry_ptr->loaded) && (entry_ptr->mem_type != H5FD_MEM_DRAW) &&
            (H5F_vfd_swmr_writer__delay_write(shared, entry_ptr->page, &(entry_ptr->delay_write_until)) < 0))

            HGOTO_ERROR(H5E_PAGEBUF, H5E_SYSTEM, FAIL, "get delayed write request failed")

        if (entry_ptr->delay_write_until > 0) {

            if (!(entry_ptr->is_mpmde)) {

                /* remove the entry from the replacement policy */

                H5PB__UPDATE_RP_FOR_REMOVE(page_buf, entry_ptr, FAIL)
            }

            H5PB__INSERT_IN_DWL(page_buf, entry_ptr, FAIL)
        }
        else if (!(entry_ptr->is_mpmde)) {

            H5PB__UPDATE_RP_FOR_ACCESS(page_buf, entry_ptr, FAIL)
        }
        else {

            /* the entry should be a multi-page metadata entry that
             * has been modified this tick.  Thus no action is required.
             */
            HDassert(entry_ptr->is_mpmde);
            HDassert(page_buf->vfd_swmr_writer);
        }
    }
    else if ((!(entry_ptr->is_mpmde)) && (entry_ptr->delay_write_until == 0)) {

        /* the entry is dirty and on the replacement policy -- just update
         * the replacement policy for an access
         */
        H5PB__UPDATE_RP_FOR_ACCESS(page_buf, entry_ptr, FAIL)
    }

done:

    FUNC_LEAVE_NOAPI(ret_value)

} /* H5PB__mark_entry_dirty() */

/*-------------------------------------------------------------------------
 *
 * Function:	H5PB__read_meta
 *
 * Purpose:	Satisfy a metadata read in cases 7, 8, 9, and 10)
 *              H5PB_read().  Specifically:
 *
 *              6) If the read is for metadata and not page aligned, clip
 *                 the read to the end of the current page if necessary.
 *                 Load the relevant page if necessary and satisfy the
 *                 read from the page buffer.  Note that it there is an
 *                 existing page, it must not be a multi-page metadata
 *                 entry.  It it is, flag an error.
 *
 *                 Recall that by the time we get to this function,
 *                 un-aligned page reads from the fixed and variable
 *                 length array structures that cross page boundaries
 *                 have already been split into two or three reads
 *                 that conform to the usual pattern of metadata reads.
 *
 *              7) If the read is for metadata, is page aligned, is larger
 *                 than one page, and there is no entry in the page buffer,
 *                 satisfy the read from the file
 *
 *              8) If the read is for metadata, is page aligned, is larger
 *                 than one page, and there is a regular entry at the target
 *                 page address, test to see if the read is speculative.
 *
 *                 If it is not, evict the page, and satisfy the read from
 *                 file.  Flag an error if the page was dirty.
 *
 *                 If it is, clip the read to one page, and satisfy the
 *                 read from the existing regular entry.
 *
 *              9) If the read is for metadata, is page aligned, is larger
 *                 than one page, and there is a multi-page metadata entry
 *                 at the target page address, test to see if
 *                 page_buf->vfd_swmr_write is TRUE.
 *
 *                 If it is, satisfy the read from the multi-page metadata
 *                 entry, clipping the read if necessary.
 *
 *                 if page_buf->vfd_swmr_write is FALSE, flag an error.
 *
 *             10) If the read is for metadata, is page aligned, is no
 *                 larger than a page, test to see if the page buffer
 *                 contains a page at the target address.
 *
 *                 If it doesn't, load the page and satisfy the read
 *                 from it.
 *
 *                 If it contains a regular page entry, satisfy the read
 *                 from it.
 *
 *                 If it contains a multipage metadata entry at the target
 *                 address, satisfy the read from the multi-page metadata
 *                 entry if page_buf->vfd_swmr_write is TRUE, and flag an
 *                 error otherwise.
 *
 *              The above case analysis may be a bit hard to read.  If so,
 *              the table shown below may help to clarify.  Here:
 *
 *                P/A       == page aligned
 *                size > PL == size > page length
 *                Spec      == speculative read
 *                A         == current address
 *
 *              In the entry exists column:
 *
 *                N         == no entry
 *                R         == regular (1 page) entry
 *                MPMDE     == multi-page metadata entry
 *
 *       | size | entry  | VFD  |         |
 *  P/A: | > PL | exists | SWMR |  Spec   | Comments:
 * ------+------+--------+------+---------+-------------------------------------
 *   N   |  X   | N || R |  X   |    X    | Clip read to page boundary if
 *       |      |        |      |         | necessary
 *       |      |        |      |         | Load entry if necessary
 *       |      |        |      |         | Satisfy read from entry (case 6)
 * ------+------+--------+------+---------+-------------------------------------
 *   N   |  X   | MPMDE  |  X   |    X    | Error (case 6)
 * ------+------+--------+------+---------+-------------------------------------
 *       |      |        |      |         |
 * ------+------+--------+------+---------+-------------------------------------
 *   Y   |  Y   |   N    |  X   |    X    | Satisfy read from file (case 7)
 * ------+------+--------+------+---------+-------------------------------------
 *   Y   |  Y   |   R    |  X   |    Y    | Clip read to page boundary
 *       |      |        |      |         | Satisfy read from entry  (case 8)
 * ------+------+--------+------+---------+-------------------------------------
 *   Y   |  Y   |   R    |  X   |    N    | Evict entry
 *       |      |        |      |         | (must be clean -- flag error if not)
 *       |      |        |      |         | Satisfy read from file (case 8)
 * ------+------+--------+------+---------+-------------------------------------
 *   Y   |  Y   | MPMDE  |  N   |    X    | Error (case 9)
 * ------+------+--------+------+---------+-------------------------------------
 *   Y   |  Y   | MPMDE  |  Y   |    X    | Clip read to MPE size if required.
 *       |      |        |      |         | Satify read from MPE (case 9)
 * ------+------+--------+------+---------+-------------------------------------
 *       |      |        |      |         |
 * ------+------+--------+------+---------+-------------------------------------
 *   Y   |  N   |   N    |  X   |    X    | Load entry
 *       |      |        |      |         | Satisfy read from entry (case 10)
 * ------+------+--------+------+---------+-------------------------------------
 *   Y   |  N   |   R    |  X   |    X    | Satisfy read from entry (case 10)
 * ------+------+--------+------+---------+-------------------------------------
 *   Y   |  N   | MPMDE  |  Y   |    X    | Satisfy read from entry (case 10)
 * ------+------+--------+------+---------+-------------------------------------
 *   Y   |  N   | MPMDE  |  N   |    X    | Error (case 10)
 * ------+------+--------+------+---------+-------------------------------------
 *
 *              Observe that the above cases imply that:
 *
 *              1) The page buffer is defined.
 *
 *              2) The page buffer has been configured to accept at least
 *                 one page of metadata.
 *
 *              3) This is a metadata read.
 *
 *              Note also that if the metadata read is of size
 *              no larger than page size, it may not cross page
 *              boundaries.
 *
 * Return:	Non-negative on success/Negative on failure
 *
 * Programmer:	John Mainzer -- 10/11/18
 *
 * Changes:     Updated to use the speculative read hint from the
 *              metadata cache, and remove the static variable
 *              containing the base address of the last read.
 *
 *                                             JRM -- 4/5/20
 *
 *-------------------------------------------------------------------------
 */
static herr_t
H5PB__read_meta(H5F_shared_t *shared, H5FD_mem_t type, haddr_t addr, size_t size, void *buf /*out*/)
{
    hbool_t       bypass      = FALSE; /* flag indicating PB bypassed */
    hbool_t       speculative = FALSE; /* speculative read hint from mdc */
    H5PB_t *      page_buf;            /* Page buffer for this file */
    H5PB_entry_t *entry_ptr;           /* Pointer to page buffer entry */
    H5FD_t *      file;                /* File driver pointer */
    uint64_t      page;                /* page offset of addr */
    haddr_t       page_addr;           /* page containing addr */
    size_t        offset;              /* offset of read in page */
    size_t        clipped_size;        /* possibley clipped size */
    herr_t        ret_value = SUCCEED; /* Return value */

    FUNC_ENTER_NOAPI(FAIL)

    /* Sanity checks */
    HDassert(shared);
    HDassert(shared->page_buf);

    page_buf = shared->page_buf;

    HDassert(page_buf->magic == H5PB__H5PB_T_MAGIC);
    HDassert(page_buf->min_rd_pages < page_buf->max_pages);
    HDassert(shared->lf);

    file = shared->lf;

    HDassert(H5FD_MEM_DRAW != type);
    HDassert(buf);

    /* Calculate the aligned address of the first page */
    page      = (addr / page_buf->page_size);
    page_addr = page * page_buf->page_size;

    if (page_addr != addr) { /* case 6 */

        /* If the read is for metadata and not page aligned, clip
         * the read to the end of the current page if necessary.
         * Load the relevant page if necessary and satisfy the
         * read from the page buffer.  Note that it there is an
         * existing page, it must not be a multi-page metadata
         * entry.  It it is, flag an error.
         */

        offset = addr - page_addr;

        if ((offset + size) <= page_buf->page_size) {

            clipped_size = size;
        }
        else {

            clipped_size = size - ((offset + size) - page_buf->page_size);
        }

        HDassert(clipped_size > 0);
        HDassert(clipped_size <= size);
        HDassert((offset + clipped_size) <= page_buf->page_size);

        /* get the containing page */
        H5PB__SEARCH_INDEX(page_buf, page, entry_ptr, FAIL)

        /* update hit rate stats */
        H5PB__UPDATE_PB_HIT_RATE_STATS(page_buf, ((entry_ptr) != NULL), TRUE, FALSE)

        if ((NULL == entry_ptr) && (H5PB__load_page(shared, page_buf, page_addr, type, &entry_ptr) < 0))

            HGOTO_ERROR(H5E_PAGEBUF, H5E_READERROR, FAIL, "page buffer page load request failed (1)")

        HDassert(entry_ptr);
        HDassert(entry_ptr->magic == H5PB__H5PB_ENTRY_T_MAGIC);
        HDassert(entry_ptr->addr == page_addr);
        HDassert(entry_ptr->is_metadata);
        HDassert(!(entry_ptr->is_mpmde));

        /* copy data from the page into read buffer */
        HDmemcpy((uint8_t *)buf, (uint8_t *)(entry_ptr->image_ptr) + offset, clipped_size);

        /* if the entry is on the LRU, update the replacement policy */
        if ((!(entry_ptr->is_mpmde)) && (entry_ptr->delay_write_until == 0)) {

            H5PB__UPDATE_RP_FOR_ACCESS(page_buf, entry_ptr, FAIL)
        }
    }
    else {

        HDassert(page_addr == addr);

        if (size > page_buf->page_size) {

            /* search the page buffer for an entry at page */
            H5PB__SEARCH_INDEX(page_buf, page, entry_ptr, FAIL)

            if (entry_ptr == NULL) { /* case 7 */

                /* update hit rate stats */
                H5PB__UPDATE_PB_HIT_RATE_STATS(page_buf, FALSE, TRUE, size > page_buf->page_size)

                /* If the read is for metadata, is page aligned, is larger
                 * than page size, and there is no entry in the page buffer,
                 * satisfy the read from the file
                 */
                if (H5FD_read(file, type, addr, size, buf) < 0)

                    HGOTO_ERROR(H5E_PAGEBUF, H5E_READERROR, FAIL, "driver read request failed (1)")

                bypass = TRUE;

                H5PB__UPDATE_STATS_FOR_BYPASS(page_buf, type, size);
            }
            else {

                HDassert(entry_ptr);
                HDassert(entry_ptr->magic == H5PB__H5PB_ENTRY_T_MAGIC);
                HDassert(entry_ptr->is_metadata);

                if (!(entry_ptr->is_mpmde)) { /* case 8 */

                    /* If the read is for metadata, is page aligned, is larger
                     * than one page, and there is a regular entry at the target
                     * page address, test to see if the read is speculative.
                     *
                     * If it is not, evict the page, and satisfy the read from
                     * file.  Flag an error if the page was dirty.
                     *
                     * If it is, clip the read to one page, and satisfy
                     * the read from the existing regular entry.
                     */

                    HDassert(entry_ptr->size == page_buf->page_size);

                    speculative = H5C_get_curr_read_speculative(shared->cache);

                    if (!speculative) {

                        /* since this is likely a second try, don't update
                         * hit rate stats.
                         */

                        HDassert(!(entry_ptr->is_dirty));

                        if (H5PB__evict_entry(shared, entry_ptr, TRUE, FALSE) < 0)

                            HGOTO_ERROR(H5E_PAGEBUF, H5E_SYSTEM, FAIL, "forced eviction failed (1)")
                        if (H5FD_read(file, type, addr, size, buf) < 0)

                            HGOTO_ERROR(H5E_PAGEBUF, H5E_READERROR, FAIL, "driver read request failed (2)")

                        bypass = TRUE;
                        H5PB__UPDATE_STATS_FOR_BYPASS(page_buf, type, size);
                    }
                    else {

                        HDassert(entry_ptr->image_ptr);

                        /* copy data from the page into read buffer */
                        HDmemcpy((uint8_t *)buf, (uint8_t *)(entry_ptr->image_ptr), entry_ptr->size);

                        /* if the entry is on the LRU, update the replacement
                         * policy
                         */
                        if ((!(entry_ptr->is_mpmde)) && (entry_ptr->delay_write_until == 0)) {

                            H5PB__UPDATE_RP_FOR_ACCESS(page_buf, entry_ptr, FAIL)
                        }

                        /* update hit rate stats */
                        H5PB__UPDATE_PB_HIT_RATE_STATS(page_buf, TRUE, TRUE, FALSE)
                    }
                }
                else { /* case 9 */

                    /* If the read is for metadata, is page aligned, is larger
                     * than one page, and there is a multi-page metadata entry
                     * at the target page address, test to see if
                     * page_buf->vfd_swmr_write is TRUE.
                     *
                     * If it is, satisfy the read from the multi-page metadata
                     * entry, clipping the read if necessary.
                     *
                     * if page_buf->vfd_swmr_write is FALSE, flag an error.
                     */
                    HDassert(entry_ptr->is_mpmde);
                    HDassert(page_buf->vfd_swmr_writer);

                    if (size > entry_ptr->size) {

                        clipped_size = entry_ptr->size;
                    }
                    else {

                        clipped_size = size;
                    }

                    /* copy data from the page into read buffer */
                    HDmemcpy((uint8_t *)buf, (uint8_t *)(entry_ptr->image_ptr), clipped_size);

                    /* if the entry is on the LRU, update the replacement
                     * policy
                     */
                    if ((!(entry_ptr->is_mpmde)) && (entry_ptr->delay_write_until == 0)) {

                        H5PB__UPDATE_RP_FOR_ACCESS(page_buf, entry_ptr, FAIL)
                    }

                    /* update hit rate stats */
                    H5PB__UPDATE_PB_HIT_RATE_STATS(page_buf, TRUE, TRUE, TRUE)
                }
            }
        }
        else { /* case 10 */

            /* If the read is for metadata, is page aligned, is no
             * larger than a page, test to see if the page buffer
             * contains a page at the target address.
             *
             * If it doesn't, load the page and satisfy the read
             * from it.
             *
             * If it contains a regular page entry, satisfy the read
             * from it.
             *
             * If it contains a multipage metadata entry at the target
             * address, satisfy the read from the multi-page metadata
             * entry if page_buf->vfd_swmr_write is TRUE, and flag an
             * error otherwise.
             */
            HDassert(size <= page_buf->page_size);

            /* get the containing page */
            H5PB__SEARCH_INDEX(page_buf, page, entry_ptr, FAIL)

            /* update hit rate stats */
            H5PB__UPDATE_PB_HIT_RATE_STATS(page_buf, (entry_ptr != NULL), TRUE, FALSE)

            if ((NULL == entry_ptr) && (H5PB__load_page(shared, page_buf, page_addr, type, &entry_ptr) < 0))

                HGOTO_ERROR(H5E_PAGEBUF, H5E_READERROR, FAIL, "page buffer page load request failed (2)")

            HDassert(entry_ptr);
            HDassert(entry_ptr->magic == H5PB__H5PB_ENTRY_T_MAGIC);
            HDassert(entry_ptr->is_metadata);
            HDassert((!(entry_ptr->is_mpmde)) || (page_buf->vfd_swmr_writer));

            /* copy data from the page into read buffer */
            HDmemcpy((uint8_t *)buf, (uint8_t *)(entry_ptr->image_ptr), size);

            /* if the entry is on the LRU, update the replacement policy */
            if ((!(entry_ptr->is_mpmde)) && (entry_ptr->delay_write_until == 0)) {

                H5PB__UPDATE_RP_FOR_ACCESS(page_buf, entry_ptr, FAIL)
            }
        }
    }

    if (!bypass)
        H5PB__UPDATE_STATS_FOR_ACCESS(page_buf, type, size);

done:

    FUNC_LEAVE_NOAPI(ret_value)

} /* end H5PB__read_meta() */

/*-------------------------------------------------------------------------
 *
 * Function:	H5PB__read_raw
 *
 * Purpose:	Satisfy a raw data read in cases 3 and 4 from H5PB_read().
 *              Specifically:
 *
 *              3) If the read is for raw data, and it is larger than the
 *                 page size, read it directly from the HDF5 file.
 *
 *                 It is possible that the page buffer contains dirty pages
 *                 that intersect with the read -- test for this and update
 *                 the read buffer from the page buffer if any such pages
 *                 exist.
 *
 *                 Note that no pages are inserted into the page buffer in
 *                 this case.
 *
 *              4) If the read is for raw data, and it is of size less
 *                 than or equal to the page size, satisfy the read from
 *                 the page buffer, loading and inserting pages into the
 *                 page buffer as necessary
 *
 *              Observe that this implies that:
 *
 *              1) The page buffer is defined.
 *
 *              2) The page buffer has been configured to accept at least
 *                 one page of raw data.
 *
 *              2) This is a raw data read.
 *
 * Return:	Non-negative on success/Negative on failure
 *
 * Programmer:	John Mainzer -- 10/11/18
 *
 * Changes:     None.
 *
 *-------------------------------------------------------------------------
 */
static herr_t
H5PB__read_raw(H5F_shared_t *shared, H5FD_mem_t type, haddr_t addr, size_t size, void *buf /*out*/)
{
    H5PB_t *      page_buf;            /* Page buffer for this file */
    H5PB_entry_t *entry_ptr;           /* Pointer to page buffer entry */
    uint64_t      first_page;          /* page offset of first I/O */
    uint64_t      last_page;           /* page offset of last I/O */
    uint64_t      search_page;         /* page offset of current page */
    haddr_t       first_page_addr;     /* address of first page of I/O */
    haddr_t       last_page_addr;      /* address of last page of I/O */
    haddr_t       search_addr;         /* Address of current page */
    hsize_t       num_touched_pages;   /* Number of pages accessed */
    size_t        offset;              /* offset of read in page */
    size_t        length;              /* length of read in page */
    hsize_t       i;                   /* Local index variable */
    herr_t        ret_value = SUCCEED; /* Return value */

    FUNC_ENTER_NOAPI(FAIL)

    /* Sanity checks */
    HDassert(shared);
    HDassert(shared->page_buf);

    page_buf = shared->page_buf;

    HDassert(page_buf->magic == H5PB__H5PB_T_MAGIC);
    HDassert(page_buf->min_md_pages < page_buf->max_pages);
    HDassert(H5FD_MEM_DRAW == type);

    /* Calculate the aligned address of the first page */
    first_page      = (addr / page_buf->page_size);
    first_page_addr = first_page * page_buf->page_size;

    /* Calculate the aligned address of the last page */
    last_page      = ((addr + size - 1) / page_buf->page_size);
    last_page_addr = last_page * page_buf->page_size;

    /* Calculate number of pages that this read spans. */
    num_touched_pages = last_page - first_page + 1;

    if (first_page_addr == last_page_addr) {

        HDassert(1 == num_touched_pages);
        last_page_addr = HADDR_UNDEF;
    }

    /* case 3) raw data read of page size or greater. */
    if (size >= page_buf->page_size) {

        if (H5FD_read(shared->lf, type, addr, size, buf) < 0)

            HGOTO_ERROR(H5E_PAGEBUF, H5E_READERROR, FAIL, "read failed")

        H5PB__UPDATE_STATS_FOR_BYPASS(page_buf, type, size);

        /* For each page that intersects with the above read, check to see
         * if it exists in the page buffer, and if so, if it is dirty.
         *
         * If it does and is, update the read buffer with the contents
         * of the page so we get the up to date data into the buffer
         * after the big read from the file.
         */
        search_page = first_page;
        search_addr = first_page_addr;

        for (i = 0; i < num_touched_pages; i++) {

            H5PB__SEARCH_INDEX(page_buf, search_page, entry_ptr, FAIL)

            /* update hit rate stats */
            H5PB__UPDATE_PB_HIT_RATE_STATS(page_buf, (entry_ptr != NULL), FALSE, FALSE)

            if (entry_ptr) {

                HDassert(entry_ptr->magic == H5PB__H5PB_ENTRY_T_MAGIC);
                HDassert(!(entry_ptr->is_metadata));
                HDassert(entry_ptr->page == search_page);
                HDassert(entry_ptr->addr == search_addr);
                HDassert(entry_ptr->size == page_buf->page_size);
                HDassert(entry_ptr->delay_write_until == 0);
                /* This page and [addr, addr + size) should NOT be disjoint. */
                HDassert(!(addr + size <= entry_ptr->addr || entry_ptr->addr + entry_ptr->size <= addr));

                if (entry_ptr->is_dirty) {

                    if (i == 0) {

                        /* handle the possible partial access of the
                         * first page.
                         */

                        HDassert(search_addr == first_page_addr);
                        HDassert(search_page == first_page);

                        offset = addr - first_page_addr;

                        HDassert(((offset == 0) && (search_addr == addr)) ||
                                 ((offset > 0) && (search_addr < addr)));

                        HDassert(page_buf->page_size >= offset);

                        HDassert(size >= page_buf->page_size - (size_t)offset);

                        HDmemcpy(buf, (uint8_t *)entry_ptr->image_ptr + offset,
                                 page_buf->page_size - (size_t)offset);
                    }
                    else if (i == num_touched_pages - 1) {

                        /* handle the possible partial access of the
                         * last page.
                         */
                        HDassert(i > 0);
                        HDassert(search_addr == last_page_addr);
                        HDassert(search_page == last_page);
                        HDassert(addr < last_page_addr);
                        HDassert(last_page_addr < addr + size);

                        offset = (num_touched_pages - 2) * page_buf->page_size +
                                 (page_buf->page_size - (addr - first_page_addr));

                        HDmemcpy((uint8_t *)buf + offset, entry_ptr->image_ptr,
                                 (size_t)((addr + size) - last_page_addr));
                    }
                    else {

                        /* this is an internal page -- copy it in its
                         * entireity.
                         */

                        offset =
                            (i - 1) * page_buf->page_size + (page_buf->page_size - (addr - first_page_addr));

                        HDassert(addr + offset == search_addr);
                        HDassert(offset + page_buf->page_size <= size);

                        HDmemcpy((uint8_t *)buf + offset, entry_ptr->image_ptr, page_buf->page_size);
                    }

                    /* we have touched the entry -- move it to the top
                     * of the LRU if it resides there.
                     *
                     * The entry will be on the LRU if both it is not
                     * a multi-page metadata entry and it is not
                     * subject to a delayed write.
                     *
                     * As this is a raw data page buffer entry, both of
                     * these must be true, and are asserted above.
                     *
                     * Thus, just update the LRU.
                     */
                    H5PB__UPDATE_RP_FOR_ACCESS(page_buf, entry_ptr, FAIL)

                } /* if ( entry_ptr->is_dirty ) */
            }     /* if ( entry_ptr ) */

            search_page++;
            search_addr += page_buf->page_size;

        } /* end for */
    }
    else {
        /* case 4: Raw data read of size less than page size.
         *
         * In this case, read the desired data from the page buffer, loading
         * pages if necessary.
         */
        HDassert(size < page_buf->page_size);

        /* first page */
        offset = addr - first_page_addr;

        if ((offset + size) <= page_buf->page_size) {

            HDassert(num_touched_pages == 1);
            length = size;
        }
        else {

            HDassert(num_touched_pages == 2);
            length = size - (page_buf->page_size - offset);
        }

        /* get the first page */
        H5PB__SEARCH_INDEX(page_buf, first_page, entry_ptr, FAIL)

        /* update hit rate stats */
        H5PB__UPDATE_PB_HIT_RATE_STATS(page_buf, (entry_ptr != NULL), FALSE, FALSE)

        if ((NULL == entry_ptr) && (H5PB__load_page(shared, page_buf, first_page_addr, type, &entry_ptr) < 0))

            HGOTO_ERROR(H5E_PAGEBUF, H5E_READERROR, FAIL, "page buffer page load request failed (1)")

        HDassert(entry_ptr);
        HDassert(entry_ptr->magic == H5PB__H5PB_ENTRY_T_MAGIC);
        HDassert(entry_ptr->addr == first_page_addr);

        /* copy data from first page into read buffer */
        HDmemcpy((uint8_t *)buf, ((uint8_t *)(entry_ptr->image_ptr) + offset), length);

        H5PB__UPDATE_RP_FOR_ACCESS(page_buf, entry_ptr, FAIL)

        /* second page, if it exists */
        if (num_touched_pages == 2) {

            offset = length;
            length = size - offset;

            HDassert(offset + length == size);

            /* get the second page */
            H5PB__SEARCH_INDEX(page_buf, last_page, entry_ptr, FAIL)

            /* update hit rate stats */
            H5PB__UPDATE_PB_HIT_RATE_STATS(page_buf, (entry_ptr != NULL), FALSE, FALSE)

            if ((NULL == entry_ptr) &&
                (H5PB__load_page(shared, page_buf, last_page_addr, type, &entry_ptr) < 0))

                HGOTO_ERROR(H5E_PAGEBUF, H5E_READERROR, FAIL, "page buffer page load request failed (2)")

            HDassert(entry_ptr);
            HDassert(entry_ptr->magic == H5PB__H5PB_ENTRY_T_MAGIC);
            HDassert(entry_ptr->addr == last_page_addr);
            HDassert(entry_ptr->page == last_page);

            /* copy data from second page into read buffer */
            HDmemcpy(((uint8_t *)(buf) + offset), (uint8_t *)(entry_ptr->image_ptr), length);

            H5PB__UPDATE_RP_FOR_ACCESS(page_buf, entry_ptr, FAIL)
        }
    } /* end else */

    H5PB__UPDATE_STATS_FOR_ACCESS(page_buf, type, size);

done:

    FUNC_LEAVE_NOAPI(ret_value)

} /* end H5PB__read_raw() */

/*-------------------------------------------------------------------------
 *
 * Function:	H5PB__write_meta
 *
 * Purpose:	Satisfy a metadata write in cases 7 and 8 from H5PB_write().
 *              Specifically:
 *
 *              7) If the write is of metadata, the write is larger than
 *                 one page, and vfd_swmr_writer is TRUE, the write must
 *                 buffered in the page buffer until the end of the tick.
 *
 *                 If it doesn't exist already, create a multi-page metadata
 *                 entry in the page buffer and copy the write into it.
 *                 Insert the new entry in the tick list if necessary.
 *
 *                 Test to see if the write of the multi-page metadata
 *                 entry must be delayed.  If so, place the entry in
 *                 the delayed write list.  Otherwise, the multi-page
 *                 metadata entry will be written to the HDF5 file and
 *                 evicted when the tick list is released at the of the
 *                 tick.
 *
 *              8) If the write is of metadata, and the write is of size
 *                 less than or equal to the page size, write the data
 *                 into the page buffer, loading and inserting a page
 *                 if necessary.
 *
 *                 If, in addition, vfd_swmr_writer is TRUE, we must:
 *
 *                  * add the page touched by the write to the tick list
 *                    so that it will be buffered until the end of the
 *                    tick.
 *
 *                  * test to see if the write must be delayed, and
 *                    add the page to the delayed write list if so.
 *
 *              Observe that this implies that:
 *
 *              1) The page buffer is defined.
 *
 *              2) The page buffer has been configured to accept at least
 *                 one page of metadata.
 *
 *              3) This is a metadata write.
 *
 *              Note also that if the metadata write is of size
 *              no larger than page size, it may not cross page
 *              boundaries.
 *
 *              Further, for writes larger than page size (case 7 only),
 *              the base address must be page aligned.
 *
 * Return:	Non-negative on success/Negative on failure
 *
 * Programmer:	John Mainzer -- 10/11/18
 *
 * Changes:     None.
 *
 *-------------------------------------------------------------------------
 */
static herr_t
H5PB__write_meta(H5F_shared_t *shared, H5FD_mem_t type, haddr_t addr, size_t size, const void *buf /*in*/)
{
    H5PB_t *      page_buf;            /* Page buffer for this file */
    H5PB_entry_t *entry_ptr;           /* Pointer to page buffer entry */
    uint64_t      page;                /* page offset of addr */
    haddr_t       page_addr;           /* page containg addr */
    size_t        offset;              /* offset of write in page */
    herr_t        ret_value = SUCCEED; /* Return value */

    FUNC_ENTER_NOAPI(FAIL)

    /* Sanity checks */
    HDassert(shared);
    HDassert(shared->page_buf);

    page_buf = shared->page_buf;

    HDassert(page_buf->magic == H5PB__H5PB_T_MAGIC);
    HDassert(page_buf->min_rd_pages < page_buf->max_pages);
    HDassert(H5FD_MEM_DRAW != type);
    HDassert(buf);

    /* Calculate the aligned address of the first page */
    page      = (addr / page_buf->page_size);
    page_addr = page * page_buf->page_size;

    /* if size > page_buf->page_size, addr must be page aligned */
    HDassert((size <= page_buf->page_size) || (addr == page_addr));

    H5PB__SEARCH_INDEX(page_buf, page, entry_ptr, FAIL)

    /* case 7) metadata write of size greater than page size. */
    if (size > page_buf->page_size) {

        offset = 0;

        /* The write must be for a multi-page metadata entry, and
         * we must be running as a VFD SWMR writer.
         *
         * This requires the following actions:
         *
         * 1) If the multi-page metadata entry is not already in the
         *    page buffer, create an entry for it.
         *
         * 2) Overwrite the image of the entry with the write buffer.
         *
         * 3) If the entry is not already on the tick list, add it to
         *    the tick list.
         *
         * 4) If the entry is not already on the delayed write list,
         *    test to see if it should be, and move it from the
         *    LRU to the delayed write list and set the delay_write_until
         *    field appropriately.
         *
         *    This is done via the call to H5PB__mark_entry_dirty()
         */
        HDassert(page_buf->vfd_swmr_writer);
        HDassert(addr == page_addr);

        /* If we're about to overwrite a single-page entry with multiple
         * pages, lengthen the entry.
         */
        if (entry_ptr != NULL && entry_ptr->size < size) {
            H5PB_entry_t *overlap;
            void *        new_image = H5MM_malloc(size);
            uint64_t      iter_page;
            uint64_t      last_page = page + roundup(size, page_buf->page_size) / page_buf->page_size;

            for (iter_page = page + 1; iter_page < last_page; iter_page++) {
                H5PB__SEARCH_INDEX(page_buf, iter_page, overlap, FAIL)
                HDassert(overlap == NULL);
            }
            if (new_image == NULL) {
                HGOTO_ERROR(H5E_PAGEBUF, H5E_SYSTEM, FAIL, "couldn't extend entry");
            }
            H5PB__UPDATE_RP_FOR_REMOVE(page_buf, entry_ptr, FAIL)

            /* To keep statistics for the index and the tick-list up-to-date,
             * it's expedient to remove and re-insert entries there.
             */
            H5PB__DELETE_FROM_INDEX(page_buf, entry_ptr, FAIL)
            if (entry_ptr->modified_this_tick)
                H5PB__REMOVE_FROM_TL(page_buf, entry_ptr, FAIL)

            entry_ptr->image_ptr = H5MM_xfree(entry_ptr->image_ptr);
            entry_ptr->image_ptr = new_image;
            entry_ptr->is_mpmde  = TRUE;
            entry_ptr->size      = size;

            if (entry_ptr->modified_this_tick)
                H5PB__INSERT_IN_TL(page_buf, entry_ptr, FAIL)
            H5PB__INSERT_IN_INDEX(page_buf, entry_ptr, FAIL)
        }

        /* update hit rate stats */
        H5PB__UPDATE_PB_HIT_RATE_STATS(page_buf, (entry_ptr != NULL), TRUE, TRUE)

        if (NULL == entry_ptr) {

            /* the multi-page metadata entry is not currently in the page
             * buffer.  Create an entry for it, and insert it into the LRU.
             *
             * Don't bother to try to make space for it, as VFD SWMR
             * ignores the limits on page buffer size.
             */
            if (H5PB__create_new_page(page_buf, addr, size, type, FALSE, &entry_ptr) < 0)

                HGOTO_ERROR(H5E_PAGEBUF, H5E_SYSTEM, FAIL, "can't create new page buffer page")

            /* set entry_ptr->loaded to TRUE so as to trigger the
             * the delayed write test in H5PB__mark_entry_dirty().
             */
            entry_ptr->loaded = TRUE;
        }

        /* at this point, one way or the other, the multi-page metadata
         * entry must be in the page buffer.
         */
        HDassert(entry_ptr->is_mpmde);
        HDassert(size == entry_ptr->size);
        HDassert(type == entry_ptr->mem_type);
    }
    else {
        /* case 8) metadata write of size no larger than page size */

        offset = addr - page_addr;

        /* write cannot cross page boundaries. */
        HDassert((offset + size) <= page_buf->page_size);

        /* update hit rate stats */
        H5PB__UPDATE_PB_HIT_RATE_STATS(page_buf, (entry_ptr != NULL), TRUE, FALSE)

        if (NULL == entry_ptr && H5PB__load_page(shared, page_buf, page_addr, type, &entry_ptr) < 0) {
            HGOTO_ERROR(H5E_PAGEBUF, H5E_READERROR, FAIL, "page buffer page load request failed (1)")
        }

        HDassert(entry_ptr->magic == H5PB__H5PB_ENTRY_T_MAGIC);
        HDassert(entry_ptr->addr == page_addr);
        HDassert(!(entry_ptr->is_mpmde));
        HDassert(entry_ptr->size == page_buf->page_size);
        HDassert(size <= entry_ptr->size);
    }

    HDassert(entry_ptr->is_metadata);

    /* copy data from the write buffer into the page image */
    HDmemcpy((uint8_t *)(entry_ptr->image_ptr) + offset, buf, size);

    if (H5PB__mark_entry_dirty(shared, page_buf, entry_ptr) < 0)
        HGOTO_ERROR(H5E_PAGEBUF, H5E_SYSTEM, FAIL, "mark entry dirty failed")

    /* Force the page buffer to retain the page until the end of
     * the tick: add the entry to the tick list if it is not
     * already present.
     */
    if (page_buf->vfd_swmr_writer && !entry_ptr->modified_this_tick) {
        entry_ptr->modified_this_tick = TRUE;
        H5PB__INSERT_IN_TL(page_buf, entry_ptr, FAIL)
    }

    H5PB__UPDATE_STATS_FOR_ACCESS(page_buf, type, size);

done:

    FUNC_LEAVE_NOAPI(ret_value)

} /* end H5PB__write_meta() */

/*-------------------------------------------------------------------------
 *
 * Function:    H5PB__write_raw
 *
 * Purpose:     Satisfy a raw data write in cases 3 and 4 from H5PB_write().
 *              Specifically:
 *
 *              3) If the write is raw data, and it of page size or
 *                 larger, write directly to the HDF5 file.
 *
 *                 It is possible that the write intersects one or more
 *                 pages in the page buffer -- test for this and update
 *                 any partially written pages, and evict any pages
 *                 that are completely overwritten.
 *
 *                 Note that no pages are inserted into the page buffer in
 *                 this case.
 *
 *              4) If the write is of raw data, and it is of size less
 *                 than the page size, write the page into the page
 *                 buffer, loading and inserting pages into the
 *                 page buffer as necessary
 *
 *              Observe that this implies that:
 *
 *              1) The page buffer is defined.
 *
 *              2) The page buffer has been configured to accept at least
 *                 one page of raw data.
 *
 *              2) This is a raw data write.
 *
 * Return:	Non-negative on success/Negative on failure
 *
 * Programmer:	John Mainzer -- 10/11/18
 *
 * Changes:     None.
 *
 *-------------------------------------------------------------------------
 */
static herr_t
H5PB__write_raw(H5F_shared_t *shared, H5FD_mem_t type, haddr_t addr, size_t size, const void *buf /*out*/)
{
    H5PB_t *      page_buf;            /* Page buffer for this file */
    H5PB_entry_t *entry_ptr;           /* Pointer to page buffer entry */
    uint64_t      first_page;          /* page offset of first I/O */
    uint64_t      last_page;           /* page offset of last I/O */
    uint64_t      search_page;         /* page offset of current page */
    haddr_t       first_page_addr;     /* address of first page of I/O */
    haddr_t       last_page_addr;      /* address of last page of I/O */
    haddr_t       search_addr;         /* Address of current page */
    hsize_t       num_touched_pages;   /* Number of pages accessed */
    hsize_t       i;                   /* Local index variable */
    size_t        length;              /* length of write in a page */
    size_t        offset;              /* offset of write in a page */
    herr_t        ret_value = SUCCEED; /* Return value */

    FUNC_ENTER_NOAPI(FAIL)

    /* Sanity checks */
    HDassert(shared);
    HDassert(shared->page_buf);

    page_buf = shared->page_buf;

    HDassert(page_buf->magic == H5PB__H5PB_T_MAGIC);
    HDassert(page_buf->min_md_pages < page_buf->max_pages);
    HDassert(shared->lf);

    HDassert(H5FD_MEM_DRAW == type);

    /* Calculate the aligned address of the first page */
    first_page      = (addr / page_buf->page_size);
    first_page_addr = first_page * page_buf->page_size;

    /* Calculate the aligned address of the last page */
    last_page      = ((addr + size - 1) / page_buf->page_size);
    last_page_addr = last_page * page_buf->page_size;

    /* Calculate number of pages that this read spans. */
    num_touched_pages = last_page - first_page + 1;

    if (first_page_addr == last_page_addr) {

        HDassert(1 == num_touched_pages);
        last_page_addr = HADDR_UNDEF;
    }

    /* case 3) raw data write of page size or greater. */
    if (size >= page_buf->page_size) {
        if (H5FD_write(shared->lf, type, addr, size, buf) < 0)

            HGOTO_ERROR(H5E_PAGEBUF, H5E_WRITEERROR, FAIL, "write through metadata accumulator failed")

        H5PB__UPDATE_STATS_FOR_BYPASS(page_buf, type, size);

        /* For each page that intersects with the above write, check to see
         * if it exists in the page buffer.
         *
         * If it does and is, and if the write overwrites page fully,
         * mark the page clean and evict it.
         *
         * If the write only partially intersects a page, update the
         * page and mark it dirty.
         */
        search_page = first_page;
        search_addr = first_page_addr;

        for (i = 0; i < num_touched_pages; i++) {

            H5PB__SEARCH_INDEX(page_buf, search_page, entry_ptr, FAIL)

            /* update hit rate stats */
            H5PB__UPDATE_PB_HIT_RATE_STATS(page_buf, (entry_ptr != NULL), FALSE, FALSE)

            if (entry_ptr) {

                HDassert(entry_ptr->magic == H5PB__H5PB_ENTRY_T_MAGIC);
                HDassert(!(entry_ptr->is_metadata));
                HDassert(entry_ptr->page == search_page);
                HDassert(entry_ptr->addr == search_addr);
                HDassert(entry_ptr->size == page_buf->page_size);
                HDassert(entry_ptr->delay_write_until == 0);
                HDassert(entry_ptr->addr <= addr + size);

                if ((addr <= entry_ptr->addr) && (entry_ptr->addr + entry_ptr->size <= addr + size)) {

                    /* the page is completely overwritten -- mark it clean
                     * and evict it.
                     */
                    if ((entry_ptr->is_dirty) && (H5PB__mark_entry_clean(page_buf, entry_ptr) < 0))

                        HGOTO_ERROR(H5E_PAGEBUF, H5E_SYSTEM, FAIL, "mark entry clean failed")

                    if (H5PB__evict_entry(shared, entry_ptr, TRUE, FALSE) < 0)

                        HGOTO_ERROR(H5E_PAGEBUF, H5E_SYSTEM, FAIL, "forced eviction failed (1)")
                }
                else if (i == 0) {

                    /* handle partial overwrite of the first page.  */

                    HDassert(search_addr == first_page_addr);
                    HDassert(search_page == first_page);
                    HDassert(search_addr < addr);
                    HDassert(entry_ptr->addr + entry_ptr->size <= addr + size);

                    offset = addr - first_page_addr;

                    HDassert(offset > 0);
                    HDassert(page_buf->page_size >= offset);
                    HDassert(size >= page_buf->page_size - (size_t)offset);

                    HDmemcpy((uint8_t *)entry_ptr->image_ptr + offset, buf,
                             page_buf->page_size - (size_t)offset);

                    if (H5PB__mark_entry_dirty(shared, page_buf, entry_ptr) < 0)

                        HGOTO_ERROR(H5E_PAGEBUF, H5E_SYSTEM, FAIL, "mark entry dirty failed (1)")
                }
                else if (i == num_touched_pages - 1) {

                    /* handle partial overwrite of the last page.  */
                    HDassert(i > 0);
                    HDassert(search_addr == last_page_addr);
                    HDassert(search_page == last_page);
                    HDassert(addr < last_page_addr);
                    HDassert(last_page_addr < addr + size);

                    offset = (num_touched_pages - 2) * page_buf->page_size +
                             (page_buf->page_size - (addr - first_page_addr));

                    HDmemcpy(entry_ptr->image_ptr, (const uint8_t *)buf + offset,
                             (size_t)((addr + size) - last_page_addr));

                    if (H5PB__mark_entry_dirty(shared, page_buf, entry_ptr) < 0)

                        HGOTO_ERROR(H5E_PAGEBUF, H5E_SYSTEM, FAIL, "mark entry dirty failed (2)")
                }
                else {

                    /* this should be un-reachable */
                    HDassert(FALSE);
                }
            } /* if ( entry_ptr ) */

            search_page++;
            search_addr += page_buf->page_size;

        } /* end for */
    }
    else {
        /* case 4: Raw data write of size less than page size.
         *
         * In this case, write the data to the page buffer, loading
         * pages if necessary.
         */
        HDassert(size < page_buf->page_size);

        /* first page */
        offset = addr - first_page_addr;

        if ((offset + size) <= page_buf->page_size) {

            HDassert(num_touched_pages == 1);
            length = size;
        }
        else {

            HDassert(num_touched_pages == 2);
            length = page_buf->page_size - offset;
            HDassert(offset + length == page_buf->page_size);
        }

        /* get the first page */
        H5PB__SEARCH_INDEX(page_buf, first_page, entry_ptr, FAIL)

        /* update hit rate stats */
        H5PB__UPDATE_PB_HIT_RATE_STATS(page_buf, (entry_ptr != NULL), FALSE, FALSE)

        if ((NULL == entry_ptr) && (H5PB__load_page(shared, page_buf, first_page_addr, type, &entry_ptr) < 0))

            HGOTO_ERROR(H5E_PAGEBUF, H5E_READERROR, FAIL, "page buffer page load request failed (1)")

        HDassert(entry_ptr);
        HDassert(entry_ptr->magic == H5PB__H5PB_ENTRY_T_MAGIC);
        HDassert(entry_ptr->addr == first_page_addr);

        /* copy data from the write buffer into the first page */
        HDmemcpy(((uint8_t *)(entry_ptr->image_ptr)) + offset, (const uint8_t *)buf, length);

        if (H5PB__mark_entry_dirty(shared, page_buf, entry_ptr) < 0)

            HGOTO_ERROR(H5E_PAGEBUF, H5E_SYSTEM, FAIL, "mark entry dirty failed (3)")

        /* second page, if it exists */
        if (num_touched_pages == 2) {

            offset = length;
            length = size - offset;

            HDassert(offset + length == size);

            /* get the first page */
            H5PB__SEARCH_INDEX(page_buf, last_page, entry_ptr, FAIL)

            /* update hit rate stats */
            H5PB__UPDATE_PB_HIT_RATE_STATS(page_buf, (entry_ptr != NULL), FALSE, FALSE)

            if ((NULL == entry_ptr) &&
                (H5PB__load_page(shared, page_buf, last_page_addr, type, &entry_ptr) < 0))

                HGOTO_ERROR(H5E_PAGEBUF, H5E_READERROR, FAIL, "page buffer page load request failed (2)")

            HDassert(entry_ptr);
            HDassert(entry_ptr->magic == H5PB__H5PB_ENTRY_T_MAGIC);
            HDassert(entry_ptr->addr == last_page_addr);
            HDassert(entry_ptr->page == last_page);

            /* copy data from the write buffer into the first page */
            HDmemcpy((uint8_t *)(entry_ptr->image_ptr), ((const uint8_t *)(buf) + offset), length);

            if (H5PB__mark_entry_dirty(shared, page_buf, entry_ptr) < 0)

                HGOTO_ERROR(H5E_PAGEBUF, H5E_SYSTEM, FAIL, "mark entry dirty failed (3)")
        }
    }

    H5PB__UPDATE_STATS_FOR_ACCESS(page_buf, type, size);

done:

    FUNC_LEAVE_NOAPI(ret_value)

} /* end H5PB__write_raw() */