summaryrefslogtreecommitdiffstats
path: root/hl
Commit message (Collapse)AuthorAgeFilesLines
* Update reformatting settings, trace wrapping, and printf-format strings (#22)Quincey Koziol2020-10-063-3993/+3739
| | | | | | | | | | | | | | | | | | | | | | | | | | | | * Add BEGIN_FUNC / CATCH / END_FUNC to macros * Remove incorrect trailing '{' * Update trace script to wrap H5TRACE macros at 110 characters and improve comments for code that performs this operation. * Clean up printf-formatting in H5public.h and correct some oversights in the code. * Reformat with BEGIN_FUNC / END_FUNC handled correctly by clang-format * Run clang-format on changes. * Correct H5_SIZEOF_HSIZE_T/H5_SIZEOF_HSSIZE_T macros to match typedef. * And make the undef value match also. * Update comment * Update clang-format actions to exclude generated files. * Post-process generated H5LTparse.h file as well as H5LTparse.c file. * Fix formatting * Update version of github clang-format action
* Fix VFD h5repacktest (#20)Allen Byrne2020-10-063-117/+101
| | | | | | | | | | | | | | * h5repacktest VFD fix and formatting changes * Fix memory leak in H5PL__find_plugin_in_path When encountering a directory, the current loop iteration was skipped without freeing the memory allocated for the path. * Refactor parser GCC diagnostic statements * genparser on jelly with default bison/flex Co-authored-by: Michael Kuhn <michael.kuhn@ovgu.de>
* Clang-format of source filesAllen Byrne2020-09-3083-22637/+21114
|
* Merge pull request #2650 in HDFFV/hdf5 from ↵David Young2020-09-281-2/+2
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ~DYOUNG/werror:rebased-fprintf-experiment to develop * commit 'c0fbc5c086566d5d3c1d1ef26baa81a53d59fc08': (24 commits) Use the right format string, "%zu", for size_t. Repair more format strings. Fix a bunch of format string errors reported by Larry. Fix some HDfprintf compilation errors: use the right format strings ("zu", PRIuHSIZE), avoid casting some printf arguments, pass the right number of arguments. Test the format string "ll" before "l", "L", and "q", like the ./configure script does. This ought to fix the compilation failure in test/dt_arith.c that Allen told me about: Cast a non-void pointer to void pointer for "%p". Use PRIu32 and "zu" formats. Delete some casts from `size_t`. I'm taking a guess that this code intended to point the 2-digit wide hexadecimal octet values, not 2 character-wide pointers to the bytes. The %02p format, which is a GNU-ism, disagreed with GCC 8.3.0 and the option flags we use. %08p is not portable, it's a GNU-ism. Use %8p, instead. Squashes a GCC error. Add format string macros PRI[doxX]HID for hid_t and use PRIdHID. Use HDva_copy() and introduce a bunch of compatbility format-string constants for uppercase hexadecimal strings, `PRIX...`. Should fix the VS2010 errors that Allen mentioned: Always #define HDfprintf as fprintf in this header. I believe this will fix the Windows build error that Allen reported. Provide an HDvasprintf implementation only if it isn't #defined. This should fix the mingw compilation issue that Allen reported. Fix va_list usage in the vasprintf(3) implementation. Promote format-string warnings to errors. Use the portable `-eq` operator instead of the bash-ism `==`. Fixes the tests on NetBSD, where /bin/sh != bash. Restore a literal percent sign ("%%") that I accidentally deleted. Fix code that made GCC complain about a NULL or `unsigned char *` arguments for "%s". Take pains to provide UINT64_MAX in all conditions. Correct a couple of format strings. ...
| * Merge remote-tracking branch 'hdffv/develop' into rebased-fprintf-experimentDavid Young2020-09-2713-594/+755
| |\
| * \ Merge remote-tracking branch 'hdffv/develop' into rebased-fprintf-experimentDavid Young2020-09-0327-1897/+1892
| |\ \
| * \ \ Merge remote-tracking branch 'hdffv/develop' into rebased-fprintf-experimentDavid Young2020-07-303-66/+92
| |\ \ \
| * | | | Squash my changes on branch `fprintf-experiment` into one commit forDavid Young2020-07-071-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | reapplication to my new warnings branch, `warnings-again`. These changes are included: commit 915551b7bf64e777dd2007386ec77b1d117770da Merge: 63858c2 a8892bb Author: David Young <dyoung@hdfgroup.org> Date: Mon Nov 25 17:39:49 2019 -0600 Merge remote-tracking branch 'hdf5/develop' into fprintf-experiment commit a8892bb42d6f6e4fbc30fae0eb2b957f81c938b9 Merge: 5c911d8 f907b51 Author: David Young <dyoung@hdfgroup.org> Date: Mon Nov 25 17:33:54 2019 -0600 Merge pull request #2055 in HDFFV/hdf5 from ~DYOUNG/vchoi_fork:add-werror-and-squash-some to develop * commit 'f907b511d06612dafc7814a7c30f2f3d2b76d52b': Oops, remove more C99 designated initializers for VS 2010 compatibility. commit 63858c22e168acaec0af8ced6641f26102cc6bb0 Merge: 20ae787 5c911d8 Author: David Young <dyoung@hdfgroup.org> Date: Mon Nov 25 17:04:42 2019 -0600 Merge remote-tracking branch 'hdf5/develop' into fprintf-experiment commit 5c911d8baf3ee7fe654269088eebdf07f59a8192 Merge: b8a5671 62208b0 Author: David Young <dyoung@hdfgroup.org> Date: Mon Nov 25 16:58:27 2019 -0600 Merge pull request #2030 in HDFFV/hdf5 from ~DYOUNG/vchoi_fork:add-werror-and-squash-some to develop * commit '62208b056a09c01855fbac7f75146be58ad6bfe5': (44 commits) Add an #include to get a function declaration. Don't use C99 designated initializers, they're not compatible with Visual Studio 2010. Quiet some more maybe-uninitialized warnings---each is a false positive, *sigh*. This is more code that may not compile with VS2010, *sigh sigh*. Always warn on maybe-uninitialized. -Wincompatible-pointer-types was not available until GCC 5, so enable it only if that's the GCC version we're using. Only promote maybe-uninitialized warnings to errors on GCC 8. Even on GCC 8, there may be false positives at low optimization levels? I need to check. Only use -Werror=cast-function-type with GCC 8 and later. Put all of the -W options back into the order I found them in so that it's easier to compare old and new config/gnu-flags. Add new source files to CMakeLists.txt. Mention the -Werror= flags in libhdf5.settings.in. free -> HDfree Promote decleration-after-statement warnings to errors. Quiet decleration-after-statement warnings. Move a statement under some declarations since some vintages of Visual Studio don't like declarations after statements. Document H5D__chunk_mem_xfree_wrapper(). Undo accidental test deletion. Oops, delete a debug printf that snuck in here. Undo my changes to the HD macros, hadn't really intended those to be on this branch.... Make errors of some more warnings. Move disabled warnings to DEVELOPER_WARNING_CFLAGS. Put just one warning option on a line, and sort some of the options. Cast to the parameter type, H5VL_token_t *, instead of to unsigned char *. Change hdset_reg_ref_t and H5R_ref_t from arrays of unsigned char to structs containing those arrays. Encapsulating the arrays in this way makes it easier to write and think about pointers to these types, casts to/from these types, etc. ... commit 20ae7877e33931b95e8c3502b027d6c3fe94a11f Merge: 46f8c61 edd5297 Author: David Young <dyoung@hdfgroup.org> Date: Fri Nov 22 15:34:09 2019 -0600 Merge remote-tracking branch 'origin/add-werror-and-squash-some' into fprintf-experiment commit 46f8c613d5117a8be5bc8385a072daa0b4262f06 Author: David Young <dyoung@hdfgroup.org> Date: Fri Nov 22 15:29:00 2019 -0600 GCC really wants us to use `ll` to format `long long`, so try to make that work before any other format modifier. Seems like we're not compiling the autoconf test program with -Werror=format ? Probably should. commit eee35b8ef3759c391327cd48a9b3c56b6f8abc99 Author: David Young <dyoung@hdfgroup.org> Date: Fri Nov 22 15:28:05 2019 -0600 It's hard to know just how wide an HDoff_t will be, and I don't think POSIX or C standards provide a PRI macro for it, so cast to intmax_t and format using PRIdMAX. commit 86eab12df7a89b546a38e99f8178dd2adbcb3433 Author: David Young <dyoung@hdfgroup.org> Date: Fri Nov 22 15:26:25 2019 -0600 URemove some casts.se the right format string for the argument. Here and there stop casting a printf argument. commit f722f7cbecbaa99449941484b014426f62f1bed5 Merge: 58e3743 6d5ec83 Author: David Young <dyoung@hdfgroup.org> Date: Fri Nov 22 14:44:16 2019 -0600 Merge branch 'add-werror-and-squash-some' into fprintf-experiment commit 58e3743b7faa9836606ee91798fe80dfc0040da7 Author: David Young <dyoung@hdfgroup.org> Date: Wed Nov 20 21:07:21 2019 -0600 Remove custom HDfprintf implementation, using the standard library's, instead. Take a swipe at repairing fprintf format strings, mainly replacing "%Hu" with "%" PRIuHSIZE, "%a" with "%" PRIuHADDR, "%Zu" with "%zu". Here and there remove an awkward cast of a printf argument to `long long` and use PRI[doux]8, PRI[doux]32, or PRI[doux]64, instead. Change occurrences of "%t" to "%s" and perform a suitable change of argument, `cond` -> `cond ? "TRUE" : "FALSE"`. Some occurrences of %Hu, %a, and %t remain, they just weren't flagged by the compiler because of #ifdef'age. commit d4366909293fa970c23512ac80e5d865d76cddbf Author: David Young <dyoung@hdfgroup.org> Date: Wed Nov 20 20:54:32 2019 -0600 Promote format-string warnigns to errors.
* | | | | OESS-98 merge with clang-format changesAllen Byrne2020-09-259-24/+24
| |_|_|/ |/| | |
* | | | Fix comment formatting due to tabs conversionAllen Byrne2020-09-241-42/+42
| | | |
* | | | File changes to affect formattingAllen Byrne2020-09-043-587/+599
| | | |
* | | | CMake and script changes for clang-formatAllen Byrne2020-09-0410-7/+156
| |_|/ |/| |
* | | Minor refactoring based on 1.10 normalization workDana Robinson2020-08-171-13/+12
| | |
* | | Addresseda Dana's comments from the pull request.Elena2020-08-141-29/+32
| | |
* | | Fixed several typos in the comments found by Larry during the review.Elena2020-08-121-3/+3
| | |
* | | The H5DSis_scale function was updated to return "not a dimension scale" (0)Elena2020-08-121-40/+49
| | | | | | | | | | | | | | | instead of failing (-1), when CLASS or DIMENSION_SCALE attributes are not written according to Dimension Scales Specification (HDFFV-10436).
* | | Removes staff email addresses from the repositoryDana Robinson2020-08-0723-555/+449
| | | | | | | | | | | | Removes redundant C library headers from hl library
* | | Fixes -Wnull-dereference warning in hl/src/H5DS.cDana Robinson2020-08-061-4/+3
| | |
* | | Adds -Wnull-dereference to the warnings we ignore in flex/bisonDana Robinson2020-08-064-1301/+1392
| |/ |/| | | | | generated code (that we have no control over).
* | Tools refactorAllen Byrne2020-07-152-65/+72
| | | | | | | | | | | | Move error_stack setup to tools library Add structure for h5dump properties Eliminate duplicated h5diff functions Use properties structure in place of argument lists.
* | HDFFV-11116 Add option for install location of Fortran MOD filesAllen Byrne2020-07-091-1/+20
|/
* Fix HDFFV-10591Binh-Minh Ribler2020-06-192-12/+24
| | | | | | | | | | | | Description: h52gif produced a segfault when a buffer overflow occurred because the data size was corrupted and became very large. This commit added a check on the data size against the buffer size to prevent the segfault. It also added error reporting to h52gif to display an error message instead of silently exiting when the failure occurred. Platforms tested: Linux/64 (jelly) SunOS 5.11 (emu)
* Merge pull request #2610 in HDFFV/hdf5 from ↵David Young2020-06-163-6/+6
|\ | | | | | | | | | | | | ~DYOUNG/werror:hdffv-11060-examples-destdir to develop * commit '4cebd8aa6c965fe2e5dde6dbff36b2be3ca58bf1': Make examples installation respect DESTDIR. Fixes HDFFV-11060.
| * Make examples installation respect DESTDIR. FixesDavid Young2020-05-263-6/+6
| | | | | | | | HDFFV-11060.
* | Eliminate unneccesary creation of DXPLQuincey Koziol2020-06-021-14/+3
| |
* | Removed trailing space from Fortran files.Dana Robinson2020-05-268-252/+252
|/
* Fix NoFilter buildAllen Byrne2020-04-241-1/+1
|
* Trim trailing whitespaceQuincey Koziol2020-04-2027-448/+448
|
* Fix shadowed typeAllen Byrne2020-04-131-3/+3
|
* TRILAB-192 update LTparse filesAllen Byrne2020-04-073-1206/+1129
|
* Minor updates and fix settings for fortran flagsAllen Byrne2020-04-061-1/+1
|
* Remove overzealous additionsAllen Byrne2020-04-052-3/+1
|
* Flag construction must be after compiler detectionAllen Byrne2020-04-053-59/+27
|
* TRILAB-192 add c++ and fortran warnings build systems one fileAllen Byrne2020-04-059-61/+44
|
* Merge pull request #2469 in HDFFV/hdf5 from tools_vol_update to developJordan Henderson2020-03-271-1/+9
|\ | | | | | | | | | | | | * commit 'ea952b25ba0fd5c4b5f60a94e75a1b5b78e66172': A few small tweaks to the tools from review Replace usage of some standard library functions with HD- versions Update Tools library to be better compatible with VOL connectors
| * Update Tools library to be better compatible with VOL connectorsJordan Henderson2020-03-171-1/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Modify h5repack to integrate with VOL connectors Update tools library to accomodate VOL connectors Update logic in h5tools_fopen for VOL connectors Add command-line options to h5repack for specifying in/out VOL connectors Implement h5tools_set_vol_fapl Fix library shutdown issue Integrate ROS3 and HDFS VFDs into new h5tools_get_fapl() scheme Avoid H5Ocopy in h5repack when using different VOL connectors Update h5tools_test_utils.c for ROS3 and HDFS integration
* | TRILAB-192 restrict extensive warnings to librariesAllen Byrne2020-03-242-0/+12
|/
* So that I can use PASSED(); anywhere a statement can go, #define PASSED() withDavid Young2020-02-281-1/+1
| | | | a do-while wrapper.
* TRILAB-142 Change minimum CMake version to 3.12Allen Byrne2020-02-2115-15/+15
|
* HDFFV-11012 - add correct fortran include path propertiesAllen Byrne2020-02-041-2/+2
|
* Merge pull request #2328 in HDFFV/hdf5 from ~DEROBINS/hdf5_der:develop_minor ↵Dana Robinson2020-01-307-718/+988
|\ | | | | | | | | | | | | to develop * commit 'a67c238feef1487814b02132bfd7961f22d9d6eb': Cleaned up remaining warnings in high-level library.
| * Cleaned up remaining warnings in high-level library.Dana Robinson2020-01-307-718/+988
| |
* | HDFFV-11011 correct issues with target file extensionAllen Byrne2020-01-282-20/+8
|/
* Squashed commit of the token_refactoring branch:Dana Robinson2020-01-162-64/+111
|
* HDFFV-11001 fix if blockAllen Byrne2020-01-151-3/+2
|
* HDFFV-11001 need to qualify all by parallel or serial typesAllen Byrne2020-01-157-9/+8
|
* HDFFV-11001 Add fine control over testingAllen Byrne2020-01-1511-17/+27
|
* Merge pull request #2071 in HDFFV/hdf5 from ~KMU/hdf5:bugfix/intel_warnings ↵Kimmy Mu2020-01-061-1/+1
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | to develop * commit '0a2bb11b248df6841daabca3970df5d8504adfc7': address problems from comments fix and address comments change according to previous comments add missing piece remove unnecessary check macro fix intel compile warnings Revert "fix warnings from Intel compiler" Revert "fix warnings and some text alignment" Revert "let hdf5 pick up the right compiler in Intel environment" Revert "fix issues from previous PR comments" Revert "using a different MACRO" using a different MACRO fix issues from previous PR comments let hdf5 pick up the right compiler in Intel environment fix warnings and some text alignment fix warnings from Intel compiler
| * Merge branch 'develop' into bugfix/intel_warningskmu2019-12-092-5/+1
| |\
| * | remove unnecessary check macrokmu2019-12-061-2/+1
| | |
generated by cgit v0.12 at 2024-11-07 03:47:59 (GMT)