summaryrefslogtreecommitdiffstats
path: root/src/H5Dchunk.c
Commit message (Collapse)AuthorAgeFilesLines
* [svn-r27976] merge from trunk.Mohamad Chaarawi2015-10-061-14/+22
|\
| * [svn-r27939] Remove H5D__iterate and use H5S_select_iterate directlyJerome Soumagne2015-10-021-14/+22
| | | | | | | | | | Add internal library callback to H5S_select_iterate to avoid having to pass hid_t objects internally
* | [svn-r27929] merge from trunk.Mohamad Chaarawi2015-10-011-80/+80
|\ \ | |/
| * [svn-r27811] Description:Quincey Koziol2015-09-161-67/+70
| | | | | | | | | | | | | | | | | | | | | | Refactor property list code to "deep copy" properties in the correct way, retraining the rest of the library to copy & release things correctly. This cleans up another batch of memory leaks, etc. within the library. Tested on: MacOSX/64 10.10.5 (amazon) w/serial & parallel Linux/32 2.6.x (jam) w/serial & parallel (h5committest forthcoming)
| * [svn-r27768] Description:Quincey Koziol2015-09-141-5/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Complete revamp of package initialization/shutdown mechanism in the library. Each package now has a single init/term routine. This new way should avoid packages being re-initialized during library shutdown and is also be _much_ more proactive about giving feedback for resource leaks internal to the library. Introduces a new "module" header file for packages in the library (e.g src/H5Fmodule.h) which sets up some necessary package configuration macros for the FUNC_ENTER/LEAVE macros. (The VFL drivers have their own slightly modified version of this header, src/H5FDdrvr_module.h) Also cleaned up a bunch of resources leaks all across the library and tests, along with addressing many warnings, as I encountered them. Tested on: MacOSX/64 10.10.5 (amazon) w/serial & parallel Linux/64 3.10.x (kituo) w/serial & parallel Linux/64 2.6.x (ostrich) w/serial
| * [svn-r27618] Description:Quincey Koziol2015-08-291-4/+0
| | | | | | | | | | | | | | | | | | | | Align w/vds branch: Remove extraneous sieve buffer flush in chunk flush callback, and move error check out of the middle of retrieving properties for dataset. Tested on: MacOSX/64 10.10.5 (amazon) w/serial & parallel (h5committest forthcoming)
| * [svn-r27613] Description:Quincey Koziol2015-08-291-2/+4
| | | | | | | | | | | | | | | | | | Align w/vds branch: Move code for initializing contiguous datasets into layout 'init' callback. Tested on: MacOSX/64 10.10.5 (amazon) w/serial & parallel (h5committest forthcoming)
* | [svn-r27261] apply metadata enhancement patch that was based on the mdc 3 ↵Mohamad Chaarawi2015-06-211-0/+22
|/ | | | branch.
* [svn-r27198] Set "entire_chunk" to false in H5D__chunk_write() for point ↵Vailin Choi2015-06-121-4/+4
| | | | | | selection as duplicate points are not checked to determine that it is really an "entire chunk". The bug appears from running the mdset.c test. This is a short-term fix for the problem.
* [svn-r27133] - Add a new attribute function characterstic for format:Mohamad Chaarawi2015-06-011-9/+9
| | | | | | | | * H5_ATTR_FORMAT(X,Y,Z) __attribute__((format(X, Y, Z))) - Rename UNUSED attribute characterstic to H5_ATTR_UNUSED. - Rename NORETURN attribute characterstic to H5_ATTR_NORETURN tested with h5committest.
* [svn-r27073] Description:Quincey Koziol2015-05-151-2/+2
| | | | | | | | Clean up H5D interface, to align w/v3 metadata cache changes Tested on: MacOSX/64 10.10.3 (amazon) w/serial & parallel Linux/32 2.6.* (jam) w/serial & parallel
* [svn-r27058] Description:Quincey Koziol2015-05-131-136/+190
| | | | | | | | | | Convert internal chunk structures to use 'scaled' coordinates instead of absolute coordinates. Tested on: Mac OSX/64 10.10.3 (amazon) w/parallel & serial Linux 2.6.x/32 (jam) w/parallel & serial Linux 2.6.x/64 (koala) w/serial
* [svn-r27045] Renamed H5_ASSIGN_OVERFLOW() to H5_CHECKED_ASSIGN() and re-orderedDana Robinson2015-05-101-21/+21
| | | | | | the arguments to be in a more logical order. Tested on: h5committest
* [svn-r26996] Description:Quincey Koziol2015-05-021-8/+1
| | | | | | | | Eliminate unneccessary 'rdcc' field from common chunk info struct. Tested on: MacOSX/64 10.10.3 (amazon) w/serial & parallel (Too minor to require h5commitest)
* [svn-r26995] Description:Quincey Koziol2015-05-021-26/+32
| | | | | | | | | | Clean up chunk 'prune by extent' and flush code, and make the rehashing routine 'update cache' hold onto more chunks, instead of evicting them as aggressively. Tested on: MacOSX/64 10.10.3 (amazon) w/serial & parallel (h5committest forthcoming)
* [svn-r26993] Description:Quincey Koziol2015-05-021-32/+19
| | | | | | | | | Align w/incoming chunk performance changes, including some small performance improvements here, as well as a few minor general code cleanups. Tested on: Mac OSX/64 10.10.3 (amazon) w/serial & parallel (Too minor to require h5committest)
* [svn-r26843] Description:Quincey Koziol2015-04-191-3/+4
| | | | | | | | Minor code & warning cleanups. Tested on: MacOSX/64 10.10.2 (amazon) w/serial & parallel Linux/32 2.6.18 (jam) w/serial & parallel
* [svn-r26842] Description:Quincey Koziol2015-04-181-52/+27
| | | | | | | | | | Cache the dataset's rank & dimension sizes, instead of querying them frequently, to speed up various checks & algorithms. Also, a few minor cleanups. Tested on: MacOSX/64 10.10.2 (amazon) w/serial & parallel Linux/32 2.6.18 (jam) w/serial & parallel
* [svn-r26841] Description:Quincey Koziol2015-04-181-5/+3
| | | | | | | | Minor formatting cleanups and remove unused field from callback struct. Tested on: Mac OSX/64 10.10.2 (amazon) w/serial & parallel (Too minor to require h5committest)
* [svn-r26837] Description:Quincey Koziol2015-04-171-288/+454
| | | | | | | | | | Separate allocating chunk on disk from inserting the chunk record into the index. This allows a "SWMR-safe" insert/update of chunks (the chunk is always allocated -> written -> inserted/updated in the index). Tested on: Mac OSX/64 10.10.2 (amazon) w/parallel & serial Linux/32 2.6.18 (jam) w/serial & parallel
* [svn-r26757] Description:Quincey Koziol2015-04-071-57/+45
| | | | | | | | Minor typos & code cleanups Tested on: MacOSX/64 10.10.2 (amazon) w/serial & parallel (Too minor to require h5committest)
* [svn-r26213] Description:Quincey Koziol2015-02-181-71/+55
| | | | | | | | Minor code cleanups, to align with revise_chunks branch. Tested on: Mac OSX/64 10.10.2 (amazon) w/serial & parallel Linux/32 2.6.x (jam) w/serial
* [svn-r25766] Description:Quincey Koziol2014-11-031-2/+2
| | | | | | | | | | Revert r25273, 25283 & 25439 (the hyperslab improvement changes). They are buggy and it's taking me a long time to correct the problem. I'll check in a revised form of the changes when I've got them straightened out. Tested on: Mac OSX 10.10.0 (amazon) w/gcc 4.9.x, C++, FORTRAN Linux 2.6.x (jam) w/parallel
* [svn-r25524] remove usage of // comment styles.Mohamad Chaarawi2014-08-111-3/+4
|
* [svn-r25509] HDFFV-8878:Mohamad Chaarawi2014-08-041-40/+205
| | | | | | Make the fill value operation for chunked datasets in parallel collective/fast. tested with h5committest
* [svn-r25392] fix HDFFV-8761:Mohamad Chaarawi2014-07-031-2/+4
| | | | allocating space for zero-length chunked dataset and asserting.
* [svn-r25273] Description:Quincey Koziol2014-06-131-2/+2
| | | | | | | | | | | Bring in Chao/Neil/my changes to optimize hyperslab selection operations further, along with 3 new public API routines: H5Scombine_hyperslab(), H5Sselect_select() and H5Scombine_select(), along with many minor cleanups to the code and fixing a few compiler warnings. Tested on: Mac OSX/64 10.9.3 w/gcc 4.9.x and parallel w/OpenMPI (h5commttest forthcoming)
* [svn-r25197] Description:Quincey Koziol2014-05-171-3/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | Bring changes from hdf5_1_8_coverity branch back to trunk: r20878: Issue 76: Check if H5Tget_nmembers(type) fails and simply return(FALSE). Also move printf to after check. r20880: Issue 192: Create ret_val var set to -1. Add out label for failures to jump to, return ret_val at bottom. r20882: Fixes for coverity: 1) bug #1679: remove dead code in test/mf.c 2) bug #1680: remove dead code in tools/lib/h5diff_dset.c r20883: Fix coverity issue 585 Description: Changed variable "c" in processStrData in h5import.c to an int, to match fgetc return value, and removed call to feof, instead checking if c == EOF. Tested on: MacOSX/64 10.9.3 (amazon) w/C++, FORTRAN & parallel (too minor to require h5committest)
* [svn-r24769] Description:Quincey Koziol2014-03-071-33/+51
| | | | | | | | | Check in Mohamad's changes to support collective I/O on point selections, along with some other minor cleanups. Tested on: Mac OSX/64 10.9.2 (amazon) w/parallel & serial (h5committest forthcoming)
* [svn-r24709] rename H5V to H5VM since H5V is needed in the fastforward ↵Mohamad Chaarawi2014-02-131-16/+16
| | | | | | | | | | | | project for view objects. The addition of view objects in the fastforward project is expected to be brough into the trunk sometimes in the future, which is why we need to make this change. Tested Manually on Jam and Ostrich. Tested with h5commitest - Koala with intel compilers failed, but nothing had to do with those changes. error on Koala: error while loading shared libraries: libirng.so
* [svn-r23987] Merge r23939 from reduce_warning branch to trunkNeil Fortner2013-08-091-1/+0
| | | | | | | | | | | Tested: jam, koala, ostrich (h5committest) Log from r23939: Fix unused variables warnings in trunk Rename static functions in H5Adense.c, H5B2cache.c, H5Bcache.c Switch these functions to use FUNC_ENTER_STATIC* macros Tested: koala
* [svn-r23715] Bug Fix: HDFFV-8247Joel Plutchak2013-05-221-4/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | Description: Failure to write fill values to the user's buffer when reading unallocated chunks from datasets that have a fill value set to H5D_FILL_VALUE_DEFAULT. A consequence of this was the reporting of spurious data values in h5dump and h5diff output. Solution: Added check for fill value of H5D_FILL_VALUE_DEFAULT whenever fill value setting was checked to decide whether or not to fill. This effectively treats H5D_FILL_VALUE_DEFAULT the same as H5D_FILL_VALUE_USER rather than H5D_FILL_VALUE_UNDEFINED. Tested: h5committest (platypus, ostrich, jam-pp, koala) ran successfully (fillval test was modified to reveal and check for this error) Note: RELEASE.txt was previously changed to reflect this fix. This checkin was of a cleaner version of the code, but mostly to get this full log message entered. -This line, and those below, will be ignored-- M H5Dchunk.c
* [svn-r23713] Description:Quincey Koziol2013-05-211-5/+5
| | | | | | | | | | Clean up warnings, switch library code to use Standard C/POSIX wrapper macros, remove internal calls to API routines, update checkapi and checkposix scripts. Tested on: Mac OSX/64 10.8.3 (amazon) w/C++ & FORTRAN Big-Endian Linux/64 (ostrich)
* [svn-r23666] Fix for fill value problem for chunked files with mixed ↵Joel Plutchak2013-05-021-3/+5
| | | | allocated/unallocated chunks.
* [svn-r23461] add missing static declarations of rotuines.Mohamad Chaarawi2013-03-271-1/+1
| | | | tested on Jam - too minor for committest
* [svn-r23152] I took out the obsolete function H5PSIwrite_chunk and its ↵Raymond Lu2013-01-111-1/+1
| | | | | | related test and performance test. Tested on koala.
* [svn-r23075] I revised the code and test according to Quincey's review. I ↵Raymond Lu2012-12-041-3/+1
| | | | | | also added more test cases. Tested on koala.
* [svn-r23017] I added a prototype function H5DOwrite_chunk in HL library for ↵Raymond Lu2012-11-071-1/+1
| | | | | | | | | Dectris people to test performance. The library's API function H5PSIdirect_write is still in. I reorganized the internal library by adding H5D__pre_write function. Tested on koala.
* [svn-r22739] ported revisions 22615 to 22737 from the trunkRaymond Lu2012-09-051-1/+3
|\
| * [svn-r22646] Description:Quincey Koziol2012-08-081-1/+3
| | | | | | | | | | | | | | | | | | Changes resulting from Klocwork static analysis tool, from Mark Miller @ LLNL (miller86@llnl.gov). Tested on: Mac OS X/64 10.7.4 (amazon) w/debug, C++ & FORTRAN, using gcc 4.7.x (too minor to require h5committest)
* | [svn-r22641] Dectris project: I revised the code per Quincey's and Neil's ↵Raymond Lu2012-08-081-12/+16
| | | | | | | | | | | | comments. I added a performance benchmark program dectris_perf.c in the test/ directory. Tested on koala and jam.
* | [svn-r22616] The code for H5PSIdirect_write and its test dectris_tst.c.Raymond Lu2012-07-301-0/+100
|/ | | | Tested on koala and jam.
* [svn-r22601] Purpose: Fix HDFFV-5853Neil Fortner2012-07-251-1/+1
| | | | | | | | | | | | | | Description: When jumping out from between H5_BEGIN_TAG and H5_END_TAG macros using HGOTO_ERROR or HGOTO_DONE, the previous metadata tag is not reset on the dxpl. This could cause problems when, for example, calling H5Ocopy within an H5Literate callback. Added new HGOTO_ERROR_TAG and HGOTO_DONE_TAG macros which must be used in place of the above between H5_BEGIN_TAG and H5_END_TAG. Tested: jam, koala, ostrich (h5committest), durandal
* [svn-r22287] Description:Quincey Koziol2012-04-161-307/+313
| | | | | | | | Clean up more FUNC_ENTER/FUNC_LEAVE macros and move H5D & H5T code toward the final design (as exemplified by the H5EA & H5FA code). Tested on: Mac OSX/64 10.7.3 (amazon) w/debug & parallel
* [svn-r22122] Issue 7785 - Writing or reading many small chunks ran out of ↵Raymond Lu2012-03-221-1/+1
| | | | | | | | memory and caused seg fault. I added checks in two places to make sure the library returns error stack when it fails to allocate memory. I didn't add any test to the test suite since there is no good way to test it. But I tested and verified the error stack by hand. Tested on jam, koala, ostrich.
* [svn-r21919] Description:Quincey Koziol2012-02-091-49/+49
| | | | | | | | Refactor function name macros and simplify the FUNC_ENTER macros, to clear away the cruft and prepare for further cleanups. Tested on: Mac OSX/64 10.7.3 (amazon) w/debug, production & parallel
* [svn-r21789] Purpose: Fix HDFFV-7833Neil Fortner2011-12-011-1/+6
| | | | | | | | | | | | Description: When shrinking a chunked dataset, the library fills in the unused parts of chunks that have been shrunk. The fill value buffer allocated for this purpose had a maximum size of 1 MB, but the fill was performed in a single operation. Therefore, if the amount of unused space in a chunk after being shrunk was greater than 1 MB, the library would read off the end of the fill value buffer. Changed the maximum fill buffer size to be equal to the chunk size. Tested: durandal; jam, koala, heiwa (h5committest)
* [svn-r21603] Purpose: Add generic skip list implementationNeil Fortner2011-10-181-1/+1
| | | | | | | | | | | | | Description: Added new H5SL_TYPE_GENERIC skip list type, which uses void *'s as keys and a client-supplied callback for key comparison. This was added to support the upcoming "merge named datatype" feature for H5Ocopy, but may be used in other places as well. Also added testing. Also fixed a potential bug with the H5SL_TYPE_OBJ implementation, and added testing for that. Tested: jam, koala, heiwa (h5committest), durandal
* [svn-r20885] Description:Quincey Koziol2011-05-201-7/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bring Coverity changes back to trunk: r20340: Address coverity issue 248. Set freed pointer to NULL if realloc fails, then check for NULL before attempting to close array of handles stored in memory addressed by pointer. r20341: Added initialization udata.path = NULL; udata.visited = NULL; to prevent unintialized use after done: label. Do C-style initialization AFTER all variable definitions. r20342: Fix valgrind error in H5DUMP-XML-tall.h5 r20343: Addressed Coverity issue 591 - check the return value of H5S_SELECT_ITER_RELEASE. r20344: Added initialization udata.path = NULL; to prevent uninitialized used after done: label r20347: Purpose: Fix memory leak in overhead.c Description: Fixed leak in test() in overhead.c where array "had" was never freed. r20348: Addressed Coverity issue 705 - added prototype for resize_configs_are_equal to cache_common.h. r20392: Purpose: Fix coverity issues 1677 and 1678 Description: Added return value checking for 4 funciton calls in H5tools_get_symlink_info(). r20394: Purpose: Fix coverity issues 1674 and 1675 Description: Modified H5Epush2() and H5E_printf_stack() to keep track of whether va_start() has been called, and to call va_end() at the end if so. r20395: Should be H5MM_calloc(count * sizeof(void*)). Fixed --gh r20396: Should be H5MM_calloc(count * sizeof(void*)). Fixed. --gh Tested on: Mac OSX/32 10.6.7 (amazon) w/debug & production (h5committested on branch)
* [svn-r20588] Description:Quincey Koziol2011-04-211-1/+1
| | | | | | | | | Clean up code a bit, move new "terminate" VFD callback to new position in H5FD_class_t struct. Tested on: Mac OS X/32 10.6.7 (amazon) w/debug & production (h5committest not required on this branch)