summaryrefslogtreecommitdiffstats
path: root/src/H5FD.c
Commit message (Collapse)AuthorAgeFilesLines
* [svn-r5900] Purpose:Quincey Koziol2002-08-271-11/+115
| | | | | | | | | | | Code cleanup/New Feature Description: Improve the space allocation in the file by re-using freed space more effectively. Platforms tested: FreeBSD 4.6 (sleipnir) w/serial & parallel
* [svn-r5871] Purpose:Quincey Koziol2002-08-121-5/+3
| | | | | | | | | | | | | | | | Code cleanup Description: Combined H5P_isa_class and H5I_object functionality into a new internal H5P API function: H5P_object_verify, which checks that a property list is the appropriate class and then returns the property list object associated with the property list ID. This reduces the source code by about 200 LOC and trims the library binary some more. Platforms tested: FreeBSD 4.6 (sleipnir)
* [svn-r5867] Purpose:Quincey Koziol2002-08-091-1/+9
| | | | | | | | | | | | | Code cleanup Description: Changed the last HRETURN* statements in the FUNC_ENTER macros into HGOTO* macros, which reduces the size of the library binary in certain configurations by another 10% Platforms tested: FreeBSD 4.6 (sleipnir) serial & parallel, IRIX64 6.5 (modi4) serial & parallel
* [svn-r5842] Purpose:Quincey Koziol2002-08-081-292/+296
| | | | | | | | | | | | | | | | Code cleanup Description: Change most (all?) HRETURN_ERROR macros to HGOTO_ERROR macros, along with HRETURN macros to HGOTO_DONE macros. This unifies the error return path from functions and reduces the size of the library by up to 10% on some platforms. Additionally, I improved a lot of the error cleanup code in many routines. Platforms tested: FreeBSD 4.6 (sleipnir) serial & parallel and IRIX64 6.5 (modi4) serial & parallel.
* [svn-r5840] Purpose:Quincey Koziol2002-07-311-26/+14
| | | | | | | | | | | | | | Code cleanup Description: Created a new H5I function which combined the some of the functionality of H5I_get_type and H5I_object: H5I_object_verify. Using this new function in the library trims another ~200 lines of code off the library and makes the resulting binaries smaller and faster also. Platforms tested: FreeBSD 4.6 (sleipnir)
* [svn-r5799] Purpose:Quincey Koziol2002-07-151-1/+1
| | | | | | | | | | | | New feature. Description: Added MPI-posix VFL driver. This driver uses MPI to coordinate actions, but performs I/O directly with posix sec(2) I/O functions. This driver should _NOT_ be used if the file accessed is not on a parallel filesystem. Platforms tested: FreeBSD 4.6 (sleipnir) w/parallel & IRIX64 6.5 (modi4) w/parallel
* [svn-r5677] Purpose:Quincey Koziol2002-06-191-2/+2
| | | | | | | | | | | Code improvement Description: Some small code cleanups and took out the code the was turning off the metadata cache for parallel I/O (!) Platforms tested: IRIX64 6.5 (modi4) w/parallel
* [svn-r5589] Purpose:Quincey Koziol2002-06-111-2/+2
| | | | | | | | | | | | | | Bug fix. Description: H5P_get was reading a 'hsize_t' field into a 'size_t' variable, causing problems on the HP's and Windows. Solution: Changed the variable to be an hsize_t Platforms tested: HP/UX 11.0 (kelgia)
* [svn-r5562] Purpose:Quincey Koziol2002-06-101-3/+7
| | | | | | | | | | | Code cleanup Description: Allow H5FD_free to return successfully (but ignore) freeing objects with size 0. Platforms tested: FreeBSD 4.5 (sleipnir)
* [svn-r5551] Purpose:Quincey Koziol2002-06-071-2/+2
| | | | | | | | | | | | Bug fix. Description: Added extra check to locations where metadata and "small data" blocks were being returned to the file's list of free space to avoid freeing 0-sized blocks. This should fix the problems in last night's daily tests. Platforms tested: FreeBSD 4.5 (sleipnir)
* [svn-r5550] Purpose:Quincey Koziol2002-06-071-36/+47
| | | | | | | | | | | | | | | | | Code Improvement Description: Split the metadata accumulator code into two parts: one for allowing writes of the accumulator buffer during reads (when the buffer is dirty and needs to be flushed to disk in order to hold the new metadata being read in) and another for only allowing writes of the buffer during writes. This allows the MPI-I/O VFL driver to use the metadata accumulator (but only during writes) and benefit from the reduced number of metadata I/O operations that it brings. Platforms tested: IRIX64 6.5 (modi4) w/parallel
* [svn-r5542] Purpose:Quincey Koziol2002-06-061-15/+15
| | | | | | | | | | | | | | | | | Code cleanup/bug fix Description: Unused space in the file was being "dropped on the floor" when the metadata or "small data" block was moved to a new location in the file and there was unused space in the old block. Solution: Put the space left in the allocation block into the free list of space for the file. This allows it to be [potentially] reused and sometimes allows the file to be smaller. Platforms tested: Solaris 2.7 (arabica) w/FORTRAN and FreeBSD 4.5 (sleipnir) w/C++
* [svn-r5536] Purpose:Quincey Koziol2002-06-051-53/+129
| | | | | | | | | | | | | | | | | New feature. Description: Added a "small data" block allocation mechanism to the library, similar to the mechanism used for allocating metadata currently. See the RFC for more details: http://hdf.ncsa.uiuc.edu/RFC/SmallData/SmallData.html This reduces the number of I/O operations which hit the disk for my test program from 19 to 15 (i.e. from 393 to 15, overall). Platforms tested: Solaris 2.7 (arabica) w/FORTRAN and FreeBSD 4.5 (sleipnir) w/C++
* [svn-r5529] Purpose:Quincey Koziol2002-06-041-4/+36
| | | | | | | | | | | | | | | Code improvement Description: Now that the metadata accumulator is working correctly, the buffer size tends to get rather large and stay there. Solution: Put a throttle on the accumulator buffer to reduce its size back down when it isn't needed. Platforms tested: Solaris 2.7 (arabica) w/FORTRAN & FreeBSD 4.5 (sleipnir) w/C++
* [svn-r5521] Purpose:Quincey Koziol2002-06-041-11/+36
| | | | | | | | | | | | | | | | | | | | | | | Code improvement Description: The metadata aggregation code in the library was not terribly smart about extending contiguous regions of metadata in the file and would not extend them as far as possible. This causes space in the file to be wasted, also. Solution: Be smarter about extending the space used in the file for metadata by checking whether new metadata blocks allocated in the file are at the end of the current metadata aggregation region and append them to the metadata region if so. This has the nice side benefit of reducing the number of bytes we waste in the file and reducing the size of the file by a small amount in some cases. This reduces the number of I/O operations which hit the disk for my test program from 53 to 19 (i.e. from 393 to 19, overall). Platforms tested: Solaris 2.7 (arabica) w/FORTRAN and FreeBSD 4.5 (sleipnir) w/C++
* [svn-r5510] Purpose:Quincey Koziol2002-06-031-57/+100
| | | | | | | | | | | | | | | | | | | | | | | | Code cleanup/bug fix Description: The "metadata accumulator" cache in the library (which is designed to catch small metadata writes/reads and bundle them together into larger I/O buffers) was incorrectly detecting the important case of metadata pieces being written sequentially to the file, adjoining but not overlapping. Additionally, the metadata accumulator was not being used to cache data read in from disk, only caching writes. Solution: Fix accumulator to correctly cache adjoining metadata writes and also to cache metadata read from disk. Between these two fixes, the number of I/O requests which resulted in actual reads/writes to the filesystem dropped from 393 requests to 82 for the particular test I was using. :-) Platforms tested: Solaris 2.7 (arabica) w/FORTRAN & FreeBSD 4.5 (sleipnir) w/C++
* [svn-r5471] Purpose:Quincey Koziol2002-05-291-40/+45
| | | | | | | | | | | | | | | | Code cleanup Description: Broke the FUNC_ENTER macro into several macros, with more specialized uses (which followup mail will describe). This was designed to move most/all of the checks which could be done at compile time to that point, instead of needlessly performing them (over & over :-) at run-time. This reduces the library's size (and thus staticly linked binaries) and has a minor speedup effect also. Platforms tested: IRIX64 6.5 (modi4) with parallel & FORTRAN enabled, and additional testing on FreeBSD and Solaris immediately after the checkin.
* [svn-r5467] Purpose:Quincey Koziol2002-05-281-4/+8
| | | | | | | | | | | | | | | | | | | | | | | | Code cleanup. Description: Took Robb's recent ideas for improving the FUNC_ENTER/FUNC_LEAVE macros equivalents in the SAF library and adapted them to our library. I added an additional macro which is equivalent to FUNC_ENTER: FUNC_ENTER_NOINIT - Has the API tracing code, etc. from FUNC_ENTER but none of the library or interface initialization code. This is to be used _only_ for static functions and those which explicitly cannot have the library or interface initialization code enabled (like the API termination routines, etc.). This allowed many more of the functions in the library [but not all yet :-(] to be wrapped with FUNC_ENTER[_NOINIT]/FUNC_LEAVE pairs. It also reduced the size of the library and executables (by cutting out a bunch of code which was never executed), I'll e-mail the exact results when I've finished editing it. Platforms tested: IRIX64 6.5 (modi4)
* [svn-r5452] Pedro Vicente Nunes2002-05-221-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Purpose: eliminating the compiler warnings in Windows Solution: I am eliminating the compiler warnings in Windows. the last 2 were: 1) if((oid_list = H5MM_malloc(oid_count*sizeof(hid_t)))==NULL) HGOTO_ERROR(H5E_RESOURCE, H5E_NOSPACE, NULL, "memory allocation failed"); D:\disk_w\hdf5\src\H5F.c(2590) : warning C4047: '=' : 'int ' differs in levels of indirection from 'void *' on the HGOTO_ERROR call , I replaced the NULL with FAIL 2) *((float*)d) = *((double*)s); D:\disk_w\hdf5\src\H5Tconv.c(6426) : warning C4244: '=' : conversion from 'double ' to 'float ', possible loss of data I added the type cast *((float*)d) = (float) *((double*)s); we have now 0 errors 0 warnings on Windows ! Platforms tested: w2000, linux
* [svn-r5444] Purpose:Quincey Koziol2002-05-201-2/+2
| | | | | | | | | | Code cleanup Description: Clean up warnings on IRIX64 6.5 (modi4) Platforms tested: IRIX64 6.5 (modi4)
* [svn-r5440] Purpose:Quincey Koziol2002-05-201-4/+8
| | | | | | | | | | | New feature Description: Add 'closing' parameter to H5FDflush and VFL "flush" functions, per http://hdf.ncsa.uiuc.edu/RFC/VFLFlush/VFLFlush.html Platforms tested: IRIX64 6.5 (modi4)
* [svn-r5403] Purpose:Quincey Koziol2002-05-131-5/+3
| | | | | | | | | | Back out changes. Description: Back out changes to VFL 'flush' API function, pending review. Platforms tested: IRIX64 6.5 (modi4)
* [svn-r5393] Purpose:Quincey Koziol2002-05-101-3/+5
| | | | | | | | | | | | | | | | | | | | | | New Feature Description: The VFL flush function is called immediately before a file is closed. This can cause duplicate syncronization actions to occur, if the VFL close function also performs them. Solution: Added 'closing' parameter to VFL 'flush' operation. This allows the VFL flush function to bypass operations that will be duplicated within the VFL close function. Additionally, use the 'closing' parameter to bypass calls to MPI_File_sync() when set. Since MPI_File_close() also syncronizes the file, this avoids the terrible performance hit taken when calling MPI_File_sync() as the file is closing. Platforms tested: IRIX64 6.5 (modi4)
* [svn-r5096] Purpose:Quincey Koziol2002-03-271-0/+57
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bug Fix Description: The H5Gget_objinfo() function was not setting the 'fileno' field in the H5G_stat_t struct passed in. Solution: Added a "file serial number" to each file currently open in the library and put that in the 'fileno' field. If a file is opened twice (with H5Fopen) and the VFL driver detects that it is the same file (i.e. the two file structures have the same "shared file info" in the library's memory structures), they will have the same serial number. This serial number has two drawbacks: - If a VFL driver doesn't/can't detect that two calls to H5Fopen with the same file actually _are_ the same file, each will get a different serial number - If the same file is closed and re-opened, the serial number will be different. It is be possible to fix the second drawback for many VFL drivers, but it would be a lot of effort and probably isn't worth it until we've got a good reason to do it. Dunno if we'll ever be able to fix the first drawback... Platforms tested: FreeBSD 4.5 (sleipnir) VS: ----------------------------------------------------------------------
* [svn-r4851] Purpose:Quincey Koziol2002-01-231-70/+135
| | | | | | | | | | | | | | | | | | Bug Fix Description: When file space was returned to the file space free-list for reuse, occasionally raw data allocations which used space from the free-list would overlap with the metadata accumulator and get over-written with the cached information in the accumulator, corrupting the data. Solution: Check if the space about to be recycled on the free-list is going to be used for raw data and also overlaps with the metadata accumulator cache, avoiding using space that fits those criteria. This fixes bug #701 Platforms tested: FreeBSD 4.5 (sleipnir)
* [svn-r4650] Purpose:Quincey Koziol2001-11-271-1/+1
| | | | | | | | Bug fix Description: Fix another typo from today's big "overflow" commit. Platforms tested: Solaris 2.6 (baldric)
* [svn-r4643] Purpose:Quincey Koziol2001-11-271-6/+15
| | | | | | | | | | | | | | | | | | | | | | Code cleanup Description: Windows is generating hundreds of warnings from some of the practices in the library. Mostly, they are because size_t is 32-bit and hsize_t is 64-bit on Windows and we were carelessly casting the larger values down to the smaller ones without checking for overflow. Also, some other small code cleanups,etc. Solution: Re-worked some algorithms to eliminate the casts and also added more overflow checking for assignments and function parameters which needed casts. Kent did most of the work, I just went over his changes and fit them into the the library code a bit better. Platforms tested: FreeBSD 4.4 (hawkwind)
* [svn-r4620] Purpose:Quincey Koziol2001-11-201-45/+42
| | | | | | | | | Code cleanup Description: Get rid of IDs from internal function calls and some small cleanups from the old-stype => generic property list conversion. Platforms tested: FreeBSD 4.4 (hawkwind)
* [svn-r4569] Raymond Lu2001-10-241-34/+46
| | | | | | | | | Purpose: Generic Property List Change Description: Changed file access list to the new generic list. Platforms tested: IRIX64, SunOS5.7, FreeBSD
* [svn-r4482] Purpose:Quincey Koziol2001-09-261-6/+6
| | | | | | | | | | | | | | | | | | | | | | Kludge Description: Since we're only about halfway through converting the internal use of property lists from the "old way" to the generic property lists, we turned off snapshots to avoid exposing lots of API changes to users, until the APIs settled down. Getting the snapshots rolling again seems to have become a priority, so some changes are going to have to be made now that were going to be postponed until we were completely finished with the conversion. This requires that the old API functions be able to deal with both the old and new property lists smoothly. Solution: Kludge together the property list code so that they can transparently handle dealing with both the old and new property lists Platforms tested: FreeBSD 4.4 (hawkwind)
* [svn-r4473] Purpose:Quincey Koziol2001-09-251-2/+2
| | | | | | | | | | | | | | | | | | | | | Code cleanup for better compatibility with C++ compilers Description: C++ compilers are choking on our C code, for various reasons: we used our UNUSED macro incorrectly when referring to pointer types we used various C++ keywords as variables, etc. we incremented enum's with the ++ operator. Solution: Changed variables, etc.to avoid C++ keywords (new, class, typename, typeid, template) Fixed usage of UNUSED macro from this: char UNUSED *c to this: char * UNUSED c Switched the enums from x++ to x=x+1 Platforms tested: FreeBSD 4.4 (hawkwind)
* [svn-r4355] Purpose:Quincey Koziol2001-08-141-8/+8
| | | | | | | | | | | | | | | | | | | | | | Code cleanup (sorta) Description: When the first versions of the HDF5 library were designed, I remembered vividly the difficulties of porting code from a 32-bit platform to a 16-bit platform and asked that people use intn & uintn instead of int & unsigned int, respectively. However, in hindsight, this was overkill and unnecessary since we weren't going to be porting the HDF5 library to 16-bit architectures. Currently, the extra uintn & intn typedefs are causing problems for users who'd like to include both the HDF5 and HDF4 header files in one source module (like Kent's h4toh5 library). Solution: Changed the uintn & intn's to unsigned and int's respectively. Platforms tested: FreeBSD 4.4 (hawkwind)
* [svn-r4324] Purpose:Quincey Koziol2001-08-101-52/+39
| | | | | | | | | | | | | | | | | | | | | | | | New Features! Description: Start migrating the internal use of property lists in the library from the older implementation to the new generic property lists. Currently, only the dataset transfer property lists are migrated to the new architecture, all the rest of the property list types are still using the older architecture. Also, the backward compatibility features are not implemented yet, so applications which use dataset transfer properties may need to make the following changes: H5Pcreate(H5P_DATASET_XFER) -> H5Pcreate_list(H5P_DATASET_XFER_NEW) and H5Pclose(<a dataset transfer property list>) -> H5Pclose_list(id) This still may have some bugs in it, especially with Fortran, but I should be wrapping up those later today. Platforms tested: FreeBSD 4.4 (hawkwind)
* [svn-r4276] Purpose:Quincey Koziol2001-07-301-8/+8
| | | | | | | | | | | | | Bug Fix Description: In certain circumstances, raw data was inadvertantly attempted to be read from the metadata cache. This was caught with an assertion failure (i.e. core dump) in the development branch or an eventual sequence of errors in the release branch. Solution: Corrected off-by-one error in metadata caching code. Platforms tested: FreeBSD 4.3 (hawkwind)
* [svn-r4213] Purpose:Quincey Koziol2001-07-161-2/+2
| | | | | | | | | | | Bug fix... (sorta) Description: Added --enable-linux-lfs configure flag to have better control over whether the enable large file support on Linux machines. Also removed the -malign-double flag for gcc since it can potentially cause errors which are difficult to detect. Platforms tested: Linix 2.2 & 2.4 (eirene and dangermouse)
* [svn-r4181] Purpose:Quincey Koziol2001-07-101-30/+26
| | | | | | | | | Bug Fix, Code Cleanup, Code Optimization, etc. Description: Fold in the hyperslab speedups, clean up compile warnings and change a few things from using 'unsigned' or 'hsize_t' to use 'size_t' instead. Platforms tested: FreeBSD 4.3 (hawkwind), Solaris 2.7 (arabica), Irix64 6.5 (modi4)
* [svn-r4012] Purpose:Quincey Koziol2001-06-181-4/+4
| | | | | | | | Clean up compiler warnings. Description: Just code neatening mostly, some casts, etc. Platforms tested: FreeBSD 4.3 (hawkwind)
* [svn-r3993] Purpose:Quincey Koziol2001-06-111-8/+8
| | | | | | | | | | | | | Bug fix for Pablo integration Description: Several API functions were using FUNC_ENTER, without using FUNC_LEAVE, HRETURN or HRETURN_ERROR to leave the function. (Using "plain" 'return' statements instead). Solution: Changed return statements to FUNC_LEAVE, HRETURN or HRETURN_ERROR, as appropriate. Platforms tested: FreeBSD 4.3 (hawkwind)
* [svn-r3983] Purpose:Quincey Koziol2001-06-111-10/+10
| | | | | | | | | Code cleanups Description: Fixed a small number of warnings and also took out the H5private.h header from H5Ppublic.h Platforms tested: FreeBSD 4.3 (hawkwind)
* [svn-r3885] Purpose:Quincey Koziol2001-05-021-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | Document bug fix Description: IMPORTANT! IMPORTANT! IMPORTANT! A case where metadata in a file could get corrupted in certain unusual sitations was detected and fixed. In certain circumstances, metadata could get cached in the raw data cache, and if that particular piece of metadata was updated on disk while incorrectly cached, the new metadata would get overwritten with the stale metadata from the raw data cache when it was flushed out. Additionally, I've patched up the raw data cache to be smarter about how much it caches and how much I/O it triggers, leading to some speedups. Solution: Changed the raw data I/O routines which perform caching to require a parameter with the size of the dataset being accessed and limited the cache to no more than that many bytes. Platforms tested: FreeBSD 4.3 (hawkwind)
* [svn-r3881] Purpose:Albert Cheng2001-05-011-28/+171
| | | | | | | | | | | | Feature Description: The allocation by alignment (H5Pset_alignment) feature code somehow got dropped in some 1.3.x version. Solution: Re-implemented it with "new and improved" algorithm. It keeps track of "wasted" file-fragment in the free-list too. Platforms tested: modi4(parallel).
* [svn-r3781] Purpose:Bill Wendling2001-04-051-10/+10
| | | | | | | | | | | | | | | | | | Update Description: Changed #include <hdf_file.h> construct to #include "hdf_file.h" so that the GNU compiler can more easily pick up the dependencies which it places in the .depend and Dependencies files. Also regenerated the Dependencies to go along with this. Platforms tested: Linux
* [svn-r3252] Purpose:Quincey Koziol2001-01-091-12/+23
| | | | | | | | | | | | | Code cleanup. Description: Fixed _lots_ (I mean _tons_) of warnings spit out by the gcc with the extra warnings. Including a few show-stoppers for compression on IRIX machines. Solution: Changed lots of variables' types to more sensible and consistent types, more range-checking, more variable typecasts, etc. Platforms tested: FreeBSD 4.2 (hawkwind), IRIX64-64 (modi4)
* [svn-r3213] ./hdf5/src/H5FD.cRobb Matzke2000-12-291-5/+6
| | | | | | | | | | | 2000-12-29 09:06:02 Robb Matzke <matzke@llnl.gov> * H5FD_query: Marked `flags' argument as /*out*/ 2000-12-29 09:05:49 Robb Matzke <matzke@llnl.gov> * H5FDquery: Marked `flags' argument as /*out*/ 2000-12-29 09:03:39 Robb Matzke <matzke@llnl.gov> * H5FD_open: Reindented a line or two.
* [svn-r3005] Purpose:Quincey Koziol2000-11-271-5/+5
| | | | | | | | Backward compatibility code Description: Add in code to allow the library to emulate the v1.2 API and behavior. Platforms tested: FreeBSD 4.2 (hawkwind)
* [svn-r2990] Purpose:Albert Cheng2000-11-211-0/+16
| | | | | | | | | | | | | | | | | | | | | Bug fix (feature, kind of) Description: The library used to hang if a collective dataset read/write request does not have the same number of eventual MPIO request. Part of the reason is that H5FD_read/H5FD_write immediately returns succeess if it sees the request size is 0. This caused problem since other processes with I/O to do would be hanging by waiting for the early returned process(es). Solution: H5FD.c: disable the early return code in parallel mode. Make it go on even with "nothing" to transfer. H5D.c: the optimized MPIO xfer routines can handle collect calls correctly when the condition is right (e.g., no conversion). When the COLLECTIVE request cannot be handled correctly without the risk of hanging, the COLLECTIVE is changed to INDEPENDENT calls for the eventual MPIO calls. Platforms tested: IRIX64 parallel (-64, n32), IRIX64 -64 sequential, Linux sequential.
* [svn-r2852] ./hdf5/src/H5FD.cRobb Matzke2000-11-101-5/+7
| | | | | | | * 2000-11-10 Robb Matzke <matzke@llnl.gov> (H5FD_close) Removed code that resets the H5FD_t file structure to zero because that struct has already been freed. This fixes a core dump on some platforms.
* [svn-r2774] H5FD.c:Albert Cheng2000-10-311-1/+1
| | | | | | | | | | | | | | | | | | | | Purpose: Bug fix Description: H5FD_close() wiped clean the public information before closing the FD. This caused problem to the lower level close() which wants to verify it has indeed handed a valid file-driver to close because that information is wiped out prematurely. Solution: Moved the public information part cleaning after it is closed. H5FDmpio.c: Added in a bunch of assertion to make sure the file handle is indeed an MPIO file. Platforms tested: IRIX64 -64 parallel
* [svn-r2764] ./hdf5/src/H5FD.cRobb Matzke2000-10-311-1/+1
| | | | Updated API tracing calls.
* [svn-r2722] Purpose:Quincey Koziol2000-10-241-7/+10
| | | | | | | | | | Feature symmetry Description: A while ago I needed to get the 'type' of data being accessed during writes to the VFL driver, so I put in code to get the information down there. Albert asked for the same information during reads, so I've added that in. Tested: FreeBSD 4.1.1 (hawkwind)
generated by cgit v0.12 at 2024-11-03 14:45:43 (GMT)