| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Bring r18076-18096 from hdf5_1_8_coverity branch to trunk:
r18076:
Correct Coverity issue #1 by removing dead code
r18077:
Fix coverity item 142. When an error occurred while copying a linked list in
H5S_point_copy, the library would not free the partially allocated list. Added
code to free the list in this case.
r18078:
Correct Coverity issue #2 by removing impossible to reach code.
r18079:
Correct #3 by removing impossible to reach code.
r18080:
Correct Coverity issue #4 by removing impossible to reach code.
r18081:
fix coverity 26 , check (dblik->parent) before calls H5HF_man_iblock_detach().
r18082:
Fixed coverity issues 321 and 316.
321: freed sm_buf in error handling to remove resource leak.
Also set sm_buf to NULL after other instances in which
it is freed to prevent double free.
316: initialized nmembs to 0.
r18083:
Correct Coverity issue #6 by removing debugging knob from error reporting code.
r18084:
Fix coverity item 269 + others. When a error occurred in a function using the
h5tools error framework, the "past_catch" variable would not be set to true
because that statement was before the label that goto jumped to. This could
cause a failure in the cleanup section to go back to the start of the section,
freeing variables twice, etc.
Moved the label infront of past_catch=TRUE.
r18085:
fixed coverity #27, check if (heap) before use heap->obj....
r18086:
fixed coverity #28, check curr_span not null before use it at if(curr_span &&
(io_bytes_left==0 || curr_seq>=maxseq))
r18087:
Correct Coverity issue #7 by cleaning up correctly on error
r18088:
Correct Coverity #8 by removing unchanged variable checking code.
r18089:
Correct Coverity issue #9 - remove impossible to reach code.
r18090:
Correct Coverity issue #11 by removing impossible to reach code. Also clean
up some minor style issues.
r18091:
Fix coverity items 314 and 318. Changed the improper assertion of the return
value of a library function to a check, and a return(void) on failure.
r18092:
Fix coverity item 70. Changed the improper assertion of the return value of a
library function to a check, and a return(void) on failure.
r18093:
Correct Coverity issue #12 by removing dead code.
r18094:
Correct Coverity issue #16 by removing debugging code.
r18095:
Fixed coverity issue # 271.
Removed redundant checking and freeing of sm_buf1 and sm_buf2.
r18096:
Correct Coverity issue #17 by refactoring test to remove dead code.
Also, removed previous "coverity" statements in comments, we'll review
those issues again and see if we can figure them out, now that we have more
experience with Coverity.
Tested on:
Mac OS X/32 10.6.2 (amazon)
|
| |
|
|
|
|
|
|
|
|
|
| |
Description:
Previously, there was no versioning for H5Z_class_t. This prevented applications
written for 1.6 using custom filters from being able to use the 1.8 library.
There is now an H5Z_class1_t and H5Z_class2_t to enable compatibility. H5Zregister is
*not* versioned, it determines which version of the struct has been passed in by the
value of the first field (id or version, both are ints).
Tested: jam, linew, smirom (h5committest), jam (--with-default-api-version=v16)
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
Bug fix (#1357)
Description:
Three filters have not assigned correct value to one value-result argument, "buf_size". N-bit, szip, and scale offset filter have had this problem.
However, I don't think this problem has been making buffer overrun because those filters were informing the caller that the "buf", another value-result argument, is smaller than it actually is. If there was actual buffer overrun, I believe another problem exists although I don't know.
Tested:
jam, smirom, linew
Although all test were passed, I'm concerned about valgrind memcheck error. There can be another miscommunication between filter and the caller.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Small clean up of datatype copying.
Tested on:
FreeBSD/32 6.2 (duty) in debug mode
FreeBSD/64 6.2 (liberty) w/C++ & FORTRAN, in debug mode
Linux/32 2.6 (kagiso) w/PGI compilers, w/C++ & FORTRAN, w/threadsafe,
in debug mode
Linux/64-amd64 2.6 (smirom) w/default API=1.6.x, w/C++ & FORTRAN,
in production mode
Linux/64-ia64 2.6 (cobalt) w/Intel compilers, w/C++ & FORTRAN,
in production mode
Solaris/32 2.10 (linew) w/deprecated symbols disabled, w/C++ & FORTRAN,
w/szip filter, in production mode
Mac OS X/32 10.5.3 (amazon) in debug mode
Linux/64-ia64 2.4 (tg-login3) w/parallel, w/FORTRAN, in production mode
|
| |
|
|
|
|
|
|
| |
Correct another case of using 'size_t' for chunk sizes where 'uint32_t'
was necessary.
Tested on:
FreeBSD/64 6.2 (liberty) w/C++ & FORTRAN
|
| |
|
|
|
|
|
|
| |
on the h5repack verify function
note: some sybols were made public
tested: windows, linux
|
| |
|
|
|
|
| |
needed by h5repack
tested: windows, linux
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Make H5Pget_filter_by_id() API versioned and switch internal usage
to H5Pget_filter_by_id2().
Add simple regression test for H5Pget_filter_by_id1().
Tested on:
FreeBSD/32 6.2 (duty) in debug mode
FreeBSD/64 6.2 (liberty) w/C++ & FORTRAN, in debug mode
Linux/32 2.6 (kagiso) w/PGI compilers, w/C++ & FORTRAN, w/threadsafe,
in debug mode
Linux/64-amd64 2.6 (smirom) w/default API=1.6.x, w/C++ & FORTRAN,
in production mode
Linux/64-ia64 2.6 (cobalt) w/Intel compilers, w/C++ & FORTRAN,
in production mode
Solaris/32 2.10 (linew) w/deprecated symbols disabled, w/C++ & FORTRAN,
w/szip filter, in production mode
Mac OS X/32 10.4.10 (amazon) in debug mode
|
| |
|
|
|
|
|
|
|
| |
copyright notice.
Tested platform:
Kagiso only since it is only a comment block change. If it works in one
machine, it should work in all, I hope. Still need to check the parallel
build on copper.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
Finish new version of the I/O pipeline message, which is much smaller than
the previous version. This version is used with the "use the latest version
of the format" flag.
Closed several memory leaks/overruns (found with valgrind).
Also, lots of compiler & formatting cleanups.
Tested on:
Linux/32 2.6 (chicago)
Linux/64 2.6 (chicago2)
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Code cleanup
Description:
Trim trailing whitespace, which is making 'diff'ing the two branches
difficult.
Solution:
Ran this script in each directory:
foreach f (*.[ch] *.cpp)
sed 's/[[:blank:]]*$//' $f > sed.out && mv sed.out $f
end
Platforms tested:
FreeBSD 4.11 (sleipnir)
Too minor to require h5committest
|
| |
|
|
|
|
|
|
|
|
|
| |
Code cleanup
Description:
Clean up some compiler warnings
Platforms tested:
FreeBSD 4.11 (sleipnir)
h5committest
|
| |
|
|
|
|
|
|
|
|
|
| |
Code cleanup
Description:
Clean up some compiler warnings.
Platforms tested:
FreeBSD 4.11 (sleipnir) w/gcc 4.0
Too minor to require h5committest
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Bug fix.
Description:
One call to macro HGOTO_ERROR passes wrong value to ret_value.
Solution:
Change the value from zero to FAIL.
Platforms tested:
heping
Misc. update:
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Bug fix.
Description:
The current HDF5 library call H5Tget_size when called by the filter
does not give the correct disk size for varible-length and variable-length
string. The filter needs to have another way, if possible, to get their
sizes.
Solution:
The filter can only solve this problem if varible-length and variable-length
string is a member of compound datatype. The filter does not support the
situation where an array datatype has variable-length or variable-length
string as its base datatype.
Platforms tested:
heping, shanti
Misc. update:
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
New feature.
Description:
The nbit filter does not support situations where datatype of string,
time, enum, variable-length, bitfield, opaque, reference is a field of
a compound datatype or array datatype.
Solution:
Modify the nbit filter to hanle such situations. The filter is a no-op
to these dataytypes.
Platforms tested:
copper, heping.
Misc. update:
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Bug fix.
Description:
The nbit filter does not check error when calling some utility functions
that can return a failure.
Solution:
Add error handling for these utility functions.
Platforms tested:
heping, copper
Misc. update:
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Modifications of nbit filter.
Description:
The nbit filter does not support datatypes other than integer,
floating-point as well as array datatype and compound datatype consisting
of integer or floating-point.
Solution:
Change the nbit filter to accept all datatype at the top level, and if
the datatype is not what described above, the filter will not do anything
to the data instead of generating errors.
Slight improvements of the filter's performance.
Platforms tested:
heping, copper
Misc. update:
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
Very slight modification.
Description:
Remove two redundant local macros.
Solution:
Platforms tested:
heping
Misc. update:
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
bug fix plus minor modifications
Description:
The nbit filter makes a wrong assumption that function H5Z_set_local_nbit
and H5Z_filter_nbit will be called together. It uses 2 local variables
outside these functions to pass information from H5Z_set_local_nbit to
H5Z_filter_nbit.
Solution:
Store the two variables in cd_values[], which can be retrieved when
H5Z_filter_nbit is called independently.
Platforms tested:
heping, copper
Misc. update:
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Tests modification and improvements of nbit filter.
Description:
Add dynamic allocation of array storing nbit parameters and check if
the number of parameters exceeds what cd_values[] can store; change
function prototypes to improve poratability; minor modification to
improve efficiency of the nbit algorithm.
Platforms tested:
AIX 5.1 and Linux 2.4.
Misc. update:
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
Description: Removed PABLO from the source
Solution:
Platforms tested: arabica with 64-bit, copper with parallel,
heping with GNU C and C++ and PGI fortran (but
I disabled hl, there is some weird problem only
on heping: F9XMODFLAG is not
propagated to the Makefile files
Misc. update:
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For N-bit filter,
Adding parameter mappings from HDF5 compound datatype, array datatype and atomic datatype
to cd_values inside HDF5 library.
N-bit filter should work with these datatypes(string and variable length datatype haven't been
considered) in the near future.
Description:
This is for debugging purpose, N-bit filter won't be tested in the daily test.
Solution:
Platforms tested:
AIX 5.1 and Linux 2.4. Arabica is too slow. Hopefully shanti can be used soon.
Misc. update:
|
| |
|
|
|
|
|
|
|
|
| |
Description:
Solution:
Platforms tested:
Misc. update:
|
|
|
To add n-bit implementation inside HDF5.
Description:
This check-in for implementation is for debugging purpose.
N-bit filter should be used for the time being.
Solution:
Platforms tested:
sol 2.7, Linux 2.4, Aix 5.1
Misc. update:
|
