summaryrefslogtreecommitdiffstats
path: root/src/H5private.h
Commit message (Collapse)AuthorAgeFilesLines
* Removes -Wimplicit-fallthrough=5 from the gcc warningsDana Robinson2020-10-221-0/+4
| | | | | | | | | | | | -Wimplicit-fallthrough=3 is added by -Wextra, which we already set. Bumping the warning level only changes how fall-through comments are parsed, with level 5 turning off fall-through comments entirely. This is unnecessary and results in having to do extra work to squash warnings when included external code uses fall-through. This change also adds /* FALLTHROUGH */ comments where H5_ATTR_FALLTHROUGH is used so compilers that don't use attributes but do respect fall-through comments don't raise spurious warnings.
* Clang-format of source filesAllen Byrne2020-09-301-1299/+1331
|
* Merge remote-tracking branch 'hdffv/develop' into rebased-fprintf-experimentDavid Young2020-09-031-3/+6
|\
| * Trivialities noticed while merging things to 1.10Dana Robinson2020-08-151-1/+1
| |
| * Merge remote-tracking branch 'origin/develop' into namespace_cleanup_01Quincey Koziol2020-08-071-2/+2
| |\
| | * Squash merge of file locking fixesDana Robinson2020-08-031-2/+2
| | |
| * | Clean up private / package / static namespace issues (function naming, whichQuincey Koziol2020-08-061-1/+4
| |/ | | | | | | | | | | header file, FUNC_ENTER / LEAVE, etc). Removed remaining personal email addresses from library source code (still needs cleaned from other directories). Misc. warning, style, and whitespace cleanup.
* | Squash my changes on branch `fprintf-experiment` into one commit forDavid Young2020-07-071-5/+9
|/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | reapplication to my new warnings branch, `warnings-again`. These changes are included: commit 915551b7bf64e777dd2007386ec77b1d117770da Merge: 63858c2 a8892bb Author: David Young <dyoung@hdfgroup.org> Date: Mon Nov 25 17:39:49 2019 -0600 Merge remote-tracking branch 'hdf5/develop' into fprintf-experiment commit a8892bb42d6f6e4fbc30fae0eb2b957f81c938b9 Merge: 5c911d8 f907b51 Author: David Young <dyoung@hdfgroup.org> Date: Mon Nov 25 17:33:54 2019 -0600 Merge pull request #2055 in HDFFV/hdf5 from ~DYOUNG/vchoi_fork:add-werror-and-squash-some to develop * commit 'f907b511d06612dafc7814a7c30f2f3d2b76d52b': Oops, remove more C99 designated initializers for VS 2010 compatibility. commit 63858c22e168acaec0af8ced6641f26102cc6bb0 Merge: 20ae787 5c911d8 Author: David Young <dyoung@hdfgroup.org> Date: Mon Nov 25 17:04:42 2019 -0600 Merge remote-tracking branch 'hdf5/develop' into fprintf-experiment commit 5c911d8baf3ee7fe654269088eebdf07f59a8192 Merge: b8a5671 62208b0 Author: David Young <dyoung@hdfgroup.org> Date: Mon Nov 25 16:58:27 2019 -0600 Merge pull request #2030 in HDFFV/hdf5 from ~DYOUNG/vchoi_fork:add-werror-and-squash-some to develop * commit '62208b056a09c01855fbac7f75146be58ad6bfe5': (44 commits) Add an #include to get a function declaration. Don't use C99 designated initializers, they're not compatible with Visual Studio 2010. Quiet some more maybe-uninitialized warnings---each is a false positive, *sigh*. This is more code that may not compile with VS2010, *sigh sigh*. Always warn on maybe-uninitialized. -Wincompatible-pointer-types was not available until GCC 5, so enable it only if that's the GCC version we're using. Only promote maybe-uninitialized warnings to errors on GCC 8. Even on GCC 8, there may be false positives at low optimization levels? I need to check. Only use -Werror=cast-function-type with GCC 8 and later. Put all of the -W options back into the order I found them in so that it's easier to compare old and new config/gnu-flags. Add new source files to CMakeLists.txt. Mention the -Werror= flags in libhdf5.settings.in. free -> HDfree Promote decleration-after-statement warnings to errors. Quiet decleration-after-statement warnings. Move a statement under some declarations since some vintages of Visual Studio don't like declarations after statements. Document H5D__chunk_mem_xfree_wrapper(). Undo accidental test deletion. Oops, delete a debug printf that snuck in here. Undo my changes to the HD macros, hadn't really intended those to be on this branch.... Make errors of some more warnings. Move disabled warnings to DEVELOPER_WARNING_CFLAGS. Put just one warning option on a line, and sort some of the options. Cast to the parameter type, H5VL_token_t *, instead of to unsigned char *. Change hdset_reg_ref_t and H5R_ref_t from arrays of unsigned char to structs containing those arrays. Encapsulating the arrays in this way makes it easier to write and think about pointers to these types, casts to/from these types, etc. ... commit 20ae7877e33931b95e8c3502b027d6c3fe94a11f Merge: 46f8c61 edd5297 Author: David Young <dyoung@hdfgroup.org> Date: Fri Nov 22 15:34:09 2019 -0600 Merge remote-tracking branch 'origin/add-werror-and-squash-some' into fprintf-experiment commit 46f8c613d5117a8be5bc8385a072daa0b4262f06 Author: David Young <dyoung@hdfgroup.org> Date: Fri Nov 22 15:29:00 2019 -0600 GCC really wants us to use `ll` to format `long long`, so try to make that work before any other format modifier. Seems like we're not compiling the autoconf test program with -Werror=format ? Probably should. commit eee35b8ef3759c391327cd48a9b3c56b6f8abc99 Author: David Young <dyoung@hdfgroup.org> Date: Fri Nov 22 15:28:05 2019 -0600 It's hard to know just how wide an HDoff_t will be, and I don't think POSIX or C standards provide a PRI macro for it, so cast to intmax_t and format using PRIdMAX. commit 86eab12df7a89b546a38e99f8178dd2adbcb3433 Author: David Young <dyoung@hdfgroup.org> Date: Fri Nov 22 15:26:25 2019 -0600 URemove some casts.se the right format string for the argument. Here and there stop casting a printf argument. commit f722f7cbecbaa99449941484b014426f62f1bed5 Merge: 58e3743 6d5ec83 Author: David Young <dyoung@hdfgroup.org> Date: Fri Nov 22 14:44:16 2019 -0600 Merge branch 'add-werror-and-squash-some' into fprintf-experiment commit 58e3743b7faa9836606ee91798fe80dfc0040da7 Author: David Young <dyoung@hdfgroup.org> Date: Wed Nov 20 21:07:21 2019 -0600 Remove custom HDfprintf implementation, using the standard library's, instead. Take a swipe at repairing fprintf format strings, mainly replacing "%Hu" with "%" PRIuHSIZE, "%a" with "%" PRIuHADDR, "%Zu" with "%zu". Here and there remove an awkward cast of a printf argument to `long long` and use PRI[doux]8, PRI[doux]32, or PRI[doux]64, instead. Change occurrences of "%t" to "%s" and perform a suitable change of argument, `cond` -> `cond ? "TRUE" : "FALSE"`. Some occurrences of %Hu, %a, and %t remain, they just weren't flagged by the compiler because of #ifdef'age. commit d4366909293fa970c23512ac80e5d865d76cddbf Author: David Young <dyoung@hdfgroup.org> Date: Wed Nov 20 20:54:32 2019 -0600 Promote format-string warnigns to errors.
* Merge pull request #2668 in HDFFV/hdf5 from monotonic_timer to developQuincey Koziol2020-07-021-9/+28
|\ | | | | | | | | | | | | | | | | | | | | | | | | * commit '7371c83f9777b34b31909e99e052398b93c31bed': Remove non-existent example Add new source files to CMake build Clean up warnings va_arg -> HDva_arg Refactor code to remove remaining checks for H5_HAVE_GETTIMEOFDAY scattered around in various places. Also clean up iopipe.c. Correct mistake in H5_now_usec calculation for clock_gettime. Remove detection for mach/mach/time.h, since we're no longer using the time routines from that header. Update H5_now_usec to prefer using clock_gettime. Changes to make timers within the library monotonic.
| * Merge remote-tracking branch 'origin/develop' into monotonic_timerQuincey Koziol2020-06-261-207/+370
| |\
| * | Changes to make timers within the library monotonic.Quincey Koziol2017-09-031-9/+28
| | |
* | | Fix typo in HDftell macro definition: 'ftello -> ftell'Jacob Smith2020-06-291-1/+1
| |/ |/|
* | Reduce overhead for H5open, which is involved in the public symbols like ↵Quincey Koziol2020-06-161-2/+27
| | | | | | | | H5T_NATIVE_INT, etc.
* | Removed HDgets macros since gets was deprecated in C99 and removedDana Robinson2020-05-101-2/+5
| | | | | | | | in C11 (gets() is not used in our repo).
* | Tidying of Mirror VFD.Jacob Smith2020-04-071-3/+0
| | | | | | | | | | | | | | * Rename server-stop utility to mirror_server_stop. * Remove external dependency on bzero(). * Modify test/use_common to use only the public API. * Rename internal bitswap macro to follow convention.
* | Add Splitter VFD to library.Jacob Smith2020-03-131-1/+65
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * "Simultaneous and equivalent" Read-Write and Write-Only channels for file I/O. * Only supports drivers with the H5FD_FEAT_DEFAULT_VFD_COMPATIBLE flag for now, preventing issues with multi-file drivers. Add Mirror VFD to library. * Write-only operations over a network. * Uses TCP/IP sockets. * Server and auxiliary server-shutdown programs provided in a new directory, `utils/mirror_vfd`. * Automated testing via loopback ("remote" of localhost).
* | Merge pull request #2351 in HDFFV/hdf5 from ↵David Young2020-03-051-4/+0
|\ \ | | | | | | | | | | | | | | | | | | ~DYOUNG/werror:b-bye-HDpthread_self to develop * commit '224cb4a03406ed72e02d026efeab47fdf7f6b33b': Use a naked pthread_self() call in the HDF5 thread wrappers.
| * | Use a naked pthread_self() call in the HDF5 thread wrappers.David Young2020-02-061-4/+0
| | |
* | | Merge pull request #2367 in HDFFV/hdf5 from ~DYOUNG/werror:unused to developDavid Young2020-02-191-14/+39
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | * commit '50aac126d7c4082c2aeb0f3a68cad26bd1cd9783': Start to document the function/parameter/variable attribute macros. Filter all of the new _USED / _UNUSED type modifiers. H5_HAVE_PARALLEL, _DEBUG_API, etc. Add attributes to some variables and parameters that are unused under some configurations.
| * | | H5_HAVE_PARALLEL, _DEBUG_API, etc. Add attributes to some variables andDavid Young2020-02-101-14/+39
| |/ / | | | | | | | | | parameters that are unused under some configurations.
* | | Delete unhelpful comment per Jordan's question.David Young2020-02-101-3/+0
| | |
* | | Make sure that H5TS_thread_id() is available as either a function or a macro inDavid Young2020-02-071-3/+5
|/ / | | | | | | | | | | | | | | | | all configurations. Previously it was neither declared nor defined in --disable-threadsafety builds. The compiler's warning got lost in the noise---I first saw the issue because my -Werror branch stopped compiling cold---and the tests still linked and ran.
* | Replace pthread_self_ulong() with H5TS_thread_id(). The POSIX ThreadsDavid Young2020-02-031-5/+0
| | | | | | | | | | implementation ought to be portable to any system that has POSIX Threads. On Windows, I use the same API call as before.
* | Merge pull request #2311 in HDFFV/hdf5 from ~KMU/hdf5:misc to developKimmy Mu2020-01-281-1/+1
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | * commit '406330addf45529ecdd088f4d22e9aab9a03661d': rename macro change condition pick up from Dave's fix leave Wswitch-default for later fix fix Wredundant-decls, Wswitch-default, Wdeclaration-after-statement, Wsign-compare, Wmisleading-indentation, Wshadow
| * | fix Wredundant-decls, Wswitch-default, Wdeclaration-after-statement, ↵kmu2020-01-271-1/+1
| | | | | | | | | | | | Wsign-compare, Wmisleading-indentation, Wshadow
* | | Replaced my_isnan with C99 isnan in h5diff.Dana Robinson2020-01-241-0/+3
| | |
* | | Removed H5_DEC_ENUMDana Robinson2020-01-231-7/+0
| | |
* | | Revert "Revert "Moved -Wunsuffixed-float-constants to the developer warnings.""Dana Robinson2020-01-231-15/+0
|/ / | | | | | | This reverts commit 6486e06545bf637d46e18a787395542f4fca143a.
* | merge and fix conflictkmu2020-01-191-15/+15
|\ \
* \ \ merge and fix conflictskmu2020-01-141-21/+17
|\ \ \ | |/ /
| * | Fix compile errors - mostly in jniAllen Byrne2019-12-061-21/+17
| | |
* | | fix unused related warningskmu2020-01-131-1/+8
|/ /
* | Yanked -Wc++-compat from the flags used to build the C library in bothDana Robinson2019-12-041-7/+0
| | | | | | | | the Autotools and CMake.
* | Fixed the H5_mpi_get_bigio_count function prototypeRichard Warren2019-11-181-1/+1
| |
* | Merge pull request #1984 in HDFFV/hdf5 from ~DYOUNG/netbsd:develop to developDavid Young2019-11-051-1/+18
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * commit '0b721858e46a317c370a24115032d5be41688f67': Make these scripts relocatable again: derive a relative path for the original installation prefix from the examples prefix. Use that relative path to locate the current installation prefix, always. Fall back to an absolute installation prefix if the relative path cannot be derived. Get the path to prefix right: needs a ../ to back out of subdirectory c/. Make this script relocatable again: derive a relative path for the original installation prefix from the examples prefix. Use that relative path to locate the current installation prefix, always. Fall back to an absolute installation prefix if the relative path cannot be derived. Let us override the examples directory using --with-examplesdir=DIR. This is handy for NetBSD where HDF5 examples are installed by convention in $prefix/share/examples/hdf5/ rather than in ${prefix}/share/hdf5_examples/, which is the HDF5 default. Follow longstanding execv convention for compatibility with NetBSD. Under the examples directories, always find the installed HDF5 executables and scripts using @prefix@ instead of a relative path, because the number of ../ in the relative path will be different on NetBSD than on other systems. Make the HDF5 configure script grok NetBSD. For portability, insulate the HDF5 library from some system macros. Not every system has perl installed in /usr/bin/, so change the shebang (#!) line to `/usr/bin/env perl` to locate perl on the PATH. For portability, use the POSIX sh(1) string-comparison operator `=` instead of `==`.
| * | For portability, insulate the HDF5 library from some system macros.David Young2019-10-031-1/+18
| | |
* | | Change API names for get/set bitio_count. Also added H5_mpi_set_bigio_count ↵Richard Warren2019-10-231-1/+2
| | | | | | | | | | | | to H5private.h.
* | | Another cleanup pass as suggested by the reviewers.Richard Warren2019-10-071-5/+0
| | |
* | | At the suggestion of the PR reviewers, moved the mpio_create_large_type to ↵Richard Warren2019-10-071-0/+8
|/ / | | | | | | H5mpi.c and renamed the function appropriately. Also moved some support functions to set and get the vvalue where we transistion to using derived datatypes.
* | Added H5Pset/get_mpi_params calls and unified them with the MPI-I/ODana Robinson2019-08-261-0/+2
| | | | | | | | VFD info in H5FDmpio.c.
* | Some refactoring prior to implementing new H5P MPI functions.Dana Robinson2019-08-141-0/+8
| | | | | | | | | | | | * Macro cleanup and obvious warning fixes in parallel code. * Moved H5FD comm and info dup/free wrapper code to a new H5mpi.c file and separated it to deal with each MPI type separately.
* | Merge pull request #1860 in HDFFV/hdf5 from ~DEROBINS/hdf5_der:map_api_merge ↵Dana Robinson2019-08-131-0/+3
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | to develop * commit 'd95745235a468b17f697843adb3d0e54bd919893': Updated h5trav.c to emit output that doesn't require ddl changes for map support. Fixed Map API CMake option Renamed H5Mdelete_key to H5Mdelete and H5Mset to H5Mput. Added the map (H5M) API
| * | Added the map (H5M) APIDana Robinson2019-08-131-0/+3
| | |
* | | Added ifdef for intel compilers, __GNUC__ has to be defined for header files ↵M. Scot Breitenfeld2019-08-131-1/+1
|/ / | | | | | | which use it to work with intel compilers. This gives a warning for intel compiler about fallthrough, so added a check not to include fallthrough if using intel compilers.
* | Added gcc conditional for __attribute__((fallthrough)), removes 34 warnings ↵M. Scot Breitenfeld2019-08-081-0/+4
| | | | | | | | on theta (10% of warnings).
* | Add support for GCC 7.x warnings, update warnhist script to account for them,Quincey Koziol2019-06-211-0/+3
| | | | | | | | clean up warnings.
* | - Added H5MMprivate.h #includes where neededDana Robinson2019-03-161-5/+1
| | | | | | | | | | - Added casts to quiet H5MM_memcpy warnings - Removed char * casts from HDmemcpy
* | Merge branch 'develop' into c_stdlib_posix_call_cleanupDana Robinson2019-02-191-0/+6
|\ \
| * | Updated sec2, log, and core VFDs to use pread/pwrite whenDana Robinson2019-01-311-0/+6
| | | | | | | | | | | | available (can be controlled via a configure/CMake option)
* | | C and POSIX call cleanupDana Robinson2019-01-111-2/+3
|/ /