summaryrefslogtreecommitdiffstats
path: root/src
Commit message (Collapse)AuthorAgeFilesLines
* Squash my changes on branch `fprintf-experiment` into one commit forDavid Young2020-07-0756-852/+445
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | reapplication to my new warnings branch, `warnings-again`. These changes are included: commit 915551b7bf64e777dd2007386ec77b1d117770da Merge: 63858c2 a8892bb Author: David Young <dyoung@hdfgroup.org> Date: Mon Nov 25 17:39:49 2019 -0600 Merge remote-tracking branch 'hdf5/develop' into fprintf-experiment commit a8892bb42d6f6e4fbc30fae0eb2b957f81c938b9 Merge: 5c911d8 f907b51 Author: David Young <dyoung@hdfgroup.org> Date: Mon Nov 25 17:33:54 2019 -0600 Merge pull request #2055 in HDFFV/hdf5 from ~DYOUNG/vchoi_fork:add-werror-and-squash-some to develop * commit 'f907b511d06612dafc7814a7c30f2f3d2b76d52b': Oops, remove more C99 designated initializers for VS 2010 compatibility. commit 63858c22e168acaec0af8ced6641f26102cc6bb0 Merge: 20ae787 5c911d8 Author: David Young <dyoung@hdfgroup.org> Date: Mon Nov 25 17:04:42 2019 -0600 Merge remote-tracking branch 'hdf5/develop' into fprintf-experiment commit 5c911d8baf3ee7fe654269088eebdf07f59a8192 Merge: b8a5671 62208b0 Author: David Young <dyoung@hdfgroup.org> Date: Mon Nov 25 16:58:27 2019 -0600 Merge pull request #2030 in HDFFV/hdf5 from ~DYOUNG/vchoi_fork:add-werror-and-squash-some to develop * commit '62208b056a09c01855fbac7f75146be58ad6bfe5': (44 commits) Add an #include to get a function declaration. Don't use C99 designated initializers, they're not compatible with Visual Studio 2010. Quiet some more maybe-uninitialized warnings---each is a false positive, *sigh*. This is more code that may not compile with VS2010, *sigh sigh*. Always warn on maybe-uninitialized. -Wincompatible-pointer-types was not available until GCC 5, so enable it only if that's the GCC version we're using. Only promote maybe-uninitialized warnings to errors on GCC 8. Even on GCC 8, there may be false positives at low optimization levels? I need to check. Only use -Werror=cast-function-type with GCC 8 and later. Put all of the -W options back into the order I found them in so that it's easier to compare old and new config/gnu-flags. Add new source files to CMakeLists.txt. Mention the -Werror= flags in libhdf5.settings.in. free -> HDfree Promote decleration-after-statement warnings to errors. Quiet decleration-after-statement warnings. Move a statement under some declarations since some vintages of Visual Studio don't like declarations after statements. Document H5D__chunk_mem_xfree_wrapper(). Undo accidental test deletion. Oops, delete a debug printf that snuck in here. Undo my changes to the HD macros, hadn't really intended those to be on this branch.... Make errors of some more warnings. Move disabled warnings to DEVELOPER_WARNING_CFLAGS. Put just one warning option on a line, and sort some of the options. Cast to the parameter type, H5VL_token_t *, instead of to unsigned char *. Change hdset_reg_ref_t and H5R_ref_t from arrays of unsigned char to structs containing those arrays. Encapsulating the arrays in this way makes it easier to write and think about pointers to these types, casts to/from these types, etc. ... commit 20ae7877e33931b95e8c3502b027d6c3fe94a11f Merge: 46f8c61 edd5297 Author: David Young <dyoung@hdfgroup.org> Date: Fri Nov 22 15:34:09 2019 -0600 Merge remote-tracking branch 'origin/add-werror-and-squash-some' into fprintf-experiment commit 46f8c613d5117a8be5bc8385a072daa0b4262f06 Author: David Young <dyoung@hdfgroup.org> Date: Fri Nov 22 15:29:00 2019 -0600 GCC really wants us to use `ll` to format `long long`, so try to make that work before any other format modifier. Seems like we're not compiling the autoconf test program with -Werror=format ? Probably should. commit eee35b8ef3759c391327cd48a9b3c56b6f8abc99 Author: David Young <dyoung@hdfgroup.org> Date: Fri Nov 22 15:28:05 2019 -0600 It's hard to know just how wide an HDoff_t will be, and I don't think POSIX or C standards provide a PRI macro for it, so cast to intmax_t and format using PRIdMAX. commit 86eab12df7a89b546a38e99f8178dd2adbcb3433 Author: David Young <dyoung@hdfgroup.org> Date: Fri Nov 22 15:26:25 2019 -0600 URemove some casts.se the right format string for the argument. Here and there stop casting a printf argument. commit f722f7cbecbaa99449941484b014426f62f1bed5 Merge: 58e3743 6d5ec83 Author: David Young <dyoung@hdfgroup.org> Date: Fri Nov 22 14:44:16 2019 -0600 Merge branch 'add-werror-and-squash-some' into fprintf-experiment commit 58e3743b7faa9836606ee91798fe80dfc0040da7 Author: David Young <dyoung@hdfgroup.org> Date: Wed Nov 20 21:07:21 2019 -0600 Remove custom HDfprintf implementation, using the standard library's, instead. Take a swipe at repairing fprintf format strings, mainly replacing "%Hu" with "%" PRIuHSIZE, "%a" with "%" PRIuHADDR, "%Zu" with "%zu". Here and there remove an awkward cast of a printf argument to `long long` and use PRI[doux]8, PRI[doux]32, or PRI[doux]64, instead. Change occurrences of "%t" to "%s" and perform a suitable change of argument, `cond` -> `cond ? "TRUE" : "FALSE"`. Some occurrences of %Hu, %a, and %t remain, they just weren't flagged by the compiler because of #ifdef'age. commit d4366909293fa970c23512ac80e5d865d76cddbf Author: David Young <dyoung@hdfgroup.org> Date: Wed Nov 20 20:54:32 2019 -0600 Promote format-string warnigns to errors.
* Small changes discovered with mingw and windows defines movedAllen Byrne2020-07-025-223/+221
|
* Merge pull request #2668 in HDFFV/hdf5 from monotonic_timer to developQuincey Koziol2020-07-0210-568/+1064
|\ | | | | | | | | | | | | | | | | | | | | | | | | * commit '7371c83f9777b34b31909e99e052398b93c31bed': Remove non-existent example Add new source files to CMake build Clean up warnings va_arg -> HDva_arg Refactor code to remove remaining checks for H5_HAVE_GETTIMEOFDAY scattered around in various places. Also clean up iopipe.c. Correct mistake in H5_now_usec calculation for clock_gettime. Remove detection for mach/mach/time.h, since we're no longer using the time routines from that header. Update H5_now_usec to prefer using clock_gettime. Changes to make timers within the library monotonic.
| * Merge remote-tracking branch 'origin/develop' into monotonic_timerQuincey Koziol2020-06-301-0/+6
| |\
| * | Clean up warningsQuincey Koziol2020-06-282-3/+7
| | |
| * | va_arg -> HDva_argQuincey Koziol2020-06-271-1/+1
| | |
| * | Refactor code to remove remaining checks for H5_HAVE_GETTIMEOFDAY scattered ↵Quincey Koziol2020-06-272-32/+41
| | | | | | | | | | | | around in various places. Also clean up iopipe.c.
| * | Merge remote-tracking branch 'origin/develop' into monotonic_timerQuincey Koziol2020-06-26427-53399/+111938
| |\ \
| * | | Correct mistake in H5_now_usec calculation for clock_gettime.Quincey Koziol2017-09-241-1/+1
| | | |
| * | | Update H5_now_usec to prefer using clock_gettime.Quincey Koziol2017-09-241-1/+8
| | | |
| * | | Changes to make timers within the library monotonic.Quincey Koziol2017-09-0310-513/+991
| | | |
* | | | Merge pull request #2669 in HDFFV/hdf5 from ↵Jake Smith2020-06-301-1/+1
|\ \ \ \ | |_|_|/ |/| | | | | | | | | | | | | | | | | | | ~JAKE.SMITH/hdf5:bugfix/HDftell_macro_typo to develop * commit 'ef05e68c38d2086c6f262744b4087f65a6e58957': Fix typo in HDftell macro definition: 'ftello -> ftell'
| * | | Fix typo in HDftell macro definition: 'ftello -> ftell'Jacob Smith2020-06-291-1/+1
| | |/ | |/|
* | | Changed wording in comment.Binh-Minh Ribler2020-06-301-2/+2
| | |
* | | - added comment to explain a klugeBinh-Minh Ribler2020-06-291-0/+2
| | | | | | | | | | | | - added the associated entry to release notes
* | | Merging in latest from upstream (HDFFV/hdf5:refs/heads/develop)Binh-Minh Ribler2020-06-2938-608/+664
|\ \ \ | |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * commit '30776671fb0a27a98b0640aa968f850241a862ce': (31 commits) * Fix intermittent error with Splitter VFD. Mismatch in time of test file creation was creating false negatives. Added note for HDFFV-10591. Fix HDFFV-10591 Reduce overhead for H5open, which is involved in the public symbols like H5T_NATIVE_INT, etc. Remove unnecessary version conditions for Clang compilers. Fix for HDFFV-10961: Couple changes to the tests' usage output files for h5clear. Fix for HDFFV-10961: add description to usage for --increment option. Add c++ to --enable-sanitize-checks option. Remove duplicate entries in MANIFEST. Make changes to CMake CompilerFlags.cmake files so extra flags are loaded for non-GNU compilers. Fix MANIFEST Add tests for all version to H5_NO_DEPRECATED_SYMBOLS section and to section for current version, with and without default API version flags. HDFFV-11000: update-testh5cc.sh.in to test sample versioned functions in HDF5 1.10, 1.12 and develop. Remember the info for the last ID looked up for a given ID type. Eliminate allocating file & memory offset & length arrays when performing I/O on a single element. Update new clang files to not pick up clang as vendor for pgCC. Add new files to MANIFEST Temporary demotion of 2 -Werror warning flags that fail on macos 10.12 Remove Production flag unknown to Apple clang. Remove redundant metadata cache tagging from some low-level internal chunk functions. The metadata cache tagging has already been done by routines further up the call stack. Clean up code to get clang version in config/linux-gnulibc1 Minor normalizations with HDF5 1.10. Add flags from config/clang-warnings/*general files to H5 C and CXX flags for all versions of Clang and Clang++ compilers. Switched from cut to awk in testcheck_version.sh.in to avoid dependence on tab vs. " " in version definitions in H5public.h. ...
| * | Merge pull request #2654 in HDFFV/hdf5 from bmr_HDFFV-10591 to developBinh-Minh Ribler2020-06-221-0/+5
| |\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixed HDFFV-10591 * commit '7d58d115079d286a566207c529e59bbccc952b03': Added note for HDFFV-10591. Fix HDFFV-10591
| | * | Fix HDFFV-10591Binh-Minh Ribler2020-06-191-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Description: h52gif produced a segfault when a buffer overflow occurred because the data size was corrupted and became very large. This commit added a check on the data size against the buffer size to prevent the segfault. It also added error reporting to h52gif to display an error message instead of silently exiting when the failure occurred. Platforms tested: Linux/64 (jelly) SunOS 5.11 (emu)
| * | | Reduce overhead for H5open, which is involved in the public symbols like ↵Quincey Koziol2020-06-162-5/+32
| |/ / | | | | | | | | | H5T_NATIVE_INT, etc.
| * | Merge pull request #2615 in HDFFV/hdf5 from ↵Jake Smith2020-06-151-0/+3
| |\ \ | | | | | | | | | | | | | | | | | | | | | | | | ~JAKE.SMITH/hdf5:bugfix/splitter_valgrind_patch to develop * commit '6462c67b6578e48c1ef6d847be59c0b5e3598a50': Patch a few holes in the Splitter VFD implementation.
| | * | Patch a few holes in the Splitter VFD implementation.Jacob Smith2020-05-291-0/+3
| | | | | | | | | | | | | | | | | | | | * Missing logfile close on driver-open failure. * Initialize empty string in test/vfd (logfile path in W/O compat check).
| * | | Merge pull request #2635 in HDFFV/hdf5 from cache_last_id_info to developQuincey Koziol2020-06-101-2/+22
| |\ \ \ | | | | | | | | | | | | | | | | | | | | * commit '0ef32f07fb9e8fb6063f3318425506047454d6f4': Remember the info for the last ID looked up for a given ID type.
| | * | | Remember the info for the last ID looked up for a given ID type.Quincey Koziol2020-06-091-2/+22
| | | | |
| * | | | Merge pull request #2634 in HDFFV/hdf5 from opt_single_selection_io to developQuincey Koziol2020-06-101-27/+32
| |\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | * commit 'a8a4e9f27b67ae2e22970e42859225adcc2e5cbb': Eliminate allocating file & memory offset & length arrays when performing I/O on a single element.
| | * | | | Eliminate allocating file & memory offset & length arrays when performing ↵Quincey Koziol2020-06-091-27/+32
| | |/ / / | | | | | | | | | | | | | | | I/O on a single element.
| * | | | Remove redundant metadata cache tagging from some low-level internal chunk ↵Quincey Koziol2020-06-091-4/+4
| |/ / / | | | | | | | | | | | | functions. The metadata cache tagging has already been done by routines further up the call stack.
| * | | Merge pull request #2630 in HDFFV/hdf5 from ~DEROBINS/hdf5_der:develop_minor ↵Dana Robinson2020-06-086-46/+38
| |\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | to develop * commit '87695c999ad7ea348ee6dc03b46b0bd345f7d7df': Minor normalizations with HDF5 1.10.
| | * | | Minor normalizations with HDF5 1.10.Dana Robinson2020-06-076-46/+38
| | | | |
| * | | | Detect when there's the same-shaped selection of a single block of elements onQuincey Koziol2020-06-051-0/+9
| |/ / / | | | | | | | | | | | | | | | | | | | | both selections, but with different selection types (i.e. one selection defined as an 'all' type and the other as a hyperslab or point type), without falling into the generic selection iteration case.
| * | | Normalization of H5T.c with 1.10.Dana Robinson2020-06-041-24/+24
| | | |
| * | | Normalization of H5D.c with 1.10.Dana Robinson2020-06-041-11/+10
| | | |
| * | | Normalizations with 1.10 branch.Dana Robinson2020-06-023-16/+19
| | | |
| * | | Normalization with hdf5_1_10Dana Robinson2020-06-0124-473/+466
| |/ /
* | | Fix HDFFV-11053Binh-Minh Ribler2020-05-261-0/+4
|/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Description: A superblock pointer was set to a temporary structure, as a kluge, and meant to be reset back to NULL after the processing was completed. However, in the case of failure before the completion, this setting caused the superblock pointer to be unpinned twice in the error recovery process. As a result, that generated a segfault in h5clear. The fix resets the superblock pointer to NULL after H5F__super_ext_remove_msg fails so that h5clear can fail properly. Note: After the fix, when built in debug mode, there will be an assertion failure with the user's file, which appeared to be corrupted: H5MM_final_sanity_check: Assertion `0 == H5MM_curr_alloc_bytes_s' failed. This did not happen on a good file or on the corrupted file with the library built in production mode. The un-freed memory were allocated during error recovery. Platforms tested: Linux/64 (jelly)
* | Replaced a few calls to HDmemcpy with H5MM_memcpy, which does overlapDana Robinson2020-05-152-8/+8
| | | | | | | | checking.
* | Removed HDgets macros since gets was deprecated in C99 and removedDana Robinson2020-05-101-2/+5
| | | | | | | | in C11 (gets() is not used in our repo).
* | Avoid allocating a chunk index for datasets with 0-sized dimensions, untilQuincey Koziol2020-05-012-3/+5
| | | | | | | | the dataset is extended.
* | Merge pull request #2542 in HDFFV/hdf5 from ~DEROBINS/hdf5_der:warning_fixes ↵Dana Robinson2020-04-271-15/+17
|\ \ | | | | | | | | | | | | | | | | | | to develop * commit 'c3367e6634d4dee88ff855da08e312f6685c23af': Moved -Woverlength-strings to the developer flags.
| * | Moved -Woverlength-strings to the developer flags.Dana Robinson2020-04-261-15/+17
| | |
* | | Fix `src/H5FDdirect.c:1346:5: error: ISO C90 forbids mixed declarationsDavid Young2020-04-241-4/+1
|/ / | | | | | | and code [-Werror=declaration-after-statement]`.
* | Merge pull request #2525 in HDFFV/hdf5 from ~LRKNOX/hdf5_lrk:develop to developLarry Knox2020-04-231-1/+1
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | * commit '43424a1392b662a29542bb70014c253162ccfe48': Add missing ')'. Add C++ warnings treated as error for autotools builds. Move macro ADD_H5_CFLAGS to cmake_ext_mod/HDFMacros.cmake and remove duplicate versions. Address PR suggestions and add overlooked GCC compiler version flags. Don't add general warnings flags for unsupported old versions of gcc and g++ (older than gcc/g++ 4.2). Correct gnu-cxxflags to determine warnings flags to be added based on C++ compiler version instead of C compiler version.
| * | Add C++ warnings treated as error for autotools builds.Larry Knox2020-04-231-1/+1
| | |
* | | Trim trailing whitespaceQuincey Koziol2020-04-20147-2473/+2473
|/ /
* | Fixed some minor cmp callback bugs and cleaned warnings.Dana Robinson2020-04-171-3/+5
| |
* | Fixed problems with S3 and HDFS VFDs.Dana Robinson2020-04-171-1/+6
| | | | | | | | | | | | * Updated info struct parameter to correct info_string * Fixed Makefile.am where the S3 VFD was listed twice, causing duplicated symbols errors.
* | Merge pull request #2452 in HDFFV/hdf5 from ↵Jake Smith2020-04-1111-5/+4020
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ~JAKE.SMITH/hdf5:feature/vfd_splitter_mirror_a to develop Add Splitter VFD and Mirror VFD. * commit '664fc6af47e369152727ff66d68d8532feb0e210': Add enable-mirror-vfd flag to configure options. Tidying of Mirror VFD. Add function header comment for `mirror_writer:run_writer()`. Add Splitter VFD to library.
| * \ Merge branch 'develop' of ↵Jacob Smith2020-04-0721-370/+682
| |\ \ | | | | | | | | | | | | https://bitbucket.hdfgroup.org/scm/~jake.smith/hdf5 into feature/vfd_splitter_mirror_a
| * | | Tidying of Mirror VFD.Jacob Smith2020-04-072-8/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | * Rename server-stop utility to mirror_server_stop. * Remove external dependency on bzero(). * Modify test/use_common to use only the public API. * Rename internal bitswap macro to follow convention.
| * | | Add Splitter VFD to library.Jacob Smith2020-03-1311-5/+4013
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * "Simultaneous and equivalent" Read-Write and Write-Only channels for file I/O. * Only supports drivers with the H5FD_FEAT_DEFAULT_VFD_COMPATIBLE flag for now, preventing issues with multi-file drivers. Add Mirror VFD to library. * Write-only operations over a network. * Uses TCP/IP sockets. * Server and auxiliary server-shutdown programs provided in a new directory, `utils/mirror_vfd`. * Automated testing via loopback ("remote" of localhost).
* | | | Merge pull request #2502 in HDFFV/hdf5 from ~DEROBINS/hdf5_der:develop_minor ↵Dana Robinson2020-04-093-20/+55
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | to develop * commit '35c0d5cdfcfaa84f59e1c596ba1ccaeb28e3d83d': Fix for passthrough VOL not passing tools tests due to incorrect optional callback queries.