| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
|
|
|
|
|
|
|
| |
Description:
Factory free lists were formerly implemented as block free lists. This was
inefficient as factories can only be one size, and implementing them as blocks
(which can be variable size) wasted computation and space. They have been
rewritten with a separate implementation, which is simlar to regular free lists
except they can be dynamically created and destroyed.
Tested: jam, linew, smirom (h5committest)
|
|
|
|
|
|
|
|
|
| |
Description:
Changed Skip list package to use a deterministic skip list. This allows the
skip list package to avoid calling rand() and srand(), even on machines without
rand_r(). There is no longer a p-value or maximum level for skip lists.
Tested: jam, smirom, linew (h5committest)
|
|
|
|
|
|
|
|
|
|
|
| |
Description:
Previously, H5Lcopy and H5Lmove would (through H5L_move) improperly apply the
"create intermediate groups" property to the source path traversal, and not the
destination. Fixed it to apply the property to the destination and not the
source. Also fixed H5Lcreate_ud to reject internal link classes without
throwing an assertion.
Tested: linew, jam, smirom (h5committtest)
|
|
|
|
|
|
|
|
|
| |
ID was passed in. I put
some argument check in the internal function H5I_find_id and took out the assertion check.
I also removed the argument check in H5Iis_valid because it's in H5I_find_id now.
Tested on jam and linew - simple change.
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
Description:
Due to a bug in H5F_super_read, every time a file with a user block was opened
it would grow by the size of the user block. The bug has been fixed, and
comments have been added to clarify when an eoa address should be relative and
when it should be absolute.
Tested:
jam, linew (h5committest)
|
|
|
|
|
|
|
|
| |
necessary as Quincey pointed out.
I took it out and used the driver address instead.
Tested on jam - simple change.
|
|
|
|
|
|
|
|
|
|
|
|
| |
is opened and closed with
v1.8 library, v1.8 library writes the driver info block in the superblock. But v1.6
doesn't write it. This caused the data after the superblock to be overwritten. The
solution is to use a flag to indicate when the original file doesn't have the driver
info, v1.8 library doesn't write it either.
Tested on jam. I have some trouble to access smirom and linew using h5committest.
|
|
|
|
|
|
|
|
|
|
|
| |
Description:
Some files apparently exist in the wild which have corrupt symbol table messages
on the root group. These files can be opened by 1.6 (which uses the cached
information in the superblock) but not by 1.8. This patch fixes 1.8 and 1.9 so
they can now open these files, and will correct them if necessary. Also fix
some potential (rare) problems with array datatype versions.
Tested: jam (parallel; h5committest not working on linew or smirom)
|
| |
|
|
|
|
|
|
|
|
| |
Bring r16560 back from trunk.
Tested on:
Mac OS X/32 10.5.6 (amazon) debug & production
(Following up with tests on more platforms)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Bug Fix
Description:
Fixing BZ #1381. The --includedir=DIR configure option, which is used to
spceify installation location of C header files, did not work correctly as
the path was hard-coded into config/commence.am. I'm presuming this is
because an older version of automake didn't know where to put C header
files. In any case, removing this line now defaults the includedir to the
same directory that it is currently hard-coded to, and also fixes the
configure flag which allows for customization of this value.
Tested:
jam, liberty
|
|
|
|
|
|
| |
H5G_dense_iterate
Tested: Fedora 10 (too minor for full committest)
|
|
|
|
|
|
|
|
|
|
|
| |
Bring v16532 back from trunk to v1.8 branch:
Pass the chunk "user data" to H5D_chunk_unlock(), so that chunks with
an address already aren't reallocated.
Tested on:
FreeBSD/32 6.3 (duty) in debug mode
(h5committest not needed here, performed on trunk)
|
| |
|
|
|
|
|
|
|
|
|
| |
Description:
In some situations it was possible for the fill value to not be written to parts
of a chunked dataset, particularly when extending and/or shrinking. Prior to
the fix for the chunk cache (1015) these bugs would have been exceedingly rare.
Tested: jam, smirom, linew (h5committest)
|
|
|
|
|
|
| |
have 2 expected outputs for 2 h5ls runs depending if run on a big or little endian machine. Configure.in was modified to export a variable carrying endianess information to testh5ls.sh. This script then compares the current run with 2 expected outputs, one for a big-endian machine (linew was used to generate the output), other for little endian (jam was used to generate the output)
the way h5ls prints types, it starts searching for NATIVE types first. One solution would be h5ls not to detect these native types, using for example the same print datatype function that h5dump does, that would make the output look the same on all platforms ("32-bit little-endian integer" would be printed instead). Drawback, this "native" information would not be available. Other solution is to have not one but 2 expected outputs and make the shell script detect the endianess and compare with one output or other
tested: jam, linew
|
|
|
|
|
|
|
|
|
|
|
| |
#1404). When the index was set to
creation order in querry function but there's no creation order indexed in the file, the library tried
to build and sort a table of all links. To optimize it, let the library use the B-tree for names of
links.
Tested with h5committest.
|
|
|
|
| |
Platforms tested: Mac OSX and AIX (by Ed) (minor fix)
|
|
|
|
|
|
|
|
|
|
| |
Bring r16499 back from trunk:
Cache chunk info for newly created chunk.
Tested on:
FreeBSD/32 6.3 (duty)
(Tests included in upcoming revise_chunks branch changes)
|
|
|
|
|
|
|
|
|
|
|
| |
Bring r16488 back from trunk:
Clean up code and eliminate resource leaks. Also avoid "null" I/O when
chunk doesn't exist and we can skip it.
Tested on:
Mac OS X/32 10.5.6 (amazon)
(too minor to require h5committest)
|
|
|
|
|
|
|
|
|
|
|
| |
Bring r16483 back from trunk:
Clean up (i.e. remove) more internal calls to H5E_clear_stack(), along with
some other minor code cleanups.
Tested on:
Mac OS X/32 10.5.6 (amazon)
(too minor to require h5committest)
|
|
|
|
|
|
|
|
|
| |
replacing all instances with long long.
Tested:
h5comittest
fedora 10 x64
XP32, VNET
|
|
|
|
|
|
| |
src/H5Oalloc.c, test/ohdr.c, toshm.c
Fixed couple of problems in src/H5Odbg.c.
h5committested.
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
Description:
The meaning of the "nbytes" field in H5D_rdcc_t was not clear, and some places
assumed it was the maximum size of the chunk cache, while some assumed it was
the current size of the chunk cache. The end result was that only 1 chunk could
be held in cache at a time. This field has been replaced by "nbytes_max" and
"nbytes_used". Performance of cached I/O should improve greatly.
Tested: jam, smirom (h5committest)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
through multiple
file handles.
Description:
An attribute's "oloc" field which specifies the file it resides in was located
in the attribute's "shared" structure. So when an attribute was opened multiple
times all of the handles for that attribute pointed to the same file id, even if
different file id's were used to open the different handles for the attribute.
The "oloc" has been moved to the top level H5A_t struct.
Tested: jam, smirom (h5committest)
|
|
|
|
|
|
|
|
|
|
|
|
| |
Description:
Since the new object header format, it has been possible for a situation to be
created where none of the messages are large enough to hold a continuation
message and there are no null messages to merge with. This makes it impossible
to add a new object header chunk. This case will now be handled by moving every
message in the last chunk to the newly allocated one, except for null messages
which are deleted.
Tested: jam, smirom (h5committest)
|
|
|
|
|
|
|
|
|
|
|
|
| |
Description:
When an attribute was created with a datatype or dataspace that was shared in
the same object header that the attribute was in, the attribute could not be
deleted. Changes made to ensure that the attribute can be deleted both when the
attribute is in the object header and when it is shared in the heap. Object
header message decode routines now take an "open_oh" parameter to enable them to
avoid opening the same object header twice.
Tested: jam, smirom (h5committest)
|
|
|
|
|
|
|
|
|
|
| |
than the cache size and isn't allocated
on disk, the library still loaded it in the cache, which is redundant. I changed it to bypass the
cache and added a test in dsets.c.
Tested on jam and smirom.
|
|
|
|
|
|
|
|
|
|
|
|
| |
Bring r16414 from trunk into 1.8 branch:
Eliminate some more calls to H5E_clear_stack() from within library code.
Clean up some warnings & comments also.
Tested on:
Mac OS X/32 10.5.6 (amazon)
(Too minor to require h5committest)
|
|
|
|
|
|
|
|
|
|
|
| |
Bring r16401 back from trunk:
Correct error introduced in r16353 with layout version, and add test
so it gets caught earlier.
Tested on:
FreeBSD/32 6.3 (duty)
Too minor to require h5committest
|
|
|
|
|
|
|
|
|
|
| |
Bring r16399 back from trunk:
Remove some internal calls to H5E_clear_stack().
Tested on:
FreeBSD/32 6.3 (duty)
Too minor to require h5committest
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Bring r16394 back from trunk:
Rename H5O_msg_read_real -> H5O_msg_read_oh, to be more consistent with
other routines in library.
Move H5O_msg_read_oh and H5O_msg_exists_oh from package to private
header file, so other routines in library can use them.
Tested on:
FreeBSD/32 6.3 (duty)
Too minor to require h5committest
|
|
|
|
|
|
|
|
| |
yesterday's dense
attribute object copy commit.
Tested: jam (gcc and pgcc)
|
|
|
|
|
|
|
|
|
| |
Description:
Attribute object copy routines have been moved from H5Oattr.c to H5Aint.c.
These routines are now shared between compact and densely stored attributes.
New routines written to support the copying of dense attributes. This patch wasmostly written by Peter Cao.
Tested: jam, smirom (h5committest)
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Description: When attempting to copy an object with a message shared in its own
object header, the library attempts to protect the same object header twice.
Previously, it was possible for the object header to be protected with write
access in one or both of these protects, which would be illegal. The library
should now always protect with read only access in this case. The conditions
for fixing incorrect datatype versions have been made weaker to support this
change. The version will only be corrected if the object header the datatype
is in is modified.
Tested: jam, smirom (h5committest)
|
|
|
|
|
|
|
|
|
|
|
|
| |
Bring r16367 back from trunk:
Refactor internal address encode/decode routines slightly, to allow for
more flexible use.
Tested on:
Mac OS X/32 (amazon)
FreeBSD/32 (duty)
(too minor to require h5committest)
|
|
|
|
|
|
|
|
|
|
| |
Bring r16364 back from trunk:
Clean up a few compiler warnings
Tested on:
Mac OS X/32 (amazon)
(too minor to require h5committest)
|
|
|
|
|
|
|
|
| |
Description: H5Tset_order will now properly reject H5T_ORDER_NONE for most
datatypes. Previously this could cause major problems as the file could not be
flushed.
Tested: jam, smirom (h5committest)
|
|
|
|
|
|
|
|
|
|
|
| |
Bring r16354 back from trunk:
Refactor internal layout information, making it easier to add another
type of chunk index.
Tested on:
FreeBSD/32 (duty)
(other configurations tested with original change)
|
|
|
|
|
|
|
|
|
|
|
|
| |
Description: H5Tinsert will now detect when a compound type that was previously
not packed becomes packed due to out of offset order insertion of a member.
H5Tinsert will now attempt to keep members sorted by offset order. This should
improve performance of H5Tinsert in all cases due to the fact that it no longer
needs to check every other member for overlapping, and should improve
performance of H5Tpack and possibly type conversion when compounds are packed
out of order.
Tested: jam, smirom (h5committest)
|
| |
|
|
|
|
|
|
| |
Changed 'THG' to 'The HDF Group' in various HDF5 source files,
most of which are <subdirectory>/COPYING.
-- Closes Bugzilla entry 1403.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Code Cleanup
Description:
- Pulled out repetetive cache stats code into its own new macro.
- Converted HDasserts in verification macros to if / HGOTO_ERROR statments
in order to keep code consistent.
Tested:
jam (also tested smirom/liberty in trunk)
|
|
|
|
|
|
|
|
|
|
|
| |
Improvement
Description:
Modified the warning messages from the Version mismatch checking to suggest
the users to try recompiling or checking the shared lib setting.
Platforms tested:
Tested in Jam only since it was just a simple text string changes.
|
|
|
|
| |
Tested on OpenVMS and jam.
|