| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|
|
|
|
|
| |
--disable-sharedlib-rpath configure option is invoked. Fix for HDFFV-8276.
Tested with h5committest and on hdf-duck.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Description:
With optimization enabled, gcc 4.8 inserts garbage into the padding bytes of
floating point types when assigning from a literal constant. This caused
problems when H5detect.c scanned the bits in floating point types to determine
their properties.
Modified H5detect.c to scan for padding before further analyzing the type, and
to ignore all information in the padding areas. Also removed code that
temporarily disabled optimization.
Tested: jam, koala, ostrich, platypus (h5committest)
|
|
|
|
|
|
|
| |
Add more usage info for UserMacros.
Add new option information about the Plugin default path.
Tested: local linux, jam
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Description:
H5Fis_hdf5 uses H5F_locate_signature to check if the file is hdf5. If it does
not locate the signature, H5F_locate_signature would issue an error and return
HADDR_UNDEF. H5Fis_hdf5 does not consider it an error if the signature is not
found, so it does not issue an error or clear the stack. The filled stack could
then cause issues later on.
Changed H5F_locate_signature to return herr_t, not issue an error if the
signature is not found, and added a parameter for a pointer to the signature
address that the function fills in.
Tested: jam, koala, ostrich (h5committest)
|
|
|
|
| |
Tested: jam, koala, ostrich (h5committest)
|
|
|
|
|
|
| |
include test.
Tested: jam
|
|
|
|
|
|
|
| |
Restrict GCC diagnostic pragmas to only gcc 4.6+
Tested on:
Mac OSX/64 10.8.4 (amazon) w/gcc 4.8
|
|
|
|
|
|
| |
Reviewed in H5T-61
Tested: local linux - cmake and autotools
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Clean up warnings, enable new compiler warning flag(s) and bring back
changes from Coverity branch:
r20813:
Remove the dead code as listed for coverity bug #1722. h5committested.
r20814:
Issue 69: Check return value and throw error if negative return. Also free datatype id on error
r20815:
Use HDstrncpy. --gh
r20816:
Replaced one last HDstrcat call with HDstrncat to resolve coverity issue 832.
r20817:
Use HDstrncpy and HDstrncat. --gh
r20818:
Purpose: Fix valgrind issues with h5jam
Description:
Modified h5jam to free strings strdup'd in parse_command_line before exit. Note
that they may still not be freed in case of error, due to the widespread use of
exit().
r20819:
Issue 80: change loop to use int as loop index.
r20820:
Maintenance: Fixed the bug found by coverity CID 788
There were two problems with this function:
1) it tried to unnecessary free NULL pointer
2) it tried to allocate c_name buffer that is done by H5Pget_class_name
Tested on:
Mac OSX 10.8.4 (amazon) w/gcc 4.8.1, C++ & FORTRAN
(too minor to require h5committest)
|
|
|
|
|
|
|
|
|
| |
double with GCC 4.8. A user in the forum found the
problem in H5detect.c (uninitialized buffer) and provided the solution. I checked it in yesterday. But it
turned out to be a false fix. So I'm back it out.
Tested on jam - reverse of changes.
|
|
|
|
|
|
|
|
| |
double with GCC 4.8. A user in the forum found the
problem in H5detect.c (uninitialized buffer) and provided the solution. Allen and I verified it.
Tested with h5committest and CMake on jam, koala, ostrich, playtus, and Allen's virtual machine.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
Count).
This is needed to avoid a conflict with the Read Context object to be
introduced in another Project.
No impact on users, since this is a private module, and low for
developers as the RC module use is very sparse in the library.
Tested with h5committest.
|
| |
|
|
|
|
|
|
| |
will generate correct H5Tinit.c file.
Tested: local gcc 4.8.2 linux
|
|
|
|
|
|
|
|
| |
Clean up more compiler warnings.
Tested on:
Mac OSX/64 10.8.4 (amazon) w/gcc, C++ & FORTRAN
(too minor to require h5committest)
|
|\
| |
| |
| |
| | |
This is the fix for "switch missing default case" warnings in src.
Mohamad & Vailin worked on this patch.
|
| |
| |
| |
| |
| |
| |
| | |
Rename static functions in H5Adense.c, H5B2cache.c, H5Bcache.c
Switch these functions to use FUNC_ENTER_STATIC* macros
Tested: koala
|
| | |
|
| |
| |
| |
| | |
H5HF_sect_single_dblock_info prototype
|
| |
| |
| |
| |
| |
| |
| |
| | |
Clean up compiler warnings
Tested on:
Mac OSX/64 10.8.4 (amazon) w/C++ & FORTRAN
(too minor to require h5committest)
|
| | |
|
| |
| |
| |
| |
| |
| |
| | |
Make compiler happier and issue less warnings.
Tested on:
Mac OSX/64 10.8.4 (amazon) w/gcc 4.8
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Tested: jam, koala, ostrich (h5committest)
Log from r23939:
Fix unused variables warnings in trunk
Rename static functions in H5Adense.c, H5B2cache.c, H5Bcache.c
Switch these functions to use FUNC_ENTER_STATIC* macros
Tested: koala
|
| |
| |
| |
| |
| |
| | |
Remove unused param (src) and unused var (hl) warnings
Tested on koala
|
| | |
|
| | |
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Merge changes from Coverity branch to trunk:
r20768:
Switch to snprintf, HDstrncat, HDstrncpy to address coverity issue 832.
r20812:
Use HDstrncpy. --gh
Tested on:
Mac OSX/64 10.8.4 (amazon) w/debug
Linux/32 2.4 (jam) w/debug
|
| | |
|
| |
| |
| |
| |
| |
| | |
This fixes: https://jira.hdfgroup.uiuc.edu/browse/HDFFV-8450
Tested on Jam.
|
| |
| |
| |
| | |
Tested: ummon
|
| |
| |
| |
| |
| |
| | |
(v)snprintf statement. Also fix use other uses of macros for windows.
Tested
|
|/ |
|
| |
|
| |
|
|
|
|
| |
This adds the UserMacros.cmake support needed.
|
| |
|
|
|
|
|
|
| |
'\/' to '\\'.
Tested: Windows
|
| |
|
|
|
|
|
|
|
| |
Fix return value from FAIL to NULL, to match the routines type.
Tested on:
Mac OSX/64 10.8.3 (amazon)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Description:
Failure to write fill values to the user's buffer when reading unallocated
chunks from datasets that have a fill value set to H5D_FILL_VALUE_DEFAULT.
A consequence of this was the reporting of spurious data values in h5dump
and h5diff output.
Solution:
Added check for fill value of H5D_FILL_VALUE_DEFAULT whenever fill value
setting was checked to decide whether or not to fill. This effectively
treats H5D_FILL_VALUE_DEFAULT the same as H5D_FILL_VALUE_USER rather than
H5D_FILL_VALUE_UNDEFINED.
Tested:
h5committest (platypus, ostrich, jam-pp, koala) ran successfully
(fillval test was modified to reveal and check for this error)
Note: RELEASE.txt was previously changed to reflect this fix. This
checkin was of a cleaner version of the code, but mostly to get this
full log message entered.
-This line, and those below, will be ignored--
M H5Dchunk.c
|
|
|
|
|
|
|
|
|
|
| |
Clean up warnings, switch library code to use Standard C/POSIX wrapper
macros, remove internal calls to API routines, update checkapi and checkposix
scripts.
Tested on:
Mac OSX/64 10.8.3 (amazon) w/C++ & FORTRAN
Big-Endian Linux/64 (ostrich)
|
| |
|
|
|
|
|
|
|
|
| |
Revert r23695, which breaks big-endian tests on ostrich, etc. Will
investigate and submit correction later.
Tested on:
BE & LE Linux systems (ostrich, koala, jam, emu)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Clean up warnings in H5Tconv.c (down to _only_ 9000 lines of output now!)
Merge changes from Coverity branch back to trunk:
r20684:
Fix for coverity bug #1721 which was due to the fix for coverity bug #943.
r20685:
Use HDstrncpy. --gh
r20761:
Purpose: Fix valgrind issues
Description:
Free image_data and data as appropriate in test_image.
r20762:
Purpose: Fix coverity issue 600
Description:
Add check for return value of H5O_close in H5Ocopy. Also cleaned up various
warnings.
r20763:
Purpose: Fix valgrind issues with h5stat
Description:
Modified h5stat to free "iter" before exit, and free "hand" before exit if
parse_command_line exits directly.
r20764:
fixed coverity issues:
69, 327, 614, 684, 685, 696, 697, 1681, 967, 826, 660, 80
r20765:
Fixed coverity bug 668
Pulled x * y * z multiply out of malloc operand into a separate n_elements variable to quiet integer overflow warning.
No actual integer overflow tests are performed since it's just a test program but I did add a check that n_elements is >= 1.
I also changed an error condition from doing its own close and returning -1 to "goto out;" like the rest of the program.
r20766:
Fixed coverity bug 667
Pulled x * y * z multiply out of malloc operand into a separate n_elements variable to quiet integer overflow warning.
No actual integer overflow tests are performed since it's just a test program.
Tested on:
Mac OSX/64 10.8.3 (amazon) w/C++ & FORTRAN
(h5committest upcoming)
|
|
|
|
|
|
| |
iteration process over datasets, groups, and files as Quincey suggested. I also removed H5I_search that I introduced in last commit but didn't actually used it.
Tested on jam and koala - simple change.
|
|
|
|
|
|
|
|
|
| |
followup commit. Quincey
reviewed my previous commit and suggested me to use H5I_iterate to iterate through
all opened objects in H5Z_unregister. I changed it in this commit.
Tested with h5committest.
|