| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
| |
undefined behavior in the alignment detection algorithm for integers in H5detect.c. Quincey decided to solve it in two steps. First, catch illegal instruction signal in the original algorithm. Second, use POSIX __alignof function to detect alignment if it's available. This checkin is the first step.
Tested on wren, jam, ostrich, platypas, and koala.
|
| |
|
|
|
|
|
|
|
|
|
| |
IDs by one. This is the second round of checkin after
receiving review comments from people. I put the safeguard in both H5F_get_objects and H5F_get_objects_cb to prevent
overfill the list.
tested with h5committest.
|
| |
|
|
|
|
|
|
|
|
| |
Studio warnings. Also added a void to a Windows-specific function.
These are both trivial changes that don't affect behavior.
Tested on: Visual Studio 2010 on 64-bit Windows 7
|
| |
|
|
|
|
|
|
| |
due to prototype" warnings by casting constants to size_t where expected by string functions.
Tested on jam, koala,ostrich and platypus with h5committest.
|
|
|
|
| |
tested with h5committest
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Correct H5I use of skip list to acquire the 'next' pointer in the skip
list after the ID's 'free' callback has been called, since it occasionally
deletes the 'next' node.
Also a little bit of code cleanup in other modules.
Tested on:
FreeBSD/32 8.2 (loyalty) w/gcc4.6, w/C++ & FORTRAN, in debug mode
FreeBSD/64 8.2 (freedom) w/gcc4.6, w/C++ & FORTRAN, in debug mode
Linux/32 2.6 (jam) w/PGI compilers, w/default API=1.8.x,
w/C++ & FORTRAN, w/threadsafe, in debug mode
Linux/64-amd64 2.6 (koala) w/Intel compilers, w/default API=1.6.x,
w/C++ & FORTRAN, in production mode
Solaris/32 2.11 (emu) w/deprecated symbols disabled, w/C++ & FORTRAN,
w/szip filter, w/threadsafe, in production mode
Linux/PPC 2.6 (ostrich) w/C++ & FORTRAN, w/threadsafe, in debug mode
|
|
|
|
|
|
|
|
| |
Clean up warnings
Tested on:
Mac OSX/64 10.8.4 (amazon) w/C++ & FORTRAN
(too minor for h5committest)
|
|
|
|
|
|
|
|
| |
Switch H5I internal data structure from using hash table to skip lists.
Tested on:
Mac OSX 10.8.4 (amazon) w/C++ & FORTRAN
FreeBSD, Linux, etc. forthcoming
|
|
|
|
| |
Tested: h5committest
|
| |
|
|
|
|
|
|
|
|
|
| |
IDs by one. I moved the safeguard in H5F_get_objects_cb
to the beginning of the function to prevent overfill the list. I added a new test case for this problem and fix in tfile.c.
Tested with h5committest.
|
|
|
|
|
|
| |
--disable-sharedlib-rpath configure option is invoked. Fix for HDFFV-8276.
Tested with h5committest and on hdf-duck.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Description:
With optimization enabled, gcc 4.8 inserts garbage into the padding bytes of
floating point types when assigning from a literal constant. This caused
problems when H5detect.c scanned the bits in floating point types to determine
their properties.
Modified H5detect.c to scan for padding before further analyzing the type, and
to ignore all information in the padding areas. Also removed code that
temporarily disabled optimization.
Tested: jam, koala, ostrich, platypus (h5committest)
|
|
|
|
|
|
|
| |
Add more usage info for UserMacros.
Add new option information about the Plugin default path.
Tested: local linux, jam
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Description:
H5Fis_hdf5 uses H5F_locate_signature to check if the file is hdf5. If it does
not locate the signature, H5F_locate_signature would issue an error and return
HADDR_UNDEF. H5Fis_hdf5 does not consider it an error if the signature is not
found, so it does not issue an error or clear the stack. The filled stack could
then cause issues later on.
Changed H5F_locate_signature to return herr_t, not issue an error if the
signature is not found, and added a parameter for a pointer to the signature
address that the function fills in.
Tested: jam, koala, ostrich (h5committest)
|
|
|
|
| |
Tested: jam, koala, ostrich (h5committest)
|
|
|
|
|
|
| |
include test.
Tested: jam
|
|
|
|
|
|
|
| |
Restrict GCC diagnostic pragmas to only gcc 4.6+
Tested on:
Mac OSX/64 10.8.4 (amazon) w/gcc 4.8
|
|
|
|
|
|
| |
Reviewed in H5T-61
Tested: local linux - cmake and autotools
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Clean up warnings, enable new compiler warning flag(s) and bring back
changes from Coverity branch:
r20813:
Remove the dead code as listed for coverity bug #1722. h5committested.
r20814:
Issue 69: Check return value and throw error if negative return. Also free datatype id on error
r20815:
Use HDstrncpy. --gh
r20816:
Replaced one last HDstrcat call with HDstrncat to resolve coverity issue 832.
r20817:
Use HDstrncpy and HDstrncat. --gh
r20818:
Purpose: Fix valgrind issues with h5jam
Description:
Modified h5jam to free strings strdup'd in parse_command_line before exit. Note
that they may still not be freed in case of error, due to the widespread use of
exit().
r20819:
Issue 80: change loop to use int as loop index.
r20820:
Maintenance: Fixed the bug found by coverity CID 788
There were two problems with this function:
1) it tried to unnecessary free NULL pointer
2) it tried to allocate c_name buffer that is done by H5Pget_class_name
Tested on:
Mac OSX 10.8.4 (amazon) w/gcc 4.8.1, C++ & FORTRAN
(too minor to require h5committest)
|
|
|
|
|
|
|
|
|
| |
double with GCC 4.8. A user in the forum found the
problem in H5detect.c (uninitialized buffer) and provided the solution. I checked it in yesterday. But it
turned out to be a false fix. So I'm back it out.
Tested on jam - reverse of changes.
|
|
|
|
|
|
|
|
| |
double with GCC 4.8. A user in the forum found the
problem in H5detect.c (uninitialized buffer) and provided the solution. Allen and I verified it.
Tested with h5committest and CMake on jam, koala, ostrich, playtus, and Allen's virtual machine.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
Count).
This is needed to avoid a conflict with the Read Context object to be
introduced in another Project.
No impact on users, since this is a private module, and low for
developers as the RC module use is very sparse in the library.
Tested with h5committest.
|
| |
|
|
|
|
|
|
| |
will generate correct H5Tinit.c file.
Tested: local gcc 4.8.2 linux
|
|
|
|
|
|
|
|
| |
Clean up more compiler warnings.
Tested on:
Mac OSX/64 10.8.4 (amazon) w/gcc, C++ & FORTRAN
(too minor to require h5committest)
|
|\
| |
| |
| |
| | |
This is the fix for "switch missing default case" warnings in src.
Mohamad & Vailin worked on this patch.
|
| |
| |
| |
| |
| |
| |
| | |
Rename static functions in H5Adense.c, H5B2cache.c, H5Bcache.c
Switch these functions to use FUNC_ENTER_STATIC* macros
Tested: koala
|
| | |
|
| |
| |
| |
| | |
H5HF_sect_single_dblock_info prototype
|
| |
| |
| |
| |
| |
| |
| |
| | |
Clean up compiler warnings
Tested on:
Mac OSX/64 10.8.4 (amazon) w/C++ & FORTRAN
(too minor to require h5committest)
|
| | |
|
| |
| |
| |
| |
| |
| |
| | |
Make compiler happier and issue less warnings.
Tested on:
Mac OSX/64 10.8.4 (amazon) w/gcc 4.8
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Tested: jam, koala, ostrich (h5committest)
Log from r23939:
Fix unused variables warnings in trunk
Rename static functions in H5Adense.c, H5B2cache.c, H5Bcache.c
Switch these functions to use FUNC_ENTER_STATIC* macros
Tested: koala
|
| |
| |
| |
| |
| |
| | |
Remove unused param (src) and unused var (hl) warnings
Tested on koala
|
| | |
|
| | |
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Merge changes from Coverity branch to trunk:
r20768:
Switch to snprintf, HDstrncat, HDstrncpy to address coverity issue 832.
r20812:
Use HDstrncpy. --gh
Tested on:
Mac OSX/64 10.8.4 (amazon) w/debug
Linux/32 2.4 (jam) w/debug
|
| | |
|
| |
| |
| |
| |
| |
| | |
This fixes: https://jira.hdfgroup.uiuc.edu/browse/HDFFV-8450
Tested on Jam.
|
| |
| |
| |
| | |
Tested: ummon
|
| |
| |
| |
| |
| |
| | |
(v)snprintf statement. Also fix use other uses of macros for windows.
Tested
|
|/ |
|