summaryrefslogtreecommitdiffstats
path: root/src
Commit message (Collapse)AuthorAgeFilesLines
* Harden H5G cache deserialization (#2810)Dana Robinson2023-04-261-68/+45
|
* Allow H5P_DEFAULT in H5Pget_vol_cap_flags and H5Pget_vol_id (#2807)jhendersonHDF2023-04-251-0/+6
|
* Sanitize H5HG cache deserialization code (#2808)Dana Robinson2023-04-252-153/+173
|
* Harden the v1 B-tree and local heap cache clients (#2803)Dana Robinson2023-04-254-96/+90
| | | | * Hardens v1 B-tree deserialize function * Harden the H5HL deserialize functionality
* H5Odtype.c decode cleanup (#2797)Dana Robinson2023-04-251-85/+234
| | | | * Adds bounds checking to H5Odtype.c * Minor tidy of dtypes test
* Sanitize object header message decode functions (#2795)Dana Robinson2023-04-2514-409/+407
| | | | | * Add buffer bounds checks * Convert asserts to real error handling to better detect broken files * General cleanup
* Add bug note to H5Dget_space_status documentation (#2788)jhendersonHDF2023-04-231-0/+14
|
* Sanitize the attribute object header msg code (#2749)Dana Robinson2023-04-191-39/+75
| | | | | Adds: * Bounds checks on buffer access * Better memory cleanup
* Sanitize the H5Oname decode function (#2757)Dana Robinson2023-04-191-20/+14
| | | | * Add bounds checking * Add memory cleanup
* Sanitize the ohdr modification time decode fxns (#2762)Dana Robinson2023-04-181-36/+38
|
* Clean up H5Oefl decode function (#2755)Dana Robinson2023-04-181-27/+28
| | | | * Use the H5_IS_BUFFER_OVERFLOW macro * Attempt to close local heap on errors if left open
* Removes programmer/date lines from src headers (#2747)Dana Robinson2023-04-1877-542/+203
|
* Check for invalid AAPL in H5Aopen (#2712)jhendersonHDF2023-04-171-5/+9
|
* Sanitize B-tree k ohdr message decode call (#2754)Dana Robinson2023-04-171-13/+20
| | | | * Check buffer bounds * Clean up memory on errors
* Sanitize the attribute info message decode fxn (#2748)Dana Robinson2023-04-171-13/+24
| | | | Adds bounds checking on the buffer in the attribute info message's decode function (H5O__ainfo_decode).
* H5Spoint.c: Fix mistake in comment (#2750)Dave Allured2023-04-161-1/+1
|
* Fix memory leaks when processing OH cont messages (#2723)Dana Robinson2023-04-142-12/+16
| | | | | | | | | | | Malformed object header continuation messages can result in a too-small buffer being passed to the decode function, which could lead to reading past the end of the buffer. Additionally, errors in processing these malformed messages can lead to allocated memory not being cleaned up. This fix adds bounds checking and cleanup code to the object header continuation message processing. Fixes #2604
* Cache macro parameter name consistency (#2738)Quincey Koziol2023-04-141-9/+9
| | | * More cache macro parameter consistency
* Cache macro error consistency (#2739)Quincey Koziol2023-04-142-86/+70
| | | * Pass failure value consistently to all macro errors
* Move cache image macros (#2732)Quincey Koziol2023-04-142-33/+42
| | | | | | * Move cache image stats macros to cache image source file * Disable formatting on the macros
* Cache macro tidy (#2731)Quincey Koziol2023-04-141-98/+98
| | | * Make cache macro parameter names more consistent
* Fix out of bounds in `hdf5/src/H5Fint.c:2859` (#2691)Kobrin Eli2023-04-133-7/+72
|
* Fixed GH-2603, heap-buffer-overflow in H5O__linfo_decode (#2697)bmribler2023-04-131-6/+22
| | | | | | * Fixed GH-2603, heap-buffer-overflow in H5O__linfo_decode Verified with valgrind -v --tool=memcheck --leak-check=full h5dump POV-GH-2603 The several invalid reads shown originally are now gone.
* Remove unused macros (#2722)Quincey Koziol2023-04-131-147/+0
| | | * Remove unused macros
* Remove dead code for H5C__SLIST_OPT_ENABLED (#2721)Quincey Koziol2023-04-132-15/+1
| | | * Remove dead code for H5C__SLIST_OPT_ENABLED
* Refactor H5C_entry_in_skip_list (#2719)Quincey Koziol2023-04-133-13/+21
| | | * Refactor H5C__entry_in_skip_list to package scope
* Fix cache validate (#2718)Quincey Koziol2023-04-131-2/+2
|
* Refactor cache mark flush dep (#2711)Quincey Koziol2023-04-132-4/+4
|
* Refactor cache validation (#2699)Quincey Koziol2023-04-134-65/+62
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Correct concurrency bugs when running tests, along with a bugfix & small warning cleanup. * Committing clang-format changes * Allow spaces (and tabs) in VOL connector info string from environment variable. * Parse connector name from HDF5_PLUGIN_PATH environment variable better * Correct H5VLquery_optional to use H5VL routine instead of H5I. Also add an error message to the failure return value from not finding a plugin. * Play nice with existing plugin paths * Use API routine to determine if native connector is terminal. * Committing clang-format changes * Make string size larger, to allow for connectors with longer names. * Be more flexible about testing external pass through connectors, especially if they have registered new optional operations. * Make cache validation routines package local --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: AWS ParallelCluster user <ec2-user@ip-10-0-0-65.us-east-2.compute.internal> Co-authored-by: Koziol <qkoziol@88665a374c70.ant.amazon.com>
* Remove duplicated H5_IS_BUFFER_OVERFLOW macro (#2700)jhendersonHDF2023-04-121-5/+0
|
* Fix for github issue #2599: (#2665)vchoi-hdfgroup2023-04-121-1/+6
| | | | | | | | | | | | | | | * Fix for github issue #2599: As indicated in the description, memory leak is detected when running "./h5dump pov". The problem is: when calling H5O__add_cont_msg() from H5O__chunk_deserialize(), memory is allocated for cont_msg_info->msgs. Eventually, when the library tries to load the continuation message via H5AC_protect() in H5O_protect(), error is encountered due to illegal info in the continuation message. Due to the error, H5O_protect() exits but the memory allocated for cont_msg_info->msgs is not freed. When we figure out how to handle fuzzed files that we didn't generate, a test needs to be added to run h5dump with the provided "pov" file. * Add message to release notes for the fix to github issue #2599.
* Cache tidy (#2693)Quincey Koziol2023-04-127-1189/+524
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Correct concurrency bugs when running tests, along with a bugfix & small warning cleanup. * Committing clang-format changes * Allow spaces (and tabs) in VOL connector info string from environment variable. * Parse connector name from HDF5_PLUGIN_PATH environment variable better * Correct H5VLquery_optional to use H5VL routine instead of H5I. Also add an error message to the failure return value from not finding a plugin. * Play nice with existing plugin paths * Use API routine to determine if native connector is terminal. * Committing clang-format changes * Make string size larger, to allow for connectors with longer names. * Be more flexible about testing external pass through connectors, especially if they have registered new optional operations. * Bring style closer to library's agreed coding style * Committing clang-format changes --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: AWS ParallelCluster user <ec2-user@ip-10-0-0-65.us-east-2.compute.internal> Co-authored-by: Koziol <qkoziol@88665a374c70.ant.amazon.com>
* Clean up memory allocated when reading messages in H5Dlayout on error ↵glennsong092023-04-111-5/+15
| | | | (#2602) (#2687)
* Fix invalid memory access in H5O__ginfo_decode (#2663)mattjala2023-04-112-1/+21
|
* Add buffer overrun checks to H5O__layout_decode and H5O__sdspace_decode (#2679)jhendersonHDF2023-04-113-55/+268
| | | Co-authored-by: Larry Knox <lrknox@hdfgroup.org>
* Fix a heap buffer overflow during H5D__compact_readvv (GitHub #2606) (#2664)jhendersonHDF2023-04-111-0/+27
|
* Comment cleanup (#2689)Quincey Koziol2023-04-1119-1211/+146
| | | * Clean up content and redundant logging in comments.
* Remove dead code hidden behind #ifdef LATER (#2686)Dana Robinson2023-04-107-223/+0
|
* Fix memory leaks and aborts in H5O EFL decode (#2656)Dana Robinson2023-04-031-48/+61
| | | | | | | | | | | | | | | | | | | | | * Convert asserts to error handling in efl decode The function that decodes external data files object header messages would call assert() when parsing malformed files, causing applications to crash when linked against the debug library. This change converts these assert() calls to HDF5 error checks, so the messages are sanity checked in both release and debug mode and debug mode no longer crashes applications. Also cleaned up some error handling usage and debug checks. * Free memory on H5O efl decode errors * Add buffer size checks to efl msg decode * Add parentheses to math expressions Fixes GitHub #2605
* Avoid suppressing error output for non-tentative file opens (#2632)jhendersonHDF2023-04-011-11/+41
| | | | | * Avoid suppressing error output for non-tentative file opens * Update comment about tentative file opens
* Fix a memory corruption issue in H5S__point_project_simple (#2626)jhendersonHDF2023-03-241-1/+1
|
* Fix minor things noted when doing 1.10 merges (#2610)Dana Robinson2023-03-241-1/+1
| | | | * Duplicated HDF_RESOURCES_DIR from cmake_ext_mod merge * Typos in comments
* Subfiling VFD - fix issues with I/O concentrator selection strategies (#2571)jhendersonHDF2023-03-171-39/+71
| | | | | Fix multiple bugs with the SELECT_IOC_EVERY_NTH_RANK and SELECT_IOC_TOTAL I/O concentrator selection strategies and add a regression test for them
* Make sure that ONLY_SHARED_LIBS option is correctly set (#2544)Allen Byrne2023-03-131-4/+4
|
* Addressed various Doxygen grammar issues. (#2524)Scot Breitenfeld2023-03-1339-203/+203
| | | | | | | | | | * reviewed H5A * Addressed various grammar issues. * remove double words, spelling fixes * replace the use of rawdata with raw data
* Elaborate how cd_values get stored (#2522)Mark (he/his) C. Miller2023-03-081-4/+7
|
* docs: in -> out (#2514) (#2516)H. Joe Lee2023-03-081-1/+1
|
* Remove redundant and flawed documentation of H5D_chunk_iter_op_t from H5D.c ↵Mark Kittisopikul2023-03-081-26/+0
| | | | | (#2512) Forward port of 9f252f1 from #2329
* Fix new codespell issues (#2521)Mark Kittisopikul2023-03-083-3/+3
| | | | | * Fix new codespell issues * Have codespell ignore ./config/sanitizer/sanitizers.cmake
* Check for overflow when calculating on-disk attribute data size (#2459)Egbert Eich2023-03-021-4/+3
| | | | | | | | | | | | | | | | | * Remove duplicate code Signed-off-by: Egbert Eich <eich@suse.com> * Add test case for CVE-2021-37501 Bogus sizes in this test case causes the on-disk data size calculation in H5O__attr_decode() to overflow so that the calculated size becomes 0. This causes the read to overflow and h5dump to segfault. This test case was crafted, the test file was not directly generated by HDF5. Test case from: https://github.com/ST4RF4LL/Something_Found/blob/main/HDF5_v1.13.0_h5dump_heap_overflow.md