| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Bring r24803 & r24804 from trunk to 1.8 branch:
r24804:
Brought changes from Coverity branch back to trunk, and cleaned up misc.
other warnings & formatting issues:
r20833:
Fixed Coverity 667 and 668 with real integer overflow tests this time.
r20834:
Use HDstrncpy and HDstrncat. --gh
r20835:
Change to use strncpy - use base_len + 1 for line 156, use HDstrlen(path) + 1 for line 159
r20836:
Fixed coverity 585 by casting output of fgetc() to a char.
r20837:
Changed sprintf calls to snprintf with size 1 less than the allocated buffer to address coverity issue #967.
r24803:
Rename GCC_DIAG_OFF/ON macros to H5_GCC_DIAG_OFF/ON and move from
src/H5private.h to src/H5public.h. Wrap typedef of hsize_t and hssize_t
in DIAG_OFF(long-long) macros.
Clean up a bunch of "macro '-' is unused" warnings.
Tested on:
Mac OSX/64 10.9.2 (amazon) w/C++, FORTRAN & parallel
(too minor to require h5committest)
|
|
|
|
|
|
|
|
|
|
|
|
| |
Tested: ostrich, platypus (h5committest, apparent system issue on jam and koala)
Log from r24635:
Change assertion to condition check/error return. Should fix periodic
assertion failure in fheap test (in test that is expected to fail cleanly).
Fix typo in H5detect.c
Tested: ostrich, platypus (h5committest - jam and koala having issues)
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Bring r24769 & r24772 from trunk to 1.8 branch:
Check in Mohamad's changes to support collective I/O on point selections,
along with some other minor cleanups.
Correct some dynamically sized arrays that fail on Windows.
Tested on:
Mac OSX/64 10.9.2 (amazon) w/parallel
(And has been through the daily test regime on the trunk)
|
| |
|
| |
|
|
|
|
|
|
| |
HDFFV-8505: UD filter changes to remove filters in h5repack.
Tested: local linux
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Note: despite the log from r24635, it was decided that this is the actual fix
for the error described in HDFFV-8647 that is not specific to BSD. This does
not address the BSD issue, which is apparently unrelated.
Tested: jam, ostrich, platypus (h5committest, apparent system issue on koala)
Log from r24635:
Change some range check assertions to errors in H5HF_man_remove in an attempt
to aid in diagnosing issue HDFFV-8647.
Tested: ummon
|
|
|
|
|
|
| |
LT_ADD_LIBHDF5_DEPENDENCY is used in Makefiles but the declaration in configure.ac is missing.
Copied declaration from trunk. Tested with h5committest on jam ostrich koala and platypus(cmake).
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Bring r24726 & r24727 from trunk to 1.8 branch:
Description:
Revert some earlier usage of strncpy, which was incorrect.
Bring Coverity changes from branch back to trunk:
r20821:
Use HDstrncpy. --gh
(Fixed already, with strdup)
r20822:
(Not merged, incorrect use of HDstrncpy())
r20823:
(Not merged, incorrect use of HDstrncpy())
r20824:
Maintenance: Bug fix: addressed CID 666.
Value stored at *expression_len should be used in the call to
HD5packFstring to avoid overflow (and unnecessary arithmetic
calculation and casting)
r20825:
Issue 642: Added check for error and handler with print to stderr and exit.
r20826:
Undo revision 20818, as that issue has already been fixed in the 1.8 branch
and trunk (but not coverity branch)
r20827:
(Not merged, incorrect use of HDstrncpy())
r20828:
Use HDstrncpy. --gh
(Corrected use of strncpy())
r20829:
Check return of H5Lget_val(print_udata->fid, path, targbuf,
linfo->u.val_size + 1, H5P_DEFAULT) and if error set trgbuf[0] to 0.
Check if H5Lunpack_elink_val(targbuf, linfo->u.val_size, NULL,
&filename, &objname) was successful and allow print. Otherwise filename
and objname are not created. (init those to NULL)
r20830:
resolved coverity issues 939, 940, 941, 944, and 947.
all were complaints about use of sprintf, and in all cases, the
buffers used were large enough for all eventualities.
Resolved issue by replacing calls to sprintf with calls
to snprintf.
r20831:
Maintenance: Addressed CID 852
Replaced sprintf with snprintf
r20832:
Purpose: Fix valgrind issues with hl/examples/ex_image2
Description:
Modified hl/examples/ex_image2 to free global "gbuf" before exit.
Tested on:
Mac OSX/64 10.9.1 (amaon) w/C++, FORTRAN & Threadsafety
(too minor to require h5committest)
|
|
|
|
|
|
|
| |
rename H5V to H5VM since H5V is needed in the fastforward project for
view objects. The addition of view objects in the fastforward project
is expected to be brough into the trunk sometimes in the future, which
is why we need to make this change.
|
|
|
|
|
|
|
|
|
| |
Tested: jam, ostrich, platypus (h5committest, apparent system issue on koala)
Log from r24463:
Issue 8484 - Segfault during H5Fopen of corrupt file. I put a condition check to make sure a pointer isn't NULL.
Tested on jam - very simple change.
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
allocate and use the H5AC_aux_t struct even if num_procs == 1. This
was a bug exposed by running a single process with a program that
generates lots of dirty metadata that needs to be flushed.
--This line, and those below, will be ignored--
_M .
M src/H5AC.c
|
|
|
|
|
|
|
|
|
|
|
| |
Bring r24476 from trunk to 1.8 branch:
Remove duplicate "intent" flags from top & shared file structures, leaving
them only in the shared file structure.
Tested on:
Mac OSX/64 10.9.0 (amazon) w/gcc 4.8, both parallel & serial
(too minor to require h5committest)
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
memory leak
when the thread-safe version of the library is built.
Part of HDFFV-8518.
Tested on:
32-bit LE linux (jam) with threadsafe and callstack enabled.
(very minor change)
|
|
|
|
|
|
| |
undefined behavior in the alignment detection algorithm for integers in H5detect.c. Quincey decided to solve it in two steps. First, catch illegal instruction signal in the original algorithm. Second, use POSIX __alignof function to detect alignment if it's available. This checkin is the first step. I merged the change from the trunk.
Tested on wren, jam, ostrich, platypas, and koala.
|
|
|
|
|
|
| |
IDs. I merged the fix the trunk. I put the safeguard in both H5F_get_objects and H5F_get_objects_cb to prevent overfill the list. I also added test cases in tfile.c.
Tested with h5committest on jam, koala, ostrich, and platypus.
|
|
|
|
|
|
|
| |
Added volatile keyword to find_bias() function in H5detect. Fixes HDFFV-8547.
Change to H5win32defs.h fixes a minor typo.
Tested on 64-bit Visual Studio 2010 / 64-bit Windows 7 (Visual Studio warning)
|
|
|
|
|
|
|
|
| |
- Fixed a couple of commenting typos in configure.ac.
Tested on: 32-bit LE linux (jam) w/ parallel and Fortran
These are minor changes, hence the limited testing.
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Bring r24256 & r24261 from trunk to 1.8 branch:
Switch H5I internal data structure from using hash table to skip lists.
Also, a few misc. cleanups.
Tested on:
FreeBSD/32 8.2 (loyalty) w/gcc4.6, w/C++ & FORTRAN, in debug mode
FreeBSD/64 8.2 (freedom) w/gcc4.6, w/C++ & FORTRAN, in debug mode
Linux/32 2.6 (jam) w/PGI compilers, w/default API=1.8.x,
w/C++ & FORTRAN, w/threadsafe, in debug mode
Linux/64-amd64 2.6 (koala) w/Intel compilers, w/default API=1.6.x,
w/C++ & FORTRAN, in production mode
Solaris/32 2.11 (emu) w/deprecated symbols disabled, w/C++ & FORTRAN,
w/szip filter, w/threadsafe, in production mode
Linux/PPC 2.6 (ostrich) w/C++ & FORTRAN, w/threadsafe, in debug mode
|
|
|
|
|
|
| |
RELEASE.txt for new info.
The 1.8 branch is open now for code changes.
|
| |
|
|
|
|
|
|
|
|
| |
unsigned long long. Allen confirmed the problem is gone. So I took
out the macro CYGWIN_ULLONG_TO_LDOUBLE_ROUND_PROBLEM. It skipped the test related to this issue.
Tested with h5committest.
|
|
|
|
| |
Tested: local linux
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Tested: jam, koala, ostrich, platypus (h5committest)
Log from r24171:
Purpose: Fix problem with gcc 4.8
Description:
With optimization enabled, gcc 4.8 inserts garbage into the padding bytes of
floating point types when assigning from a literal constant. This caused
problems when H5detect.c scanned the bits in floating point types to determine
their properties.
Modified H5detect.c to scan for padding before further analyzing the type, and
to ignore all information in the padding areas. Also removed code that
temporarily disabled optimization.
Tested: jam, koala, ostrich, platypus (h5committest)
|
|
|
|
|
|
|
|
| |
UD plugins.
Also warning session fixes.
Tested: CMake local linux
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Tested: jam, koala, ostrich, platypus (h5committest)
Log from r24140:
Purpose: Remove problematic abandonment of error stack
Description:
H5Fis_hdf5 uses H5F_locate_signature to check if the file is hdf5. If it does
not locate the signature, H5F_locate_signature would issue an error and return
HADDR_UNDEF. H5Fis_hdf5 does not consider it an error if the signature is not
found, so it does not issue an error or clear the stack. The filled stack could
then cause issues later on.
Changed H5F_locate_signature to return herr_t, not issue an error if the
signature is not found, and added a parameter for a pointer to the signature
address that the function fills in.
Tested: jam, koala, ostrich (h5committest)
|
|
|
|
|
|
|
|
|
| |
Tested: jam, koala, ostrich, platypus (h5committest)
Log from r24139:
Remove "will never be exectued" warnings in H5detect.c
Tested: jam, koala, ostrich (h5committest)
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Tested: jam, koala, ostrich, platypus (h5committest)
Log from r23987:
Merge r23939 from reduce_warning branch to trunk
Tested: jam, koala, ostrich (h5committest)
Log from r23939:
Fix unused variables warnings in trunk
Rename static functions in H5Adense.c, H5B2cache.c, H5Bcache.c
Switch these functions to use FUNC_ENTER_STATIC* macros
Tested: koala
|
|
|
|
|
|
|
|
| |
Revert accidental checkin of a patch that disables file truncation for
parallel I/O.
Tested on:
MacOSX/64 10.8.4 (amazon)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Bring r24101 & 24111 from trunk to 1.8 branch:
r24101:
=======
Description:
Clean up warnings, enable new compiler warning flag(s) and bring back
changes from Coverity branch:
r20813:
Remove the dead code as listed for coverity bug #1722. h5committested.
r20814:
Issue 69: Check return value and throw error if negative return. Also free datatype id on error
r20815:
Use HDstrncpy. --gh
r20816:
Replaced one last HDstrcat call with HDstrncat to resolve coverity issue 832.
r20817:
Use HDstrncpy and HDstrncat. --gh
r20818:
Purpose: Fix valgrind issues with h5jam
Description:
Modified h5jam to free strings strdup'd in parse_command_line before exit. Note
that they may still not be freed in case of error, due to the widespread use of
exit().
r20819:
Issue 80: change loop to use int as loop index.
r20820:
Maintenance: Fixed the bug found by coverity CID 788
There were two problems with this function:
1) it tried to unnecessary free NULL pointer
2) it tried to allocate c_name buffer that is done by H5Pget_class_name
r24111:
=======
Description:
Restrict GCC diagnostic pragmas to only gcc 4.6+
Tested on:
Mac OSX 10.8.4 (amazon) w/gcc 4.8.1, C++ & FORTRAN
(too minor to require h5committest)
|
|
|
|
|
|
| |
scripts. HDFFV-8498 merge from trunk.
Tested: local linux - cmake and autotools
|
| |
|
|
|
|
|
|
| |
them back for OpenVMS. But I took out the test case in dtransform.c which has problem. See Jira issue VMS-8.
Tested on jam.
|
|
|
|
|
|
|
|
|
| |
H5T__conv_f_i for OpenVMS because
they have problem to convert between integers and floating numbers. I also commented out the test
case in dt_arith.c for OpenVMS.
Tested on jam - simple change.
|
|
|
|
|
|
|
| |
Also add default switch blocks to h5import.
Merge h5dump any_path option from trunk.
Tested: local linux
|
| |
|
|
|
|
|
| |
This is the fix for "switch missing default case" warnings in src.
Mohamad & Vailin worked on this patch.
|
|
|
|
|
|
|
|
|
|
| |
Bring r24030 from trunk to 1.8 branch:
Clean up more compiler warnings.
Tested on:
Mac OSX/64 10.8.4 (amazon) w/gcc, C++ & FORTRAN
(too minor to require h5committest)
|
|
|
|
|
|
|
|
|
|
| |
Bring r24020 from trunk to 1.8 branch:
Clean up compiler warnings
Tested on:
Mac OSX/64 10.8.4 (amazon) w/C++ & FORTRAN
(too minor to require h5committest)
|
|
|
|
|
|
|
|
|
|
| |
Bring r23988 from trunk to 1.8 branch:
Make compiler happier and issue less warnings.
Tested on:
Mac OSX/64 10.8.4 (amazon) w/gcc 4.8
(daily tested on trunk)
|
| |
|
| |
|
| |
|
| |
|