summaryrefslogtreecommitdiffstats
path: root/src
Commit message (Collapse)AuthorAgeFilesLines
* Add buffer overrun checks to H5O__layout_decode and H5O__sdspace_decode ↵jhendersonHDF2023-04-153-53/+270
| | | | (#2679) (#2729)
* Fix a heap buffer overflow during H5D__compact_readvv (GitHub #2606) (#2664) ↵jhendersonHDF2023-04-151-0/+27
| | | | (#2726)
* H5O__pline_decode() Make more resilient to out-of-bounds read (#2210) (#2733)jhendersonHDF2023-04-152-2/+18
| | | | | | | | | Malformed hdf5 files may have trunkated content which does not match the expected size. When this function attempts to decode these it may read past the end of the allocated space leading to heap overflows as bounds checking is incomplete. Make sure each element is within bounds before reading. This fixes CVE-2019-8396 / HDFFV-10712 / github bug #2209.
* Fix for github issue #2599: (#2665) (#2735)vchoi-hdfgroup2023-04-141-1/+6
| | | | | | | | | | | | As indicated in the description, memory leak is detected when running "./h5dump pov". The problem is: when calling H5O__add_cont_msg() from H5O__chunk_deserialize(), memory is allocated for cont_msg_info->msgs. Eventually, when the library tries to load the continuation message via H5AC_protect() in H5O_protect(), error is encountered due to illegal info in the continuation message. Due to the error, H5O_protect() exits but the memory allocated for cont_msg_info->msgs is not freed. When we figure out how to handle fuzzed files that we didn't generate, a test needs to be added to run h5dump with the provided "pov" file.
* Avoid suppressing error output for non-tentative file opens (#2632) (#2669)jhendersonHDF2023-04-131-7/+43
| | | | | * Avoid suppressing error output for non-tentative file opens * Update comment about tentative file opens
* * Convert asserts to error handling in efl decode (#2709)Dana Robinson2023-04-131-48/+61
| | | | | | | | | | | | | | | | | | | The function that decodes external data files object header messages would call assert() when parsing malformed files, causing applications to crash when linked against the debug library. This change converts these assert() calls to HDF5 error checks, so the messages are sanity checked in both release and debug mode and debug mode no longer crashes applications. Also cleaned up some error handling usage and debug checks. * Free memory on H5O efl decode errors * Add buffer size checks to efl msg decode * Add parentheses to math expressions Fixes GitHub #2605
* Port h5dchunk_iter_hsizet_size #2074 to hdf5_1_12 branch (#2329)Mark Kittisopikul2023-03-293-29/+3
|
* Minor cherry-pick merges to 1.12 (#2581)Larry Knox2023-03-292-8/+10
|
* Fix a memory corruption issue in H5S__point_project_simple (#2626) (#2630)jhendersonHDF2023-03-291-1/+1
|
* Make sure that ONLY_SHARED_LIBS option is correctly set (#2546)Allen Byrne2023-03-141-4/+4
|
* Update Copyright headers. (#2534)Larry Knox2023-03-13405-410/+0
|
* Fix new codespell issues (#2521) (#2530)Larry Knox2023-03-103-3/+3
| | | | | | | | | | | | | * Fix new codespell issues (#2521) * Fix new codespell issues * Have codespell ignore ./config/sanitizer/sanitizers.cmake * Fix typo in genparser. --------- Co-authored-by: Mark Kittisopikul <mkitti@users.noreply.github.com>
* 1.12 Merge doxygen plist tables changes #2470 from develop (#2505)Allen Byrne2023-03-0121-826/+219
| | | | | | | | | * Merge doxygen plist tables changes #2470 from develop * Add new/moved files * More add new/moved files * Doxy corrections
* Fix for HDFFV-11052: h5debug fails on a corrupted file (h5_nrefs_POC)… ↵vchoi-hdfgroup2023-02-262-24/+32
| | | | | | | | | | | | | | | | | | | | | | | | (#2291) (#2496) * Fix for HDFFV-11052: h5debug fails on a corrupted file (h5_nrefs_POC) producing a core dump. When h5debug closes the corrupted file, the library calls H5F__dest() which performs all the closing operations for the file "f" (H5F_t *) but just keeping note of errors in "ret_value" all the way till the end of the routine. The user-provided corrupted file has an illegal file size causing failure when reading the image during the closing process. At the end of this routine it sets f->shared to NULL and then frees "f". This is done whether there is error or not in "ret_value". Due to the failure in reading the file earlier, the routine then returns error. The error return from H5F__dest() causes the file object "f" not being removed from the ID node table. When the library finally exits, it will try to close the file objects in the table. This causes assert failure when H5F_ID_EXISTS(f) or H5F_NREFS(f). Fix: a) H5F_dest(): free the f only when there is no error in "ret_value" at the end of the routine. b) H5VL__native_file_close(): if f->shared is NULL, free "f"; otherwise, perform closing on "f" as before. c) h5debug.c main(): track error return from H5Fclose(). * Committing clang-format changes Co-authored-by: vchoi <vchoi@jelly.ad.hdfgroup.org> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
* 1.12 Merge Correct pkgconfig variables and libraries #2259 (#2478)Allen Byrne2023-02-171-4/+14
| | | | | * Merge Correct pkgconfig variables and libraries #2259 * Fix spacing
* Brings mirror VFD test fixes from develop (#2392)Dana Robinson2023-01-051-36/+36
|
* Minor change to H5private.h to bring in line with develop (#2391)Dana Robinson2023-01-051-20/+5
|
* Fix for HDFFV-10840: Instead of using fill->buf for datatype conversi… (#2277)vchoi-hdfgroup2022-12-121-14/+11
| | | | | | | | | | | | | | | * Fix for HDFFV-10840: Instead of using fill->buf for datatype conversion (#2153) * Fix for HDFFV-10840: Instead of using fill->buf for datatype conversion if it is large enough, a buffer is allocated regardless so that the element in fill->buf can later be reclaimed. Valgrind is run on test/set_extent.c and there is no memory leak. * Add information of this fix to release notes. * Change macos version for CI to macos-11 until accum test failure is fixed for macos 12. Co-authored-by: Larry Knox <lrknox@hdfgroup.org>
* 1.12 Merge HDFGroup#2175 Implement option for using CMake GNUInstallDirs (#2221)Allen Byrne2022-11-042-6/+6
|
* Merge #2198 correct CMake MPI linking (#2215)Allen Byrne2022-11-041-6/+6
|
* Fix problem with variable length attributes being accessed through multiple ↵Neil Fortner2022-11-041-0/+4
| | | | file handles (#2181) (#2207)
* Fixed an issue that could occur when combining hyperslab selections (#2122) ↵Neil Fortner2022-10-041-2/+2
| | | | (#2138)
* 1 12 doxygen merge from 1.10 (#2094)Allen Byrne2022-09-1312-17/+41
|
* Address review comments from downstream merge of #2016 (#2073) (#2081)Neil Fortner2022-09-011-3/+5
|
* Fix bug in attribute type conversion wiith compound types - merge to 1.12 ↵Neil Fortner2022-08-241-9/+44
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (#2061) * Fix bug in attribute type conversion wiith compound types (#2016) * Fix bug in attribute type conversion where the background buffer would not be initialized with the destination contents when necessary. Other minor simplification. * Committing clang-format changes * Fix warnings. * Address review comments. Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * Add note to RELEASE.txt for GitHub #2016 (#2030) * Fix bug in attribute type conversion where the background buffer would not be initialized with the destination contents when necessary. Other minor simplification. * Committing clang-format changes * Fix warnings. * Address review comments. * Add RELEASE.txt note for PR #2016 * Add GitHub number to release note Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
* Persist dataset access properties when using H5Fstart_swmr_write - merge to ↵Neil Fortner2022-08-224-31/+121
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 1.12 branch (#2031) * Merge GitHub #1862 (HDFFV-11308) to 1.12 branch Persist dataset access properties when using H5Fstart_swmr_write (#1862) * Fix HDFFV-11308 - dataset access properties disappear when using H5Fstart_swmr_write. * Committing clang-format changes * Add test for H5Fstart_swmr_write() persisting DAPL settings. Fix bugs in the library exposed by this test. * Committing clang-format changes Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * Fix bug in swmr.c introduced with recent merge (double_t) (#1913) * Fix HDFFV-11308 - dataset access properties disappear when using H5Fstart_swmr_write. * Committing clang-format changes * Add test for H5Fstart_swmr_write() persisting DAPL settings. Fix bugs in the library exposed by this test. * Committing clang-format changes * Replace accidental use of double_t in swmr.c with double. Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * Add note to RELEASE.txt for HDFFV-11308 (#2029) * Add note to RELEASE.txt for HDFFV-11308 * Fix formatting error in RELEASE.txt * Committing clang-format changes * Fix inappropriate use of HGOTO_ERROR (#2055) Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
* Spelling fixes for codespell (#2038)Dana Robinson2022-08-1842-62/+62
| | | | | | | * Spelling fixes for codespell * Committing clang-format changes Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
* Backport H5Dchunk_iter to 1.12 branch (#1970)Mark Kittisopikul2022-08-166-16/+269
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Revert "Revert H5Dchunk_iter changes in hdf5_1_12_1 (#733)" This reverts commit 10abe9a8b4985a18a0c88615686184d233d7b845. * Apply clang-format * Reincorporate spelling fix from #1166 * Incorporate H5Dchunk_iter changes from #161 * Backport to 1.12: Adds a quick for for some egregious chunk_info badness (#722) * Backport to 1.12: Converts testhdf5 macros to h5test macros in chunk_info.c (#1820) The two macro schemes were not designed to work together. Also quiets some MSVC warnings about comparing pointers and integers. * Backport to 1.12: H5Dchunk_iter now passes offsets in units of dataset elements, fix #1419 (#1969) * H5Dchunk_iter now passes chunk dimension scaled offsets, fix #1419 * Update docs for H5Dchunk_iter, H5Dget_chunk_info* Modified description for `H5Dchunk_iter`, `H5Dget_chunk_info`, and `H5Dget_chunk_info_by_coord` to the following * offset Logical position of the chunk’s first element in units of dataset elements * filter_mask Bitmask indicating the filters used when the chunk was written * size Chunk size in bytes, 0 if the chunk does not exist * Sync H5Dchunk_iter documentation with develop * Remove H5VL_DATASET_WAIT references from 1.12 * Backport to 1.12 #161, #1474, review comments Co-authored-by: Dana Robinson <43805+derobins@users.noreply.github.com>
* [1.12 Merge] Hdf5 1 12 develop merges (#2012)jhendersonHDF2022-08-163-8/+23
| | | | | | | | | | | | | | | | | * Fix invalid comment about character encoding in H5Fint.c (#1845) * Convert assertion on (possibly corrupt) file contents to normal error check (#1861) * Convert assertion on (possibly corrupt) file contents to normal error check * Committing clang-format changes Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * Avoid allocating chunk map for contiguous and compact dataset I/O (#1927) * Add documentation for parallel compression feature (#1981) Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
* Fix Error examples (#1997)Allen Byrne2022-08-111-267/+211
|
* Merge UG from 1.10 and add prelim vol section (#1980)Allen Byrne2022-08-0927-194/+14021
| | | | | | | * Merge UG from 1.10 and add prelim vol section * Spelling fixes * Merge format and autotools javadoc from 1.10
* clang 13 format #1933 (#1939)Allen Byrne2022-07-27332-3535/+3544
|
* Implement support for big I/O for independent reads (#1446) (#1719)jhendersonHDF2022-05-031-16/+34
| | | | | | | | | | | | | * Implement big I/O support for independent reads. Add test for this. * Committing clang-format changes * Update big I/O code in H5FD__mpio_write() to match that in H5FD__mpio_read(). Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Neil Fortner <nfortne2@hdfgroup.org> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
* [1.12 Merge]Hdf5 1 12 warnings fixes (#1715)jhendersonHDF2022-05-0339-454/+481
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Warnings fixes (#1680) * Clean stack size warnings in sio_engine (#1687) * Fixes stack size warnings in tcoords.c (#1688) * Address some warnings from casting away of const (#1684) * Fixes stack size warnings in ntypes (#1695) * Fixes stack size warnings in dtransform (#1696) * Fixes stack size warnings in set_extent test (#1698) * Be a bit safer with signed arithmetic, thus quieting some signed-overflow warnings from GCC (#1706) * Avoid a signed overflow: check the range of `entry_ptr->age` before increasing it instead of increasing it and then checking the range. This quiets a GCC warning. * Avoid the potential for signed overflow by rewriting expressions `MAX(0, fwidth - n)` as `MAX(n, fwidth) - n` for various `n`. This change quiets some GCC warnings. * Change some local variables that cannot take sensible negative values from signed to unsigned. This quiets GCC warnings about potential signed overflow. * In a handful of instances, check the range of a signed integer before increasing/decreasing it, just in case the increase/decrease overflows. This quiets a handful of GCC signed-overflow warnings. * Committing clang-format changes Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * Fix object size warnings in cache.c test (#1701) * Fix some const cast and stack/static object size warnings (#1700) * Fix various warnings * Move HDfree_const to H5private.h for wider use * Print output from all ranks in parallel tests on allocation failure * Move const pointer freeing macro to h5test.h for now * Stop lying about H5S_t const-ness (#1209) Hyperslabs can be reworked inside several H5S callbacks, making H5S_t non-const in some places where it is marked const. This change switches these incorrectly const H5S_t pointer parameters and variables to non-const where appropriate. * Fix a few warnings after recent H5S const-related changes (#1225) * Adjustments for HDF5 1.12 Co-authored-by: Dana Robinson <43805+derobins@users.noreply.github.com> Co-authored-by: David Young <dyoung@hdfgroup.org> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
* Hdf5 1 12 Miscellaneous warnings fixes (#1718)jhendersonHDF2022-05-039-47/+61
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Fixes const issues in the version 2 B-trees (#1172) The operations that were changed are fundamentally not const since the shadow operation can modify the node structure when SWMR is in use. * Quiets const warning in H5RS code (#1181) * Avoid calling H5Ropen_object with a misaligned H5R_ref_t: copy the (#1171) * Avoid calling H5Ropen_object with a misaligned H5R_ref_t: copy the raw H5R_ref_t bytes to a heap buffer that's known to have the right alignment. * Committing clang-format changes * Use an automatic H5R_ref_t instead of malloc'ing one. Go ahead and initialize the H5R_ref_t to all-0s so that arbitrary stack content doesn't foul things up. Bail out with an error if `size` exceeds `sizeof(H5R_ref_t)`. * Committing clang-format changes Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * Miscellaneous warnings fixes Co-authored-by: Dana Robinson <43805+derobins@users.noreply.github.com> Co-authored-by: David Young <dyoung@hdfgroup.org> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
* Fix SWMR/refresh bug hidden by library free lists (#1702) (#1711)Larry Knox2022-05-021-4/+10
|
* Update version to 1.12.3-1 after creating hdf5_1_12_2 releaseLarry Knox2022-04-081-3/+3
| | | | | preparation branch. Clean release note entries from RELEASE.txt.
* 1.12: Last round of normalizations for 1.12.2 (#1621)Dana Robinson2022-04-089-68/+105
|
* Brings minor changes from headers in develop (#1618)Dana Robinson2022-04-087-38/+0
|
* Merge branch 'spelling-corrections' of https://github.com/lrknox/hdf5 into ↵Larry Knox2022-04-07109-269/+271
|\ | | | | | | lrknox-spelling-corrections
| * Merge branch 'hdf5_1_12' into spelling-correctionsLarry Knox2022-04-0711-2321/+204
| |\
| * | Committing clang-format changesgithub-actions2022-04-072-3/+5
| | |
| * | Commit codespell spelling corrections.Larry Knox2022-04-07110-273/+273
| | |
* | | Brings free list debugging changes from develop (#1615)Dana Robinson2022-04-072-30/+72
| | |
* | | 1.12: Brings 1.12 compiler options in line with develop (#1611)Dana Robinson2022-04-072-9/+9
| | | | | | | | | | | | | | | * Brings 1.12 compiler options in line with develop * Revert 'since' doxygen field in H5public.h
* | | Fixes H5E_ID error categores erroneously brought over from develop (#1613)Dana Robinson2022-04-073-3/+3
| | |
* | | Fix these Doxygen warnings #1581 (#1592)Allen Byrne2022-04-073-11/+10
| |/ |/|
* | Brings skip list try_free_safe changes from develop (#1612)Dana Robinson2022-04-072-476/+206
| |
* | Removes unused H5HP and H5MP packages (#1610)Dana Robinson2022-04-079-1848/+1
|/
* Clang warning fixes from develop. (#1583)Larry Knox2022-04-059-11/+20
|