summaryrefslogtreecommitdiffstats
path: root/src
Commit message (Collapse)AuthorAgeFilesLines
* [svn-r24726] Description:Quincey Koziol2014-02-206-75/+92
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Revert some earlier usage of strncpy, which was incorrect. Bring Coverity changes from branch back to trunk: r20821: Use HDstrncpy. --gh (Fixed already, with strdup) r20822: (Not merged, incorrect use of HDstrncpy()) r20823: (Not merged, incorrect use of HDstrncpy()) r20824: Maintenance: Bug fix: addressed CID 666. Value stored at *expression_len should be used in the call to HD5packFstring to avoid overflow (and unnecessary arithmetic calculation and casting) r20825: Issue 642: Added check for error and handler with print to stderr and exit. r20826: Undo revision 20818, as that issue has already been fixed in the 1.8 branch and trunk (but not coverity branch) r20827: (Not merged, incorrect use of HDstrncpy()) r20828: Use HDstrncpy. --gh (Corrected use of strncpy()) r20829: Check return of H5Lget_val(print_udata->fid, path, targbuf, linfo->u.val_size + 1, H5P_DEFAULT) and if error set trgbuf[0] to 0. Check if H5Lunpack_elink_val(targbuf, linfo->u.val_size, NULL, &filename, &objname) was successful and allow print. Otherwise filename and objname are not created. (init those to NULL) r20830: resolved coverity issues 939, 940, 941, 944, and 947. all were complaints about use of sprintf, and in all cases, the buffers used were large enough for all eventualities. Resolved issue by replacing calls to sprintf with calls to snprintf. r20831: Maintenance: Addressed CID 852 Replaced sprintf with snprintf r20832: Purpose: Fix valgrind issues with hl/examples/ex_image2 Description: Modified hl/examples/ex_image2 to free global "gbuf" before exit. Tested on: Mac OSX/64 10.9.1 (amaon) w/C++, FORTRAN & Threadsafety (too minor to require h5committest)
* [svn-r24725] HDFFV-8629: h5repack will not attempt to remove UD filters. ↵Allen Byrne2014-02-201-17/+21
| | | | | | h5repack requires a check for UD filters that also must check if the filter can be dynamically loaded. This require a change in the library that checks for this. Tested: locally and reviewed
* [svn-r24716] Snapshot version 1.9 release 172HDF Tester2014-02-162-3/+3
|
* [svn-r24709] rename H5V to H5VM since H5V is needed in the fastforward ↵Mohamad Chaarawi2014-02-1357-385/+385
| | | | | | | | | | | | project for view objects. The addition of view objects in the fastforward project is expected to be brough into the trunk sometimes in the future, which is why we need to make this change. Tested Manually on Jam and Ostrich. Tested with h5commitest - Koala with intel compilers failed, but nothing had to do with those changes. error on Koala: error while loading shared libraries: libirng.so
* [svn-r24698] Snapshot version 1.9 release 171HDF Tester2014-02-092-3/+3
|
* [svn-r24682] Add IF SHARED block around Windows PDB file generation command.Allen Byrne2014-02-041-2/+3
|
* [svn-r24681] Description:Scot Breitenfeld2014-02-041-3/+10
| | | | | | | | | Fix for HDF5/HDFFV-8620 H5Rget_name with NULL name parameter fails. The name parameter now excepts NULL, in which case the length of then name is returned. Tested: jam (intel and gnu)
* [svn-r24676] Snapshot version 1.9 release 170HDF Tester2014-02-022-3/+3
|
* [svn-r24635] Change some range check assertions to errors in H5HF_man_remove ↵Neil Fortner2014-01-161-2/+4
| | | | | | | | in an attempt to aid in diagnosing issue HDFFV-8647. Tested: ummon
* [svn-r24598] allocate and use the H5AC_aux_t struct even if num_procs == 1. ↵Mohamad Chaarawi2013-12-301-48/+42
| | | | | | | | | This was a bug exposed by running a single process with a program that generates lots of dirty metadata that needs to be flushed. h5committest done!
* [svn-r24476] Description:Quincey Koziol2013-11-307-26/+25
| | | | | | | | | Remove duplicate "intent" flags from top & shared file structures, leaving them only in the shared file structure. Tested on: Mac OSX/64 10.9.0 (amazon) w/gcc 4.8, both parallel & serial (too minor to require h5committest)
* [svn-r24465] Snapshot version 1.9 release 169HDF Tester2013-11-252-3/+3
|
* [svn-r24463] Issue 8484 - Segfault during H5Fopen of corrupt file. I put a ↵Raymond Lu2013-11-221-1/+1
| | | | | | condition check to make sure a pointer isn't NULL. Tested on jam - very simple change.
* [svn-r24368] Issue 8147 - clang's -fcatch-undefined-behavior exposed ↵Raymond Lu2013-10-281-4/+43
| | | | | | | undefined behavior in the alignment detection algorithm for integers in H5detect.c. Quincey decided to solve it in two steps. First, catch illegal instruction signal in the original algorithm. Second, use POSIX __alignof function to detect alignment if it's available. This checkin is the first step. Tested on wren, jam, ostrich, platypas, and koala.
* [svn-r24362] Snapshot version 1.9 release 168HDF Tester2013-10-272-3/+3
|
* [svn-r24360] Jira issue 8528: H5Fget_obj_ids overfilled the list of object ↵Raymond Lu2013-10-251-59/+73
| | | | | | | | | IDs by one. This is the second round of checkin after receiving review comments from people. I put the safeguard in both H5F_get_objects and H5F_get_objects_cb to prevent overfill the list. tested with h5committest.
* [svn-r24334] Snapshot version 1.9 release 167HDF Tester2013-10-202-3/+3
|
* [svn-r24333] Added a few volatile keywords to H5detect.c to quiet Visual ↵Dana Robinson2013-10-192-3/+3
| | | | | | | | Studio warnings. Also added a void to a Windows-specific function. These are both trivial changes that don't affect behavior. Tested on: Visual Studio 2010 on 64-bit Windows 7
* [svn-r24287] Snapshot version 1.9 release 166HDF Tester2013-10-132-3/+3
|
* [svn-r24285] Eliminate several "passing argument ... with different width ↵Larry Knox2013-10-105-7/+7
| | | | | | due to prototype" warnings by casting constants to size_t where expected by string functions. Tested on jam, koala,ostrich and platypus with h5committest.
* [svn-r24270] checkin coverity changes from 10/4/2013.Mohamad Chaarawi2013-10-091-0/+3
| | | | tested with h5committest
* [svn-r24261] Description:Quincey Koziol2013-10-074-10/+11
| | | | | | | | | | | | | | | | | | | Correct H5I use of skip list to acquire the 'next' pointer in the skip list after the ID's 'free' callback has been called, since it occasionally deletes the 'next' node. Also a little bit of code cleanup in other modules. Tested on: FreeBSD/32 8.2 (loyalty) w/gcc4.6, w/C++ & FORTRAN, in debug mode FreeBSD/64 8.2 (freedom) w/gcc4.6, w/C++ & FORTRAN, in debug mode Linux/32 2.6 (jam) w/PGI compilers, w/default API=1.8.x, w/C++ & FORTRAN, w/threadsafe, in debug mode Linux/64-amd64 2.6 (koala) w/Intel compilers, w/default API=1.6.x, w/C++ & FORTRAN, in production mode Solaris/32 2.11 (emu) w/deprecated symbols disabled, w/C++ & FORTRAN, w/szip filter, w/threadsafe, in production mode Linux/PPC 2.6 (ostrich) w/C++ & FORTRAN, w/threadsafe, in debug mode
* [svn-r24256] Description:Quincey Koziol2013-10-048-14/+14
| | | | | | | | Clean up warnings Tested on: Mac OSX/64 10.8.4 (amazon) w/C++ & FORTRAN (too minor for h5committest)
* [svn-r24255] Description:Quincey Koziol2013-10-0414-415/+402
| | | | | | | | Switch H5I internal data structure from using hash table to skip lists. Tested on: Mac OSX 10.8.4 (amazon) w/C++ & FORTRAN FreeBSD, Linux, etc. forthcoming
* [svn-r24224] HDFFV-8529: Space separate define stringsAllen Byrne2013-09-301-1/+1
| | | | Tested: h5committest
* [svn-r24218] Snapshot version 1.9 release 165HDF Tester2013-09-292-3/+3
|
* [svn-r24210] Jira issue 8528: H5Fget_obj_ids overfilled the list of object ↵Raymond Lu2013-09-271-14/+7
| | | | | | | | | IDs by one. I moved the safeguard in H5F_get_objects_cb to the beginning of the function to prevent overfill the list. I added a new test case for this problem and fix in tfile.c. Tested with h5committest.
* [svn-r24194] Don't add hdf5 library dependencies to lib files when ↵Larry Knox2013-09-241-0/+1
| | | | | | --disable-sharedlib-rpath configure option is invoked. Fix for HDFFV-8276. Tested with h5committest and on hdf-duck.
* [svn-r24186] Snapshot version 1.9 release 164HDF Tester2013-09-222-3/+3
|
* [svn-r24171] Purpose: Fix problem with gcc 4.8Neil Fortner2013-09-194-122/+125
| | | | | | | | | | | | | | Description: With optimization enabled, gcc 4.8 inserts garbage into the padding bytes of floating point types when assigning from a literal constant. This caused problems when H5detect.c scanned the bits in floating point types to determine their properties. Modified H5detect.c to scan for padding before further analyzing the type, and to ignore all information in the padding areas. Also removed code that temporarily disabled optimization. Tested: jam, koala, ostrich, platypus (h5committest)
* [svn-r24167] HDFFV-8513, HDFFV-8522 Plugin testing in h5repack, h5dump.Allen Byrne2013-09-193-6/+6
| | | | | | | Add more usage info for UserMacros. Add new option information about the Plugin default path. Tested: local linux, jam
* [svn-r24140] Purpose: Remove problematic abandonment of error stackNeil Fortner2013-09-133-36/+41
| | | | | | | | | | | | | | | Description: H5Fis_hdf5 uses H5F_locate_signature to check if the file is hdf5. If it does not locate the signature, H5F_locate_signature would issue an error and return HADDR_UNDEF. H5Fis_hdf5 does not consider it an error if the signature is not found, so it does not issue an error or clear the stack. The filled stack could then cause issues later on. Changed H5F_locate_signature to return herr_t, not issue an error if the signature is not found, and added a parameter for a pointer to the signature address that the function fills in. Tested: jam, koala, ostrich (h5committest)
* [svn-r24139] Remove "will never be exectued" warnings in H5detect.cNeil Fortner2013-09-131-42/+74
| | | | Tested: jam, koala, ostrich (h5committest)
* [svn-r24120] HDFFV-8345: plugin test properly checks static-exec result to ↵Allen Byrne2013-09-101-1/+1
| | | | | | include test. Tested: jam
* [svn-r24111] Description:Quincey Koziol2013-09-061-10/+5
| | | | | | | Restrict GCC diagnostic pragmas to only gcc 4.6+ Tested on: Mac OSX/64 10.8.4 (amazon) w/gcc 4.8
* [svn-r24104] HDFFV-8345: add User Defined filters to h5repack.Allen Byrne2013-09-062-2/+5
| | | | | | Reviewed in H5T-61 Tested: local linux - cmake and autotools
* [svn-r24103] Force NO optimization of H5detect.cAllen Byrne2013-09-062-2/+2
|
* [svn-r24101] Description:Quincey Koziol2013-09-055-48/+123
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Clean up warnings, enable new compiler warning flag(s) and bring back changes from Coverity branch: r20813: Remove the dead code as listed for coverity bug #1722. h5committested. r20814: Issue 69: Check return value and throw error if negative return. Also free datatype id on error r20815: Use HDstrncpy. --gh r20816: Replaced one last HDstrcat call with HDstrncat to resolve coverity issue 832. r20817: Use HDstrncpy and HDstrncat. --gh r20818: Purpose: Fix valgrind issues with h5jam Description: Modified h5jam to free strings strdup'd in parse_command_line before exit. Note that they may still not be freed in case of error, due to the widespread use of exit(). r20819: Issue 80: change loop to use int as loop index. r20820: Maintenance: Fixed the bug found by coverity CID 788 There were two problems with this function: 1) it tried to unnecessary free NULL pointer 2) it tried to allocate c_name buffer that is done by H5Pget_class_name Tested on: Mac OSX 10.8.4 (amazon) w/gcc 4.8.1, C++ & FORTRAN (too minor to require h5committest)
* [svn-r24098] Issue 8500 - H5detect.c has trouble to find info for long ↵Raymond Lu2013-09-041-2/+0
| | | | | | | | | double with GCC 4.8. A user in the forum found the problem in H5detect.c (uninitialized buffer) and provided the solution. I checked it in yesterday. But it turned out to be a false fix. So I'm back it out. Tested on jam - reverse of changes.
* [svn-r24095] Issue 8500 - H5detect.c has trouble to find info for long ↵Raymond Lu2013-09-031-0/+2
| | | | | | | | double with GCC 4.8. A user in the forum found the problem in H5detect.c (uninitialized buffer) and provided the solution. Allen and I verified it. Tested with h5committest and CMake on jam, koala, ostrich, playtus, and Allen's virtual machine.
* [svn-r24092] Snapshot version 1.9 release 163HDF Tester2013-09-012-3/+3
|
* [svn-r24087] Rename the private H5RC (reference count) module to H5UC (Use ↵Mohamad Chaarawi2013-08-3018-100/+106
| | | | | | | | | | | | Count). This is needed to avoid a conflict with the Read Context object to be introduced in another Project. No impact on users, since this is a private module, and low for developers as the RC module use is very sparse in the library. Tested with h5committest.
* [svn-r24068] Snapshot version 1.9 release 162HDF Tester2013-08-252-3/+3
|
* [svn-r24046] HDFFV-8500: set h5detect compile optimization to -O0Allen Byrne2013-08-211-1/+6
| | | | | | will generate correct H5Tinit.c file. Tested: local gcc 4.8.2 linux
* [svn-r24030] Description:Quincey Koziol2013-08-191-120/+0
| | | | | | | | Clean up more compiler warnings. Tested on: Mac OSX/64 10.8.4 (amazon) w/gcc, C++ & FORTRAN (too minor to require h5committest)
* [svn-r24027] merge r 23938 from reduce warnings branch into trunk.Mohamad Chaarawi2013-08-197-0/+39
|\ | | | | | | | | This is the fix for "switch missing default case" warnings in src. Mohamad & Vailin worked on this patch.
| * [svn-r23939] Fix unused variables warnings in trunkNeil Fortner2013-07-2611-188/+177
| | | | | | | | | | | | | | Rename static functions in H5Adense.c, H5B2cache.c, H5Bcache.c Switch these functions to use FUNC_ENTER_STATIC* macros Tested: koala
| * [svn-r23938] remove "switch missing default case" in src.Mohamad Chaarawi2013-07-268-0/+41
| |
| * [svn-r23937] Remove unused param / var warnings and fix ↵Jerome Soumagne2013-07-265-7/+9
| | | | | | | | H5HF_sect_single_dblock_info prototype
* | [svn-r24020] Description:Quincey Koziol2013-08-172-1/+5
| | | | | | | | | | | | | | | | Clean up compiler warnings Tested on: Mac OSX/64 10.8.4 (amazon) w/C++ & FORTRAN (too minor to require h5committest)