| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Bug Fix: HDFFV-8247
Description:
Failure to write fill values to the user's buffer when reading unallocated
chunks from datasets that have a fill value set to H5D_FILL_VALUE_DEFAULT.
A consequence of this was the reporting of spurious data values in h5dump
and h5diff output.
Solution:
Added check for fill value of H5D_FILL_VALUE_DEFAULT whenever fill value
setting was checked to decide whether or not to fill. This effectively
treats H5D_FILL_VALUE_DEFAULT the same as H5D_FILL_VALUE_USER rather than
H5D_FILL_VALUE_UNDEFINED.
Tested:
h5committest (platypus, ostrich, jam-pp, koala) ran successfully
(fillval test was modified to reveal and check for this error)
H5Dchunk.c:
fix in library code.
fillval.c:
Added test_partalloc to expose potential fill value issues.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Bring r25084, 25088, 25092, 25097 from trunk to 1.8 branch:
r25084:
Begin process of migrating from using property list IDs internally to the
library to using the internal generic property list data structure.
r25088:
Introduce "file I/O info" struct, to hold file & dxpl pointers, and start
propagating up through library.
r25092:
More migration to using H5F_io_info_t pointers and away from using
property list IDs internally. Also, clean up some compiler warnings in the
cache code.
r25097:
Make progress toward moving from DXPL IDs to property list structures
within the library. Also move the signature location code from the H5F
package to the H5FD package, where it's a better fit. Also, clean up some
more compiler warnings along the way.
Tested:
Mac OSX/64 10.9.2 (amazon) w/C++, FORTRAN & parallel
(h5committested on trunk)
|
|
|
|
|
|
|
|
| |
back fix for removing rpaths from lib files. The fix also removed dependencies on libhdf5, etc. when the --disable-sharedlib-rpath configure option was invoked.
Added instead configure variable hardcode_into_lib=no. This removes rpath from lib files on Linux and solaris machines.
Tested with h5committest on jam, koala, ostrich and platypus (cmake), and on emu and kite.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Bring r24995 and r24998 from the trunk to the 1.8 branch:
r24995:
Improve checks for NULL buffer from user during H5Dread/H5Dwrite calls.
r24998:
Check in Neil's changes for correctly handling case where library is
reinitialized through a deprecated routine.
Tested on:
Mac OSX/64 10.9.2 (amazon) w/serial & paralle
(change has baked on trunk for >7 days)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Merged r24993 from the trunk.
Adds core VFD write tracking functionality. When enabled, the core VFD
will track dirty regions of the file and only write out the changed
regions. The new H5Pget/set_core_write_tracking() API call controls this
feature. A new "core_paged" VFD target was added to the check-vfd target
in test/Makefile.am that runs all tests with the new write tracking
functionality.
Tested on:
32-bit LE linux (jam)
64-bit LE linux (koala)
64-bit BE linux (ostrich)
Each platform was tested with HDF5_DRIVER set to "core" and "core_paged".
Jam was also tested with the standard sec2 driver.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Merge of r24937 from the trunk
Adds H5free_memory to the API. This function should be used to free
memory allocated by the library (e.g., returned values from
H5Tget_tag, H5Pget_class_name, etc.).
This is mainly to help Windows applications deal with multiple CRT
instances, but can also be helpful when a debug memory manager is
being used or when the HDF5 API is being wrapped for managed languages
like Python and Java.
Tested on:
32-bit LE linux (jam) with fortran and C++
64-bit BE linux (ostrich)
64-bit LE linux (koala)
|
|
|
|
|
|
|
|
| |
Merge of r24416 from the trunk
Fixes a number of compiler warnings in the dsets test.
Tested on:
32-bit LE linux (jam) - very minor changes, mostly casts
|
|
|
|
| |
Tested: h5committest
|
|
|
|
| |
Tested: local linux
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Bring r24869 & r24875 from trunk to 1.8 branch:
Clean up more compiler warnings, plus merge a few Coverity bug fixes from
the hdf5_1_8_coverity branch back to the trunk:
r20877:
Purpose: Fix coverity issue 1723
Description:
Modified test_generate in hl/test_image to close file "f" before exit, even if
an error occurs.
r20879:
Issue 63: change check of return of H5Tget_nmembers to <=0. No need to go
futher if call fails as well as empty.
r20881:
Coverity #659 in Run 46: I changed the Line 442 where it tries to check whether
FLAG_PRINTED is TRUE. But it had just been set to FALSE. I took out the
condition check in the print statement.
Tested on:
Mac OSX/64 10.9.2 (amazon) w/C++, FORTRAN & Parallel
(daily tested on trunk)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Bring r24864 from trunk to 1.8 branch:
Remove all traces of MPI-POSIX VFD and GPFS detection/code.
Remove remaining traces of stream VFD.
Remove testpar/t_posix_compliant test (it's not actually verifying anything).
Clean up H5D__mpio_opt_possible() further.
Moved environment variable that disables MPI collective operations into
MPI-IO VFD (instead of it being in src/H5S.c).
A few other small code cleanups.
Tested on:
Mac OSX/64 10.9.2 (amazon) w/parallel & serial
(daily tested on trunk)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Bring r24803 & r24804 from trunk to 1.8 branch:
r24804:
Brought changes from Coverity branch back to trunk, and cleaned up misc.
other warnings & formatting issues:
r20833:
Fixed Coverity 667 and 668 with real integer overflow tests this time.
r20834:
Use HDstrncpy and HDstrncat. --gh
r20835:
Change to use strncpy - use base_len + 1 for line 156, use HDstrlen(path) + 1 for line 159
r20836:
Fixed coverity 585 by casting output of fgetc() to a char.
r20837:
Changed sprintf calls to snprintf with size 1 less than the allocated buffer to address coverity issue #967.
r24803:
Rename GCC_DIAG_OFF/ON macros to H5_GCC_DIAG_OFF/ON and move from
src/H5private.h to src/H5public.h. Wrap typedef of hsize_t and hssize_t
in DIAG_OFF(long-long) macros.
Clean up a bunch of "macro '-' is unused" warnings.
Tested on:
Mac OSX/64 10.9.2 (amazon) w/C++, FORTRAN & parallel
(too minor to require h5committest)
|
|
|
|
|
|
| |
LT_ADD_LIBHDF5_DEPENDENCY is used in Makefiles but the declaration in configure.ac is missing.
Copied declaration from trunk. Tested with h5committest on jam ostrich koala and platypus(cmake).
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Bring r24726 & r24727 from trunk to 1.8 branch:
Description:
Revert some earlier usage of strncpy, which was incorrect.
Bring Coverity changes from branch back to trunk:
r20821:
Use HDstrncpy. --gh
(Fixed already, with strdup)
r20822:
(Not merged, incorrect use of HDstrncpy())
r20823:
(Not merged, incorrect use of HDstrncpy())
r20824:
Maintenance: Bug fix: addressed CID 666.
Value stored at *expression_len should be used in the call to
HD5packFstring to avoid overflow (and unnecessary arithmetic
calculation and casting)
r20825:
Issue 642: Added check for error and handler with print to stderr and exit.
r20826:
Undo revision 20818, as that issue has already been fixed in the 1.8 branch
and trunk (but not coverity branch)
r20827:
(Not merged, incorrect use of HDstrncpy())
r20828:
Use HDstrncpy. --gh
(Corrected use of strncpy())
r20829:
Check return of H5Lget_val(print_udata->fid, path, targbuf,
linfo->u.val_size + 1, H5P_DEFAULT) and if error set trgbuf[0] to 0.
Check if H5Lunpack_elink_val(targbuf, linfo->u.val_size, NULL,
&filename, &objname) was successful and allow print. Otherwise filename
and objname are not created. (init those to NULL)
r20830:
resolved coverity issues 939, 940, 941, 944, and 947.
all were complaints about use of sprintf, and in all cases, the
buffers used were large enough for all eventualities.
Resolved issue by replacing calls to sprintf with calls
to snprintf.
r20831:
Maintenance: Addressed CID 852
Replaced sprintf with snprintf
r20832:
Purpose: Fix valgrind issues with hl/examples/ex_image2
Description:
Modified hl/examples/ex_image2 to free global "gbuf" before exit.
Tested on:
Mac OSX/64 10.9.1 (amaon) w/C++, FORTRAN & Threadsafety
(too minor to require h5committest)
|
|
|
|
|
|
|
| |
rename H5V to H5VM since H5V is needed in the fastforward project for
view objects. The addition of view objects in the fastforward project
is expected to be brough into the trunk sometimes in the future, which
is why we need to make this change.
|
|
|
|
| |
Update tools testfiles
|
|
|
|
|
|
|
|
|
| |
errors
Solution: testhdf5 now exits EXIT_SUCCESS(0) if no errors, else
EXIT_FAILURE(1).
Tested: Jam only since it is a trivial fix.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
HDF5_DRIVER
environment variable. Fixes HDFFV-8554.
Tested on:
32-bit LE linux (jam)
64-bit LE linux (koala)
64-bit BE linux (ostrich)
64-bit Windows 7 with VS 2010
On all platforms, the big test was run with the environment
variable set to all supported VFDs.
|
|
|
|
|
|
|
|
|
|
|
| |
Bring r24476 from trunk to 1.8 branch:
Remove duplicate "intent" flags from top & shared file structures, leaving
them only in the shared file structure.
Tested on:
Mac OSX/64 10.9.0 (amazon) w/gcc 4.8, both parallel & serial
(too minor to require h5committest)
|
|
|
|
|
|
| |
IDs. I fixed a typo. It caused the PGI compiler on jam to fail tfile.c test.
Tested with h5committest.
|
|
|
|
|
|
| |
cleaned. CMake update to clean testfiles.
Tested: local cmake, autotools
|
|
|
|
|
|
| |
IDs. I merged the fix the trunk. I put the safeguard in both H5F_get_objects and H5F_get_objects_cb to prevent overfill the list. I also added test cases in tfile.c.
Tested with h5committest on jam, koala, ostrich, and platypus.
|
| |
|
| |
|
|
|
|
|
|
|
|
| |
unsigned long long. Allen confirmed the problem is gone. So I took
out the macro CYGWIN_ULLONG_TO_LDOUBLE_ROUND_PROBLEM. It skipped the test related to this issue.
Tested with h5committest.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
number.
Description:
There is a bug in the current big.c tests. In a nut-shell,
the writing part randomly picks 50 locations and write 4KB
from that location. Random location range is from byte 0
to end of dataset. There is the problem--if the random location
is greater than (end of dataset - 4KB), then error.
Solution:
Adjust the random number to be at least 4KB less than the end of the
dataset. That allows it write 4KB more from the generated starting
position.
Also put in a proper error message if unexpected switch values happened.
Tested: h5comittest plus jam serial build and test.
|
|
|
|
|
|
|
|
| |
UD plugins.
Also warning session fixes.
Tested: CMake local linux
|
|
|
|
|
|
|
|
| |
negative zero in long double. I made it warning instead of
failure.
Tested on jam and Boeing OpenVMS - simple change.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Bring r24101 & 24111 from trunk to 1.8 branch:
r24101:
=======
Description:
Clean up warnings, enable new compiler warning flag(s) and bring back
changes from Coverity branch:
r20813:
Remove the dead code as listed for coverity bug #1722. h5committested.
r20814:
Issue 69: Check return value and throw error if negative return. Also free datatype id on error
r20815:
Use HDstrncpy. --gh
r20816:
Replaced one last HDstrcat call with HDstrncat to resolve coverity issue 832.
r20817:
Use HDstrncpy and HDstrncat. --gh
r20818:
Purpose: Fix valgrind issues with h5jam
Description:
Modified h5jam to free strings strdup'd in parse_command_line before exit. Note
that they may still not be freed in case of error, due to the widespread use of
exit().
r20819:
Issue 80: change loop to use int as loop index.
r20820:
Maintenance: Fixed the bug found by coverity CID 788
There were two problems with this function:
1) it tried to unnecessary free NULL pointer
2) it tried to allocate c_name buffer that is done by H5Pget_class_name
r24111:
=======
Description:
Restrict GCC diagnostic pragmas to only gcc 4.6+
Tested on:
Mac OSX 10.8.4 (amazon) w/gcc 4.8.1, C++ & FORTRAN
(too minor to require h5committest)
|
|
|
|
|
|
| |
them back for OpenVMS. But I took out the test case in dtransform.c which has problem. See Jira issue VMS-8.
Tested on jam.
|
|
|
|
|
|
|
|
|
| |
H5T__conv_f_i for OpenVMS because
they have problem to convert between integers and floating numbers. I also commented out the test
case in dt_arith.c for OpenVMS.
Tested on jam - simple change.
|
|
|
|
|
|
|
| |
Also add default switch blocks to h5import.
Merge h5dump any_path option from trunk.
Tested: local linux
|
|
|
|
|
|
|
|
|
|
| |
Bring r24030 from trunk to 1.8 branch:
Clean up more compiler warnings.
Tested on:
Mac OSX/64 10.8.4 (amazon) w/gcc, C++ & FORTRAN
(too minor to require h5committest)
|
|
|
|
|
|
|
|
|
|
| |
Bring r24020 from trunk to 1.8 branch:
Clean up compiler warnings
Tested on:
Mac OSX/64 10.8.4 (amazon) w/C++ & FORTRAN
(too minor to require h5committest)
|
|
|
|
|
|
|
|
|
|
| |
Bring r24011 from trunk to 1.8 branch:
Clean up a few warnings
Tested on:
Mac OSX 10.8.4 (amazon) w/C++ & FORTRAN
(too minor to require h5committest)
|
|
|
|
| |
Tested: local linux
|
|
|
|
|
|
|
|
|
|
|
|
| |
Bring r23713 and r23717 from trunk to 1.8 branch:
Clean up warnings, switch library code to use Standard C/POSIX wrapper
macros, remove internal calls to API routines, update checkapi and checkposix
scripts.
Tested on:
Mac OSX/64 10.8.3 (amazon) w/C++ & FORTRAN
Big-Endian Linux/64 (ostrich)
|
| |
|
|
|
|
|
|
| |
test/unregister.c as a new test.
No test is needed.
|
|
|
|
|
|
|
|
|
| |
of code from the trunk. It fixes the problem by first iterating
through all opened datasets and groups to see if any of them uses the filter. If it finds one, the function fails with a message.
Then the function flushes all opened files.
Tested with h5committest.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Bring r23695 from trunk to 1.8 branch:
Clean up warnings in H5Tconv.c (down to _only_ 9000 lines of output now!)
Merge changes from Coverity branch back to trunk:
r20684:
Fix for coverity bug #1721 which was due to the fix for coverity bug #943.
r20685:
Use HDstrncpy. --gh
r20761:
Purpose: Fix valgrind issues
Description:
Free image_data and data as appropriate in test_image.
r20762:
Purpose: Fix coverity issue 600
Description:
Add check for return value of H5O_close in H5Ocopy. Also cleaned up various
warnings.
r20763:
Purpose: Fix valgrind issues with h5stat
Description:
Modified h5stat to free "iter" before exit, and free "hand" before exit if
parse_command_line exits directly.
r20764:
fixed coverity issues:
69, 327, 614, 684, 685, 696, 697, 1681, 967, 826, 660, 80
r20765:
Fixed coverity bug 668
Pulled x * y * z multiply out of malloc operand into a separate n_elements variable to quiet integer overflow warning.
No actual integer overflow tests are performed since it's just a test program but I did add a check that n_elements is >= 1.
I also changed an error condition from doing its own close and returning -1 to "goto out;" like the rest of the program.
r20766:
Fixed coverity bug 667
Pulled x * y * z multiply out of malloc operand into a separate n_elements variable to quiet integer overflow warning.
No actual integer overflow tests are performed since it's just a test program.
Tested on:
Mac OSX/64 10.8.3 (amazon) w/C++ & FORTRAN
(h5committest upcoming)
|
|\
| |
| |
| |
| |
| | |
project) and a few changes for CMake and Windows from the trunk (related to DESY).
Tested with desycommittest (emu, koala, jam, ostrich, and ostrich-no-shared-lib), but can't wait for duck to finish. It takes too long.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Bring r23529 from trunk to 1.8 branch:
Stop aliasing property to indicate internal collective metadata operations
with property to perform collective raw data operations from the application.
Tested on:
Mac OSX/64 10.8.3 (amazon) w/parallel
(daily tests on trunk)
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Bring r23549 from trunk to desy_1_8 branch:
More misc. cleanups, but main change is to make an "extern" header file
for the plugin interface.
Tested on:
Mac OSX/64 10.8.3 (amazon)
|
| |
| |
| |
| |
| |
| | |
H5PL_get_plugin_info functions.
Tested on koala - simple change.
|
| |
| |
| |
| |
| |
| | |
H5Pocpl.c.
Tested on koala - no code change.
|
| |
| |
| |
| |
| |
| |
| |
| | |
and sqrt to simpler multiplication and division
to avoid potential rounding problem in math operations.
Tested on koala - simple change.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
libxyz.dylib.
Solution: Changed test_plugin.in to copy library file names in the form of libdynlib{123].*.
Another problem:
Even when copy failed in copying the libray files (was in the form of *.so*),
the test still passed. That was because .libs was included in $HDF5_PLUGIN_PATH and the needed
plug in libraries were generated there.
Solution:
Fixed by copying the plug in library files to separate directories and seetup HDF5_PLUGIN_PATH
to include them but NOT .libs.
Tested: used desycommittest (duck, emu, jam, koala, ostrich) plus cmakehdf5 in jam.
|