summaryrefslogtreecommitdiffstats
path: root/test
Commit message (Collapse)AuthorAgeFilesLines
* Basic alignment with async branch (#115)Quincey Koziol2020-11-2339-164/+160
| | | | | | | * Basic alignment with async branch - trivial changes to reduce clutter in overall diff. * Update minor error code to reflect change within library * Update the error output to match library
* Corrects use of unitialized bytes in the chunk_info test (#106)Dana Robinson2020-11-201-2/+2
|
* Revert "Switch ID code to use a hash table instead of a skip list (#52)" (#104)Dana Robinson2020-11-201-75/+0
| | | This reverts commit a50d211755cb272b2e468144e7d892a4c90813c4.
* Switch ID code to use a hash table instead of a skip list (#52)Dana Robinson2020-11-171-0/+75
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Brings hash table ID code over from Bitbucket branch * Includes reformatting via clang. * Excludes uthash.h from reformatting. * Still has the failing test issue in tid.c. This should only be a problem if a custom ID type is used and its free function deletes other IDs. * Fixes munged H5_GCC_DIAG_ON/OFF macros in H5I.c The H5_GCC_DIAG_ON/OFF macros used to turn off fallthrough warnings in uthash.h (external code) were munged when formatting with clang due to their lack of quotes. e.g.; H5_GCC_DIAG_OFF(implicit-fallthrough) was munged to: H5_GCC_DIAG_OFF(implicit - fallthrough) which compiles, but is useless. So, with quotes, this is now: H5_GCC_DIAG_OFF("implicit-fallthrough") which survives reformatting with clang. * Fixes issues with user callbacks in the ID hash tables The skip lists (previously) used to handle IDs use a mark-and-sweep scheme to deal with user-defined ID delete callbacks which themselves delete other IDs in the list. The uthash hash table implementation used to manage the IDs in this feature branch does not have this ability. This commit restores the skip lists for non-library ID types in lieu of significantly modifying the uthash code. The hash tables are used to manage the library IDs as those do not delete other IDs when they are closed. * Adds uthash.h to MANIFEST * Removes implicit-fallthrough diagnostic disable Removing -Wimplicit-fallthrough=5 means that the uthash code no longer raises warnings so the H5_GCC_DIAG_OFF/ON macros that disabled those warnings have been removed from H5I.c. * Adds a test to ensure you can delete IDs in the H5Iiterate() callback
* CMake: MINGW implies WIN32Michel Zou2020-10-302-3/+3
|
* Fixes minor issues in various virtual file driversDana Robinson2020-10-292-9/+7
| | | | | | | | | | | | - HDFS VFD files now ignored in the Autotools when the HDFS VFD is not being built. - All VFD init code uses idiomatic H5I_INVALID_HID instead of -1 or FAIL. - The HDFS VFD now includes H5FDdrvr_module.h in the right place. - The HDFS tests in test/hdfs.c no longer pass NULL to VERIFY macros, which raised warnings. - Minor tweaks to fix const, unused variables, etc. warnings in several VFDs.
* HD prefix updates in src/ and test/Dana Robinson2020-10-2462-345/+346
| | | | | | | Adds missing HD prefixes to API calls in src and test. Adds some extra processing to bin/checkposix to keep the noise levels down when running the script (not comprehensive).
* Update reformatting settings, trace wrapping, and printf-format strings (#22)Quincey Koziol2020-10-061-2/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | * Add BEGIN_FUNC / CATCH / END_FUNC to macros * Remove incorrect trailing '{' * Update trace script to wrap H5TRACE macros at 110 characters and improve comments for code that performs this operation. * Clean up printf-formatting in H5public.h and correct some oversights in the code. * Reformat with BEGIN_FUNC / END_FUNC handled correctly by clang-format * Run clang-format on changes. * Correct H5_SIZEOF_HSIZE_T/H5_SIZEOF_HSSIZE_T macros to match typedef. * And make the undef value match also. * Update comment * Update clang-format actions to exclude generated files. * Post-process generated H5LTparse.h file as well as H5LTparse.c file. * Fix formatting * Update version of github clang-format action
* Clang-format of source filesAllen Byrne2020-09-30183-114474/+125729
|
* Pre-format fixes for warnings as errorsAllen Byrne2020-09-292-27/+18
|
* Merge pull request #2650 in HDFFV/hdf5 from ↵David Young2020-09-2818-89/+114
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ~DYOUNG/werror:rebased-fprintf-experiment to develop * commit 'c0fbc5c086566d5d3c1d1ef26baa81a53d59fc08': (24 commits) Use the right format string, "%zu", for size_t. Repair more format strings. Fix a bunch of format string errors reported by Larry. Fix some HDfprintf compilation errors: use the right format strings ("zu", PRIuHSIZE), avoid casting some printf arguments, pass the right number of arguments. Test the format string "ll" before "l", "L", and "q", like the ./configure script does. This ought to fix the compilation failure in test/dt_arith.c that Allen told me about: Cast a non-void pointer to void pointer for "%p". Use PRIu32 and "zu" formats. Delete some casts from `size_t`. I'm taking a guess that this code intended to point the 2-digit wide hexadecimal octet values, not 2 character-wide pointers to the bytes. The %02p format, which is a GNU-ism, disagreed with GCC 8.3.0 and the option flags we use. %08p is not portable, it's a GNU-ism. Use %8p, instead. Squashes a GCC error. Add format string macros PRI[doxX]HID for hid_t and use PRIdHID. Use HDva_copy() and introduce a bunch of compatbility format-string constants for uppercase hexadecimal strings, `PRIX...`. Should fix the VS2010 errors that Allen mentioned: Always #define HDfprintf as fprintf in this header. I believe this will fix the Windows build error that Allen reported. Provide an HDvasprintf implementation only if it isn't #defined. This should fix the mingw compilation issue that Allen reported. Fix va_list usage in the vasprintf(3) implementation. Promote format-string warnings to errors. Use the portable `-eq` operator instead of the bash-ism `==`. Fixes the tests on NetBSD, where /bin/sh != bash. Restore a literal percent sign ("%%") that I accidentally deleted. Fix code that made GCC complain about a NULL or `unsigned char *` arguments for "%s". Take pains to provide UINT64_MAX in all conditions. Correct a couple of format strings. ...
| * Merge remote-tracking branch 'hdffv/develop' into rebased-fprintf-experimentDavid Young2020-09-2711-1568/+1822
| |\
| * \ Merge remote-tracking branch 'hdffv/develop' into rebased-fprintf-experimentDavid Young2020-09-251-0/+174
| |\ \
| * \ \ Merge remote-tracking branch 'hdffv/develop' into rebased-fprintf-experimentDavid Young2020-09-0392-2117/+2689
| |\ \ \
| * \ \ \ Merge remote-tracking branch 'hdffv/develop' into rebased-fprintf-experimentDavid Young2020-07-307-3/+529
| |\ \ \ \
| * | | | | Fix code that made GCC complain about a NULL or `unsigned char *` arguments forDavid Young2020-07-072-28/+47
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | "%s". XXX The duplication between test/ros3.c test/s3comms.c is really annoying.
| * | | | | Correct a couple of format strings.David Young2020-07-071-2/+4
| | | | | |
| * | | | | Use PRIuHSIZE and PRIXHSIZE for portability.David Young2020-07-071-2/+2
| | | | | |
| * | | | | Squash my changes on branch `fprintf-experiment` into one commit forDavid Young2020-07-0714-85/+89
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | reapplication to my new warnings branch, `warnings-again`. These changes are included: commit 915551b7bf64e777dd2007386ec77b1d117770da Merge: 63858c2 a8892bb Author: David Young <dyoung@hdfgroup.org> Date: Mon Nov 25 17:39:49 2019 -0600 Merge remote-tracking branch 'hdf5/develop' into fprintf-experiment commit a8892bb42d6f6e4fbc30fae0eb2b957f81c938b9 Merge: 5c911d8 f907b51 Author: David Young <dyoung@hdfgroup.org> Date: Mon Nov 25 17:33:54 2019 -0600 Merge pull request #2055 in HDFFV/hdf5 from ~DYOUNG/vchoi_fork:add-werror-and-squash-some to develop * commit 'f907b511d06612dafc7814a7c30f2f3d2b76d52b': Oops, remove more C99 designated initializers for VS 2010 compatibility. commit 63858c22e168acaec0af8ced6641f26102cc6bb0 Merge: 20ae787 5c911d8 Author: David Young <dyoung@hdfgroup.org> Date: Mon Nov 25 17:04:42 2019 -0600 Merge remote-tracking branch 'hdf5/develop' into fprintf-experiment commit 5c911d8baf3ee7fe654269088eebdf07f59a8192 Merge: b8a5671 62208b0 Author: David Young <dyoung@hdfgroup.org> Date: Mon Nov 25 16:58:27 2019 -0600 Merge pull request #2030 in HDFFV/hdf5 from ~DYOUNG/vchoi_fork:add-werror-and-squash-some to develop * commit '62208b056a09c01855fbac7f75146be58ad6bfe5': (44 commits) Add an #include to get a function declaration. Don't use C99 designated initializers, they're not compatible with Visual Studio 2010. Quiet some more maybe-uninitialized warnings---each is a false positive, *sigh*. This is more code that may not compile with VS2010, *sigh sigh*. Always warn on maybe-uninitialized. -Wincompatible-pointer-types was not available until GCC 5, so enable it only if that's the GCC version we're using. Only promote maybe-uninitialized warnings to errors on GCC 8. Even on GCC 8, there may be false positives at low optimization levels? I need to check. Only use -Werror=cast-function-type with GCC 8 and later. Put all of the -W options back into the order I found them in so that it's easier to compare old and new config/gnu-flags. Add new source files to CMakeLists.txt. Mention the -Werror= flags in libhdf5.settings.in. free -> HDfree Promote decleration-after-statement warnings to errors. Quiet decleration-after-statement warnings. Move a statement under some declarations since some vintages of Visual Studio don't like declarations after statements. Document H5D__chunk_mem_xfree_wrapper(). Undo accidental test deletion. Oops, delete a debug printf that snuck in here. Undo my changes to the HD macros, hadn't really intended those to be on this branch.... Make errors of some more warnings. Move disabled warnings to DEVELOPER_WARNING_CFLAGS. Put just one warning option on a line, and sort some of the options. Cast to the parameter type, H5VL_token_t *, instead of to unsigned char *. Change hdset_reg_ref_t and H5R_ref_t from arrays of unsigned char to structs containing those arrays. Encapsulating the arrays in this way makes it easier to write and think about pointers to these types, casts to/from these types, etc. ... commit 20ae7877e33931b95e8c3502b027d6c3fe94a11f Merge: 46f8c61 edd5297 Author: David Young <dyoung@hdfgroup.org> Date: Fri Nov 22 15:34:09 2019 -0600 Merge remote-tracking branch 'origin/add-werror-and-squash-some' into fprintf-experiment commit 46f8c613d5117a8be5bc8385a072daa0b4262f06 Author: David Young <dyoung@hdfgroup.org> Date: Fri Nov 22 15:29:00 2019 -0600 GCC really wants us to use `ll` to format `long long`, so try to make that work before any other format modifier. Seems like we're not compiling the autoconf test program with -Werror=format ? Probably should. commit eee35b8ef3759c391327cd48a9b3c56b6f8abc99 Author: David Young <dyoung@hdfgroup.org> Date: Fri Nov 22 15:28:05 2019 -0600 It's hard to know just how wide an HDoff_t will be, and I don't think POSIX or C standards provide a PRI macro for it, so cast to intmax_t and format using PRIdMAX. commit 86eab12df7a89b546a38e99f8178dd2adbcb3433 Author: David Young <dyoung@hdfgroup.org> Date: Fri Nov 22 15:26:25 2019 -0600 URemove some casts.se the right format string for the argument. Here and there stop casting a printf argument. commit f722f7cbecbaa99449941484b014426f62f1bed5 Merge: 58e3743 6d5ec83 Author: David Young <dyoung@hdfgroup.org> Date: Fri Nov 22 14:44:16 2019 -0600 Merge branch 'add-werror-and-squash-some' into fprintf-experiment commit 58e3743b7faa9836606ee91798fe80dfc0040da7 Author: David Young <dyoung@hdfgroup.org> Date: Wed Nov 20 21:07:21 2019 -0600 Remove custom HDfprintf implementation, using the standard library's, instead. Take a swipe at repairing fprintf format strings, mainly replacing "%Hu" with "%" PRIuHSIZE, "%a" with "%" PRIuHADDR, "%Zu" with "%zu". Here and there remove an awkward cast of a printf argument to `long long` and use PRI[doux]8, PRI[doux]32, or PRI[doux]64, instead. Change occurrences of "%t" to "%s" and perform a suitable change of argument, `cond` -> `cond ? "TRUE" : "FALSE"`. Some occurrences of %Hu, %a, and %t remain, they just weren't flagged by the compiler because of #ifdef'age. commit d4366909293fa970c23512ac80e5d865d76cddbf Author: David Young <dyoung@hdfgroup.org> Date: Wed Nov 20 20:54:32 2019 -0600 Promote format-string warnigns to errors.
* | | | | | OESS-98 merge with clang-format changesAllen Byrne2020-09-252-20/+20
| |_|_|_|/ |/| | | |
* | | | | Merge pull request #2882 in HDFFV/hdf5 from ↵Allen Byrne2020-09-2511-1568/+1822
|\ \ \ \ \ | |_|_|_|/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ~BYRN/hdf5_adb:feature/cmakeV2-clang-format to develop * commit '571a5e9250ca69adb54ef956361a5cf77059f67c': Add h5ls test plugin format target Fix manifest Add code owners file Update actions - split push/pull-request commits Change to executable Change to based on LLVM format Fix comment formatting due to tabs conversion Disable formatting for file File changes to affect formatting CMake and script changes for clang-format
| * | | | Fix comment formatting due to tabs conversionAllen Byrne2020-09-242-383/+383
| | | | |
| * | | | File changes to affect formattingAllen Byrne2020-09-049-1564/+1638
| | | | |
| * | | | CMake and script changes for clang-formatAllen Byrne2020-09-042-3/+183
| | |_|/ | |/| |
* | | | Add H5Ssel_iter_init API call to reset a selection iteratorJordan Henderson2020-09-181-0/+174
|/ / /
* | | Merge branch 'develop' into develop_minorDana Robinson2020-08-272-8/+85
|\ \ \
| * \ \ Merge pull request #2795 in HDFFV/hdf5 from ↵Larry Knox2020-08-181-0/+3
| |\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ~BMRIBLER/hdf5_bmr2020:hdf5_bmr2020_addrsani to develop * commit '5352b1dbc92313d91d3502dd8352352abe8749a7': Fixed typo Fix HDFFV-11101
| | * | | Fix HDFFV-11101Binh-Minh Ribler2020-08-171-0/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Description Added initialization to local structs in the src function H5MF_settle_raw_data_fsm() and the test function test_bt2_hdr_fd() to prevent the following error in two different occurrences: MemorySanitizer: use-of-uninitialized-value Platforms tested: Linux/64 (jelly) Linux/64 (platypus)
| * | | | Moves lock flag to H5F_shared_t and adds test.Dana Robinson2020-08-171-8/+82
| | | | |
* | | | | Removes inappropriate file locking callDana Robinson2020-08-181-2/+0
| | | | |
* | | | | Minor refactoring based on 1.10 normalization workDana Robinson2020-08-172-2/+1
|/ / / /
* | | | Merge pull request #2769 in HDFFV/hdf5 from mdc_sl_opt to developJohn Mainzer2020-08-175-1050/+1324
|\ \ \ \ | |/ / / |/| | | | | | | | | | | | | | | | | | | * commit 'd00bab96fb4da12a18b5de528c96469978c4c927': Minor copy edits to comments -- no code changes. Tab to space conversions. When flushing, the metadata cache attempts to flush entries in increasing address order. To facilitate this, the metadata cache needs a list of of dirty entries in increasing address order. This is implemented via a skip list of all dirty entries in the cache.
| * | | Merge branch 'develop' into mdc_sl_optmainzer2020-08-1517-311/+54
| |\ \ \
| * | | | Tab to space conversions.mainzer2020-08-141-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Re-applied tab to space conversions accidentally reverted in the commit of the metadata cache skip list optimization, and performed some additional tab to space conversions in passing. Tested parallel / debug on Jelly.
| * | | | Merge branch 'develop' into mdc_sl_optmainzer2020-08-1375-713/+1096
| |\ \ \ \
| * | | | | When flushing, the metadata cache attempts to flush entries in increasingmainzer2020-08-055-1046/+1320
| | |_|_|/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | address order. To facilitate this, the metadata cache needs a list of of dirty entries in increasing address order. This is implemented via a skip list of all dirty entries in the cache. To date this skip list has been maintained at all times. However, profiling indicates that we can avoid significant overhead by constructing the skip list of dirty entries just before a flush, taking it down afterwareds, and not maintaining it during normal operation. This commit implements this optimization for both serial and parallel. Tested serial and parallel, debug and production on charis and jelly.
* | | | | Merge pull request #2771 in HDFFV/hdf5 from ↵Binh-Minh Ribler2020-08-161-0/+98
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ~BMRIBLER/hdf5_bmr:hdf5_bmr_HDFFV-10933 to develop Fixed HDFFV-10933 * commit '16349c5fddce8a74644e18d01d7ea8186aaaa255': Fixed HDFFV-10933
| * | | | | Fixed HDFFV-10933Binh-Minh Ribler2020-08-141-0/+98
| | |_|/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Description: Updated the original fix by Kent Y. in commit 200a77d8c3e51663c375aafffff607ae9b438f4e - used internal functions instead of public API - moved some code into the subroutine for a cleaner look. - added test to dsets.c Platforms tested: Linux/64 (jelly)
* | | | | Trivialities noticed while merging things to 1.10Dana Robinson2020-08-154-33/+33
|/ / / /
* | | | Merge remote-tracking branch 'origin/develop' into remove_unneeded_taggingQuincey Koziol2020-08-1418-348/+86
|\ \ \ \
| * \ \ \ Merge pull request #2739 in HDFFV/hdf5 from namespace_cleanup_01 to developQuincey Koziol2020-08-1415-309/+44
| |\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * commit '3f46a380e084d83a84783383bdfbbd9a443e9f27': Correct typos w/HGOTO_DONE & HGOTO_ERROR Move H5T_vlen_reclaim to package scope Switch H5VM inline routines back to single underscope and put a comment in their header about this naming Clean up private / package / static namespace issues (function naming, which header file, FUNC_ENTER / LEAVE, etc). Removed remaining personal email addresses from library source code (still needs cleaned from other directories). Misc. warning, style, and whitespace cleanup.
| | * \ \ \ Merge remote-tracking branch 'origin/develop' into namespace_cleanup_01Quincey Koziol2020-08-122-6/+6
| | |\ \ \ \
| | * \ \ \ \ Merge remote-tracking branch 'origin/develop' into namespace_cleanup_01Quincey Koziol2020-08-101-6/+6
| | |\ \ \ \ \
| | * \ \ \ \ \ Merge remote-tracking branch 'origin/develop' into namespace_cleanup_01Quincey Koziol2020-08-0766-134/+251
| | |\ \ \ \ \ \
| | * | | | | | | Switch H5VM inline routines back to single underscope and put a comment in ↵Quincey Koziol2020-08-063-13/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | their header about this naming
| | * | | | | | | Clean up private / package / static namespace issues (function naming, whichQuincey Koziol2020-08-0616-322/+57
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | header file, FUNC_ENTER / LEAVE, etc). Removed remaining personal email addresses from library source code (still needs cleaned from other directories). Misc. warning, style, and whitespace cleanup.
| * | | | | | | | Tweak to hide unused threadsafe callback in non-threadsafe buildsDana Robinson2020-08-131-2/+2
| | |_|_|_|_|/ / | |/| | | | | |
| * | | | | | | Cleans warnings and cruft from ttsafe_attr_vlen.cDana Robinson2020-08-121-11/+9
| | | | | | | |
| * | | | | | | Fixes Windows issues due to exposed pthread codeDana Robinson2020-08-121-4/+7
| | | | | | | |
| * | | | | | | Fixes a size mismatch when copying old-style to new-style referencesDana Robinson2020-08-121-4/+4
| | | | | | | |