summaryrefslogtreecommitdiffstats
path: root/tools/lib/h5diff_array.c
Commit message (Collapse)AuthorAgeFilesLines
* Updates to warnhist script, along with a few cleanups, and add some commentsQuincey Koziol2019-07-101-1/+1
| | | | to warning cleanups that are a bit obscure.
* Add support for GCC9, update warnhist script, and clean up warnings.Quincey Koziol2019-07-031-1/+1
|
* Updated configure & CMake compiler flags for GCC 8.x, along with correspondingQuincey Koziol2019-06-281-4/+4
| | | | | changes to warnhist script (and some extra improvements for condensing C++ and Java warnings), and fixed a bunch of warnings.
* Add support for GCC 7.x warnings, update warnhist script to account for them,Quincey Koziol2019-06-211-6/+5
| | | | clean up warnings.
* Changes made based on feedback from pull request #1039.Vailin Choi2018-05-141-2/+2
|
* Fix for HDFFV-10180 Performance issues with H5Oget_info.Vailin Choi2018-04-241-2/+2
|
* Avoid double freeAllen Byrne2017-10-191-3/+0
|
* Fix error handling issuesAllen Byrne2017-10-171-45/+66
|
* HDFFV-10297 add h5copy test and fix h5diff errorsAllen Byrne2017-10-161-508/+497
|
* HDFFV-10296 Update tools lib to use the error handling macros.Allen Byrne2017-10-131-390/+374
|
* VS2012 and earlier cannot have execute stmnts before declareAllen Byrne2017-10-031-1/+1
|
* Fix merge typosAllen Byrne2017-09-111-3/+3
|
* HDFFV-9774 Fix code mergeAllen Byrne2017-09-081-3582/+2230
|
* HDFFV-10246 Add check for string not null before useAllen Byrne2017-07-251-4/+16
|
* Fixed many minor warnings.Dana Robinson2017-05-251-6/+6
|
* HDFFV-10128 Fixed string length with no null fixedAllen Byrne2017-05-161-2/+7
|
* HDFFV-10128 add test to check null termAllen Byrne2017-05-151-35/+52
| | | Test is another dataset
* HDFFV-10128 Fix null term stringsAllen Byrne2017-05-121-7/+17
|
* Merge pull request #426 in HDFFV/hdf5 from ~LRKNOX/hdf5_lrk:hdf5_1_10 to ↵Larry Knox2017-04-251-6/+4
| | | | | | | | | | hdf5_1_10 * commit '54957d37f5aa73912763dbb6e308555e863c43f4': Commit copyright header change for src/H5PLpkg.c which was added after running script to make changes. Add new files in release_docs to MANIFEST. Cimmit changes to Makefile.in(s) and H5PL.c that resulted from running autogen.sh. Merge pull request #407 in HDFFV/hdf5 from ~LRKNOX/hdf5_lrk:hdf5_1_10_1 to hdf5_1_10_1 Change copyright headers to replace url referring to file to be removed and replace it with new url for COPYING file.
* HDFFV-10128 fix string compare and add testsAllen Byrne2017-03-031-9/+16
|
* [svn-r30236] HDFFV-9928: remove duplicate and unconditional includes in ↵Allen Byrne2016-08-011-4/+0
| | | | | | h5diff_array. Also format function block in h5diff_attr to eliminate excessive whitespace
* [svn-r30113] Description:Quincey Koziol2016-06-281-1776/+1429
| | | | | | | | Clean up warnings (from 2774 -> 1560, with my standard debug build) Tested on: MacOSX/64 10.11.5 (amazon) w/serial, parallel & production (h5committest forthcoming)
* [svn-r27626] Various minor warning fixes before major SWMR and VDS merges.Dana Robinson2015-08-311-20/+20
| | | | | | | | | | | gcc 4.9.2 was used to create the warning list - implicit casts - shadowed variables - various enum issues - other minor fixes (comments, unused macros, etc.) Tested on: h5committest
* [svn-r27572] Removed VMS-specific code from the library.Dana Robinson2015-08-241-22/+0
| | | | | | | | | The only remaining code consists of a few floating-point tests that rely on pre-generated and checked-in VMS files. These have been left alone, even though they will not be possible to recreate, since testing VMS float behavior is still important. Tested on: h5committest
* [svn-r24224] HDFFV-8529: Space separate define stringsAllen Byrne2013-09-301-6/+6
| | | | Tested: h5committest
* [svn-r24138] Cast constants to specified type. Allen Byrne2013-09-131-5/+5
| | | | | | | | Cast smaller vars to larger type. Cast calculation result to correct type. Changed int member to hbool_t Tested: local linux
* [svn-r24101] Description:Quincey Koziol2013-09-051-9/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Clean up warnings, enable new compiler warning flag(s) and bring back changes from Coverity branch: r20813: Remove the dead code as listed for coverity bug #1722. h5committested. r20814: Issue 69: Check return value and throw error if negative return. Also free datatype id on error r20815: Use HDstrncpy. --gh r20816: Replaced one last HDstrcat call with HDstrncat to resolve coverity issue 832. r20817: Use HDstrncpy and HDstrncat. --gh r20818: Purpose: Fix valgrind issues with h5jam Description: Modified h5jam to free strings strdup'd in parse_command_line before exit. Note that they may still not be freed in case of error, due to the widespread use of exit(). r20819: Issue 80: change loop to use int as loop index. r20820: Maintenance: Fixed the bug found by coverity CID 788 There were two problems with this function: 1) it tried to unnecessary free NULL pointer 2) it tried to allocate c_name buffer that is done by H5Pget_class_name Tested on: Mac OSX 10.8.4 (amazon) w/gcc 4.8.1, C++ & FORTRAN (too minor to require h5committest)
* [svn-r23695] Description:Quincey Koziol2013-05-111-2/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Clean up warnings in H5Tconv.c (down to _only_ 9000 lines of output now!) Merge changes from Coverity branch back to trunk: r20684: Fix for coverity bug #1721 which was due to the fix for coverity bug #943. r20685: Use HDstrncpy. --gh r20761: Purpose: Fix valgrind issues Description: Free image_data and data as appropriate in test_image. r20762: Purpose: Fix coverity issue 600 Description: Add check for return value of H5O_close in H5Ocopy. Also cleaned up various warnings. r20763: Purpose: Fix valgrind issues with h5stat Description: Modified h5stat to free "iter" before exit, and free "hand" before exit if parse_command_line exits directly. r20764: fixed coverity issues: 69, 327, 614, 684, 685, 696, 697, 1681, 967, 826, 660, 80 r20765: Fixed coverity bug 668 Pulled x * y * z multiply out of malloc operand into a separate n_elements variable to quiet integer overflow warning. No actual integer overflow tests are performed since it's just a test program but I did add a check that n_elements is >= 1. I also changed an error condition from doing its own close and returning -1 to "goto out;" like the rest of the program. r20766: Fixed coverity bug 667 Pulled x * y * z multiply out of malloc operand into a separate n_elements variable to quiet integer overflow warning. No actual integer overflow tests are performed since it's just a test program. Tested on: Mac OSX/64 10.8.3 (amazon) w/C++ & FORTRAN (h5committest upcoming)
* [svn-r23415] Description:Quincey Koziol2013-03-211-2/+2
| | | | | | | Avoid using fpclassify() for detecting zero/non-zero values. Tested on: Mac OSX/64 10.8.3 (amazon) w/debug
* [svn-r23395] Description:Quincey Koziol2013-03-201-259/+430
| | | | | | | | | | | | Bring Coverity changes from branch to trunk: r20682: fixed coverity: 76, 77, 635, 636, 1164, 1165, 1166, 1121, 1122, 1117, 1343 Tested on: Mac OSX/64 10.8.3 (amazon) w/C++ & FORTRAN (too minor to require h5committest)
* [svn-r22625] HDFFV-8111: h5diff compare file to itself - removed path shortcutAllen Byrne2012-08-031-0/+45
|
* [svn-r21980] Correct HD prefix in tools for *allocAllen Byrne2012-02-241-1/+1
| | | | Checked for HD support.
* [svn-r21979] Correct HD prefix in tools for strlen and memcpyAllen Byrne2012-02-241-136/+136
| | | | Checked for HD support.
* [svn-r21974] Update HSIZE_T print statements to use correct macro.Allen Byrne2012-02-231-32/+32
| | | | | | Fix some more HD prefix issues in tools. Tested: local linux
* [svn-r21358] Purpose:Jonathan Kim2011-09-021-30/+40
| | | | | | | | | | | HDFFV-7712 - h5diff: segfault over combinations of complex container types (compound, array, vlen) Description: - Fixed segfault over dataset with container types (array,lven) with multiple nested compound types. (ex: compound->array->compound, compound->vlen->compound) Tested: jam (linux32-LE), koala (linux64-LE), heiwa (linuxppc64-BE), tejeda (mac32-LE), linew (solaris-BE), Cmake (jam)
* [svn-r21121] Description:Quincey Koziol2011-07-181-4/+4
| | | | | | | | | Switch from H5P_DATASET_ACCESS_DEFAULT to H5P_DEFAULT for calls to H5Rdereference2(). Tested on: Mac OS X/32 10.6.8 (amazon) w/debug (too minor to require h5committest)
* [svn-r21117] Issue 2763 - I added a new parameter of object access property ↵Raymond Lu2011-07-181-4/+4
| | | | | | list to the function H5Rdereference. It's called H5Rdereference2 now. H5Rdereference function has been deprecated to H5Rdereference1. I also added some test cases in trefer.c. Tested on jam, heiwa, and koala.
* [svn-r21105] Fixed two bugs:Peter Cao2011-07-151-52/+80
| | | | | | | - h5repack: h5repack failed to copy dataset if the layout is changed from chunked with unlimited dims to contiguous. (PC -- 2011/07/15) - h5diff: "--delta" option considers two NaN of the same type are different, which is wrong based on http://www.hdfgroup.org/HDF5/doc/RM/Tools.html#Tools-Diff. (PC -- 2011/07/15)
* [svn-r20724] Purpose: Fix a bug in h5diff when enum values are compared that doDana Robinson2011-05-041-2/+33
| | | | | | | | | | | | | | | | | not represent a valid enum value. Description: The h5diff code compares enum values by converting them to strings and then comparing them. When the enum value is out of range and can't be converted to an enum string representation, the comparison was skipped. The code now flags differences when one of the two enum values is out of range (two out of range values are compared in memory). A test has been added to the tools test script. This fixes JIRA HDFFV-7527 Tested on: jam, koala, heiwa (h5committest)
* [svn-r20384] Purpose:Jonathan Kim2011-03-311-3/+3
| | | | | | | | | | | | | | | | | | Fixed Bug 2184 - GMQS: h5diff - incorrect calculation code for --use-system-epsilon option Description: Merged from HDF5 1.8 branch r20369. Fixed h5diff for --use-system-epsilon option: the calculation changed from ( |a - b| / b ) to ( |a - b| ). This was decided for better performance and was corrected only in HDF5 trunk, so 1.8 got updated. Also comments for equal_XXX() function were updated correctly. Also help page and RM got updated correctly. Also add test cases for testing the differences w/wo the option. Tested: jam (linux32-LE), amani (linux64-LE), heiwa (linuxppc64-BE), tejeda (mac32-LE), linew (solaris-BE), Windows (32-LE)
* [svn-r20070] Description:Quincey Koziol2011-02-091-1/+1
| | | | | | | Switch order of system includes, to correct error on FreeBSD machines. Tested on: FreeBSD/32 6.3 (duty) w/debug
* [svn-r20065] Description:Quincey Koziol2011-02-081-6/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bring changes from Coverity branch to trunk: r19975: Fixed potential mem leak at H5O_attr_open_by_name r19980: Fix coverity issue 792. Free tmp_env_prefix in H5Lexternal.c line 365 if it is not NULL but its contents are 0 when it goes out of scope. r20039: Eliminate warnings about nested extern and implicit declarations of parallel_print and address Coverity defects 712-781 by #including h5tools_utils.h in h5diff_array.c, h5diff_attr.c, h5diff_dset.c and h5diff_util.c. r20046: Purpose: Address TOCTOU warnings in h5jam and h5unjam Description: Coverity is afraid that the state of the input file could change between the call to stat() and the call to open(). This is called a time-of- check time-of-use (TOCTOU) vulnerability. Modified stat calls to fstat which uses an open file pointer so it (hopefully) won't complain any more. r20047: Addressed coverity issues 135-137, 462-464. Local pointers that needed to be freed in case of error were moved out of a switch statement in src/H5Tnative.c, set to NULL, and checked before freeing. Tested on: Mac OS X/32 10.6.6 (amazon) w/debug & production (h5committested on Coverity branch)
* [svn-r19892] Purpose:Jonathan Kim2010-12-281-184/+165
| | | | | | | | | | | | | | | | | | | Bug 2089 - GMQS: h5diff segfault on a compound dataset with fixed length + vlen string type order Description: This is fix for the segfault when h5diff compares a compound dataset with combination of fixed length string types and vlen string types in certain orders. Optimized vlariable length string handling codes. The fix is referred from h5dump handling vlen strings. For testing, several compound datasets were added with various combinations. Previous failed cases: - Vlen string, Fixed length string, Vlen string, Fixed length string - Fixed length string, Fixed length string, Vlen string, Vlen string - Fixed length string, Vlen string, Fixed length string, Vlen string Tested: jam (linux32-LE), amani (linux64-LE), heiwa (linuxppc64-BE), tejeda (mac32-LE), linew (solaris-BE)
* [svn-r19759] Purpose:Jonathan Kim2010-11-111-4/+12
| | | | | | | | | | | | | | | | | | Fix compile error for Windows from previous checkin r19757. Description: Previous log: Improve h5diff performance. The following changes for improving h5diff performance: 1) use HDmemcmp() before comparing each elements (memcmp() is very fast at both linew and jam) 2) replace the expensive H5Tequals() calls 3) retrieve datatype information at dataset level not each element level for compound datasets Tested: jam (linux32-LE), Windows
* [svn-r19757] Purpose:Jonathan Kim2010-11-111-35/+118
| | | | | | | | | | | | | | | | Improve h5diff performance. Description: The following changes for improving h5diff performance: 1) use HDmemcmp() before comparing each elements (memcmp() is very fast at both linew and jam) 2) replace the expensive H5Tequals() calls 3) retrieve datatype information at dataset level not each element level for compound datasets Tested: jam (linux32-LE), amani (linux64-LE), heiwa (linuxppc64-BE), tejeda (mac32-LE), linew (solaris-BE)
* [svn-r19712] Purpose:Jonathan Kim2010-11-021-30/+76
| | | | | | | | | | | | | | | Fixed h5diff to handle variable-length strings in a compound dataset correctly. Also variable-length string array in a compound dataset. Bug #1989. Description: Garbage values were displayed when h5diff compared variable-length strings (or string array) in a compound type dataset. Tested: jam (linux32-LE), amani (linux64-LE), heiwa (linuxppc64-BE), tejeda (Mac32)
* [svn-r19237] Description:Quincey Koziol2010-08-121-6/+2
| | | | | | | | | | Clean up misc. compiler warnings. Tested on: FreeBSD/32 6.3 (duty) in debug mode Mac OS X/32 10.6.4 (amazon) w/C++ & FORTRAN, w/threadsafe, in production mode Mac OS X/32 10.6.4 (amazon) w/parallel, in debug mode
* [svn-r18425] Purpose:Jonathan Kim2010-03-181-1/+2
| | | | | | | | | | | | Fix for bug1814 - NPOESS: h5repack doesn't handle references to the groups as an element of a dataset Description: handles object reference to named-datatype as well. Add test cases. Tested: jam, amani, linew
* [svn-r18197] Description:Quincey Koziol2010-01-301-39/+39
| | | | | | | | | Trim trailing whitespace from source code files with this command: find . \( -name "*.[ch]" -or -name "*.cpp" -or -name "*.f90" \) -print |xargs -n 1 sed -i "" 's/[[:blank:]]*$//' Tested on: None - eyeballed only
* [svn-r17981] Description:Quincey Koziol2009-12-101-50/+47
| | | | | | | | Abstract "print header" code into separate routine. Tested on: Mac OS X/32 10.6.2 (amazon) w/debug (too minor to require h5committest)