summaryrefslogtreecommitdiffstats
path: root/tools/lib/h5tools.c
Commit message (Collapse)AuthorAgeFilesLines
* [svn-r23219] Description:Quincey Koziol2013-02-021-33/+19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bring reviewed changes from Coverity branch back to trunk (QK & JK): r20457: Coverity issue 691: return of H5duo could be negative. Fixed by using STDOUT_FILENO and redesign parse_command_line and main to cleanup file allocations. The output_file var is null when using stdout. In cleanup do not close output_file if NULL. r20510: Initialize ufid = -1 and predicate HDclose call on ufid != -1 r20511: Purpose: Fix coverity issue 1715 Description: Free "file" and nested data on failure in H5FD_core_open. r20512: Initialize ifid = -1 and predicate HDclose call on ifid != -1 r20514: Initialize h5fid = -1 and predicate HDclose call on h5fid != -1 r20516: Added else branch to the if (ret_value < 0) check. r20522: Addressed coverity issues 930-933, 850, 836, 835, 1307. All minor potential buffer overwrite bugs, or coverity errors. Fixed by replacing strcpy and sprintf with strncpy and snprintf. r20523: fixed coverity issues 68, 1120, 1116i r20524: Check H5Z_SZIP->encoder_present < 1 assuming 0 represents absence. r20601: Purpose: Fix coverity issues 1703-1705 Description: Modified the cleanup code in test_free in accum.c to reset allocated buffers to NULL after they are freed, and modified the error cleanup code to check if these buffers are NULL before freeing them. Also fixed some unrelated warnings in accum.c. r20602: Use HDsnprintf and HDstrncat r20603: Purpose: Fix coverity issues 808-809 Description: Modified test_core in vfd.c to check the returns from malloc, and keep track of whether points and check are allocated by setting them to NULL when they are not. Added code to free points and check on error if they are not NULL. Also fixed unrelated warnings in vfd.c. r20604: Use HDstrncpy. r20605: Use HDstrncpy and HDstrncat. r20606: Purpose: Fix coverity issue 807 Description: Modified long_compact in stab.c to keep track of whether objname is allocated by setting it to NULL when it is not. Added code to free objname on error if it is not NULL. r20607: Changed string function calls to use versions that specify the string length to fix coverity issues 832 and 839. Tested on: Mac OSX/64 10.8.2 (amazon) (Too minor to require h5committest)
* [svn-r23216] Add newline for special case of only raw data to stdoutAllen Byrne2013-01-311-2/+7
|
* [svn-r23190] HDFFV-8285: Add suppress ddl option.Allen Byrne2013-01-221-24/+48
| | | | Tested: local linux
* [svn-r23158] HDFFV-8169: h5dump incorrectly dumps a string into a binary fileAllen Byrne2013-01-141-1/+1
| | | | Tested: local linux
* [svn-r22625] HDFFV-8111: h5diff compare file to itself - removed path shortcutAllen Byrne2012-08-031-251/+0
|
* [svn-r22604] cast void* to char* for calculationAllen Byrne2012-07-261-6/+6
| | | | Issue on windows
* [svn-r22602] Allen Byrne2012-07-251-164/+191
|
* [svn-r22411] reduce compiler warnings by removing unreferenced variables and ↵Allen Byrne2012-05-251-4/+5
| | | | | | adding cast Tested: local linux
* [svn-r22087] Minor formatting changes to sync with 1.8Allen Byrne2012-03-191-1/+1
|
* [svn-r22061] Description:Quincey Koziol2012-03-131-1/+1
| | | | | | | | Change to use versioned API call, to avoid problems when defaulting to older AI versions. Tested on: Mac OSX/64 10.7.3 (amazon) w/debug
* [svn-r22042] HDFFV-7957-7958:Allen Byrne2012-03-121-2/+9
| | | | | Add tools error stack and check return from H5Dreference call. Tested: CMake and h5committest
* [svn-r21985] Tools must call h5tools_init before command_line parsing or ↵Allen Byrne2012-02-241-2/+20
| | | | | | | | using tools_mesg functions. Tools library uses alais variables for stdout, stderr and tools library uses HDfprintf() functions. Tested: local linux
* [svn-r21974] Update HSIZE_T print statements to use correct macro.Allen Byrne2012-02-231-5/+5
| | | | | | Fix some more HD prefix issues in tools. Tested: local linux
* [svn-r21971] Correct HD prefixAllen Byrne2012-02-221-1/+1
|
* [svn-r21969] Added missing HD prefixAllen Byrne2012-02-221-134/+135
| | | | Correct indentation
* [svn-r21953] HDDFV-7560: h5dump refactoringAllen Byrne2012-02-171-2636/+30
| | | | Tested: local linux
* [svn-r21952] HDFFV-5874: -c and -k subsettingAllen Byrne2012-02-171-2/+2
| | | | Tested:local linux
* [svn-r21378] The tools used "%hhd" to print signed char. But VMS doesn't ↵Raymond Lu2011-09-131-1/+5
| | | | | | know it. So I used H5_VMS to have a different way ("%hd") to print it. Tested on jam. Not tested on VMS yet. Simple change.
* [svn-r21121] Description:Quincey Koziol2011-07-181-3/+3
| | | | | | | | | Switch from H5P_DATASET_ACCESS_DEFAULT to H5P_DEFAULT for calls to H5Rdereference2(). Tested on: Mac OS X/32 10.6.8 (amazon) w/debug (too minor to require h5committest)
* [svn-r21117] Issue 2763 - I added a new parameter of object access property ↵Raymond Lu2011-07-181-2/+2
| | | | | | list to the function H5Rdereference. It's called H5Rdereference2 now. H5Rdereference function has been deprecated to H5Rdereference1. I also added some test cases in trefer.c. Tested on jam, heiwa, and koala.
* [svn-r20796] Refactor print_data_region_blocks/ponts to remove context ↵Allen Byrne2011-05-111-53/+83
| | | | | | | | passed in by value. The print functions needed an independent context with only the current indent level passed in by argument. Also synched the two routines logical flows and corrected a mem_space error. h5dump (and h5stat, h5jam/h5unjam) help option not tested. Added h5dump parse_command_line technique for h5stat and h5jam/unjam and created testfiles. Tested: local linux
* [svn-r20785] Revert region data print changes from yesterdayAllen Byrne2011-05-101-60/+50
|
* [svn-r20783] correct type of variable for blkindxAllen Byrne2011-05-091-4/+4
|
* [svn-r20781] correct typo of variable types for indx and jndxAllen Byrne2011-05-091-2/+2
|
* [svn-r20776] Refactor print_data_region_blocks/ponts to remove context ↵Allen Byrne2011-05-091-44/+54
| | | | | | passed in by value. The print functions needed an independent context with only the current indent level passed in by argument. Also synched the two routines logical flows and corrected a mem_space error. Tested: local linux
* [svn-r20725] Add overlooked changes from part of coverity fixAllen Byrne2011-05-041-2/+7
| | | | Tested: local linux
* [svn-r20713] Packed Bits Merge:Allen Byrne2011-05-031-8/+6
| | | | | | | | | removed option defines and #ifdef/#endif refactored all printf to HDfprintf in h5dump.c formatted and indention improvements synched with 1.8 branch Tested: local linux
* [svn-r20677] Merge packed bits option from 1.8 branch to trunk. CMake only. ↵Allen Byrne2011-04-291-0/+5
| | | | | | Autotools merge to come. Tested: local Linux
* [svn-r20676] Purpose:Jonathan Kim2011-04-291-7/+49
| | | | | | | | | | | | | | | | - HDFFV-5928 - GMQS: h5diff problem and improvement on comparsing the same objects Description: Fixed: 1) adding h5tools_is_obj_same() function to check if two given IDs or paths point to the same object. This function can be very useful for other tools and applications. 2) using h5tools_is_obj_same() at h5diff() and diff() in h5diff.c. If two paths point to the same object, there is no need to check the details of the object since we know there is no difference. The fix will increase the performance by skipping the content comparison. It also fixed the problem of reporting difference for some cases of comparing the same file, e.g. empty files or files with incomparable objects the same file. Test update: Updat prvious test cases (171, 172, 530) affected by this fix, so they still perfrom originally intended testing without bypassing. Tested: jam (linux32-LE), koala (linux64-LE), heiwa (linuxppc64-BE), tejeda (mac32-LE), linew (solaris-BE), cmake
* [svn-r20626] Albert's test on bp reveals that the dumper had assertion ↵Raymond Lu2011-04-251-2/+6
| | | | | | | | failure when it tried to display empty attribute data. I added a check for empty attribute in h5dump.c. I also added a check for empty dataset in tools/lib/h5tools.c. Tested on jam. But I tested the same changes in 1.8 on jam, linew, and amani.
* [svn-r20539] Description:Quincey Koziol2011-04-181-38/+23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bring Coverity changes back to trunk: r20276: Add recursive is vlen string function. Cleanup resource leaks for issues: 200,202,329,688,811,812 r20277: Check types and close by adding error section: issue 687 r20278: Replaced implicit pointer conversion with (ocrt_info.new_obj != NULL). r20280: Addressed coverity issues 927-929 & 583. The real issue is failure to check file name length -- at least at the H5FD interface level. This needs more work, but at least I have dealt with the issue in H5FDfamily.c r20337: H5O_type_t obj_type = H5O_TYPE_UNKNOWN; r20338: Added udata.name = NULL; to prevent potential uninitialized use after done: label. r20339: coverity issues: 686,828,1670-1673,1707-1711 Tested on: FreeBSD/32 6.3 (duty) in debug mode FreeBSD/64 6.3 (liberty) w/C++ & FORTRAN, in debug mode FreeBSD/32 8.2 (loyalty) w/gcc4.6, in debug mode FreeBSD/64 8.2 (freedom) w/gcc4.6, in debug mode Linux/32 2.6 (jam) w/PGI compilers, w/default API=1.8.x, w/C++ & FORTRAN, w/threadsafe, in debug mode Linux/64-amd64 2.6 (amani) w/Intel compilers, w/default API=1.6.x, w/C++ & FORTRAN, in production mode Solaris/32 2.10 (linew) w/deprecated symbols disabled, w/C++ & FORTRAN, w/szip filter, w/threadsafe, in production mode Linux/PPC 2.6 (heiwa) w/C++ & FORTRAN, w/threadsafe, in debug mode Linux/64-amd64 2.6 (abe) w/parallel, w/FORTRAN, in debug mode
* [svn-r20480] Description:Quincey Koziol2011-04-121-4/+10
| | | | | | | | | | | Remove global variable for the path name in the group traversal code. Also clean up a bunch of compiler warnings. Tested on: Mac OS X/32 10.6.7 (amazon) w/debug & production FreeBSD/32 6.3 (duty) w/debug FreeBSD/64 6.3 (liberty) w/debug Solaris/32 2.7 (linew) w/debug
* [svn-r20285] Purpose:Jonathan Kim2011-03-211-49/+66
| | | | | | | | | | | | | | | | | Improve the previous fix for Bug 2216 - GMQS: h5diff - memory leak when compares vlen string in dataset or attributes Description: Related to the previous checkin r20270 and r20266. Improve h5tools_detect_vlen() code for better performance. H5Tdetect_class already recusive on given type so don't need to be part of recusive call again. Also improve error handlings in h5tools_detect_vlen and h5tools_detect_vlen_str functions. Also updated h5ls and h5dump code accordingly. Tested: jam (linux32-LE), amani (linux64-LE), heiwa (linuxppc64-BE), tejeda (mac32-LE), linew (solaris-BE), Cmake - jam
* [svn-r20270] Purpose:Jonathan Kim2011-03-181-0/+49
| | | | | | | | | | | | | | | | Improve the previous fix for Bug 2216 - GMQS: h5diff - memory leak when compares vlen string in dataset or attributes Description: Improve the fix along with the previous checkin r20266. Add a new function to tool lib, h5tools_detect_vlen_data() which return TRUE if include any kind of vlen data all at once, either VLEN-data or VLEN-string and so on. Also updated h5ls and h5dump code accordingly. Tested: jam (linux32-LE), amani (linux64-LE), heiwa (linuxppc64-BE), tejeda (mac32-LE), linew (solaris-BE), Cmake - jam
* [svn-r20247] Change name of new VLEN function from H5Tdetect_vlen_str to ↵Allen Byrne2011-03-141-6/+10
| | | | | | | | h5tools_detect_vlen_str to match other functions in tools lib. Added back test for H5Tdetect_class of H5T_VLEN after each instance of above function to catch all VLEN types in h5dump. Tested: local linux
* [svn-r20222] Correct mistake by declaring indexing variable removed from for ↵Allen Byrne2011-03-101-0/+1
| | | | at top of function.
* [svn-r20221] Remove rougue 'int' inside for loop (cut-paste error) - windows ↵Allen Byrne2011-03-101-1/+1
| | | | complained.
* [svn-r20216] Valgrind fix for memory leak in h5tools_dump_xxx which is fixed ↵Allen Byrne2011-03-091-2/+54
| | | | | | | | by adding a new function; htri_t H5Tdetect_vlen_str(hid_t tid) to h5tools. This needs to be called before any H5Aread/H5Dread and if TRUE, then call vlen_reclaim function after the corresponding h5tools_dump_xxx(). Tested: local linux and valgrind
* [svn-r20206] Updated manifest and source code for fixing h5dump -y -o problemPeter Cao2011-03-091-9/+9
|
* [svn-r20108] Purpose:Jonathan Kim2011-02-151-9/+4
| | | | | | | | | | | | | | Fixing Bug 2092 - h5dump does not display index for a dataset Description: h5dump skip displaying array indices every certain number when the array type dataset is relatively big. The certain number varies according to the size of each array. This checkin fix the skipping array indices problem. This fix also correct indentation of the dataset data output. Tested: jam (linux32-LE), amani (linux64-LE), heiwa (linuxppc64-BE), tejeda (mac32-LE), linew (solaris-BE)
* [svn-r19918] Add hh modifier to signed char printf format string. Added ↵Allen Byrne2011-01-051-1/+1
| | | | | | | h5dump test to verify that signed/unsigned datasets print correctly. Bring solution from 1.8 packed bits fix which solved problem on heiwa with Signed char of 8 bits Tested: local linux
* [svn-r19654] Description:Quincey Koziol2010-10-211-34/+34
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bring Coverity revisions from branch back to trunk, and clean up some other misc. compiler warnings also. r19500: Fix coverity items 1446 and 1447. Moved up calls to memset in test_cont in ohdr.c so the test never tries to close uninitialized locations. r19501: Fix coverity items 1398-1445. Various uninitialized variable errors in fheap.c. r19502: Fixed coverity issue 579 and some additional warnings in the file as well. r19503: Bug fix: This fix addressed the "RESOURCE_LEAK" problems #789 and 790, run 26 r19504: minor mods to try to keep coverity from flagging false positives. r19505: Fixed coverity issues 566 - 571. Declared variables that are passed to functions that use them as arrays to be arrays of size 1. Tested on: Mac OS X/32 10.6.4 (amazon) w/debug, production & parallel (h5committested on trunk)
* [svn-r19262] Undo r19261.Allen Byrne2010-08-201-0/+7
|
* [svn-r19261] Remove unused variables and allocationAllen Byrne2010-08-201-7/+0
| | | | Tested: local linux
* [svn-r19252] Description:Quincey Koziol2010-08-191-19/+16
| | | | | | | | | | | | | | | | | | | | | | | Bring Coverity changes from branch to trunk: r19161: Fixed the part for matching the subset info with dataset r19189: BZ1646: h5dump does not check number of dimensions for subsetting parameters against the dataset Changed subset_t structure from holding hsize_t pointers to holding new subset_d pointers, which hold the original hsize_t pointer + len. this len is then checked against dataset ndims in the handle_dataset function of h5dump. Changed all references to use new data structure. Added tests for each subset parameter. r19190: Added new h5dump ddl files Tested on: Mac OS X/32 10.6.4 (amazon) w/debug & production (h5committested on branch)
* [svn-r19237] Description:Quincey Koziol2010-08-121-33/+30
| | | | | | | | | | Clean up misc. compiler warnings. Tested on: FreeBSD/32 6.3 (duty) in debug mode Mac OS X/32 10.6.4 (amazon) w/C++ & FORTRAN, w/threadsafe, in production mode Mac OS X/32 10.6.4 (amazon) w/parallel, in debug mode
* [svn-r19202] [BZ1953]implementation for the proposed changes suggested by ↵Allen Byrne2010-08-091-16/+340
| | | | | | | the "h5dump_output_option" RFC. This required that the region reference code be duplicated and reduced to allow the do_bin_output() function to understand region references. The container type-id also needed to be propagated into the do_bin_output() function and functions referenced (render_bin_output*). Existing tests tested the binary function, so only one test was added to test the region reference generated file. Tested: local linux
* [svn-r18816] Move progname and d_status functions from h5tools to h5tools_utilAllen Byrne2010-05-141-30/+0
| | | | | Tested: linux and windows
* [svn-r18759] pull r18757 from 1.8 branchAllen Byrne2010-05-111-0/+30
| | | | | | | | | Enable tools lib to be built as a dll on windows. Added two get/set functions for progname and d_status. Also add windows import/export declarations to functions. Updated error_mesg() and warn_mesg() to remove progname argument and use get functions Tested: Windows, linux
* [svn-r18197] Description:Quincey Koziol2010-01-301-157/+157
| | | | | | | | | Trim trailing whitespace from source code files with this command: find . \( -name "*.[ch]" -or -name "*.cpp" -or -name "*.f90" \) -print |xargs -n 1 sed -i "" 's/[[:blank:]]*$//' Tested on: None - eyeballed only