summaryrefslogtreecommitdiffstats
path: root/tools/lib
Commit message (Collapse)AuthorAgeFilesLines
* [svn-r24804] Description:Quincey Koziol2014-03-163-69/+47
| | | | | | | | | | | | | | | | | | | | | | | | Brought changes from Coverity branch back to trunk, and cleaned up misc. other warnings & formatting issues: r20833: Fixed Coverity 667 and 668 with real integer overflow tests this time. r20834: Use HDstrncpy and HDstrncat. --gh r20835: Change to use strncpy - use base_len + 1 for line 156, use HDstrlen(path) + 1 for line 159 r20836: Fixed coverity 585 by casting output of fgetc() to a char. r20837: Changed sprintf calls to snprintf with size 1 less than the allocated buffer to address coverity issue #967. Tested on: Mac OSX/64 10.9.2 (amazon) w/C++, FORTRAN & parallel (too minor to require h5committest)
* [svn-r24789] Bump up the minimum cmake versionAllen Byrne2014-03-131-1/+1
|
* [svn-r24781] HDFFV-8700 -Allen Byrne2014-03-111-19/+19
| | | | | | | KitWare recommendations: Change CMake commands to lower case. Remove INCLUDE_DIRECTORIES in src for target level includes. Change ADD_DEFINITIONS package debug defines into CMake option. Remove -DNDEBUG
* [svn-r24726] Description:Quincey Koziol2014-02-201-12/+24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Revert some earlier usage of strncpy, which was incorrect. Bring Coverity changes from branch back to trunk: r20821: Use HDstrncpy. --gh (Fixed already, with strdup) r20822: (Not merged, incorrect use of HDstrncpy()) r20823: (Not merged, incorrect use of HDstrncpy()) r20824: Maintenance: Bug fix: addressed CID 666. Value stored at *expression_len should be used in the call to HD5packFstring to avoid overflow (and unnecessary arithmetic calculation and casting) r20825: Issue 642: Added check for error and handler with print to stderr and exit. r20826: Undo revision 20818, as that issue has already been fixed in the 1.8 branch and trunk (but not coverity branch) r20827: (Not merged, incorrect use of HDstrncpy()) r20828: Use HDstrncpy. --gh (Corrected use of strncpy()) r20829: Check return of H5Lget_val(print_udata->fid, path, targbuf, linfo->u.val_size + 1, H5P_DEFAULT) and if error set trgbuf[0] to 0. Check if H5Lunpack_elink_val(targbuf, linfo->u.val_size, NULL, &filename, &objname) was successful and allow print. Otherwise filename and objname are not created. (init those to NULL) r20830: resolved coverity issues 939, 940, 941, 944, and 947. all were complaints about use of sprintf, and in all cases, the buffers used were large enough for all eventualities. Resolved issue by replacing calls to sprintf with calls to snprintf. r20831: Maintenance: Addressed CID 852 Replaced sprintf with snprintf r20832: Purpose: Fix valgrind issues with hl/examples/ex_image2 Description: Modified hl/examples/ex_image2 to free global "gbuf" before exit. Tested on: Mac OSX/64 10.9.1 (amaon) w/C++, FORTRAN & Threadsafety (too minor to require h5committest)
* [svn-r24725] HDFFV-8629: h5repack will not attempt to remove UD filters. ↵Allen Byrne2014-02-201-144/+145
| | | | | | h5repack requires a check for UD filters that also must check if the filter can be dynamically loaded. This require a change in the library that checks for this. Tested: locally and reviewed
* [svn-r24682] Add IF SHARED block around Windows PDB file generation command.Allen Byrne2014-02-041-2/+3
|
* [svn-r24480] Description:Quincey Koziol2013-11-302-49/+8
| | | | | | | | | | | Bring r24479 from 1.8 branch to trunk: Fix ph5diff worker command handling so it can correctly respond to situations where there's no work to perform. Also, a few minor code cleanups. Tested on: Mac OSX/64 10.9.0 (amazon) w/parallel (too minor to require h5committest)
* [svn-r24285] Eliminate several "passing argument ... with different width ↵Larry Knox2013-10-102-14/+14
| | | | | | due to prototype" warnings by casting constants to size_t where expected by string functions. Tested on jam, koala,ostrich and platypus with h5committest.
* [svn-r24224] HDFFV-8529: Space separate define stringsAllen Byrne2013-09-303-8/+8
| | | | Tested: h5committest
* [svn-r24194] Don't add hdf5 library dependencies to lib files when ↵Larry Knox2013-09-241-0/+1
| | | | | | --disable-sharedlib-rpath configure option is invoked. Fix for HDFFV-8276. Tested with h5committest and on hdf-duck.
* [svn-r24138] Cast constants to specified type. Allen Byrne2013-09-135-20/+20
| | | | | | | | Cast smaller vars to larger type. Cast calculation result to correct type. Changed int member to hbool_t Tested: local linux
* [svn-r24115] Reduce warnings for conversions of different widths.Larry Knox2013-09-061-99/+99
| | | | h5committested on jam, ostrich, koala, and platypus.
* [svn-r24101] Description:Quincey Koziol2013-09-052-19/+26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Clean up warnings, enable new compiler warning flag(s) and bring back changes from Coverity branch: r20813: Remove the dead code as listed for coverity bug #1722. h5committested. r20814: Issue 69: Check return value and throw error if negative return. Also free datatype id on error r20815: Use HDstrncpy. --gh r20816: Replaced one last HDstrcat call with HDstrncat to resolve coverity issue 832. r20817: Use HDstrncpy and HDstrncat. --gh r20818: Purpose: Fix valgrind issues with h5jam Description: Modified h5jam to free strings strdup'd in parse_command_line before exit. Note that they may still not be freed in case of error, due to the widespread use of exit(). r20819: Issue 80: change loop to use int as loop index. r20820: Maintenance: Fixed the bug found by coverity CID 788 There were two problems with this function: 1) it tried to unnecessary free NULL pointer 2) it tried to allocate c_name buffer that is done by H5Pget_class_name Tested on: Mac OSX 10.8.4 (amazon) w/gcc 4.8.1, C++ & FORTRAN (too minor to require h5committest)
* [svn-r24030] Description:Quincey Koziol2013-08-193-24/+28
| | | | | | | | Clean up more compiler warnings. Tested on: Mac OSX/64 10.8.4 (amazon) w/gcc, C++ & FORTRAN (too minor to require h5committest)
* [svn-r24011] Description:Quincey Koziol2013-08-151-1/+1
| | | | | | | | Clean up a few warnings Tested on: Mac OSX 10.8.4 (amazon) w/C++ & FORTRAN (too minor to require h5committest)
* [svn-r23953] Update stream handling to allow binary mode - due to unjam fix.Allen Byrne2013-07-312-17/+60
| | | | Tested: local linux
* [svn-r23944] Move stream functions into tools lib.Allen Byrne2013-07-302-7/+225
| | | | Tested: local linux
* [svn-r23825] Bug HDFFV-8469: C++ comments in C code.Albert Cheng2013-06-261-1/+0
| | | | | | | | Found and removed two more "//" comments. Tested: in Koala by $ env CFLAGS="-ansi" ../hdf5/bin/buildhdf5 -fortran -cxx -config # enable fortran and cxx, configure only $ make AM_CFLAGS=-ansi # compile all source file by setting HDF5 build CFLAGS as "-ansi" only
* [svn-r23800] Added the HD prefix to the system functions used in the ↵Allen Byrne2013-06-201-9/+9
| | | | h5tools_str_replace function.
* [svn-r23796] remove commented line with c++ styleAllen Byrne2013-06-201-2/+0
|
* [svn-r23745] HDFFV-8461: Add Windows /MT supportAllen Byrne2013-06-101-1/+2
| | | | This adds the UserMacros.cmake support needed.
* [svn-r23740] HDFFV-8447: subsetting broke data output file option.Allen Byrne2013-06-071-7/+7
| | | | Reviewed in H5T-59, tested local linux
* [svn-r23695] Description:Quincey Koziol2013-05-113-46/+64
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Clean up warnings in H5Tconv.c (down to _only_ 9000 lines of output now!) Merge changes from Coverity branch back to trunk: r20684: Fix for coverity bug #1721 which was due to the fix for coverity bug #943. r20685: Use HDstrncpy. --gh r20761: Purpose: Fix valgrind issues Description: Free image_data and data as appropriate in test_image. r20762: Purpose: Fix coverity issue 600 Description: Add check for return value of H5O_close in H5Ocopy. Also cleaned up various warnings. r20763: Purpose: Fix valgrind issues with h5stat Description: Modified h5stat to free "iter" before exit, and free "hand" before exit if parse_command_line exits directly. r20764: fixed coverity issues: 69, 327, 614, 684, 685, 696, 697, 1681, 967, 826, 660, 80 r20765: Fixed coverity bug 668 Pulled x * y * z multiply out of malloc operand into a separate n_elements variable to quiet integer overflow warning. No actual integer overflow tests are performed since it's just a test program but I did add a check that n_elements is >= 1. I also changed an error condition from doing its own close and returning -1 to "goto out;" like the rest of the program. r20766: Fixed coverity bug 667 Pulled x * y * z multiply out of malloc operand into a separate n_elements variable to quiet integer overflow warning. No actual integer overflow tests are performed since it's just a test program. Tested on: Mac OSX/64 10.8.3 (amazon) w/C++ & FORTRAN (h5committest upcoming)
* [svn-r23446] HDFFV-8344, HDFFV-8346: merge from 1.8 branchAllen Byrne2013-03-251-3/+13
|
* [svn-r23415] Description:Quincey Koziol2013-03-211-2/+2
| | | | | | | Avoid using fpclassify() for detecting zero/non-zero values. Tested on: Mac OSX/64 10.8.3 (amazon) w/debug
* [svn-r23395] Description:Quincey Koziol2013-03-205-489/+455
| | | | | | | | | | | | Bring Coverity changes from branch to trunk: r20682: fixed coverity: 76, 77, 635, 636, 1164, 1165, 1166, 1121, 1122, 1117, 1343 Tested on: Mac OSX/64 10.8.3 (amazon) w/C++ & FORTRAN (too minor to require h5committest)
* [svn-r23353] Correct target nameAllen Byrne2013-03-151-3/+3
|
* [svn-r23305] HDFFV-8257: szip still used even if headers are not found. ↵Allen Byrne2013-02-183-195/+188
| | | | | | Change configure to test the result of the CHECK HEADERS call before checking for the library. Tested: local linux, h5committest
* [svn-r23304] Purpose:Jonathan Kim2013-02-181-0/+7
| | | | | | | | | | | | HDFFV-7643 - h5diff - incorrect exit-code returns for extra attribute exist Description: h5diff: Fixed to return correct exit code 1 when detect unique attribute. Prior to this fix, h5diff returned exit code 0 indicating two files are identical. Tested: jam (linux32-LE), koala (linux64-LE), ostrich (linuxppc64-BE), fred (mac64-LE), emu (solaris-BE), Windows (32-LE cmake), cmake (jam)
* [svn-r23226] HDFFV-8285: suppress-ddl option: Changed file options to allow ↵Allen Byrne2013-02-042-0/+3
| | | | | | for filename F to be optional. Tested: local linux
* [svn-r23219] Description:Quincey Koziol2013-02-021-33/+19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bring reviewed changes from Coverity branch back to trunk (QK & JK): r20457: Coverity issue 691: return of H5duo could be negative. Fixed by using STDOUT_FILENO and redesign parse_command_line and main to cleanup file allocations. The output_file var is null when using stdout. In cleanup do not close output_file if NULL. r20510: Initialize ufid = -1 and predicate HDclose call on ufid != -1 r20511: Purpose: Fix coverity issue 1715 Description: Free "file" and nested data on failure in H5FD_core_open. r20512: Initialize ifid = -1 and predicate HDclose call on ifid != -1 r20514: Initialize h5fid = -1 and predicate HDclose call on h5fid != -1 r20516: Added else branch to the if (ret_value < 0) check. r20522: Addressed coverity issues 930-933, 850, 836, 835, 1307. All minor potential buffer overwrite bugs, or coverity errors. Fixed by replacing strcpy and sprintf with strncpy and snprintf. r20523: fixed coverity issues 68, 1120, 1116i r20524: Check H5Z_SZIP->encoder_present < 1 assuming 0 represents absence. r20601: Purpose: Fix coverity issues 1703-1705 Description: Modified the cleanup code in test_free in accum.c to reset allocated buffers to NULL after they are freed, and modified the error cleanup code to check if these buffers are NULL before freeing them. Also fixed some unrelated warnings in accum.c. r20602: Use HDsnprintf and HDstrncat r20603: Purpose: Fix coverity issues 808-809 Description: Modified test_core in vfd.c to check the returns from malloc, and keep track of whether points and check are allocated by setting them to NULL when they are not. Added code to free points and check on error if they are not NULL. Also fixed unrelated warnings in vfd.c. r20604: Use HDstrncpy. r20605: Use HDstrncpy and HDstrncat. r20606: Purpose: Fix coverity issue 807 Description: Modified long_compact in stab.c to keep track of whether objname is allocated by setting it to NULL when it is not. Added code to free objname on error if it is not NULL. r20607: Changed string function calls to use versions that specify the string length to fix coverity issues 832 and 839. Tested on: Mac OSX/64 10.8.2 (amazon) (Too minor to require h5committest)
* [svn-r23216] Add newline for special case of only raw data to stdoutAllen Byrne2013-01-311-2/+7
|
* [svn-r23190] HDFFV-8285: Add suppress ddl option.Allen Byrne2013-01-224-35/+68
| | | | Tested: local linux
* [svn-r23160] HDFFV-8227: Mac DARWIN requires CMake 2.8.10Allen Byrne2013-01-141-1/+1
|
* [svn-r23158] HDFFV-8169: h5dump incorrectly dumps a string into a binary fileAllen Byrne2013-01-141-1/+1
| | | | Tested: local linux
* [svn-r22998] Description:Quincey Koziol2012-11-012-23/+30
| | | | | | | | | | | | | | | | | | | | | | | Clean up warnings and bring changes from Coverity branch back to trunk: r20451: Fixed coverity 810 r20454: Purpose: Fix coverity issue 816 Description: Modified various file drivers to always check the return value from H5P_get_driver_info. r20455: Purpose: Cleanup fix for coverity issue 816 Description: Removed redundant check for "fa" in H5FD_core_open. Tested on: Mac OSX/64 10.8.2 (amazon) w/debug (Too minor to require h5committest)
* [svn-r22933] Purpose:Jonathan Kim2012-10-191-0/+18
| | | | | | | | | | HDFFV-8145 h5diff slowness with version >= 1.8.7 Description: Improved speed when comparing HDF5 files with lots of attributes. Much slower performance was identified with release version from 1.8.7 to 1.8.10 compared to 1.8.6. Tested: jam (linux32-LE), koala (linux64-LE), ostrich (linuxppc64-BE), tejeda (mac32-LE), Windows (32-LE cmake), cmake (jam)
* [svn-r22921] Description:Quincey Koziol2012-10-181-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | Review Coverity changes and bring them back to trunk. (QK & JK) r20402: Added #includes for h5tools.y or h5tools_utils.h as required to remedy implicit function declarations which caused compiler warnings and coverity issues 703-4 and 708-11. r20414: This is related to the previous checkin r20399. There were incorrect updates which caused incorrect behavior when no file was given. Also possible segfault when handling hyperslab options. Simplify the code changes. r20449: Description: Modified H5E_walk2_cb to check return value of H5I_object_verify. r20450: fixed coverity 813 Tested on: Mac OSX/64 10.8.2 (amazon) w/C++, FORTRAN, debug & threadsafe (too minor to require h5committest)
* [svn-r22908] Reverted changes in revision 22819Larry Knox2012-10-161-2/+0
| | | | Tested with h5committest on jam, koala and ostrich.
* [svn-r22819] Added H5BLD_STATIC and HDF5_USE_SHLIB to configure.ac so that ↵Larry Knox2012-09-271-0/+2
| | | | | | if configured with --disable-static the default for HDF5_USE_SHLIB in the compile scripts will be changed to yes. This is a fix for HDFFV-8141, where the compile scripts try to link to non-existant static hdf5 libraries. Tested on jam,koala,ostrich(h5committest) and other THG machines.
* [svn-r22785] HDFFV-8153: Pull POSIX_C_SOURCE define out to separate ↵Allen Byrne2012-09-181-0/+5
| | | | | | variable. Use ADD_DEFINITIONS (${HDF5_EXTRA_C_FLAGS}) in non-fortran CMakeLists.txt folders Tested: jam with intel compilers
* [svn-r22751] Purpose:Jonathan Kim2012-09-102-8/+22
| | | | | | | | | | | | HDFFV-5919 - GMQS: h5diff - The number of object difference is not consistent between dataset and group/type when attribute(s) have differences Description: Object differences are not consistent between dataset and group/datatype when their attribute(s) have differences. This is because attribute(s) differences is not accumulated to group or datatype object’s difference, but accumulated to dataset difference. To fix, do not accumulate attribute difference to dataset difference. This is referred to h5diff’s default behavior and also past report from users that users were confused by the accumulated behavior. (also can’t figure out only for dataset difference , also hard to spot dataset difference when it has lots of attributes or differences) This also lead to fix inconsistent format indicating difference between dataset and group/datatype object. Tested: jam (linux32-LE), koala (linux64-LE), ostrich (linuxppc64-BE), tejeda (mac32-LE), linew (solaris-BE), Windows (32-LE cmake), cmake (jam)
* [svn-r22709] HDFFV-8129: reconfigured on jam, Remove overloading of ↵Allen Byrne2012-08-231-15/+16
| | | | | | autotools TESTS var, rename configure.in to configure.ac, convert test scripts from hard *.sh to configure managed *sh.in files. Tested: h5committest
* [svn-r22706] Updated autotools: autoconf 2.69, automake 1.12.3, m4 1.4.16, ↵Larry Knox2012-08-221-51/+104
| | | | | | libtool 2.4.2 Tested THG machines.
* [svn-r22684] Purpose: Jonathan Kim2012-08-154-20/+59
| | | | | | | | | | | | Address HDFFV-7942 - h5diff: incorrect result for comparing attribute data with different type size in same class Description: When comparing attribute data values with same type class but different size, the result was incorrect. It was due to the size difference and got truncated. Fixed to match up the smaller type size to big type size like what dataset does. Tested: jam (linux32-LE), koala (linux64-LE), ostrich (linuxppc64-BE), tejeda (mac32-LE), linew (solaris-BE), Windows (32-LE cmake), cmake (jam)
* [svn-r22637] Remove legacy command to kill MPI processes on obj to obj testing.Allen Byrne2012-08-061-18/+9
| | | | Tested: Windows, jam, koala
* [svn-r22631] Move executable statement to after declarationsAllen Byrne2012-08-061-2/+2
|
* [svn-r22625] HDFFV-8111: h5diff compare file to itself - removed path shortcutAllen Byrne2012-08-0310-464/+217
|
* [svn-r22618] Jonathan Kim2012-08-011-8/+0
| | | | | | | | | | | | | | Purpose: HDFFV-8003 - ph5diff (parallel h5diff): daily test failure on ember intermittently during non comparable test file comparison HDFFV-7755 - parallel h5diff : hanging on koala intermittently during non comparable test file comparison Description: non-comparable test intermittently hung on koala and ember, but not on jam. it didn't occur until -np reaches 4 or bigger. it occurred once out of many repeated attempts of the same test. There was a incorrectly (mistakenly?) duplicated code in MPI section which caused such hang in a certain condition. The test used more processes than other tests, which increased chance to trigger more undone processes, and such process could enter the incorrect code section and wait for wrong pair of send. it explains why it occurred intermittently according to machine condition and using a certain feature. Removed incorrect code which blocked correct code. Tested: some manually repeated test performed jam (linux32-LE), koala (linux64-LE), ostrich (linuxppc64-BE)
* [svn-r22604] cast void* to char* for calculationAllen Byrne2012-07-261-6/+6
| | | | Issue on windows
generated by cgit v0.12 at 2024-10-30 23:19:54 (GMT)