summaryrefslogtreecommitdiffstats
path: root/tools/lib
Commit message (Collapse)AuthorAgeFilesLines
* [svn-r20108] Purpose:Jonathan Kim2011-02-151-9/+4
| | | | | | | | | | | | | | Fixing Bug 2092 - h5dump does not display index for a dataset Description: h5dump skip displaying array indices every certain number when the array type dataset is relatively big. The certain number varies according to the size of each array. This checkin fix the skipping array indices problem. This fix also correct indentation of the dataset data output. Tested: jam (linux32-LE), amani (linux64-LE), heiwa (linuxppc64-BE), tejeda (mac32-LE), linew (solaris-BE)
* [svn-r20070] Description:Quincey Koziol2011-02-091-1/+1
| | | | | | | Switch order of system includes, to correct error on FreeBSD machines. Tested on: FreeBSD/32 6.3 (duty) w/debug
* [svn-r20065] Description:Quincey Koziol2011-02-085-13/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bring changes from Coverity branch to trunk: r19975: Fixed potential mem leak at H5O_attr_open_by_name r19980: Fix coverity issue 792. Free tmp_env_prefix in H5Lexternal.c line 365 if it is not NULL but its contents are 0 when it goes out of scope. r20039: Eliminate warnings about nested extern and implicit declarations of parallel_print and address Coverity defects 712-781 by #including h5tools_utils.h in h5diff_array.c, h5diff_attr.c, h5diff_dset.c and h5diff_util.c. r20046: Purpose: Address TOCTOU warnings in h5jam and h5unjam Description: Coverity is afraid that the state of the input file could change between the call to stat() and the call to open(). This is called a time-of- check time-of-use (TOCTOU) vulnerability. Modified stat calls to fstat which uses an open file pointer so it (hopefully) won't complain any more. r20047: Addressed coverity issues 135-137, 462-464. Local pointers that needed to be freed in case of error were moved out of a switch statement in src/H5Tnative.c, set to NULL, and checked before freeing. Tested on: Mac OS X/32 10.6.6 (amazon) w/debug & production (h5committested on Coverity branch)
* [svn-r20061] Description:Quincey Koziol2011-02-081-128/+88
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bring changes from Coverity branch to trunk: r19930: Fix memory leaks involving VL attributes in h5repack and h5diff. The buffers in copy_attr and diff_attr were not checked for the presence of a vlen before being freed, and vlen storage was never reclaimed. Added checks and calls to H5D_vlen_reclaim(). r19933: Purpose: Fix memory leak in H5L_move_cb() Description: H5L_move_cb copied the source link using H5O_msg_copy() but freed it manually using H5MM_xfree(). Since H5O_link_copy allocates the link using H5FL_MALLOC, this causes the link to be allocated from the free list but is never put back on the free list when it is freed. This prevents the link free list from shutting down properly. Modified H5L_move_cb() and H5L_move_dest_cb() to free the link properly using H5O_msg_free(). r19973: Fix resource leaks by freeing string created by HD5f2string r19974: Issue #345: Inialize buf variable to null Tested on: Mac OS X/32 10.6.6 (amazon) w/debug & production (h5committested on Coverity branch)
* [svn-r20052] Description:Quincey Koziol2011-02-061-147/+104
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Clean up Coverity warnings, and fix some style issues: r19735: Fix for memory leak in test/mf found by valgrind. r19736: Fix memory leak in h5repack. The buffer in copy_objects, when copying the entire dataset at once, was not checked for the presence of a vlen, and vlen storage was never reclaimed. Added check and call to H5D_vlen_reclaim(). r19772: Change H5assert() to if (H5T_VLEN != src->shared->type || H5T_VLEN != dst->shared->type) HGOTO_ERROR(H5E_ARGS, H5E_BADTYPE, FAIL, "not a H5T_VLEN datatype") r19774: removed unused priv. r19775: removed unused variables r19778: Fix memory leak comparing for variable length data types. r19834: Fixed memory leaks found by valgrind. Memory errors remain for another day. Tested on: Mac OS X/32 10.6.6 (amazon) w/debug & production (h5committested on branch)
* [svn-r19918] Add hh modifier to signed char printf format string. Added ↵Allen Byrne2011-01-052-2/+2
| | | | | | | h5dump test to verify that signed/unsigned datasets print correctly. Bring solution from 1.8 packed bits fix which solved problem on heiwa with Signed char of 8 bits Tested: local linux
* [svn-r19909] Change how LINK_FLAGS for fortran are appended on WindowsAllen Byrne2011-01-051-1/+0
| | | | bring r19908 from 1.8 branch
* [svn-r19892] Purpose:Jonathan Kim2010-12-281-184/+165
| | | | | | | | | | | | | | | | | | | Bug 2089 - GMQS: h5diff segfault on a compound dataset with fixed length + vlen string type order Description: This is fix for the segfault when h5diff compares a compound dataset with combination of fixed length string types and vlen string types in certain orders. Optimized vlariable length string handling codes. The fix is referred from h5dump handling vlen strings. For testing, several compound datasets were added with various combinations. Previous failed cases: - Vlen string, Fixed length string, Vlen string, Fixed length string - Fixed length string, Fixed length string, Vlen string, Vlen string - Fixed length string, Vlen string, Fixed length string, Vlen string Tested: jam (linux32-LE), amani (linux64-LE), heiwa (linuxppc64-BE), tejeda (mac32-LE), linew (solaris-BE)
* [svn-r19839] Updated to libtool v 2.4, autoconf 2.68 and m4-1.4.15.Larry Knox2010-11-231-0/+3
| | | | Tested with h5committest on amani, heiwa, and jam.
* [svn-r19759] Purpose:Jonathan Kim2010-11-111-4/+12
| | | | | | | | | | | | | | | | | | Fix compile error for Windows from previous checkin r19757. Description: Previous log: Improve h5diff performance. The following changes for improving h5diff performance: 1) use HDmemcmp() before comparing each elements (memcmp() is very fast at both linew and jam) 2) replace the expensive H5Tequals() calls 3) retrieve datatype information at dataset level not each element level for compound datasets Tested: jam (linux32-LE), Windows
* [svn-r19757] Purpose:Jonathan Kim2010-11-112-36/+132
| | | | | | | | | | | | | | | | Improve h5diff performance. Description: The following changes for improving h5diff performance: 1) use HDmemcmp() before comparing each elements (memcmp() is very fast at both linew and jam) 2) replace the expensive H5Tequals() calls 3) retrieve datatype information at dataset level not each element level for compound datasets Tested: jam (linux32-LE), amani (linux64-LE), heiwa (linuxppc64-BE), tejeda (mac32-LE), linew (solaris-BE)
* [svn-r19712] Purpose:Jonathan Kim2010-11-021-30/+76
| | | | | | | | | | | | | | | Fixed h5diff to handle variable-length strings in a compound dataset correctly. Also variable-length string array in a compound dataset. Bug #1989. Description: Garbage values were displayed when h5diff compared variable-length strings (or string array) in a compound type dataset. Tested: jam (linux32-LE), amani (linux64-LE), heiwa (linuxppc64-BE), tejeda (Mac32)
* [svn-r19654] Description:Quincey Koziol2010-10-211-34/+34
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bring Coverity revisions from branch back to trunk, and clean up some other misc. compiler warnings also. r19500: Fix coverity items 1446 and 1447. Moved up calls to memset in test_cont in ohdr.c so the test never tries to close uninitialized locations. r19501: Fix coverity items 1398-1445. Various uninitialized variable errors in fheap.c. r19502: Fixed coverity issue 579 and some additional warnings in the file as well. r19503: Bug fix: This fix addressed the "RESOURCE_LEAK" problems #789 and 790, run 26 r19504: minor mods to try to keep coverity from flagging false positives. r19505: Fixed coverity issues 566 - 571. Declared variables that are passed to functions that use them as arrays to be arrays of size 1. Tested on: Mac OS X/32 10.6.4 (amazon) w/debug, production & parallel (h5committested on trunk)
* [svn-r19506] Bring changes from revisions 19408, 19421, and 19442 from ↵Larry Knox2010-10-041-5/+15
| | | | | | branches/hdf5_1_8 to trunk. These revisions reorganize the compile scripts using h5cc.in, h5fc.in, and h5c++.in, add checks for installed examples to the scripts that run them after installation, and add DESTDIR for install as needed for RPMs. Tested on amani, heiwa and jam by h5committest and with CYGWIN.
* [svn-r19443] Purpose:Jonathan Kim2010-09-201-10/+14
| | | | | | | | | | Fix for group comparison with exclude-path case. Use relative path. Description: Related to "1890: h5diff excluding object for file comparison via command line" checkins. (r19406) Tested: jam, amani and heiwa
* [svn-r19434] Correct use of lib, include, bin in INSTALL commands to use ↵Allen Byrne2010-09-201-4/+4
| | | | | | proper variables. Tested: local linux
* [svn-r19418] On windows, an include bypassed the WIN32_LEAN_AND_MEAN define. ↵Allen Byrne2010-09-171-1/+1
| | | | | | Moved the define up. Moved the h5dif.h to after the h5private include Tested: Windows
* [svn-r19406] Purpose:Jonathan Kim2010-09-162-17/+138
| | | | | | | | | | | Add --exclude-path option Description: Specified path to an object will be excluded from comparing the two files or two groups. If group is specified all the member objects will be excluded. Related to "1890: h5diff excluding object for file comparison via command line" Tested: jam, amani and heiwa
* [svn-r19400] Purpose:Jonathan Kim2010-09-167-311/+896
| | | | | | | | | | Fix for Bug1975 h5diff - support recursive comparison on group when specified as an object Description: Compare member objects and groups recursively when two files or groups are specified to be compared. Support parallel diff and handling symbolic links accordingly. Tested: jam, amani, heiwa
* [svn-r19366] Updated autoconf to version 2.6.7, libtool to version 2.2.10, ↵Larry Knox2010-09-101-1/+1
| | | | | | and m4 to version 1.4.14. Also added m4 directory for m4 macros according to autoconf suggestion. Tested with h5committest on amani, jam, and heiwa, and on linew.
* [svn-r19325] Added parallel build commands.Allen Byrne2010-08-311-1/+16
| | | | | | | Corrected use/name of source folder aliases. Duplicated FindMPI.cmake so that non-c++ compiler is found first (recommemded commands did not work). Tested: local linux with mpich
* [svn-r19300] BZ 1958: Add h5dump xml tests to CMake supportAllen Byrne2010-08-251-0/+6
| | | | Tetsed: local linux
* [svn-r19292] Description:Quincey Koziol2010-08-243-40/+47
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Merge r19290 & r19291 from 1.8 branch to trunk: r19290: Correct another error in metadata accumulator dirty region calculations (this time with a corner case when freeing data in the file). r19291: Avoid getting object information for soft/external links if we aren't going to traverse across the link itself. Tested on: FreeBSD/32 6.3 (duty) in debug mode FreeBSD/64 6.3 (liberty) w/C++ & FORTRAN, in debug mode Linux/32 2.6 (jam) w/PGI compilers, w/default API=1.8.x, w/C++ & FORTRAN, w/threadsafe, in debug mode Linux/64-amd64 2.6 (amani) w/Intel compilers, w/default API=1.6.x, w/C++ & FORTRAN, in production mode Solaris/32 2.10 (linew) w/deprecated symbols disabled, w/C++ & FORTRAN, w/szip filter, w/threadsafe, in production mode Linux/PPC 2.6 (heiwa) w/C++ & FORTRAN, w/threadsafe, in debug mode Linux/64-ia64 2.6 (cobalt) w/Intel compilers, w/C++ & FORTRAN, in production mode Linux/64-amd64 2.6 (abe) w/parallel, w/FORTRAN, in debug mode Mac OS X/32 10.6.4 (amazon) in debug mode Mac OS X/32 10.6.4 (amazon) w/C++ & FORTRAN, w/threadsafe, in production mode Mac OS X/32 10.6.4 (amazon) w/parallel, in debug mode
* [svn-r19262] Undo r19261.Allen Byrne2010-08-201-0/+7
|
* [svn-r19261] Remove unused variables and allocationAllen Byrne2010-08-201-7/+0
| | | | Tested: local linux
* [svn-r19252] Description:Quincey Koziol2010-08-197-100/+106
| | | | | | | | | | | | | | | | | | | | | | | Bring Coverity changes from branch to trunk: r19161: Fixed the part for matching the subset info with dataset r19189: BZ1646: h5dump does not check number of dimensions for subsetting parameters against the dataset Changed subset_t structure from holding hsize_t pointers to holding new subset_d pointers, which hold the original hsize_t pointer + len. this len is then checked against dataset ndims in the handle_dataset function of h5dump. Changed all references to use new data structure. Added tests for each subset parameter. r19190: Added new h5dump ddl files Tested on: Mac OS X/32 10.6.4 (amazon) w/debug & production (h5committested on branch)
* [svn-r19237] Description:Quincey Koziol2010-08-124-59/+48
| | | | | | | | | | Clean up misc. compiler warnings. Tested on: FreeBSD/32 6.3 (duty) in debug mode Mac OS X/32 10.6.4 (amazon) w/C++ & FORTRAN, w/threadsafe, in production mode Mac OS X/32 10.6.4 (amazon) w/parallel, in debug mode
* [svn-r19202] [BZ1953]implementation for the proposed changes suggested by ↵Allen Byrne2010-08-091-16/+340
| | | | | | | the "h5dump_output_option" RFC. This required that the region reference code be duplicated and reduced to allow the do_bin_output() function to understand region references. The container type-id also needed to be propagated into the do_bin_output() function and functions referenced (render_bin_output*). Existing tests tested the binary function, so only one test was added to test the region reference generated file. Tested: local linux
* [svn-r19183] Corrected h5repack verbose test for windowsAllen Byrne2010-08-061-18/+18
| | | | | | Updated tools/lib source dir variable for source list Tested: local linux
* [svn-r19153] Description:Quincey Koziol2010-07-291-43/+34
| | | | | | | | | | | | | | | | | | | | | | | | Bring changes on Coverity branch back to trunk: r19040: Fixed coverity #440 - NULL check after dereference. We moved the NULL check up into the IF block and changed it to assertion. r19041: Maintenance: Addressed Coverity issues 441 and 449 by initializing proper variables r19042: In function H5O_chunk_protect (H5Ochunk.c): - Initialize H5O_chunk_proxy_t pointers chk_proxy and ret_value. - Free chk_proxy on error. r19043: Addressed coverity issues 442 - 448 by initializing pointers to NULL. Tested on: Mac OS X/32 10.6.4 (amazon) w/debug & production (Too minor to require h5committest)
* [svn-r19059] Brought changes from hdf5_1_8 to add version information for ↵Larry Knox2010-07-091-0/+2
| | | | | | fortran and c++ compilers in libhdf5.settings file and configure output (r18836), to install examples as part of make install (r18680), and to provide scripts to compile and run the examples after they are installed (r18817). Tested with new/h5committest on amani, heiwa, and jam.
* [svn-r19051] Purpose:Jonathan Kim2010-07-071-6/+5
| | | | | | | | | | | Add --no-dangling-links option to h5ls. Description: Related to "Bug 1830 - Following an dangling external link in h5ls should set non-zero return code." If --no-dangling-links option is specified and any dangling link is found, return exit code 1 (error). Tested: jam, amani and heiwa
* [svn-r18873] Purpose:Jonathan Kim2010-05-211-2/+2
| | | | | | | | | | | Rename '--follow-links' to '--follow-symlinks' Description: The '--follow-links' option is to follow symbolic links (soft and external). Make the name more intuitive and specific to the feature. Tested: jam, amani and linew
* [svn-r18856] Added CPack commands for installtion programAllen Byrne2010-05-191-3/+5
| | | | Tested: local linux and Windows
* [svn-r18816] Move progname and d_status functions from h5tools to h5tools_utilAllen Byrne2010-05-144-34/+34
| | | | | Tested: linux and windows
* [svn-r18793] Add files to support building library with CMakeAllen Byrne2010-05-131-0/+68
| | | | Tested: Local linux
* [svn-r18759] pull r18757 from 1.8 branchAllen Byrne2010-05-119-64/+111
| | | | | | | | | Enable tools lib to be built as a dll on windows. Added two get/set functions for progname and d_status. Also add windows import/export declarations to functions. Updated error_mesg() and warn_mesg() to remove progname argument and use get functions Tested: Windows, linux
* [svn-r18709] Purpose:Mike McGreevy2010-05-051-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | Improve configure's large-file support control. Description: Modified configure to now attempt to add defines necessary for supporting largefiles on all systems, instead of solely on linux. This is in response to user requests to enable largefile support on Solaris by default, as well as to give extra control on AIX (instead of just jamming the necessary flag into the config files). The old --enable-linux-lfs flag has been removed in favor of the --enable-largefile flag (enabled by default), which can be used on all platforms. On systems where large files cannot be supported in this manner, configure will report as such. Tested: h5committest AIX (NCSA's blue_print machine) duty, liberty, and linew.
* [svn-r18614] Purpose:Jonathan Kim2010-04-223-145/+163
| | | | | | | | Fix for bug 1817 : h5copy fail to copy dangling link by specifying link path directly Tested: jam, amani, linew
* [svn-r18579] Purpose:Mike McGreevy2010-04-151-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Autotool Upgrade / Libtool Bug Fix Description: Updated autotools referenced in bin/reconfigure as follows: Autoconf 2.64 --> Autoconf 2.65 Automake 1.11 --> Automake 1.11.1 Libtool 2.2.6a --> Libtool 2.2.6b-mcg The referenced libtool version is a custom version of 2.2.6b. It has been tweaked to fix a bug in libtool that occurs when using PGI 10.0 compilers. A check incorrectly categorizes the C++ compiler as version 1.0 instead of 10.0, and the link line is subsequently set up incorrectly and fails to compile. A patch has been made available and will be included in the next release of libtool, but in the meantime I've applied the patch to a custom installation as indicated above. This bin/reconfigure now references the custom installation, and the resulting configure script will correctly categorize the PGI 10.0 C++ compiler. Ran bin/reconfigure to regenerate configure and makefiles. Tested: jam and amani with PGI 10.0 compilers. h5committest
* [svn-r18548] Description:Quincey Koziol2010-04-131-1/+1
| | | | | | | Minor cleanups to compile with PGI C compiler 10.x. Tested on: Linux 2.4/32 (jam) w/PGI 10.x C and F90 compilers
* [svn-r18425] Purpose:Jonathan Kim2010-03-181-1/+2
| | | | | | | | | | | | Fix for bug1814 - NPOESS: h5repack doesn't handle references to the groups as an element of a dataset Description: handles object reference to named-datatype as well. Add test cases. Tested: jam, amani, linew
* [svn-r18273] Purpose:Jonathan Kim2010-02-181-6/+64
| | | | | | | | | | | | | | | | | | bugzilla 1754: h5diff: support comparing through links. Description: Fix incorrect (or hanging) behavior in parallel mode when specifying invalid combination of command options. (ex: -v and -q , --no-dangling-links without --follow-links) Add relate test case Update h5diffgentest.c due to add test files this and previous time Note: svn #18266 (prior to this) svn #18164 (original check-in) Tested: h5committest (jam, amani and linew)
* [svn-r18266] Purpose:Jonathan Kim2010-02-162-526/+482
| | | | | | | | | | | | | | | bugzilla 1754: h5diff: support comparing through links. (original check-in svn revision #18164) Description: fix the hang issue in parallel mode when compare external-link. add --no-dangling-links option. add test cases (#450-#459) relate to the new option. improve test script to check exit code. update --help relate to the new options. correct some indentations. Tested: h5committest (jam, amani and linew)
* [svn-r18197] Description:Quincey Koziol2010-01-3011-409/+409
| | | | | | | | | Trim trailing whitespace from source code files with this command: find . \( -name "*.[ch]" -or -name "*.cpp" -or -name "*.f90" \) -print |xargs -n 1 sed -i "" 's/[[:blank:]]*$//' Tested on: None - eyeballed only
* [svn-r18166] Purpose:Jonathan Kim2010-01-261-2/+1
| | | | | | | | | | | Take care of test case fail for h5repack from checkin (r18164) Description: Previous checkin didn't allow h5diff to return succeed when a link's target object doesn't exist. Changed it to succeed with warning. (Need to discuss related feature) Tested on Jam
* [svn-r18164] Purpose:Jonathan Kim2010-01-252-39/+587
| | | | | | | | | | | | | | | Add a feature to compare through links. Relate to bugzilla report 1754. Description: Currently, h5diff command only compares the name(path) of target object not the actual data. With this feature, h5diff will go through the link(s) and figure out the actual object at the end of the link and compare data if exist. Internally we have hard-link, soft-link, external-link (as part of user_defined-link). This feature will provide a user transparent experience when comparing link objects as the user can specify any of those 3 type of links to be compared in any combination. Tested on Jam.
* [svn-r18159] Description:Quincey Koziol2010-01-231-90/+30
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bring Coverity fixes from 1/22/10 session to trunk: r18137: 219: Initialized hid_t to -1 and added close to error block. 189-191: Initialized line to NULL and added free line, and close fp to error block. r18138: 19: Moved code block for printing that the number of enums is empty to the error block. (Would never have been executed otherwise) r18139: Fix coverity item 58. Moved code related to displaying the parent of a repeated group to the else(isRoot) section, as the root group has no parent. r18140: 218: Initialized ret_value variable to -1. Because of throw Exception in default case of switch, the coverity problem would not have executed anyway. Good pratice is to initialize variables. r18141: Fix coverity item 92. Added code to H5E_register_class to free cls in case of an error. r18142: Fix coverity item 91. Added code to H5E_create_msg to free msg in case of an error. r18143: fixed issue 14, took away "if" and used #ifndef_xxx. r18144: Fix coverity item 110. Added code to H5Eget_minor to free msg_str in case of an error. r18145: fixed coverity #18 removed "aligned", it is always NULL. r18146: Fix coverity item 109. Added code to H5Eget_major to free msg_str in case of an error. r18147: Fixed coverity #81 and #82, Check for bad pointer(s), but can't issue error, just leave r18148: Fix coverity item 97. Added code to H5FD_fapl_open to free copied_driver_info in case of an error. r18149: Fix coverity item 96. Added code to H5FD_dxpl_open to free copied_driver_info in case of an error. r18150: Fix Coverity issue #29: Protected cache_ptr dereferences with "if(pass)" block r18151: Fix coverity item 93. Added code to H5FL_fac_init to free factory and new_node in case of an error. r18152: Fix coverity items 98 and 99. Added code free allocated space in case of error. r18155: 124: Freed head pointer before jumping to done. There was no error handling block and normal exit used same path out. 120-123: Freed list of lists in error handling block. r18156: Fix coverity issues 179, 180, 181, 182, 183, 184, 186, 320, 407. These were resource leak issues where allocated memory was not freed, generally in the case of tests that failed. Tested on: Mac OS X/32 10.6.2 (amazon) debug & production
* [svn-r18134] Purpose:Jonathan Kim2010-01-212-5/+9
| | | | | | | | | | | | Additional fix relted to the fix of bug1672. Description: The fix of bug1672 caused some changes of output which required modifying some test cases. After some discussion, restoring the changes of the test cases was decided. After many experiments for the solution, this fix was made so the code which improved performance can stay. Tested on Jam.
* [svn-r18126] Fix for bug1749: Incorrect code in diff() function for links ↵Jonathan Kim2010-01-201-12/+2
| | | | compare