summaryrefslogtreecommitdiffstats
path: root/tools/src
Commit message (Collapse)AuthorAgeFilesLines
* Update reformatting settings, trace wrapping, and printf-format strings (#22)Quincey Koziol2020-10-061-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | * Add BEGIN_FUNC / CATCH / END_FUNC to macros * Remove incorrect trailing '{' * Update trace script to wrap H5TRACE macros at 110 characters and improve comments for code that performs this operation. * Clean up printf-formatting in H5public.h and correct some oversights in the code. * Reformat with BEGIN_FUNC / END_FUNC handled correctly by clang-format * Run clang-format on changes. * Correct H5_SIZEOF_HSIZE_T/H5_SIZEOF_HSSIZE_T macros to match typedef. * And make the undef value match also. * Update comment * Update clang-format actions to exclude generated files. * Post-process generated H5LTparse.h file as well as H5LTparse.c file. * Fix formatting * Update version of github clang-format action
* HDFFV-11096 replace backticks with doublequotesAllen Byrne2020-10-042-7/+7
|
* HDFFV-11096 fix typo in h5dump usage textAllen Byrne2020-10-031-1/+1
|
* Clang-format of source filesAllen Byrne2020-09-3033-10356/+10672
|
* Fix jni with %Lg instead of %LfAllen Byrne2020-09-291-4/+4
| | | Fix warnings due to improper formed define tag in h5diff
* Merge pull request #2650 in HDFFV/hdf5 from ↵David Young2020-09-287-46/+46
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ~DYOUNG/werror:rebased-fprintf-experiment to develop * commit 'c0fbc5c086566d5d3c1d1ef26baa81a53d59fc08': (24 commits) Use the right format string, "%zu", for size_t. Repair more format strings. Fix a bunch of format string errors reported by Larry. Fix some HDfprintf compilation errors: use the right format strings ("zu", PRIuHSIZE), avoid casting some printf arguments, pass the right number of arguments. Test the format string "ll" before "l", "L", and "q", like the ./configure script does. This ought to fix the compilation failure in test/dt_arith.c that Allen told me about: Cast a non-void pointer to void pointer for "%p". Use PRIu32 and "zu" formats. Delete some casts from `size_t`. I'm taking a guess that this code intended to point the 2-digit wide hexadecimal octet values, not 2 character-wide pointers to the bytes. The %02p format, which is a GNU-ism, disagreed with GCC 8.3.0 and the option flags we use. %08p is not portable, it's a GNU-ism. Use %8p, instead. Squashes a GCC error. Add format string macros PRI[doxX]HID for hid_t and use PRIdHID. Use HDva_copy() and introduce a bunch of compatbility format-string constants for uppercase hexadecimal strings, `PRIX...`. Should fix the VS2010 errors that Allen mentioned: Always #define HDfprintf as fprintf in this header. I believe this will fix the Windows build error that Allen reported. Provide an HDvasprintf implementation only if it isn't #defined. This should fix the mingw compilation issue that Allen reported. Fix va_list usage in the vasprintf(3) implementation. Promote format-string warnings to errors. Use the portable `-eq` operator instead of the bash-ism `==`. Fixes the tests on NetBSD, where /bin/sh != bash. Restore a literal percent sign ("%%") that I accidentally deleted. Fix code that made GCC complain about a NULL or `unsigned char *` arguments for "%s". Take pains to provide UINT64_MAX in all conditions. Correct a couple of format strings. ...
| * Merge remote-tracking branch 'hdffv/develop' into rebased-fprintf-experimentDavid Young2020-09-2710-2/+133
| |\
| * \ Merge remote-tracking branch 'hdffv/develop' into rebased-fprintf-experimentDavid Young2020-09-0315-69/+148
| |\ \
| * \ \ Merge remote-tracking branch 'hdffv/develop' into rebased-fprintf-experimentDavid Young2020-07-3017-728/+573
| |\ \ \
| * | | | Restore a literal percent sign ("%%") that I accidentally deleted.David Young2020-07-071-1/+1
| | | | |
| * | | | Delete extra argument, there is no formatting for it.David Young2020-07-071-1/+1
| | | | |
| * | | | Squash my changes on branch `fprintf-experiment` into one commit forDavid Young2020-07-076-45/+45
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | reapplication to my new warnings branch, `warnings-again`. These changes are included: commit 915551b7bf64e777dd2007386ec77b1d117770da Merge: 63858c2 a8892bb Author: David Young <dyoung@hdfgroup.org> Date: Mon Nov 25 17:39:49 2019 -0600 Merge remote-tracking branch 'hdf5/develop' into fprintf-experiment commit a8892bb42d6f6e4fbc30fae0eb2b957f81c938b9 Merge: 5c911d8 f907b51 Author: David Young <dyoung@hdfgroup.org> Date: Mon Nov 25 17:33:54 2019 -0600 Merge pull request #2055 in HDFFV/hdf5 from ~DYOUNG/vchoi_fork:add-werror-and-squash-some to develop * commit 'f907b511d06612dafc7814a7c30f2f3d2b76d52b': Oops, remove more C99 designated initializers for VS 2010 compatibility. commit 63858c22e168acaec0af8ced6641f26102cc6bb0 Merge: 20ae787 5c911d8 Author: David Young <dyoung@hdfgroup.org> Date: Mon Nov 25 17:04:42 2019 -0600 Merge remote-tracking branch 'hdf5/develop' into fprintf-experiment commit 5c911d8baf3ee7fe654269088eebdf07f59a8192 Merge: b8a5671 62208b0 Author: David Young <dyoung@hdfgroup.org> Date: Mon Nov 25 16:58:27 2019 -0600 Merge pull request #2030 in HDFFV/hdf5 from ~DYOUNG/vchoi_fork:add-werror-and-squash-some to develop * commit '62208b056a09c01855fbac7f75146be58ad6bfe5': (44 commits) Add an #include to get a function declaration. Don't use C99 designated initializers, they're not compatible with Visual Studio 2010. Quiet some more maybe-uninitialized warnings---each is a false positive, *sigh*. This is more code that may not compile with VS2010, *sigh sigh*. Always warn on maybe-uninitialized. -Wincompatible-pointer-types was not available until GCC 5, so enable it only if that's the GCC version we're using. Only promote maybe-uninitialized warnings to errors on GCC 8. Even on GCC 8, there may be false positives at low optimization levels? I need to check. Only use -Werror=cast-function-type with GCC 8 and later. Put all of the -W options back into the order I found them in so that it's easier to compare old and new config/gnu-flags. Add new source files to CMakeLists.txt. Mention the -Werror= flags in libhdf5.settings.in. free -> HDfree Promote decleration-after-statement warnings to errors. Quiet decleration-after-statement warnings. Move a statement under some declarations since some vintages of Visual Studio don't like declarations after statements. Document H5D__chunk_mem_xfree_wrapper(). Undo accidental test deletion. Oops, delete a debug printf that snuck in here. Undo my changes to the HD macros, hadn't really intended those to be on this branch.... Make errors of some more warnings. Move disabled warnings to DEVELOPER_WARNING_CFLAGS. Put just one warning option on a line, and sort some of the options. Cast to the parameter type, H5VL_token_t *, instead of to unsigned char *. Change hdset_reg_ref_t and H5R_ref_t from arrays of unsigned char to structs containing those arrays. Encapsulating the arrays in this way makes it easier to write and think about pointers to these types, casts to/from these types, etc. ... commit 20ae7877e33931b95e8c3502b027d6c3fe94a11f Merge: 46f8c61 edd5297 Author: David Young <dyoung@hdfgroup.org> Date: Fri Nov 22 15:34:09 2019 -0600 Merge remote-tracking branch 'origin/add-werror-and-squash-some' into fprintf-experiment commit 46f8c613d5117a8be5bc8385a072daa0b4262f06 Author: David Young <dyoung@hdfgroup.org> Date: Fri Nov 22 15:29:00 2019 -0600 GCC really wants us to use `ll` to format `long long`, so try to make that work before any other format modifier. Seems like we're not compiling the autoconf test program with -Werror=format ? Probably should. commit eee35b8ef3759c391327cd48a9b3c56b6f8abc99 Author: David Young <dyoung@hdfgroup.org> Date: Fri Nov 22 15:28:05 2019 -0600 It's hard to know just how wide an HDoff_t will be, and I don't think POSIX or C standards provide a PRI macro for it, so cast to intmax_t and format using PRIdMAX. commit 86eab12df7a89b546a38e99f8178dd2adbcb3433 Author: David Young <dyoung@hdfgroup.org> Date: Fri Nov 22 15:26:25 2019 -0600 URemove some casts.se the right format string for the argument. Here and there stop casting a printf argument. commit f722f7cbecbaa99449941484b014426f62f1bed5 Merge: 58e3743 6d5ec83 Author: David Young <dyoung@hdfgroup.org> Date: Fri Nov 22 14:44:16 2019 -0600 Merge branch 'add-werror-and-squash-some' into fprintf-experiment commit 58e3743b7faa9836606ee91798fe80dfc0040da7 Author: David Young <dyoung@hdfgroup.org> Date: Wed Nov 20 21:07:21 2019 -0600 Remove custom HDfprintf implementation, using the standard library's, instead. Take a swipe at repairing fprintf format strings, mainly replacing "%Hu" with "%" PRIuHSIZE, "%a" with "%" PRIuHADDR, "%Zu" with "%zu". Here and there remove an awkward cast of a printf argument to `long long` and use PRI[doux]8, PRI[doux]32, or PRI[doux]64, instead. Change occurrences of "%t" to "%s" and perform a suitable change of argument, `cond` -> `cond ? "TRUE" : "FALSE"`. Some occurrences of %Hu, %a, and %t remain, they just weren't flagged by the compiler because of #ifdef'age. commit d4366909293fa970c23512ac80e5d865d76cddbf Author: David Young <dyoung@hdfgroup.org> Date: Wed Nov 20 20:54:32 2019 -0600 Promote format-string warnigns to errors.
* | | | | OESS-98 merge with clang-format changesAllen Byrne2020-09-2510-30/+30
| |_|_|/ |/| | |
* | | | CMake and script changes for clang-formatAllen Byrne2020-09-0410-2/+133
| |_|/ |/| |
* | | Minor refactoring based on 1.10 normalization workDana Robinson2020-08-171-1/+1
| | |
* | | TRILABS-277 Use JIRA number as #ifdefAllen Byrne2020-08-151-4/+5
| | |
* | | Merging in latest from upstream (HDFFV/hdf5:refs/heads/develop)Allen Byrne2020-08-151-1/+0
|\ \ \ | | | | | | | | | | | | | | | | * commit '40bf112b56c90b7e90c9ec3d7a35a78d1d12288b': Trivialities noticed while merging things to 1.10
| * | | Trivialities noticed while merging things to 1.10Dana Robinson2020-08-151-1/+0
| | | |
* | | | HDFFV-9984 Add options to merge/prune external links during repackAllen Byrne2020-08-144-51/+128
|/ / /
* | | Removes staff email addresses from the repositoryDana Robinson2020-08-076-7/+6
| | | | | | | | | | | | Removes redundant C library headers from hl library
* | | Warning fixes in tools and h5test.cDana Robinson2020-08-061-1/+4
| | |
* | | Minor normalizations with 1.12 branchDana Robinson2020-08-012-7/+7
| |/ |/|
* | Warnings reduction in toolsAllen Byrne2020-07-302-4/+2
| |
* | Tools refactorAllen Byrne2020-07-1516-724/+571
|/ | | | | | Move error_stack setup to tools library Add structure for h5dump properties Eliminate duplicated h5diff functions Use properties structure in place of argument lists.
* Fix for HDFFV-10961: add description to usage for --increment option.vchoi2020-06-111-2/+7
|
* Merge branch 'develop' of ssh://bitbucket.hdfgroup.org:7999/~jhenderson/hdf5 ↵Jordan Henderson2020-04-271-179/+224
|\ | | | | | | into develop
| * Merge pull request #2540 in HDFFV/hdf5 from extend_h5debug to developQuincey Koziol2020-04-271-179/+224
| |\ | | | | | | | | | | | | | | | | | | * commit '3f3363177d5cc1efc8fcfc70e1feed7a293da2d4': Range check # of 'extra' command-line parameters against array size. Refactor "extra" command-line arguments, and clean up code so the tool doesn't assert when exiting. Extend h5debug to support 3-D datasets for chunks.
| | * Range check # of 'extra' command-line parameters against array size.Quincey Koziol2020-04-261-1/+9
| | |
| | * Refactor "extra" command-line arguments, and clean up code so the tool doesn'tQuincey Koziol2020-04-261-183/+216
| | | | | | | | | | | | assert when exiting.
| | * Extend h5debug to support 3-D datasets for chunks.Quincey Koziol2020-04-251-3/+7
| | |
* | | Fix memory error in h5dump xml 'escape the string' routineJordan Henderson2020-04-271-4/+2
|/ /
* | Further updates to the tools warnings fixes from code review.Dana Robinson2020-04-271-3/+7
| |
* | Updates to tools warning PR from code review.Dana Robinson2020-04-261-8/+4
| |
* | Fixes for warnings in the tools code.Dana Robinson2020-04-253-11/+15
|/
* Merge pull request #2532 in HDFFV/hdf5 from ~DEROBINS/hdf5_der:develop_minor ↵Dana Robinson2020-04-236-156/+318
|\ | | | | | | | | | | | | | | to develop * commit '785bd0975ba13c3033820d0fc809da963fcd54ca': Fixed h5diff command-line parameters to use 1 and 2 instead of src and dst. Added VOL command-line options to (p)h5diff, h5ls, h5dump, and h5mkgrp.
| * Fixed h5diff command-line parameters to use 1 and 2 instead of srcDana Robinson2020-04-221-43/+43
| | | | | | | | and dst.
| * Added VOL command-line options to (p)h5diff, h5ls, h5dump, and h5mkgrp.Dana Robinson2020-04-216-143/+305
| |
* | Merge pull request #2530 in HDFFV/hdf5 from ~DEROBINS/hdf5_der:develop_minor ↵Dana Robinson2020-04-214-31/+25
|\ \ | |/ | | | | | | | | | | to develop * commit 'c6097935d5be4c3750b9bf9167783ad28158905b': Separated VFD and VOL parameters in tools.
| * Separated VFD and VOL parameters in tools.Dana Robinson2020-04-214-31/+25
| |
* | Trim trailing whitespaceQuincey Koziol2020-04-203-7/+7
|/
* Fixed problems with S3 and HDFS VFDs.Dana Robinson2020-04-173-6/+6
| | | | | | * Updated info struct parameter to correct info_string * Fixed Makefile.am where the S3 VFD was listed twice, causing duplicated symbols errors.
* Update h5repack long arguments for id-->value changes.Dana Robinson2020-04-141-2/+2
|
* Changed identifiers and command-line options from "id" to "value" in toolsDana Robinson2020-04-141-8/+8
| | | | code to be in agreement with H5VL API terminology.
* Added support for passing connector info strings via the commandDana Robinson2020-04-094-11/+11
| | | | line to the tools internals.
* Fix for passthrough VOL not passing tools tests due to incorrectDana Robinson2020-04-082-12/+3
| | | | optional callback queries.
* Merging in latest from upstream (HDFFV/hdf5:refs/heads/develop)Allen Byrne2020-04-063-31/+59
|\ | | | | | | | | | | | | * commit '4830a1796441abbb5a4fbd2cff9a651f2a0d066e': Updated tools dump output when dataset offset is undefined. Added checks for native optional call support in some of the tools. Misc changes for h5dump VOL changes.
| * Merge branch 'develop' into tools_vol_updateDana Robinson2020-04-061-8/+8
| |\
| * | Added checks for native optional call support in some of the tools.Dana Robinson2020-04-022-26/+54
| | |
| * | Merge branch 'develop' into tools_vol_updateDana Robinson2020-04-024-37/+37
| |\ \
| * \ \ Merge branch 'develop' into tools_vol_updateDana Robinson2020-03-311-0/+2
| |\ \ \