From a209e23d79c41b0e3d78bb8394d1b2f704d7db77 Mon Sep 17 00:00:00 2001
From: Jordan Henderson <jhenderson@hdfgroup.org>
Date: Fri, 1 Mar 2024 19:27:31 -0600
Subject: Add test program to see if _Float16 really works

---
 config/cmake/ConfigureChecks.cmake | 23 +++++++++++++++---
 config/cmake/HDFTests.c            | 33 +++++++++++++++++++++++++
 configure.ac                       | 49 +++++++++++++++++++++++++++++++++-----
 3 files changed, 96 insertions(+), 9 deletions(-)

diff --git a/config/cmake/ConfigureChecks.cmake b/config/cmake/ConfigureChecks.cmake
index 14e8b75..25de5b0 100644
--- a/config/cmake/ConfigureChecks.cmake
+++ b/config/cmake/ConfigureChecks.cmake
@@ -384,10 +384,27 @@ if (${HDF_PREFIX}_SIZEOF__FLOAT16)
   if (h5_have_flt16_epsilon AND h5_have_flt16_min AND
       h5_have_flt16_max AND h5_have_flt16_min_10_exp AND
       h5_have_flt16_max_10_exp AND h5_have_flt16_mant_dig)
-    set (${HDF_PREFIX}_HAVE__FLOAT16 1)
+    # Finally, some compilers like OneAPI on MSVC appear to just be broken,
+    # as support for _Float16 and its macros can be detected properly, but
+    # then code is generated that uses the __truncsfhf2, __truncdfhf2,
+    # __extendhfsf2 functions, which end up being unresolved with MSVC. Let's
+    # try to compile a program that will generate these functions as a last
+    # resort for checking for _Float16 support.
+    message (VERBOSE "Compiling test program for _Float16 support")
+    try_compile (
+        h5_compiled_float16_test
+        ${CMAKE_BINARY_DIR} 
+        ${HDF_RESOURCES_DIR}/HDFTests.c
+        COMPILE_DEFINITIONS "-DCHECK_FLOAT16"
+        C_STANDARD 99
+    )
 
-    # Check if we can use fabsf16
-    CHECK_FUNCTION_EXISTS (fabsf16 ${HDF_PREFIX}_HAVE_FABSF16)
+    if (${h5_compiled_float16_test})
+      set (${HDF_PREFIX}_HAVE__FLOAT16 1)
+
+      # Check if we can use fabsf16
+      CHECK_FUNCTION_EXISTS (fabsf16 ${HDF_PREFIX}_HAVE_FABSF16)
+    endif ()
   else ()
     set (${HDF_PREFIX}_HAVE__FLOAT16 0)
   endif ()
diff --git a/config/cmake/HDFTests.c b/config/cmake/HDFTests.c
index 095f113..fd0beb2 100644
--- a/config/cmake/HDFTests.c
+++ b/config/cmake/HDFTests.c
@@ -192,3 +192,36 @@ int main ()
 }
 
 #endif /* HAVE_IOEO */
+
+#ifdef CHECK_FLOAT16
+
+#define __STDC_WANT_IEC_60559_TYPES_EXT__
+#include <float.h>
+
+int
+main(int argc, char **argv)
+{
+    signed char a;
+    _Float16    b;
+    double      c;
+
+    /* Convert signed char to _Float16  */
+    a = 1;
+    b = (_Float16)a;
+
+    /* Convert back */
+    b = 3.0f16;
+    a = (signed char)b;
+
+    /* Convert double to _Float16 */
+    c = 5.0;
+    b = (_Float16)c;
+
+    /* Convert back */
+    b = 3.0f16;
+    c = (double)b;
+
+    return 0;
+}
+
+#endif /* CHECK_FLOAT16 */
diff --git a/configure.ac b/configure.ac
index 279d488..2fdfbb6 100644
--- a/configure.ac
+++ b/configure.ac
@@ -581,14 +581,51 @@ if test "$ac_cv_sizeof__Float16" != 0; then
      test "X$ac_cv_have_decl_FLT16_MIN_10_EXP" = "Xyes" &&
      test "X$ac_cv_have_decl_FLT16_MAX_10_EXP" = "Xyes" &&
      test "X$ac_cv_have_decl_FLT16_MANT_DIG" = "Xyes" ; then
-    HAVE__FLOAT16="yes"
+    # Finally, some compilers like OneAPI on MSVC appear to just be broken,
+    # as support for _Float16 and its macros can be detected properly, but
+    # then code is generated that uses the __truncsfhf2, __truncdfhf2,
+    # __extendhfsf2 functions, which end up being unresolved with MSVC. Let's
+    # try to compile a program that will generate these functions as a last
+    # resort for checking for _Float16 support.
+    AC_MSG_CHECKING([if _Float16 program can be compiled])
+    AC_CACHE_VAL([hdf5_cv_float16_prog_compiled],
+      [AC_RUN_IFELSE(
+        [AC_LANG_PROGRAM([
+            #define __STDC_WANT_IEC_60559_TYPES_EXT__
+            #include <float.h>
+        ],[
+            signed char a;
+            _Float16    b;
+            double      c;
+            /* Convert signed char to _Float16  */
+            a = 1;
+            b = (_Float16)a;
+            /* Convert back */
+            b = 3.0f16;
+            a = (signed char)b;
+            /* Convert double to _Float16 */
+            c = 5.0;
+            b = (_Float16)c;
+            /* Convert back */
+            b = 3.0f16;
+            c = (double)b;
+        ])]
+      , [hdf5_cv_float16_prog_compiled=yes], [hdf5_cv_float16_prog_compiled=no], [hdf5_cv_float16_prog_compiled=no])])
 
-    # Check if we can use fabsf16
-    AC_CHECK_FUNC([fabsf16], [AC_DEFINE([HAVE_FABSF16], [1],
-                      [Define if has fabsf16 function])], [])
+    if test ${hdf5_cv_float16_prog_compiled} = "yes" ; then
+      AC_MSG_RESULT([yes])
+    
+      HAVE__FLOAT16="yes"
 
-    # Define HAVE__FLOAT16 macro for H5pubconf.h if _Float16 is available.
-    AC_DEFINE([HAVE__FLOAT16], [1], [Determine if _Float16 is available])
+      # Check if we can use fabsf16
+      AC_CHECK_FUNC([fabsf16], [AC_DEFINE([HAVE_FABSF16], [1],
+                        [Define if has fabsf16 function])], [])
+
+      # Define HAVE__FLOAT16 macro for H5pubconf.h if _Float16 is available.
+      AC_DEFINE([HAVE__FLOAT16], [1], [Determine if _Float16 is available])
+    else
+      AC_MSG_RESULT([no])
+    fi
   fi
 
   AC_MSG_CHECKING([if _Float16 support is available])
-- 
cgit v0.12