From 0731cf7e0e5134c2da969ce07ff00578c7dd4648 Mon Sep 17 00:00:00 2001
From: Allen Byrne <byrn@hdfgroup.org>
Date: Thu, 30 Jul 2020 14:53:08 -0500
Subject: More warnings reduction

---
 tools/lib/h5diff_array.c          | 1 -
 tools/src/misc/h5mkgrp.c          | 2 --
 tools/test/h5diff/h5diffgentest.c | 1 -
 tools/test/h5dump/h5dumpgentest.c | 1 -
 tools/test/h5jam/tellub.c         | 6 ++++--
 5 files changed, 4 insertions(+), 7 deletions(-)

diff --git a/tools/lib/h5diff_array.c b/tools/lib/h5diff_array.c
index cb35217..b4d4fa0 100644
--- a/tools/lib/h5diff_array.c
+++ b/tools/lib/h5diff_array.c
@@ -1203,7 +1203,6 @@ static hsize_t diff_region(hid_t obj1_id, hid_t obj2_id, hid_t region1_id, hid_t
                 /* print differences if found */
                 if (nfound_b && opts->mode_verbose) {
                     H5O_info_t oi1, oi2;
-                    char *obj1_str = NULL, *obj2_str = NULL;
 
                     H5Oget_info2(obj1_id, &oi1, H5O_INFO_BASIC);
                     H5Oget_info2(obj2_id, &oi2, H5O_INFO_BASIC);
diff --git a/tools/src/misc/h5mkgrp.c b/tools/src/misc/h5mkgrp.c
index 71db297..2b4d57f 100644
--- a/tools/src/misc/h5mkgrp.c
+++ b/tools/src/misc/h5mkgrp.c
@@ -123,8 +123,6 @@ parse_command_line(int argc, const char *argv[], mkgrp_opt_t *options)
 {
     int opt;            /* Option from command line */
     size_t curr_group;  /* Current group name to copy */
-    hbool_t custom_fapl = FALSE;
-    hid_t tmp_fapl_id = H5I_INVALID_HID;
 
     /* Check for empty command line */
     if(argc == 1) {
diff --git a/tools/test/h5diff/h5diffgentest.c b/tools/test/h5diff/h5diffgentest.c
index 935194c..7b407fd 100644
--- a/tools/test/h5diff/h5diffgentest.c
+++ b/tools/test/h5diff/h5diffgentest.c
@@ -8035,7 +8035,6 @@ void test_double_epsilon(const char *fname1, const char *fname2)
 {
     hid_t    fid1 = H5I_INVALID_HID, fid2 = H5I_INVALID_HID;
     hsize_t  dims1[2] = { 4, 7 };
-    hsize_t  dims2[2] = { 4, 7 };
     double   wdata[4][7];
     int i, j;
 
diff --git a/tools/test/h5dump/h5dumpgentest.c b/tools/test/h5dump/h5dumpgentest.c
index bce3493..411763b 100644
--- a/tools/test/h5dump/h5dumpgentest.c
+++ b/tools/test/h5dump/h5dumpgentest.c
@@ -3629,7 +3629,6 @@ gent_group_comments(void)
 {
     hid_t fid = H5I_INVALID_HID;
     hid_t group = H5I_INVALID_HID;
-    hbool_t supports_comments = FALSE;
 
     fid = H5Fcreate(FILE33, H5F_ACC_TRUNC, H5P_DEFAULT, H5P_DEFAULT);
 
diff --git a/tools/test/h5jam/tellub.c b/tools/test/h5jam/tellub.c
index 1cdd289..dbd2e69 100644
--- a/tools/test/h5jam/tellub.c
+++ b/tools/test/h5jam/tellub.c
@@ -71,6 +71,7 @@ parse_command_line (int argc, const char *argv[])
             case 'h':
                 usage (h5tools_getprogname());
                 h5tools_setstatus(EXIT_SUCCESS);
+                break;
             case '?':
             default:
                 usage (h5tools_getprogname());
@@ -105,7 +106,7 @@ int
 main (int argc, const char *argv[])
 {
     char *ifname;
-    hid_t ifile;
+    hid_t ifile = H5I_INVALID_HID;
     hsize_t usize;
     htri_t testval;
     herr_t status;
@@ -165,7 +166,8 @@ main (int argc, const char *argv[])
 
 done:
     H5Pclose (plist);
-    H5Fclose (ifile);
+    if(ifile >= 0)
+        H5Fclose (ifile);
 
     leave(h5tools_getstatus());
 } /* end main() */
-- 
cgit v0.12