From 50db5f95720e74339b230055558ec9591ee46a74 Mon Sep 17 00:00:00 2001 From: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Date: Mon, 13 Sep 2021 18:47:43 +0000 Subject: Committing clang-format changes --- src/H5Fvfd_swmr.c | 1 - test/vfd_swmr_gfail_writer.c | 42 +++++++++++++++++++++--------------------- 2 files changed, 21 insertions(+), 22 deletions(-) diff --git a/src/H5Fvfd_swmr.c b/src/H5Fvfd_swmr.c index 57c2ecd..69e03a0 100644 --- a/src/H5Fvfd_swmr.c +++ b/src/H5Fvfd_swmr.c @@ -1122,7 +1122,6 @@ H5F_vfd_swmr_reader_end_of_tick(H5F_t *f, hbool_t entering_api) #if 0 /*Kent*/ HDassert(oent->length == nent->length); #endif - /* the page has been altered -- evict it and * any contained metadata cache entries. diff --git a/test/vfd_swmr_gfail_writer.c b/test/vfd_swmr_gfail_writer.c index 4447343..8635cef 100644 --- a/test/vfd_swmr_gfail_writer.c +++ b/test/vfd_swmr_gfail_writer.c @@ -20,49 +20,49 @@ * 2) Create many groups * 3) Use the named pipe to send the reader a message to start verifying * 4) Call H5Fvfd_swmr_end_tick immeidately after sending out the message to the reader - * 5) Sleep for two ticks before receiving a message from the reader that informs the reader + * 5) Sleep for two ticks before receiving a message from the reader that informs the reader * started verifying * 6) If the option to delete the group is off(by default), just sleep for a relatively long time, - * then close the HDF5 file. + * then close the HDF5 file. * Else delete the last 1000 groups that are just created if the total number of * created groups is greater than 1000. - * Call H5Fvfd_swmr_end_tick sleep for a relatively long time, + * Call H5Fvfd_swmr_end_tick sleep for a relatively long time, * then close HDF5 file. * Reader: * 1) Open the HDF5 file * 2) Wait for the writer's message that informs the writer finished creating groups. * 3) After receiving the message from the writer, send a message back to the writer, * then call H5Literate to iterate through all the groups. The callback function just checks if - * the group name's prefix is valid. + * the group name's prefix is valid. * An #if 0 #endif block can help the user easily tune to check the iterated group names. - * 4) HDclock_gettime is used to check the total time of H5Literate call. + * 4) HDclock_gettime is used to check the total time of H5Literate call. * 5) Close the HDF5 file. * * The number of groups, the tick length, the max lag, the page buffer size, the page size and the - * sleep duration on the writer side before closing the file are configurable. + * sleep duration on the writer side before closing the file are configurable. * Users can also choose an option to delete 1000 groups after creating a larger number of groups.. * We only test to creat the groups with the latest file format. The option to create a * group via the earlies file format is still there. * * Issues and expected design fail * - * The parameter numbers that can reproduce the issues are tested at jelly. + * The parameter numbers that can reproduce the issues are tested at jelly. * To duplicate the issues at other machines, the number of groups to be created should be different. * * Issue 1: HDassert(oent->length == nent->length) error. * Need to UNCOMMENT out the HDassert(oent->length == nent->length) at ../src/H5Fvfd_swmr.c. * May also modify the group number a bit to see the assertion error. * - * GROUP_n=340000 + * GROUP_n=340000 * ./vfd_swmr_gfail_writer -q -n $GROUP_n & * ./vfd_swmr_gfail_reader -n $GROUP_n & * - * Issue 2: H5C__load_entry(): incorrect metadata checksum after all read attempts addr - * Sometimes the expected + * Issue 2: H5C__load_entry(): incorrect metadata checksum after all read attempts addr + * Sometimes the expected * "Reader's API time exceeds max_lag of ticks, may increase the value of max_lag." may appear * You may need to modify the group number a bit to see the unexpected error message. * - * GROUP_n=420000 + * GROUP_n=420000 * ./vfd_swmr_gfail_writer -q -n $GROUP_n & * ./vfd_swmr_gfail_reader -n $GROUP_n & * @@ -70,36 +70,36 @@ * This failure occurs when page size and page buffer size change from 4K to 8K. * This issue seems to be always repeatable with the following number of groups. * - * GROUP_n=320000 + * GROUP_n=320000 * ./vfd_swmr_gfail_writer -q -B 8192 -s 8192 -n $GROUP_n & * ./vfd_swmr_gfail_reader -B 8192 -s 8192 -n $GROUP_n & * Issue 4: not enough space to copy index * To duplicate this failure, the number of groups should be much larger, 2 millions. - * The max_lag and tick_len should also be set to big numbers. + * The max_lag and tick_len should also be set to big numbers. * This issue seems to be always repeatable with the following number of groups. * - * GROUP_n=2000000 + * GROUP_n=2000000 * ./vfd_swmr_gfail_writer -q -m 40 -t 10 -n $GROUP_n & * ./vfd_swmr_gfail_reader -m 40 -t 10 -n $GROUP_n & * Expected design fail * * Writer creates a large number of groups, then deletes the last 1000 groups, - * With the following settings, the expected + * With the following settings, the expected * "Reader's API time exceeds max_lag of ticks, may increase the value of max_lag." - * should appear. If not, increases the GROUP_n. + * should appear. If not, increases the GROUP_n. * - * GROUP_n=320000 + * GROUP_n=320000 * ./vfd_swmr_gfail_writer -q -d -n $GROUP_n & * ./vfd_swmr_gfail_reader -n $GROUP_n & * - * When increasing the max_lag, we may see the program run normally since + * When increasing the max_lag, we may see the program run normally since * the reader can finish iterating all the groups within the max_lag of ticks. * The following program should end normally. If not, increase the max_lag. * ./vfd_swmr_gfail_writer -m 9 -q -d -n $GROUP_n & * ./vfd_swmr_gfail_reader -m 9 -n $GROUP_n & - + */ #define H5F_FRIEND /*suppress error about including H5Fpkg */ @@ -652,11 +652,11 @@ main(int argc, char **argv) decisleep(s.w_sleep_len); } else { /*Reader */ - if(s.use_named_pipes) { + if (s.use_named_pipes) { if (false == np_rd_receive(&s)) { TEST_ERROR; } - + dbgf(2, "reader receives the message.\n"); if (np_rd_send(&s) == false) { TEST_ERROR; -- cgit v0.12