From e0c21e2f8feb0fe5b95bd0c38524ded125ecb17d Mon Sep 17 00:00:00 2001 From: jhendersonHDF Date: Wed, 29 Mar 2023 09:36:34 -0500 Subject: Fix a memory corruption issue in H5S__point_project_simple (#2626) (#2630) --- release_docs/RELEASE.txt | 14 ++++++++++++++ src/H5Spoint.c | 2 +- 2 files changed, 15 insertions(+), 1 deletion(-) diff --git a/release_docs/RELEASE.txt b/release_docs/RELEASE.txt index 05160fa..40cf0b2 100644 --- a/release_docs/RELEASE.txt +++ b/release_docs/RELEASE.txt @@ -205,6 +205,20 @@ Bug Fixes since HDF5-1.12.1 release =================================== Library ------- + - Fixed a memory corruption issue that can occur when reading + from a dataset using a hyperslab selection in the file + dataspace and a point selection in the memory dataspace + + When reading from a dataset using a hyperslab selection in + the dataset's file dataspace and a point selection in the + dataset's memory dataspace where the file dataspace's "rank" + is greater than the memory dataspace's "rank", memory corruption + could occur due to an incorrect number of selection points + being copied when projecting the point selection onto the + hyperslab selection's dataspace. + + (JTH - 2023/03/23) + - Seg fault on file close h5debug fails at file close with core dump on a file that has an diff --git a/src/H5Spoint.c b/src/H5Spoint.c index 3e85aff..22feaf8 100644 --- a/src/H5Spoint.c +++ b/src/H5Spoint.c @@ -2316,7 +2316,7 @@ H5S__point_project_simple(const H5S_t *base_space, H5S_t *new_space, hsize_t *of /* Copy over the point's coordinates */ HDmemset(new_node->pnt, 0, sizeof(hsize_t) * rank_diff); H5MM_memcpy(&new_node->pnt[rank_diff], base_node->pnt, - (new_space->extent.rank * sizeof(hsize_t))); + (base_space->extent.rank * sizeof(hsize_t))); /* Keep the order the same when copying */ if (NULL == prev_node) -- cgit v0.12