From e3c98c2899039b0a3e49205bad3a84ebbfacdff4 Mon Sep 17 00:00:00 2001 From: Albert Cheng Date: Wed, 5 Dec 2001 12:18:34 -0500 Subject: [svn-r4672] Purpose: Bug fix Description: Snapshot does "make check" directly, instead of building all binary first. This means it does not cover code that are not tested (e.g., example, perform). (That explained why the errors in the PIO performance code were not reported in daily test but blew up when people built the library the "normal" way.) It is done this way so that the snaptest aborts as soon as the first test failed rather than after all code are compiled. Solution: Add "make" (to build all binary) before "make check". The allows snaptest to fail as soon as the first compiling failure. If we wish the snaptest to abort on the first test failure, the two can be swapped as "make check && make ...". (It would appear strange to run tests then make binary.) Platforms tested: Would be tested in the daily test tonight. (I should have tested it first but I started this commit process already. Sorry.) --- bin/snapshot | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/bin/snapshot b/bin/snapshot index 4a5d668..520724e 100755 --- a/bin/snapshot +++ b/bin/snapshot @@ -256,10 +256,11 @@ if [ "$cmd" = "all" -o -n "$cmdtest" ]; then fi fi - # Make sure all the serial tests work. + # Build, run tests and install procedures if [ "$snapshot" = "yes" ]; then if (cd ${TESTDIR} && \ ${srcdir:+${CURRENT}/}${CONFIGURE} --prefix=$INSTALLDIR && \ + ${MAKE} && \ ${MAKE} check && \ ${MAKE} install install-doc && \ ${MAKE} uninstall uninstall-doc); then -- cgit v0.12