From 715ae9c86529d2db78eeaa82097e95cf65f6512a Mon Sep 17 00:00:00 2001 From: Allen Byrne Date: Tue, 22 May 2018 10:43:01 -0500 Subject: Correct attribute location --- config/cmake/ConversionTests.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/config/cmake/ConversionTests.c b/config/cmake/ConversionTests.c index 002bc88..321d879 100644 --- a/config/cmake/ConversionTests.c +++ b/config/cmake/ConversionTests.c @@ -25,7 +25,7 @@ #include #include -int main(void) HDF_NO_UBSAN +int HDF_NO_UBSAN main(void) { long double ld = 20041683600089727.779961L; long ll; @@ -86,7 +86,7 @@ done: #include #include -int main(void) HDF_NO_UBSAN +int HDF_NO_UBSAN main(void) { long double ld; long ll; @@ -149,7 +149,7 @@ done: #include #include -int main(void) HDF_NO_UBSAN +int HDF_NO_UBSAN main(void) { long double ld = 20041683600089727.779961L; long long ll; @@ -192,7 +192,7 @@ done: #include #include -int main(void) HDF_NO_UBSAN +int HDF_NO_UBSAN main(void) { long double ld; long long ll; @@ -253,8 +253,8 @@ int FC_DUMMY_MAIN() { return 1;} #endif #endif -int -main () HDF_NO_UBSAN +int HDF_NO_UBSAN +main () { char *chp = "beefs"; -- cgit v0.12 From 11689d9873fbf013001d0b3bb4bda97420d3cf70 Mon Sep 17 00:00:00 2001 From: Allen Byrne Date: Tue, 22 May 2018 11:02:43 -0500 Subject: Add release note --- release_docs/RELEASE.txt | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/release_docs/RELEASE.txt b/release_docs/RELEASE.txt index 1c5ca46..8a9828f 100644 --- a/release_docs/RELEASE.txt +++ b/release_docs/RELEASE.txt @@ -121,7 +121,16 @@ Bug Fixes since HDF5-1.10.2 release Configuration ------------- - Reworked java test suite into individual JUnit tests. + - Moved the location of gcc attribute. + + The gcc attribute(no_sanitize), named as the macro HDF_NO_UBSAN, + was located after the function name. Builds with GCC 7 did not + indicate any problem, but GCC 8 issied errors. Moved the + attribute before the function name, as required. + + (ADB 2018/05/22, HDFFV-10473) + + - Reworked java test suite into individual JUnit tests. Testing the whole suite of java unit tests in a single JUnit run made it difficult to determine actual failures when tests would fail. -- cgit v0.12 From 78e1372ad5e35fc3ef691767148f7d2eea2feea4 Mon Sep 17 00:00:00 2001 From: Allen Byrne Date: Tue, 22 May 2018 11:03:04 -0500 Subject: fix typo --- release_docs/RELEASE.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/release_docs/RELEASE.txt b/release_docs/RELEASE.txt index 8a9828f..0a1b892 100644 --- a/release_docs/RELEASE.txt +++ b/release_docs/RELEASE.txt @@ -125,7 +125,7 @@ Bug Fixes since HDF5-1.10.2 release The gcc attribute(no_sanitize), named as the macro HDF_NO_UBSAN, was located after the function name. Builds with GCC 7 did not - indicate any problem, but GCC 8 issied errors. Moved the + indicate any problem, but GCC 8 issued errors. Moved the attribute before the function name, as required. (ADB 2018/05/22, HDFFV-10473) -- cgit v0.12