From 6a93d1f834184853913d43e50fda5b350fa1dc38 Mon Sep 17 00:00:00 2001
From: Jacob Smith <jake.smith@hdfgroup.org>
Date: Fri, 7 Feb 2020 13:47:15 -0600
Subject: Fix improper S3 signing key null check (HDFFV-11015).

---
 src/H5FDs3comms.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/H5FDs3comms.c b/src/H5FDs3comms.c
index f08e9d5..d9d4c88 100644
--- a/src/H5FDs3comms.c
+++ b/src/H5FDs3comms.c
@@ -1202,7 +1202,7 @@ H5FD_s3comms_s3r_open(const char          *url,
 
     if ((region      != NULL && *region      != '\0') ||
         (id          != NULL && *id          != '\0') ||
-        (signing_key != NULL && *signing_key != '\0'))
+        (signing_key != NULL))
     {
         /* if one exists, all three must exist
          */
@@ -1214,7 +1214,7 @@ H5FD_s3comms_s3r_open(const char          *url,
             HGOTO_ERROR(H5E_ARGS, H5E_BADVALUE, NULL,
                         "secret id cannot be null.\n");
         }
-        if (signing_key == NULL || signing_key[0] == '\0') {
+        if (signing_key == NULL) {
             HGOTO_ERROR(H5E_ARGS, H5E_BADVALUE, NULL,
                         "signing key cannot be null.\n");
         }
-- 
cgit v0.12