From 5bace59b991b704225f4338e70b79abaa57cf836 Mon Sep 17 00:00:00 2001 From: Quincey Koziol Date: Tue, 6 Apr 2004 11:38:00 -0500 Subject: [svn-r8307] Purpose: Code optimization Description: Fix H5S_select_copy so it doesn't call calloc() for allocating memory that will be immediately overwritten. Platforms tested: Solaris 2.7 (arabica) too small to require h5committest --- src/H5Sselect.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/H5Sselect.c b/src/H5Sselect.c index 7a758fc..9156971 100644 --- a/src/H5Sselect.c +++ b/src/H5Sselect.c @@ -139,9 +139,11 @@ H5S_select_copy (H5S_t *dst, const H5S_t *src) /* Copy offset information */ if(src->extent.u.simple.rank>0) { - if (NULL==(dst->select.offset = H5FL_ARR_CALLOC(hssize_t,src->extent.u.simple.rank))) + if (NULL==(dst->select.offset = H5FL_ARR_MALLOC(hssize_t,src->extent.u.simple.rank))) HGOTO_ERROR (H5E_RESOURCE, H5E_NOSPACE, FAIL, "memory allocation failed"); - if(src->select.offset!=NULL) + if(src->select.offset==NULL) + HDmemset(dst->select.offset,0,(src->extent.u.simple.rank*sizeof(hssize_t))); + else HDmemcpy(dst->select.offset,src->select.offset,(src->extent.u.simple.rank*sizeof(hssize_t))); } /* end if */ else -- cgit v0.12