From 4d245ec8566f7bd91ff48caec6ff86bea3cebf78 Mon Sep 17 00:00:00 2001 From: Quincey Koziol Date: Mon, 11 Jun 2001 17:35:08 -0500 Subject: [svn-r3993] Purpose: Bug fix for Pablo integration Description: Several API functions were using FUNC_ENTER, without using FUNC_LEAVE, HRETURN or HRETURN_ERROR to leave the function. (Using "plain" 'return' statements instead). Solution: Changed return statements to FUNC_LEAVE, HRETURN or HRETURN_ERROR, as appropriate. Platforms tested: FreeBSD 4.3 (hawkwind) --- src/H5FD.c | 16 ++++++++-------- src/H5FL.c | 3 ++- src/H5P.c | 2 +- 3 files changed, 11 insertions(+), 10 deletions(-) diff --git a/src/H5FD.c b/src/H5FD.c index 5fc0c02..9dbdfcb 100644 --- a/src/H5FD.c +++ b/src/H5FD.c @@ -983,17 +983,17 @@ H5FD_cmp(const H5FD_t *f1, const H5FD_t *f2) FUNC_ENTER(H5FD_cmp, -1); /*return value is arbitrary*/ - if ((!f1 || !f1->cls) && (!f2 || !f2->cls)) return 0; - if (!f1 || !f1->cls) return -1; - if (!f2 || !f2->cls) return 1; - if (f1->cls < f2->cls) return -1; - if (f1->cls > f2->cls) return 1; + if ((!f1 || !f1->cls) && (!f2 || !f2->cls)) HRETURN(0); + if (!f1 || !f1->cls) HRETURN(-1); + if (!f2 || !f2->cls) HRETURN(1); + if (f1->cls < f2->cls) HRETURN(-1); + if (f1->cls > f2->cls) HRETURN(1); /* Files are same driver; no cmp callback */ if (!f1->cls->cmp) { - if (f1f2) return 1; - return 0; + if (f1f2) HRETURN(1); + HRETURN(0); } ret_value = (f1->cls->cmp)(f1, f2); diff --git a/src/H5FL.c b/src/H5FL.c index e5c104b..1b1cae5 100644 --- a/src/H5FL.c +++ b/src/H5FL.c @@ -1132,7 +1132,8 @@ H5FL_arr_free(H5FL_arr_head_t *head, void *obj) H5MM_xfree(obj); #else /* NO_ARR_FREE_LISTS */ /* The H5MM_xfree code allows obj to null */ - if (!obj) return (NULL); + if (!obj) + HRETURN (NULL); /* Double check parameters */ assert(head); diff --git a/src/H5P.c b/src/H5P.c index 442f40c..28544a3 100644 --- a/src/H5P.c +++ b/src/H5P.c @@ -631,7 +631,7 @@ H5Pcopy(hid_t plist_id) H5TRACE1("i","i",plist_id); if (H5P_DEFAULT==plist_id) - return H5P_DEFAULT; + HRETURN(H5P_DEFAULT); /* Check args */ if (NULL == (plist = H5I_object(plist_id)) || -- cgit v0.12