From 54f02fdaf2e449834f48817a15c8b8a0aa8eed1f Mon Sep 17 00:00:00 2001 From: MuQun Yang Date: Wed, 22 Mar 2006 21:20:12 -0500 Subject: [svn-r12139] Purpose: portibility issue to windows Description: setvbuf on visual studio 2005 needs the size to be greater or equal to 2. Buffer size in bytes. Allowable range: 2 <= size <= INT_MAX (2147483647). Internally, the value supplied for size is rounded down to the nearest multiple of 2. h5import used linebuffer option of setvbuf for stderr and stdout and the size is 0 by default. This causes core dump with visual 2005 on windows 64-bit. Solution: 1. Use HDsetvbuf inside h5import.c, 2. Define HDsetvbuf inside windows H5pubconf.h for windows to work around the core dump of h5import test. This is probably a bug inside visual studio 2005. Platforms tested: h5committest windows 6.0 at XP visual 2005 at XP-64bit Misc. update: --- src/H5private.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/H5private.h b/src/H5private.h index cf16bce..263b529 100644 --- a/src/H5private.h +++ b/src/H5private.h @@ -806,7 +806,9 @@ int HDremove_all(char * fname); #define HDsetpgid(P,PG) setpgid(P,PG) #define HDsetsid() setsid() #define HDsetuid(U) setuid(U) +#ifndef WIN32 #define HDsetvbuf(F,S,M,Z) setvbuf(F,S,M,Z) +#endif #define HDsigaction(N,A) sigaction(N,A) #define HDsigaddset(S,N) sigaddset(S,N) #define HDsigdelset(S,N) sigdelset(S,N) -- cgit v0.12