From d1dd4a424685200b382185736e3435a6ae8e5505 Mon Sep 17 00:00:00 2001 From: Larry Knox Date: Fri, 15 Oct 2021 16:45:50 -0500 Subject: Fixed HDFFV-11150 (#356) (#1104) * Fixed HDFFV-11150 (#356) Description Replaced an HDassert with a check for null pointer in H5O_dec_rc() to catch null pointer in corrupted data situation. As a result, removed the null check prior to H5O_dec_rc() calls. Platforms tested: Linux/64 (jelly) * Add release note for HDFFV-11150 fix. Co-authored-by: bmribler <39579120+bmribler@users.noreply.github.com> --- release_docs/RELEASE.txt | 8 ++++++++ src/H5Ochunk.c | 4 ++-- src/H5Oint.c | 3 ++- 3 files changed, 12 insertions(+), 3 deletions(-) diff --git a/release_docs/RELEASE.txt b/release_docs/RELEASE.txt index a14b738..1ce3ec4 100644 --- a/release_docs/RELEASE.txt +++ b/release_docs/RELEASE.txt @@ -209,6 +209,14 @@ Bug Fixes since HDF5-1.12.1 release =================================== Library ------- + - Fixed a segmentation fault + + A segmentation fault occurred with a Mathworks corrupted file. + + A detection of accessing a null pointer was added to prevent the problem. + + (BMR - 2021/10/14, HDFFV-11150) + - Detection of simple data transform function "x" In the case of the simple data transform function "x" the (parallel) diff --git a/src/H5Ochunk.c b/src/H5Ochunk.c index 66e11c8..eadbb19 100644 --- a/src/H5Ochunk.c +++ b/src/H5Ochunk.c @@ -412,12 +412,12 @@ H5O__chunk_dest(H5O_chunk_proxy_t *chk_proxy) HDassert(chk_proxy); /* Decrement reference count of object header */ - if (chk_proxy->oh && H5O__dec_rc(chk_proxy->oh) < 0) + if (H5O__dec_rc(chk_proxy->oh) < 0) HGOTO_ERROR(H5E_OHDR, H5E_CANTDEC, FAIL, "can't decrement reference count on object header") +done: /* Release the chunk proxy object */ chk_proxy = H5FL_FREE(H5O_chunk_proxy_t, chk_proxy); -done: FUNC_LEAVE_NOAPI(ret_value) } /* H5O__chunk_dest() */ diff --git a/src/H5Oint.c b/src/H5Oint.c index 18b2db0..ad5b7b7 100644 --- a/src/H5Oint.c +++ b/src/H5Oint.c @@ -2925,7 +2925,8 @@ H5O__dec_rc(H5O_t *oh) FUNC_ENTER_PACKAGE /* check args */ - HDassert(oh); + if (!oh) + HGOTO_ERROR(H5E_ARGS, H5E_BADVALUE, FAIL, "invalid object header") /* Decrement reference count */ oh->rc--; -- cgit v0.12