From de2440ae5f5227a8f513c4fef4c963990d6bb90f Mon Sep 17 00:00:00 2001 From: Dana Robinson Date: Thu, 27 Jun 2019 22:38:20 -0700 Subject: Warning fixes: * fix for static/const flipped in H5Dint.c * Removed missing done target in H5Rint.c * Fixed misleading indentation in h5format_convert.c --- src/H5Dint.c | 4 ++-- src/H5Rint.c | 3 +-- tools/src/h5format_convert/h5format_convert.c | 10 ++++++---- 3 files changed, 9 insertions(+), 8 deletions(-) diff --git a/src/H5Dint.c b/src/H5Dint.c index cd120d0..b517f8b 100644 --- a/src/H5Dint.c +++ b/src/H5Dint.c @@ -114,8 +114,8 @@ static hbool_t H5D_top_package_initialize_s = FALSE; /* Prefixes of VDS and external file from the environment variables * HDF5_EXTFILE_PREFIX and HDF5_VDS_PREFIX */ -const static char *H5D_prefix_ext_env = NULL; -const static char *H5D_prefix_vds_env = NULL; +static const char *H5D_prefix_ext_env = NULL; +static const char *H5D_prefix_vds_env = NULL; /*------------------------------------------------------------------------- diff --git a/src/H5Rint.c b/src/H5Rint.c index 8109ac0..2355ec1 100644 --- a/src/H5Rint.c +++ b/src/H5Rint.c @@ -84,12 +84,11 @@ H5R__init_package(void) { herr_t ret_value = SUCCEED; /* Return value */ - FUNC_ENTER_NOAPI_NOINIT + FUNC_ENTER_NOAPI_NOINIT_NOERR /* Mark "top" of interface as initialized */ H5R_top_package_initialize_s = TRUE; -done: FUNC_LEAVE_NOAPI(ret_value) } /* end H5R__init_package() */ diff --git a/tools/src/h5format_convert/h5format_convert.c b/tools/src/h5format_convert/h5format_convert.c index b9ed9ce..5fb02f4 100644 --- a/tools/src/h5format_convert/h5format_convert.c +++ b/tools/src/h5format_convert/h5format_convert.c @@ -260,8 +260,9 @@ convert(hid_t fid, const char *dname) h5tools_setstatus(EXIT_FAILURE); goto error; } - else if(verbose_g) + else if(verbose_g) { HDfprintf(stdout, "Retrieve the dataset's chunk indexing type\n"); + } if(idx_type == H5D_CHUNK_IDX_BTREE) { if(verbose_g) @@ -269,8 +270,9 @@ convert(hid_t fid, const char *dname) h5tools_setstatus(EXIT_SUCCESS); goto done; } - else if (verbose_g) + else if(verbose_g) { HDfprintf(stdout, "Dataset's chunk indexing type is not version 1 B-tree\n"); + } break; @@ -302,8 +304,8 @@ convert(hid_t fid, const char *dname) if(noop_g) { if(verbose_g) HDfprintf(stdout, "Not converting the dataset\n"); - h5tools_setstatus(EXIT_SUCCESS); - goto done; + h5tools_setstatus(EXIT_SUCCESS); + goto done; } if(verbose_g) -- cgit v0.12