From 2a492f23a1bfc25169dc6f063afaf6dd20d0e749 Mon Sep 17 00:00:00 2001 From: Allen Byrne Date: Wed, 9 Mar 2011 10:49:46 -0500 Subject: [svn-r20211] Valgrind indicated error in writing past buffer. Contary to ref man H5O_get_comment does not return null char in size. Tested: local linux and valgrind --- tools/h5dump/h5dump.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/h5dump/h5dump.c b/tools/h5dump/h5dump.c index 81a6793..bebc892 100644 --- a/tools/h5dump/h5dump.c +++ b/tools/h5dump/h5dump.c @@ -2660,7 +2660,7 @@ dump_comment(hid_t obj_id) /* call H5Oget_comment again with the correct value. * If the call to H5Oget_comment returned an error, skip this block */ if (cmt_bufsize > 0) { - comment = (char *)HDmalloc((size_t)cmt_bufsize); /* new_size including null terminator */ + comment = (char *)HDmalloc((size_t)(cmt_bufsize+1)); /* new_size including null terminator */ if(comment) { cmt_bufsize = H5Oget_comment(obj_id, comment, cmt_bufsize); if(cmt_bufsize > 0) { -- cgit v0.12