From 005c6a91557a576cdb23bcdde623dda9076861ef Mon Sep 17 00:00:00 2001 From: Jonathan Kim Date: Fri, 13 May 2011 10:02:26 -0500 Subject: [svn-r20811] Purpose: HDFFV-7594 - GMQS: h5dump shows wrong values for H5T_STD_I8LE dataset on Blue-gene (ppc64 linux BE +@) Description: Merged from HDF5 trunk r20804. For the STD_I8 type data, updated to use 'signed char' instead of 'char' as 'char' could be defined as unsigned on a certain system, which cause h5dump to display data values incorrectly. Tested: jam (linux32-LE), koala (linux64-LE), heiwa (linuxppc64-BE), tejeda (mac32-LE), cmake --- release_docs/RELEASE.txt | 3 +++ tools/lib/h5tools_str.c | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/release_docs/RELEASE.txt b/release_docs/RELEASE.txt index be55c5f..ba2d3d7 100644 --- a/release_docs/RELEASE.txt +++ b/release_docs/RELEASE.txt @@ -105,6 +105,9 @@ Bug Fixes since HDF5-1.8.7 Tools ----- + - Fixed h5dump to display correct value for H5T_STD_I8LE dataset + on a system (ppc64, linux, Big-Endian, clustering). + Bug #HDFFV-7594 (ABERT & JKM 05/12/2011) - Fixed h5diff to compare file itself correctly. Previously h5diff reported either different or not compatible in certain cases even comparing file itself. This fix also improve performance when diff --git a/tools/lib/h5tools_str.c b/tools/lib/h5tools_str.c index 54e2584..af3f7e7 100644 --- a/tools/lib/h5tools_str.c +++ b/tools/lib/h5tools_str.c @@ -814,7 +814,7 @@ h5tools_str_sprint(h5tools_str_t *str, const h5tool_format_t *info, hid_t contai h5tools_str_append(str, OPT(info->fmt_uint, "%u"), tempuint); } else if (H5Tequal(type, H5T_NATIVE_SCHAR)) { - char tempchar; + signed char tempchar; HDmemcpy(&tempchar, cp_vp, sizeof(char)); if(packed_bits_num) { tempchar = (tempchar >> packed_data_offset) & packed_data_mask; -- cgit v0.12