summaryrefslogtreecommitdiffstats
path: root/test/ohdr.c
blob: dc0497f7655985ca35a5e924115604cdf0c0d3c0 (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
1169
1170
1171
1172
1173
1174
1175
1176
1177
1178
1179
1180
1181
1182
1183
1184
1185
1186
1187
1188
1189
1190
1191
1192
1193
1194
1195
1196
1197
1198
1199
1200
1201
1202
1203
1204
1205
1206
1207
1208
1209
1210
1211
1212
1213
1214
1215
1216
1217
1218
1219
1220
1221
1222
1223
1224
1225
1226
1227
1228
1229
1230
1231
1232
1233
1234
1235
1236
1237
1238
1239
1240
1241
1242
1243
1244
1245
1246
1247
1248
1249
1250
1251
1252
1253
1254
1255
1256
1257
1258
1259
1260
1261
1262
1263
1264
1265
1266
1267
1268
1269
1270
1271
1272
1273
1274
1275
1276
1277
1278
1279
1280
1281
1282
1283
1284
1285
1286
1287
1288
1289
1290
1291
1292
1293
1294
1295
1296
1297
1298
1299
1300
1301
1302
1303
1304
1305
1306
1307
1308
1309
1310
1311
1312
1313
1314
1315
1316
1317
1318
1319
1320
1321
1322
1323
1324
1325
1326
1327
1328
1329
1330
1331
1332
1333
1334
1335
1336
1337
1338
1339
1340
1341
1342
1343
1344
1345
1346
1347
1348
1349
1350
1351
1352
1353
1354
1355
1356
1357
1358
1359
1360
1361
1362
1363
1364
1365
1366
1367
1368
1369
1370
1371
1372
1373
1374
1375
1376
1377
1378
1379
1380
1381
1382
1383
1384
1385
1386
1387
1388
1389
1390
1391
1392
1393
1394
1395
1396
1397
1398
1399
1400
1401
1402
1403
1404
1405
1406
1407
1408
1409
1410
1411
1412
1413
1414
1415
1416
1417
1418
1419
1420
1421
1422
1423
1424
1425
1426
1427
1428
1429
1430
1431
1432
1433
1434
1435
1436
1437
1438
1439
1440
1441
1442
1443
1444
1445
1446
1447
1448
1449
1450
1451
1452
1453
1454
1455
1456
1457
1458
1459
1460
1461
1462
1463
1464
1465
1466
1467
1468
1469
1470
1471
1472
1473
1474
1475
1476
1477
1478
1479
1480
1481
1482
1483
1484
1485
1486
1487
1488
1489
1490
1491
1492
1493
1494
1495
1496
1497
1498
1499
1500
1501
1502
1503
1504
1505
1506
1507
1508
1509
1510
1511
1512
1513
1514
1515
1516
1517
1518
1519
1520
1521
1522
1523
1524
1525
1526
1527
1528
1529
1530
1531
1532
1533
1534
1535
1536
1537
1538
1539
1540
1541
1542
1543
1544
1545
1546
1547
1548
1549
1550
1551
1552
1553
1554
1555
1556
1557
1558
1559
1560
1561
1562
1563
1564
1565
1566
1567
1568
1569
1570
1571
1572
1573
1574
1575
1576
1577
1578
1579
1580
1581
1582
1583
1584
1585
1586
1587
1588
1589
1590
1591
1592
1593
1594
1595
1596
1597
1598
1599
1600
1601
1602
1603
1604
1605
1606
1607
1608
1609
1610
1611
1612
1613
1614
1615
1616
1617
1618
1619
1620
1621
1622
1623
1624
1625
1626
1627
1628
1629
1630
1631
1632
1633
1634
1635
1636
1637
1638
1639
1640
1641
1642
1643
1644
1645
1646
1647
1648
1649
1650
1651
1652
1653
1654
1655
1656
1657
1658
1659
1660
1661
1662
1663
1664
1665
1666
1667
1668
1669
1670
1671
1672
1673
1674
1675
1676
1677
1678
1679
1680
1681
1682
1683
1684
1685
1686
1687
1688
1689
1690
1691
1692
1693
1694
1695
1696
1697
1698
1699
1700
1701
1702
1703
1704
1705
1706
1707
1708
1709
1710
1711
1712
1713
1714
1715
1716
1717
1718
1719
1720
1721
1722
1723
1724
1725
1726
1727
1728
1729
1730
1731
1732
1733
1734
1735
1736
1737
1738
1739
1740
1741
1742
1743
1744
1745
1746
1747
1748
1749
1750
1751
1752
1753
1754
1755
1756
1757
1758
1759
1760
1761
1762
1763
1764
1765
1766
1767
1768
1769
1770
1771
1772
1773
1774
1775
1776
1777
1778
1779
1780
1781
1782
1783
1784
1785
1786
1787
1788
1789
1790
1791
1792
1793
1794
1795
1796
1797
1798
1799
1800
1801
1802
1803
1804
1805
1806
1807
1808
1809
1810
1811
1812
1813
1814
1815
1816
1817
1818
1819
1820
1821
1822
1823
1824
1825
1826
1827
1828
1829
1830
1831
1832
1833
1834
1835
1836
1837
1838
1839
1840
1841
1842
1843
1844
1845
1846
1847
1848
1849
1850
1851
1852
1853
1854
1855
1856
1857
1858
1859
1860
1861
1862
1863
1864
1865
1866
1867
1868
1869
1870
1871
1872
1873
1874
1875
1876
1877
1878
1879
1880
1881
1882
1883
1884
1885
1886
1887
1888
1889
1890
1891
1892
1893
1894
1895
1896
1897
1898
1899
1900
1901
1902
1903
1904
1905
1906
1907
1908
1909
1910
1911
1912
1913
1914
1915
1916
1917
1918
1919
1920
1921
1922
1923
1924
1925
1926
1927
1928
1929
1930
1931
1932
1933
1934
1935
1936
1937
1938
1939
1940
1941
1942
1943
1944
1945
1946
1947
1948
1949
1950
1951
1952
1953
1954
1955
1956
1957
1958
1959
1960
1961
1962
1963
1964
1965
1966
1967
1968
1969
1970
1971
1972
1973
1974
1975
1976
1977
1978
1979
1980
1981
1982
1983
1984
1985
1986
1987
1988
1989
1990
1991
1992
1993
1994
1995
1996
1997
1998
1999
2000
2001
2002
2003
2004
2005
2006
2007
2008
2009
2010
2011
2012
2013
2014
2015
2016
2017
2018
2019
2020
2021
2022
2023
2024
2025
2026
2027
2028
2029
2030
2031
2032
2033
2034
2035
2036
2037
2038
2039
2040
2041
2042
2043
2044
2045
2046
2047
2048
2049
2050
2051
2052
2053
2054
2055
2056
2057
2058
2059
2060
2061
2062
2063
2064
2065
2066
2067
2068
2069
2070
2071
2072
2073
2074
2075
2076
2077
2078
2079
2080
2081
2082
2083
2084
2085
2086
2087
2088
2089
2090
2091
2092
2093
2094
2095
2096
2097
2098
2099
2100
2101
2102
2103
2104
2105
2106
2107
2108
2109
2110
2111
2112
2113
2114
2115
2116
2117
2118
2119
2120
2121
2122
2123
2124
2125
2126
2127
2128
2129
2130
2131
2132
2133
2134
2135
2136
2137
2138
2139
2140
2141
2142
2143
2144
2145
2146
2147
2148
2149
2150
2151
2152
2153
2154
2155
2156
2157
2158
2159
2160
2161
2162
2163
2164
2165
2166
2167
2168
2169
2170
2171
2172
2173
/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * *
 * Copyright by The HDF Group.                                               *
 * Copyright by the Board of Trustees of the University of Illinois.         *
 * All rights reserved.                                                      *
 *                                                                           *
 * This file is part of HDF5.  The full HDF5 copyright notice, including     *
 * terms governing use, modification, and redistribution, is contained in    *
 * the COPYING file, which can be found at the root of the source code       *
 * distribution tree, or in https://www.hdfgroup.org/licenses.               *
 * If you do not have access to either file, you may request a copy from     *
 * help@hdfgroup.org.                                                        *
 * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */

/* Programmer:  Robb Matzke
 *              Tuesday, November 24, 1998
 */
#include "h5test.h"

#include "H5CXprivate.h" /* API Contexts                             */
#include "H5Iprivate.h"  /* Identifiers                              */
#include "H5VLprivate.h" /* Virtual Object Layer                     */

/*
 * This file needs to access private datatypes from the H5O package.
 * This file also needs to access the object header testing code.
 */
#define H5O_FRIEND /* suppress error about including H5Opkg */
#define H5O_TESTING
#include "H5Opkg.h"

/*
 * This file needs to access private datatypes from the H5G package.
 */
#define H5G_FRIEND /* suppress error about including H5Gpkg */
#include "H5Gpkg.h"

/*
 * This file needs to access private routines from the H5FD package.
 */
#define H5FD_FRIEND /* suppress error about including H5FDpkg */
#define H5FD_TESTING
#include "H5FDpkg.h"

const char *FILENAME[] = {"ohdr", "ohdr_min_a", "ohdr_min_b", NULL};

/* used for object header size comparison */
#define EQ 1
#define LT 2
#define GT 3

/* The tbogus.h5 is generated from gen_bogus.c in HDF5 'test' directory.
 * To get this data file, define H5O_ENABLE_BOGUS in src/H5Oprivate, rebuild
 * the library and simply compile gen_bogus.c with that HDF5 library and run it.
 */
#define FILE_BOGUS   "tbogus.h5"
#define TESTFILE_LEN 256

/*  */
#define FILE_OHDR_SWMR     "ohdr_swmr.h5"
#define DSET_NAME          "COMPACT_DSET"
#define OBJ_VERSION_LATEST 2

/*
 *  Verify that messages are moved forward into a "continuation message":
 *    Create an object header with several continuation chunks
 *    Remove a message in the last chunk
 *    The remaining message(s) in the last chunk should be moved forward into the continuation message
 *    The process will repeat when the continuation message is big enough to hold all the
 *        messages in the last chunk.
 *    Result: the number of chunks should be reduced
 */
static herr_t
test_cont(char *filename, hid_t fapl)
{
    hid_t          file = -1;
    H5F_t *        f    = NULL;
    H5O_hdr_info_t hdr_info;
    H5O_loc_t      oh_locA, oh_locB;
    time_t         time_new;
    const char *   short_name = "T";
    const char *   long_name  = "This is the message";
    size_t         nchunks;

    TESTING("object header continuation block");

    HDmemset(&oh_locA, 0, sizeof(oh_locA));
    HDmemset(&oh_locB, 0, sizeof(oh_locB));

    /* Create the file to operate on */
    if ((file = H5Fcreate(filename, H5F_ACC_TRUNC, H5P_DEFAULT, fapl)) < 0)
        FAIL_STACK_ERROR;
    if (NULL == (f = (H5F_t *)H5VL_object(file)))
        FAIL_STACK_ERROR;
    if (H5AC_ignore_tags(f) < 0) {
        H5_FAILED();
        H5Eprint2(H5E_DEFAULT, stdout);
        goto error;
    } /* end if */

    if (H5O_create(f, (size_t)H5O_MIN_SIZE, (size_t)0, H5P_GROUP_CREATE_DEFAULT, &oh_locA /*out*/) < 0)
        FAIL_STACK_ERROR;

    if (H5O_create(f, (size_t)H5O_MIN_SIZE, (size_t)0, H5P_GROUP_CREATE_DEFAULT, &oh_locB /*out*/) < 0)
        FAIL_STACK_ERROR;

    time_new = 11111111;

    if (H5O_msg_create(&oh_locA, H5O_NAME_ID, 0, 0, &long_name) < 0)
        FAIL_STACK_ERROR;

    if (H5O_msg_create(&oh_locB, H5O_MTIME_ID, 0, 0, &time_new) < 0)
        FAIL_STACK_ERROR;
    if (H5O_msg_create(&oh_locB, H5O_MTIME_ID, 0, 0, &time_new) < 0)
        FAIL_STACK_ERROR;
    if (H5O_msg_create(&oh_locB, H5O_MTIME_ID, 0, 0, &time_new) < 0)
        FAIL_STACK_ERROR;

    if (H5O_msg_create(&oh_locA, H5O_MTIME_NEW_ID, 0, 0, &time_new) < 0)
        FAIL_STACK_ERROR;

    if (H5O_msg_create(&oh_locB, H5O_MTIME_ID, 0, 0, &time_new) < 0)
        FAIL_STACK_ERROR;

    if (H5O_msg_create(&oh_locA, H5O_NAME_ID, 0, 0, &short_name) < 0)
        FAIL_STACK_ERROR;

    if (1 != H5O_link(&oh_locA, 1))
        FAIL_STACK_ERROR;
    if (1 != H5O_link(&oh_locB, 1))
        FAIL_STACK_ERROR;
    if (H5AC_prep_for_file_flush(f) < 0)
        FAIL_STACK_ERROR;
    if (H5AC_flush(f) < 0)
        FAIL_STACK_ERROR;
    if (H5AC_secure_from_file_flush(f) < 0)
        FAIL_STACK_ERROR;
    if (H5O__expunge_chunks_test(&oh_locA) < 0)
        FAIL_STACK_ERROR;

    if (H5O_get_hdr_info(&oh_locA, &hdr_info) < 0)
        FAIL_STACK_ERROR;
    nchunks = hdr_info.nchunks;

    /* remove the 1st H5O_NAME_ID message */
    if (H5O_msg_remove(&oh_locA, H5O_NAME_ID, 0, FALSE) < 0)
        FAIL_STACK_ERROR;

    if (H5O_get_hdr_info(&oh_locA, &hdr_info) < 0)
        FAIL_STACK_ERROR;

    if (hdr_info.nchunks >= nchunks)
        TEST_ERROR;

    if (H5O_close(&oh_locA, NULL) < 0)
        FAIL_STACK_ERROR;
    if (H5O_close(&oh_locB, NULL) < 0)
        FAIL_STACK_ERROR;
    if (H5Fclose(file) < 0)
        FAIL_STACK_ERROR;

    PASSED();

    return SUCCEED;

error:
    H5E_BEGIN_TRY
    {
        H5O_close(&oh_locA, NULL);
        H5O_close(&oh_locB, NULL);
        H5Fclose(file);
    }
    H5E_END_TRY;

    return FAIL;
} /* end test_cont() */

/*
 *  Verify that object headers are held in the cache until they are linked
 *      to a location in the graph, or assigned an ID.  This is done by
 *      creating an object header, then forcing it out of the cache by creating
 *      local heaps until the object header is evicted from the cache, then
 *      modifying the object header.  The refcount on the object header is
 *      checked as verifying that the object header has remained in the cache.
 */
static herr_t
test_ohdr_cache(char *filename, hid_t fapl)
{
    hid_t               file = -1;                            /* File ID */
    hid_t               my_fapl;                              /* FAPL ID */
    H5AC_cache_config_t mdc_config;                           /* Metadata cache configuration info */
    H5F_t *             f = NULL;                             /* File handle */
    H5HL_t *            lheap, *lheap2, *lheap3;              /* Pointer to local heaps */
    haddr_t             lheap_addr, lheap_addr2, lheap_addr3; /* Local heap addresses */
    H5O_loc_t           oh_loc;                               /* Object header location */
    time_t              time_new;                             /* Time value for modification time message */
    unsigned            rc;                                   /* Refcount for object */

    TESTING("object header creation in cache");

    /* Make a copy of the FAPL */
    if ((my_fapl = H5Pcopy(fapl)) < 0)
        FAIL_STACK_ERROR;

    /* Tweak down the size of the metadata cache to only 64K */
    mdc_config.version = H5AC__CURR_CACHE_CONFIG_VERSION;
    if (H5Pget_mdc_config(my_fapl, &mdc_config) < 0)
        FAIL_STACK_ERROR;
    mdc_config.set_initial_size = TRUE;
    mdc_config.initial_size     = 32 * 1024;
    mdc_config.max_size         = 64 * 1024;
    mdc_config.min_size         = 8 * 1024;
    if (H5Pset_mdc_config(my_fapl, &mdc_config) < 0)
        FAIL_STACK_ERROR;

    /* Create the file to operate on */
    if ((file = H5Fcreate(filename, H5F_ACC_TRUNC, H5P_DEFAULT, my_fapl)) < 0)
        FAIL_STACK_ERROR;
    if (H5Pclose(my_fapl) < 0)
        FAIL_STACK_ERROR;
    if (NULL == (f = (H5F_t *)H5VL_object(file)))
        FAIL_STACK_ERROR;
    if (H5AC_ignore_tags(f) < 0)
        FAIL_STACK_ERROR;

    /* Create object (local heap) that occupies most of cache */
    if (H5HL_create(f, (31 * 1024), &lheap_addr) < 0)
        FAIL_STACK_ERROR;

    /* Protect local heap (which actually pins it in the cache) */
    if (NULL == (lheap = H5HL_protect(f, lheap_addr, H5AC__READ_ONLY_FLAG)))
        FAIL_STACK_ERROR;

    /* Create an object header */
    HDmemset(&oh_loc, 0, sizeof(oh_loc));
    if (H5O_create(f, (size_t)2048, (size_t)1, H5P_GROUP_CREATE_DEFAULT, &oh_loc /*out*/) < 0)
        FAIL_STACK_ERROR;

    /* Query object header information */
    rc = 0;
    if (H5O__get_rc_test(&oh_loc, &rc) < 0)
        FAIL_STACK_ERROR;
    if (0 != rc)
        TEST_ERROR;

    /* Create object (local heap) that occupies most of cache */
    if (H5HL_create(f, (31 * 1024), &lheap_addr2) < 0)
        FAIL_STACK_ERROR;

    /* Protect local heap (which actually pins it in the cache) */
    if (NULL == (lheap2 = H5HL_protect(f, lheap_addr2, H5AC__READ_ONLY_FLAG)))
        FAIL_STACK_ERROR;

    /* Unprotect local heap (which actually unpins it from the cache) */
    if (H5HL_unprotect(lheap2) < 0)
        FAIL_STACK_ERROR;

    /* Create object header message in new object header */
    time_new = 11111111;
    if (H5O_msg_create(&oh_loc, H5O_MTIME_NEW_ID, 0, 0, &time_new) < 0)
        FAIL_STACK_ERROR;

    /* Create object (local heap) that occupies most of cache */
    if (H5HL_create(f, (31 * 1024), &lheap_addr3) < 0)
        FAIL_STACK_ERROR;

    /* Protect local heap (which actually pins it in the cache) */
    if (NULL == (lheap3 = H5HL_protect(f, lheap_addr3, H5AC__READ_ONLY_FLAG)))
        FAIL_STACK_ERROR;

    /* Unprotect local heap (which actually unpins it from the cache) */
    if (H5HL_unprotect(lheap3) < 0)
        FAIL_STACK_ERROR;

    /* Query object header information */
    /* (Note that this is somewhat of a weak test, since it doesn't actually
     *  verify that the object header was evicted from the cache, but it's
     *  very difficult to verify when an entry is evicted from the cache in
     *  a non-invasive way -QAK)
     */
    rc = 0;
    if (H5O__get_rc_test(&oh_loc, &rc) < 0)
        FAIL_STACK_ERROR;
    if (0 != rc)
        TEST_ERROR;

    /* Decrement reference count o object header */
    if (H5O_dec_rc_by_loc(&oh_loc) < 0)
        FAIL_STACK_ERROR;

    /* Close object header created */
    if (H5O_close(&oh_loc, NULL) < 0)
        FAIL_STACK_ERROR;

    /* Unprotect local heap (which actually unpins it from the cache) */
    if (H5HL_unprotect(lheap) < 0)
        FAIL_STACK_ERROR;

    if (H5Fclose(file) < 0)
        FAIL_STACK_ERROR;

    PASSED();

    return SUCCEED;

error:
    H5E_BEGIN_TRY
    {
        H5Fclose(file);
    }
    H5E_END_TRY;

    return FAIL;
} /* test_ohdr_cache() */

/*
 *  To exercise the coding for the re-read of the object header for SWMR access.
 *  When the object header is read in H5O_load() of H5Ocache.c, the library initially reads
 *  H5O_SPEC_READ_SIZE (512, currently)  bytes for decoding, then reads the
 *  remaining bytes later if the object header is greater than H5O_SPEC_READ_SIZE
 *  bytes.  For SWMR access, the read should be done all at one time.
 */
static herr_t
test_ohdr_swmr(hbool_t new_format)
{
    hid_t             fid          = -1;   /* File ID */
    hid_t             fapl         = -1;   /* File access property list */
    hid_t             did          = -1;   /* Dataset ID */
    hid_t             sid          = -1;   /* Dataspace ID */
    hid_t             plist        = -1;   /* Dataset creation property list */
    size_t            compact_size = 1024; /* The size of compact dataset */
    int *             wbuf         = NULL; /* Buffer for writing */
    hsize_t           dims[1];             /* Dimension sizes */
    size_t            u;                   /* Iterator */
    int               n;                   /* Data variable */
    H5O_native_info_t ninfo;               /* Information for the object */

    if (new_format) {
        TESTING("exercise the coding for the re-read of the object header for SWMR access: latest-format");
    }
    else {
        TESTING(
            "exercise the coding for the re-read of the object header for SWMR access: non-latest-format");
    } /* end if */

    /* File access property list */
    if ((fapl = H5Pcreate(H5P_FILE_ACCESS)) < 0)
        FAIL_STACK_ERROR;

    /* Create the file with/without latest format: ensure version 2 object header for SWMR */
    if (new_format) {
        /* Set to use latest library format */
        if (H5Pset_libver_bounds(fapl, H5F_LIBVER_LATEST, H5F_LIBVER_LATEST) < 0)
            FAIL_STACK_ERROR;

        if ((fid = H5Fcreate(FILE_OHDR_SWMR, H5F_ACC_TRUNC, H5P_DEFAULT, fapl)) < 0)
            TEST_ERROR;
    } /* end if */
    else {
        if ((fid = H5Fcreate(FILE_OHDR_SWMR, H5F_ACC_TRUNC | H5F_ACC_SWMR_WRITE, H5P_DEFAULT, fapl)) < 0)
            TEST_ERROR;
    } /* end else */

    /* Initialize data */
    wbuf = (int *)HDcalloc(compact_size, sizeof(int));
    n    = 0;
    for (u = 0; u < compact_size; u++)
        wbuf[u] = n++;

    /* Create a small data space for compact dataset */
    dims[0] = (hsize_t)compact_size;
    if ((sid = H5Screate_simple(1, dims, NULL)) < 0)
        FAIL_STACK_ERROR;

    /* Create property list for compact dataset creation */
    if ((plist = H5Pcreate(H5P_DATASET_CREATE)) < 0)
        FAIL_STACK_ERROR;

    /* Set the layout for the compact dataset */
    if (H5Pset_layout(plist, H5D_COMPACT) < 0)
        FAIL_STACK_ERROR;

    /* Create a compact dataset */
    if ((did = H5Dcreate2(fid, DSET_NAME, H5T_NATIVE_INT, sid, H5P_DEFAULT, plist, H5P_DEFAULT)) < 0)
        FAIL_STACK_ERROR;

    /* Write to the compact dataset */
    if (H5Dwrite(did, H5T_NATIVE_INT, H5S_ALL, H5S_ALL, H5P_DEFAULT, wbuf) < 0)
        FAIL_STACK_ERROR;

    /* Close the dataset */
    if (H5Dclose(did) < 0)
        FAIL_STACK_ERROR;

    /* Close the file */
    if (H5Fclose(fid) < 0)
        FAIL_STACK_ERROR;

    /* Open the file for SWMR write with/without latest format */
    if ((fid = H5Fopen(FILE_OHDR_SWMR, H5F_ACC_RDWR | H5F_ACC_SWMR_WRITE, fapl)) < 0)
        FAIL_STACK_ERROR;

    /* Open the compact dataset */
    if ((did = H5Dopen2(fid, DSET_NAME, H5P_DEFAULT)) < 0)
        FAIL_STACK_ERROR;

    /* Get the object information */
    if (H5Oget_native_info(did, &ninfo, H5O_NATIVE_INFO_HDR) < 0)
        FAIL_STACK_ERROR;

    if (new_format)
        if (ninfo.hdr.version != OBJ_VERSION_LATEST)
            FAIL_STACK_ERROR;

    /* The size of object header should be greater than the speculative read size of H5O_SPEC_READ_SIZE */
    /* This will exercise the coding for the re-read of the object header for SWMR access */
    if (ninfo.hdr.space.total < H5O_SPEC_READ_SIZE)
        TEST_ERROR;

    /* Close the dataset */
    if (H5Dclose(did) < 0)
        FAIL_STACK_ERROR;

    /* Close the file */
    if (H5Fclose(fid) < 0)
        FAIL_STACK_ERROR;

    /* Close the dataspace */
    if (H5Sclose(sid) < 0)
        FAIL_STACK_ERROR;

    /* Close the dataset creation property list */
    if (H5Pclose(plist) < 0)
        FAIL_STACK_ERROR;

    /* Close the file access property list */
    if (H5Pclose(fapl) < 0)
        FAIL_STACK_ERROR;

    /* Remove the test file */
    if (HDremove(FILE_OHDR_SWMR) < 0)
        FAIL_STACK_ERROR;

    /* Free the buffer */
    HDfree(wbuf);

    PASSED();

    return SUCCEED;

error:
    H5E_BEGIN_TRY
    {
        H5Fclose(fid);
        H5Dclose(did);
        H5Sclose(sid);
        H5Pclose(plist);
        H5Pclose(fapl);
        HDremove(FILE_OHDR_SWMR);
        HDfree(wbuf);
    }
    H5E_END_TRY;

    return FAIL;
} /* test_ohdr_swmr() */

/*
 * Tests bad object header messages.
 *
 * Currently tests for CVE-2020-10810 fixes but can be expanded to handle
 * other CVE badness.
 */

/* This is a generated file that can be obtained from:
 *
 * https://nvd.nist.gov/vuln/detail/CVE-2020-10810
 *
 * It was formerly named H5AC_unpin_entry_POC
 */
#define CVE_2020_10810_FILENAME "cve_2020_10810.h5"

static herr_t
test_ohdr_badness(hid_t fapl)
{
    hid_t fid = H5I_INVALID_HID;

    /* CVE-2020-10810 involved a malformed fsinfo message
     * This test ensures the fundamental problem is fixed. Running it under
     * valgrind et al. will ensure that the memory leaks and invalid access
     * are fixed.
     */
    TESTING("Fix for CVE-2020-10810");

    H5E_BEGIN_TRY
    {
        /* This should fail due to the malformed fsinfo message. It should
         * fail gracefully and not segfault.
         */
        fid = H5Fopen(CVE_2020_10810_FILENAME, H5F_ACC_RDWR, fapl);
    }
    H5E_END_TRY;

    if (fid >= 0)
        FAIL_PUTS_ERROR("should not have been able to open malformed file");

    PASSED();

    return SUCCEED;

error:
    H5E_BEGIN_TRY
    {
        H5Fclose(fid);
    }
    H5E_END_TRY;

    return FAIL;
}

/*
 *  To test objects with unknown messages in a file with:
 *      a) H5O_BOGUS_VALID_ID:
 *       --the bogus_id is within the range of H5O_msg_class_g[]
 *      b) H5O_BOGUS_INVALID_ID:
 *         --the bogus_id is outside the range of H5O_msg_class_g[]
 *
 *   The test file is FILE_BOGUS: "tbogus.h5" generated with gen_bogus.c
 *   --objects that have unknown header messages with H5O_BOGUS_VALID_ID in "/"
 *   --objects that have unknown header messages with H5O_BOGUS_INVALID_ID in "/group"
 *
 *   The test also uses the test file FILENAME[0] (ohdr.h5): the parameter "filename"
 */
static herr_t
test_unknown(unsigned bogus_id, char *filename, hid_t fapl)
{
    hid_t fid       = -1; /* file ID */
    hid_t gid       = -1; /* group ID */
    hid_t did       = -1; /* Dataset ID */
    hid_t sid       = -1; /* Dataspace ID */
    hid_t aid       = -1; /* Attribute ID */
    hid_t loc       = -1; /* location: file or group ID */
    hid_t fid_bogus = -1; /* bogus file ID */
    hid_t gid_bogus = -1; /* bogus group ID */
    hid_t loc_bogus = -1; /* location: bogus file or group ID */
    char  testfile[TESTFILE_LEN];

    /* create a different name for a local copy of the data file to be
       opened with rd/wr file permissions in case build and test are
       done in the source directory. */
    HDstrncpy(testfile, FILE_BOGUS, TESTFILE_LEN);
    testfile[TESTFILE_LEN - 1] = '\0';
    HDstrncat(testfile, ".copy", sizeof(testfile) - HDstrlen(testfile) - 1);

    /* Make a copy of the data file from svn. */
    if (h5_make_local_copy(FILE_BOGUS, testfile) < 0)
        FAIL_STACK_ERROR;

    TESTING("object with unknown header message and no flags set");

    /* Open filename */
    if ((fid = H5Fopen(filename, H5F_ACC_RDWR, fapl)) < 0)
        FAIL_STACK_ERROR;

    /* Open FILE_BOGUS */
    if ((fid_bogus = H5Fopen(testfile, H5F_ACC_RDONLY, fapl)) < 0)
        FAIL_STACK_ERROR;

    /* Set up location ID depending on bogus_id */
    if (bogus_id == H5O_BOGUS_INVALID_ID) {
        /* Open "group" in FILE_BOGUS */
        if ((gid_bogus = H5Gopen2(fid_bogus, "group", H5P_DEFAULT)) < 0)
            FAIL_STACK_ERROR;
        loc_bogus = gid_bogus;

        /* Create "group" in filename */
        if ((gid = H5Gcreate2(fid, "group", H5P_DEFAULT, H5P_DEFAULT, H5P_DEFAULT)) < 0)
            FAIL_STACK_ERROR;
        loc = gid;
    }
    else { /* H5O_BOGUS_VALID_ID */
        loc_bogus = fid_bogus;
        loc       = fid;
    } /* end else */

    /* Open the dataset with the unknown header message, but no extra flags */
    if ((did = H5Dopen2(loc_bogus, "Dataset1", H5P_DEFAULT)) < 0)
        FAIL_STACK_ERROR;
    if (H5Dclose(did) < 0)
        FAIL_STACK_ERROR;

    PASSED();

    TESTING("object with unknown header message & 'shareable' flag set");

    /* Open the dataset with the unknown header message, and "shareable" flag */
    if ((did = H5Dopen2(loc_bogus, "Dataset5", H5P_DEFAULT)) < 0)
        FAIL_STACK_ERROR;
    if (H5Dclose(did) < 0)
        FAIL_STACK_ERROR;

    PASSED();

    TESTING("object in r/o file with unknown header message & 'fail if unknown and open for write' flag set");

    /* Open the dataset with the unknown header message, and "fail if unknown and open for write" flag */
    if ((did = H5Dopen2(loc_bogus, "Dataset2", H5P_DEFAULT)) < 0)
        FAIL_STACK_ERROR;
    if (H5Dclose(did) < 0)
        FAIL_STACK_ERROR;

    PASSED();

    TESTING("object in r/o file with unknown header message & 'fail if unknown always' flag set");

    /* Attempt to open the dataset with the unknown header message, and "fail if unknown always" flag */
    H5E_BEGIN_TRY
    {
        did = H5Dopen2(loc_bogus, "Dataset3", H5P_DEFAULT);
    }
    H5E_END_TRY;
    if (did >= 0) {
        H5Dclose(did);
        TEST_ERROR;
    } /* end if */

    PASSED();

    TESTING("object with unknown header message & 'mark if unknown' flag set");

    /* Copy object with "mark if unknown" flag on message into file (FILENAME[0]) that can be modified */
    if (H5Ocopy(loc_bogus, "Dataset4", loc, "Dataset4", H5P_DEFAULT, H5P_DEFAULT) < 0)
        FAIL_STACK_ERROR;

    /* Closing: filename */
    if (bogus_id == H5O_BOGUS_INVALID_ID)
        if (H5Gclose(gid) < 0)
            FAIL_STACK_ERROR;
    if (H5Fclose(fid) < 0)
        FAIL_STACK_ERROR;

    /* Re-open filename, with read-only permissions */
    if ((fid = H5Fopen(filename, H5F_ACC_RDONLY, fapl)) < 0)
        FAIL_STACK_ERROR;

    /* Set up location ID depending on bogus_id */
    if (bogus_id == H5O_BOGUS_INVALID_ID) {
        /* Open "group" in filename */
        if ((gid = H5Gopen2(fid, "group", H5P_DEFAULT)) < 0)
            FAIL_STACK_ERROR;
        loc = gid;
    }
    else
        loc = fid;

    /* Open the dataset with the "mark if unknown" message */
    if ((did = H5Dopen2(loc, "Dataset4", H5P_DEFAULT)) < 0)
        FAIL_STACK_ERROR;

    /* Check that the "unknown" message was _NOT_ marked */
    if (H5O__check_msg_marked_test(did, FALSE) < 0)
        FAIL_STACK_ERROR;

    /* Close the dataset */
    if (H5Dclose(did) < 0)
        FAIL_STACK_ERROR;

    /* Close "group" in filename depending on bogus_id */
    if (bogus_id == H5O_BOGUS_INVALID_ID)
        if (H5Gclose(gid) < 0)
            FAIL_STACK_ERROR;

    /* Close filename (to flush change to object header) */
    if (H5Fclose(fid) < 0)
        FAIL_STACK_ERROR;

    /* Re-open filename */
    if ((fid = H5Fopen(filename, H5F_ACC_RDWR, fapl)) < 0)
        FAIL_STACK_ERROR;

    /* Set up location ID depending on bogus_id */
    if (bogus_id == H5O_BOGUS_INVALID_ID) {
        /* Open "group" in filename */
        if ((gid = H5Gopen2(fid, "group", H5P_DEFAULT)) < 0)
            FAIL_STACK_ERROR;
        loc = gid;
    }
    else
        loc = fid;

    /* Open the dataset with the "mark if unknown" message */
    if ((did = H5Dopen2(loc, "Dataset4", H5P_DEFAULT)) < 0)
        FAIL_STACK_ERROR;

    /* Create data space */
    if ((sid = H5Screate(H5S_SCALAR)) < 0)
        FAIL_STACK_ERROR;

    /* Create an attribute, to get the object header into write access */
    if ((aid = H5Acreate2(did, "Attr", H5T_NATIVE_INT, sid, H5P_DEFAULT, H5P_DEFAULT)) < 0)
        FAIL_STACK_ERROR;

    /* Close dataspace */
    if (H5Sclose(sid) < 0)
        FAIL_STACK_ERROR;

    /* Close attribute */
    if (H5Aclose(aid) < 0)
        FAIL_STACK_ERROR;

    /* Close the dataset */
    if (H5Dclose(did) < 0)
        FAIL_STACK_ERROR;

    /* Close "group" in filename depending on bogus_id */
    if (bogus_id == H5O_BOGUS_INVALID_ID)
        if (H5Gclose(gid) < 0)
            FAIL_STACK_ERROR;

    /* Close filename (to flush change to object header) */
    if (H5Fclose(fid) < 0)
        FAIL_STACK_ERROR;

    /* Re-open filename */
    if ((fid = H5Fopen(filename, H5F_ACC_RDONLY, fapl)) < 0)
        FAIL_STACK_ERROR;

    /* Set up location ID depending on bogus_id */
    if (bogus_id == H5O_BOGUS_INVALID_ID) {
        /* Open "group" in filename */
        if ((gid = H5Gopen2(fid, "group", H5P_DEFAULT)) < 0)
            FAIL_STACK_ERROR;
        loc = gid;
    }
    else
        loc = fid;

    /* Re-open the dataset with the "mark if unknown" message */
    if ((did = H5Dopen2(loc, "Dataset4", H5P_DEFAULT)) < 0)
        FAIL_STACK_ERROR;

    /* Check that the "unknown" message was marked */
    if (H5O__check_msg_marked_test(did, TRUE) < 0)
        FAIL_STACK_ERROR;

    /* Close the dataset */
    if (H5Dclose(did) < 0)
        FAIL_STACK_ERROR;

    /* Closing: filename */
    if (bogus_id == H5O_BOGUS_INVALID_ID)
        if (H5Gclose(gid) < 0)
            FAIL_STACK_ERROR;
    if (H5Fclose(fid) < 0)
        FAIL_STACK_ERROR;

    PASSED();

    /* Closing: FILE_BOGUS */
    if (bogus_id == H5O_BOGUS_INVALID_ID)
        if (H5Gclose(gid_bogus) < 0)
            FAIL_STACK_ERROR;
    if (H5Fclose(fid_bogus) < 0)
        FAIL_STACK_ERROR;

    TESTING("object in r/w file with unknown header message & 'fail if unknown and open for write' flag set");

    /* Open FILE_BOGUS with RW intent this time */
    if ((fid_bogus = H5Fopen(testfile, H5F_ACC_RDWR, H5P_DEFAULT)) < 0)
        FAIL_STACK_ERROR;

    /* Set up location ID */
    if (bogus_id == H5O_BOGUS_INVALID_ID) {
        /* Open "group" in FILE_BOGUS */
        if ((gid_bogus = H5Gopen2(fid_bogus, "group", H5P_DEFAULT)) < 0)
            FAIL_STACK_ERROR;
        loc_bogus = gid_bogus;
    }
    else
        loc_bogus = fid_bogus;

    /* Attempt to open the dataset with the unknown header message, and "fail if unknown and open for write"
     * flag */
    H5E_BEGIN_TRY
    {
        did = H5Dopen2(loc_bogus, "Dataset2", H5P_DEFAULT);
    }
    H5E_END_TRY;
    if (did >= 0) {
        H5Dclose(did);
        TEST_ERROR;
    } /* end if */

    PASSED();

    TESTING("object in r/w file with unknown header message & 'fail if unknown always' flag set");

    /* Attempt to open the dataset with the unknown header message, and "fail if unknown always" flag */
    H5E_BEGIN_TRY
    {
        did = H5Dopen2(loc_bogus, "Dataset3", H5P_DEFAULT);
    }
    H5E_END_TRY;
    if (did >= 0) {
        H5Dclose(did);
        TEST_ERROR;
    } /* end if */

    /* Closing: FILE_BOGUS */
    if (bogus_id == H5O_BOGUS_INVALID_ID)
        if (H5Gclose(gid_bogus) < 0)
            FAIL_STACK_ERROR;
    if (H5Fclose(fid_bogus) < 0)
        FAIL_STACK_ERROR;

    PASSED();

    return SUCCEED;

error:
    H5E_BEGIN_TRY
    {
        H5Fclose(fid);
        H5Gclose(gid);
        H5Fclose(fid_bogus);
        H5Gclose(gid_bogus);
        H5Dclose(did);
        H5Sclose(sid);
        H5Aclose(aid);
    }
    H5E_END_TRY;

    return FAIL;
} /* test_unknown() */

/*
 * Count the number of attributes attached to an object.
 * Returns negative in event of error.
 */
static int
count_attributes(hid_t dset_id)
{
    H5O_info2_t info;

    if (H5Oget_info3(dset_id, &info, H5O_INFO_NUM_ATTRS) < 0)
        return -1;
    else
        return (int)info.num_attrs; /* should never exceed int bounds */
} /* count_attributes */

/*
 * Get the total space used by the object header.
 * Used by oh_compare()
 * On success, stores size in `size_out` pointer.
 */
static herr_t
oh_getsize(hid_t did, hsize_t *size_out)
{
    H5O_native_info_t ninfo;

    if (FAIL == H5Oget_native_info(did, &ninfo, H5O_NATIVE_INFO_HDR))
        return FAIL;

    *size_out = ninfo.hdr.space.total;

    return SUCCEED;
} /* _oh_getsize */

/*
 * Compare the TOTAL space used by datasets' object headers.
 * Returns negative value if an error occurred,
 * else positive #defined indicator value EQ, LT, GT.
 */
static int
oh_compare(hid_t did1, hid_t did2)
{
    hsize_t space1 = 0;
    hsize_t space2 = 0;

    if (FAIL == oh_getsize(did1, &space1))
        return -1;
    if (FAIL == oh_getsize(did2, &space2))
        return -2;

    if (space1 < space2)
        return LT;
    else if (space1 > space2)
        return GT;
    else
        return EQ;
} /* oh_compare() */

/*
 * Demonstrate attribute addition to datasets.
 * Conduct additions side-by-side with a standard datataset and one with
 * minimized dataset object headers.
 */
#define ATTR_NAME_MAX 64
#define ATTR_SHORT    "first"
#define ATTR_LONG     "second"
#define N_ATTRS       64
static herr_t
test_minimized_dset_ohdr_attribute_addition(hid_t fapl_id)
{
    hsize_t dims[1]                  = {0}; /* dataspace extent */
    char    filename[512]            = "";
    char    attr_name[ATTR_NAME_MAX] = "";
    hid_t   fid                      = H5I_INVALID_HID;
    hid_t   dcpl_id                  = H5I_INVALID_HID;
    hid_t   sid                      = H5I_INVALID_HID;
    hid_t   did                      = H5I_INVALID_HID;
    hid_t   aid                      = H5I_INVALID_HID;
    char *  in_buf                   = NULL;
    char *  out_buf                  = NULL;
    size_t  buf_size                 = 0;
    int     out_val                  = 0;
    int     in_val                   = 0;
    int     i;

    TESTING("adding attributes to datasets created with H5Pset_dset_no_attrs_hint()");

    /* Create the test file */
    if (NULL == h5_fixname(FILENAME[1], fapl_id, filename, sizeof(filename)))
        TEST_ERROR;
    if ((fid = H5Fcreate(filename, H5F_ACC_TRUNC, H5P_DEFAULT, fapl_id)) == H5I_INVALID_HID)
        TEST_ERROR;

    /* Set the 'no attrs' hint on the dcpl */
    if ((dcpl_id = H5Pcreate(H5P_DATASET_CREATE)) == H5I_INVALID_HID)
        TEST_ERROR;
    if (H5Pset_dset_no_attrs_hint(dcpl_id, TRUE) < 0)
        TEST_ERROR;

    /* The dataset doesn't need to contain data */
    dims[0] = 0;
    if ((sid = H5Screate_simple(1, dims, NULL)) == H5I_INVALID_HID)
        TEST_ERROR;

    /* Create the dataset */
    if ((did = H5Dcreate2(fid, "H5Pset_dset_no_attrs_hint", H5T_NATIVE_INT, sid, H5P_DEFAULT, dcpl_id,
                          H5P_DEFAULT)) == H5I_INVALID_HID)
        TEST_ERROR;

    /* Close */
    if (H5Pclose(dcpl_id) < 0)
        TEST_ERROR;
    if (H5Sclose(sid) < 0)
        TEST_ERROR;

    /**********************************************
     * ADD A (STRING) ATTRIBUTE AND MANIPULATE IT *
     **********************************************/

    buf_size = HDstrlen(ATTR_LONG) + 1;
    if (NULL == (in_buf = (char *)HDcalloc(buf_size, sizeof(char))))
        TEST_ERROR;
    if (NULL == (out_buf = (char *)HDcalloc(buf_size, sizeof(char))))
        TEST_ERROR;

    /* Create a string attribute on the dataset
     *
     * It has to be long enough to hold the longest string we're going to write
     * to it.
     */
    dims[0] = buf_size;
    if ((sid = H5Screate_simple(1, dims, NULL)) == H5I_INVALID_HID)
        TEST_ERROR;
    if ((aid = H5Acreate2(did, "string_attr", H5T_NATIVE_CHAR, sid, H5P_DEFAULT, H5P_DEFAULT)) ==
        H5I_INVALID_HID)
        TEST_ERROR;

    /* Write attribute data */
    HDstrcpy(in_buf, ATTR_SHORT);
    if (H5Awrite(aid, H5T_NATIVE_CHAR, in_buf) < 0)
        TEST_ERROR;

    /* Make sure the count is correct */
    if (count_attributes(did) != 1)
        TEST_ERROR;

    /* Read the data back and verify */
    if (H5Aread(aid, H5T_NATIVE_CHAR, out_buf) < 0)
        TEST_ERROR;
    if (HDstrcmp(in_buf, out_buf) != 0)
        TEST_ERROR;

    /* modify the string attribute */
    HDmemset(in_buf, 0, buf_size);
    HDstrcpy(in_buf, ATTR_LONG);
    if (H5Awrite(aid, H5T_NATIVE_CHAR, in_buf) < 0)
        TEST_ERROR;

    if (count_attributes(did) != 1)
        TEST_ERROR;

    /* Read the data back and verify */
    if (H5Aread(aid, H5T_NATIVE_CHAR, out_buf) < 0)
        TEST_ERROR;
    if (HDstrcmp(in_buf, out_buf) != 0)
        TEST_ERROR;

    /* Close */
    if (H5Sclose(sid) < 0)
        TEST_ERROR;
    if (H5Aclose(aid) < 0)
        TEST_ERROR;

    /***************************************
     * ADD A BUNCH OF (INTEGER) ATTRIBUTES *
     ***************************************/

    if ((sid = H5Screate(H5S_SCALAR)) == H5I_INVALID_HID)
        TEST_ERROR;

    /* Loop over a reasonable number of attributes */
    for (i = 0; i < N_ATTRS; i++) {

        /* Set the attribute's name */
        if (HDsnprintf(attr_name, ATTR_NAME_MAX, "int_attr_%d", i) < 0)
            TEST_ERROR;

        /* Create an integer attribute on the dataset */
        if ((aid = H5Acreate2(did, attr_name, H5T_NATIVE_INT, sid, H5P_DEFAULT, H5P_DEFAULT)) ==
            H5I_INVALID_HID)
            TEST_ERROR;

        /* Write attribute data */
        in_val = i;
        if (H5Awrite(aid, H5T_NATIVE_INT, &in_val) < 0)
            TEST_ERROR;

        /* Make sure the count is correct (already has one attribute) */
        if (count_attributes(did) != i + 2)
            TEST_ERROR;

        /* Read the data back and verify */
        if (H5Aread(aid, H5T_NATIVE_INT, &out_val) < 0)
            TEST_ERROR;
        if (in_val != out_val)
            TEST_ERROR;

        /* Close */
        if (H5Aclose(aid) < 0)
            TEST_ERROR;
    }

    /* Close */
    if (H5Sclose(sid) < 0)
        TEST_ERROR;

    /* Close the remaining IDs */
    if (H5Dclose(did) < 0)
        TEST_ERROR;
    if (H5Fclose(fid) < 0)
        TEST_ERROR;

    /* Free memory */
    HDfree(in_buf);
    HDfree(out_buf);

    PASSED();
    return SUCCEED;

error:
    H5E_BEGIN_TRY
    {
        (void)H5Pclose(dcpl_id);
        (void)H5Sclose(sid);
        (void)H5Dclose(did);
        (void)H5Aclose(aid);
        (void)H5Fclose(fid);
    }
    H5E_END_TRY;

    HDfree(in_buf);
    HDfree(out_buf);

    return FAIL;
} /* test_minimized_dset_ohdr_attribute_addition */

/*
 * Compare header sizes against when headers have been minimized.
 * Repeats tests with headers "compact" and normal.
 */
static herr_t
test_minimized_dset_ohdr_size_comparisons(hid_t fapl_id)
{
    hsize_t  array_10[1] = {10}; /* dataspace extents */
    unsigned compact     = 0;

    /* IDs that are file-agnostic */
    hid_t dspace_id     = -1;
    hid_t int_type_id   = -1;
    hid_t dcpl_minimize = -1;
    hid_t dcpl_dontmin  = -1;
    hid_t dcpl_default  = -1;

    /* IDs for non-minimized file open */
    hid_t file_f_id   = -1; /* lower 'f' for standard file setting */
    hid_t dset_f_x_id = -1; /* 'x' for default */
    hid_t dset_f_N_id = -1; /* 'N' for explicit non-minimized dset */
    hid_t dset_f_Y_id = -1; /* 'Y' for minimized dset */

    /* IDs for minimized file open */
    hid_t file_F_id   = -1; /* upper 'F' for minimized file setting */
    hid_t dset_F_x_id = -1; /* 'x' for default */
    hid_t dset_F_N_id = -1; /* 'N' for explicit non-minimized dset */
    hid_t dset_F_Y_id = -1; /* 'Y' for minimized dset */

    char filename_a[512] = "";
    char filename_b[512] = "";

    herr_t ret;

    /* dataset suffixes:
     *                | default | minimize | don't minimize (dcpl-set)
     * ---------------+---------+----------+---------------
     * file-default   |   f_x   |   f_Y    |   f_N
     * ---------------+---------+----------+---------------
     * file-minimized |   F_x   |   F_Y    |   F_N
     */

    /*********
     * SETUP *
     *********/

    /* Set filenames (not in a test, can't use TEST_ERROR) */
    if (h5_fixname(FILENAME[1], fapl_id, filename_a, sizeof(filename_a)) == NULL)
        return FAIL;
    if (h5_fixname(FILENAME[2], fapl_id, filename_b, sizeof(filename_b)) == NULL)
        return FAIL;

    for (compact = 0; compact < 2; compact++) { /* 0 or 1 */

        if (compact)
            TESTING("minimized dset object headers size comparisons (compact)");
        else
            TESTING("minimized dset object headers size comparisons");

        dcpl_default = H5Pcreate(H5P_DATASET_CREATE);
        if (dcpl_default < 0)
            TEST_ERROR;

        dcpl_minimize = H5Pcreate(H5P_DATASET_CREATE);
        if (dcpl_minimize < 0)
            TEST_ERROR;
        ret = H5Pset_dset_no_attrs_hint(dcpl_minimize, TRUE);
        if (ret < 0)
            TEST_ERROR;

        dcpl_dontmin = H5Pcreate(H5P_DATASET_CREATE);
        if (dcpl_dontmin < 0)
            TEST_ERROR;
        ret = H5Pset_dset_no_attrs_hint(dcpl_dontmin, FALSE);
        if (ret < 0)
            TEST_ERROR;

        if (compact) {
            ret = H5Pset_layout(dcpl_default, H5D_COMPACT);
            if (ret < 0)
                TEST_ERROR;
            ret = H5Pset_layout(dcpl_minimize, H5D_COMPACT);
            if (ret < 0)
                TEST_ERROR;
            ret = H5Pset_layout(dcpl_dontmin, H5D_COMPACT);
            if (ret < 0)
                TEST_ERROR;
        }

        dspace_id = H5Screate_simple(1, array_10, NULL);
        if (dspace_id < 0)
            TEST_ERROR;

        int_type_id = H5Tcopy(H5T_NATIVE_INT);
        if (int_type_id < 0)
            TEST_ERROR;

        file_f_id = H5Fcreate(filename_a, H5F_ACC_TRUNC, H5P_DEFAULT, fapl_id);
        if (file_f_id < 0)
            TEST_ERROR;

        dset_f_x_id =
            H5Dcreate2(file_f_id, "default", int_type_id, dspace_id, H5P_DEFAULT, dcpl_default, H5P_DEFAULT);
        if (dset_f_x_id < 0)
            TEST_ERROR;

        dset_f_N_id =
            H5Dcreate2(file_f_id, "dsetNOT", int_type_id, dspace_id, H5P_DEFAULT, dcpl_dontmin, H5P_DEFAULT);
        if (dset_f_N_id < 0)
            TEST_ERROR;

        dset_f_Y_id =
            H5Dcreate2(file_f_id, "dsetMIN", int_type_id, dspace_id, H5P_DEFAULT, dcpl_minimize, H5P_DEFAULT);
        if (dset_f_x_id < 0)
            TEST_ERROR;

        file_F_id = H5Fcreate(filename_b, H5F_ACC_TRUNC, H5P_DEFAULT, fapl_id);
        if (file_F_id < 0)
            TEST_ERROR;
        ret = H5Fset_dset_no_attrs_hint(file_F_id, TRUE);
        if (ret < 0)
            TEST_ERROR;

        dset_F_x_id =
            H5Dcreate2(file_F_id, "default", int_type_id, dspace_id, H5P_DEFAULT, dcpl_default, H5P_DEFAULT);
        if (dset_F_x_id < 0)
            TEST_ERROR;

        dset_F_N_id =
            H5Dcreate2(file_F_id, "dsetNOT", int_type_id, dspace_id, H5P_DEFAULT, dcpl_dontmin, H5P_DEFAULT);
        if (dset_F_N_id < 0)
            TEST_ERROR;

        dset_F_Y_id =
            H5Dcreate2(file_F_id, "dsetMIN", int_type_id, dspace_id, H5P_DEFAULT, dcpl_minimize, H5P_DEFAULT);
        if (dset_F_Y_id < 0)
            TEST_ERROR;

        /*********
         * TESTS *
         *********/

        /* Identity */
        if (oh_compare(dset_f_x_id, dset_f_x_id) != EQ)
            TEST_ERROR;

        if (oh_compare(dset_f_x_id, dset_f_N_id) != EQ)
            TEST_ERROR;
        if (oh_compare(dset_f_x_id, dset_f_Y_id) != GT)
            TEST_ERROR;
        if (oh_compare(dset_f_N_id, dset_f_Y_id) != GT)
            TEST_ERROR;

        if (oh_compare(dset_F_x_id, dset_F_N_id) != EQ)
            TEST_ERROR;
        if (oh_compare(dset_F_x_id, dset_F_Y_id) != EQ)
            TEST_ERROR;
        if (oh_compare(dset_F_N_id, dset_F_Y_id) != EQ)
            TEST_ERROR;

        if (oh_compare(dset_F_x_id, dset_f_Y_id) != EQ)
            TEST_ERROR;
        if (oh_compare(dset_F_x_id, dset_f_x_id) != LT)
            TEST_ERROR;

        /************
         * TEARDOWN *
         ************/

        if (H5Sclose(dspace_id) < 0)
            TEST_ERROR;
        if (H5Tclose(int_type_id) < 0)
            TEST_ERROR;
        if (H5Pclose(dcpl_default) < 0)
            TEST_ERROR;
        if (H5Pclose(dcpl_minimize) < 0)
            TEST_ERROR;
        if (H5Pclose(dcpl_dontmin) < 0)
            TEST_ERROR;

        if (H5Fclose(file_f_id) < 0)
            TEST_ERROR;
        if (H5Dclose(dset_f_x_id) < 0)
            TEST_ERROR;
        if (H5Dclose(dset_f_N_id) < 0)
            TEST_ERROR;
        if (H5Dclose(dset_f_Y_id) < 0)
            TEST_ERROR;

        if (H5Fclose(file_F_id) < 0)
            TEST_ERROR;
        if (H5Dclose(dset_F_x_id) < 0)
            TEST_ERROR;
        if (H5Dclose(dset_F_N_id) < 0)
            TEST_ERROR;
        if (H5Dclose(dset_F_Y_id) < 0)
            TEST_ERROR;

        PASSED();

    } /* compact and non-compact */

    return SUCCEED;

error:
    H5E_BEGIN_TRY
    {
        (void)H5Pclose(dcpl_default);
        (void)H5Pclose(dcpl_minimize);
        (void)H5Pclose(dcpl_dontmin);
        (void)H5Sclose(dspace_id);
        (void)H5Tclose(int_type_id);

        (void)H5Fclose(file_f_id);
        (void)H5Dclose(dset_f_x_id);
        (void)H5Dclose(dset_f_N_id);
        (void)H5Dclose(dset_f_Y_id);

        (void)H5Fclose(file_F_id);
        (void)H5Dclose(dset_F_x_id);
        (void)H5Dclose(dset_F_N_id);
        (void)H5Dclose(dset_F_Y_id);
    }
    H5E_END_TRY;
    return FAIL;
} /* test_minimized_dset_ohdr_size_comparisons */

/*
 * Test minimized dataset object header with filter/pipeline message
 */
static herr_t
test_minimized_dset_ohdr_with_filter(hid_t fapl_id)
{
    char           filename[512]   = "";
    const hsize_t  extents[1]      = {1024}; /* extents of dataspace */
    const unsigned filter_values[] = {0};    /* TBD */
    const hsize_t  chunk_dim[]     = {32};   /* needed for filter */
    const int      ndims           = 1;
    hid_t          dspace_id       = -1;
    hid_t          dtype_id        = -1;
    hid_t          dcpl_xZ_id      = -1;
    hid_t          dcpl_mx_id      = -1;
    hid_t          dcpl_mZ_id      = -1;
    hid_t          dset_xx_id      = -1;
    hid_t          dset_xZ_id      = -1;
    hid_t          dset_mx_id      = -1;
    hid_t          dset_mZ_id      = -1;
    hid_t          file_id         = -1;
    herr_t         ret;

    /* dcpl suffixes:
     *           | default | minimize
     * ----------+---------+---------
     * no filter |    xx   |   mx
     * ----------+---------+---------
     * filter    |    xZ   |   mZ
     */

    TESTING("minimized dset object headers with filter message");

    /*********
     * SETUP *
     *********/

    if (h5_fixname(FILENAME[1], fapl_id, filename, sizeof(filename)) == NULL)
        TEST_ERROR;

    dcpl_mx_id = H5Pcreate(H5P_DATASET_CREATE);
    if (dcpl_mx_id < 0)
        TEST_ERROR;
    ret = H5Pset_dset_no_attrs_hint(dcpl_mx_id, TRUE);
    if (ret < 0)
        TEST_ERROR;

    dcpl_xZ_id = H5Pcreate(H5P_DATASET_CREATE);
    if (dcpl_xZ_id < 0)
        TEST_ERROR;
    ret = H5Pset_chunk(dcpl_xZ_id, ndims, chunk_dim);
    if (ret < 0)
        TEST_ERROR;
    ret = H5Pset_filter(dcpl_xZ_id, H5Z_FILTER_DEFLATE, H5Z_FLAG_OPTIONAL, 0, filter_values);
    if (ret < 0)
        TEST_ERROR;
    dcpl_mZ_id = H5Pcreate(H5P_DATASET_CREATE);
    if (dcpl_mZ_id < 0)
        TEST_ERROR;
    ret = H5Pset_dset_no_attrs_hint(dcpl_mZ_id, TRUE);
    if (ret < 0)
        TEST_ERROR;
    ret = H5Pset_chunk(dcpl_mZ_id, ndims, chunk_dim);
    if (ret < 0)
        TEST_ERROR;
    ret = H5Pset_filter(dcpl_mZ_id, H5Z_FILTER_DEFLATE, H5Z_FLAG_OPTIONAL, 0, filter_values);
    if (ret < 0)
        TEST_ERROR;

    dspace_id = H5Screate_simple(1, extents, extents);
    if (dspace_id < 0)
        TEST_ERROR;

    dtype_id = H5Tcopy(H5T_NATIVE_INT);
    if (dtype_id < 0)
        TEST_ERROR;

    file_id = H5Fcreate(filename, H5F_ACC_TRUNC, H5P_DEFAULT, fapl_id);
    if (file_id < 0)
        TEST_ERROR;

    dset_xx_id = H5Dcreate2(file_id, "xx", dtype_id, dspace_id, H5P_DEFAULT, H5P_DEFAULT, H5P_DEFAULT);
    if (dset_xx_id < 0)
        TEST_ERROR;

    dset_mx_id = H5Dcreate2(file_id, "Mx", dtype_id, dspace_id, H5P_DEFAULT, dcpl_mx_id, H5P_DEFAULT);
    if (dset_mx_id < 0)
        TEST_ERROR;

    dset_xZ_id = H5Dcreate2(file_id, "xZ", dtype_id, dspace_id, H5P_DEFAULT, dcpl_xZ_id, H5P_DEFAULT);
    if (dset_xZ_id < 0)
        TEST_ERROR;

    dset_mZ_id = H5Dcreate2(file_id, "MZ", dtype_id, dspace_id, H5P_DEFAULT, dcpl_mZ_id, H5P_DEFAULT);
    if (dset_mZ_id < 0)
        TEST_ERROR;

    /*********
     * TESTS *
     *********/

    if (oh_compare(dset_mx_id, dset_xx_id) != LT)
        TEST_ERROR;
    if (oh_compare(dset_mx_id, dset_xZ_id) != LT)
        TEST_ERROR;
    if (oh_compare(dset_mZ_id, dset_mx_id) != GT)
        TEST_ERROR;
    if (oh_compare(dset_mZ_id, dset_xZ_id) != LT)
        TEST_ERROR;

    /************
     * TEARDOWN *
     ************/

    if (H5Sclose(dspace_id) < 0)
        TEST_ERROR;
    if (H5Tclose(dtype_id) < 0)
        TEST_ERROR;
    if (H5Pclose(dcpl_xZ_id) < 0)
        TEST_ERROR;
    if (H5Pclose(dcpl_mx_id) < 0)
        TEST_ERROR;
    if (H5Pclose(dcpl_mZ_id) < 0)
        TEST_ERROR;
    if (H5Dclose(dset_xx_id) < 0)
        TEST_ERROR;
    if (H5Dclose(dset_xZ_id) < 0)
        TEST_ERROR;
    if (H5Dclose(dset_mx_id) < 0)
        TEST_ERROR;
    if (H5Dclose(dset_mZ_id) < 0)
        TEST_ERROR;
    if (H5Fclose(file_id) < 0)
        TEST_ERROR;

    PASSED();
    return SUCCEED;

error:
    H5E_BEGIN_TRY
    {
        (void)H5Sclose(dspace_id);
        (void)H5Tclose(dtype_id);
        (void)H5Pclose(dcpl_xZ_id);
        (void)H5Pclose(dcpl_mx_id);
        (void)H5Pclose(dcpl_mZ_id);
        (void)H5Dclose(dset_xx_id);
        (void)H5Dclose(dset_xZ_id);
        (void)H5Dclose(dset_mx_id);
        (void)H5Dclose(dset_mZ_id);
        (void)H5Fclose(file_id);
    }
    H5E_END_TRY;
    return FAIL;
} /* test_minimized_dset_ohdr_with_filter */

/*
 * Test minimized dataset object header and recording modification times.
 */
static herr_t
test_minimized_dset_ohdr_modification_times(hid_t _fapl_id)
{
    /* test-local structure for parameterized testing
     */
    struct testcase {
        unsigned oh_version;
    };

    char          filename[512] = "";
    const hsize_t extents[1]    = {128}; /* extents of dataspace */
    hid_t         dspace_id     = -1;
    hid_t         dtype_id      = -1;
    hid_t         dcpl_xT_id    = -1; /* Track modtime */
    hid_t         dcpl_mx_id    = -1; /* minimized */
    hid_t         dcpl_mT_id    = -1; /* minimized, Track */
    hid_t         dcpl_mN_id    = -1; /* minimized, do Not track */
    hid_t         dset_xx_id    = -1;
    hid_t         dset_xT_id    = -1;
    hid_t         dset_mx_id    = -1;
    hid_t         dset_mT_id    = -1;
    hid_t         dset_mN_id    = -1;
    hid_t         file_id       = -1;
    hid_t         fapl_id       = -1;
    herr_t        ret;

    unsigned        i        = 0; /* for testcase loop */
    unsigned        n_cases  = 2; /* must match `cases` array size below */
    struct testcase cases[2] = {
        {
            1,
        }, /* version 1 object header */
        {
            2,
        }, /* version 2 object header */
    };

    /* dcpl suffixes:
     *             | default | minimize
     * ------------+---------+---------
     * default     |    xx   |   mx
     * ------------+---------+---------
     * don't track |    xN   |   mN
     * ------------+---------+---------
     * track       |    xT   |   mT
     */

    TESTING("minimized dset object headers with modification times");

    /*********
     * SETUP *
     *********/

    if (h5_fixname(FILENAME[1], _fapl_id, filename, sizeof(filename)) == NULL)
        TEST_ERROR;

    dcpl_mx_id = H5Pcreate(H5P_DATASET_CREATE);
    if (dcpl_mx_id < 0)
        TEST_ERROR;
    ret = H5Pset_dset_no_attrs_hint(dcpl_mx_id, TRUE);
    if (ret < 0)
        TEST_ERROR;

    dcpl_xT_id = H5Pcreate(H5P_DATASET_CREATE);
    if (dcpl_xT_id < 0)
        TEST_ERROR;
    ret = H5Pset_obj_track_times(dcpl_xT_id, TRUE);
    if (ret < 0)
        TEST_ERROR;

    dcpl_mT_id = H5Pcreate(H5P_DATASET_CREATE);
    if (dcpl_mT_id < 0)
        TEST_ERROR;
    ret = H5Pset_dset_no_attrs_hint(dcpl_mT_id, TRUE);
    if (ret < 0)
        TEST_ERROR;
    ret = H5Pset_obj_track_times(dcpl_mT_id, TRUE);
    if (ret < 0)
        TEST_ERROR;

    dcpl_mN_id = H5Pcreate(H5P_DATASET_CREATE);
    if (dcpl_mN_id < 0)
        TEST_ERROR;
    ret = H5Pset_dset_no_attrs_hint(dcpl_mN_id, TRUE);
    if (ret < 0)
        TEST_ERROR;
    ret = H5Pset_obj_track_times(dcpl_mN_id, FALSE);
    if (ret < 0)
        TEST_ERROR;

    dspace_id = H5Screate_simple(1, extents, extents);
    if (dspace_id < 0)
        TEST_ERROR;

    dtype_id = H5Tcopy(H5T_NATIVE_INT);
    if (dtype_id < 0)
        TEST_ERROR;

    for (i = 0; i < n_cases; i++) {

        /* -------------- *
         * per-case setup *
         * -------------- */

        fapl_id = H5Pcopy(_fapl_id);
        if (fapl_id < 0)
            TEST_ERROR;

        if (cases[i].oh_version > 1) {
            ret = H5Pset_libver_bounds(fapl_id, H5F_LIBVER_V18, H5F_LIBVER_V110);
            if (ret < 0)
                TEST_ERROR;
        }

        file_id = H5Fcreate(filename, H5F_ACC_TRUNC, H5P_DEFAULT, fapl_id);
        if (file_id < 0)
            TEST_ERROR;

        dset_xx_id = H5Dcreate2(file_id, "xx", dtype_id, dspace_id, H5P_DEFAULT, H5P_DEFAULT, H5P_DEFAULT);
        if (dset_xx_id < 0)
            TEST_ERROR;

        dset_mx_id = H5Dcreate2(file_id, "mx", dtype_id, dspace_id, H5P_DEFAULT, dcpl_mx_id, H5P_DEFAULT);
        if (dset_mx_id < 0)
            TEST_ERROR;

        dset_xT_id = H5Dcreate2(file_id, "xT", dtype_id, dspace_id, H5P_DEFAULT, dcpl_xT_id, H5P_DEFAULT);
        if (dset_xT_id < 0)
            TEST_ERROR;
        dset_mT_id = H5Dcreate2(file_id, "mT", dtype_id, dspace_id, H5P_DEFAULT, dcpl_mT_id, H5P_DEFAULT);
        if (dset_mT_id < 0)
            TEST_ERROR;

        dset_mN_id = H5Dcreate2(file_id, "mN", dtype_id, dspace_id, H5P_DEFAULT, dcpl_mN_id, H5P_DEFAULT);
        if (dset_mN_id < 0)
            TEST_ERROR;

        /* ----- *
         * TESTS *
         * ----- */

        /* sanity check */
        if (oh_compare(dset_mx_id, dset_xx_id) != LT)
            TEST_ERROR;
        if (oh_compare(dset_mx_id, dset_xT_id) != LT)
            TEST_ERROR;

        if (oh_compare(dset_xx_id, dset_xT_id) != EQ)
            TEST_ERROR;
        if (oh_compare(dset_mx_id, dset_mT_id) != EQ)
            TEST_ERROR;
        if (oh_compare(dset_mN_id, dset_mT_id) != LT)
            TEST_ERROR;

        if (oh_compare(dset_mT_id, dset_xT_id) != LT)
            TEST_ERROR;

        /* ----------------- *
         * per-case teardown *
         * ----------------- */

        if (H5Dclose(dset_xx_id) < 0)
            TEST_ERROR;
        if (H5Dclose(dset_xT_id) < 0)
            TEST_ERROR;
        if (H5Dclose(dset_mx_id) < 0)
            TEST_ERROR;
        if (H5Dclose(dset_mT_id) < 0)
            TEST_ERROR;
        if (H5Dclose(dset_mN_id) < 0)
            TEST_ERROR;
        if (H5Fclose(file_id) < 0)
            TEST_ERROR;
        if (H5Pclose(fapl_id) < 0)
            TEST_ERROR;

    } /* for each version tested */

    /************
     * TEARDOWN *
     ************/

    if (H5Sclose(dspace_id) < 0)
        TEST_ERROR;
    if (H5Tclose(dtype_id) < 0)
        TEST_ERROR;
    if (H5Pclose(dcpl_xT_id) < 0)
        TEST_ERROR;
    if (H5Pclose(dcpl_mx_id) < 0)
        TEST_ERROR;
    if (H5Pclose(dcpl_mT_id) < 0)
        TEST_ERROR;
    if (H5Pclose(dcpl_mN_id) < 0)
        TEST_ERROR;

    PASSED();
    return SUCCEED;

error:
    H5E_BEGIN_TRY
    {
        (void)H5Sclose(dspace_id);
        (void)H5Tclose(dtype_id);
        (void)H5Pclose(dcpl_xT_id);
        (void)H5Pclose(dcpl_mx_id);
        (void)H5Pclose(dcpl_mT_id);
        (void)H5Pclose(dcpl_mN_id);
        (void)H5Dclose(dset_xx_id);
        (void)H5Dclose(dset_xT_id);
        (void)H5Dclose(dset_mx_id);
        (void)H5Dclose(dset_mT_id);
        (void)H5Dclose(dset_mN_id);
        (void)H5Fclose(file_id);
        (void)H5Pclose(fapl_id);
    }
    H5E_END_TRY;
    return FAIL;
} /* test_minimized_dset_ohdr_modification_times */

/*
 * Test minimized dataset object header with a fill value set.
 */
static herr_t
test_minimized_dset_ohdr_fillvalue_backwards_compatability(hid_t _fapl_id)
{
    char          filename[512] = "";
    const hsize_t extents[1]    = {64};  /* extents of dataspace */
    const int     fill[1]       = {343}; /* fill value of dataset */
    hid_t         file_id       = -1;
    hid_t         dtype_id      = -1;
    hid_t         dspace_id     = -1;
    hid_t         dcpl_id       = -1;
    hid_t         fapl_id       = -1;
    hid_t         dset_0_id     = -1;
    hid_t         dset_1_id     = -1;
    herr_t        ret;

    /*********
     * SETUP *
     *********/

    TESTING("minimized dset object headers with fill values and different libver support");

    fapl_id = H5Pcopy(_fapl_id);
    if (fapl_id < 0)
        TEST_ERROR;

    if (h5_fixname(FILENAME[1], fapl_id, filename, sizeof(filename)) == NULL)
        TEST_ERROR;

    dspace_id = H5Screate_simple(1, extents, extents);
    if (dspace_id < 0)
        TEST_ERROR;

    dtype_id = H5Tcopy(H5T_NATIVE_INT);
    if (dtype_id < 0)
        TEST_ERROR;

    dcpl_id = H5Pcreate(H5P_DATASET_CREATE);
    if (dcpl_id < 0)
        TEST_ERROR;

    ret = H5Pset_dset_no_attrs_hint(dcpl_id, TRUE);
    if (ret == FAIL)
        TEST_ERROR;

    ret = H5Pset_fill_value(dcpl_id, dtype_id, fill);
    if (ret == FAIL)
        TEST_ERROR;

    ret = H5Pset_libver_bounds(fapl_id, H5F_LIBVER_EARLIEST, H5F_LIBVER_LATEST);
    if (ret == FAIL)
        TEST_ERROR;

    file_id = H5Fcreate(filename, H5F_ACC_TRUNC, H5P_DEFAULT, fapl_id);
    if (file_id < 0)
        TEST_ERROR;

    dset_0_id = H5Dcreate2(file_id, "fullrange", dtype_id, dspace_id, H5P_DEFAULT, dcpl_id, H5P_DEFAULT);
    if (dset_0_id < 0)
        TEST_ERROR;

    /* Close file and re-open with different libver bounds.
     * Dataset "fullrange" must also be closed for expected reopen behavior.
     */
    if (H5Fclose(file_id) < 0)
        TEST_ERROR;
    if (H5Dclose(dset_0_id) < 0)
        TEST_ERROR;

    ret = H5Pset_libver_bounds(fapl_id, H5F_LIBVER_V18, H5F_LIBVER_LATEST);
    if (ret == FAIL)
        TEST_ERROR;

    file_id = H5Fopen(filename, H5F_ACC_RDWR, fapl_id);
    if (file_id < 0)
        TEST_ERROR;

    dset_1_id = H5Dcreate2(file_id, "upperrange", dtype_id, dspace_id, H5P_DEFAULT, dcpl_id, H5P_DEFAULT);
    if (dset_1_id < 0)
        TEST_ERROR;

    /* re-open "fullrange" dataset
     */
    dset_0_id = H5Dopen2(file_id, "fullrange", H5P_DEFAULT);
    if (dset_0_id < 0)
        TEST_ERROR;

    /*********
     * TESTS *
     *********/

    /* dset not supporting pre-1.08 should be smaller? */
    if (oh_compare(dset_1_id, dset_0_id) != LT)
        TEST_ERROR;

    /************
     * TEARDOWN *
     ************/

    if (H5Sclose(dspace_id) < 0)
        TEST_ERROR;
    if (H5Tclose(dtype_id) < 0)
        TEST_ERROR;
    if (H5Pclose(dcpl_id) < 0)
        TEST_ERROR;
    if (H5Pclose(fapl_id) < 0)
        TEST_ERROR;
    if (H5Dclose(dset_0_id) < 0)
        TEST_ERROR;
    if (H5Dclose(dset_1_id) < 0)
        TEST_ERROR;
    if (H5Fclose(file_id) < 0)
        TEST_ERROR;

    PASSED();
    return SUCCEED;

error:
    H5E_BEGIN_TRY
    {
        (void)H5Sclose(dspace_id);
        (void)H5Tclose(dtype_id);
        (void)H5Pclose(dcpl_id);
        (void)H5Pclose(fapl_id);
        (void)H5Dclose(dset_0_id);
        (void)H5Dclose(dset_1_id);
        (void)H5Fclose(file_id);
    }
    H5E_END_TRY;
    return FAIL;
} /* test_minimized_dset_ohdr_fillvalue_backwards_compatability */

/*-------------------------------------------------------------------------
 * Function:    main
 *
 * Purpose:     Exercise private object header behavior and routines
 *
 * Return:      Success: 0
 *              Failure: 1
 *
 * Programmer:  Robb Matzke
 *              Tuesday, November 24, 1998
 *
 *-------------------------------------------------------------------------
 */
int
main(void)
{
    hid_t          fapl = -1;
    hid_t          file = -1;
    H5F_t *        f    = NULL;
    const char *   env_h5_drvr;     /* File driver value from environment */
    hbool_t        single_file_vfd; /* Whether VFD used stores data in a single file */
    char           filename[1024];
    H5O_hdr_info_t hdr_info;  /* Object info */
    H5O_loc_t      oh_loc;    /* Object header locations */
    H5F_libver_t   low, high; /* File format bounds */
    time_t         time_new, ro;
    int            i;                      /* Local index variable */
    hbool_t        api_ctx_pushed = FALSE; /* Whether API context pushed */
    herr_t         ret;                    /* Generic return value */

    /* Get the VFD to use */
    env_h5_drvr = HDgetenv(HDF5_DRIVER);
    if (env_h5_drvr == NULL)
        env_h5_drvr = "nomatch";

    /* Check for VFD which stores data in multiple files */
    single_file_vfd = !h5_driver_uses_multiple_files(env_h5_drvr, 0);

    /* Reset library */
    h5_reset();
    fapl = h5_fileaccess();
    h5_fixname(FILENAME[0], fapl, filename, sizeof filename);

    /* Push API context */
    if (H5CX_push() < 0)
        FAIL_STACK_ERROR;
    api_ctx_pushed = TRUE;

    /* Loop through all the combinations of low/high library format bounds */
    for (low = H5F_LIBVER_EARLIEST; low < H5F_LIBVER_NBOUNDS; low++) {
        for (high = H5F_LIBVER_EARLIEST; high < H5F_LIBVER_NBOUNDS; high++) {
            const char *low_string;  /* Message for library version low bound */
            const char *high_string; /* Message for library version high bound */
            char        msg[80];     /* Message for file format version */

            /* Set version bounds before opening the file */
            H5E_BEGIN_TRY
            {
                ret = H5Pset_libver_bounds(fapl, low, high);
            }
            H5E_END_TRY;

            if (ret < 0) /* Invalid low/high combinations */
                continue;

            /* Display info about testing */
            low_string  = h5_get_version_string(low);
            high_string = h5_get_version_string(high);
            HDsnprintf(msg, sizeof(msg), "Using file format version: (%s, %s)", low_string, high_string);
            HDputs(msg);

            /* test on object continuation block */
            if (test_cont(filename, fapl) < 0)
                TEST_ERROR;

            /* Create the file to operate on */
            if ((file = H5Fcreate(filename, H5F_ACC_TRUNC, H5P_DEFAULT, fapl)) < 0)
                FAIL_STACK_ERROR;
            if (NULL == (f = (H5F_t *)H5VL_object(file)))
                FAIL_STACK_ERROR;
            if (H5AC_ignore_tags(f) < 0) {
                H5_FAILED();
                H5Eprint2(H5E_DEFAULT, stdout);
                goto error;
            } /* end if */

            /*
             * Test object header creation
             * (using default group creation property list only because it's convenient)
             */
            TESTING("object header creation");
            HDmemset(&oh_loc, 0, sizeof(oh_loc));
            if (H5O_create(f, (size_t)64, (size_t)0, H5P_GROUP_CREATE_DEFAULT, &oh_loc /*out*/) < 0)
                FAIL_STACK_ERROR;
            PASSED();

            /* create a new message */
            TESTING("message creation");
            time_new = 11111111;
            if (H5O_msg_create(&oh_loc, H5O_MTIME_NEW_ID, 0, 0, &time_new) < 0)
                FAIL_STACK_ERROR;
            if (1 != H5O_link(&oh_loc, 1))
                FAIL_STACK_ERROR;
            if (H5AC_prep_for_file_flush(f) < 0)
                FAIL_STACK_ERROR;
            if (H5AC_flush(f) < 0)
                FAIL_STACK_ERROR;
            if (H5AC_secure_from_file_flush(f) < 0)
                FAIL_STACK_ERROR;
            if (H5AC_expunge_entry(f, H5AC_OHDR, oh_loc.addr, H5AC__NO_FLAGS_SET) < 0)
                FAIL_STACK_ERROR;
            if (NULL == H5O_msg_read(&oh_loc, H5O_MTIME_NEW_ID, &ro))
                FAIL_STACK_ERROR;
            if (ro != time_new)
                TEST_ERROR;
            PASSED();

            /*
             * Test modification of an existing message.
             */
            TESTING("message modification");
            time_new = 33333333;
            if (H5O_msg_write(&oh_loc, H5O_MTIME_NEW_ID, 0, 0, &time_new) < 0)
                FAIL_STACK_ERROR;
            if (H5AC_prep_for_file_flush(f) < 0)
                FAIL_STACK_ERROR;
            if (H5AC_flush(f) < 0)
                FAIL_STACK_ERROR;
            if (H5AC_secure_from_file_flush(f) < 0)
                FAIL_STACK_ERROR;
            if (H5AC_expunge_entry(f, H5AC_OHDR, oh_loc.addr, H5AC__NO_FLAGS_SET) < 0)
                FAIL_STACK_ERROR;
            if (NULL == H5O_msg_read(&oh_loc, H5O_MTIME_NEW_ID, &ro))
                FAIL_STACK_ERROR;
            if (ro != time_new)
                TEST_ERROR;

            /* Make certain that chunk #0 in the object header can be encoded with a 1-byte size */
            if (H5O_get_hdr_info(&oh_loc, &hdr_info) < 0)
                FAIL_STACK_ERROR;
            if (hdr_info.space.total >= 256)
                TEST_ERROR;

            PASSED();

            /*
             * Test creation of a bunch of messages one after another to see
             * what happens when the object header overflows in core.
             * (Use 'old' MTIME message here, because it is large enough to be
             *  replaced with a continuation message (the new one is too small)
             *  and the library doesn't understand how to migrate more than one
             *  message from an object header currently - QAK - 10/8/03)
             */
            TESTING("object header overflow in memory");
            for (i = 0; i < 40; i++) {
                time_new = (i + 1) * 1000 + 1000000;
                if (H5O_msg_create(&oh_loc, H5O_MTIME_ID, 0, 0, &time_new) < 0)
                    FAIL_STACK_ERROR;
            } /* end for */
            if (H5AC_prep_for_file_flush(f) < 0)
                FAIL_STACK_ERROR;
            if (H5AC_flush(f) < 0)
                FAIL_STACK_ERROR;
            if (H5AC_secure_from_file_flush(f) < 0)
                FAIL_STACK_ERROR;
            if (H5AC_expunge_entry(f, H5AC_OHDR, oh_loc.addr, H5AC__NO_FLAGS_SET) < 0)
                FAIL_STACK_ERROR;

            /* Make certain that chunk #0 in the object header will be encoded with a 2-byte size */
            if (H5O_get_hdr_info(&oh_loc, &hdr_info) < 0)
                FAIL_STACK_ERROR;
            if (hdr_info.space.total < 256)
                TEST_ERROR;

            PASSED();

            /* Close & re-open file & object header */
            /* (makes certain that an object header in the new format that transitions
             *  between 1-byte chunk #0 size encoding and 2-byte chunk #0 size encoding
             *  works correctly - QAK)
             */
            TESTING("close & re-open object header");
            if (H5O_close(&oh_loc, NULL) < 0)
                FAIL_STACK_ERROR;
            if (H5Fclose(file) < 0)
                FAIL_STACK_ERROR;
            if ((file = H5Fopen(filename, H5F_ACC_RDWR, fapl)) < 0)
                FAIL_STACK_ERROR;
            if (NULL == (f = (H5F_t *)H5VL_object(file)))
                FAIL_STACK_ERROR;
            if (H5AC_ignore_tags(f) < 0)
                FAIL_STACK_ERROR;
            oh_loc.file = f;
            if (H5O_open(&oh_loc) < 0)
                FAIL_STACK_ERROR;
            PASSED();

            /*
             * Test creation of a bunch of messages one after another to see
             * what happens when the object header overflows on disk.
             */
            TESTING("object header overflow on disk");
            for (i = 0; i < 10; i++) {
                time_new = (i + 1) * 1000 + 10;
                if (H5O_msg_create(&oh_loc, H5O_MTIME_NEW_ID, 0, 0, &time_new) < 0)
                    FAIL_STACK_ERROR;
                if (H5AC_prep_for_file_flush(f) < 0)
                    FAIL_STACK_ERROR;
                if (H5AC_flush(f) < 0)
                    FAIL_STACK_ERROR;
                if (H5AC_secure_from_file_flush(f) < 0)
                    FAIL_STACK_ERROR;
                if (H5AC_expunge_entry(f, H5AC_OHDR, oh_loc.addr, H5AC__NO_FLAGS_SET) < 0)
                    FAIL_STACK_ERROR;
            } /* end for */
            PASSED();

            /*
             * Delete all time messages.
             */
            TESTING("message deletion");
            if (H5O_msg_remove(&oh_loc, H5O_MTIME_NEW_ID, H5O_ALL, TRUE) < 0)
                FAIL_STACK_ERROR;
            if (H5O_msg_remove(&oh_loc, H5O_MTIME_ID, H5O_ALL, TRUE) < 0)
                FAIL_STACK_ERROR;
            if (H5O_msg_read(&oh_loc, H5O_MTIME_NEW_ID, &ro))
                FAIL_STACK_ERROR;
            if (H5O_msg_read(&oh_loc, H5O_MTIME_ID, &ro))
                FAIL_STACK_ERROR;
            PASSED();

            /*
             * Constant message handling.
             * (can't write to them, but should be able to remove them)
             */
            TESTING("constant message handling");
            time_new = 22222222;
            if (H5O_msg_create(&oh_loc, H5O_MTIME_NEW_ID, H5O_MSG_FLAG_CONSTANT, 0, &time_new) < 0)
                FAIL_STACK_ERROR;
            if (H5AC_prep_for_file_flush(f) < 0)
                FAIL_STACK_ERROR;
            if (H5AC_flush(f) < 0)
                FAIL_STACK_ERROR;
            if (H5AC_secure_from_file_flush(f) < 0)
                FAIL_STACK_ERROR;
            if (H5AC_expunge_entry(f, H5AC_OHDR, oh_loc.addr, H5AC__NO_FLAGS_SET) < 0)
                FAIL_STACK_ERROR;
            if (NULL == H5O_msg_read(&oh_loc, H5O_MTIME_NEW_ID, &ro))
                FAIL_STACK_ERROR;
            if (ro != time_new)
                TEST_ERROR;
            time_new = 33333333;
            H5E_BEGIN_TRY
            {
                ret = H5O_msg_write(&oh_loc, H5O_MTIME_NEW_ID, 0, 0, &time_new);
            }
            H5E_END_TRY;
            if (ret >= 0)
                TEST_ERROR;
            if (H5O_msg_remove(&oh_loc, H5O_MTIME_NEW_ID, H5O_ALL, TRUE) < 0)
                FAIL_STACK_ERROR;
            PASSED();

            /* release resources */
            TESTING("object header closing");
            if (H5O_close(&oh_loc, NULL) < 0)
                FAIL_STACK_ERROR;
            PASSED();

            /* Close the file we created */
            if (H5Fclose(file) < 0)
                TEST_ERROR;

            /* Test reading datasets with undefined object header messages
             * and the various "fail/mark if unknown" object header message flags
             */
            HDputs("Accessing objects with unknown header messages: H5O_BOGUS_VALID_ID");
            if (single_file_vfd) {
                if (test_unknown(H5O_BOGUS_VALID_ID, filename, fapl) < 0)
                    TEST_ERROR;
            } /* end if */
            else {
                SKIPPED();
                HDputs("    Unknown header message test not supported with the current VFD.");
            } /* end else */
            HDputs("Accessing objects with unknown header messages: H5O_BOGUS_INVALID_ID");
            if (single_file_vfd) {
                if (test_unknown(H5O_BOGUS_INVALID_ID, filename, fapl) < 0)
                    TEST_ERROR;
            } /* end if */
            else {
                SKIPPED();
                HDputs("    Unknown header message test not supported with the current VFD.");
            } /* end else */

            /* Test object header creation metadata cache issues */
            if (test_ohdr_cache(filename, fapl) < 0)
                TEST_ERROR;

            if (test_minimized_dset_ohdr_attribute_addition(fapl) < 0)
                TEST_ERROR;

            if (test_minimized_dset_ohdr_size_comparisons(fapl) < 0)
                TEST_ERROR;

            if (test_minimized_dset_ohdr_with_filter(fapl) < 0)
                TEST_ERROR;

            if (test_minimized_dset_ohdr_modification_times(fapl) < 0)
                TEST_ERROR;

            if (test_minimized_dset_ohdr_fillvalue_backwards_compatability(fapl) < 0)
                TEST_ERROR;

        } /* high */
    }     /* low */

    /* Verify bad ohdr message fixes work */
    test_ohdr_badness(fapl);

    /* Verify symbol table messages are cached */
    if (h5_verify_cached_stabs(FILENAME, fapl) < 0)
        TEST_ERROR;

    if (H5FD__supports_swmr_test(env_h5_drvr)) {
        /* A test to exercise the re-read of the object header for SWMR access */
        if (test_ohdr_swmr(TRUE) < 0)
            TEST_ERROR;
        if (test_ohdr_swmr(FALSE) < 0)
            TEST_ERROR;
    }
    else
        HDputs("Skipped SWMR tests for SWMR-incompatible VFD");

    /* Pop API context */
    if (api_ctx_pushed && H5CX_pop(FALSE) < 0)
        FAIL_STACK_ERROR;
    api_ctx_pushed = FALSE;

    HDputs("All object header tests passed.");
    h5_cleanup(FILENAME, fapl);
    return 0;

error:
    HDputs("*** TESTS FAILED ***");
    H5E_BEGIN_TRY
    {
        H5Fclose(file);
    }
    H5E_END_TRY;

    if (api_ctx_pushed)
        H5CX_pop(FALSE);

    return 1;
} /* end main() */