route: drop bitrate,sample-point getters/setters from can link

These accessor functions just get/set a field of ci_data_bittiming,
which can already be get/set as a whole. It seems redundant, so drop it.

It's really important that things are principle at all (like, setting
ci_data_bittiming). It's not clear that we need such convenience
functions, if you can achieve the same result otherwise.

Yes, we have similar accessors already. I think that is not a good
approach though.

If they turn out very useful, we can still revert this patch.

1 files changed, 0 insertions, 84 deletions

diff --git a/lib/route/link/can.c b/lib/route/link/can.c
index f515f66..376c1a5 100644
--- a/lib/route/link/can.c
+++ b/lib/route/link/can.c
@@ -839,90 +839,6 @@ int rtnl_link_can_set_data_bittiming(struct rtnl_link *link,
 	return 0;
 }
 
-/**
- * Get CAN FD device data bit-timing
- * @arg link            Link object
- * @arg data_bitrate		CAN FD data bitrate
- *
- * @return 0 on success or a negative error code
- */
-int rtnl_link_can_get_data_bitrate(struct rtnl_link *link, uint32_t *data_bitrate)
-{
-	struct can_info *ci = link->l_info;
-
-	IS_CAN_LINK_ASSERT(link);
-	if (!data_bitrate)
-		return -NLE_INVAL;
-
-	if (ci->ci_mask & CAN_HAS_DATA_BITTIMING)
-		*data_bitrate = ci->ci_data_bittiming.bitrate;
-	else
-		return -NLE_AGAIN;
-
-	return 0;
-}
-
-/**
- * Set CAN FD device data bit-rate
- * @arg link            Link object
- * @arg data_bitrate    CAN FD data bitrate
- *
- * @return 0 on success or a negative error code
- */
-int rtnl_link_can_set_data_bitrate(struct rtnl_link *link, uint32_t data_bitrate)
-{
-	struct can_info *ci = link->l_info;
-
-	IS_CAN_LINK_ASSERT(link);
-
-	ci->ci_data_bittiming.bitrate = data_bitrate;
-	ci->ci_mask |= CAN_HAS_DATA_BITTIMING;
-
-	return 0;
-}
-
-/**
- * Get CAN FD device data sample point
- * @arg link	Link object
- * @arg sp		CAN FD sample point
- *
- * @return 0 on success or a negative error code
- */
-int rtnl_link_can_get_data_sample_point(struct rtnl_link *link, uint32_t *sp)
-{
-	struct can_info *ci = link->l_info;
-
-	IS_CAN_LINK_ASSERT(link);
-	if (!sp)
-		return -NLE_INVAL;
-
-	if (ci->ci_mask & CAN_HAS_DATA_BITTIMING)
-		*sp = ci->ci_data_bittiming.sample_point;
-	else
-		return -NLE_AGAIN;
-
-	return 0;
-}
-
-/**
- * Set CAN FD device data sample point
- * @arg link	Link object
- * @arg sp		CAN FD sample point
- *
- * @return 0 on success or a negative error code
- */
-int rtnl_link_can_set_data_sample_point(struct rtnl_link *link, uint32_t sp)
-{
-	struct can_info *ci = link->l_info;
-
-	IS_CAN_LINK_ASSERT(link);
-
-	ci->ci_data_bittiming.sample_point = sp;
-	ci->ci_mask |= CAN_HAS_DATA_BITTIMING;
-
-	return 0;
-}
-
 /** @} */
 
 /**