cache: don't decide cache operation based on NL_OBJ_DUMP in ce_flags

Objects used to be marked as NL_OBJ_DUMP in ce_flags. Then,
later, the flag was evaluated to decide whether:

  - append/prepend the object in the hash-table (relevant for for routes)
  - ignore duplicate nexthops for routes during oo_update().

That becomes for example rather confusing for pickup_checkdup_cb()
which marks the object as NL_OBJ_DUMP for nl_cache_add(), but not during
nl_object_update() (why?).

Another example where that is confusing is nl_cache_move(), which would
append/prepend the object based on (obj->ce_msgflags & NLM_F_APPEND).
Is that correct behavior? Maybe, maybe it doesn't matter. Either way
it is confusing to have the decision whether to append/prepend the
object in the hash-table 3 functions down the call stack, instead
as explict argument to __cache_add().

Instead, callers must tell nl_cache_add() whether to append the flag,
and they must tell nl_object_update() whether the object was received
during a dump.

Signed-off-by: Thomas Haller <thaller@redhat.com>

0 files changed, 0 insertions, 0 deletions