| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
| |
The NOTE refers to an ancient libnl3 version. It is not relevant
anymore. Drop it.
Instead, print some summary overview from the configuration.
|
|
|
|
|
|
|
|
|
| |
We get this warning:
aclocal: warning: couldn't open directory 'm4': No such file or directory
Avoid it, by letting "doc/configure.ac" use the top-level m4 directory
too.
|
|
|
|
|
| |
configure.ac:67: warning: The macro `AM_PROG_LIBTOOL' is obsolete.
configure.ac:67: You should run autoupdate.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Silence warnings with "-Wno-portability".
Makefile.am:1130: warning: '%'-style pattern rules are a GNU make extension
Makefile.am:1131: warning: dir $@: non-POSIX variable name
Makefile.am:1131: (probably a GNU make extension)
Makefile.am:1134: warning: '%'-style pattern rules are a GNU make extension
Makefile.am:1137: warning: patsubst %,%.build-headers-test.o,$(public_headers: non-POSIX variable name
Makefile.am:1137: (probably a GNU make extension)
We care about portability, but only to the extend that we test configurations
via CI. As all our current CI passes, the warning is bogus and not something we
will fix.
If you come up in a situation where this is a problem, then we have a real
scenario at hand and something to fix. Unless that happens, we target a real
implementation and not the make specification.
|
|\
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Change the license for a few files from GPL-2.0-only to
LGPL-2.1-only.
All relevant contributions seems to have been made by Thomas Graf. I
presume, this was just a mistake in the license header, as the project
as a whole is LGPL licensed. Thomas as working for Red Hat at the time,
maybe the copyright for the code is with Red Hat.
In any case, the wrong licensing needs to be fixed. If there are any
objections to this, the offending code needs to be removed. Please reach
out in that case.
https://github.com/thom311/libnl/pull/357
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
In commit ef858fb492df ('- Reworked the classifier interface. - Added
initial ematch support - Added support for the basic classifier - Added
support for the cgroup classifier'), the license headers were added as
GPL-2.0-only. That is in conflict with the licences of the project and a
problem.
We would either have to delete the code, or "change" the license.
The file only had (relevant) contributions by Thomas Graf. There are
some trivial modifications by myself (Thomas Haller), and I agree with
this change. There is also a small change by another contributor, which
does seem trivial enough to not prevent changing the license:
- 4ff512b05456 [Cong Wang] ('correct --protocol option for nl-cls-* utilities')
- c52087601198 [Peter Wu] ('trivial: whitespace-only fixes for src and lib')
- cee0b1b50c2e [Yegor Yefremov] ('Add SPDX identifiers')
See `gitk src/nl-cls-add.c`.
|
|/
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In commit 5e732ad075e5 ('New set of address management tools'), the
license headers were added/changed as GPL-2.0-only. That is in conflict
with the licences of the project and a problem.
We would either have to delete the code, or "change" the license.
The files only had (relevant) contributions by Thomas Graf. There are
some trivial modifications by myself (Thomas Haller), and I agree with
this change. There are also small changes by another contributors, which
seem trivial enough to not prevent changing the license:
- 7701c8572fa4 [Pavel Roskin] ('Make some functions and global variables static')
- c52087601198 [Peter Wu] ('trivial: whitespace-only fixes for src and lib')
- cee0b1b50c2e [Yegor Yefremov] ('Add SPDX identifiers')
See `gitk src/nl-addr-{add,delete,list}.c`.
|
|\ |
|
| | |
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
srandom() and random() are a code smell, because they are not thread safe.
Avoid its usage, even if this was only for testing. Even in testing code,
we don't want to find those functions and have to reason why they are fine
for testing. Just don't.
Arguably, _nltst_rand_u32() calls jrand48(), which (in glibc) is
possibly not thread-safe either. But that is only one place for
investigation, instead of 3.
Also, _nltst_rand_u32() honors NLTST_SEED_RAND to generate a
reproducible sequence of random numbers.
|
| |
| |
| |
| | |
Avoid non-threadsafe libc API.
|
| | |
|
|/ |
|
|
|
|
|
|
| |
https://github.com/thom311/libnl/issues/356
Fixes: 780d06ae8bee ('route: add nh type')
|
| |
|
|\ |
|
| | |
|
| |
| |
| |
| | |
$ ./tools/clang-format.sh
|
|/
|
|
|
|
|
| |
Taken from linux kernel v6.4 at [1]. The file is unmodified, except for the
"ForEachMacros".
[1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/.clang-format?id=6995e2de6891c724bfeb2db33d7b87775f913ad1
|
|
|
|
|
|
| |
As we now copy all linux headers, and we have include/linux-private
in our include search path, just include the linux headers as we commonly
do.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It doesn't work well, to only include some parts of the linux headers.
For example, <linux/ipv6.h> includes <linux/stddef.h>, which previously
wasn't copied. Worse, <linux/ipv6.h> depends on some recent defines in
<linux/stddef.h>, so we cannot just mix kernel headers from different
versions.
Import all the used <linux/*> kernel headers. Note that architecture
specific headers from "<asm/*" and "<asm-generic/*" are not copied.
Taken from v6.4 (6995e2de6891c724bfeb2db33d7b87775f913ad1).
Reimport via
cd /data/src/linux
make headers_install ARCH=i386 INSTALL_HDR_PATH=/tmp/Linux/
cd /data/src/libnl3
for h in $(cd include/linux-private/; git ls-files .); do \
/bin/cp /tmp/Linux/include/$h include/linux-private/$h ; \
done
|
|
|
|
| |
Taken from v6.4 (6995e2de6891c724bfeb2db33d7b87775f913ad1).
|
| |
|
|
|
|
|
| |
libnl3 itself needs to be build with a C compiler. Drop the unnecessary
"extern "C"" parts from internal code.
|
| |
|
|
|
|
| |
This is currently unused.
|
|
|
|
| |
to be self-contained
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This tool had a GPL-2.0-only license text when it was added.
That is not what we require for libnl3 contributions.
Since being added, the file was only touched by me (Thomas Haller) and
Yegor Yefremov. Those are all trivial contributions.
This leaves Joe Damato, who initially contributed the file. Joe
agrees with this adjustment of the license (Thanks!!).
Note that there is also a line:
Copyright (c) 2013 Sassano Systems LLC <joe@sassanosystems.com>
Apparently, the copyright for the contribution is also with Joe, so
there is no further problem.
Fixes: c97c8c2bfdb0 ('Add idiag-socket-details')
https://github.com/thom311/libnl/pull/354
|
| |
|
|
|
|
|
|
| |
I don't think we want to ignore patch files. Why should we?
This reverts commit f55ef93d1eb9d792af2a3b79c055ee21bf14e9ea.
|
| |
|
|
|
|
| |
Fixes: 780d06ae8bee ('route: add nh type')
|
|
|
|
|
|
|
|
|
| |
So "rtnl_link_info_ops_get" didn't actually work with libnl-3.7.
Fix for 3.8.
https://github.com/thom311/libnl/issues/350
Fixes: 2e0d7f85d2ae ('lib: add rtnl_link_info_ops_get() and take lock for rtnl_link_info_ops's io_refcnt')
|
|\ |
|
| | |
|
| |
| |
| |
| |
| | |
For no strong reason, we include the public netlink headers with
<> instead of "". Be consistent.
|
| | |
|
| |
| |
| |
| |
| |
| |
| | |
We have copies of the linux headers in include/linux-private.
For those files, include the copies explicitly.
No practice there is no difference, since we build with :-Ilinux-private".
|
| | |
|
| | |
|
| | |
|
|/ |
|
|\ |
|
| | |
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
In an autotools project, <config.h> should be included as very first thing
in almost all cases. We also want include other stuff, in particular
"include/base", which contains our own extensions on top of plain C (it
is thus applicable to all our C modules).
Add a "nl-default.h", which can be included as first and prepares a base
for each C source.
Additionally, since header files are never compiled directly (only indirectly
by being included), they can rely that "nl-default.h" is always available.
|
| |
| |
| |
| |
| |
| |
| | |
It seems "config.h" is the more common name for the autotools generated
header. In any case, it should not be under "lib", because lib is
specifically about libnl-3 and similar libraries. It's awkward for
modules under src to include from lib.
|
| |
| |
| |
| |
| | |
Move all the declarations from "netlink-private/types.h" to places
closer to where they are used.
|
| |
| |
| |
| |
| | |
Naming is just so important to understand what this is.
This name is better.
|