summaryrefslogtreecommitdiffstats
path: root/lib/route
Commit message (Collapse)AuthorAgeFilesLines
* lib/route: add support for bridge mstiRonan Dalton2024-10-101-27/+494
| | | | https://github.com/thom311/libnl/pull/409
* lib/route: add support for bridge info booloptsRonan Dalton2024-09-181-0/+81
| | | | Add support for the IFLA_BR_MULTI_BOOLOPT bridge link attribute.
* lib/route: extend bridge info supportRonan Dalton2024-09-161-0/+174
| | | | | | | | Add support for the following attributes for bridge links: IFLA_BR_STP_STATE IFLA_BR_MCAST_ROUTER IFLA_BR_MCAST_SNOOPING
* lib/route: add missing bridge info getter functionsRonan Dalton2024-09-161-0/+95
| | | | | | There are bridge info setter functions for nf_call_iptables, nf_call_ip6tables and nf_call_arptables, but no corresponding getter functions, so add them.
* lib/route: add rtnl_neigh ext flags supportRonan Dalton2024-09-161-6/+70
| | | | | | | | | | The amount of flags that could be stored in the ndm_flags field of ndmsg was limited to 8, so the kernel introduced a new attribute so more flags could be represented in netlink messages. Add support for the extended neighbour flags. https://github.com/thom311/libnl/pull/405
* route: add support for getting permanent mac address of linkAntonio Prcela2024-09-122-0/+34
| | | | https://github.com/thom311/libnl/pull/404
* lib/route: extend bridge flagsRonan Dalton2024-09-121-22/+120
| | | | | | | | | | | | | | | | | | Add support for the following bridge flags: IFLA_BRPORT_PROXYARP IFLA_BRPORT_PROXYARP_WIFI IFLA_BRPORT_MCAST_FLOOD IFLA_BRPORT_MCAST_TO_UCAST IFLA_BRPORT_VLAN_TUNNEL IFLA_BRPORT_BCAST_FLOOD IFLA_BRPORT_NEIGH_SUPPRESS IFLA_BRPORT_ISOLATED IFLA_BRPORT_LOCKED IFLA_BRPORT_MAB IFLA_BRPORT_NEIGH_VLAN_SUPPRESS https://github.com/thom311/libnl/pull/403
* link/bonding: implement parsing link typeJonas Gorski2024-08-301-0/+54
| | | | | | | Now that we can compare and clone, we can implement parsing bond type links. Add parsing for all supported types. Signed-off-by: Jonas Gorski <jonas.gorski@bisdn.de>
* link/bonding: implement comparing bond linksJonas Gorski2024-08-301-0/+21
| | | | | | Implement comparing two bond links to know if their attributes changed. Signed-off-by: Jonas Gorski <jonas.gorski@bisdn.de>
* link/bonding: implement io_clone()Jonas Gorski2024-08-301-0/+21
| | | | | | | Implement the missing rtnl_link_info_ops::io_clone(), so that cloning a bond link will retain its data. Signed-off-by: Jonas Gorski <jonas.gorski@bisdn.de>
* link/bonding: add getters for attributesJonas Gorski2024-08-271-3/+133
| | | | | | | In preparation of parsing bond link attributes, add getters for all supported attributes. Signed-off-by: Jonas Gorski <jonas.gorski@bisdn.de>
* link/bonding: rename bn_mask to ce_maskJonas Gorski2024-08-271-11/+11
| | | | | | rename bn_mask to ce_mask to allow the use of attr macros. Signed-off-by: Jonas Gorski <jonas.gorski@bisdn.de>
* link: link_msg_parser(): keep link info instead of release and reacquireJonas Gorski2024-08-191-5/+1
| | | | | | | | | | | | | | | | | | | | | | Calling release_link_info() will call io_free() for rtnl_link::l_info was allocated just a few lines before as a side effect of rtnl_link_set_type(). Apart from doing needless memory churn, this will also leave the link with l_info set to NULL if the link type does not provide a io_parse() function. Assuming the memory leak mentioned in bfee88b8b0a9 ("route: fix memory leak of l_info_ops in link_msg_parser()") was a double reference taken by calling rtnl_link_info_ops_lookup() twice, once via rtnl_link_set_type(), and once directly, replace the lookup() / release() lookup() with a single lookup() and then reuse the populated rtnl_link::l_info_ops pointer. Fixes: bfee88b8b0a9 ("route: fix memory leak of l_info_ops in link_msg_parser()") Signed-off-by: Jonas Gorski <jonas.gorski@bisdn.de> https://github.com/thom311/libnl/pull/396
* all: fix and enable "-Wsign-compare" warningThomas Haller2024-05-2919-38/+49
|
* build: use AC_USE_SYSTEM_EXTENSIONS instead of defining _GNU_SOURCEThomas Haller2024-05-292-2/+6
| | | | | | | | | Don't define _GNU_SOURCE on the command line. Instead, use AC_USE_SYSTEM_EXTENSIONS which embeds it in "include/config.h". Also, fix flex files to ensure "include/config.h" is included as first, and that we get _GNU_SOURCE defined before including anything else. This is achieved by include "include/nl-default.h" as %top{}.
* build: cleanup defining SYSCONFDIR on command lineThomas Haller2024-05-291-1/+1
| | | | | | | | | | | | | | | | Optimally, ./configure defines things in include/config.h. However, that does not work well with defines that contain path names (see [1]). Continue to use "-D" command line option. However, factor out the definition to one place. Also, rename from SYSCONFDIR to _NL_SYSCONFDIR_LIBNL. Note that "src_lib_libnl_cli_3_la_CPPFLAGS" defined to -DSYSCONFDIR=\"$(sysconfdir)\", without the "libnl" subdirectory. In this case, the define was never used. The change doesn't matter. [1] https://www.gnu.org/software/autoconf/manual/autoconf-2.63/html_node/Installation-Directory-Variables.html
* lib: add internal _nla_len() helperThomas Haller2024-05-291-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | nla_len() has no valid reason to fail or return a negative number. Callers are not allowed to call this on an invalid structure. They usually would call nla_validate() first. However, as it returns a signed "int", coverity assumes that in some cases the value could be negative. That results in coverity warning like Error: INTEGER_OVERFLOW (CWE-190): libnl-3.9.0/lib/route/nh.c:339: tainted_data_return: Called function "nla_len(tb[NHA_GROUP])", and a possible return value may be less than zero. libnl-3.9.0/lib/route/nh.c:339: cast_underflow: An assign of a possibly negative number to an unsigned type, which might trigger an underflow. libnl-3.9.0/lib/route/nh.c:340: overflow: The expression "len / 8UL" is deemed underflowed because at least one of its arguments has underflowed. libnl-3.9.0/lib/route/nh.c:340: cast_overflow: An assign that casts to a different type, which might trigger an overflow. libnl-3.9.0/lib/route/nh.c:342: overflow_sink: "size", which might have underflowed, is passed to "rtnl_nh_grp_info(size, (struct nexthop_grp const *)data, &nh_group)". # 340| size = len / sizeof(struct nexthop_grp); # 341| # 342|-> err = rtnl_nh_grp_info(size, (const struct nexthop_grp *)data, # 343| &nh_group); # 344| if (err < 0) { Add an internal _nla_len() with an API that clearly cannot return negative values. Also, add _nl_assert() which in debug builds do some consistency checks on the argument. https://issues.redhat.com/browse/RHEL-34299
* route: treat routes with via nexthops as universe scoped as wellJonas Gorski2024-05-291-1/+1
| | | | | | | | | RTA_VIA is a RTA_GATEWAY with added address family, so we should treat them them equivalent for guessing the scope. Signed-off-by: Jonas Gorski <jonas.gorski@bisdn.de> https://github.com/thom311/libnl/pull/389
* route: add missing priority to route_keygen() debug printJonas Gorski2024-05-171-4/+5
| | | | | | | | | | | | | | | | | | | | | | | Route priority is part of the hash key calculation, but the debug print omitted it. This could cause seemingly identical values have different hash values. Fix this by also printing the route priority, and reformat according to clang-format. Before: DBG<5>lib/route/route_obj.c:378 route_keygen: route 0x55fd326f7d50 key (fam 10 tos 0 table 254 addr fe80::/64) keysz 26 hash 0x18c DBG<5>lib/route/route_obj.c:378 route_keygen: route 0x55fd326f7fa0 key (fam 10 tos 0 table 254 addr fe80::/64) keysz 26 hash 0x278 After: DBG<5>lib/route/route_obj.c:378 route_keygen: route 0x558cfde91d50 key (fam 10 tos 0 table 254 prio 256 addr fe80::/64) keysz 26 hash 0x18c DBG<5>lib/route/route_obj.c:378 route_keygen: route 0x558cfde91fa0 key (fam 10 tos 0 table 254 prio 1024 addr fe80::/64) keysz 26 hash 0x278 Signed-off-by: Jonas Gorski <jonas.gorski@bisdn.de> https://github.com/thom311/libnl/pull/388
* route: move "struct rtnl_nexthop" to "nl-priv-dynamic-route"Thomas Haller2024-05-171-15/+0
| | | | | | | | rtnl_route_get_nexthops() returns the list of nexthops, but that is not usable without access to the rtnh_list field. We want to use that from tests. Move to another header (but still not public API).
* route: expose nexthop id attributeJonas Gorski2024-05-171-1/+34
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Routes may reference a nexthop (group) via the new nexthop API by its ID, so add accessors for setting and getting it. Referencing a nexthop is mutually exclusive to specifiying nexthops in the route, so make sure we do not do that when creating netlink messages (which may exist both, since netlink messages from the kernel contain both unless 'nexthop_compat_mode' is disabled). $ ip -6 r 2001:db8:3::/64 nhid 20 metric 1024 pref medium nexthop via 2001:db8:1::2 dev v0 weight 1 nexthop via 2001:db8:2::2 dev v1 weight 1 Before: $ nl-route-list inet6 2001:db8:3::/64 table main type unicast via 2001:db8:1::2 dev v0 via 2001:db8:2::2 dev v1 After: $ nl-route-list inet6 2001:db8:3::/64 table main type unicast nhid 20 via 2001:db8:1::2 dev v0 via 2001:db8:2::2 dev v1 Signed-off-by: Jonas Gorski <jonas.gorski@bisdn.de> https://github.com/thom311/libnl/pull/386
* route: drop unused fields from "struct rtnl_route"Thomas Haller2024-05-171-2/+0
|
* route: use the new helper function for comparing nexthopsJonas Gorski2024-05-141-12/+4
| | | | | | | | | | | | | | | | When a route is created while the interface has no link, we get a notification with the route and the nexthop having the flag LINKDOWN. If the interface later gets a link, we do not get a route notification about it, so the route and nexthop stay at LINKDOWN in the libnl cache. If the route then gets removed again, the to be removed route will not have the LINKDOWN flag anymore, which then can break comparison of the nexthop(s). So use the new nexthop identical helper to avoid this scenario. Signed-off-by: Jonas Gorski <jonas.gorski@bisdn.de>
* nexthop: add a identical helper functionJonas Gorski2024-05-141-0/+17
| | | | | | | | | | | | | | | Not all attributes of a nexthop are id attributes, e.g. the flags will contain state (LINKDOWN, DEAD) of the attached link about which the kernel will not send route updates. Likewise, the weight may not exist when processing an ECMP IPv6 route update which only contains a single nexthop. Since rtnl_nexthop isn't a first class cache object, we cannot use nl_object_identical(), so add a separate identical helper function which compares only fixed attributes. Signed-off-by: Jonas Gorski <jonas.gorski@bisdn.de>
* route: fix IPv6 ecmp route deleted nexthop matchingJonas Gorski2024-05-071-1/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When the kernel sends a ECMP route update with just the deleted nexthop, the nexthop will have no associated weight, and its flags may indicate that it is dead: route_update: RTM_DELROUTE new route: inet6 default table main type unicast <DEAD,> scope global priority 0x400 protocol 0x9 nexthop via fe80::b226:28ff:fe62:8841 dev port4 <dead,> old route: inet6 default table main type unicast scope global priority 0x400 protocol 0x9 nexthop via fe80::b226:28ff:fe62:8841 dev port4 weight 0 <> nexthop via fe80::fa8e:a1ff:fee0:8344 dev port49 weight 0 <> nexthop via fe80::b226:28ff:fe62:d400 dev port3 weight 0 <> nexthop via fe80::fa8e:a1ff:fee0:8349 dev port54 weight 0 <> Since we are comparing the nexthops strictly with all attributes, we can never match the deleted nexthop. This causes libnl to fail to remove the deleted nexthop from the route, and consequently send out a nop-update and a desync of the route in the cache and in the kernel. Fix this by ignoring NH_ATTR_FLAGS (0x1) and NH_ATTR_WEIGHT (0x2) when comparing nexthops to properly match the deleted one. Fixes: 29b71371e764 ("route cache: Fix handling of ipv6 multipath routes") Signed-off-by: Jonas Gorski <jonas.gorski@bisdn.de> https://github.com/thom311/libnl/pull/382
* route: avoid compiler warning about calloc() arguments in ↵Thomas Haller2024-05-061-1/+1
| | | | | | | | | | | rtnl_netem_set_delay_distribution() CC lib/route/qdisc/libnl_route_3_la-netem.lo lib/route/qdisc/netem.c: In function 'rtnl_netem_set_delay_distribution': lib/route/qdisc/netem.c:975:39: error: 'calloc' sizes specified with 'sizeof' in the earlier argument and not in the later argument [-Werror=calloc-transposed-args] 975 | line = (char *) calloc(sizeof(char), len + 1); | ^~~~ lib/route/qdisc/netem.c:975:39: note: earlier argument should specify number of elements, later size of each element
* core: always define statements for NL_DBG()Thomas Haller2024-04-222-6/+0
| | | | | | | | | | Conditionally defining to nothing, means that the compiler doesn't see the print statement without NL_DEBUG. In turn, we lack checking of the statement by the compiler. Instead, add an "if (NL_DEBUG)" around it. Since NL_DEBUG is a constant, the compiler will optimize out all the code of the statement, while still checking it.
* build: always define NL_DEBUGThomas Haller2024-04-222-3/+3
| | | | | | | | | | Checking conditional defines with #ifdef is error prone because we don't get a compiler warning when the define wrongly is missing. Instead, always define it to either 0 or 1. The benefit is also that now we can use NL_DEBUG in C (not only in the preprocessor).
* all: use defines for attributesThomas Haller2024-04-222-2/+2
| | | | We have those defines. Use them throughout.
* route/bison: include "nl-default.h" in lex/yacc filesThomas Haller2024-04-223-1/+6
| | | | | | | | | | | For building all of our source files, we should include first "config.h". This ensures that we have for example NL_DEBUG available. Actually, "config.h" is included by "nl-default.h". In turn this means, all our source files should first include "nl-default.h", which drags in a set of default headers. Fix the lex/yacc files for that.
* route: add support for layer 3 filtering on bridgesCordell O'Leary2024-04-031-0/+96
| | | | https://github.com/thom311/libnl/pull/373
* tests: add test for bridge vlan attributes.Cordell O'Leary2024-02-291-4/+4
|
* route: add support for vlan filtering on bridge ports.Cordell O'Leary2024-02-292-8/+386
|
* route: Add support to set ageing time for dynamic bridge table entriesCordell O'Leary2024-02-291-0/+58
|
* route/tc: avoid integer overflow in rtnl_tc_calc_cell_log()Thomas Haller2023-12-041-2/+2
| | | | | | | | | | | | Coverity doesn't like this. Workaround. Error: CPPCHECK_WARNING (CWE-190): [#def97] libnl-3.8.0/lib/route/tc.c:681: error[integerOverflow]: Signed integer overflow for expression '1<<i'. # 679| # 680| for (i = 0; i < 32; i++) # 681|-> if ((1 << i) == cell_size) # 682| return i; # 683|
* route/cls: add get/take wrappers for rtnl_act_append()Thomas Haller2023-12-015-21/+14
| | | | | | | | | | | | rtnl_act_append() either takes ownership of the argument, or does nothing (on error). This pattern is hard to get right. In the past, there were various bugs at this place. Add two wrappers _rtnl_act_append_get() and _rtnl_act_append_take() which consistently don't take ownership of the pointer or take it. Also, in functions like rtnl_flower_append_action() only set the mask after successfully modifying the data.
* route/cls: fix leak in error handling of rtnl_flower_append_action()Thomas Haller2023-12-011-1/+5
| | | | | | Using rtnl_act_append() correctly is hard. Fixes: ef46de143206 ('route/cls: add flower classifier')
* route: fix just introduced use-after-free in rtnl_act_parse()Thomas Haller2023-12-011-0/+2
| | | | Fixes: 105a6be10a5f ('route: use cleanup macro in rtnl_act_parse()')
* route: use cleanup macro in rtnl_act_parse()Thomas Haller2023-12-011-28/+19
|
* route: fix memleak in rtnl_act_parse()Thomas Haller2023-12-011-1/+1
| | | | | | | | | | | | | | | | | | | Coverity warns: Error: RESOURCE_LEAK (CWE-772): [#def2] libnl-3.8.0/lib/route/act.c:421: alloc_fn: Storage is returned from allocation function "rtnl_act_alloc". libnl-3.8.0/lib/route/act.c:421: var_assign: Assigning: "act" = storage returned from "rtnl_act_alloc()". libnl-3.8.0/lib/route/act.c:426: var_assign: Assigning: "tc" = "act". libnl-3.8.0/lib/route/act.c:438: noescape: Resource "tc" is not freed or pointed-to in "rtnl_tc_set_kind". libnl-3.8.0/lib/route/act.c:455: leaked_storage: Variable "tc" going out of scope leaks the storage it points to. libnl-3.8.0/lib/route/act.c:455: leaked_storage: Variable "act" going out of scope leaks the storage it points to. # 453| tc_act_stats_policy); # 454| if (err < 0) # 455|-> return err; # 456| # 457| if (tb3[TCA_STATS_BASIC]) { Fixes: 05bd6366387c ('add support for TC action statistics')
* route/can: implement can_device_statsJob Feikens2023-12-011-5/+54
| | | | | | | Adds the rtnl_link_can_get_device_stats function to get xstats of a CAN-bus link as a can_device_stats struct. https://github.com/thom311/libnl/pull/368
* route/link: add bonding interface options set rtnl apisLokesh Dhoundiyal2023-10-301-0/+70
| | | | | | | [thaller@redhat.com: fixed wrong variable name in code and reworded commit message.] https://github.com/thom311/libnl/pull/363
* clang-format: reformat files with new formatThomas Haller2023-08-173-25/+25
| | | | $ ./tools/clang-format.sh
* include: use <linux/$file> instead of <linux-private/linux/$file>Thomas Haller2023-08-0831-38/+38
| | | | | | As we now copy all linux headers, and we have include/linux-private in our include search path, just include the linux headers as we commonly do.
* include/linux: update all linux headersThomas Haller2023-08-081-2/+3
| | | | Taken from v6.4 (6995e2de6891c724bfeb2db33d7b87775f913ad1).
* all: drop "extern "C"" from internal codeThomas Haller2023-08-072-16/+0
| | | | | libnl3 itself needs to be build with a C compiler. Drop the unnecessary "extern "C"" parts from internal code.
* include: don't explicitly include headers from "nl-default.h"Thomas Haller2023-08-032-4/+0
|
* include: include private linux headers with explicit pathThomas Haller2023-08-0330-37/+39
| | | | | | | We have copies of the linux headers in include/linux-private. For those files, include the copies explicitly. No practice there is no difference, since we build with :-Ilinux-private".
* include: drop "netlink-private/netlink.h" and move declarationsThomas Haller2023-08-0290-170/+93
|
* all: cleanup includes and use "nm-default.h"Thomas Haller2023-08-0283-118/+372
|
generated by cgit v0.12 at 2025-04-06 07:48:13 (GMT)