From a70f789a79d734979af8610dadb3e2ee42e6b6ee Mon Sep 17 00:00:00 2001 From: Thomas Haller Date: Fri, 1 Dec 2023 17:15:13 +0100 Subject: route: fix memleak in rtnl_act_parse() Coverity warns: Error: RESOURCE_LEAK (CWE-772): [#def2] libnl-3.8.0/lib/route/act.c:421: alloc_fn: Storage is returned from allocation function "rtnl_act_alloc". libnl-3.8.0/lib/route/act.c:421: var_assign: Assigning: "act" = storage returned from "rtnl_act_alloc()". libnl-3.8.0/lib/route/act.c:426: var_assign: Assigning: "tc" = "act". libnl-3.8.0/lib/route/act.c:438: noescape: Resource "tc" is not freed or pointed-to in "rtnl_tc_set_kind". libnl-3.8.0/lib/route/act.c:455: leaked_storage: Variable "tc" going out of scope leaks the storage it points to. libnl-3.8.0/lib/route/act.c:455: leaked_storage: Variable "act" going out of scope leaks the storage it points to. # 453| tc_act_stats_policy); # 454| if (err < 0) # 455|-> return err; # 456| # 457| if (tb3[TCA_STATS_BASIC]) { Fixes: 05bd6366387c ('add support for TC action statistics') --- lib/route/act.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/route/act.c b/lib/route/act.c index ffee827..e5bdce0 100644 --- a/lib/route/act.c +++ b/lib/route/act.c @@ -452,7 +452,7 @@ int rtnl_act_parse(struct rtnl_act **head, struct nlattr *tb) err = nla_parse_nested(tb3, TCA_STATS_MAX, tb2[TCA_ACT_STATS], tc_act_stats_policy); if (err < 0) - return err; + goto err_free; if (tb3[TCA_STATS_BASIC]) { struct gnet_stats_basic bs; -- cgit v0.12