diff options
| author | Eric Siegerman <pub08-git@davor.org> | 2017-02-14 19:17:06 (GMT) |
|---|---|---|
| committer | Eric Siegerman <pub08-git@davor.org> | 2017-02-14 19:17:06 (GMT) |
| commit | b89cac7b2e92b792af98bb0a12e4d14684d07629 (patch) | |
| tree | 61839b45c434b67fdcc849dc998305c093b5f129 /tests | |
| parent | 7e57c398c1b23f1631f690e0154ee4bee98e5f71 (diff) | |
| download | lz4-b89cac7b2e92b792af98bb0a12e4d14684d07629.zip lz4-b89cac7b2e92b792af98bb0a12e4d14684d07629.tar.gz lz4-b89cac7b2e92b792af98bb0a12e4d14684d07629.tar.bz2 | |
Don't use "foo && false || true"
Replace it with either:
test ! -f $FILE_THAT_SHOULD_NOT_EXIST
or:
! $COMMAND_THAT_SHOULD_FAIL
as appropriate.
Diffstat (limited to 'tests')
| -rw-r--r-- | tests/Makefile | 38 |
1 files changed, 19 insertions, 19 deletions
diff --git a/tests/Makefile b/tests/Makefile index 77e6ae7..ebab278 100644 --- a/tests/Makefile +++ b/tests/Makefile @@ -236,17 +236,17 @@ test-lz4-basic: lz4 datagen unlz4 lz4cat ./datagen -g256MB | $(LZ4) -vqB4D | $(LZ4) -t @echo "hello world" > tmp $(LZ4) --rm -f tmp - ls -ls tmp && false || true # must fail (--rm) - ls -ls tmp.lz4 - $(PRGDIR)/lz4cat tmp.lz4 # must display hello world - ls -ls tmp.lz4 + test ! -f tmp # must fail (--rm) + test -f tmp.lz4 + $(PRGDIR)/lz4cat tmp.lz4 # must display hello world + test -f tmp.lz4 $(PRGDIR)/unlz4 --rm tmp.lz4 - ls -ls tmp - ls -ls tmp.lz4 && false || true # must fail (--rm) - ls -ls tmp.lz4.lz4 && false || true # must fail (unlz4) - $(PRGDIR)/lz4cat tmp # pass-through mode - ls -ls tmp - ls -ls tmp.lz4 && false || true # must fail (lz4cat) + test -f tmp + test ! -f tmp.lz4 # must fail (--rm) + test ! -f tmp.lz4.lz4 # must fail (unlz4) + $(PRGDIR)/lz4cat tmp # pass-through mode + test -f tmp + test ! -f tmp.lz4 # must fail (lz4cat) $(LZ4) tmp # creates tmp.lz4 $(PRGDIR)/lz4cat < tmp.lz4 > tmp3 # checks lz4cat works with stdin (#285) $(DIFF) -q tmp tmp3 @@ -262,22 +262,22 @@ test-lz4-hugefile: lz4 datagen test-lz4-testmode: lz4 datagen @echo "\n ---- bench mode ----" - $(LZ4) -bi1 + $(LZ4) -bi1 @echo "\n ---- test mode ----" - ./datagen | $(LZ4) -t && false || true - ./datagen | $(LZ4) -tf && false || true + ! ./datagen | $(LZ4) -t + ! ./datagen | $(LZ4) -tf @echo "\n ---- pass-through mode ----" - ./datagen | $(LZ4) -d > $(VOID) && false || true - ./datagen | $(LZ4) -df > $(VOID) + ! ./datagen | $(LZ4) -d > $(VOID) + ./datagen | $(LZ4) -df > $(VOID) @echo "Hello World !" > tmp1 $(LZ4) -dcf tmp1 @echo "from underground..." > tmp2 $(LZ4) -dcfm tmp1 tmp2 @echo "\n ---- test cli ----" - $(LZ4) file-does-not-exist && false || true - $(LZ4) -f file-does-not-exist && false || true - $(LZ4) -fm file1-dne file2-dne && false || true - $(LZ4) -fm file1-dne file2-dne && false || true + ! $(LZ4) file-does-not-exist + ! $(LZ4) -f file-does-not-exist + ! $(LZ4) -fm file1-dne file2-dne + ! $(LZ4) -fm file1-dne file2-dne test-lz4-opt-parser: lz4 datagen @echo "\n ---- test opt-parser ----" |