| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
g++-4.4 creates the following warning for this line.
```
g++-4.4 -Wno-deprecated -O3 -Wall -Wextra -Wundef -Wshadow -Wcast-align -Werror -I../lib -I../programs -DXXH_NAMESPACE=LZ4_ lz4frame.o lz4.o lz4hc.o xxhash.o checkFrame.c -o checkFrame
checkFrame.c: In function ‘int frameCheck(cRess_t, FILE*, unsigned int, size_t)’:
checkFrame.c:156: error: comparison between signed and unsigned integer expressions
```
|
|\
| |
| | |
Fix NULL ptr arithmetic in lz4.c
|
| | |
|
| |
| |
| |
| | |
only do arithmetic if offset > 0
|
| |\
| |/
|/| |
|
|\ \
| | |
| | | |
Disable Meson + clang build at travis-ci
|
| | | |
|
|\ \ \
| | | |
| | | | |
Add GitHub Actions script ci.yml
|
| | | |
| | | |
| | | |
| | | | |
We must enable this test when all make usan errors will be resolved properly.
|
| | | | |
|
|\ \ \ \
| |_|/ /
|/| | | |
fix UB of lz4frame:907
|
| | | |
| | | |
| | | |
| | | |
| | | | |
ensure `dictBase` is only used
when there is an actual dictionary content.
|
| | |/
| |/|
| | |
| | | |
was blindly adding an offset (0) to `dictionary` which could be `NULL`.
|
|/ /
| |
| |
| |
| |
| | |
now line 912
by ensuring pointer arithmetic is only performed
if there is a reason for an internal buffer to be used.
|
|\ \
| | |
| | | |
Fix 'make usan'
|
| |/
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The following command doesn't work as intended
```
cd
git clone https://github.com/lz4/lz4.git
cd lz4
make usan MOREFLAGS='-Wcomma -Werror'
```
```
Cleaning completed
cc: error: unrecognized command line option ‘-Wcomma’; did you mean ‘-Wcomment’?
make[3]: *** [<builtin>: ../lib/lz4.o] Error 1
make[2]: *** [Makefile:65: lz4] Error 2
make[1]: *** [Makefile:133: test] Error 2
make: *** [Makefile:158: usan] Error 2
```
Because the following part of the `Makefile` doesn't propagate `CC`, `CFLAGS` and `LDFLAGS` to child `$(MAKE)` properly.
```
.PHONY: usan
usan: CC = clang
usan: CFLAGS = -O3 -g -fsanitize=undefined -fno-sanitize-recover=undefined -fsanitize-recover=pointer-overflow
usan: LDFLAGS = $(CFLAGS)
usan: clean
$(MAKE) test FUZZER_TIME="-T30s" NB_LOOPS=-i1
```
We need explicit propagation for child process
```
- $(MAKE) test FUZZER_TIME="-T30s" NB_LOOPS=-i1
+ CC=$(CC) CFLAGS=$(CFLAGS) LDFLAGS=$(LDFLAGS) $(MAKE) test FUZZER_TIME="-T30s" NB_LOOPS=-i1
```
After that, `make usan` works and it shows expected runtime error.
```
$ make usan MOREFLAGS='-Wcomma -Werror'
Cleaning completed
../lib/lz4frame.c:907:25: runtime error: applying non-zero offset 65536 to null pointer
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior ../lib/lz4frame.c:907:25 in
../lib/lz4frame.c:907:58: runtime error: applying zero offset to null pointer
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior ../lib/lz4frame.c:907:58 in
...
```
Please note that `make usan` is working at travis-ci. Because `.travis.yml` has the following [explicit `compiler:` setting](https://github.com/lz4/lz4/blob/7a966c1511816b53ac93aa2f2a2ff97e036a4a60/.travis.yml#L66).
```
- name: (Trusty) USan test
dist: trusty
compiler: clang
script:
- make usan MOREFLAGS=-Wcomma -Werror
```
|
|\ \
| |/
|/| |
Fix -Wshorten-64-to-32 warning
|
|/ |
|
|\
| |
| | |
Fix potential memory corruption with negative memmove() size
|
| | |
|
| | |
|
|\ \
| |/
|/| |
Avoiding null pointer dereference
|
|/ |
|
|\
| |
| | |
Update .cirrus.yml
|
|/
|
| |
current up-to-date stable branch is 12.2
|
|\
| |
| | |
Don't trigger UBSan warning in LZ4_resetStreamHC_fast if LZ4_streamHC…
|
| |
| |
| |
| | |
LZ4_streamHCPtr->internal_donotuse.end is NULL.
|
|\ \
| | |
| | | |
Update snapcraft.yaml to reflect latest build
|
|/ / |
|
|\ \
| |/
|/| |
fix some typos (work by Andrea Gelmini)
|
|/ |
|
|\
| |
| | |
Add include locations for x64 builds as well
|
|/ |
|
|\
| |
| | |
Makefile correctly export CFLAGS
|
| |
| |
| |
| | |
initialization and conversion
|
| |
| |
| |
| | |
so now, `%p` _requires_ a `void*` pointer ?
|
| | |
|
| |
| |
| |
| | |
seems to require explicit environment variables
|
| | |
|
| |\
| |/
|/|
| | |
remove `LN_S`
|
|\ \
| | |
| | | |
install links over existing install
|
|/ /
| |
| |
| | |
ensures links are created
|
|/
|
|
|
| |
remove usage of include Makefile.inc in too Makefile
as it seems to somehow unexport CFLAGS ...
|
| |
|
| |
|
|\
| |
| | |
Remove accidentally committed temporary files
|
| | |
|
|/ |
|
| |
|
| |
|