From 8745638d7c04bdfc33bcf656ed262c2588534db5 Mon Sep 17 00:00:00 2001 From: Jennifer Liu Date: Tue, 26 Jun 2018 17:53:12 -0700 Subject: Fixed invalid argument test and reformatted else --- programs/lz4cli.c | 3 +-- tests/Makefile | 4 ++-- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/programs/lz4cli.c b/programs/lz4cli.c index 669b585..dc60b00 100644 --- a/programs/lz4cli.c +++ b/programs/lz4cli.c @@ -385,8 +385,7 @@ int main(int argc, const char** argv) fastLevel = readU32FromChar(&argument); if (fastLevel) { cLevel = -(int)fastLevel; - } - else { + } else { badusage(exeName); } } else if (*argument != 0) { diff --git a/tests/Makefile b/tests/Makefile index abaf648..0e7924a 100644 --- a/tests/Makefile +++ b/tests/Makefile @@ -268,8 +268,8 @@ test-lz4-basic: lz4 datagen unlz4 lz4cat test "$(shell ./datagen -g20KB | $(LZ4) -c --fast=1 | wc -c)" -eq "$(shell ./datagen -g20KB| $(LZ4) -c --fast| wc -c)" # checks default fast compression is -1 test "$(shell ./datagen -g20KB | $(LZ4) -c -3 | wc -c)" -lt "$(shell ./datagen -g20KB| $(LZ4) -c --fast=1 | wc -c)" # 3 vs -1 test "$(shell ./datagen -g20KB | $(LZ4) -c -1 | wc -c)" -lt "$(shell ./datagen -g20KB| $(LZ4) -c --fast=2 | wc -c)" # 1 vs -2 - test "$(shell $(LZ4) -c --fast=0 tmp-tlb-dg20k | wc -c)" -eq 0 # lz4 should fail when fast=0 - test "$(shell $(LZ4) -c --fast=-1 tmp-tlb-dg20k | wc -c)" -eq 0 # lz4 should fail when fast=-1 + ! $(LZ4) -c --fast=0 tmp-tlb-dg20K # lz4 should fail when fast=0 + ! $(LZ4) -c --fast=-1 tmp-tlb-dg20K # lz4 should fail when fast=-1 @$(RM) tmp-tlb* -- cgit v0.12