diff options
| author | jan.nijtmans <nijtmans@users.sourceforge.net> | 2023-04-29 14:56:13 (GMT) |
|---|---|---|
| committer | jan.nijtmans <nijtmans@users.sourceforge.net> | 2023-04-29 14:56:13 (GMT) |
| commit | ef51b5aacdb05bb3e9120129f0c50ae3b31bf915 (patch) | |
| tree | 094460499663c8a111a7aab0f09c9aa72e668732 | |
| parent | 905633199cd68f24f41e7616ca8c831feaa8427c (diff) | |
| download | tcl-ef51b5aacdb05bb3e9120129f0c50ae3b31bf915.zip tcl-ef51b5aacdb05bb3e9120129f0c50ae3b31bf915.tar.gz tcl-ef51b5aacdb05bb3e9120129f0c50ae3b31bf915.tar.bz2 | |
Resolve a TODO
| -rw-r--r-- | generic/tclBasic.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/generic/tclBasic.c b/generic/tclBasic.c index 686cf62..1b4bca1 100644 --- a/generic/tclBasic.c +++ b/generic/tclBasic.c @@ -3298,7 +3298,11 @@ invokeObj2Command( Command *cmdPtr = (Command *) clientData; if (objc > INT_MAX) { - objc = TCL_INDEX_NONE; /* TODO - why? Should error, not truncate */ + /* Since TCL_INDEX_NONE is an invalid value for objc, + * calling cmdPtr->objProc or cmdPtr->nreProc will + * eventually result in a Tcl_WrongNumArgs() call. + * That's exactly what we want to happen. */ + objc = TCL_INDEX_NONE; } if (cmdPtr->objProc != NULL) { result = cmdPtr->objProc(cmdPtr->objClientData, interp, objc, objv); |